wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-27 21:42:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
12339 commits 15 branches 17 tags 192 MiB
Commit graph

9740 commits

Author SHA1 Message Date
jenkins-bot c253bfbd5a Merge "Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields" 2016-04-08 16:39:50 +00:00
Translation updater bot a7b2938f0e Localisation updates from https://translatewiki.net. 
Change-Id: I67966efc3392f3d2133c0442aad699406bba0c00
 2016-04-07 23:05:28 +02:00
Translation updater bot f9487af27a Localisation updates from https://translatewiki.net. 
Change-Id: Iaded10f066d638b38240ff8572e4abb326d42302
 2016-04-06 23:16:05 +02:00
Alex Monk 978224f2ec Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields 
* Use TitleInputWidget for wiki-page-name and wiki-template-name parameters
* Use UserInputWidget for wiki-user-name parameters
* Use a custom hacky CheckboxInputWidget child class for boolean parameters
* Borrow some ve.ui.MWExternalLinkAnnotationWidget.prototype.createInputWidget code for url parameters
* Use a TextInputWidget with multiline disabled for line parameters

Not dealt with in this commit, so fallback to existing behaviour:
* string
* number
* unknown
* content
* unbalanced-wikitext
* date
* wiki-file-name

Bug: T55613
Bug: T124734
Bug: T124736
Change-Id: If04944d64303d959e8dd605e75a175895932b788
Depends-On: I87699a93ca1b34c6d248456fcc060f584623d158
Depends-On: I5e97604f0fc24176d5e89899bf0505dc442a1a7e
 2016-04-06 22:07:19 +01:00
Translation updater bot 5f58ba4bf5 Localisation updates from https://translatewiki.net. 
Change-Id: I21bc9c165d900adb4223887846c898e702ac40df
 2016-04-05 23:01:17 +02:00
jenkins-bot 597a095a64 Merge "Ensure veswitched is not set when we set wteswitched in the URI" 2016-04-05 15:51:33 +00:00
jenkins-bot f9c95cd820 Merge "Fix up mw.libs.ve.EditingTabDialog.prototype.getActionProcess" 2016-04-05 15:41:28 +00:00
Alex Monk 373a19f1cc Ensure veswitched is not set when we set wteswitched in the URI 
veswitched and wteswitched together cannot result in any sane behaviour.

To reproduce:
* Open VE (while having multi-tab pref?), switch into WTE
* Make a change
* Switch into VE

Change-Id: I90e19169e3fab60ab876c8e4d349801309db262f
 2016-04-05 01:27:37 +01:00
Alex Monk f67b578c3f Fix up mw.libs.ve.EditingTabDialog.prototype.getActionProcess 
How did this ever work?

Ensure action is passed through and not just undefined, wait for change to go
through before refreshing.

Bug: T131818
Change-Id: I83b5695906044299d338e62e6c980c596d291765
 2016-04-04 23:57:46 +01:00
Translation updater bot 2ff6fd5b9b Localisation updates from https://translatewiki.net. 
Change-Id: I39ddf914192ccdd0d41708303eb9fb153329c1ba
 2016-04-04 22:13:20 +02:00
Antoine Musso 4a97e9585f [BrowserTest] Fix i18n files lookup 
The visual_editor_page used relative paths expecting the current
directory to be modules/ve-mw/tests/browser. Use absolute paths instead.

Change-Id: I8b1c4eddc2085ee80380f288bceb14c6feee0a60
 2016-04-04 11:52:36 +02:00
Translation updater bot 286f489a6d Localisation updates from https://translatewiki.net. 
Change-Id: Iaef135e32858ff9562fba4a1fe56558fc13ba893
 2016-04-03 23:25:01 +02:00
jenkins-bot 12aefcc213 Merge "After saving and setting HTML, set single-editor edit section handlers again" 2016-04-02 18:32:46 +00:00
Roan Kattouw 8e69dfa3b8 ArticleTarget: Correct comment explaining where setAssumeExistence( false ); is called 
Change-Id: Ib883ea1fe57fe6cb3e182965a18eb3fb50246178
 2016-04-02 20:28:44 +03:00
jenkins-bot 65ee77da50 Merge "MWExternalLinkAnnotation: Only match plain external <a>s with hrefs" 2016-04-02 16:05:36 +00:00
Ed Sanders 6fad9ecdee MWExternalLinkAnnotation: Only match plain external <a>s with hrefs 
We now accept non-Parsoid generated external links from paste,
so make sure they have href attributes otherwise they aren't
really external links and will throw exceptions later on.

Bug: T131430
Change-Id: Ifb565b1ce30cfe80ae72b17f6a9551ea40b36453
 2016-04-02 18:51:56 +03:00
jenkins-bot aa5f992159 Merge "MWExtensionNode#generateContents: Fix renderEmpty logic" 2016-04-02 09:31:07 +00:00
Tpt 8ccbb58ca6 MWExtensionNode#generateContents: Fix renderEmpty logic 
This static attribute is not used anywhere so it should be safe

Change-Id: I633c521859b59614835344a4644560ac933c6028
 2016-04-02 07:58:33 +00:00
Alex Monk 7788aece55 After saving and setting HTML, set single-editor edit section handlers again 
Change-Id: I6e0962271e7e1460abbe82864b47fddc5bd7f235
 2016-04-02 09:53:25 +03:00
Translation updater bot 6b4dcefcf2 Localisation updates from https://translatewiki.net. 
Change-Id: I520bd24cc795d85ab66e2d623d77b7141d0188ab
 2016-04-01 22:30:49 +02:00
Roan Kattouw f6ba399137 Fix asynchronous loading of MWAlienExtensionNode renderings 
ve.dm.MWExtensionNode#toDataElement calls storeGeneratedContents()
which prepopulates the cache, but because it was being called with
the wrong context, this.name was null and so the key we were storing
it under was different from the key we'd later be looking for.

Fixed by ensuring ve.dm.MWAlienExtensionNode#toDataElement preserves
context when calling its parent. Our static context hacks are tricky.

Change-Id: If859d861453067d7656a33a1767f6efc7bd9d323
 2016-04-01 12:50:13 +03:00
Translation updater bot 1ad77ddf91 Localisation updates from https://translatewiki.net. 
Change-Id: Ic552bb2a2a87252033cc9f6ab57ff9545f6686b5
 2016-03-31 22:47:29 +02:00
jenkins-bot 2449ce203d Merge "Use veaction=edit in URL instead of action=edit when we're using multiple tabs" 2016-03-31 15:42:40 +00:00
Translation updater bot db5741d061 Localisation updates from https://translatewiki.net. 
Change-Id: Ib60a84f5f2dd85ed5b2f9dd89b8eb64402e8a2d6
 2016-03-30 22:43:22 +02:00
Alex Monk 4210c4bee0 Use veaction=edit in URL instead of action=edit when we're using multiple tabs 
TODO: What about prefer-wt users switching from WTE?

Bug: T131064
Change-Id: I9aa701cbda3964decb8b1ee853c0a281567a0ccb
 2016-03-30 02:54:01 +01:00
jenkins-bot 4dadaa677c Merge "MWWikitextStringTransferHandler: Add test for autoGenerated=true" 2016-03-29 22:01:39 +00:00
jenkins-bot f5f97adbe4 Merge "MWWikitextStringTransferHandler: Factor out body tag from response" 2016-03-29 21:42:09 +00:00
jenkins-bot b44cee5557 Merge "MWWikitextStringTransferHandler: Remove data-parsoid from tests" 2016-03-29 21:39:07 +00:00
Translation updater bot f753a46fa1 Localisation updates from https://translatewiki.net. 
Change-Id: I840ba9e9d5c3eaed4837cabbd5fbf35c1079150e
 2016-03-29 22:40:33 +02:00
Ed Sanders 18df6c3d47 MWWikitextStringTransferHandler: Add test for autoGenerated=true 
Bug: T131153
Change-Id: I4922abe7978e1f04eb2276214c761622b44149c7
 2016-03-29 19:57:45 +00:00
Ed Sanders b51b512555 MWWikitextStringTransferHandler: Factor out body tag from response 
Change-Id: Ic694d1099538d2c60900d490667f2175f7f3afb3
 2016-03-29 19:57:36 +00:00
Ed Sanders 818931dd9e MWWikitextStringTransferHandler: Remove data-parsoid from tests 
It is ignored by VE, and isn't present in restbase responses.

Change-Id: Iaa2a6a66ba76ca0d63b4d6791ab8589191bce0f2
 2016-03-29 19:57:26 +00:00
jenkins-bot 0242dedff9 Merge "Filter out auto-generated reference lists" 2016-03-29 19:37:35 +00:00
jenkins-bot 18533b47fa Merge "Toolbar: Add tooltips to structure and insert groups" 2016-03-29 17:15:51 +00:00
jenkins-bot 29af9b54b6 Merge "MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more" 2016-03-29 16:52:31 +00:00
jenkins-bot 190c64ed69 Merge "Select tool when it's been closed by education tool popup button" 2016-03-29 16:42:38 +00:00
jenkins-bot b9643881d9 Merge "Remove icon properties from windows" 2016-03-29 16:37:22 +00:00
Alex Monk 0760cd6974 Select tool when it's been closed by education tool popup button 
Bug: T117273
Change-Id: I54b704b6663f7d862557e6524713259dee8765cc
 2016-03-29 15:54:22 +01:00
Ed Sanders 9a347220bc Target loading: Only parse oldid if it is non-null 
This un-breaks MobileFrontend.

Change-Id: Ib1bce6b80abb004ff4ca26920759ef98f3cd1143
 2016-03-29 12:57:00 +01:00
Ed Sanders c516d897d2 Remove icon properties from windows 
Windows stopped supporting icons a while ago.

Change-Id: I8a63152282a5968dcd17675330e31bd1ebe4b68b
 2016-03-29 12:33:42 +01:00
Ed Sanders 1d8d1c2a64 Toolbar: Add tooltips to structure and insert groups 
Bug: T131133
Change-Id: I927bf6f0d1de74b4ac8d16c3b5ce27720db322d4
 2016-03-29 12:08:22 +01:00
Translation updater bot d4d1f10b95 Localisation updates from https://translatewiki.net. 
Change-Id: Ifdc4b011bcb895ae3fa39a1fbe31b1640d1e56e4
 2016-03-28 22:46:52 +02:00
James D. Forrester a6477fb960 MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more 
Change-Id: Ib2f63d1626d8286c7dfd74227d09046a7d2af509
 2016-03-28 19:53:08 +00:00
jenkins-bot ff61173f90 Merge "MWLinkAnnotationInspector: select entire link when switching tabs" 2016-03-28 19:22:35 +00:00
Ed Sanders 681250dd5e Filter out auto-generated reference lists 
Bug: T101553
Bug: T127664
Change-Id: Idc8c6f30ccdd5eaf76a3f7c1b923d8656ca36413
Depends-On: I24250845e97acb4b7de9c495cb46dbd28fc8817e
 2016-03-28 17:23:42 +00:00
David Lynch d33f5969ad MWLinkAnnotationInspector: select entire link when switching tabs 
Bug: T129650
Change-Id: I4ca445f2c43438c36ece23245660b63f2a48b722
 2016-03-28 11:38:45 -05:00
James D. Forrester 0a23ec716d i18n: Drop another two references to the wikitext editor 
Change-Id: I89b727e880f40d6e82fb584beb4647aed6134e90
 2016-03-28 08:47:20 -07:00
Translation updater bot f239e17a1e Localisation updates from https://translatewiki.net. 
Change-Id: Ie585e9b5dd0251d35e90646f0ff79cc76cf66da8
 2016-03-27 21:25:48 +02:00
Thalia 003e02efaa MWAceEditorWidget: Update maxRows and minRows if minRows is changed 
This was being done correctly in initialize, but not in setMinRows.

Bug: T131009
Change-Id: I57c771720c59ca1d75f0b9bc14e7c834237019d5
 2016-03-27 17:42:11 +00:00
jenkins-bot ff65a71773 Merge "Template Dialog: pushPending while the dialog is closing" 2016-03-26 03:13:42 +00:00
jenkins-bot 068bafd9df Merge "ArticleTarget: Don't assume an explicit oldid is old; check against current" 2016-03-26 00:49:58 +00:00
Alex Monk 680e464e94 ArticleTarget: Don't assume an explicit oldid is old; check against current 
Bug: T130810
Change-Id: I3d5b748da37a0a059f282f97dd0d68d1846e2553
 2016-03-25 17:37:02 -07:00
jenkins-bot 35ea4b3e4e Merge "Don't strip namespace from text that we replace firstHeading with" 2016-03-25 22:43:41 +00:00
Alex Monk b1aebf0b48 Don't strip namespace from text that we replace firstHeading with 
wgTitle is basically just $title->getText()
wgPageName is $title->getPrefixedDBkey()

So we need to take wgPageName and run getPrefixedText (difference is underscores
get replaced by spaces)

Change-Id: Ib99f0d20f1ba99338f80bbbf39cffd544887c3fa
 2016-03-25 04:45:09 +00:00
Translation updater bot 8bf7d4ba07 Localisation updates from https://translatewiki.net. 
Change-Id: Ief4cec942df98bef1b43038fa14e0cb6403ea454
 2016-03-24 22:40:13 +01:00
David Lynch 0268e74a7f Template Dialog: pushPending while the dialog is closing 
Double-clicking the "insert" button would double-insert the template. Counting
the close as a pending action avoids that.

Bug: T129725
Change-Id: I41af7c051fd54004cecd563d7a6cf8fdb452840f
 2016-03-24 11:33:00 -05:00
Translation updater bot 3028f4f2d6 Localisation updates from https://translatewiki.net. 
Change-Id: I7715d2d33b21e1a9d142a2be00a032fe83de4f75
 2016-03-23 22:25:43 +01:00
jenkins-bot 9b9ace9d03 Merge "Rename startSave -> onSaveDialogSave" 2016-03-23 19:48:06 +00:00
jenkins-bot 52c862b5af Merge "Make data-mw/body.html attribute comparable" 2016-03-23 19:20:40 +00:00
Ed Sanders 5e4ad90845 Rename startSave -> onSaveDialogSave 
Factor out actual startSave into new startSave method.

Change-Id: I73edb5021903f04aa197ace2a2afa3aa3a5ddac6
 2016-03-23 11:14:06 +00:00
Ed Sanders 6a159001ab Make data-mw/body.html attribute comparable 
Change-Id: Ie23c5816a18f4da84c3d40c13a8c048710389f4b
 2016-03-23 11:03:53 +00:00
Alex Monk 2063025237 Don't change focus to VE surface if we're opening the SET dialog 
Bug: T130552
Change-Id: Idc4639bb3f51690a827bdbdb0419e9303dd39a1b
 2016-03-23 01:08:32 +00:00
Translation updater bot 0f6bdb9071 Localisation updates from https://translatewiki.net. 
Change-Id: I994551c7973f274b4791d23c89fd808038df14da
 2016-03-22 22:34:47 +01:00
Ed Sanders fd3683e414 Update VE core submodule to master (d1ce123) 
New changes:
6cf8864 Follow-up eb97c1f: Fix build for added language 'inh'
d1ce123 SpecialCharacterDialog: Use getReadyProcess promise to wait for char list

Local changes:
* SpecialCharacterDialog: Defer loading of character list.
  Saves ~40k for most users who never use it.

Change-Id: I74b30fee96e1ae4463ed28c19bef4b515330220e
Depends-On: I45dc9f788aa5bd702b91ffd9f63b05b1f4760691
 2016-03-22 09:15:23 -07:00
James D. Forrester 7df0e7589e Update VE core submodule to master (eb97c1f) 
New changes:
e661245 Localisation updates from https://translatewiki.net.
d0bac53 ElementLinearData: Add test for sanitize conversions
53988e4 ElementLinearData: Test blacklist unwrapping
8593098 ve.dm.Model: Remove unused, untested method 'hasAttributes'
6247dd2 ce.Surface: Add tests for table strip delete
bee1851 ce.Surface: Add larger table strip-delete test
42d39e7 ce.Surface: Test table navigation with enter/escape/tab/shift-tab
5d248f9 Remove TableCaptionCommand
a86ad04 PreviewElement: Check node is a GCN, and always return a boolean
b518839 Localisation updates from https://translatewiki.net.
8834e9c ce.Surface: Allow any key code in the key handler tests
6b3ea6a ce.Surface: Linear arrow tests for block node
026999d Localisation updates from https://translatewiki.net.
eb97c1f Localisation updates from https://translatewiki.net.

Change-Id: Ic5853116d97623316d9a6bbacda2ecab9e4b49d5
 2016-03-22 15:12:36 +00:00
Translation updater bot b6662a697d Localisation updates from https://translatewiki.net. 
Change-Id: I111db7bda332fc853e50d2d5cd029389a01676e8
 2016-03-21 23:37:06 +01:00
Translation updater bot eed6125ef2 Localisation updates from https://translatewiki.net. 
Change-Id: I197104b10bb7aa062030a6cf22975283dbe42d28
 2016-03-20 22:43:49 +01:00
Translation updater bot c450fdd332 Localisation updates from https://translatewiki.net. 
Change-Id: I2425ab6952f0890671132342acfa0308cf286882
 2016-03-19 22:55:27 +01:00
Translation updater bot c37a2d11f7 Localisation updates from https://translatewiki.net. 
Change-Id: Ia9b65fcfe6117d2075483bd130900c51b787eddc
 2016-03-18 22:45:18 +01:00
jenkins-bot 4e4684e7d0 Merge "Show redirect target inside target" 2016-03-17 22:54:39 +00:00
Translation updater bot d036f04573 Localisation updates from https://translatewiki.net. 
Change-Id: I30e95352b17b75c8eb8dba54a4007238c28b1c63
 2016-03-17 23:23:48 +01:00
Ed Sanders b7d25d92bc Detect the type of plain pasted links 
Using the same logic we used for converting pasted URLs, detect
internal links by matching their base.

Currently link pasting is still disabled in the VE target, but
has been enabled elsewhere (Flow).

Change-Id: Iebd61abbe1fe82fd18d129e1dbc815ca75f44e87
 2016-03-17 19:30:13 +00:00
jenkins-bot d5ef085b3e Merge "Link pasting: Match RDFa-less links as external" 2016-03-17 17:45:52 +00:00
Ed Sanders 5e6cbc187c Link pasting: Match RDFa-less links as external 
Now that some targets support link pasting (Flow) we need to
make sure that pasted links match to an allowed type ('link/mwExternal')
instead of plain 'link' annotations which should never exist
in an MW document.

In a later commit we should auto-detect internal links.

Change-Id: I7faae834aa6e730c3cf93a691331a05fd0fe3d5c
 2016-03-17 17:18:41 +00:00
jenkins-bot 1c27e5d51a Merge "In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId" 2016-03-17 15:39:12 +00:00
jenkins-bot 33c9055fdc Merge "Reload page after user selects multi-tab option of SET dialog" 2016-03-17 15:39:09 +00:00
Alex Monk 3288d4e3f9 Show redirect target inside target 
Bug: T63861
Depends-On: I71d3d415fe918e8b0a090860cad9271092b1bd7e
Change-Id: I5a138b95e04773885ca9ee548026729805eb11f0
 2016-03-17 15:21:06 +00:00
Translation updater bot 445a830d52 Localisation updates from https://translatewiki.net. 
Change-Id: I2764438c78e674d492157f55fb15ae82ed114b36
 2016-03-15 23:06:07 +01:00
Ed Sanders dec9aa09e4 Use keyboard icon for keyboard help tool 
Change-Id: Id5e5097dfcdb5e3be2b21c89886857cb379997e6
 2016-03-15 17:28:48 +00:00
Alex Monk 02953f5d64 Suppress meta dialog on refresh pages if we want to show SET dialog 
Bug: T129819
Change-Id: I1176d06e5a5f56f01528acd7d099c8be9d317e51
 2016-03-15 08:10:46 +00:00
Translation updater bot af64cf7b12 Localisation updates from https://translatewiki.net. 
Change-Id: I85827c3e9262adf7bb6191ff68de688f744b613a
 2016-03-14 22:55:30 +01:00
jenkins-bot 53d3c62d46 Merge "CommandHelpDialog: Inherit non-corruptively" 2016-03-14 20:28:56 +00:00
Ed Sanders f5873ac1db CommandHelpDialog: Inherit non-corruptively 
Change-Id: Ieb497eebe930e58a02552eb9d4305280c91c92c2
 2016-03-14 20:03:52 +00:00
Ed Sanders 5d5d5419c6 AceEditorWidget: Use namespaced 'require' 
The un-namespaced version will soon be removed to fix RL issues.

Bug: T127643
Change-Id: Iaf4ed23d88cb955b8f8f61725f9effa6180de5bf
 2016-03-14 16:56:16 +00:00
Željko Filipin 63eb2a2f46 [BrowserTest] Increase the time Selenium waits for VisualEditor to load 
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.

Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
 2016-03-14 13:00:17 +01:00
jenkins-bot 110c6eb057 Merge "[BrowserTest] Disable failing language screenshot scenario" 2016-03-14 11:33:53 +00:00
jenkins-bot 0cdf4393ed Merge "Prefer error *code* when logging unknown errors" 2016-03-14 01:01:48 +00:00
jenkins-bot 3a1f6a34c8 Merge "Log readonly code for readonly errors" 2016-03-14 01:00:47 +00:00
Alex Monk 612e43dc08 Prefer error *code* when logging unknown errors 
See also I4a5bac24

Change-Id: I62fda9dadd24704f5930b30a2f8ad4d4a9e729cb
 2016-03-14 00:27:42 +00:00
Translation updater bot 004247822d Localisation updates from https://translatewiki.net. 
Change-Id: I18e35f520e9b8dde3c96e6b2c3b740d1fb48c294
 2016-03-13 22:57:53 +01:00
jenkins-bot 1a0733c4f2 Merge "MWSaveDialog: Fix vertical alignment" 2016-03-13 11:43:17 +00:00
Translation updater bot 368953b808 Localisation updates from https://translatewiki.net. 
Change-Id: I1c34348e0ce6227d6a3e84a969271563b0e8a6d5
 2016-03-12 21:14:25 +01:00
Alex Monk 22bf016a84 In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId 
There's probably more to this bug but I think we should still correct this

Bug: T125437
Change-Id: Ib32d1e69b2500578b5dc160c0c2d7481f5577ebb
 2016-03-12 04:46:54 +00:00
Translation updater bot 7c8a2207d3 Localisation updates from https://translatewiki.net. 
Change-Id: Ifefb57f56a762c7fcb5cab0258d018be0e7c10eb
 2016-03-11 22:18:35 +01:00
Ed Sanders da9aff2421 MWSaveDialog: Fix vertical alignment 
Change-Id: Ifb62375da6c872a3a4ef783e479a5476ca318b32
 2016-03-11 17:37:01 +00:00
Alex Monk d1d4839f8f Log readonly code for readonly errors 
I thought I did this yesterday

Change-Id: Icd2cf8fdf4263cab335a2ddfa53ab0585153dfb4
 2016-03-11 17:33:57 +00:00
Alex Monk 3807a918f9 Reload page after user selects multi-tab option of SET dialog 
Bug: T129510
Change-Id: I3fcac175f18d8159e6a5c4084668264d4705970c
 2016-03-11 05:39:29 +00:00
Translation updater bot 55a6cd08b2 Merge "Localisation updates from https://translatewiki.net." 2016-03-10 21:33:52 +00:00
Translation updater bot 3aac2043a4 Localisation updates from https://translatewiki.net. 
Change-Id: Ia3db1d0b33d4bdbde66452bcf33a7b0b0e4da5bb
 2016-03-10 22:31:26 +01:00
jenkins-bot d6ec1ed86f Merge "Fix logging of event_action.saveFailure.message for responseUnknown" 2016-03-10 21:22:37 +00:00
jenkins-bot ad7c364725 Merge "Better handling of read-only mode" 2016-03-10 21:22:34 +00:00
Alex Monk 0a6f6e1bbd Fix logging of event_action.saveFailure.message for responseUnknown 
Change-Id: Ic8d3066d8f6ccf8bc4a1001fd4d406b313915e82
 2016-03-10 21:03:25 +00:00
Alex Monk d2a9aefba7 Better handling of read-only mode 
* Don't just fail to load, action=visualeditor itself should not write to the DB
  (we have action=visualeditoredit for that)
* Send notice to the client in the usual way
* Handle read only errors on save, log as unknown

This won't let you review changes because that uses visualeditoredit

Bug: T129501
Change-Id: Id78c06b031423e47a7ddf94ec615b6d6975309d3
 2016-03-10 21:02:52 +00:00
jenkins-bot 3eaaf57847 Merge "Suppress welcome dialog this time if we're showing the SET pref dialog" 2016-03-10 20:38:39 +00:00
Alex Monk 4462f2539a Suppress welcome dialog this time if we're showing the SET pref dialog 
Bug: T129200
Change-Id: Iaa6d80df930cfcbd243efd31437cb8707da35c06
 2016-03-10 17:54:15 +00:00
Željko Filipin 43e9c8714f [BrowserTest] Disable failing language screenshot scenario 
VisualEditor_Insert_Menu scenario fails with `Original image height is
too small! (ChunkyPNG::OutOfBounds)`.

Bug: T119482
Change-Id: I30c3a9757c5754a40921fce5225b73897eed865b
 2016-03-10 15:06:56 +01:00
Translation updater bot d36a099939 Localisation updates from https://translatewiki.net. 
Change-Id: I32293b4f2532d15e65b71f09e53ac9c2e8817356
 2016-03-09 22:48:24 +01:00
jenkins-bot 2e89f4f658 Merge "[BrowserTest] Disable failing language screenshots" 2016-03-09 17:32:57 +00:00
jenkins-bot 67fb8dd07f Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError" 2016-03-09 17:31:27 +00:00
Timo Tijhof cf1d7c0dab mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined" 
Regression from 863a2c2974.

Sometimes when clicking "Switch to source mode" in the toolbar this
error is thrown and the interface freezes because setEditorPreference()
only returns a promise if the value is different.

> Uncaught TypeError: Cannot read property 'done' of undefined
> - ve.init.mw.DesktopArticleTarget.switchToWikitextEditor

Change-Id: Ie59f06a8ed9af9c4fb8199b013c06992d0c4f700
 2016-03-08 23:13:11 +00:00
Translation updater bot d8a9a11ca7 Localisation updates from https://translatewiki.net. 
Change-Id: Ia668efdeff27d984848c2bca823bf41d370706f9
 2016-03-08 22:46:51 +01:00
Ed Sanders d5e594b9f6 Link inspector: Remove premature call to onLinkTypeIndexSet 
This causes the inspector to take focus early (line 291) on
first load, and is not necessary as this method fires when
needed anyway.

Bug: T129228
Change-Id: Ia69f76b68e89daf5cb01449c40e71de4ec32d400
 2016-03-08 16:54:09 +00:00
jenkins-bot 7261cf5364 Merge "Link inspector: make height consistent" 2016-03-08 16:50:02 +00:00
Ed Sanders 7f31507e12 Link inspector: make height consistent 
Make the DOM order sensible so we don't have to
use SearchWidget's position:absolute hacks.

Bug: T129173
Change-Id: I3517e0e0cfe2ab0eee4bed7390e41710d3140eb0
 2016-03-08 10:26:31 +00:00
James D. Forrester 80139533ab i18n: Don't refer to the name of the tab in the beta notice given it changes 
Change-Id: I9beb322aeabece0df483271b33dbaa41f5da732a
 2016-03-07 16:58:32 -08:00
James D. Forrester b247ffd7bd i18n: Explain to returning users that their preferences are mutable 
Change-Id: I8a47725d7271af54b30f2130e97b08edec0f0b59
 2016-03-07 16:56:13 -08:00
James D. Forrester 9a6650ae1f i18n: Relabel the SET preference and dialog to 'mode' 
Change-Id: Id876f4ba102800237cbc4a671d4db9a26f7f116d
 2016-03-07 15:51:19 -08:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
jenkins-bot 7a5f34fac3 Merge "Education popup: Also handle clicks on dots" 2016-03-07 23:28:55 +00:00
jenkins-bot 39f3cfa4a7 Merge "Keep summary and checkbox selections when swtiching WTE->VE" 2016-03-07 23:17:08 +00:00
jenkins-bot 075f569e51 Merge "Update ArticleTarget for new API token handling" 2016-03-07 23:14:32 +00:00
jenkins-bot 6ed2d23b13 Merge "Don't give the user the option to discard changes when changing editor" 2016-03-07 23:14:29 +00:00
jenkins-bot 15f8efed70 Merge "DesktopArticleTarget.init#getLastEditor: Check values for validity" 2016-03-07 23:14:26 +00:00
James D. Forrester 79d1f92b42 DesktopArticleTarget: Add Edge and MSIE to whitelist 
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
 2016-03-07 14:58:10 -08:00
jenkins-bot 4d34f9ad75 Merge "Follow-up I65d96627: Remember the user's preference in WikiEditor too" 2016-03-07 22:31:54 +00:00
James D. Forrester d8eb68d7b6 Don't give the user the option to discard changes when changing editor 
Bug: T128585
Change-Id: I02f31e46ae7b2dc7505ed55fc56cd00f538a90e3
 2016-03-07 13:39:32 -08:00
Translation updater bot 98052e165d Localisation updates from https://translatewiki.net. 
Change-Id: I1e160b1149c6f0a5abb31ad51ba0a099de151a1f
 2016-03-07 22:27:34 +01:00
James D. Forrester b0407d840d Follow-up I65d96627: Remember the user's preference in WikiEditor too 
Oh dear.

Bug: T129130
Change-Id: I12481ded12f99ab1ba59dbd403c1eed038235fd9
 2016-03-07 13:03:35 -08:00
jenkins-bot 789979f223 Merge "Try to fix handling of empty document on WTE->VE switch" 2016-03-07 19:48:22 +00:00
James D. Forrester 302aeefd85 DesktopArticleTarget.init#getLastEditor: Check values for validity 
Change-Id: I23e0884a97b3689dd42c3df11a6311cd0601c348
 2016-03-07 11:27:23 -08:00
jenkins-bot fe19bfb0af Merge "Use iconWhenInvisible for alien extension nodes" 2016-03-07 18:34:38 +00:00
Ed Sanders bbf86a6768 Use iconWhenInvisible for alien extension nodes 
Change-Id: I0bc9bfd040685855402f705f46973e36c42dc0db
 2016-03-07 18:15:45 +00:00
jenkins-bot c930ac2779 Merge "Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry" 2016-03-07 16:32:13 +00:00
Translation updater bot 4dd9110c18 Localisation updates from https://translatewiki.net. 
Change-Id: I894adeef0ad09824fad0d3fff544ced1f7f3b1ae
 2016-03-06 22:18:45 +01:00
Ed Sanders 5cc10a810a Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry 
This allows extensions to register their own rules for detecting wikitext,
e.g. matching '<ref>'.

Bonus: Strip the autogenerated <references/> tag which
gets inserted when converting a <ref>.

Bug: T128805
Change-Id: I7a38db45d25e86ff3f3f6199aa04425ec98f7cc4
 2016-03-05 22:47:00 +00:00
Translation updater bot bcb8aed482 Localisation updates from https://translatewiki.net. 
Change-Id: Icffb9dc8b7f78d2debad38046ba42ea678b969ae
 2016-03-05 23:01:12 +01:00
Ricordisamoa 993015e03b Update ArticleTarget for new API token handling 
action=query&prop=info was being used because it can be combined
with action=query&meta=userinfo, while action=tokens cannot.

However, since MediaWiki 1.24 the 'intoken' parameter of
action=query&prop=info is deprecated, while the preferred way of
retrieving tokens is action=query&meta=tokens which not only can
be combined with action=query&meta=userinfo but also spares the
need of dealing with page ids.

Change-Id: I5ded3c303ede20514eeb2840715fe240b3b2c7e1
 2016-03-05 14:44:07 +01:00
jenkins-bot ea11c33e6d Merge "Handle API errors when refetching the edit token" 2016-03-05 02:16:32 +00:00
Roan Kattouw 6322be2e07 Handle API errors when refetching the edit token 
This can happen when the user gets logged out on a private wiki.
We get a badtoken error, so we try to refetch the token, which
itself returns an error. Token refetches didn't have error handling
at all and got the save dialog stuck in the pending state.

We can't offer the user to proceed with a different identity here,
because we encountered an error while trying to figure out what their
current identity is. The best we can do is encourage them to
log back in in a different tab.

Bug: T128934
Change-Id: I17d4452f688ec22631dbd12af223731635004d66
 2016-03-04 18:06:33 -08:00
jenkins-bot 074885d7cf Merge "Follow-up 2c24efae: fix typo in event name for unknown save errors" 2016-03-05 02:01:57 +00:00
Roan Kattouw 84d534997e Follow-up 2c24efae: fix typo in event name for unknown save errors 
This probably means we stopped logging unknown save errors
back in August.

Change-Id: I4a5bac244a469e73643e8a7d978d9212dd838fb0
 2016-03-04 17:31:40 -08:00
Translation updater bot 0d94d8312d Localisation updates from https://translatewiki.net. 
Change-Id: I92baebf577ce098877cff730f2ff8de4974f79b2
 2016-03-04 22:56:47 +01:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots 
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
 2016-03-04 15:54:13 +01:00
Alex Monk dde45949a3 Try to fix handling of empty document on WTE->VE switch 
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
 2016-03-04 02:05:41 +00:00
Ed Sanders 67c207a6f5 Use abstract target widget creation 
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
 2016-03-03 11:49:44 -08:00
Ed Sanders d64436cc0c Use new surface executeCommand method 
Change-Id: I84c718d9da4b7dd0627ba37d9c29c3a25cc5d73e
Depends-On: Id975ea9da43654cd9991a302b49a9fb32782078e
 2016-03-03 11:49:44 -08:00
Ed Sanders 62d16e5a8a Update VE core submodule to master (ac24b50) 
New changes:
0b7e689 FindAndReplaceDialog: don't use tabindex
17b10a5 Localisation updates from https://translatewiki.net.
a4133e4 [BREAKING CHANGE] Make whitespaceHtmlCharacters a real static property

Local changes:
* MWEntityNode: Fix lookup of whitespaceHtmlCharacters

  Property is now in 'static', and use registry to look up
  TextNode by symbolic name.

Change-Id: Ied8c0c6feb69141c7c53fc4cc790774dee2cb63c
Depends-On: I7537b46a9fd58dfb2bd18dc4ed469aa221b96e86
 2016-03-03 08:13:33 -08:00
Ed Sanders 115bf4b3d2 CategoryWidget: Remove reorder event fix after upstream fix 
Change-Id: I9088c931433b0824f72b4c77d0fd05cb062068f7
Depends-On: I67945db3652b0edb24b490089b8ea5a43f0b29d0
 2016-03-03 15:53:49 +00:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError 
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
 2016-03-03 14:58:14 +00:00
jenkins-bot 659b9c3576 Merge "[BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages" 2016-03-02 23:33:32 +00:00
Translation updater bot 61cda9824f Localisation updates from https://translatewiki.net. 
Change-Id: Ife76752d154e4b595a570e8c8fefed114362dc9f
 2016-03-02 23:40:57 +01:00
Alex Monk a3f77d9479 Education popup: Also handle clicks on dots 
Bug: T128440
Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
 2016-03-02 21:48:05 +00:00
Alex Monk 4ed6fd4010 Change Accept header a bit 
Per post-merge commit on I77af4b58 by Subbu

Bug: T128233
Change-Id: I30c4c1ad5b68e5b8a006d7a6c7bcbaac7e2eb164
 2016-03-02 15:37:37 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages 
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
 2016-03-02 13:50:44 +01:00
Alex Monk 21334a0fa8 Keep summary and checkbox selections when swtiching WTE->VE 
Bug: T128529
Change-Id: I8a7deac1c4d9390c1db7d78c3e0a11d927ef127b
 2016-03-02 11:55:50 +00:00
Ed Sanders d94d98ebfe ArticleTarget: Update documentation 
'onReady' no longer exists

Change-Id: I6fbcf619ba471f69380a64ba02994bd6ef0ca246
 2016-03-01 22:03:07 +00:00
jenkins-bot 7d1ddae652 Merge "MWTemplateSpecModel: Use namespace constant" 2016-03-01 21:56:51 +00:00
jenkins-bot 1619ca17aa Merge "MWTemplatePage: Don't assume template is the template namespace" 2016-03-01 21:51:19 +00:00
Ed Sanders 1e800f2fdf MWTemplateSpecModel: Use namespace constant 
Change-Id: I4404ee726550ca9aa9322720736f6f3778278df7
 2016-03-01 21:41:10 +00:00
Ed Sanders 5b17cbca67 MWTemplatePage: Don't assume template is the template namespace 
Content can be transcluded from any namespace using '{{:'.

Bug: T128333
Change-Id: Ifa076960958d1e72f302c5bfd5d896427a0e721f
 2016-03-01 13:40:38 -08:00
Translation updater bot eceb548e6c Localisation updates from https://translatewiki.net. 
Change-Id: Id1453f111870ee703f552fa407dab76b19d786f5
 2016-03-01 22:04:45 +01:00
jenkins-bot a0caedc6d9 Merge "API: Send Accept: header to RESTbase" 2016-03-01 03:24:45 +00:00
Alex Monk 2f135e9590 API: Send Accept: header to RESTbase 
Bug: T128233
Change-Id: I77af4b58e5469a898063a3f838802e4f5769514b
 2016-03-01 01:14:02 +00:00
Alex Monk d46c5e9f91 Fix WTE->VE switching in prefer-wt SET mode 
Bug: T128402
Change-Id: I56af672f2334214f048a4bbfe2f9fab891832792
 2016-02-29 23:46:11 +00:00
David Lynch 7486f74c6f MWMediaDialog: Only cache relevant information 
Trim the cached image data from the media dialog down so that it only caches
the same information that would have been fetched for a non-uploaded image.
Consistency!

Bug: T126081
Change-Id: I0f057c111b66f29c6360e27f97256384f5320b75
 2016-02-29 10:16:34 -06:00
jenkins-bot e39d8a744b Merge "Show welcome dialog on mobile too" 2016-02-29 03:02:03 +00:00
jenkins-bot 517bb92a79 Merge "Give a useful message in the temporary blank edit screen" 2016-02-29 02:56:12 +00:00
Translation updater bot 7546362fa9 Localisation updates from https://translatewiki.net. 
Change-Id: I7bade8021975fc1c3e2426211e6805a913f07891
 2016-02-28 22:00:32 +01:00
jenkins-bot 70a9cee5f3 Merge "Update VE core submodule to master (0371bbe)" 2016-02-28 01:12:55 +00:00
jenkins-bot 03448253b3 Merge "Revert "Compress PNGs with zopflipng"" 2016-02-28 00:29:30 +00:00
Legoktm 7ebac23f86 Revert "Compress PNGs with zopflipng" 
This reverts commit cbb7831938.

Change-Id: Ide4880a4a980847bb14cc5880662a4d2142581b8
 2016-02-28 00:07:50 +00:00
Alex Monk ade0862db1 Give a useful message in the temporary blank edit screen 
Bug: T128028
Change-Id: Ife0a9de96965a9848f362696fc403708fd344825
 2016-02-27 21:42:10 +00:00
Translation updater bot e7ad07513a Localisation updates from https://translatewiki.net. 
Change-Id: I88bf6d9f401bfbeab5e256a3b6169541ce8ac0eb
 2016-02-27 21:59:35 +01:00
James D. Forrester ab4d3e956b Update VE core submodule to master (0371bbe) 
New changes:
0371bbe [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern

Local changes: Use new VisualEditorSupportCheck pattern

Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
 2016-02-26 12:26:56 -08:00
Ed Sanders 34d607d546 EducationPopupTool: Use vendor prefixes for animation 
Bug: T128133
Change-Id: Ic061b50e1ed68ea35ac0ccbefbcb5252f917d35f
 2016-02-26 15:34:06 +00:00
Ed Sanders 8f028813e5 CategoryWidget: Update to work with new DraggableGroupElement 
Change-Id: Iefac99dba0e6b8ed3eaaa1d5f1d92e402e3cf2db
 2016-02-25 16:07:50 -08:00
Alex Monk ced27f348f Show welcome dialog on mobile too 
Bug: T112599
Change-Id: Ie04aab468c80dabc84e1386e7529138e1101450e
 2016-02-25 22:03:00 +00:00
Translation updater bot cef228ec1d Localisation updates from https://translatewiki.net. 
Change-Id: I8a8e0b9b879d18d8011821e49dc8c23624652a38
 2016-02-25 22:22:09 +01:00
jenkins-bot 7bef4c9a20 Merge "Warn for empty summary when edit section used" 2016-02-25 18:56:57 +00:00
Translation updater bot 48a2404923 Localisation updates from https://translatewiki.net. 
Change-Id: I0a5b177af81d7f05a86b18f5089a76545b2b8860
 2016-02-24 22:03:55 +01:00
jenkins-bot 222a5361ba Merge "[BrowserTest] Fix ve.init is undefined error messages in Selenium tests" 2016-02-24 17:56:57 +00:00
jenkins-bot 79d8849b49 Merge "Make surface measurable while activating" 2016-02-24 01:33:47 +00:00
Translation updater bot 4fdef459ae Localisation updates from https://translatewiki.net. 
Change-Id: I32522ae9e647712d6256174fade8e0314808b739
 2016-02-23 22:35:50 +01:00
Ed Sanders 229a088f34 Make surface measurable while activating 
If the surface is display:none then $.width always
returns 0, which breaks features like FocusableNode's
invisible icon.

Bug: T127319
Change-Id: Ib157ffaeb56fca2bdc26868d830c4bf8feafa2a8
 2016-02-23 17:05:09 +00:00
wctaiwan 5da37932a2 Warn for empty summary when edit section used 
Warn the user about an empty edit summary when the "edit section"
link is used to trigger VE.

Re-does Ic7b456ca a different way.

Bug: T114857
Change-Id: I319c9c5bed47140a81eb409d490c9f82b89a49fe
 2016-02-23 00:34:12 +00:00
jenkins-bot 74b2489276 Merge "Link to file description pages in media dialog" 2016-02-22 21:07:43 +00:00
Translation updater bot ed26366723 Localisation updates from https://translatewiki.net. 
Change-Id: Ib209a100469a77418cc66174d69bc6955101a7a3
 2016-02-22 21:42:37 +01:00
jenkins-bot 0b8f6b576d Merge "Transclusion dialog: Simplify example/default value labels" 2016-02-22 15:48:07 +00:00
Ed Sanders 816fca78e8 Transclusion dialog: Simplify example/default value labels 
'Value' comes across as a bit technical. 'e.g.' is more common
for 'example value'. Truncate 'Default value:' to just 'Default:'.

Change-Id: Ie03fb64a01846071ccdcb673439fc568b9d0de78
 2016-02-22 15:40:19 +00:00
jenkins-bot 705fc76e62 Merge "MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia)" 2016-02-22 06:34:05 +00:00
jenkins-bot 0f9a09be73 Merge "Make platform language functions actually work" 2016-02-22 06:34:02 +00:00
Ed Sanders 083182debd Make platform language functions actually work 
Previously arguments were not getting passed through.

Change-Id: I19fbd6f8a7f32163a85dda01fa46ac56a8c78cf8
 2016-02-22 00:05:05 +00:00
Translation updater bot 56e29facc9 Localisation updates from https://translatewiki.net. 
Change-Id: I8f4817ee86f71cf8233069b48b5dfd842d0fadff
 2016-02-21 22:30:14 +01:00
Ed Sanders deb676e73d MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia) 
Change-Id: I4fabf5f8d87b9b21623883203b9d6965a0ff33a0
 2016-02-21 18:20:30 +00:00
Alex Monk ca5cab52af Link to file description pages in media dialog 
Bug: T125227
Change-Id: I243f5479ab27ab098d41db08ff4a53195d382577
 2016-02-21 03:45:37 +00:00
Ori Livneh cbb7831938 Compress PNGs with zopflipng 
Zopfli is the most efficient DEFLATE compression algorithm, trading run-time
performance for file sizes that are typically 3-8% smaller than those produced
by zlib with the maximum compression setting. Its output is Deflate-compatible,
so no specialized decoder is needed.

This change was created by running zopflipng against all the PNG files in this
repository. The exact invocation was:

  git ls-files --exclude-per-directory=.gitignore -- '*.png' \|
    parallel zopflipng -m -y {} {} \;

Files which zopflipng was not able to compress more efficiently were left unmodified.

Bug: T127608
Change-Id: Id5807b1ec56320b3474878290dd05600c1e389d5
 2016-02-21 00:14:58 +00:00
Translation updater bot 3fd583d1d7 Localisation updates from https://translatewiki.net. 
Change-Id: I035d1386ec12fdcd6152cf25a029d9c133c7c1f9
 2016-02-20 22:25:46 +01:00
Translation updater bot d300f6a1ff Localisation updates from https://translatewiki.net. 
Change-Id: I826fa20c2850c5711e81863104d39453daaa40b3
 2016-02-19 22:12:30 +01:00
jenkins-bot 30e6acfff2 Merge "MWMetaDialog: Fix setup of pages" 2016-02-19 19:52:55 +00:00
Ed Sanders 15a47665c8 Meta dialog: Use window action to open windows 
Because abstraction.

Change-Id: I9811db4380c6cf37a73a76b97c8439f94723c5a6
 2016-02-19 17:37:42 +00:00
Translation updater bot acc2347eee Localisation updates from https://translatewiki.net. 
Change-Id: I7dae6beab2b97fefffa0bdc72766e553da7a4c75
 2016-02-18 22:18:44 +01:00
James D. Forrester 6e6ac1656f MWPopupTool: Update Phabricator URL broken by upgrade 
Change-Id: I17fc6178729e246643e999e622b84e34fc7959b3
 2016-02-18 11:24:00 -08:00
Ed Sanders b70eb51491 MWMetaDialog: Fix setup of pages 
Only call setup in ready process, as setup includes setting
focus. Defer fitInput call to category widget until transition
is finished so measurements are correct.

Change-Id: I49a30402cf58e36f16316e3ab04fa3349d19954e
 2016-02-18 17:14:45 +00:00
Ed Sanders 704ec7ad3f MWCategoryWidget: Improve caching 
For every title request, store an entry in noramlizedTitle to
avoid ever making an API request for that category again.

This prevents API requests from being fired every time a
category was moved, which in turn prevents the list from
flickering as it waits for the API request to resolve.

Also normalise the spelling of normalize to en-US/en-GB-oxendict

Bug: T127317
Change-Id: Ie26d9d60fb83981c45ff27199e38ae98e5560a28
 2016-02-18 17:14:33 +00:00
Željko Filipin 60a08f925c [BrowserTest] Fix ve.init is undefined error messages in Selenium tests 
All scenarios that are passing are enabled to run in Jenkins.
(The commit increases the number of passing scenarios from 2 to 18.)

Bug: T126966
Change-Id: I9789ca42717133120197c4625bb8dad4ea496aa8
 2016-02-18 15:42:05 +01:00
Ed Sanders 7eeb136d94 MWCategoryWidget: Use namespace constants from config 
Change-Id: I63661ce49dbb0fac62cb7dbd65c466cfdd6e57b0
 2016-02-18 11:36:31 +00:00
James D. Forrester cebaacb546 Update VE core submodule to master (cdfd84e) 
New changes:
c02ea46 Clarify documentation of directionality methods
43c9b6f Move initialisation browser support checking from downstream
c89be66 Localisation updates from https://translatewiki.net.
5fb7907 Follow-up c89be66: Fix build for added language 'nan'
fc74fab dm.ElementLinearData.compareElements: Add a few missed test cases

Local changes:
Use initialisation browser support checking from upstream

Depends-On: I27a8e7b4376647f01cee648de987dc3ca6a060d5
Change-Id: I3fc79422ee5e487cf5fae3929fe492f21cd2840a
 2016-02-17 20:04:16 -08:00
Translation updater bot dabeb4218d Localisation updates from https://translatewiki.net. 
Change-Id: Iaabe8dd045b2670aeb9fc0164fcb30f682f73b6c
 2016-02-17 22:52:14 +01:00
Alex Monk 83d8a7d9bb Don't remove .ve-activated after successfully activating 
hideLoading always gets called after activating, not just failing

Follows-up: I13058ae1

Bug: T127184
Change-Id: I47d1892feacbfcf832aa32f689f173601b76c4ba
 2016-02-17 15:36:18 +00:00
Translation updater bot 3ec98ab32d Localisation updates from https://translatewiki.net. 
Change-Id: I18bd9573f32007ef6a112b035d0bea503d4c581b
 2016-02-16 23:13:41 +01:00
jenkins-bot 88c5316f22 Merge "Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit" 2016-02-16 16:56:15 +00:00
Translation updater bot 6c9b6f0fd7 Localisation updates from https://translatewiki.net. 
Change-Id: I2ac29726abb9a68893926d5ab1e06985b5a81cf9
 2016-02-15 21:42:28 +01:00
Željko Filipin 966f2f7bbb [BrowserTest] Jenkins runs only passing Cucumber scenarios 
To get at least some Cucumber scenarios running in Jenkins, disable all
of them that are failing and run only ones that are passing.

The next step will be to fix failing scenarios.

Bug: T94162
Change-Id: Id0338c1d6b86d6b45220c5c0802074be397fb607
 2016-02-15 13:18:19 +00:00
Translation updater bot db852aff65 Localisation updates from https://translatewiki.net. 
Change-Id: I3e66b91d4c39d676e167e5d0cfdc914e44c51fa4
 2016-02-14 21:31:45 +01:00
Translation updater bot 747a90ada2 Localisation updates from https://translatewiki.net. 
Change-Id: If10088f3fc527750ea96bd73d55e8c412d5c1c66
 2016-02-13 23:02:29 +01:00
Alex Monk 9a1c0762cb Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit 
Bug: T125998
Change-Id: I2982f6e5f26086a1175b9fc8c3039a2143a44659
 2016-02-13 02:56:01 +00:00
Alex Monk 1c1d018bc7 Unbreak VE 
Follow-up to I13058ae1

Change-Id: Icb30f87746bea3911379fca9766877a36e8b5975
 2016-02-13 00:58:42 +00:00
Translation updater bot 685bacc990 Localisation updates from https://translatewiki.net. 
Change-Id: Ibd9a19ca100c3c0d392ec40095601db780d29103
 2016-02-12 22:12:14 +01:00
jenkins-bot bcae181cec Merge "Try to make MW->VE switching failures break less things" 2016-02-12 17:29:29 +00:00
Translation updater bot 40bbaa9c71 Localisation updates from https://translatewiki.net. 
Change-Id: Ia32d187a8afac039d4d2fb71a233fc25e0f87039
 2016-02-11 21:41:11 +01:00
Alex Monk 4a288a5866 Try to make MW->VE switching failures break less things 
* Try to hide loading bar on failure
* Don't set wgAction back to 'view' if we're dropping the user back to the
  wikitext editor

Bug: T125580
Change-Id: I13058ae131a1dda3b172e78d9b143d70831c47f1
 2016-02-11 02:39:06 +00:00
Ed Sanders af8e23ec6e Remove code for varying MWLinkInspectorTool title 
The title is visibly varied in the context menu separately, and
we don't usually change the link tool's title - so this is just
a performance drain (updateState happens a lot).

Change-Id: I9cf2aa509a6aac3a2914fa52167cb4463843cd72
 2016-02-11 02:22:16 +00:00
Translation updater bot 35cf5524b3 Localisation updates from https://translatewiki.net. 
Change-Id: Ide3b91bb90a8fd3c566bd657a13997211d8a345c
 2016-02-10 21:11:44 +01:00
jenkins-bot 0611527d77 Merge "Remove translations of messages since moved to Cite/Citoid" 2016-02-10 08:08:51 +00:00
jenkins-bot 4a751524c4 Merge "Edit mode switch: Show popup next to VE switch button" 2016-02-10 01:51:57 +00:00
Ed Sanders 80124c88a6 Edit mode switch: Show popup next to VE switch button 
Only show if the user came from VE.

Change-Id: Ic362ba534d135fca5516c8ba401f6b2a22886ff1
 2016-02-10 01:36:32 +00:00
Alex Monk 863a2c2974 Don't try to tell the server to set preferences to their current values 
It's rather pointless.

Change-Id: I8065af1d61108ce843c0afd2eaa0f1f9b85b6998
 2016-02-10 01:04:47 +00:00
Ed Sanders e073a431fc Remove translations of messages since moved to Cite/Citoid 
Change-Id: I692f03b374ec28ec6d81aab2d2d6fcd7705cedc5
 2016-02-10 00:39:18 +00:00
Translation updater bot 829b2cd430 Localisation updates from https://translatewiki.net. 
Change-Id: I28e88ed6e5da7567693ee2833e501696251deecd
 2016-02-09 21:42:50 +01:00
jenkins-bot d5f6c220d3 Merge "Follow-up I7e1edcf05c: Remove MonoBook z-index hack" 2016-02-09 14:28:16 +00:00
jenkins-bot 1844af1588 Merge "ve.init.mw.trackSubscriber: Sample at 6.25%" 2016-02-09 01:06:23 +00:00
James D. Forrester a1db489d95 ve.init.mw.trackSubscriber: Sample at 6.25% 
Bug: T125598
Change-Id: I1915a6456ba5dfc10e4a52df24cee2e68b27e526
 2016-02-08 13:22:33 -08:00
Translation updater bot 047517fa22 Localisation updates from https://translatewiki.net. 
Change-Id: I475a76215ab50328eb2c65d68b2c4be2a5afd6e2
 2016-02-08 22:17:32 +01:00
jenkins-bot e5eb83ff8b Merge "build: Bump various devDeps to latest and make pass" 2016-02-08 18:18:03 +00:00
Ed Sanders 25be46a57d Fix transclusion node cloneElement method 
* Override the static cloneElement. getClonedElement shouldn't
  be overridden as doing so misses static invocations.
* Apply the same fix to extension nodes
* Fix DOM loop to reference clone.originalDomElements[ i ]

Logically depends on Id8024c171c to work.

Bug: T126169
Bug: T126114
Change-Id: Icf4d3115db5b12b97a6c805ff3d0b71d9e88b804
 2016-02-08 15:29:19 +00:00
jenkins-bot a996356e12 Merge "MWImageModel: Use clearDefaultDimensions" 2016-02-08 12:52:10 +00:00
Ed Sanders cfe21d317d MWImageModel: Use clearDefaultDimensions 
setDefaultDimensions( {} ) is a no-op.

Bug: T126078
Change-Id: I1ef7cae04574e2561d21d4071d19a0067d81b263
 2016-02-08 12:37:26 +00:00
James D. Forrester e6e492efc6 build: Bump various devDeps to latest and make pass 
* grunt-contrib-jshint: 0.11.3 -> 0.12.0
  This version of the linter cleans up a number of options. 'es5' is now assumed to be
  true by default, and replaced as 'esversion'; 'latedef' is extended to also cover
  functions' defintions, disabled for us for now; 'futurehostile' is introduced to aid
  future-incompatible names for ES6+ support.

  I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this file is
  meant to be loaded by all JS-capable clients to determine if it is (amongst other
  things) capable of ES5, so now we assert ES3 compatibility via jshint.

* grunt-jscs: 2.5.0 -> 2.7.0
  Minor version bump that doesn't affect us.

* grunt-jsonlint: 1.0.6 -> 1.0.7
  Trivial version bump that doesn't affect us.

Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
 2016-02-07 19:41:21 -08:00
jenkins-bot 2b01e43777 Merge "DesktopTarget: Move generic VE desktop styles into a separate module" 2016-02-08 01:59:56 +00:00
Ed Sanders 739f924e98 Follow-up I7e1edcf05c: Remove MonoBook z-index hack 
The cited reasons were that the the logo and search bar
have a z-index of 3, but that doesn't matter as they are
nested in other elements with z-indexes.

Change-Id: I7ff279efe7c01ba1ffb1fa0d460d59a493ccc47a
 2016-02-07 17:40:50 -08:00
Ed Sanders c51cef07b9 DesktopTarget: Move generic VE desktop styles into a separate module 
Here they can be re-used by other VE desktop targets,e.g. Flow.

Change-Id: I18431ff73fc1c6ab5639a579e85b0f0cc48cb9ce
 2016-02-07 17:39:57 -08:00
Translation updater bot 0138f6a71f Localisation updates from https://translatewiki.net. 
Change-Id: Ia7c748204f03aa2be7f403846118753c5f174669
 2016-02-07 22:22:53 +01:00
jenkins-bot 16c498fa97 Merge "DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface" 2016-02-07 10:30:06 +00:00
Ed Sanders efd41fbc74 Remove global overlay hack now fixed in Vector 
Change-Id: Ic5cfb7ae4d244799be56e12b4b0a44b6ddd00303
Depends-On: I5ebb4e59e3714dfaa3d755ecf6285009efe7b62a
 2016-02-07 03:26:02 +00:00
Ed Sanders 9bf010c33c DesktopArticleTarget: Cleanup styles 
* Use more specific ve-init-mw-desktopArticleTarget class
* Add comments and reorder in places

Change-Id: Ic9291d3e50304fe3a0efa7ace1ce93c7fba91d98
 2016-02-06 19:26:06 -08:00
Alex Monk 138fafbbb9 DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface 
So the normal logic is used to close other windows etc.

Bug: T125479
Change-Id: Iee9ef7484de745f3adced28cdbcc87a0c2b597f5
 2016-02-06 02:02:39 +00:00
jenkins-bot e0de4c4447 Merge "Remove all Extension:Cite code, now moved there" 2016-02-05 22:17:08 +00:00
jenkins-bot 5a360f4cbb Merge "Remove mwReference tests, moved to Cite extension" 2016-02-05 22:16:24 +00:00
James D. Forrester 1e0486a679 Remove all Extension:Cite code, now moved there 
Depends-on: I39936ed83d5a60471a0a75da753f498e80aef234
Depends-on: Ifd853bf9f901065798bd0063aeaa786a3761aa71
Depends-on: I32c93c5118eafe5f071252290c58d3de8dacc81a
Change-Id: Iba0f25b3ebe4e5e63377da57afb760d6980f9907
 2016-02-05 21:36:56 +00:00
Ed Sanders 094555cb3c Remove mwReference tests, moved to Cite extension 
Change-Id: I07a2bf45117c2d14c7b00875c0a710e20980a23a
 2016-02-05 21:36:56 +00:00
Translation updater bot bd848ac4f1 Localisation updates from https://translatewiki.net. 
Change-Id: Ic65af97f6c29c1e0c47317997b18ab064f80a2f5
 2016-02-05 21:54:43 +01:00
Translation updater bot 7c07b2706b Localisation updates from https://translatewiki.net. 
Change-Id: Ibd8991424c15ff9d6700c5103c75aff17aa452d9
 2016-02-04 22:18:02 +01:00
Ed Sanders 5864a62134 Default extensions to not use the 'invisible icon' 
Bug: T125767
Change-Id: I58c58080382974a887ebc52c1ac80cb5970db8c7
 2016-02-04 19:38:16 +00:00
Translation updater bot 622ca082ca Localisation updates from https://translatewiki.net. 
Change-Id: I29d93111a508e8af12752b6b93dc13d106f01d5f
 2016-02-03 23:09:41 +01:00
Translation updater bot 0acd4160f4 Localisation updates from https://translatewiki.net. 
Change-Id: Id1d12847d0c09993453c889af16266b9bac9d9ee
 2016-02-02 21:33:11 +01:00
jenkins-bot 804ab26fb2 Merge "Check xhr.responseText is set before trying to send it to $.byteLength" 2016-02-02 19:08:08 +00:00
Alex Monk 9808d04bfe Check xhr.responseText is set before trying to send it to $.byteLength 
Bug: T125399
Change-Id: I09881fe8b6db7d95e32732129d043c4a13fa7a9a
 2016-02-02 18:52:56 +00:00
Ed Sanders 98bc5daba1 Use new iconWhenInvisible feature in Transclusion/Extenion nodes 
Change-Id: Iba55676c06a1cd625187c38c1ae0c9c20b065827
Depends-On: I127bb5d34850cdc545ea3c05d0fc41a8ae1c6dea
 2016-02-02 18:07:13 +00:00
Translation updater bot 9ec0705a2b Localisation updates from https://translatewiki.net. 
Change-Id: If02911bde5c9cdbaeeaf52a45f4746b1b61b7d16
 2016-02-01 21:56:13 +01:00
Ed Sanders db5ed236dd Add controls for wikitable and sortable to table dialog 
Bug: T95189
Depends-On: Ife3f3505b845db28dd29a07e9be1533c39726ce1
Change-Id: I1672d8cd2e138df1fad19dcfd948700942e87f2c
 2016-02-01 10:58:42 -08:00
Ed Sanders 74358498da Update VE core submodule to master (70ff8cc) 
New changes:
242ab45 DesktopContext: Float the context when it goes beyond the viewport
405c44d Rename TableContext to TableLineContext
6c564be Sort messages alphabetically
70ff8cc Introduce table and table cell context

Change-Id: I4357162bc192c90f99ca0aec12eb67bf848e5504
 2016-02-01 10:51:26 -08:00
Ed Sanders 5e296a959b Sort messages alphabetically 
Change-Id: I45b440b1b020ea79ab4c1eba78effb526c41ddc4
 2016-02-01 17:36:43 +00:00
Translation updater bot 122d76bfbe Localisation updates from https://translatewiki.net. 
Change-Id: Ib037f762e584c8b6bc153a469057b362e31393fc
 2016-01-31 21:42:24 +01:00
Translation updater bot 1b33f7b912 Localisation updates from https://translatewiki.net. 
Change-Id: I499a7c36f46bed65f06c881de3df9fdf53e20036
 2016-01-30 22:50:35 +01:00
Alex Monk 8cc034b9af Run VE->WTE modification checks regardless of how the user got into VE 
I think this fixes a bug similar to the one described in the bug below.

Bug: T124708
Change-Id: I61558227315bec36b71dac281b8da311a3d6bb1a
 2016-01-30 03:06:46 +00:00
Translation updater bot de5f372ac5 Localisation updates from https://translatewiki.net. 
Change-Id: Idfb5e5fdd92cae124b428c768fd89baa6239541c
 2016-01-29 22:43:50 +01:00
Ed Sanders 0ed45dbf61 MWTable: use new sanitization method 
This prevents tables from getting sanitized even on
VE to VE copy. Also by calling ClassAttributeNode sanitize
extra CSS classes are removed.

Bug: T97462
Bug: T125220
Depends-On: Ia3ce386b2a03bc227818b10423bca72c736c0656
Change-Id: Ifd91e00b40665b446bbdcdf8859d2bb641bc0e67
 2016-01-29 10:29:19 -08:00
jenkins-bot 66b0ff5111 Merge "ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl" 2016-01-29 17:00:38 +00:00
Translation updater bot 77a11811fb Localisation updates from https://translatewiki.net. 
Change-Id: If88cee4c9c766aabdccc4d996d48c0151e5611bb
 2016-01-28 21:11:06 +01:00
Bartosz Dziewoński fb54d03a59 ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl 
Change-Id: Iae61d13a6c776c86bcec6744a2153b14c07722e9
 2016-01-28 19:02:38 +01:00
jenkins-bot e4e7fce00e Merge "Create a more neutral warning message" 2016-01-28 07:57:33 +00:00
Justin Du 854f0a3692 Create a more neutral warning message 
Change was made because editing mode is not always left to go to view mode,
but for example also because of clicking on "History".

Bug: T121754
Change-Id: Ibc1ba697081e60b8a797f5ea1b814a320ba812c3
 2016-01-28 07:29:09 +00:00
Translation updater bot e181ca806b Localisation updates from https://translatewiki.net. 
Change-Id: I694abc3d49df4ed6b580a10bdc37ba24fc288ac0
 2016-01-27 21:46:32 +01:00
jenkins-bot f78dd8ad72 Merge "MWWelcomeDialog: Let the user switch editors" 2016-01-27 00:20:10 +00:00
James D. Forrester d8769edd01 MWWelcomeDialog: Let the user switch editors 
Change-Id: If88942d866278f3012dae7972d464a3d2a6a4f82
 2016-01-27 00:14:07 +00:00
jenkins-bot fc43d61ec5 Merge "MWTargetWidget: Add missing indent commands to blacklists" 2016-01-26 23:53:51 +00:00
Ed Sanders abb094babd MWTargetWidget: Add missing indent commands to blacklists 
Bug: T124619
Change-Id: If2a5d98673db6e2d29fe49f1e7f5307437ba3866
 2016-01-26 23:46:12 +00:00
James D. Forrester 2c76dc5b50 MWEditingTabDialog: Use 'small' size 
Change-Id: Icb30d4fbea21653cf2fb6c782a4314be97a3e0a2
 2016-01-26 14:51:55 -08:00
jenkins-bot 75b0a8de63 Merge "Don't try to load VE over the top of the wikitext editor we just switched to" 2016-01-26 17:01:24 +00:00
Alex Monk 589437a772 Don't try to load VE over the top of the wikitext editor we just switched to 
(if we discarded changes)

Bug: T124316
Change-Id: Ic5e6ee8f4b6e75c3ae877021bcb29733b881e6d2
 2016-01-26 16:49:50 +00:00
Alex Monk d7183d7e64 Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. 
Clicking 'View source' should probably not cause VE to load

Bug: T124650
Change-Id: I236de38b0f90f1aaa5d04b57cb7759e5951baf2b
 2016-01-26 16:47:26 +00:00
Alex Monk bfa15c44a5 Check user preferences before loading VE on-load on action=edit/submit etc. 
Bug: T124743
Change-Id: I2e8a19014464a2b7fb76de08676e7cb808e06956
 2016-01-26 02:48:27 +00:00
Translation updater bot 71c0473094 Localisation updates from https://translatewiki.net. 
Change-Id: I159863f04ee8af735dde305b24d8f5cd0a5c8b2b
 2016-01-25 22:33:02 +01:00
jenkins-bot 6666bfcaea Merge "MWTableNode: Mixin ve.ce.ClassAttributeNode" 2016-01-25 20:54:15 +00:00
Ed Sanders ba0b084813 MWTableNode: Mixin ve.ce.ClassAttributeNode 
The DM side already had the mixin, the CE side was still using custom
logic that has since been moved to ce.ClassAttributeNode.

This fixes the issue of tables not getting the wikitable class in VE
as it was only applied on attribute change previously, which never happened.

Change-Id: I197347762fc9228034f7664484539e5888722bcf
 2016-01-25 16:35:49 +00:00
Translation updater bot 8e5a9e71a9 Localisation updates from https://translatewiki.net. 
Change-Id: I401186574b88f3c5c810644799b55f2af5740f8c
 2016-01-24 21:22:34 +01:00
Translation updater bot d246540ccf Localisation updates from https://translatewiki.net. 
Change-Id: Ie90b5f4eb9a6303d4374b99c98c0dfeb8e595fbc
 2016-01-23 22:30:32 +01:00
jenkins-bot d29524c8b3 Merge "When loading VE from action=edit/submit, replace the title shown" 2016-01-22 20:43:02 +00:00
Alex Monk 38180b5d4d When loading VE from action=edit/submit, replace the title shown 
Bug: T117643
Change-Id: Ice21389d02ea10adc668c5b0a64ba2b0b9cf5744
 2016-01-22 20:27:01 +00:00
Ed Sanders b66aa990ba Follow-up I9714cf3: Add tests for wikitable paste 
Bug: T85577
Change-Id: I8e2893c9a6f80fafe6cae142e4f50ffbe6d550ac
 2016-01-22 20:13:26 +00:00
jenkins-bot e6c61052a0 Merge "MWTableNode: Apply wikitable class to pasted tables" 2016-01-22 19:10:41 +00:00
Ed Sanders bf50e2a570 MWTableNode: Apply wikitable class to pasted tables 
Bug: T85577
Change-Id: I9714cf3e8ccc165f91af939481c845c3ec9c5f6b
 2016-01-22 18:43:47 +00:00
Thalia 16330ac05d Add method for setting minimum number of rows in Ace editor widget 
Bug: T123891
Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
 2016-01-22 17:05:35 +00:00
Translation updater bot b382eced8c Localisation updates from https://translatewiki.net. 
Change-Id: Idce091710bdb8936a362df1ce2f000b792b1b286
 2016-01-21 21:56:24 +01:00
Translation updater bot 27261322b4 Localisation updates from https://translatewiki.net. 
Change-Id: I6f9e970a0cb80e33849c67d1a850ce019cdcd76e
 2016-01-20 21:09:24 +01:00
jenkins-bot 3bc62ba61d Merge "SaveDialog: Fix alignment of checkboxes" 2016-01-20 18:36:46 +00:00
Translation updater bot 5b95d6c1e6 Localisation updates from https://translatewiki.net. 
Change-Id: I5b3ed86498fcc81cb448d056d32b53cb9a15a579
 2016-01-19 21:22:21 +01:00
Ed Sanders 74e4450c92 SaveDialog: Fix alignment of checkboxes 
Change-Id: Ia7718e7cebe7c533a76533dc82bcf93f8da49d15
 2016-01-19 16:40:32 +00:00
jenkins-bot ee70cc5c44 Merge "Single Edit Tab: simplify logic; make 'prefer-wt' just disabled" 2016-01-18 21:28:26 +00:00
Translation updater bot 9b0ba61924 Localisation updates from https://translatewiki.net. 
Change-Id: I45ba38e70875a2e7783144aa0756f4bc8989c835
 2016-01-18 21:38:20 +01:00
James D. Forrester aa08d34318 Single Edit Tab: simplify logic; make 'prefer-wt' just disabled 
Change-Id: I090375933656f29636c355c4d2ce358dd7f7f074
 2016-01-18 11:23:59 -08:00
James D. Forrester 68ea08cd5e Drop support for adding prefix/appendix labels to edit tabs/links 
Depends-On: I264599a1c4f60b37a46d49c808cf271ba0a8f882
Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
 2016-01-18 03:06:33 +00:00
Translation updater bot f0b2ce2ded Localisation updates from https://translatewiki.net. 
Change-Id: If3cb31818a635b6f5b4ac4796fced777f5517dd0
 2016-01-17 22:35:39 +01:00
Translation updater bot 81a33e1ddc Localisation updates from https://translatewiki.net. 
Change-Id: If2e5f3a07d289d3575ada8cc712b80ed11e2f532
 2016-01-16 21:59:41 +01:00
Translation updater bot 5a8b1c294e Localisation updates from https://translatewiki.net. 
Change-Id: I1653aca5124b19dbd879d82196ec381070ccce13
 2016-01-14 22:26:26 +01:00
Translation updater bot 6606c25902 Localisation updates from https://translatewiki.net. 
Change-Id: I913124a4a85545e9abc179a225ec3ee5746bda11
 2016-01-13 23:32:14 +01:00
Translation updater bot cec85b9e3c Localisation updates from https://translatewiki.net. 
Change-Id: I76a506a5fb58dee87fd3459d557b29190ad7e777
 2016-01-12 22:49:13 +01:00
Translation updater bot c37fbf1f70 Localisation updates from https://translatewiki.net. 
Change-Id: Ie52c778d1291121d3d78dcae9ae8a5d23d5c27b8
 2016-01-11 22:55:11 +01:00
Translation updater bot 946163d758 Localisation updates from https://translatewiki.net. 
Change-Id: Ib5d617cc8a22b6c5e5248c3a374d10d08cd3434f
 2016-01-10 23:15:09 +01:00
Translation updater bot f26501b4f6 Localisation updates from https://translatewiki.net. 
Change-Id: I6c324c98c20cc8d4b7b1b51f7eec5b5a608eee2b
 2016-01-08 22:22:26 +01:00
Translation updater bot d1386ae5b8 Localisation updates from https://translatewiki.net. 
Change-Id: Icf5edd18f9fa08c0ff63808c750b2f64698066bf
 2016-01-07 23:39:13 +01:00
jenkins-bot 7a39be3798 Merge "Stop using broken image links in tests" 2016-01-07 01:21:25 +00:00
David Lynch 3cffb489bb Stop using broken image links in tests 
They make it a little bit more cluttered to hunt down problems when
testing. So, use the minimum image instead of just "Foo" or similar.

Bug: T121636
Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
 2016-01-06 17:11:38 -08:00
Dan Duvall 96677fb74a [BrowserTest] Experimenting with JS object references 
References to JS objects for VE elements can determined by referencing
the VE and OOUI API documentation[1][2] and interrogating the objects in
a browser console. Errors should be closer to what developers understand
but testers should pair with developers to better understand how to
define new page elements and where to go for documentation/help.

The VE entrypoint for the singleton reference is `ve.init.target` (if
there's only one instance of VE target; there may be multiple in some
cases like Flow).

[1] https://doc.wikimedia.org/VisualEditor/master/
[2] https://doc.wikimedia.org/oojs-ui/master/js/

Change-Id: I1f642807cdd3059d8e7e885a8b239ac01b9b3024
 2016-01-06 17:07:35 -08:00
Translation updater bot 739b4c796d Localisation updates from https://translatewiki.net. 
Change-Id: I406227f147f21b4deed2a5a6e9f556e84cd32a65
 2016-01-06 21:56:55 +01:00
Translation updater bot 94126edb04 Localisation updates from https://translatewiki.net. 
Change-Id: I1d7295d5aee0dd72a7469c6467b12177187988dc
 2016-01-05 22:31:09 +01:00
Translation updater bot b3a11a9325 Localisation updates from https://translatewiki.net. 
Change-Id: I79bdcd360cf4c879b8344f75af927fdfac89dcd2
 2016-01-04 22:38:41 +01:00
jenkins-bot 3591a0e63d Merge "Education popups: Only show for DesktopArticleTarget" 2016-01-04 20:00:58 +00:00
Ed Sanders e7ee5c20c6 Education popups: Only show for DesktopArticleTarget 
For now they are not well supported by other targets
(e.g. Flow and Mobile).

Change-Id: Ibd1f3c8994611661b52c0cf36438b41f623b9451
 2016-01-04 10:43:43 -08:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016 
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
 2016-01-03 14:57:25 -08:00
jenkins-bot e59e36e225 Merge "Refactor MediaResources(Provider/Queue)" 2016-01-03 22:55:39 +00:00
James D. Forrester 4a781a3a16 EditingTabDialog: Shorten the copy to make snappier, drop 'Edit' tab name 
Change-Id: Idd5f373d9fef364318efddcc98ea2de5e91860a8
 2016-01-03 13:44:54 -08:00
Translation updater bot 93b4a43b18 Localisation updates from https://translatewiki.net. 
Change-Id: I26cf69fe5f4593ca22c9a170fd16fb02549b187e
 2016-01-03 21:45:19 +01:00
Alex Monk 85bb085418 DesktopArticleTarget: Preserve oldid when switching from WTE into VE 
Change-Id: I8682a2a2b90ae2e42f1a8e01e16d0f9f3d66a2d5
 2016-01-03 10:59:21 -08:00
jenkins-bot 26e3c0ad1d Merge "Preserve oldid when switching from VE into WTE" 2016-01-03 06:35:58 +00:00
Translation updater bot f80e0c7482 Localisation updates from https://translatewiki.net. 
Change-Id: I58460ed4632db989f00464d0401a7bba5cd072da
 2016-01-01 20:07:11 +01:00
Translation updater bot f1df0e0df4 Localisation updates from https://translatewiki.net. 
Change-Id: I88a173f67541d0a5d1c8628e81871cbfce6db393
 2015-12-30 21:46:23 +01:00
Željko Filipin 2cfaa9528c [BrowserTest] Update mediawiki_selenium Ruby gem to the latest version 
Bug: T114241
Change-Id: Ic6cf69516a1e36173fbbf6b86494e845721a19d0
 2015-12-30 11:46:23 +00:00
Translation updater bot 8eca31d729 Localisation updates from https://translatewiki.net. 
Change-Id: I8c80187c5efb9b45b2a0df338a778a6074d467ac
 2015-12-28 21:05:28 +01:00
Translation updater bot 7dcba8dbf4 Localisation updates from https://translatewiki.net. 
Change-Id: I03f05bd052a77b75d731994fb8b247d21dff1077
 2015-12-27 20:38:22 +01:00
Translation updater bot ac555fd695 Localisation updates from https://translatewiki.net. 
Change-Id: If3e7e7050a93934732703d239b76c3b7c31069cb
 2015-12-26 21:12:39 +01:00
Translation updater bot 97dd3ee12d Localisation updates from https://translatewiki.net. 
Change-Id: I491b5cdaa05e954fffc5c11e6db6e12629064893
 2015-12-25 21:55:54 +01:00
jenkins-bot 3231220774 Merge "SET: Don't try to do any client-side section link magic if we're not supposed to." 2015-12-23 23:18:57 +00:00
Alex Monk 76cb69ecec SET: Don't try to do any client-side section link magic if we're not supposed to. 
Ugh.

Bug: T121599
Change-Id: I47a93d5dbedc5ae989a2973fb793ac99edfb139a
 2015-12-23 22:10:20 +00:00
Translation updater bot fa66daef6c Localisation updates from https://translatewiki.net. 
Change-Id: Ie2040e33f23c85fc0f6a2a66773c67c30aa6ac83
 2015-12-23 22:08:06 +01:00
Ed Sanders 2afd7c903d DesktopArticleTarget: Improve teardown sequence 
* Ensure activating classes are removed by rejecting activatedDeferred
  as soon as teardown starts.
* Try to teardown surfaces is surfaces exist, not just if the target is active.
* Remove noop teardownDebugBar. The debugbar lives inside the surface now.
* Ensure progress bar is always reset, even if target setup is aborted.

Bug: T99139
Change-Id: I16a071c0d4bc8bbc6af2e03e63ee0ffc18d55c75
 2015-12-23 12:13:50 +00:00
Translation updater bot 9cc9b8f1a1 Localisation updates from https://translatewiki.net. 
Change-Id: Ia72cf64c778cf9ab82f24700ec90e404bd0f9432
 2015-12-22 22:12:49 +01:00
Ed Sanders 93f0e8b30c Refactor MediaResources(Provider/Queue) 
Create a subclass for MediaSearch(Provider/Queue) and make the parent
class a more generic representation of API requests for media.

Change-Id: Iea8b90e829d532d210bfef3c96d6798c64e15eed
 2015-12-22 14:00:10 +00:00
Translation updater bot dd85041a29 Localisation updates from https://translatewiki.net. 
Change-Id: I66a72ca80277579be5674cbeb0794a70c7093345
 2015-12-21 22:07:16 +01:00
Translation updater bot 39d762e844 Localisation updates from https://translatewiki.net. 
Change-Id: I9de2feb735f9c722d941e7fdac53f4ee241ad9ad
 2015-12-20 22:36:27 +01:00
jenkins-bot 7c1660c933 Merge "Make Ace Editor adjustSize method chainable" 2015-12-20 12:56:03 +00:00
jenkins-bot 7da9dc409f Merge "ReferenceEducationPopup: Don't flip the numbers in the RTL image" 2015-12-19 15:06:24 +00:00
Florian 5627701cb1 Fix inheritance of ve.ui.MWTransclusionDialogTool 
From the description of the commit message[1] for WindowTool and
FragmentWindowTool, the ve.ui.MWTransclusionDialogTool should be
a FragmentWindowTool, and not a WindowTool.

In fact, the bug is caused by the missing isCompatibleWith method
in WindowTool.

[1] I3a0e761f0d6e942d503ec

Follow up: I676af9c50b09ef007926240eb2327d1a0fdd80f5

Bug: T121596
Change-Id: I9a47e5d67fcd7a94155b7cf77c734c94b0ed69e1
 2015-12-19 11:52:44 +00:00
Thalia f8fbbdf66d Make Ace Editor adjustSize method chainable 
Change-Id: I48307bd9184bb238a553d178c0d66084244e9ebf
 2015-12-19 10:57:04 +00:00
Translation updater bot c747c06759 Localisation updates from https://translatewiki.net. 
Change-Id: I6ee493d00d8fd9ad8ea4fc4efbf7513be9765d07
 2015-12-18 23:39:12 +01:00
Alex Monk c10236cc58 Preserve oldid when switching from VE into WTE 
Bug: T120898
Change-Id: I51774fd7ca5be7373d8aec55cb420a874bc7d531
 2015-12-18 00:47:03 +00:00
Translation updater bot a9637adf2d Localisation updates from https://translatewiki.net. 
Change-Id: Ic62f7e83d426f1e5872cd0597d54458d851490ad
 2015-12-17 22:46:49 +01:00
Translation updater bot 4e2d06605e Localisation updates from https://translatewiki.net. 
Change-Id: If7ed2349bec27df44a387cfca605de7e1f75873d
 2015-12-16 22:37:19 +01:00
jenkins-bot 607878e2ba Merge "MWTarget: Only add ve-init-mw-target-surface to the main target surface" 2015-12-16 20:06:33 +00:00
jenkins-bot 6b7fc00f68 Merge "DesktopArticleTarget: Change tab text on server side when possible" 2015-12-16 19:51:03 +00:00
Ed Sanders a689caa762 MWTarget: Only add ve-init-mw-target-surface to the main target surface 
Avoid adding it to TargetWidget surfaces.

Bug: T121450
Change-Id: I7c43b07c5bade3a778ad423e39b25616e03aa888
 2015-12-16 14:36:06 +00:00
jenkins-bot 46c2cafdf6 Merge "ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing" 2015-12-16 06:44:45 +00:00
Translation updater bot b02b68626a Localisation updates from https://translatewiki.net. 
Change-Id: I2bcafc960dedf619d0c81163a7a75253b377a79d
 2015-12-15 22:25:56 +01:00
Alex Monk c99a5b627e DesktopArticleTarget: Change tab text on server side when possible 
Usually. Unless you load VE, because then you might be loading on
`action=edit` in remember-last mode and therefore the tab text needs to
be updated from "Edit source" to "Edit". Or "Create source" to "Create".
Or the equivalent with 'local description' in the case of pages from
foreign file repos, etc.

Bug: T120970
Change-Id: I8f07be6c8e415b40ad134ee82d0bda1d63cc4f96
 2015-12-15 10:49:45 -08:00
Alex Monk 76a12f2f9b Try to actually resolve visualeditor-editor preference setting when switching editors 
Seems we need to make sure this returns before navigating to the target page.
This reverts commit 40807a0743.

Bug: T121122
Change-Id: I4edf03bc0d57b03897d9f1802eabd8f0dd9962b9
 2015-12-15 17:35:22 +00:00
Ed Sanders f87d92a167 ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing 
Otherwise temporary changes to the previewNode will pollute the original
doc's model tree.

Bug: T121488
Change-Id: I6a6b3d904061b0ce6e0c513ad424aabc3c4472b5
 2015-12-15 14:40:07 +00:00
jenkins-bot b08c8bd682 Merge "Fix up "Simplify some SET logic"" 2015-12-15 02:56:45 +00:00
Alex Monk 39af893c75 Fix up "Simplify some SET logic" 
By 'simplifying', I broke stuff.

This reverts commit b7227f96fe.

Change-Id: I46fdcf336f556680fa72df0893447b6850cc4b1d
 2015-12-15 02:50:15 +00:00
jenkins-bot d3d851f394 Merge "Simplify some SET logic" 2015-12-14 21:17:15 +00:00
Alex Monk b7227f96fe Simplify some SET logic 
Change-Id: Ie89260607f0253dd7d749af7426702985a0340f4
 2015-12-14 21:11:15 +00:00
Translation updater bot 0200bbf328 Localisation updates from https://translatewiki.net. 
Change-Id: I43deefad46e60797eda66e10c37eed67a61c141b
 2015-12-14 22:06:23 +01:00
jenkins-bot 33cbf199f1 Merge "Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"" 2015-12-14 20:53:28 +00:00
Jforrester 40807a0743 Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 
This reverts commit 5b083a7272.

Change-Id: Ieac905b80ea219075b4de498d645f22c3e86c5ca
 2015-12-14 20:46:08 +00:00
Bartosz Dziewoński ca81362afd ve.ui.MWMediaDialog: Make the dialog higher (600px) 
Avoids a scrollbar for option 4 of the A/B test from T120867.

Change-Id: I3eacb560117219febd6e08066599e2d4d42df219
 2015-12-14 20:53:32 +01:00
jenkins-bot d750417545 Merge "Take pageCanLoadVE into account when figuring out whether VE will load in-page or not" 2015-12-14 17:14:41 +00:00
jenkins-bot 04d8089db6 Merge "Fix setEditorPreference call" 2015-12-14 17:08:42 +00:00
Alex Monk 774034b553 Take pageCanLoadVE into account when figuring out whether VE will load in-page or not 
Bug: T121342
Change-Id: I84ade6e2ab062597fbfd859a90a864c7607547da
 2015-12-14 16:58:26 +00:00
Alex Monk a3148a1559 Fix setEditorPreference call 
Added brokenly in I82e39752

Bug: T121343
Change-Id: Ie7b228e94458b17d6ec7c23be264144dec9563be
 2015-12-14 16:49:28 +00:00
jenkins-bot 51d493918b Merge "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 2015-12-14 16:46:02 +00:00
jenkins-bot 648457ca4c Merge "Switch numbered link context to "delete" instead of "clear"" 2015-12-14 01:19:22 +00:00
Translation updater bot a6bab3aeff Localisation updates from https://translatewiki.net. 
Change-Id: I9b6d4fa66a9a18160d5143de1ed1c6e783bd0ed3
 2015-12-13 22:24:39 +01:00
James D. Forrester 5b083a7272 DesktopArticleTarget: Don't abort in SET mode if veswitched is set 
Bug: T121122
Change-Id: I6dca85361be0c1c1c0d39b12b167af813706ae0b
 2015-12-11 18:15:25 -08:00
James D. Forrester 2368171fb7 DesktopArticleTarget: Consolidate editor preference setting code 
Change-Id: I82e3975233eee0473b513d0931a2d6770fc0f86d
 2015-12-11 17:12:28 -08:00
Alex Monk 0774bdf924 Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks 
To use
	.then( function ( opened ) { return opened; } )
	.then( function ( closing ) { return closing; } )
	.then( function ( data ) {
etc. instead of nesting them in .done functions

Change-Id: Ic8cee9639b90cb378ce0b7e58dc04eab0ff4cbc7
 2015-12-11 23:43:13 +00:00
Alex Monk 155d0240a4 Remember switching into VE from WT when discarding changes 
Bug: T120966
Change-Id: I9a7b87cb2561416b72f53afa5140e9d2a4330cfe
 2015-12-11 23:35:59 +00:00
Alex Monk 9e5a01aa6b Check that we really want VE before loading it for section edits 
Bug: T121189
Change-Id: I34371bf78d34e9d362e9cf5c64bdd108478969b9
 2015-12-11 23:19:07 +00:00
Translation updater bot e71f1d67d6 Localisation updates from https://translatewiki.net. 
Change-Id: Ife97e1435802802dfeb7754fcea6874433bc6b0d
 2015-12-11 23:56:38 +01:00
jenkins-bot e24e2ed7cf Merge "[BREAKING CHANGE] Create ve.init.mw.Target base class" 2015-12-11 18:16:22 +00:00
jenkins-bot 2e6719c0d7 Merge "Use upstreamed actionGroups functionality" 2015-12-11 18:09:50 +00:00
Ed Sanders aa2e0af348 Update VE core submodule to master (19e50b7) 
New changes:
e536779 [DEPRECATING CHANGE] Rename link inspector tools
3899967 Localisation updates from https://translatewiki.net.
0a1c09e [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets

Local changes:
* Refactor tools for the breaking change

Change-Id: I676af9c50b09ef007926240eb2327d1a0fdd80f5
 2015-12-11 10:03:02 -08:00
Ed Sanders fbb05fb8ed Use upstreamed actionGroups functionality 
Depends on I272175dff3 in ve core.

Change-Id: I94cef0f3d8c1b903780890934c2c4963cbe05989
 2015-12-11 16:43:48 +00:00
Ed Sanders 21d5856000 [BREAKING CHANGE] Create ve.init.mw.Target base class 
Move over logic which isn't specific to the article
implementation of VE (e.g. nothing related to loading/saving).

Refactors setupSurface to use an abstract tracking method (which
does nothing by default), and moves surface CSS classes to #createSurface.

Breaking change:
* Rename onSurfaceReady to surfaceReady. We shouldn't need to listen
  to our own events.
* Rename onReady to documentReady. onReady is not a listener.

Bug: T97166
Change-Id: I7242b1bb5501b7755a18a13d13e166c30cac9cdd
 2015-12-11 16:41:47 +00:00
Ed Sanders 672c91f41b DesktopArticleTarget: Fix signature of editNotices 
Also ensure it is always an array.

Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
 2015-12-11 16:41:47 +00:00
Alex Monk 98a456b189 Single edit tab: Fall back to the wikitext editor when certain parameters show up 
We can't handle these yet. There's also 'preview' but I think we probably
qualify as supporting that.

Bug: T121126
Change-Id: I4602992a77f460b9bfcbad0eac1bdd79d67df04d
 2015-12-10 23:13:25 +00:00
jenkins-bot 69778a65e5 Merge "Let the feedback tool be configured for a remote wiki" 2015-12-10 22:04:23 +00:00
Translation updater bot 46b901e640 Merge "Localisation updates from https://translatewiki.net." 2015-12-10 22:02:32 +00:00
Translation updater bot 536ff00e5a Localisation updates from https://translatewiki.net. 
Change-Id: Ide641aaf9ffec8558271116f9a3a29c1307ed588
 2015-12-10 23:01:35 +01:00
jenkins-bot 3db4f22ecf Merge "MWSaveDialog: De-flag the 'return to save' button on diffs" 2015-12-10 21:51:01 +00:00
James D. Forrester 705199753c Let the feedback tool be configured for a remote wiki 
Bug: T92661
Change-Id: Id48729c89db208714f67fec1eabafe577a834b51
 2015-12-10 12:12:59 -08:00
Ed Sanders 29f33a57d5 Rename mw.Target to mw.ArticleTarget 
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).

Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
 2015-12-10 16:26:20 +00:00
Alex Monk 128901866a Don't check editor preferences etc. if user wants veaction=edit 
Bug: T120978
Change-Id: I39e28c80440260959b7f1c25b82a057c21de43be
 2015-12-09 23:04:02 +00:00
jenkins-bot 212300af1f Merge "Avoid useless jQuery.click shortcut" 2015-12-09 22:18:12 +00:00
Translation updater bot d08da2d62f Localisation updates from https://translatewiki.net. 
Change-Id: Ibbc339a27888a391c6c40ced26c154cabb29acf7
 2015-12-09 21:43:17 +01:00
David Lynch e9fbb38818 Switch numbered link context to "delete" instead of "clear" 
Bug: T120705
Change-Id: I305a0469df8ca3fd75bcd371cf9b9f8894c09f7e
 2015-12-09 12:42:20 -06:00
Ed Sanders e7ccc77000 Edit mode switching: Tell VE if the wikitext was modified 
Currently we assume that any document state from WE is modified
but that is not necessarily the case.

Change-Id: I085825152528ae5a5e973e8b44f68cb07ee92416
 2015-12-09 17:44:43 +00:00
Ed Sanders e9250d87fd Avoid useless jQuery.click shortcut 
Why have one event API when you can have ten...

Change-Id: I645cbeb4e486aba9e734ba47d2e7c3958a694f19
 2015-12-09 17:34:00 +00:00
jenkins-bot a9894809f6 Merge "DesktopArticleTarget: Handle section edit link clicks in single edit tab mode" 2015-12-09 17:16:12 +00:00
Alex Monk b877e16723 DesktopArticleTarget: Handle section edit link clicks in single edit tab mode 
Bug: T58337
Change-Id: Ic4c19cdfc3cfcf33604d0c4e7780b45967cdf57d
 2015-12-09 09:08:46 -08:00
Ed Sanders ae26eefb05 Fix typos 
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
 2015-12-09 16:47:13 +00:00
jenkins-bot 6c1e613fa4 Merge "Make clear button on numbered external links remove the node" 2015-12-09 16:26:29 +00:00
jenkins-bot 87ce2f0a20 Merge "EducationPopup: Increase z-index above toolbar dialog's" 2015-12-09 16:26:26 +00:00
David Lynch 7b66083319 Make clear button on numbered external links remove the node 
Bug: T120705
Change-Id: I07d57ba95f46f0fa80f9038ccb42d8d89375fd23
 2015-12-09 10:11:54 -06:00
Ed Sanders 1121dc5295 EducationPopup: Increase z-index above toolbar dialog's 
Bug: T116577
Change-Id: Icb91dcebd450f954b8bae18ee57f75386de754ac
 2015-12-09 15:56:08 +00:00
jenkins-bot 2efbdc670c Merge "Single edit tab and section links" 2015-12-09 00:40:46 +00:00
Ed Sanders 4513283140 ve.ui.Icons.css: Fix inpsector typo 
Change-Id: I9cb7f6ff38e26632d04a1ffc65ae468a5ee301cc
 2015-12-09 00:18:46 +00:00
James D. Forrester ccc087c461 MWSaveDialog: De-flag the 'return to save' button on diffs 
Change-Id: Icb7c07dae23b7f3ba1b4cdf6c73f17a1bbff1bdf
 2015-12-08 13:31:44 -08:00
Translation updater bot ce89f917df Localisation updates from https://translatewiki.net. 
Change-Id: Ie88cfc5d6f943fb52e25c0dd54fe907120dec972
 2015-12-08 22:26:41 +01:00
Alex Monk 748db015b0 Single edit tab and section links 
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible

Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
 2015-12-08 17:47:16 +00:00
Translation updater bot bd5a6242f1 Localisation updates from https://translatewiki.net. 
Change-Id: I251067f1f7b60e3972f725aa192f2cb90178dc8d
 2015-12-07 23:16:10 +01:00
jenkins-bot 4be9c9178e Merge "MWTemplatePage: Re-word the no-description text to reflect being always there" 2015-12-07 22:07:17 +00:00
Bartosz Dziewoński ae8a275095 MWTemplatePage: Re-word the no-description text to reflect being always there 
The <visualeditor-dialog-transclusion-no-template-description> message
is now always displayed in template transclusion dialog, both when
adding a new one and when editing existing one. I think it's best to
just remove the incorrect part, as the dialog provides sufficient
context for what is happening.

The $2 parameter is no longer used or documented, but is still
supported for compatibility with existing translations.

Bug: T87130
Change-Id: Ibaa06c3bb1e9afbf0005b1605236f4be8cb15251
 2015-12-07 21:59:03 +00:00
jenkins-bot db7bec4825 Merge "MediaDialog: Remove useless empty object arg to media size widget" 2015-12-07 19:21:11 +00:00
Ed Sanders a917871505 GalleryInspector: Use namespace id constant 
Change-Id: Ia51634e84cf984d8ed4ecdab87590111bf12478f
 2015-12-07 18:49:53 +00:00
Ed Sanders 557eb4fe84 MediaDialog: Remove useless empty object arg to media size widget 
Change-Id: Id85498616f80147cd856d4d12bf5a0e58ad66029
 2015-12-07 14:12:56 +00:00
Translation updater bot 83620175ca Localisation updates from https://translatewiki.net. 
Change-Id: I3d109b133ee6d709a937013bb9eb825800c98775
 2015-12-06 21:45:56 +01:00
Translation updater bot db13a4d43a Localisation updates from https://translatewiki.net. 
Change-Id: I0d6dede3ef71b7729db66646875c308d50296d81
 2015-12-05 23:16:10 +01:00
Ed Sanders 63184600d4 Use wgNamespaceIds constants instead of hard-coded numbers 
Change-Id: I71b80e59a5e24d63e68637a1ae8422974643bd3a
 2015-12-04 19:57:56 +00:00
Translation updater bot 6ceb0c39e6 Localisation updates from https://translatewiki.net. 
Change-Id: Ie307b6e81958bb16c96a0ffff6b3568139564f4f
 2015-12-03 23:17:58 +01:00
James D. Forrester 3c9a361da0 MWMediaDialog: Add a margin back to the border checkbox 
This was removed upstream in OOUI as unecessary in general, but clearly
this was the place for which the rule had been designed. :-)

Bug: T119547
Change-Id: I46a1df1141c337b436e66872f1a8cdae026816cd
 2015-12-02 18:28:18 -08:00
Translation updater bot 7e50ac1ab6 Localisation updates from https://translatewiki.net. 
Change-Id: I2180bc4edca07261381b2790af6ebc29e0fde97f
 2015-12-02 22:01:03 +01:00
Translation updater bot d924ded91e Localisation updates from https://translatewiki.net. 
Change-Id: Ia694075416ebb62d351441419089d2570943ccf8
 2015-12-01 21:37:34 +01:00
Translation updater bot 3772e473d5 Localisation updates from https://translatewiki.net. 
Change-Id: I4133263c6d9228e867cb54be4b706e8f21a2bbc1
 2015-11-30 21:38:08 +01:00
jenkins-bot e24eaea22c Merge "Avoid embedding Git metadata in ext.visualEditor.data" 2015-11-30 11:48:28 +00:00
Ori Livneh b1db8349fe Avoid embedding Git metadata in ext.visualEditor.data 
Partially reverts "Expose version information in the client" (a72099af66 / I7836e1d40).
The Git data oscillates between two values due to differences between the
staging and production environments. Each change causes the module version to
change also, leading to cache churn.

Instead fetch version information with an API call the first
time the help popup is opened.

Bug: T119750
Change-Id: Ib9c45e60d3164cfa85eb1ef247cc91cf0d8bf954
 2015-11-30 12:34:56 +01:00
Translation updater bot 24046cb548 Localisation updates from https://translatewiki.net. 
Change-Id: I24ccb4b7af6241ed77eb47970d821262454ac26e
 2015-11-28 21:49:42 +01:00
Translation updater bot 1b176cba81 Localisation updates from https://translatewiki.net. 
Change-Id: I459d7ee237ffa2ba146bbd82059e5e22f92234b5
 2015-11-27 22:48:54 +01:00
Translation updater bot b367964ad6 Localisation updates from https://translatewiki.net. 
Change-Id: I57f93b07e2179ec7cbb75866094dd98f64b54f9c
 2015-11-26 22:06:32 +01:00
jenkins-bot 2a46cc7873 Merge "Add autocomplete options to AceEditorWidget config options" 2015-11-25 03:48:38 +00:00
Thalia 3d98b1d291 Add autocomplete options to AceEditorWidget config options 
Bug: T119549
Change-Id: I57db44c876c5cb0487bda6a72e36fedaccb532b5
 2015-11-24 19:44:41 -08:00
jenkins-bot 4655ba4c5c Merge "MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one" 2015-11-25 02:53:36 +00:00
James D. Forrester b68e34fdeb MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one 
Depends on If4ec151a in OOUI.

Bug: T111100
Change-Id: I90af27a7ba881c588b8a432f1cc1e54ab4c80f79
 2015-11-24 18:40:13 -08:00
Translation updater bot 0bfa4b7001 Localisation updates from https://translatewiki.net. 
Change-Id: I4894709e82769d5161cf39a6488ae1666d5690d6
 2015-11-24 23:12:39 +01:00
Ed Sanders bbdb48abdf Create MWPreviewElement which adds the mw-body-content class 
This fixes some rendering issues, and also increases the font
size of reference contexts from 12.8px (interface) to 14px (content).

Bug: T119430
Change-Id: Ib1bae8cd4cfe86903d78406a33db78e1489fde86
 2015-11-23 14:28:57 -08:00
Translation updater bot 23270f87f9 Localisation updates from https://translatewiki.net. 
Change-Id: I045fa54ee959371101a2fc62238d8b10ccb348b0
 2015-11-23 22:36:41 +01:00
jenkins-bot 22a8c76d09 Merge "When adding a label to a numbered link, force the selection" 2015-11-23 19:02:04 +00:00
jenkins-bot 5649256ceb Merge "Re-fix in-page loading" 2015-11-23 17:00:13 +00:00
jenkins-bot 4616696e0d Merge "Prevent switching from unedited section directly into VE" 2015-11-23 17:00:08 +00:00
Translation updater bot 7698beb14e Localisation updates from https://translatewiki.net. 
Change-Id: I8bde2353b3bb3f950a329f033b87602b107bd722
 2015-11-22 20:48:25 +01:00
David Lynch 50759e2064 When adding a label to a numbered link, force the selection 
Otherwise the selection will/won't contain the opening node of the
link, depending on where in the paragraph it is. This makes the
experience of starting to type unpredictable to the user. By forcing
it to always have the contents of the node selected, typing always
just updates the label.

Bug: T114643
Depends-On: I7c46a917d9752145174919f41066b4841b203218
Change-Id: Ic1c573c2c28ced49f685ec6082506cb20d5163cd
 2015-11-20 18:36:44 -06:00
Ed Sanders 0e30e328ba Update VE core submodule to master (e8c6f7d) 
New changes:
b44ef6d [BREAKING CHANGE] Fix WhitespacePreservingTextInputWidget API
96e4034 Localisation updates from https://translatewiki.net.

Local changes:
* Use new WhitespacePreservingTextInputWidget API

Change-Id: I9920a3b5c8c3e8a241dcfdd1bde20f4ea1cf78b6
 2015-11-20 15:44:49 -08:00
jenkins-bot 5dbe119699 Merge "MW Examples: Fix test message" 2015-11-20 23:38:56 +00:00
jenkins-bot 77f605d2a5 Merge "Add tests for RESTBase ID comparison" 2015-11-20 23:38:53 +00:00
jenkins-bot 8200cffac5 Merge "Improve tests of data-parsoid annotation comparisons" 2015-11-20 23:37:50 +00:00
Translation updater bot 3523279808 Localisation updates from https://translatewiki.net. 
Change-Id: I8658191225f986b896358ebdd98fdefacb143ca0
 2015-11-20 22:59:51 +01:00
Ed Sanders 68755b212e MW Examples: Fix test message 
Change-Id: I4a0b9bb92fa45fca82391943b86a43fec8f2e3a1
 2015-11-20 20:34:18 +00:00
Ed Sanders 287436ae25 Add tests for RESTBase ID comparison 
Depends on I8323bbf34 in core.

Change-Id: I4043322361cdbbfd211133191c062eae42269ca4
 2015-11-20 20:34:12 +00:00
Ed Sanders 3d7d363e9c Improve tests of data-parsoid annotation comparisons 
So that it actually fails if you remove the key feature.

Depends on Iff15190e in core.

Change-Id: I1557f683241193aa4a97e04af0b4daf244a8b121
 2015-11-20 12:32:29 -08:00
Ed Sanders bbfcbeb79d Use ES5 trim instead of jQuery 
Change-Id: I6e8b958176385cb672380454fcc3b4970261caa9
 2015-11-20 11:48:55 -08:00
James D. Forrester 285eb85eb8 ReferenceEducationPopup: Don't flip the numbers in the RTL image 
Bug: T117949
Change-Id: Ia4164773a9c4f1510b8795efb4c93260a3abe672
 2015-11-19 19:31:21 -08:00
Alex Monk a0462d69d4 Re-fix in-page loading 
Probably broken by Ie808bcaa
Partially reverts Icad04dac, hopefully without any regressions

Change-Id: I4589bde7eac58b54027a6b9dbe6ecddf79780599
 2015-11-20 01:57:24 +00:00
Alex Monk 67a51aee9b Prevent switching from unedited section directly into VE 
Bug: T117713
Change-Id: Iee9ae2bbe4757cb07e9aa2bd5f41a46c0ebb391a
 2015-11-20 00:10:38 +00:00
Translation updater bot 360cdacd4b Localisation updates from https://translatewiki.net. 
Change-Id: Iabd0b1ea673697111e28cd959bdf1bca32f72ad6
 2015-11-19 21:41:49 +01:00
jenkins-bot 8fae033411 Merge "AceEditorWidget: Ensure loadingPromise is set when setupEditor runs" 2015-11-19 16:47:13 +00:00
Ed Sanders dbdae59128 AceEditorWidget: Ensure loadingPromise is set when setupEditor runs 
Change-Id: I11d37b863f28bacd4c09992d6fcc180621766577
 2015-11-18 23:11:10 -08:00
jenkins-bot 9f1aedbefc Merge "Make selectRange method of AceEditorWidget focus the input" 2015-11-19 03:28:44 +00:00
Thalia 18448bb42b Make selectRange method of AceEditorWidget focus the input 
The selectRange method does this in TextInputWidget, so it
should here too.

Change-Id: Ib3851e0c72876d3c25ae5992cf9732637238d117
 2015-11-18 19:14:50 -08:00
jenkins-bot 718e06cf1b Merge "Add method to toggle the AceEditorWidget print margin" 2015-11-18 21:46:44 +00:00
Thalia 21fd89ba3c Add method to toggle the AceEditorWidget print margin 
Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
 2015-11-18 13:38:41 -08:00
Translation updater bot a09b6e3a20 Localisation updates from https://translatewiki.net. 
Change-Id: I2affa2a7543343d7f5899b5b55e1cb7e0a954c92
 2015-11-18 22:01:07 +01:00
jenkins-bot 52f151193a Merge "Make focus method of AceEditorWidget chainable" 2015-11-18 20:29:48 +00:00
Thalia 88d466ba23 Make focus method of AceEditorWidget chainable 
The focus method of InputWidget and other descendants
of InputWidget is already chainable

Change-Id: Ib75fb7b08769e86c652c63dac069e2573e61f89a
 2015-11-18 12:21:44 -08:00
Ed Sanders bd40f62c17 Introduce MWExtensionPreviewDialog 
An MWExtensionDialog with a PreviewElement for the selected node,
or node to insert.

Depends on Icd622e15cd7 in VE core.

Change-Id: Ia0f46da2d445dd94c8aa50be73508d9f1afcb816
 2015-11-18 19:33:32 +00:00
jenkins-bot d5562830fd Merge "MWSignatureTool: Restrict command to linear selections" 2015-11-18 06:17:56 +00:00
Ed Sanders 259ec31ece MWSignatureTool: Restrict command to linear selections 
Change-Id: If6109c2ef2a18eccaccf18bd1d76c272a1dc3cd5
 2015-11-17 22:08:23 -08:00
jenkins-bot 761ecc96f4 Merge "AceEditorWidget: Implement getRange" 2015-11-18 06:04:27 +00:00
jenkins-bot 2104ee1590 Merge "Wikitext paste: Fail if result has no visible content" 2015-11-18 03:39:52 +00:00
jenkins-bot df9b4b05b9 Merge "Edit mode switching: Auto-close jQuery.UI dialogs before switching" 2015-11-18 03:36:31 +00:00
Ed Sanders f9ca524ef9 Wikitext paste: Fail if result has no visible content 
For example if '[[category:foo]]' is pasted.

Bug: T118191
Change-Id: I9c51846414dd6b885b33f1dc9076edadbc6464c4
 2015-11-18 03:33:14 +00:00
Ed Sanders a5d700807a AceEditorWidget: Implement getRange 
Depends on I109a666679 in OOUI.

Change-Id: Ie40a30a3743237c1c1cd59dd2165d313363e04cb
 2015-11-18 03:32:54 +00:00
Ed Sanders e1d14099e0 Image/gallery icons: Rename and use new upstream versions 
Depends on oojs-ui > 0.13.2.

Change-Id: Iee4cc52b998626e829fd92346d5ee1295c08f26f
 2015-11-18 01:49:31 +00:00
Ed Sanders 19034b0416 Edit mode switching: Auto-close jQuery.UI dialogs before switching 
Bug: T118282
Change-Id: I7960e4f71dd8b710f2ec2430f2946679af07012b
 2015-11-17 17:26:01 -08:00
jenkins-bot 370a060ffc Merge "AceEditorWidget: Implement selectRange" 2015-11-17 23:49:46 +00:00
jenkins-bot 4785177791 Merge "Make dependencies of jquery.uls.data more specific" 2015-11-17 23:44:07 +00:00
jenkins-bot a40c0082b0 Merge "Make 'moment' a dependency of just 'mwimage', not all of VE-MW" 2015-11-17 23:42:36 +00:00
Ed Sanders 5e96050b48 AceEditorWidget: Implement selectRange 
This is not trivial because Ace selections are
[column,row] tuples, so we need to translate to
one dimensional offsets.

Change-Id: I901b025b3747d61c74f49038fe4a65ed75758211
 2015-11-17 23:39:33 +00:00
Ed Sanders d1da56a6cb Make dependencies of jquery.uls.data more specific 
Change-Id: I135defffc71d8aa61dc74bb871da96737a3eeb0c
 2015-11-17 15:34:23 -08:00
Ed Sanders b5c16ac95c Make 'moment' a dependency of just 'mwimage', not all of VE-MW 
Change-Id: I23c193bfb34203aa6f2ef1d3633c208e5c692c97
 2015-11-17 14:55:10 -08:00
Translation updater bot b4f2194085 Localisation updates from https://translatewiki.net. 
Change-Id: I15540a448677ac4e4b6a0eba024e230ce4846b22
 2015-11-17 21:55:40 +01:00
Alex Monk 889358f24c Ensure we always catch the wikiEditor-toolbar-doneInitialSections event 
Don't wait for module loading. Before, this was only actually working half the
time.

Change-Id: I7fb284a800927672642c59231a322982b613f16b
 2015-11-17 02:23:25 +00:00
jenkins-bot 2fcbc18dff Merge "Provide a tool to insert a signature in namespaces that need it" 2015-11-17 00:16:42 +00:00
jenkins-bot 3e9d040a79 Merge "AceEditorWidget: Allow users to force an Ace editor refresh" 2015-11-16 22:46:24 +00:00
Translation updater bot 64d8e394ce Localisation updates from https://translatewiki.net. 
Change-Id: Iaf8fb457fd0b835d5b8819f5dab015c4a59e0a78
 2015-11-16 22:19:07 +01:00
Ed Sanders 35c44db988 AceEditorWidget: Allow users to force an Ace editor refresh 
Ace is clever about not updating the rendering of elements
which aren't visible, so allow users to force an update, for
example if they changed the value while the whole widget
was hidden.

Change-Id: I7bbbffd17489bc80fe5fa80911f29d7223e125a3
 2015-11-16 12:12:10 -08:00
Ed Sanders 470a4a551b AceEditorWidget: Refactor to ensure setValue runs synchronously 
Also ensure setEditorWidget is only called once when
loadingPromise resolves.

Change-Id: I1a95bda5e9ff17d7575326f29fa01d273193c4a5
 2015-11-16 11:36:08 -08:00
Bartosz Dziewoński 9be5c85db4 Provide a tool to insert a signature in namespaces that need it 
VisualEditor is usually not enabled in talk namespaces... but
sometimes it is. And when users see the button to edit with VE,
they're going to click it and expect to be able to sign their posts.

This tool is only loaded on talk pages and pages in additional
namespaces defined in $wgExtraSignatureNamespaces.

Code adapted with small tweaks from my own gadget
<https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js?oldid=13461327>,
which is already available under the MIT license.

Changes include:
* The tool is now always visible if the wiki allows signatures in any
  VE namespaces, but disabled when not allowed in the current namespace.
* Register '~~~~' sequence to insert the signature.
* Code style tweaks for stricter lint checks in this repository.
* Documentation corrections.

Swedish translation provided by André Costa (already credited
as a translator as Lokal_Profil).

Depends on changes in VisualEditor core:
* I89fe53890ab59d12260ea6b41de802c38c24e8b9
* I14cd7efac521687ea38580341ae08ddc522edeeb

Bug: T53154
Change-Id: I6be5fb2118cf3eef5098d4c5320228aa81411ccb
 2015-11-16 18:06:32 +01:00
Translation updater bot 9d01677f75 Localisation updates from https://translatewiki.net. 
Change-Id: I2e18f18c1614e74a5681ea7e8faf0ce71c1b5db1
 2015-11-15 22:22:40 +01:00
jenkins-bot f44e127eb5 Merge "AceEditorWidget: Emit resize event at end of cycle" 2015-11-15 02:38:22 +00:00
Translation updater bot 8a456d3e31 Localisation updates from https://translatewiki.net. 
Change-Id: I1eb678891af629bf935f2837e76ba5b856d5f9fd
 2015-11-14 22:19:35 +01:00
Ed Sanders b21b939a67 AceEditorWidget: Emit resize event at end of cycle 
Ensures the widget has taken its new size before emitting the event.

Bug: T117926
Change-Id: If1dab2ecadb2a581100c0ae154b341ce8d173a7c
 2015-11-13 18:48:35 -08:00
C. Scott Ananian 236fad19b6 Ensure magic link nodes inherit the annotations of their text 
If you create an autolink in the middle of bolded text, the magic link
should also be bolded.  Similarly, if you convert a bolded simple link
to a magic link, the magic link should stay bolded.

Change-Id: I38c7f3c0c275851049088a37f3b37d815ed38e4e
 2015-11-13 13:48:18 -08:00
Translation updater bot 73918e0e1e Localisation updates from https://translatewiki.net. 
Change-Id: I63a0e4185c61a42cf0d142d520fdc1e7c7f9000f
 2015-11-13 21:35:36 +01:00
Translation updater bot a284d335a8 Localisation updates from https://translatewiki.net. 
Change-Id: I7f7dba15312b3fda8e9a737428f4bc191604ac4f
 2015-11-12 23:02:52 +01:00
jenkins-bot c6aeff4ba9 Merge "Edit mode switching: Separate styles" 2015-11-11 22:33:35 +00:00
jenkins-bot 96f91758f6 Merge "Update VE core submodule to master (77d786a)" 2015-11-11 22:10:08 +00:00
Translation updater bot c1ac8806c6 Localisation updates from https://translatewiki.net. 
Change-Id: I7f3c0dfe04074271159b7f22032c587374f72836
 2015-11-11 21:57:36 +01:00
Ed Sanders 9bcc61e195 Update VE core submodule to master (77d786a) 
New changes:
95589a6 test: Add a Rakefile for new CI requirement
1a4497e ve.ui.DialogTool: Do not require that a command is set
cbf1bff ve.ui.Tool: Fix documentation for getCommandName
530022d Localisation updates from https://translatewiki.net.
9529093 Update OOjs UI to v0.13.2
b8d6c15 Add icon: Rename 'insert' to 'add'
2f3015b Update OOjs to v1.1.10
78ceb18 Fix deletion inside a structural node at start/end of document
ce3e9a4 ve.utils: Use binarySearch from OOjs

Local change:
* MW test cases for new structural deletion logic

Bug: T52250
Change-Id: I643449c1fa08ea12c8c3aa13f4a4b97d8876990d
 2015-11-11 12:35:53 -08:00
Ed Sanders 86a1d1bfa3 Edit mode switching: Separate styles 
Ensures that these styles are loaded *after* OOUI by making
them dependent on it, unlike DesktopArticleTarget.init
which isn't.

Change-Id: Ia1fff16432d20fb56707c5e21c6a930d2478e311
 2015-11-11 18:50:55 +00:00
jenkins-bot c815c3242d Merge "Edit mode switching: Only show WE toolbar button once module is loaded" 2015-11-11 02:21:04 +00:00
jenkins-bot 53dbf3ac2f Merge "Replace 'source' icon with OOUI's 'wikiText' one" 2015-11-11 01:42:00 +00:00
jenkins-bot 1f2905c39f Merge "DesktopTarget: Fix opacity of #siteSub and #contentSub" 2015-11-10 23:39:03 +00:00
Translation updater bot 7bb161d5f7 Localisation updates from https://translatewiki.net. 
Change-Id: Ia25e40a77c416e2dde09b7e68d6e836baf9b3adc
 2015-11-10 22:36:30 +01:00
Ed Sanders cfe3d9b561 Edit mode switching: Only show WE toolbar button once module is loaded 
No point showing the icon if we don't have the functionality to
make it do anything. Also this reduces the number of RL requests
made as we never fetch OOUI separately.

Change-Id: Iac9aa6f34c485223e73981b3377c7d0cfd31dae9
 2015-11-10 10:43:33 -08:00
Alex Monk 6213c23db1 Fix updating of display title upon save 
Bug: T117643
Change-Id: Ibd3d4f056a2d175e52b60b6e3a4c0ece04f26f50
 2015-11-10 13:50:00 +00:00
Alex Monk 87affb5ca4 Restructure education popup code to work without overriding onSelect 
That code was breaking on mobile which uses a subclass of the normal
link inspector.

Bug: T117603
Change-Id: I75541230c21b1ee9eb73f6fb4b1fe5a5f9c14e75
 2015-11-09 23:18:01 +00:00
Alex Monk 5f162522eb Merge "ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work" 2015-11-09 22:42:34 +00:00
Translation updater bot e87b56b53e Localisation updates from https://translatewiki.net. 
Change-Id: Ie37b9b551d0af53d2420af4a798a26c1954ecf0b
 2015-11-09 21:50:10 +01:00
Bartosz Dziewoński 7d69e86265 ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work 
Work around RESTBase problem that causes errors if we try to switch to
VE when the wikitext is empty. This would prevent non-power-users from
opening VE entirely.

This only solves the issue for new empty pages, and not when the user
intentionally empties the edit box. In that case, though, they get a
dialog where they can choose to "keep" or "discard" changes, and
discarding lets you open the editor.

Bug: T118152
Change-Id: Ie808bcaa9826deacac392dd6cbc90a9446602b79
 2015-11-09 18:55:21 +01:00
jenkins-bot b966333009 Merge "Unset 'action' query parameter from veEditUri, which should always point to VE" 2015-11-09 15:26:18 +00:00
Translation updater bot 280b68b183 Localisation updates from https://translatewiki.net. 
Change-Id: I96650b4066bf3a33e0b31e53ddefa15dac49d5b7
 2015-11-08 22:14:22 +01:00
Alex Monk 1e4889bbc7 Unset 'action' query parameter from veEditUri, which should always point to VE 
Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
 2015-11-08 20:32:28 +00:00
Translation updater bot a8dbf5f828 Localisation updates from https://translatewiki.net. 
Change-Id: I37ec76d17c9c7f24c6691d8cb85faf7422f28633
 2015-11-07 22:45:38 +01:00
Alex Monk 3e23d3b96d Only load switching module (depending on OOUI etc.) on edit pages 
This wasn't as bad as T112401 (that was blocking render), but we
still shouldn't be loading the module on page views.

Bug: T118088
Change-Id: If86701ed7ff4e8d6defb1c682aa9a38c211be0fa
 2015-11-07 19:08:29 +00:00
jenkins-bot 69bce26579 Merge "Drop any beforeunload handlers when loading from existing wikitext" 2015-11-07 16:09:50 +00:00
Alex Monk 6247a2f430 WikiEditor integration: Fix dependencies for switch button 
Change-Id: Ic8fb607e8c467e89c0b9af0a9baab84e59b19ba8
 2015-11-07 04:15:14 +00:00
Alex Monk 2910cd2384 Drop any beforeunload handlers when loading from existing wikitext 
Bug: T117769
Change-Id: I823737b17e5af8ed15bc2b62db61a31886e8d418
 2015-11-07 03:57:19 +00:00
jenkins-bot 4a582d7abf Merge "WikiEditor integration: Only add VE switch button if VE is available" 2015-11-06 22:13:36 +00:00
Translation updater bot 5a771525dd Localisation updates from https://translatewiki.net. 
Change-Id: I50f024e4704930c59b8dd225f7ea975351c3e895
 2015-11-06 22:29:08 +01:00
Alex Monk 87931fb3f2 WikiEditor integration: Only add VE switch button if VE is available 
Bug: T117968
Change-Id: Ibfe73b7170083bc9ee0a0322768999c8650da4e7
 2015-11-06 18:23:44 +00:00
Translation updater bot db5c453648 Localisation updates from https://translatewiki.net. 
Change-Id: Ifa98bbba31c83dbd4052674081333991cf7b473d
 2015-11-05 21:46:47 +01:00
jenkins-bot 9f036c10f6 Merge "Update CommandHelpRegistry calls for breaking change in core" 2015-11-05 15:35:48 +00:00
Ed Sanders 216d0ea7a7 Update CommandHelpRegistry calls for breaking change in core 
New changes:
281b543 Slugs: Remove vertical alignment hack
d6ddbe4 Localisation updates from https://translatewiki.net.
94bb263 Follow-up d6ddbe4: Fix build for added language 'sd'
bc8579d [BREAKING CHANGE] CommandHelp: Cleanup registry API

Change-Id: I65e2bfc299fbd60d6bdc7a57a030980b6cb8ab18
 2015-11-05 07:29:44 -08:00
Bartosz Dziewoński 4a1a9bbf82 ve.init.mw.Target: Update TitleBlacklist error code 
The error code has changed after T115258 and is now consistently
'titleblacklist-forbidden' for all TitleBlacklist errors.

The API now also provides information about the exact error message to
display (error.message) and the TitleBlacklist rule that matched
(error.line), but we probably don't have that message client-side, so
we're not trying to display it. Maybe when we can load it (T40280).

Bug: T116198
Change-Id: I32fccc7d0b2b66c739d59db05c568a56d9f07eec
 2015-11-05 04:07:38 +01:00
Ed Sanders 3716682570 CommandHelpDialog: Move registrations to where sequences are defined 
Change-Id: I031575bbf40cd789252ac5e082bb5fa435eab257
 2015-11-04 15:03:58 -08:00
Translation updater bot 3b6ee5ca68 Localisation updates from https://translatewiki.net. 
Change-Id: I09939347d8aec3aadc28673736f50eba94b42c1b
 2015-11-04 21:22:59 +01:00
David Lynch 6df227d4e0 MWCommandHelpDialog: update for core changes 
Also: update VE core submodule to master (61f3fe7)

New changes:
4ef3666 Localisation updates from https://translatewiki.net.
cfa3482 Localisation updates from https://translatewiki.net.
d3486d4 CommandHelpDialog: Rename 'category' to 'groupName'
b5578d1 Localisation updates from https://translatewiki.net.
926595e Update OOjs UI to v0.13.1
61f3fe7 [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog

Change-Id: If651ed30ab85175c7a262d9ccccc2e1613b0f3d6
 2015-11-04 12:01:45 -06:00
jenkins-bot dd897a3e67 Merge "Don't allow keeping changes when switching from wikitext *section* editing" 2015-11-04 16:34:54 +00:00
jenkins-bot 633bc55f9d Merge "Apply same hide/show logic to both education popup dots" 2015-11-04 16:21:22 +00:00
Alex Monk 9c7a058b09 Don't allow keeping changes when switching from wikitext *section* editing 
Bug: T117713
Change-Id: I16f17fa2aa4c9a1b74d8cde072c611e2685f5448
 2015-11-04 16:19:36 +00:00
jenkins-bot d24844af2e Merge "Unbreak 404 handling code" 2015-11-04 16:06:09 +00:00
Alex Monk 6341c4a3b5 Apply same hide/show logic to both education popup dots 
Bug: T117627
Change-Id: Icbde23f396935b7f6275ed89ce264ce5e49ebf6a
 2015-11-04 15:56:40 +00:00
Alex Monk dbf79f15fd Unbreak 404 handling code 
Broken in I2a529434

Bug: T117697
Change-Id: Ic34ef81afdde0851f4935971a808f22cdd5cde89
 2015-11-04 15:31:19 +00:00
James D. Forrester 09800aa249 Replace 'source' icon with OOUI's 'wikiText' one 
Change-Id: Id66d436b9140604ace7ebfbec1f80dc8f3830a20
 2015-11-04 06:15:29 -08:00
jenkins-bot 3b30ea8916 Merge "Source icon: Use double brakcets" 2015-11-04 14:14:52 +00:00
jenkins-bot 4dacc683f5 Merge "Target init: Add edit mode switch icons to VE and WE toolbars" 2015-11-04 14:14:49 +00:00
Ed Sanders 42b3463e7d Source icon: Use double brakcets 
This is now a candidate for upstreaming to OOUI as the
'wikitext' icon, which is slightly larger.

Bug: T111038
Change-Id: I19a287926d6f100d2cb5ed1d713387a2dac56b37
 2015-11-04 14:07:41 +00:00
Ed Sanders b05d9fcb0e Target init: Add edit mode switch icons to VE and WE toolbars 
VE already has a a switch icon in the options menu, so bring that
up to the main toolbar.

Append an OOUI button to the WikiEditor toolbar if present, and bind
to the same functon as the edit tab.

Bug: T49779
Change-Id: Ic1e83ea7b13c4fef68024bf05ffc244060666103
 2015-11-04 14:07:41 +00:00
Alex Monk bc6fe7dc77 Set wgAction when messing with the action URL parameter 
Also get rid of an unused variable.

Bug: T117596
Change-Id: I8479fa930397cff48c3a103f3a2c99e89190dc4a
 2015-11-04 01:41:46 +00:00
Alex Monk eb63b57d32 Fix check for loading from modified action=edit 
Bug: T117596
Change-Id: Icad04dac7dc94927cff9b93b175d4a6c4dddee5a
 2015-11-03 16:19:26 -08:00
Alex Monk b550323b53 Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit 
Change-Id: If03dab6130aed7662b04000b809884a514bb2762
 2015-11-03 23:55:17 +00:00
Ed Sanders 6dd7576941 AceEditorWidget: Add method to clear undo stack 
After the widget is initialised the caller will probably
want to clear the undo stack, so that the first state
is the initial value provided.

Bonus: Add documentation for the widget.

Change-Id: Ia331acc4177e32784061cae55c450eb0f83fd744
 2015-11-03 13:41:09 -08:00
Translation updater bot a9befc64b3 Localisation updates from https://translatewiki.net. 
Change-Id: I9dd2d16b514a0f576f6b886ba16c4db8fc112069
 2015-11-03 21:54:34 +01:00
Ed Sanders 1b40e6434f VESwitchConfirmDialog: Set pending on the correct button 
Button indices were the wrong way around; find the button by
name to avoid future problems.

Change-Id: I778ff11875539d38f5a8905c9ff472fd3bd6baae
 2015-11-03 18:58:59 +00:00
Ed Sanders 28a5d0db84 VESwitchConfirmDialog: Use modes to hide 'keep' button 
Change-Id: I92110ea14ded335db330721c08314c7a20169886
 2015-11-03 18:57:15 +00:00
Alex Monk 07c6c17e5c Unbreak loading of VE in the read page 
Change-Id: Ic3e4e65296fa63b3a7d5114366f2859f4ce3f21d
 2015-11-03 18:16:47 +00:00
Ed Sanders 17898270ee CommandHelpDialog: Move insertions into a separate group 
Also add table and comment insertions.

Change-Id: If87261bf3d01854ab1f7ce1b447589fa8098dcf2
 2015-11-03 17:03:56 +00:00
Ed Sanders 91152e2c05 CommandHelpDialog: Use new method for getting access key prefix 
Change-Id: I85628e9282d7b78a4fdd2ea2f3b0b72019302dcc
 2015-11-03 11:06:54 +00:00
jenkins-bot 36e2e85e53 Merge "Update VE core submodule to master (062cb26)" 2015-11-03 10:59:23 +00:00
James D. Forrester c714eb173c Update VE core submodule to master (062cb26) 
New changes:
6cae77b ElementLinearData: Add another case to hasContent
d2e15f2 SurfaceFragment: Improve handling of delete all
16db2a3 Return 'null' instead of null in ve.Filibuster observers
24de6b2 Introduce key down handlers to separate logic from ce surface
f77fe99 Localisation updates from https://translatewiki.net.
062cb26 Localisation updates from https://translatewiki.net.

Change-Id: I61c94983c7898af219266af3022761638c7578b7
 2015-11-03 10:36:53 +00:00
jenkins-bot adb0c427ef Merge "[PULL THROUGH] Remove resize detection now that TextInputWidget implements it" 2015-11-03 01:47:41 +00:00
Alex Monk f71a5a5bca Dialog for switching between wikitext and visual editing 
Change-Id: I7046ffbe318d046b4baee11f4148ab77fc2af7fd
 2015-11-03 01:36:29 +00:00
jenkins-bot 56af2bb742 Merge "MWSaveDialog: Fix styling of border radii" 2015-11-03 01:28:30 +00:00
jenkins-bot cfef14dd4a Merge "Tags: Switch 'VisualEditor' out for 'the visual editor' as elsewhere" 2015-11-03 01:24:38 +00:00
jenkins-bot 097482bbff Merge "MWEducationPopupTool: Changes to the dot" 2015-11-03 01:24:35 +00:00
Ed Sanders 926d39d54d MWSaveDialog: Fix styling of border radii 
Remove bottom border radii from the <textarea> and apply to
the options bar instead.

Apply different values for Apex and MediaWiki themes.

Change-Id: If727863a87547692ee499d2141c0418658609412
 2015-11-03 01:20:52 +00:00
jenkins-bot ab42a490d9 Merge "AceEditorWidget: Preserve selection on setValue" 2015-11-03 01:17:18 +00:00
Alex Monk 5eaa211d43 MWEducationPopupTool: Changes to the dot 
Make the dot more like the one in the designs, with two circles etc.

Change-Id: Ic3e1b2dcd846c5825455b68697acab44016ee598
 2015-11-03 01:15:44 +00:00
Ed Sanders e582fae840 [PULL THROUGH] Remove resize detection now that TextInputWidget implements it 
This depends on the OOUI release which contains Iaadaf1f9f.

Change-Id: I24d3756d627fc3514d8b476f9af87fdecbaa1e09
 2015-11-03 01:13:26 +00:00
jenkins-bot a0a0f0e2c0 Merge "Allow switching from wikitext to VE" 2015-11-02 23:18:33 +00:00
Translation updater bot 05ce5efbdf Localisation updates from https://translatewiki.net. 
Change-Id: I78ab1b44b18ed3080ee1a1e9ceca58501544abf7
 2015-11-02 22:40:02 +01:00
Alex Monk 85b745666f Allow switching from wikitext to VE 
Just by pressing the VE tab for now

Requires a relatively new version of restbase

Bug: T49779
Change-Id: I2a5294345f5e0f469c1dd1bdd29dbce211571a4e
 2015-11-02 20:55:19 +00:00
jenkins-bot fdafb7e887 Merge "ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up" 2015-11-02 19:08:06 +00:00
jenkins-bot df5eff257c Merge "Add mediawiki-specific sequences to the command help dialog" 2015-11-02 17:33:52 +00:00
jenkins-bot 54782884d5 Merge "[BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set" 2015-11-02 12:22:39 +00:00
Vikas S Yaligar 0971054f40 [BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set 
Bug: T111525
Bug: T90577

Change-Id: I421c4c0ce7bcf7be757d31481940ada58e4c9f20
 2015-11-02 12:18:07 +00:00
Translation updater bot 6096916701 Localisation updates from https://translatewiki.net. 
Change-Id: I1c0c5dd11c8a900da883c4e53d554fcd9d4ac1a8
 2015-11-01 21:41:46 +01:00
David Lynch 8bda88f661 Add mediawiki-specific sequences to the command help dialog 
The extension registers a lot of sequences that don't apply to core
VisualEditor. Pretty much the opposite of the trigger situation, where
almost all are in core. So, merge them into the help dialog.

Update VE core submodule to master (be148ae)
New changes:
7380244 [BREAKING CHANGE] Include sequences in the command help dialog

Bug: T116013
Change-Id: I5ad2939c10140b954fb29e1e50414ab7d79aeab7
 2015-10-31 21:28:57 -05:00
Translation updater bot 3791e5658a Localisation updates from https://translatewiki.net. 
Change-Id: I75b45bcfab4a86d785dfd8052c950ad5edd4e4f3
 2015-10-31 21:08:22 +01:00
Translation updater bot 8303873ced Localisation updates from https://translatewiki.net. 
Change-Id: I86d151740c187a018a7e33afc88c601e614f8dd7
 2015-10-30 21:51:06 +01:00
Ed Sanders bd22be33db AceEditorWidget: Preserve selection on setValue 
Also avoid calling setValue when the value hasn't changed
so as not to pollute the undo stack.

Change-Id: I07fc5db0480a8583b361d472723f863ca90046f7
 2015-10-30 16:14:09 +00:00
Thalia 7731508134 Make new error element 
Bug: T114754
Change-Id: I5839ba62fe4b4708ff51dc549c5294189d7f8843
 2015-10-29 22:32:42 +00:00
Translation updater bot a3dc541e0c Localisation updates from https://translatewiki.net. 
Change-Id: I2fdbb79b00eec6579f53e66c7395998d209424d2
 2015-10-29 21:27:15 +01:00
Ed Sanders 2c2f8c8a04 MediaSearch: Order search results correctly 
Bug: T117036
Change-Id: Ia11f3486214425f203695a6060e304a90eba7734
 2015-10-29 12:51:22 +00:00
Bartosz Dziewoński 0238c53262 ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up 
Depends on I65a92e3915a6844056fb7b3a2758a168eb12e6b8 in MediaWiki core.

Change-Id: If59979f30315c7a2164457108362803544431615
 2015-10-28 22:31:45 +01:00
Translation updater bot 3583645f59 Localisation updates from https://translatewiki.net. 
Change-Id: I949f0feecd93fb5d5de5427b760240c9432a3704
 2015-10-28 21:56:56 +01:00
Translation updater bot bd80afd598 Localisation updates from https://translatewiki.net. 
Change-Id: I803c50fa52067ed7912adb800b84dc28f27a9d8b
 2015-10-27 21:33:59 +01:00
Ed Sanders def886b845 AceEditorWidget: Make setters chainable and support invalid flag 
Change-Id: I78f395459f526164c0c506beec62a0083817e64b
 2015-10-27 19:02:17 +00:00
Ed Sanders b222696675 DesktopTarget: Fix opacity of #siteSub and #contentSub 
siteSub and contentSub are both children of bodyContent so
no need to give them opacity directly.

Bonus: Make them user-select:none to avoid confusion as they
are in the edit area.

Bug: T116755
Change-Id: Iea4c35abc1eedb892e02c54b61e40726fa2b096e
 2015-10-27 14:41:45 +00:00
Krinkle 59f55fbb9b Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName" 
Shouldn't be needed once T116693 is fixed.

This reverts commit 39bb635a60.

Change-Id: I545a9eba85f15dcae00c5f117939960acf4113d2
 2015-10-27 01:07:47 +00:00
Roan Kattouw 39bb635a60 DesktopArticleTarget.init: Tolerate missing wgRelevantPageName 
For some reason this happens on some zhwiki pages.

Bug: T116693
Change-Id: I2880b8e7f2ed933928b155dd8727012f79854e1d
 2015-10-26 16:31:44 -07:00
Translation updater bot 4245756344 Localisation updates from https://translatewiki.net. 
Change-Id: I6877fd0a9b91bc25e162dd45d366018e7b05e2af
 2015-10-26 21:05:19 +01:00
Ed Sanders 35b9c4119a AceEditorWidget: Use mw.loader#getState instead of private moduleRegistry 
Change-Id: I845651af837ccc042b6193876e17ba2b571dfe9c
 2015-10-26 09:31:37 +00:00
Translation updater bot 565a10da61 Localisation updates from https://translatewiki.net. 
Change-Id: I937839d0970a94312dfa12aa2aa282b45a4d9d80
 2015-10-25 22:09:01 +01:00
Timo Tijhof 51369ab9ab mw.TargetLoader: Avoid private mw.loader#moduleRegistry property 
Follows-up 28f3a02e56.

* Use mw.loader#getState() instead of private 'moduleRegistry'.
  This property is not a supported API and may change at any time.

* Use plain push() instead of splice(). The order of modules
  is insignificant as dependencies are enforced by module registry
  only. Besides, the order is additionally normalised both
  client-side and server-side by ResourceLoader.

Change-Id: Id9291c97c3bfc01c4cf203aa7b15629fb8412f5b
 2015-10-24 22:26:14 +01:00
jenkins-bot bc5e827ffb Merge "AceEditorWidget: Use showLineNumbers instead of showGutter" 2015-10-22 23:24:53 +00:00
jenkins-bot 724aeb9b33 Merge "Add theme-specific drop shadows to target loading bar" 2015-10-22 23:06:58 +00:00
jenkins-bot a67c62a754 Merge "Create separate skinStyles for target loading bar" 2015-10-22 23:06:56 +00:00
Ed Sanders 21aec73795 AceEditorWidget: Use showLineNumbers instead of showGutter 
The gutter is still useful even if line numbers are hidden.

Change-Id: Ia85ce7cd4987eb0b7022dc35cfd1029fbe78e3dc
 2015-10-23 00:04:57 +01:00
jenkins-bot 2018249d97 Merge "Create more MW sequences" 2015-10-22 21:49:54 +00:00
Ed Sanders 07d56b6b5d Create more MW sequences 
* '{|' for tables
* '<!--' for comments
* '<gallery' for galleries

Change-Id: Ib78c411bf8676bc1974bb80515fd56c642cd67b7
 2015-10-22 22:23:13 +01:00
Translation updater bot 7317ee1f2c Localisation updates from https://translatewiki.net. 
Change-Id: Ic63f9b48379735da1b506ea7f7e447c0196c761e
 2015-10-22 22:05:34 +02:00
Bartosz Dziewoński cf6178f3a1 ve.ui.MWMediaDialog: Reset upload booklet when done uploading 
Bug: T115380
Change-Id: I7c252a08cc2f09385102650e4d437e74d3919e59
 2015-10-22 20:30:44 +02:00
jenkins-bot 9e74b26c41 Merge "ve.ui.MWMediaDialog: Correct harmless typo in method name" 2015-10-22 18:26:15 +00:00
Bartosz Dziewoński 777fc0445e ve.ui.MWMediaDialog: Correct harmless typo in method name 
Change-Id: Ibeb037896123349edac6bc74ab0d9541a2a63e93
 2015-10-22 20:18:43 +02:00
Bartosz Dziewoński c5434b2db8 ve.ui.MWMediaDialog: Only disable 'upload' and 'save' actions on setup, not on tab switch 
When the tab is switched, we already set a mode that doesn't allow
using these actions.

Bug: T116299
Change-Id: Ib3ba50f578face3d49bcd14e41afe01a3b3d15af
 2015-10-22 20:12:03 +02:00
Bartosz Dziewoński bc9487cc8e ve.ui.MWMediaDialog: Move upload booklet init further up 
The first time this is called, it will try to switch panels, so it has
to be done before we switch to the right panel.

Bug: T116217
Bug: T116219
Change-Id: I22411024995e22ae65bde1e6418748aedf026b1b
 2015-10-22 19:44:39 +02:00
jenkins-bot bc15c3e189 Merge "Move sequence registrations adjacent to commands" 2015-10-22 16:12:38 +00:00
jenkins-bot ca982073aa Merge "Introduce Ace editor widget" 2015-10-22 15:47:07 +00:00
Ed Sanders c9fc5fb171 Add theme-specific drop shadows to target loading bar 
As a modal popup it should have a drop shadow

Change-Id: I5b4a07c268c30124ed7ba6cc5391005595abeb7b
 2015-10-22 16:02:25 +01:00
Ed Sanders 9749ff5187 Create separate skinStyles for target loading bar 
Change-Id: I74eff697711641a7c111564ddb9e493ad358b8d4
 2015-10-22 16:01:44 +01:00
Ed Sanders 57d33a291e Move sequence registrations adjacent to commands 
If a command is not registered because a file/module is not
loaded, the sequence should not be loaded either.

Change-Id: I45d86ad371c7b717601b6593eaa573292ebdd4ed
 2015-10-22 15:15:41 +01:00
Ed Sanders 28f3a02e56 References: Don't load ext.visualEditor.mwreference if Cite is not installed 
Ultimately we should move all the code for this module to the cite
extension.

Bug: T41621
Change-Id: Ia2fcc9513ae806aaa173770337f176d5dbf59709
 2015-10-22 11:36:17 +01:00
Ed Sanders 524c2c9ee0 '<ref' sequence: Trigger basic dialog if Citoid not installed 
Change-Id: Ibb7589e760e5583e12581cd4fc07dc88101420ea
 2015-10-22 11:21:20 +01:00
Ed Sanders 60c1ee7d56 Introduce Ace editor widget 
The widget attempts to load the ext.codeEditor.ace.modes module
and if it fails, will fall back to regular TextWidget behaviour.

Bug: T49742
Change-Id: Ie483f6eba25e3732a396c18decc0e1844b806b23
 2015-10-21 20:59:08 +01:00
Translation updater bot 15748bde2d Localisation updates from https://translatewiki.net. 
Change-Id: I4cef8d64023e3af574eb9d746098858b4cb39d46
 2015-10-20 22:52:49 +02:00
Translation updater bot ab7394f674 Localisation updates from https://translatewiki.net. 
Change-Id: I6ad4b1bbd99e737e50e43ffa50bd5efead3142b0
 2015-10-19 22:22:09 +02:00
Translation updater bot 0df380a3d5 Localisation updates from https://translatewiki.net. 
Change-Id: I9480dfe3fb12c4dbbbb5d660d54911067415d1d6
 2015-10-18 21:58:41 +02:00
Translation updater bot 07b66e4703 Localisation updates from https://translatewiki.net. 
Change-Id: Ia7021c4366ffa854444796ac70bd2a299ee72f13
 2015-10-16 22:07:09 +02:00
Ed Sanders 760d9c130c EducationPopup: Tidy up DOM and CSS 
Change-Id: I4effa34a4d3ddfca0f6ee61fe169a726dc0ec3f6
 2015-10-15 22:35:30 +01:00
Translation updater bot 692a2a37e1 Localisation updates from https://translatewiki.net. 
Change-Id: I9050b383581d6950a4de2ad58f2600918f7c37d5
 2015-10-15 21:33:25 +02:00
Ed Sanders 5bde3be8a6 Browser tests: Fix selectors for strikethrough and underline 
Change-Id: I94010005369b225494f5e603d71d1f57941d7db0
 2015-10-15 15:49:01 +01:00
Translation updater bot e64d143678 Localisation updates from https://translatewiki.net. 
Change-Id: I4a8d12cd63d7ecc11106cdcdbee74060183796e8
 2015-10-15 09:53:04 +02:00
jenkins-bot a9d9ab1ae8 Merge "Followup 9d6fbc894e: fix JS error in education popup" 2015-10-15 00:38:48 +00:00
jenkins-bot eb8695f7ee Merge "Browser tests: Fix table test" 2015-10-15 00:32:53 +00:00
jenkins-bot 09428d13a1 Merge "Browser tests: Fix media insert test" 2015-10-15 00:30:43 +00:00
jenkins-bot 44c3f31e77 Merge "Browser tests: Update link inspector tests" 2015-10-15 00:30:41 +00:00
jenkins-bot d839c37c31 Merge "Revert "[Browser tests] Wait for save button to be enabled"" 2015-10-15 00:24:07 +00:00
Roan Kattouw 17a5cf6a93 Followup 9d6fbc894e: fix JS error in education popup 
If a tool had an education popup bound to it, but it was
suppressed because the user has already seen it (according to
the cookie or localStorage), then clicking that tool would
cause a JS error.

Also remove a workaround for a ClippableElement problem
that appears to be unnecessary.

Change-Id: I73a3f5f9cc1726e28e70fc545b72960afc5ac41c
 2015-10-14 16:32:14 -07:00
jenkins-bot 81a89952ef Merge "Educational popups and highlights for links+citations" 2015-10-14 21:52:50 +00:00
Ed Sanders 780d42b295 Browser tests: Fix table test 
Change-Id: Ib2751cd58dd134f61f94e0a0e8c9c3540a7f26ea
 2015-10-14 22:27:42 +01:00
Ed Sanders 4cbcfe8b66 Browser tests: Fix media insert test 
Change-Id: I55c9247d235fa7ed4e020c62338d42a88d6c2358
 2015-10-14 22:27:42 +01:00
Ed Sanders 2948d0b324 Browser tests: Update link inspector tests 
Change-Id: I5e902b4ab3215450a4374fb7327159d3edfc5ef2
 2015-10-14 21:29:14 +01:00
Esanders 60e3b55393 Revert "[Browser tests] Wait for save button to be enabled" 
This reverts commit 122be9c95a.

Change-Id: Ia79636d5fdcf3f1a224c93688c164bf1030c3bee
 2015-10-14 21:27:21 +01:00
Translation updater bot b6546f0bc3 Localisation updates from https://translatewiki.net. 
Change-Id: I9b9643f7774b9adb6b1ebf4f46903f4a416bf700
 2015-10-14 21:57:12 +02:00
jenkins-bot 41b168b0ec Merge "[Browser tests] Wait for save button to be enabled" 2015-10-14 19:08:23 +00:00
jenkins-bot d9788db376 Merge "Browser tests: Add API URLs to environments.yml" 2015-10-14 17:28:17 +00:00
Ed Sanders 36652a721a Browser tests: Add API URLs to environments.yml 
Change-Id: I524eb984cf04baeacfc131f482b2a773636dc87f
 2015-10-14 17:42:49 +01:00
Ed Sanders 4943127cde Link inspector: Show redlink in suggestions 
This feature was accidentally dropped when the widget was moved to core.

Change-Id: I302b4b001f1db64b023dae73e36c85e491617e92
 2015-10-14 17:24:53 +01:00
Ed Sanders 122be9c95a [Browser tests] Wait for save button to be enabled 
In some tests the save button won't be available for a few ms
until the latest transaction has been pushed to the undo stack.

Change-Id: If03f03b033a21a039a322ca32983d0302e44efbb
 2015-10-14 15:28:14 +00:00
Prateek Saxena d1bf196f68 Media upload: Initialize booklet before setting file on drag drop 
Calling initialize will clear all fields including the
OO.ui.SelectFileWidget that was just set.

Follows up I521909d27c390faad7d62f717f2b97b7676e5a63.

Bug: T40031
Change-Id: Ibc7ddafae9cb7718372520245a356938f4731479
 2015-10-14 12:49:31 +00:00
Ed Sanders e1f9adebfe Rename ImageTransferHandler to MediaTransferHandler 
Change-Id: If68e2e4a9dbff4707fb9cbbadcd69a7ff8375a4b
 2015-10-14 12:41:25 +00:00
Ed Sanders a6c4c3b3e1 Follow-up Id473b45: Call getResults on input widget 
Bug: T115448
Change-Id: I8bfbb3092aa49750930c6437b0526a8b900722f1
 2015-10-14 11:34:36 +00:00
jenkins-bot cbddb00638 Merge "Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description'" 2015-10-14 02:39:50 +00:00
Translation updater bot 9aaf5c933e Localisation updates from https://translatewiki.net. 
Change-Id: I2d386399a32f2c20034fce0e96921f578b01a813
 2015-10-13 22:14:15 +02:00
Ed Sanders 7f2d9d0042 Media upload: Use new setFile method 
Depends on I30ec98be0 in MW core.

Change-Id: Ied82ac8fd25a1c4b9818029429231ce2f39916d4
 2015-10-13 18:25:09 +00:00
Ed Sanders 557340426f Media upload: Initiate upload process on image drop 
Bug: T40031
Change-Id: I521909d27c390faad7d62f717f2b97b7676e5a63
 2015-10-13 11:24:34 -07:00
jenkins-bot 3efea1d05e Merge "MWLinkAnnotationInspector: Close inspector when a search result is clicked" 2015-10-13 16:07:33 +00:00
jenkins-bot 7ac49bcfd9 Merge "ReferenceContextItem: Factor out getReferenceNode and use correct node" 2015-10-13 12:16:01 +00:00
Translation updater bot de900b63ee Localisation updates from https://translatewiki.net. 
Change-Id: I144099a28ac3120780306ef4e610584b4ab0da54
 2015-10-12 21:07:07 +02:00
jenkins-bot 1da509937d Merge "[BrowserTest] Use English if i18n file does not exists to convert the text" 2015-10-12 15:21:35 +00:00
Vikas S Yaligar 0d282a5e32 [BrowserTest] Use English if i18n file does not exists to convert the text 
Bug: T111525
Change-Id: Iaf557114df0bcdca3f82fc0ba0bcb752f5cb2c3d
 2015-10-12 15:13:48 +00:00
Translation updater bot 34ce74e044 Localisation updates from https://translatewiki.net. 
Change-Id: I7933389827e2e2b99aeddfc7a1222ee06a5e96dc
 2015-10-11 21:24:43 +02:00
jenkins-bot caaf0bd3cd Merge "MWLinkAnnotationInspector: Use IndexLayout for internal/external" 2015-10-11 12:42:02 +00:00
jenkins-bot 676fd50aa3 Merge "Media upload: Hide tabs after first stage of upload booklet" 2015-10-11 12:41:43 +00:00
jenkins-bot 1d8450bf94 Merge "Media upload: Only reset upload booklet on dialog setup" 2015-10-11 12:41:40 +00:00
jenkins-bot 821f478d98 Merge "MediaDialog: Rename bookletLayout to mediaSettingsBooklet" 2015-10-11 12:41:38 +00:00
Translation updater bot 19beb645f7 Localisation updates from https://translatewiki.net. 
Change-Id: I6a69972203990c251baac3dba14c88d1f11f65de
 2015-10-10 22:45:25 +02:00
Ed Sanders d5766c2d5f Media upload: Hide tabs after first stage of upload booklet 
Change-Id: Ie0cd0fe7761b3937de685ed18b96cc95b8ca4d4f
 2015-10-10 16:52:35 +01:00
Ed Sanders aa5f0c2faf Media upload: Only reset upload booklet on dialog setup 
Bug: T115059
Change-Id: I4ee9b408624ee3b0dfc3079f02ebbaf2e66f3fa3
 2015-10-10 16:52:25 +01:00
Ed Sanders afb556813a MediaDialog: Rename bookletLayout to mediaSettingsBooklet 
Change-Id: I04dbdfd14daedf614e8a47992231d48d72f7ff33
 2015-10-10 16:26:40 +01:00
Ed Sanders f1f75bf511 MWLinkAnnotationInspector: Close inspector when a search result is clicked 
Change-Id: Id473b45a222d53f6bca0168dad4adf536ccdf97a
 2015-10-10 15:49:45 +01:00
Ed Sanders fff96cdc8f MWLinkAnnotationInspector: Use IndexLayout for internal/external 
As originally intended, but avoided because of since-fixed CSS issues.

Change-Id: I60186c8f8a13eb9a7708716329dc959e1913665d
 2015-10-10 13:02:16 +01:00
Translation updater bot 25f08228cf Localisation updates from https://translatewiki.net. 
Change-Id: I3cc88f7e10e751f1ce2ac47109706b29ac9bfa13
 2015-10-09 22:34:54 +02:00
Bartosz Dziewoński 2e5a31d66a Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description' 
The bug in jqueryMsg that required this is now fixed. Depends on
I56d8f7ec03a70f5c2360d9c5099496ecb2f668ad and
Icc360724c75755a6ffc31792d8439cba142642ae in MediaWiki core.

Changes to messages were done with search-and-replace:
  <a $2>       --->  [[{{ns:template}}:$1|
  </a>         --->  ]]
  {{GENDER:$3  --->  {{GENDER:$2

Bug: T87131
Change-Id: I67475edb75fb5192a76fbe629d735d1f2dcd1d48
 2015-10-09 13:10:00 +02:00
Vikas S Yaligar df2c17bfd2 [BrowserTest] Load i18n messages from MediaWiki to browser tests 
* translate method can be called to translate a particular string to a
specific language.

Bug: T90577
Change-Id: I7852ee0b0009e70bd9decef0dd317055d91a06a6
 2015-10-09 09:49:37 +00:00
Translation updater bot fbd83f2d4b Localisation updates from https://translatewiki.net. 
Change-Id: I0c9e54c4255a64ac9c487c92e84b1ec0a80068ba
 2015-10-08 23:10:21 +02:00
Ed Sanders 8ac173894d MWParameterPage: Focus value input when focussing page 
Logically depends on I6a439cb13e in OOUI.

Bug: T114562
Change-Id: Ic9ad6ceca8e8f6cb7b1a0f56cd6ed858e39e1dfa
 2015-10-07 14:33:55 -07:00
Translation updater bot 02fcbd4959 Localisation updates from https://translatewiki.net. 
Change-Id: I41f962ec577ec186b0b598e0e791924aa36ce641
 2015-10-07 22:04:25 +02:00
jenkins-bot df8d63c66b Merge "Fix typo in MWMediaDialog" 2015-10-07 18:38:09 +00:00
Ed Sanders fcc9be4fa4 Fix typo in MWMediaDialog 
Change-Id: Id8133f9eee523a7cd237d4ca2814b29bce02fa0d
 2015-10-07 19:34:21 +01:00
Ed Sanders 9fb6977e52 Update VE core submodule to master (363adf2) 
New changes:
63c5f67 [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering
6dd1cb2 Add ve.dm.Surface#selectLastContentOffset

Local changes:
* Use new getHashForRendering in GeneratedContentNode users

  As we no longer have a model hash, remove the originalIndex check
  and just rely on the deep comparison of mwData (trading a deep copy
  for a hash computation should result in similar performance).

Bug: T114689
Change-Id: Ida0ee0234418408b735232c633d41908a424a9ff
 2015-10-07 15:00:32 +00:00
jenkins-bot b83511ac54 Merge "Add image upload tab to media dialog" 2015-10-07 01:54:20 +00:00
Ed Sanders 97ddc8af2b Add image upload tab to media dialog 
Uses the ForeignStructuredUpload BookletLayout.

Bug: T40030
Change-Id: I103044210e714d99350a28a48619beacefb43eaa
 2015-10-06 18:40:19 -07:00
jenkins-bot f764155edc Merge "Don't error when trying to re-use a reference as itself." 2015-10-06 21:58:06 +00:00
jenkins-bot 45468b992a Merge "ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser" 2015-10-06 21:09:58 +00:00
Translation updater bot 8285ddf2a5 Localisation updates from https://translatewiki.net. 
Change-Id: I11980fb1fc52f010da55800457e0ee1be0690229
 2015-10-06 22:04:06 +02:00
Bartosz Dziewoński c684e2c682 ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser 
The bug in jqueryMsg that required this is now fixed.

Bug: T87219
Change-Id: Ib7ef7e6a0451539099c12ae32d02b50c269c7529
 2015-10-06 19:04:10 +02:00
Alex Monk 9d6fbc894e Educational popups and highlights for links+citations 
Bug: T108620
Change-Id: I42b0e06f50aca5cb783d88f79a080461e745ceee
 2015-10-06 14:33:57 +01:00
jenkins-bot cd29e0376d Merge "Add error element to MWLiveExtensionInspector" 2015-10-05 22:53:20 +00:00
Translation updater bot e75fb6a2da Localisation updates from https://translatewiki.net. 
Change-Id: Icbf09f06f978d791208bc9ac37f56524700e7a97
 2015-10-05 22:17:32 +02:00
Ed Sanders 3f2a885e3e Ensure full error message is shown when inspector is closed 
Applying staging doesn't emit an update event on the node, so
forcefully emit one with 'staged' equal to false, so the full
error is rendered (if present).

Logically depends on I8ebb26d4bc in core.

Bug: T114480
Change-Id: I7ba54b67982fc5b10839426cdc216e14c0e33c01
 2015-10-05 17:15:40 +00:00
jenkins-bot aaaded172b Merge "Toolbar config: Prevent 'Table' from moving after menu expand" 2015-10-05 15:14:47 +00:00
jenkins-bot 4878313bea Merge "Consistently use spaces inside brackets in CSS" 2015-10-05 15:02:25 +00:00
Ed Sanders 2c9b9e4d73 ReferenceContextItem: Factor out getReferenceNode and use correct node 
Use the node from the parent dm document, not the internal list document.

Change-Id: Ieeb0a63bd40de7a8a2944322ba800feec7a7f4dd
 2015-10-05 16:01:54 +01:00
jenkins-bot 7c0f17c2cf Merge "ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons" 2015-10-05 11:55:04 +00:00
Thalia 9307fa7095 Add error element to MWLiveExtensionInspector 
As part of the plan to render extension errors in the
inspector instead of the view, append an element to
contain the error. More specifically, the element is
a div that contains a LabelWidget (in which the error
message is displayed) and a ButtonWidget (to expand
and collapse the error).

Initially the error element is hidden, but if Parsoid
returns an error, the element will be shown. If the
error is longer than 1 line, it is truncated but can
be expanded. On closing the inspector, any remaining
error is collapsed and hidden.

Depends on I6002d9870d2b to work

Bug: T113172
Change-Id: Ie84130d4ac0da9a738bf98ad0a3677d47566d585
 2015-10-05 00:22:22 +01:00
Translation updater bot 4eb7a0554b Localisation updates from https://translatewiki.net. 
Change-Id: I1574aa4164e8e530740112596120b44b1707d562
 2015-10-04 22:20:56 +02:00
jenkins-bot 291065459c Merge "Use ve.setProp to set new pages list in MWTemplateTitleInputWidget#getLookupRequest" 2015-10-04 19:54:45 +00:00
Bartosz Dziewoński 205beb2b49 ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons 
OO.ui.BookletLayout does not respect tabindices when trying to focus
the first focusable element after a page is switched. Remove the need
for manually set tabindices in ve.ui.MWTemplateDialog by using natural
DOM order and absolutely positioning things to keep current design.

Bug: T114562
Change-Id: I7a18a455f9fa80eb3d2ea17bff8139e0194c0fbf
 2015-10-04 20:39:16 +02:00
Ed Sanders 1eb0ef2011 Consistently use spaces inside brackets in CSS 
Change-Id: Ie63a50cb16cb89dac7060857220485d7d23f2fe3
 2015-10-04 18:33:43 +01:00
Ed Sanders 7337eb1d7e Toolbar config: Prevent 'Table' from moving after menu expand 
Change-Id: I9f472668e0cf8f3014c681f6f2430e685bf50534
 2015-10-04 13:28:55 +01:00
Translation updater bot 5124a7075b Localisation updates from https://translatewiki.net. 
Change-Id: I751798608f4e54a643b4cb488d9217bfcb704266
 2015-10-03 22:14:37 +02:00
Translation updater bot 815a729780 Localisation updates from https://translatewiki.net. 
Change-Id: I0d72901cb61d21af1ff710c1be8d3cc9150ca75c
 2015-10-02 23:51:15 +02:00
Ed Sanders d63dce138d MWExtensionNode: Fix selector to find dimension-less images 
Change-Id: Idf219636f9b2b58e30b1a155c052ada4c60e6ec9
 2015-10-02 14:18:13 +01:00
Alex Monk a46b7a819e Hack to stop logging edit events for non-desktop targets 
Mobile target, for example, has events logged in the MobileFrontend extension instead
(which covers both the wikitext editor there and the VE integration)

Bug: T110272
Bug: T109525
Change-Id: I521f1825dc9c0a135db54cd005cda723908f14bc
 2015-10-01 23:48:10 +00:00
jenkins-bot e14c8e11cf Merge "Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle" 2015-10-01 16:14:29 +00:00
jenkins-bot 1bbfcf23c6 Merge "MWExtenionNode: Ensure objects are deep copied when used in the hash" 2015-10-01 15:28:01 +00:00
Thalia 34f6e11a19 Call updatePreview when closing the LiveExtensionInspector 
Call updatePreview in insertOrUpdate node, when closing the
inspector. If edits have only been made to attributes that
don't affect the rendering, updatePreview will not have been
called, so the model won't have changed. Therefore
updatePreview should be called every time the inspector is
closed to make sure such edits are applied.

Bug: T113078
Change-Id: I48fb291487f76fc515f122646d205366a60dca62
 2015-10-01 15:58:20 +01:00
Ed Sanders c5c88482b9 MWExtenionNode: Ensure objects are deep copied when used in the hash 
We don't expect users not to alter the hash (subclasses may delete items)
so make a copy of any objects we put in it.

Change-Id: I6274f47e02b9f2d53864d4a2ae80df42e6c89867
 2015-10-01 15:57:49 +01:00
Ed Sanders 50de745afd MWExtensionNode: Copy mw data before modifying 
Otherwise we are directly modifying model.element.attributes
which is very bad.

Change-Id: Icf066a5848b9c67c2c4b3fcafd72d0142996e48d
 2015-10-01 13:34:01 +01:00
jenkins-bot 1b455ac201 Merge "Call afterRender whether or not images emit 'load'" 2015-09-30 21:00:13 +00:00
Thalia 53f4aa64d9 Call afterRender whether or not images emit 'load' 
MWExtensionNodes currently don't call afterRender if the image
is already loaded, which can happen if we decide not to rerender
after an update (e.g. when the response is an error).

Change-Id: Ic9c11e446a7cc789bb20680466709ff2ad5cb22e
 2015-09-30 21:47:40 +01:00
Translation updater bot d6f09eb3b0 Localisation updates from https://translatewiki.net. 
Change-Id: I661c0b37dce0b8e30c960dad2bfa0600e9920d83
 2015-09-30 22:12:21 +02:00
Translation updater bot c1f26c0922 Localisation updates from https://translatewiki.net. 
Change-Id: I53bf43111c86cabfb668f0bd3d05b57611e78bb1
 2015-09-29 22:10:19 +02:00
Ed Sanders 074f7bcefe Follow-up If556afa10: Fix typo: nodeType -> nodeName 
Change-Id: I19915647981787f7bbf2c86fc7bd02308d5da218
 2015-09-29 17:35:23 +01:00
Roan Kattouw 0d4b30f927 MWInlineExtensionNode: Don't assume responses are always <p>-wrapper 
For the Score extension they aren't, and this causes JS errors in production.

Change-Id: If556afa1046f460d7fdd29cb1c50ac93dad88fde
 2015-09-28 19:36:48 -07:00
jenkins-bot ce8107ec0b Merge "Autodisable preference" 2015-09-28 23:46:59 +00:00
Alex Monk 97e70ba3cc Autodisable preference 
We want to flip the default of visualeditor-enable to true, but don't
necessarily want to turn it on for users who already have contributions but who
haven't already enabled it. Therefore we're considering adding such users to
this autodisable preference which they can self-remove (by explicitly enabling
VE) or we can target later, separate from betatempdisable users.

Bug: T112352
Change-Id: I1ce5e6c92055e30fdc82bc912a767e913b190ef6
 2015-09-29 00:30:27 +01:00
jenkins-bot 3aee082548 Merge "MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget" 2015-09-28 21:10:54 +00:00
Translation updater bot d17197696f Localisation updates from https://translatewiki.net. 
Change-Id: I89a27eeb175bfcf2f4cb3dd4beba38a664def4d8
 2015-09-28 22:51:02 +02:00
jenkins-bot f9247ce087 Merge "MWLinkAnnotationInspector: Update actions when changing tabs" 2015-09-27 22:07:23 +00:00