wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 06:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ReferenceContextItem: Factor out getReferenceNode and use correct node"

Browse source
This commit is contained in:
jenkins-bot 2015-10-13 12:16:01 +00:00 committed by Gerrit Code Review
parent de900b63ee 2c9b9e4d73
commit 7ac49bcfd9
1 changed files with 20 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
modules/ve-mw/ui/contextitems/ve.ui.MWReferenceContextItem.js
View file

@ -48,12 +48,9 @@ ve.ui.MWReferenceContextItem.static.commandName = 'reference';
* @return {jQuery} DOM rendering of reference
*/
ve.ui.MWReferenceContextItem.prototype.getRendering = function () {
var refModel;
if ( this.model.isEditable() ) {
refModel = ve.dm.MWReferenceModel.static.newFromReferenceNode( this.model );
this.view = new ve.ui.PreviewElement(
refModel.getDocument().getInternalList().getItemNode( refModel.getListIndex() )
);
var refNode = this.getReferenceNode();
if ( refNode ) {
this.view = new ve.ui.PreviewElement( refNode );
// The $element property may be rendered into asynchronously, update the context's size when the
// rendering is complete if that's the case
@ -67,6 +64,23 @@ ve.ui.MWReferenceContextItem.prototype.getRendering = function () {
}
};
/**
* Get the reference node in the containing document (not the internal list document)
*
* @return {ve.dm.Node} Reference node
*/
ve.ui.MWReferenceContextItem.prototype.getReferenceNode = function () {
var refModel;
if ( !this.model.isEditable() ) {
return null;
}
if ( !this.referenceNode ) {
refModel = ve.dm.MWReferenceModel.static.newFromReferenceNode( this.model );
this.referenceNode = this.getFragment().getDocument().getInternalList().getItemNode( refModel.getListIndex() );
}
return this.referenceNode;
};
/**
* @inheritdoc
*/