wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 08:10:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

MWInlineExtensionNode: Don't assume responses are always <p>-wrapper

Browse source 
For the Score extension they aren't, and this causes JS errors in production.

Change-Id: If556afa1046f460d7fdd29cb1c50ac93dad88fde
This commit is contained in:
Roan Kattouw 2015-09-28 19:36:48 -07:00
parent ce8107ec0b
commit 0d4b30f927
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
View file

@ -150,10 +150,10 @@ OO.inheritClass( ve.ce.MWInlineExtensionNode, ve.ce.MWExtensionNode );
*/
ve.ce.MWInlineExtensionNode.prototype.onParseSuccess = function ( deferred, response ) {
var data = response.visualeditor,
contentNodes = $( data.content ).get();
contentNodes = $.parseHTML( data.content );
// Inline nodes will come back in wrapper paragraphs, so unwrap them.
if ( contentNodes[ 0 ] && contentNodes[ 0 ].childNodes ) {
// Inline nodes may come back in a wrapper paragraph; in that case, unwrap it
if ( contentNodes.length === 1 && contentNodes[ 0 ].nodeType === 'P' ) {
contentNodes = Array.prototype.slice.apply( contentNodes[ 0 ].childNodes );
}
deferred.resolve( contentNodes );