wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-19 12:16:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
15122 commits 162 branches 1 tag 190 MiB
Commit graph

11535 commits

Author SHA1 Message Date
jenkins-bot fbdd7c895f Merge "Do not "resolve attributes" in toDomElements() overrides" 2017-09-18 22:27:28 +00:00
jenkins-bot 0246c2a62f Merge "Enable preload in VisualEditor" 2017-09-18 19:59:13 +00:00
David Lynch c440a3576f DesktopArticleTarget: Support preloadtitle in source mode 
Can't support it in visual mode, since there's no new-section handling at all.

Bug: T51622
Change-Id: I763d5fff156e9ef3893bd882fab1dc2d47121728
 2017-09-18 10:18:37 -05:00
Translation updater bot 228af9d25d Localisation updates from https://translatewiki.net. 
Change-Id: I10e3b3c86449102851aec61f7166adfd9432164b
 2017-09-17 22:48:16 +02:00
Translation updater bot 76771b4cd0 Localisation updates from https://translatewiki.net. 
Change-Id: I1cbc38a425ec200a585dfacb825893c20da5b1e2
 2017-09-16 23:06:04 +02:00
David Lynch ea274c94cd Enable preload in VisualEditor 
This allows the use of the preload and preloadparams query parameters. They
should behave as they do in the old editor, loading substituted content in
visual and source modes.

Bug: T51622
Change-Id: I522fb5b480d17912f6d6116be6aa043ead855b52
 2017-09-15 17:17:51 -05:00
C. Scott Ananian 853ec0bc9c Inspectors for editing LanguageConverter markup 
Basic inspectors for editing.  Changing from block to inline, or
adding "hidden" or "describe" flags not supported.

The UI layout for two-way and one-way rules could certainly be improved.

Bug: T49411
Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f5185
 2017-09-15 09:24:33 -07:00
jenkins-bot 0034fb3c65 Merge "CollabTarget: Disable submit button when input is invalid" 2017-09-15 00:22:12 +00:00
Ed Sanders 35be4f4757 CollabTarget: Disable submit button when input is invalid 
Change-Id: Id8b3c098fc2fbec778b0d4cf98fa7cc35202d95b
 2017-09-15 00:16:27 +00:00
Translation updater bot 253d0b2e09 Localisation updates from https://translatewiki.net. 
Change-Id: Idc7a04710edbde1341c8fd87ab50d74a4ea87dd2
 2017-09-14 23:36:51 +02:00
C. Scott Ananian 26df4dca33 Doc update: use the full class name so JSDuck hyperlinks it correctly 
Change-Id: I2c6f6a6c5b497767d7f7731c86cc145ed60b1deb
 2017-09-14 11:07:07 -04:00
Ed Sanders 405afdce70 Strip RESTBase IDs from historical diffs 
Change-Id: I911d529204a97003ed233464709737b018918634
 2017-09-14 13:45:10 +01:00
Translation updater bot 9dfe4bbdc7 Localisation updates from https://translatewiki.net. 
Change-Id: I2195f7cb1d274f73a32a35237f6e0b9b23e29749
 2017-09-13 22:56:59 +02:00
jenkins-bot 1809344c8a Merge "URL decode file names in gallery, as in PHP parser" 2017-09-13 18:00:56 +00:00
jenkins-bot 714f43c8c2 Merge "Fix typos in gallery attribute names" 2017-09-13 17:34:52 +00:00
jenkins-bot 779dcc2164 Merge "ArticleTarget: Make save commands triggerable from anywhere" 2017-09-13 15:40:19 +00:00
jenkins-bot d6fb66e70c Merge "Use lowerCamelCase for javascript var oldId" 2017-09-13 13:45:20 +00:00
jenkins-bot cd6dfaa42b Merge "Remove pageName/revision from ArticleTarget constructor" 2017-09-13 13:45:19 +00:00
jenkins-bot 15ba6dbc53 Merge "Change ArticleTargetLoader#requestPageData API to use options object" 2017-09-13 13:42:10 +00:00
Ed Sanders a6ac6d0cec Fix typos in gallery attribute names 
The MW attributes are 'style' and 'class'. The plural
forms are used internally only to avoid JS keywords.

Change-Id: I1b7d14872aab4b6b3882d00165924fd1639e1744
 2017-09-13 14:06:44 +01:00
Ed Sanders 280696ad3f URL decode file names in gallery, as in PHP parser 
Bug: T175816
Change-Id: I3ec9c1f6db57798cdc1b5a787dd0bd9b4d3beef1
 2017-09-13 14:03:20 +01:00
Ed Sanders f9562838bf ArticleTarget: Make save commands triggerable from anywhere 
Change-Id: Iea5b2ff1210b0b28a58017f198f55124c9a3348d
 2017-09-13 12:00:19 +00:00
Ed Sanders d515d418c1 Use lowerCamelCase for javascript var oldId 
Change-Id: Idd04578a0035320f85dc911a2f4ddbc6f378887f
 2017-09-13 12:57:37 +01:00
Ed Sanders ebce67b6ab Remove pageName/revision from ArticleTarget constructor 
Other page state is read directly, rather than passed in.
If we come up with a use case for passing this in at a later
date we can reconsider the best way to do this.

Change-Id: Iee7e608c969776b89dbb38b3b56a5177e48344af
 2017-09-13 12:57:37 +01:00
Ed Sanders 682787f312 Change ArticleTargetLoader#requestPageData API to use options object 
Change-Id: I02e6218a8359b1cbc8fed1a34d68206a2a154d46
 2017-09-13 12:57:37 +01:00
Translation updater bot c2b8de09a5 Localisation updates from https://translatewiki.net. 
Change-Id: Ib39c3b33100062858098f2f803e1fad751f837d2
 2017-09-12 22:56:25 +02:00
jenkins-bot 508fdf1543 Merge "Don't require a selection to run any of the save actions" 2017-09-11 15:10:23 +00:00
jenkins-bot 822db7eacf Merge "Add feedback link for visual diff inside save dialog" 2017-09-11 12:01:39 +00:00
Translation updater bot caa7341d49 Localisation updates from https://translatewiki.net. 
Change-Id: If867adb27d970653090e741b90ed503f49a13842
 2017-09-10 22:50:20 +02:00
Ed Sanders 13ef05b489 Don't require a selection to run any of the save actions 
Change-Id: I3a8f7e1e9e3714f226ac240a429a62d011112285
 2017-09-10 14:53:14 +01:00
Translation updater bot bf27796935 Localisation updates from https://translatewiki.net. 
Change-Id: I09865a7a366e768cdb5ac6dcbcbb7ab15ac67420
 2017-09-09 22:53:44 +02:00
Translation updater bot dc2366cbba Localisation updates from https://translatewiki.net. 
Change-Id: I768e3e14ff1b0becdba08daa7694b22625792fab
 2017-09-09 00:22:20 +02:00
jenkins-bot 2bc46f93d3 Merge "CollabTarget: Minimise dependencies, and make toolbar tweaks" 2017-09-08 15:52:55 +00:00
Ed Sanders e4585d520b CollabTarget: Minimise dependencies, and make toolbar tweaks 
Change-Id: I37cccd5760b8e65fc4232ca4572147f3b031255d
 2017-09-08 15:46:45 +00:00
Translation updater bot b80952158a Localisation updates from https://translatewiki.net. 
Change-Id: I10f4721b977be987129d271ba1534887bcaabd4d
 2017-09-07 23:42:28 +02:00
David Lynch 569f917edc MWExtensionWindow: clean up originalMwData on teardown 
Not doing this makes adding a new extension node with the exact same content
as a previously-viewed one have the Done button disabled.

Bug: T172586
Change-Id: I39105144e17135044ef644b5464b0fbfdfc019d5
 2017-09-07 10:40:36 -05:00
Bartosz Dziewoński 98351fbcf3 Do not "resolve attributes" in toDomElements() overrides 
Resolving attributes means turning 'href' and 'src' URLs from possibly
relative to absolute, so that they don't depend on the base URI of the
document.

This is necessary when rendering for clipboard (and in some other
cases), but at the point when toDomElements() is called, the document
these elements are in does not necessary have a sane base URI set,
giving us hrefs pointing to nonexistent pages.

Don't do it here; it will happen later when we know what the right
document (and right base URI) is, e.g. in ve.ce.Surface#onCopy or
ve.ui.PreviewElement#replaceWithModelDom.

Bug: T169675
Bug: T175157
Change-Id: Ie0a5d6e1c57b8efdbbfba0c24f31ca91d156e200
 2017-09-07 14:06:24 +02:00
Translation updater bot 67ef60629d Localisation updates from https://translatewiki.net. 
Change-Id: I6176a308b3b526f068da420473e52d342aa0da14
 2017-09-06 23:02:05 +02:00
Bartosz Dziewoński 92cea19890 Use .length instead of .size() for jQuery objects 
.size() is deprecated.

Change-Id: Ib28b7fede117de474efea705adf5dc2cdf8cb101
 2017-09-06 14:52:40 +02:00
Prateek Saxena 1d6b87243e Use findFirstSelectableitem instead of getFirstSelectableItem 
Depends-on: Ic12be404eba490e5ce748f0d754a807e12f6ba76
Bug: T76630
Change-Id: I7daccf8620ec43a56183fd455048a1f2c5f71f26
 2017-09-06 15:42:42 +10:00
jenkins-bot a13620f49a Merge "MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage" 2017-09-06 00:38:33 +00:00
Translation updater bot 8980881dd4 Localisation updates from https://translatewiki.net. 
Change-Id: I745a308a42416baed8debda4b5e2e7491ef5537d
 2017-09-05 23:04:02 +02:00
jenkins-bot 9ef0f71983 Merge "Stop requiring deprecated EditPage::getCheckboxes()" 2017-09-05 18:00:52 +00:00
Arlo Breault 3e96d8ed5a Use figure-inline instead of span for inline media 
Bug: T118520
Depends-On: I0681c39301e52a3368b53d38ed518ac66e18f0d6
Change-Id: Id8ec5b77207f43fc7c379b35859dc09f264e2c04
 2017-09-05 12:17:14 -04:00
Thalia a3902ebff8 Add feedback link for visual diff inside save dialog 
Bug: T170665
Change-Id: I0b09b1089c834a013ad5fee4ecdf75b483b56323
 2017-09-05 13:35:37 +01:00
Prateek Saxena 2b923c0346 MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage 
Bug: T76630
Depends-on: I068dad8c79c4bda6ea37ab6a1eb6ba72ab6f7dc0
Change-Id: Ib4e380aa6cd0cacbadd42bdf447ddee6443f22ef
 2017-09-05 12:13:41 +10:00
Translation updater bot 828ce717f3 Localisation updates from https://translatewiki.net. 
Change-Id: I09c9579992c49851382f4c0d54af59e1552a6532
 2017-09-04 22:52:04 +02:00
Translation updater bot ef753a82ce Localisation updates from https://translatewiki.net. 
Change-Id: Ib1ff25374fcf0df6c0e8ffc3d402adbd3b36dfa1
 2017-09-03 22:41:47 +02:00
jenkins-bot d743fa7c1f Merge "Disable VE on Special:Undelete" 2017-08-31 23:40:41 +00:00
Bartosz Dziewoński df9e564b73 Stop requiring deprecated EditPage::getCheckboxes() 
Instead, use getCheckboxesDefinition(), and build our save form
checkboxes from that rather than extracting them from the HTML.

The ability to have non-checkbox fields there is removed, as that was
never intentional and is now impossible.

To avoid transient problems during deployment (old JS code cached in
the user's browser receiving the new format of API responses), the old
property is kept in the API response. We should remove it next week.

Bug: T174613
Bug: T174686
Change-Id: I5bfca5e116fe790302c3b6ac1357e80237fb1ed2
 2017-08-31 17:47:15 +02:00
jenkins-bot af756c4c20 Merge "EducationPopup: Add cursor:pointer" 2017-08-30 17:59:26 +00:00
Ed Sanders 24747966b6 EducationPopup: Add cursor:pointer 
We still expect the user to click on the tool, and
the actions still works (albeit delayed), so we
should use cursor:pointer.

Change-Id: I6d2b0140f5fd918809f05acc6e405ef430c518fd
 2017-08-30 17:48:27 +00:00
jenkins-bot a24be49c01 Merge "ve.ui.MWEducationPopupTool: Position blue dots with CSS only" 2017-08-30 17:42:38 +00:00
jenkins-bot 1a40fd2b71 Merge "ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table" 2017-08-30 15:48:07 +00:00
jenkins-bot 61ae9df214 Merge "MWParameterPage: Vertically align actions with label" 2017-08-30 15:42:53 +00:00
Egbe Eugene 2fc6423070 Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label 
Since "nbsp" is hard to translate, it is removed from the current
text of visualeditor-mwlanguagevariantcontextitem-rule-code-label,
which was "Language code" - now changed to "Language code".
Instead the table headings (where this message is used) are defined
as non-breaking in CSS.

Bug: T173181
Change-Id: I9794fa010ad908fe772fa6858c25acc6beb973d5
 2017-08-29 21:58:33 +02:00
Bartosz Dziewoński bff16fb352 ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table 
For magical HTML reasons, a `<tbody>` node is automatically inserted
inside the `<table>` node. Therefore the table always had exactly one
direct child, this check always failed and table was never shown.
Instead, count the rows.

Change-Id: Ia8a5387c3f605689ab1053c923952ec955b83253
 2017-08-29 21:57:48 +02:00
jenkins-bot 50c31a0b29 Merge "mw.ArticleTarget: strip HTML tags entirely from source-mode summary" 2017-08-29 19:50:04 +00:00
David Lynch dc101c6169 mw.ArticleTarget: strip HTML tags entirely from source-mode summary 
Bug: T173711
Change-Id: If8b354b2788285ea27472bf9a16544f8e5c091f8
 2017-08-29 12:01:33 -05:00
David Lynch 5d4ff082e6 MWLinkAnnotationInspector: check input validity when switching modes 
Focusing a TextInputWidget normally unsets validity. However, because we're
kind of pretending this is the same input, just in a different mode, it
doesn't make sense to the user that the focus behavior occurs. So, make it
recheck validity after we switch.

Bug: T172159
Change-Id: I1d9d6670d72483c7510fd5ed3c539b43af8432bf
 2017-08-29 11:28:29 -05:00
Bartosz Dziewoński 0a378318bf ve.ui.MWEducationPopupTool: Position blue dots with CSS only 
We can place them in bottom center of the toolbar buttons with
just CSS, no need to manually calculate the position (which
doesn't give the correct results if the toolbar is not visible).

Also add z-index for correct rendering inside TargetWidget,
not overlapped by the toolbar border (e.g. in the media dialog).

Bug: T174120
Change-Id: I556ddfcf252669107cf21810fbed7c9a3751e906
 2017-08-29 18:21:44 +02:00
Ed Sanders c8e856bfb2 MWParameterPage: Vertically align actions with label 
Also make label consistent height, with or without an
indicator using line-height, and move closer to input.

Change-Id: I1b6e6e2f3caa4c949583cafa9448aae6ebc1e0a1
 2017-08-29 14:45:21 +01:00
Ed Sanders 550408f863 Increase width of param actions container 
Bug: T174202
Change-Id: I61a175593b087219b22c5be91d00054b1c15e1dc
 2017-08-29 14:28:26 +01:00
Translation updater bot 498d1dde0c Localisation updates from https://translatewiki.net. 
Change-Id: I85367b5829adcc6402905429b09b00302d1c8585
 2017-08-29 09:27:05 +02:00
Translation updater bot 632a39446f Localisation updates from https://translatewiki.net. 
Change-Id: I86a476a67016ccfec0ece9a6d40576bcc9cc9683
 2017-08-28 13:47:03 +02:00
Ed Sanders 63607c4cff Remove reference to editfont-default 
Bug: T170223
Depends-On: I1ace59c980740fc785ccbd500e19cc8b71d46a5b
Change-Id: I2ac04df04b6652b47490dff5202683c041178a2c
 2017-08-25 18:44:53 +01:00
Ed Sanders 3ba918a6ae Disable VE on Special:Undelete 
Bug: T173154
Change-Id: I2a7d815a67c9e0f80ab3cdfd3a3755370c831867
 2017-08-25 18:09:37 +01:00
Translation updater bot 4677c6837b Localisation updates from https://translatewiki.net. 
Change-Id: I5ea49bc6475bf5c10b900b9ade15455ee939b4a8
 2017-08-25 10:06:55 +02:00
jenkins-bot b73deb1690 Merge "Create wrapper paragraph when converting block image to inline" 2017-08-24 22:16:16 +00:00
jenkins-bot 842b3336bd Merge "Move historical diff loading to DiffLoader util" 2017-08-24 18:33:45 +00:00
jenkins-bot f315c650f6 Merge "Don't focus media dialog until ready process" 2017-08-24 17:18:54 +00:00
Brad Jorsch 2abb9b1b2d Remove execute mode from non-executable 
Change-Id: I46549acd49ca883e9047b8117cb968a9ddbb06cc
 2017-08-24 10:57:25 -04:00
Ed Sanders eb2ee52de0 Create wrapper paragraph when converting block image to inline 
This prevents the image jumping into another paragraph,
e.g. in a different table cell.

Move the logic for removing the old image out of MWMediaDialog
and into MWImageModel#insertImageNode.

Bug: T121449
Change-Id: Ibd7c92f3f90c382ceffd3e0defb12ba36a3786d2
 2017-08-24 15:56:22 +01:00
Ed Sanders b11b144ad6 Don't focus media dialog until ready process 
Bug: T174027
Change-Id: I070b5538e12c8a165a714ac6c3fd172f0ed179d4
 2017-08-24 15:38:11 +01:00
Ed Sanders 51207e7aa5 Allow for mw.body being null in <selfclosing/> extensions 
Bug: T173016
Change-Id: I8daa65e5dc0368b366710f044b621287e83e26f7
 2017-08-23 16:13:16 +00:00
Translation updater bot 21759ac8c9 Localisation updates from https://translatewiki.net. 
Change-Id: I39a7dcd4701e7481dadc37a285159ab283d995e2
 2017-08-23 09:43:48 +02:00
jenkins-bot 8e29c59e44 Merge "Decrease border contrast on selected Vector tabs" 2017-08-22 20:47:22 +00:00
Volker E a2f70cac8b Decrease border contrast on selected Vector tabs 
Decreasing border contrast on selected Vector tabs.

Bug: T173465
Change-Id: I46530c8cdf9161e527f421eeb8186a7695057361
 2017-08-22 13:28:24 -07:00
Translation updater bot 03e17c61bc Localisation updates from https://translatewiki.net. 
Change-Id: Ibd8a3f757e90d99142994dc73b15f178cf98d90b
 2017-08-22 09:24:57 +02:00
Translation updater bot 066cc2ed3e Localisation updates from https://translatewiki.net. 
Change-Id: I0e8878a5878027ffcf58bd02629fe8c54123634a
 2017-08-19 09:26:56 +02:00
jenkins-bot 12ee2041d7 Merge "Align border and border-radius values" 2017-08-17 14:52:10 +00:00
jenkins-bot 9c2bccea48 Merge "Replace remaining greys/reds with WikimediaUI color palette colors" 2017-08-17 14:52:05 +00:00
Translation updater bot 98618638a1 Localisation updates from https://translatewiki.net. 
Change-Id: Ia7afe35d0f465b16d73f065c2373ded6f2dff063
 2017-08-17 09:20:06 +02:00
Volker E 19eb726677 Align border and border-radius values 
Aligning `border` code syntax codebase-wide and
`border-radius` values to WikimediaUI theme.

Change-Id: I1a16dccf17bd112ba5071ebfe02d57237feb39e0
 2017-08-16 14:05:55 -07:00
Volker E aaffa6aa46 Replace remaining greys/reds with WikimediaUI color palette colors 
Replacing remaining greys and reds apart Monobook/Apex specific
stylesheets with WikimediaUI palette colors.

Bug: T173459
Change-Id: I9b5b1c379bf76e8da57eeff28c7dd000f148a8fc
 2017-08-16 13:43:02 -07:00
Translation updater bot 84c6f28b97 Localisation updates from https://translatewiki.net. 
Change-Id: I594ea5f8e9f15fb6739e2ede21e3e365caa77b0a
 2017-08-15 09:02:55 +02:00
Translation updater bot 24e7cd1b26 Localisation updates from https://translatewiki.net. 
Change-Id: Ib536e242d7d941e57e18056b52a304cfdfd73ed6
 2017-08-14 09:43:14 +02:00
Ed Sanders 3cf074c6ea Move historical diff loading to DiffLoader util 
Change-Id: I318752ede2e5c90f9d0ecd26b39e997fff2d60bd
 2017-08-13 15:31:42 -04:00
David Chan c87abccdf9 MWLinkAction: Don't annotate close tags 
Change-Id: I273838eba4cb259cf053ce88378da10b0e241155
 2017-08-13 11:33:43 -04:00
jenkins-bot 2398ae1f3f Merge "Inform users visual diffs are in beta" 2017-08-12 21:04:54 +00:00
Thalia fd75d2687f Inform users visual diffs are in beta 
Bug: T170665
Change-Id: Ia144c4409767567e41693a3fecd245a6b49c27c7
 2017-08-11 15:12:08 -04:00
jenkins-bot 8975449eaf Merge "Context item for LanguageConverter markup" 2017-08-11 14:29:09 +00:00
jenkins-bot 6f12d066d1 Merge "Rename LanguageConverter markup fields" 2017-08-11 14:28:11 +00:00
Translation updater bot 40337be73a Localisation updates from https://translatewiki.net. 
Change-Id: I42edcaf67657f3d0c8425ae1152a47ed3dbc6df9
 2017-08-10 23:17:54 +02:00
jenkins-bot a604c3064a Merge "VisualDiff: Store diffmode in query string on diff pages" 2017-08-10 19:22:40 +00:00
Ed Sanders 1d70266b8b VisualDiff: Store diffmode in query string on diff pages 
Change-Id: I092ac68dd31b29b4418e7afb37bfe94befa16558
 2017-08-10 11:24:54 -04:00
C. Scott Ananian c89a3059f8 Context item for LanguageConverter markup 
Add a context item giving more information on language converter markup.

Bug: T49411
Change-Id: I3c91db84793a9a965dcb760253b24edee5d7bd23
 2017-08-10 11:02:41 -04:00
C. Scott Ananian 4ff740fe21 Rename LanguageConverter markup fields 
Avoid confusion by using `twoway` instead of `bidir`, which could be
confused with the Unicode bidirectional layout algorithm.

Depends-On: Ib59dff22e64f235e30778a5a5b3e525e4fc7fdd3
Change-Id: I7efb35245d48125b167dc0f0ef8f12aa0fff94e5
 2017-08-10 10:59:57 -04:00
Translation updater bot 937f5c0238 Localisation updates from https://translatewiki.net. 
Change-Id: I1b87d53f71cdaa9d9200bb77985e16e26313d174
 2017-08-09 22:46:38 +02:00
jenkins-bot 430fa82774 Merge "Expose ve.ui.MWInternalLinkContextItem generateBody logic" 2017-08-09 18:07:33 +00:00
David Chan c03d69b761 Expose ve.ui.MWInternalLinkContextItem generateBody logic 
Change-Id: I94912ac2c471cc5d227fa8b9cb29c302ca29814d
 2017-08-09 17:58:49 +00:00
jenkins-bot afd3bb5a1d Merge "Remove code for magnify icon from figcaption node" 2017-08-09 16:35:54 +00:00
Translation updater bot 961b2241e9 Localisation updates from https://translatewiki.net. 
Change-Id: I930f11036e7bc1ac1ee700e65b5ddd2bda222b61
 2017-08-08 23:08:11 +02:00
Translation updater bot a2af4cb554 Localisation updates from https://translatewiki.net. 
Change-Id: Iea21c4fac1e837b0f87e7188a46a3aeca0fd87e6
 2017-08-07 23:10:09 +02:00
Translation updater bot 57dfd917f2 Localisation updates from https://translatewiki.net. 
Change-Id: I352afaf45420ca6a3ad59c23573eac8f13202f6e
 2017-08-06 22:51:32 +02:00
jenkins-bot 1e474e038e Merge "Support visual diffs on Special:ComparePages" 2017-08-06 11:46:57 +00:00
Ed Sanders 5104f63cf3 Support visual diffs on Special:ComparePages 
Bug: T171821
Change-Id: I13fe8349ab2d078b172637c931f1b80f7108c927
 2017-08-05 23:38:20 +01:00
Translation updater bot 060c3d5558 Localisation updates from https://translatewiki.net. 
Change-Id: I7d2f623163590912147702af63a24709fccd4442
 2017-08-05 22:54:48 +02:00
Translation updater bot 1e12b53858 Localisation updates from https://translatewiki.net. 
Change-Id: Ifc5d45f9e8b43bf5a17a0e1206cae95645e325eb
 2017-08-04 23:31:05 +02:00
jenkins-bot dc99384c06 Merge "Fill empty apihelp messages" 2017-08-03 21:53:41 +00:00
Umherirrender 33ddad9382 Fill empty apihelp messages 
Change-Id: I5c300e763b58071719710e73fcc0c1666a8e35ec
 2017-08-03 23:42:09 +02:00
Translation updater bot 5e85df4c31 Localisation updates from https://translatewiki.net. 
Change-Id: Id51f14b71889d68489b7e0c34d1b3add3316fc06
 2017-08-03 23:11:46 +02:00
Roan Kattouw 448944de3b Standardize on /^(\.\.?\/)*/ for interpreting Parsoid hrefs 
We used (\.+\/)* instead of (\.\.?\/)* in some places,
but that doesn't make much sense since we won't and shouldn't
ever see stuff like '.../'

Change-Id: I9efcff2d2a34499ca57321dfbae29392ecb422d7
 2017-08-02 21:30:31 +00:00
Translation updater bot 96fd341f1d Localisation updates from https://translatewiki.net. 
Change-Id: I73618d0dc368f56585b7f950ecf20c693d29b8d6
 2017-08-01 23:05:50 +02:00
jenkins-bot 7b17760ad6 Merge "ve.init.mw.ArticleTarget: Fix parsing of preview documents" 2017-08-01 17:40:51 +00:00
Bartosz Dziewoński e31ffa9199 ve.init.mw.ArticleTarget: Fix parsing of preview documents 
ve.init.mw.Target.static.parseDocument requires that its parameter be
a complete HTML document with a single root tag, otherwise some of its
workarounds break horribly in IE 11 (and possibly Firefox).

Bug: T171600
Change-Id: Iaacf24f7bef40a24230fcfa08e15bab31b1587c0
 2017-08-01 17:16:43 +00:00
jenkins-bot c959caffe4 Merge "Copy over missing steps from MWLinkAnnotationInspector to Wikitext version" 2017-08-01 16:25:08 +00:00
Translation updater bot 9a0fda6bba Localisation updates from https://translatewiki.net. 
Change-Id: I3e8539bec5dbd521a0fc1b10d72f78e3d1637d56
 2017-07-31 23:05:34 +02:00
jenkins-bot c44e8e7b19 Merge "Compare template names when diffing, not just type" 2017-07-31 19:28:57 +00:00
Ed Sanders a90f8f5ea1 Copy over missing steps from MWLinkAnnotationInspector to Wikitext version 
Bug: T171892
Bug: T171895
Change-Id: Id14eed79b9a2395b3b722828e62b05d3d8d44327
 2017-07-31 18:44:12 +01:00
jenkins-bot 1bfe56ddb0 Merge "ArticleTarget: set local config to hide welcome dialog" 2017-07-31 16:07:35 +00:00
Translation updater bot 34cd347904 Localisation updates from https://translatewiki.net. 
Change-Id: Ie572f56ba6293663fc4c19e5b70d80035e97e57f
 2017-07-28 22:47:03 +02:00
Ed Sanders 539a1cab43 Compare template names when diffing, not just type 
As type is always 'mwTransclusionInline/Block'.

Bug: T166801
Change-Id: I76cdf0add780d556206c439797cfcca19133d94d
Depends-On: I0f24d9d81b5491a8f09bc59e5f544f99751fd506
 2017-07-28 21:32:32 +01:00
Translation updater bot c0a5b64695 Localisation updates from https://translatewiki.net. 
Change-Id: Id9389d3f271a86db33767e8c9813eaa14b019a17
 2017-07-27 23:23:21 +02:00
Translation updater bot ae47ac45c0 Localisation updates from https://translatewiki.net. 
Change-Id: I47ea114caf376072407ba6c92e60c216aaeb61fd
 2017-07-26 22:58:09 +02:00
Translation updater bot cc0bd4b4cc Localisation updates from https://translatewiki.net. 
Change-Id: I349f1de9b00d36c1e2f1072f7c2cd84629cd3e6e
 2017-07-25 22:47:19 +02:00
C. Scott Ananian 9ee713d480 Display LanguageConverter markup in VisualEditor 
Implement special node types for language variant markup, so that they
display appropriately based on the currently-selected variant.

(Parsoid uses empty elements to represent this markup, so without this
patch anything in -{ ... }- is alienated and disappears.)

A follow-up patch will implement context items and inspectors to
allow editing these nodes.  This patch is basic "read-only" support.

Depends on I4fcdebc2290ec35ba188f4c2e69d578791fbcd67 in Parsoid to
generate the appropriate markup, but this patch is safe to merge
independently.

Bug: T49411
Change-Id: Ie11e9301d2513bfe4a36036481cee9a047f46d37
 2017-07-25 15:26:41 +00:00
Ed Sanders aeca5a8253 Remove code for magnify icon from figcaption node 
This icon is now added by Parsoid content CSS.

Bug: T160960
Depends-On: Id66f09c54103854ccbaa54a03e7c62890b67cba9
Change-Id: I8d76d759641b091c1821ff658b1201ca625fd146
 2017-07-25 14:48:39 +01:00
Translation updater bot ea40fc5f60 Localisation updates from https://translatewiki.net. 
Change-Id: I57efbb78a536b94d16f7bfeabf4ee7002b21aa0f
 2017-07-24 23:21:05 +02:00
David Lynch 0e973e2539 ce.MWTransclusionNode: make sure model exists before getting its document 
Bug: T168932
Change-Id: I8d458888ed0b80205ce17b41f3506410c550630f
 2017-07-24 11:31:19 -05:00
jenkins-bot 6dec360659 Merge "Edit image captions in place" 2017-07-24 16:02:06 +00:00
jenkins-bot 23b9f4284e Merge "Fix toolbar position on Special:CollabPad" 2017-07-24 08:49:23 +00:00
Ed Sanders 058e30d29d Fix toolbar position on Special:CollabPad 
Adds missing ve-init-mw-desktopArticleTarget-toolbar-open class.

Change-Id: I8579928c8daa224bb9bec8fa5f4360fb3c52c5a1
 2017-07-24 09:38:29 +01:00
Translation updater bot 99d18028d9 Localisation updates from https://translatewiki.net. 
Change-Id: I2580854b1270433a4ccda9262d16d7741c9b03e1
 2017-07-22 23:01:52 +02:00
Translation updater bot d15eb23806 Localisation updates from https://translatewiki.net. 
Change-Id: I5fe6d7383256cf027d4550d81ed5bee28df8b1ce
 2017-07-20 23:07:09 +02:00
jenkins-bot 03173b7b2d Merge "ve.ui.MWEducationPopupTool: Don't show if not inside a BarToolGroup" 2017-07-20 17:07:20 +00:00
Timo Tijhof d8a532c87e tests: Remove QUnit.newMwEnvironment from ve.test.utils.mwEnvironment 
Two problems:
* At least one caller already calls QUnit.newMwEnvironment(), which means
  it runs twice which is unsupported and breaks If4141df10eae55 in core.
* It assumes the return will contain 'setup' and 'teardown', which
  is internal and also changes with If4141df10eae55 in core.

Using 'setup' and 'teardown' for this within VE-MW is fine.

First attempt is to simply remove it. Uses that already called
QUnit.newMwEnvironment are effectively unchanged. Uses that didn't
and only pass ve.test.utils.mwEnvironment to QUnit.module directly
will now run without core's QUnit.newMwEnvironment() setup/teardown.

If that breaks anything, we can add it back to those tests that actually
need it.

Change-Id: I9ef0368ba58daf1c7dc92d083ae79c108cc27638
 2017-07-20 00:15:51 +00:00
Translation updater bot d804a1fc10 Localisation updates from https://translatewiki.net. 
Change-Id: Ifbb0c0e37626c04e5085abdda1e8d4a2f60c3c4d
 2017-07-19 23:00:11 +02:00
Bartosz Dziewoński 49d5bae106 ve.ui.MWEducationPopupTool: Don't show if not inside a BarToolGroup 
The popup gets hideously deformed in other cases. Getting it to work
would probably be difficult. Let's just not show it.

Bug: T170919
Change-Id: If9005e9cdea52fefab981f4c7f05f71fce99f3e8
 2017-07-19 22:13:34 +02:00
David Lynch 5f6e186ed4 ArticleTarget: set local config to hide welcome dialog 
This stops the welcome dialog from being displayed repeatedly if the user
edits the article multiple times in the same pageload.

Bug: T170983
Change-Id: I8cc5990e9acb1ac09a2d6dd95eef8042c70088c7
 2017-07-19 14:29:49 -05:00
David Lynch 420037b3ff LinkCache: parsoid element styling, detect selflink fragments 
Selflinks with fragments aren't actually selflinks, and so shouldn't be styled
as such.

Bug: T170943
Change-Id: Icb67c81327769d09af6bcfe593843d9dd2bcc33c
 2017-07-19 11:54:00 -05:00
Ed Sanders 3180445ce9 Edit image captions in place 
Bug: T149753
Depends-On: I6967c9c2b99449e1a4ac003db8213586eda7fbbd
Change-Id: I9baaa8634e9f364e78b3e881113ed8fa917bc76f
 2017-07-19 13:01:02 +01:00
Translation updater bot 623664ec48 Localisation updates from https://translatewiki.net. 
Change-Id: I3e607ca45c0b4f650df79ae26d8c01b26a7e9e88
 2017-07-18 23:10:28 +02:00
jenkins-bot 8baf524006 Merge "Visual diffs: Use new wgDiffOldId/wgDiffNewId" 2017-07-18 15:40:28 +00:00
Bartosz Dziewoński 6123b452da Visual diffs: Use new wgDiffOldId/wgDiffNewId 
This also removes an undeclared dependency on mediawiki.Uri.

Bug: T169574
Depends-On: Ic4abaae6e9c74509f7a114a697cdbb78dd1b89b6
Change-Id: I76803da5f1a52171a1af8de1f3e31ea127a2da78
 2017-07-18 15:16:03 +00:00
Ed Sanders 835a775a49 build: Upgrade grunt-eslint from 19.0.0 to 20.0.0 
Mostly indent and regex fixes.

Change-Id: Iaf9d02363c78cb71deec5c4cab53a05b67f60600
 2017-07-18 12:55:33 +01:00
jenkins-bot 1a2de9c8ad Merge "DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages" 2017-07-17 22:48:21 +00:00
David Lynch c7486ae19b DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages 
Bug: T138715
Change-Id: I1d1efe7fb3286bbf85ea2a17356dcad1d3346517
 2017-07-17 17:17:07 -05:00
L10n-bot 3cd82770e8 Merge "Localisation updates from https://translatewiki.net." 2017-07-17 21:11:56 +00:00
Translation updater bot e91837d952 Localisation updates from https://translatewiki.net. 
Change-Id: I63740a790669e5562776d363c06a31270592f79b
 2017-07-17 23:11:47 +02:00
Ed Sanders 1efd8c5a61 Add mw-parser-output class to CE document 
Bug: T164790
Change-Id: I14ee60dc3e68aad02a740af06f5749e6b5e3329c
 2017-07-17 18:04:52 +01:00
jenkins-bot 1333373c3e Merge "Drop local 'template' icon, use 'puzzle' from upstream" 2017-07-17 15:09:28 +00:00
jenkins-bot 0549c55ca3 Merge "Fix wikitext preview in IE and Edge" 2017-07-17 14:29:43 +00:00
Translation updater bot c820c04ee1 Localisation updates from https://translatewiki.net. 
Change-Id: Ie47d9a6c3f50275338c980822a90edba6853dd8e
 2017-07-14 22:57:02 +02:00
Bartosz Dziewoński 0e00b2c109 Fix wikitext preview in IE and Edge 
In Internet Explorer and Edge, NodeList objects do not have the
'forEach' method. However, Array's 'forEach' can be applied to them,
as we do elsewhere in the code.

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach

Bug: T170466
Change-Id: Icb19995e140607d45c47fb6ae8d60ac80b664d02
 2017-07-14 15:30:27 +02:00
Translation updater bot 815f9e4acc Localisation updates from https://translatewiki.net. 
Change-Id: If9dc517ccbb54150ca209d62bae06df165182429
 2017-07-13 23:01:37 +02:00
jenkins-bot 1b6cc864b3 Merge "DesktopArticleTarget.init: only show welcome dialog if page editable" 2017-07-13 18:11:46 +00:00
David Lynch 0e8ef6c307 ce.MWTransclusionNode: make sure model exists before getting its document 
Bug: T168932
Change-Id: Idf18839b1f1fae6eb29621f1950d2b52c99e3433
 2017-07-13 11:33:38 -05:00
David Lynch a2f8597712 DesktopArticleTarget.init: only show welcome dialog if page editable 
"Welcome to wikipedia, anyone can edit, we welcome all improvements. Start
editing!" is a bit out of place when what you'll see after clicking "start
editing" is "you can't edit this page".

Bug: T138715
Change-Id: I9f655a5f12d4e45644bd01631c2d3131375d8e8f
 2017-07-12 10:29:54 -05:00
Translation updater bot 48a215b9b3 Localisation updates from https://translatewiki.net. 
Change-Id: Ida79312d18b2b56b8d75345fde654c59437dca7b
 2017-07-11 23:09:03 +02:00
Ed Sanders 0917d27e61 Fix wikitext table insertion 
Since Ic8b11d8052 #insertContent puts multiline strings on separate
lines, so to get this to behave correctly, pass in linear data instead.

Bug: T170160
Change-Id: Ie121fce1af46c6834945f4de30bcd9924ee96fd1
 2017-07-10 16:16:11 +01:00
Translation updater bot ec3677e001 Localisation updates from https://translatewiki.net. 
Change-Id: If34229d9423fb41b99ae7e6d578d247a924d669e
 2017-07-08 22:49:24 +02:00
Translation updater bot b67d8d5da9 Localisation updates from https://translatewiki.net. 
Change-Id: Iab72a6b6f3236203dce7ea6bf8ec3c1b7bd96acb
 2017-07-06 23:04:57 +02:00
James D. Forrester 528942c2e1 Drop local 'template' icon, use 'puzzle' from upstream 
Now that our template icon has been upstreamed thereto.

Bug: T111041
Change-Id: If101018de284dcc1be086d92427de0d88adb0e02
 2017-07-06 09:52:56 -07:00
jenkins-bot eb94174561 Merge "ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack"" 2017-07-06 14:53:34 +00:00
Translation updater bot db2921281e Localisation updates from https://translatewiki.net. 
Change-Id: I964c0d70f0ad7e953de2ba7d4a77613d81c55785
 2017-07-05 22:47:29 +02:00
Bartosz Dziewoński 4c3c8b3d1e ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack" 
The promise #getTeardownProcess is trying to resolve/reject no longer
exists, causing exceptions. The code has been unnecessary for a while,
as we do all the work in #getActionProcess. (In the case that we do
switch, the teardown code isn't even called, since we navigate away.)

Cancelling the switch to wikitext works correctly after removing this
code.

Bug: T169588
Change-Id: I1b9b12edf12a0b91f06c13aa53024efb80868387
 2017-07-04 21:49:15 +02:00
jenkins-bot 16f5bc609e Merge "TextInputWidgets: update for deprecated multiline behavior" 2017-07-03 21:21:20 +00:00
David Lynch cfe1d6c0c9 TextInputWidgets: update for deprecated multiline behavior 
Remove config option `multiline` and change to MultilineTextInputWidget as
appropriate.

Bug: T169272
Change-Id: I45565f01de76a88d64d7b0691d1e7279354f375d
 2017-07-03 22:09:58 +01:00
Translation updater bot af7c3a71c9 Localisation updates from https://translatewiki.net. 
Change-Id: I4f1851f6c388dec8ab6be4510607c8f1e8784a33
 2017-07-03 22:52:23 +02:00
Ed Sanders dd54c9c95d Return truthy object when image info not found 
A missing image should return some data to say the
image is missing, not just reject the promise.

Bug: T169337
Change-Id: Ib41a64a783c1baca88f428417c98e7fb913d14a1
 2017-07-03 18:01:33 +00:00
Ed Sanders 915e818356 Clear all gallery state on teardown 
Change-Id: I90662d02bd2d9768bdcf27e532ed8b8792f764c3
 2017-07-03 17:48:06 +00:00
jenkins-bot 73a0574452 Merge "Normalize to template namespace when comparing" 2017-07-03 16:50:44 +00:00
Ed Sanders b3d44c1ccd Normalize to template namespace when comparing 
Bug: T169307
Change-Id: Ic3524819fb026713b27b193e4a03338fffd97229
 2017-07-03 16:41:08 +00:00
jenkins-bot baf1908b99 Merge "DesktopArticleTarget: Regenerate title in all non-view page scenarios" 2017-07-03 16:25:51 +00:00
Translation updater bot 9986166cfb Localisation updates from https://translatewiki.net. 
Change-Id: Ia03ad93b311249dc73b38b69ea085ecfbf75985d
 2017-07-02 22:54:36 +02:00
Ed Sanders af25311201 DesktopArticleTarget: Regenerate title in all non-view page scenarios 
Bug: T168236
Change-Id: I15f2aeb42b98855512970e2f07396fd7a7c97354
 2017-07-01 17:27:07 +00:00
Translation updater bot 90841ca36c Localisation updates from https://translatewiki.net. 
Change-Id: I87974d7d4cbd1f83e913953849d7583d5aa60fc0
 2017-06-30 23:43:26 +02:00
jenkins-bot 59d74932b0 Merge "Update VE core submodule to master (b528a5321)" 2017-06-29 07:39:01 +00:00
Translation updater bot 1055bebefc Localisation updates from https://translatewiki.net. 
Change-Id: I6b7d0c0b29a571c695078b8a00086470751df315
 2017-06-28 23:18:21 +02:00
David Lynch 7e678dc81a Update VE core submodule to master (b528a5321) 
New changes:
44d2d666c Remove custom icon sizing from block slugs
793d131f9 Ignore covering annotations when looking for plain text pastes
b0025f3ab dm.Document fixupInsertion: check suggestedParents as well
73ce638f1 ve.ui.TableLineContext: Fancier popups
9d54d531e Visual Diff: add internal list diff
4f4e121b5 DiffElement: Add hacky support for template-defined references

Local changes:

dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings

Core VE doesn't have any elements with suggestedParents, so make sure this is
properly tested.

Bug: T153315
Bug: T162819
Bug: T164017
Bug: T165865
Change-Id: I01489226d282abe71020e65358ead24fe07692f7
 2017-06-28 20:57:19 +01:00
jenkins-bot 05bc265198 Merge "Keep TOC in correct place in document" 2017-06-28 12:31:33 +00:00
jenkins-bot be808346c9 Merge "Fix TOC meta item detection" 2017-06-28 12:31:32 +00:00
Jforrester 15c6011875 Merge "Ensure MWInlineImages get the ve-ce-leafNode class" 2017-06-27 17:15:44 +00:00
Translation updater bot 42ca5c6d1e Localisation updates from https://translatewiki.net. 
Change-Id: Ibb3f2f38abf77af4872012fb32f73f89d94d0c7b
 2017-06-26 23:08:30 +02:00
jenkins-bot 7f14f854c4 Merge "ve.init.mw.DesktopArticleTarget: Remove some hacks" 2017-06-26 20:27:09 +00:00
Ed Sanders c4f93b1411 Ensure MWInlineImages get the ve-ce-leafNode class 
Without this class, offset calculations fail and model/view
sync can be lost.

Bug: T167009
Change-Id: Ie7b6551ac5a532949c14122b9ee7584a794af0f2
 2017-06-26 12:43:23 +00:00
jenkins-bot 0dee2be8d8 Merge "GalleryDialog: Re-order and make margins even" 2017-06-26 10:33:17 +00:00
jenkins-bot b2ae6ddcb8 Merge "GalleryDialog: Downstream fix for DraggableElement padding" 2017-06-26 10:32:07 +00:00
Translation updater bot 6623018b9d Localisation updates from https://translatewiki.net. 
Change-Id: I97af6bed779e8435746a70ae0eba850ce4be1d2f
 2017-06-25 23:21:18 +02:00
jenkins-bot ba3a5d85bd Merge "Show visual diffs on DiffPage" 2017-06-25 03:30:29 +00:00
jenkins-bot a7fdaffb1b Merge "Clear all diff state when switching editors" 2017-06-24 11:10:32 +00:00
Translation updater bot 2a2b22c829 Localisation updates from https://translatewiki.net. 
Change-Id: I157176fbd3f29a718b7b95974216db819c881cb9
 2017-06-23 22:54:56 +02:00
Ed Sanders 15af26876a GalleryDialog: Re-order and make margins even 
Move image inside filename fieldset, and make
margins between fieldsets and button 1em.

Change-Id: I7f6789043f873f9da4e960c94e22a7ee096a352f
 2017-06-23 12:16:35 -07:00
Ed Sanders 9eb637e933 GalleryDialog: Downstream fix for DraggableElement padding 
Bug: T168745
Change-Id: I95e6f5cd2126878c4f973285fceece1d5a03c4eb
 2017-06-23 11:58:37 -07:00
jenkins-bot 93a44ef399 Merge "MWTransclusionDialog: fix conditions for "show options" button disabling" 2017-06-23 17:21:50 +00:00
Ed Sanders fd1adfb3b5 Keep TOC in correct place in document 
Change-Id: I6ad8cd8cbd7ef902204408673eb096b7405abd24
 2017-06-22 15:16:15 -07:00
Ed Sanders 1a0fd81f64 Fix TOC meta item detection 
Change-Id: Icce35100bbc0bfb5584a676eec0e1774308d0f68
 2017-06-22 15:16:14 -07:00
Translation updater bot 48c6e558ea Localisation updates from https://translatewiki.net. 
Change-Id: I03013c77fdaffbca561a7e3a3462a5469703b25b
 2017-06-22 23:10:14 +02:00
Ed Sanders 11e6e25ac6 Clear all diff state when switching editors 
Bug: T168618
Change-Id: I19ff5054b87568546bfe1202d67c5d863e1549be
 2017-06-22 10:54:04 -07:00
David Lynch 9ded195f7e MWTransclusionDialog: fix conditions for "show options" button disabling 
As I understand it, the button should be enabled whenever there's more than
one option in the sidebar, and disabled otherwise. The previously chosen
conditions weren't perfectly proxying this, and the button would be disabled
whenever editing an already-existing transclusion.

Bug: T167710
Change-Id: Id303b680c072642ae7b66066e28ecc9f1dc90fd7
 2017-06-22 17:58:52 +01:00
jenkins-bot e285c8e4cb Merge "Show simple category list in preview" 2017-06-21 20:07:45 +00:00
jenkins-bot 090d26f9c5 Merge "Use Parsoid data for template names rather than detect from wikitext" 2017-06-21 01:15:38 +00:00
jenkins-bot 7cd5a5d61f Merge "Add newline to end of wikitext documents" 2017-06-21 01:10:57 +00:00
Ed Sanders 09519a24d2 Add newline to end of wikitext documents 
Bug: T156609
Change-Id: I80d82ad87464b1c6e0344b29123bb96fcc4cffad
 2017-06-20 17:51:51 -07:00
jenkins-bot 115f8e7ae5 Merge "Move preview document filtering into MWSaveDialog" 2017-06-21 00:41:26 +00:00
jenkins-bot fc4e836d4b Merge "Fix getWikitextFragment shortcut to return a promise" 2017-06-21 00:40:46 +00:00
Ed Sanders 6f72ef82d9 Show simple category list in preview 
Bug: T153534
Change-Id: Ie86abdad76a38855d5ad1a394c0bfb3c8dd5a8c6
 2017-06-20 23:50:52 +00:00
Ed Sanders 9dd638a5ab Move preview document filtering into MWSaveDialog 
Also:
* Make mw-content-DIR nest inside mw-body-content
* Use ve.filterMetaElements

Change-Id: Ic70c7dff0f74b81f92b8bd48e8092549947990ba
Depends-On: I478fe1f39164b9fd7e71987b818b8f668d1a7020
 2017-06-20 23:50:44 +00:00
jenkins-bot 87e1ede04a Merge "Return nothing from styleParsoidElements" 2017-06-20 23:11:46 +00:00
Translation updater bot 8beac44dab Localisation updates from https://translatewiki.net. 
Change-Id: Ie734ca2986ad6f5a1da5f349b20756ef283246c3
 2017-06-20 23:08:44 +02:00
Ed Sanders e1b4321b5a Return nothing from styleParsoidElements 
The method modifies DOM elements in place, and the return
value is never used.

Change-Id: I6254389dbf8daa67795206cb508038b60e1a4761
 2017-06-20 21:03:22 +00:00
jenkins-bot c4c4375b7d Merge "Remove old authorListWidget CSS" 2017-06-20 20:13:58 +00:00
Translation updater bot f7586d5f9d Localisation updates from https://translatewiki.net. 
Change-Id: I59770f4737b52838d1c5cbdb2e9111986b76fc75
 2017-06-19 23:12:02 +02:00
Translation updater bot c5dad8f018 Localisation updates from https://translatewiki.net. 
Change-Id: I961fe87e1974dc12df7fd0df33745c95c926a871
 2017-06-18 22:55:09 +02:00
Ed Sanders 585cf5f990 Fix getWikitextFragment shortcut to return a promise 
Change-Id: Ide5c920332ba9dd0777a7c63e27ebbbc9a391172
 2017-06-17 19:42:24 -07:00
Ed Sanders f400a6debe Remove old authorListWidget CSS 
Change-Id: Ibeaae78f1424fc098dbc103438e7cb2c4d15c9d8
 2017-06-17 19:42:22 -07:00
Translation updater bot b9a6dc8394 Localisation updates from https://translatewiki.net. 
Change-Id: I53062bbd73eb478e27284f35320f5bc2bd4809bf
 2017-06-17 22:50:13 +02:00
Translation updater bot d67005cdb8 Localisation updates from https://translatewiki.net. 
Change-Id: Ic29540f87264d7541afa0a3be696cb47ed7e4f50
 2017-06-16 23:02:01 +02:00
jenkins-bot 4b852d899b Merge "Use static parseDocument method" 2017-06-16 18:38:25 +00:00
jenkins-bot 14dd536d32 Merge "ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning" 2017-06-16 18:32:51 +00:00
Ed Sanders 0e6d8d5fff Show visual diffs on DiffPage 
Only shown if VisualEditorEnableDiffPage is set, or query
string param 'visualdiff' is present.

Currently:
* All VE javascript is loaded (could be cut down to just DM code)
* The entire Parsoid HTML of both revisions being compared is loaded
* Both Parsoid HTML docs are parsed into VE DM trees and diffed

Bug: T167508
Change-Id: I151fc9bab3d3032f50c8d11be6b54e45a06fcc34
 2017-06-16 19:29:19 +01:00
Bartosz Dziewoński 624211a60f Use Parsoid data for template names rather than detect from wikitext 
We were incorrectly handling transclusions with trailing
newlines after the template name.

This also improves handling of non-template transclusions,
e.g. parser functions like `{{int:mainpage}}`, which are
no longer mangled as if they were page names.

ve.dm.MWTransclusionNode#isSingleTemplate will now match
a template even if it's name is itself template-generated.

Logic for turning Parsoid's hrefs into page names stolen
from ve.dm.MWImageNode.prototype.getFilename.

Bug: T167613
Change-Id: Ibecf71338eb37bb3da81a7372e4ed41140a9af57
 2017-06-14 23:15:18 +00:00
Bartosz Dziewoński 433e7b5069 ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning 
OOjs UI Popups position themselves automatically relative to their
$floatableContainer these days.

Also added explicit `$floatableContainer: this.$element` in the config
(although not strictly needed, since the parent node is used by
default, this makes the code more robust in case we move the popup
somewhere else in the DOM).

Bug: T167751
Change-Id: Id4267fce6499a4c217f7dc1d18871c02dd078aee
 2017-06-14 23:19:09 +02:00
Bartosz Dziewoński 9dcf6dcddc ve.init.mw.DesktopArticleTarget: Remove some hacks 
No longer needed after I2ede6c88be569224c0b2a4e388a133ad98b86a7b
in VisualEditor core.

* 'transform: none' from 049a32c60a
  (that change does not describe what the issue was, but clearly
  it wasn't a complete fix and I see no problems without it).
* 'z-index: 4' from 6fff13b898 (I can't
  reproduce the issue there after removing it).

Bug: T167616
Change-Id: I7e0d603af2668269e5587eaa5e4761166a1b4097
 2017-06-14 22:25:25 +02:00
Bartosz Dziewoński 39b82f7b00 Revert 032fb292, a97eacd0 
Reverting a new weird hack for an issue and bringing back the
old, tried and true hack that was removed in the mistaken belief
that if a bug is marked as fixed, it is really fixed.

* Revert "MWTransclusionDialog: size footer correctly"
  This reverts commit 032fb2924e.
* Revert "Remove dialog height hack tagged against resolved bug"
  This reverts commit a97eacd05b.

Bug: T93290
Bug: T167483
Change-Id: If1cc07837892bb0248c74025d5403f9698e77705
 2017-06-14 20:38:38 +02:00
jenkins-bot 5fbe84a4e6 Merge "MWTransclusionDialog: size footer correctly" 2017-06-14 11:39:41 +00:00
Translation updater bot 98568e734f Localisation updates from https://translatewiki.net. 
Change-Id: I751ac55b2a10f014c1db8df1d6915d71711ee5c9
 2017-06-13 22:51:12 +02:00
Brad Jorsch 7ec68ed168 API: Split description messages into summary + additional text 
See MediaWiki core patch I778bab2b

Change-Id: I642895c0e77dabfde3a7cdc744c5de4df9489aa5
 2017-06-13 13:27:52 -04:00
David Lynch 032fb2924e MWTransclusionDialog: size footer correctly 
Changing label means a refresh is needed.

Bug: T167483
Change-Id: Ie4b35696bdf21d2a74e786875615d8753a57972d
 2017-06-13 11:48:38 -05:00
Translation updater bot 2dc77148cb Localisation updates from https://translatewiki.net. 
Change-Id: I182b53a98bb4d7c5e471b23a4665c1c3a84c8b46
 2017-06-12 22:52:07 +02:00
jenkins-bot 7e892bbc97 Merge "MWParameterPage: Fix missed remove -> trash icon name rename" 2017-06-12 18:55:05 +00:00
jenkins-bot b170e81d83 Merge "Fix i18n TODOs in CollabPad" 2017-06-12 18:51:31 +00:00
jenkins-bot 27c6f624ae Merge "[DEPRECATING CHANGE] Make Target#createModelFromDom static" 2017-06-12 18:50:38 +00:00
jenkins-bot 076a7feef2 Merge "Add filename to gallery dialog page" 2017-06-12 18:46:48 +00:00
James D. Forrester a7d48228dc MWParameterPage: Fix missed remove -> trash icon name rename 
Bug: T167598
Change-Id: I1701bd426ea66a40937bcc69183c697a8e39710d
 2017-06-12 11:39:50 -07:00
Translation updater bot 678949a23d Localisation updates from https://translatewiki.net. 
Change-Id: Ia2bd46f3bbe52d17c6ea187dbd8a516de564adf8
 2017-06-11 22:48:17 +02:00
Translation updater bot a84164a38b Localisation updates from https://translatewiki.net. 
Change-Id: Ia38f09ce88980b0954a81b72ff32954e286fed23
 2017-06-11 00:39:40 +02:00
Ed Sanders 23c0b6997e Fix i18n TODOs in CollabPad 
Change-Id: Ifa802773881e2f2763578223bc76ca2798a08b17
 2017-06-10 12:48:09 +01:00
Translation updater bot 44d0e3336b Localisation updates from https://translatewiki.net. 
Change-Id: I3d19d4fed087b2f3b2fea902f2a223e765eceddd
 2017-06-09 23:04:23 +02:00
Ed Sanders 75d583a0d9 Use static parseDocument method 
Change-Id: I545a58ffcbf1c7c57c197f4858958de835a40394
Depends-On: I5b36e187a5e8bb68b47b2fccf5b46c08b81b01d9
 2017-06-08 14:43:09 +01:00
Ed Sanders f178061117 [DEPRECATING CHANGE] Make Target#createModelFromDom static 
Change-Id: I019689f87ac0f7f40a8a7600029b5ce1bc92e77f
 2017-06-08 14:35:31 +01:00
jenkins-bot e97393434a Merge "Give extensions a fallback icon when invisible" 2017-06-07 23:34:20 +00:00
Ed Sanders 8fb56b8d75 Give extensions a fallback icon when invisible 
Bug: T166526
Change-Id: I5eafbef3b751a83cef353c8a9f09d90820fa9409
 2017-06-07 22:29:19 +01:00
Translation updater bot 94be609bb4 Localisation updates from https://translatewiki.net. 
Change-Id: I881fdd18a2a6eda2af0f9b48d0e93ba05b845ee0
 2017-06-07 22:56:46 +02:00
L10n-bot 46bcf496fe Merge "Localisation updates from https://translatewiki.net." 2017-06-06 21:03:23 +00:00
Translation updater bot 6c802d059f Localisation updates from https://translatewiki.net. 
Change-Id: I927c7fe0f0c1dae63d337245a6e40723a69fd379
 2017-06-06 22:50:16 +02:00
jenkins-bot 7774f2bee1 Merge "dm.MWTransclusionNode: Move mixin comment, remove duplicated static property" 2017-06-06 15:44:25 +00:00
Ed Sanders 9ccdf15695 dm.MWTransclusionNode: Move mixin comment, remove duplicated static property 
Change-Id: Id8f8205db92a70dde7ba22b39e90e37590efb3d1
 2017-06-06 16:28:01 +01:00
jenkins-bot 010197f1b8 Merge "Don't try to i18n-parse JSON string" 2017-06-06 15:08:16 +00:00
Ed Sanders 4a163020a8 Add filename to gallery dialog page 
Also add fieldset headings consistent with media dialog.

Bug: T167049
Change-Id: I8112b70d8e3ba19079fdab0806ad343b233c9c18
 2017-06-06 15:48:24 +01:00
Ed Sanders 4484f5c316 Don't try to i18n-parse JSON string 
Bug: T167051
Change-Id: Idf07ba51d2681f0f5d275f2a732d77cd85e63d03
 2017-06-06 11:12:41 +01:00
Translation updater bot 3830d2d864 Localisation updates from https://translatewiki.net. 
Change-Id: Ib2dc866df76ca62367f5fbc76d0dd75831bf3968
 2017-06-05 23:20:13 +02:00
Translation updater bot 507fdb73fc Localisation updates from https://translatewiki.net. 
Change-Id: Ief77af837492f4171aebd118d3d07277adcdf8cf
 2017-06-04 23:37:19 +02:00
Translation updater bot b7ef971cbf Localisation updates from https://translatewiki.net. 
Change-Id: I670fd45d44a881de24917d40d4d4eea047cee185
 2017-06-03 22:54:52 +02:00
Translation updater bot 748d301680 Localisation updates from https://translatewiki.net. 
Change-Id: I9fe85ad034bd1784867bf9bbeb5b93d0d568e95d
 2017-06-02 22:51:08 +02:00
jenkins-bot c5bdd39a63 Merge "Update for deprecation of OOjs UI openWindow/closeWindow promise" 2017-06-02 00:32:39 +00:00
Bartosz Dziewoński 4f55d8066e Update for deprecation of OOjs UI openWindow/closeWindow promise 
Bug: T166729
Change-Id: I95b85a8c0d488993c11da74e1d856fef6cf0ebb4
 2017-06-02 00:21:58 +02:00
Translation updater bot 87b90944c8 Localisation updates from https://translatewiki.net. 
Change-Id: I2c7721a9dc5b4abe2151ebe6604bd1b4d7715999
 2017-06-01 23:21:13 +02:00
jenkins-bot f01577ffa8 Merge "ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff" 2017-06-01 18:08:21 +00:00
jenkins-bot a506627f57 Merge "Correct numbers in visualeditor-dialog-meta-settings-toc-help" 2017-06-01 17:49:21 +00:00
David Lynch 7f8f188187 Correct numbers in visualeditor-dialog-meta-settings-toc-help 
Bug: T166029
Change-Id: Ic15834218bed8a78ad2d9de6c0838988ca65cd4b
 2017-06-01 10:46:02 -05:00
jenkins-bot 1a80348e8b Merge "Guard against mwdata.body being null" 2017-06-01 14:52:57 +00:00
Bartosz Dziewoński 834539748c ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff 
This fixes the focussing problems from T166150.

As a separate consequence, when loading a template/transclusion
takes a while (it can take several seconds for e.g. a template with
100 parameters), we will now display nothing while the user waits.
Previously we displayed an empty frozen dialog (note that this only
worked the first time for some reason).

Bug: T166150
Change-Id: I414a72ee248517867eef63a75f2d327aa5d5b908
 2017-06-01 16:31:05 +02:00
Ed Sanders a5e44034fb Guard against mwdata.body being null 
Bug: T166754
Change-Id: I3b887a3a6ee81ca3fd0b242fadc8b833b9031b50
 2017-06-01 14:01:23 +01:00
jenkins-bot c9d9361c5b Merge "Update VE core submodule to master (8be817396)" 2017-06-01 01:16:43 +00:00
Ed Sanders c7221988a1 Update VE core submodule to master (8be817396) 
New changes:
26085a853 Make author list a ListPopupTool
c4ea53eef Update OOjs to v2.1.0
8c94697f3 Update OOjs UI to v0.22.0
cdebc4817 Follow-up 8c94697f: Actually commit the icon changes I had locally
8be817396 Update OOjs UI to v0.22.1

Local changes for author list popup

Change-Id: I36bcaf122528a4a12882aaff3b33ef936082a391
 2017-05-31 17:48:45 -07:00
James D. Forrester 756079d477 Replace uses of the removed 'remove' icon with the 'trash' one 
Bug: T166730
Change-Id: I528dcdb390a4488ffac89fc823ff35bc1eda4f24
 2017-05-31 16:30:17 -07:00
Translation updater bot 8cb43a5f73 Localisation updates from https://translatewiki.net. 
Change-Id: I154f2dd73776ab7c227c5776bdfd97a1228f5dd4
 2017-05-30 22:50:10 +02:00
Translation updater bot f372a9fbc7 Localisation updates from https://translatewiki.net. 
Change-Id: I6c06a3c102a1ac6c009c7c2fc074b6e7a7c55eb7
 2017-05-29 23:33:34 +02:00
Translation updater bot b29b2816b2 Localisation updates from https://translatewiki.net. 
Change-Id: Ia20bdbf2ab8962c4cd73c7296db5f5e1db55d80f
 2017-05-28 22:42:27 +02:00
Translation updater bot ff1279244a Localisation updates from https://translatewiki.net. 
Change-Id: Ic8decb78f5ba98c21d8b526ea91ae88db7bd3605
 2017-05-26 22:53:58 +02:00
Translation updater bot efc4eccc47 Localisation updates from https://translatewiki.net. 
Change-Id: I49161dac6c2583b4820a1d052b0cca8053e68583
 2017-05-25 22:58:36 +02:00
Timo Tijhof a9ce695f75 mw.DesktopArticleTarget: Use require() for mw.page.watch 
Add 'require' to eslint global whitelist for this extension,
since ResourceLoader provides this in all contexts now.

Bug: T166254
Depends-On: I0e6a95bd4fbaba06eae5137ac7af84f62bebf6f0
Change-Id: I6b2fe57317dcff18ec6d9ea0cd9e4eb9c894c169
 2017-05-24 21:17:02 +00:00
Translation updater bot abaa359422 Localisation updates from https://translatewiki.net. 
Change-Id: I2bfd2fa70e5aa870e2001a78d058e6e90a2bb73c
 2017-05-24 23:04:42 +02:00
jenkins-bot 762344b2f1 Merge "Remove dialog height hack tagged against resolved bug" 2017-05-24 06:54:46 +00:00
Translation updater bot 2a84837eb9 Localisation updates from https://translatewiki.net. 
Change-Id: Ifa384f07695740972053594107aa4c3f49d6a054
 2017-05-23 23:09:13 +02:00
Ed Sanders a97eacd05b Remove dialog height hack tagged against resolved bug 
Bug: T93290
Change-Id: Idbb20a0adf854ba68e10043608764891f3d8514d
 2017-05-23 17:48:02 +01:00
Ed Sanders 004ca16a8f Remove mobile browsers from the blacklist 
They are already blacklisted by MW:
https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix_.28mobile.29

Change-Id: I8d6bfc415604a74b6da82d8c4b8f7d9ec7b9d89d
 2017-05-22 14:58:54 +02:00
Translation updater bot 0c26e1804f Localisation updates from https://translatewiki.net. 
Change-Id: I39d9799f42e23262a53e129b1ceea4f76bbef627
 2017-05-21 23:00:27 +02:00
James D. Forrester 8e88db4232 Follow-up 7e72163ea: Fix CBN alien unit test I missed and force-merged 
Whoops.

Change-Id: I21e30efd930458f6c1509e2f3d947f94d5ec5ad2
 2017-05-21 16:32:08 +02:00
Ed Sanders 578deca159 rebaser: Initialize toolbar 
Change-Id: I06e66859219e8d657063f24c59811338a195a28b
 2017-05-21 11:44:01 +02:00
Ed Sanders 5d00944d09 CollabPad: Move synchronizer/authorList to Target from Target.init 
Change-Id: I828ab12662e03cf674e20ae5676ca6eaa2592eba
 2017-05-21 10:30:33 +02:00
Ed Sanders 1a577b668d Move getWikitextFragment up to Target from ArticleTarget 
Any MW target may want to get a wikitext fragment, not just
ArticleTargets. Requires us to move refreshEditToken up as well.

Change-Id: I27d30e20fefd5ba266d3d8e5f99383e9b4d4993a
 2017-05-21 07:57:49 +00:00
Ed Sanders cf0a03ff5a CollabPad: Add popstate/teardown handling 
Change-Id: I3faa7e2dd79fa5f1816833852325185caa4e82d4
 2017-05-21 09:56:53 +02:00
Translation updater bot adc947e1f1 Localisation updates from https://translatewiki.net. 
Change-Id: Ibbc8c82e247dc5eb9ca616d9c0ff0ec1eeda7d12
 2017-05-20 22:58:20 +02:00
Ed Sanders 574baf2e8e Provide VE-rebaser in MediaWiki as Special:CollabPad 
Change-Id: I3ffe0e2b6af43d4018dcd79877f4f27ed7d6a7e7
 2017-05-20 19:51:09 +00:00
David Lynch 07e4d5fd17 dm.MWTransclusionNode: remove TableCellableNode mixin 
Change-Id: Ic08c7ba03ad2bee35a96a750377450475d0efeed
 2017-05-19 20:55:14 +02:00
jenkins-bot ed2a6b873e Merge "Allow extension nodes to convert to a specified type of dataElement" 2017-05-19 14:27:16 +00:00
Ed Sanders 153f7b034d Allow extension nodes to convert to a specified type of dataElement 
Sub-classes want to dynamically change type, e.g. inlineFoo/blockFoo,
but doing this after storeGeneratedContents invalidates the cache,
so ensure this is done as soon as the element is generated.

Bug: T151130
Change-Id: I80e2f2587cff8e9d9fe6ded5d8581263268deaa8
 2017-05-19 16:08:01 +02:00
jenkins-bot fbc835be12 Merge "MWCategoryInputWidget: missing 'new' for cached redirected optionwidgets" 2017-05-19 10:13:40 +00:00
David Lynch dfbbe378c3 MWCategoryInputWidget: missing 'new' for cached redirected optionwidgets 
Bug: T164820
Change-Id: I8b2ae9112af74910cb6ba5097dcec8be86cc1376
 2017-05-19 11:57:17 +02:00
Jforrester 352eaea9af Revert "Localisation updates from https://translatewiki.net." 
This reverts commit df892898c5.

hi messages corrupted.

Change-Id: I826f13d24bb43f54700a134b98ecc0fa14a6e3b3
 2017-05-19 08:35:58 +00:00
Translation updater bot df892898c5 Localisation updates from https://translatewiki.net. 
Change-Id: I45389fc125e3fd4823731c1cf561851be734b54c
 2017-05-18 23:02:00 +02:00
jenkins-bot 526d1ba71e Merge "Enable edit tab setup on appropriate Special pages" 2017-05-18 16:18:49 +00:00
Bartosz Dziewoński d687e01208 Do not check for visual editor availability when loading source editor 
Follow-up to fefb76eebc. Prior to that
change, the condition for this looked like this:

  // … if on a ?veaction=edit/editsource page
  (
    isViewPage &&
    uri.query.veaction in editModes &&
    (
      uri.query.veaction === 'editsource' ||
      init.isVisualAvailable
    )
  )

In the refactor, the `uri.query.veaction === 'editsource'` check was
lost.

Since that code is pretty messy (probably predating the source editor
and hastily adjusted), instead change the check for `isVisualAvailable`
to just `isAvailable`. If the requested mode turns out to not be
available later, the editor will not load.

Bug: T165146
Change-Id: Idfaf9115dd20cec8f8e044a704b93b07984cdcee
 2017-05-16 18:57:56 +02:00
jenkins-bot 4249e7898e Merge "Rename deprecated Card to current TabPanel" 2017-05-16 09:50:42 +00:00
jenkins-bot cfa8de994e Merge "MWTransclusionNode: Implement MWTransclusionTableCell" 2017-05-15 18:05:01 +00:00
David Lynch 0eb6b94b4c MWTransclusionNode: Implement MWTransclusionTableCell 
Back in de98382a55, references to MWTransclusionTableCell were introduced,
but weren't followed through on. So, actually add it. Have cellable
Transclusions use it as their type.

Bug: T144122
Depends-On: I054f12f4218102a12d7a9ea843f9c61e8825c52c
Change-Id: I367f878bfd1c58e20b62368cb78120604b48d791
 2017-05-15 12:09:11 -05:00
Ed Sanders 63c36c87da Always prefer wikitext for action=edit on non-SET wikis 
Ideally we could use the preferred editor, but this breaks
tab switching to the old editor.

Bug: T165238
Change-Id: I5f5ee5566cdd2080ba7c89d43cf127b457537768
 2017-05-15 12:48:30 +01:00
jenkins-bot 5e11f1669a Merge "Fix action=edit links for NWE" 2017-05-15 11:06:49 +00:00
Ed Sanders 9342e45f7b Fix action=edit links for NWE 
We added support loading NWE from action=edit in I35208cce069
but missed this check in the front-end.

Bug: T165238
Change-Id: I2732eaa81a3f968b34c4e878b2ad36de981dd567
 2017-05-15 11:52:06 +01:00
James D. Forrester 57aad56a7b Enable edit tab setup on appropriate Special pages 
Using the forthcoming wgRelevantPageIsProbablyEditable.

Bug: T165010
Depends-On: I6c6ca1cfd93e7be917952980f1e1d57aec3a1292
Change-Id: I6c6ca1cfd93e7be917952980f1e1d57aec3a1229
 2017-05-15 11:14:29 +01:00
Translation updater bot dd9a7ad9f9 Localisation updates from https://translatewiki.net. 
Change-Id: I3becfe7c241e510b558e65a54060d3e93cc907b5
 2017-05-14 22:48:41 +02:00
Translation updater bot db24f81138 Localisation updates from https://translatewiki.net. 
Change-Id: Ic7ce8924f898681caafe37761384f0f30919fc8c
 2017-05-12 23:19:04 +02:00
Translation updater bot 898091bfed Localisation updates from https://translatewiki.net. 
Change-Id: Ifa7703be93365df355b7de8db47e878a10b33256
 2017-05-11 23:37:50 +02:00
Volker E f695877de7 Rename deprecated Card to current TabPanel 
Renaming CardLayout to TabPanelLayout and all connected code instances.
Follow-up to Icfe1652cc038dc131b6b855ce9b45040b8ee5178

Bug: T164903
Change-Id: I9ce4e31e390522d469e126fb3a4b05787cef7fef
 2017-05-10 11:46:49 -07:00
David Lynch 2f40972807 MWWikitextDataTransferHandlerFactory: Don't reimplement getText 
I forgot about getText in 41ca528705, apparently.

Bug: T163237
Change-Id: Ibb646fc03a0293845c4449cbbe6c822ba63751f8
 2017-05-10 10:58:42 -05:00
jenkins-bot 862c3ca22e Merge "MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible" 2017-05-10 15:51:16 +00:00
jenkins-bot 24e4cb7d8b Merge "Update VE core submodule to master (fbeb0db2c)" 2017-05-10 15:36:39 +00:00
James D. Forrester 229d6cdf3b Update VE core submodule to master (fbeb0db2c) 
New changes:
d61440346 Add logging to the rebase server and client
d1d2539ae rebaser: Add script to convert a log file to a test case
0896d5f05 lib: Update README files for OOjs and OOjs UI
045ae87fb Localisation updates from https://translatewiki.net.
04b276e16 VisualDiff: Make annotation whitespace trimming configurable
dd04912e5 Localisation updates from https://translatewiki.net.
11fc30709 MobileContext: fix button spacing
7898acd0b Fix typos and minor lint issues
4e3e2deb9 Avoid using the global namespace in test files
1ed81efa1 build: Update eslint to 0.4.0 and make a pass

Bug: T163473
Bug: T164166
Change-Id: I4bab4260d6b05ff0277cacd167186336acc02080
 2017-05-10 10:02:54 -05:00
Translation updater bot 31bea72f3a Localisation updates from https://translatewiki.net. 
Change-Id: I1acf037adbf8456802f4321377b7209cb7268462
 2017-05-09 23:10:18 +02:00
David Lynch 41ca528705 MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible 
This lets us avoid a fraction of a second lag when someone pastes a plain URL
into source mode.

Bug: T163237
Change-Id: I0e673856dec5f273fb92731b27494762299d2d6c
 2017-05-09 10:19:15 -05:00
jenkins-bot 0f903b09d1 Merge "Generate visual diff only after switching to visual diff tab" 2017-05-09 13:31:36 +00:00
Ed Sanders debcd678b5 Generate visual diff only after switching to visual diff tab 
Bug: T164724
Change-Id: I48e49d4b68cc769b3e9d061983de4c78b5ad5c34
 2017-05-09 10:09:39 +00:00
Translation updater bot 4296814235 Localisation updates from https://translatewiki.net. 
Change-Id: I24e0b7ee282f937c0e7b1c44798a78439d723b63
 2017-05-08 23:01:19 +02:00
Translation updater bot 3e31b869e8 Localisation updates from https://translatewiki.net. 
Change-Id: I768ab6f09c49c7d3cdee0f0764a59ac0164bd445
 2017-05-06 23:07:00 +02:00
Translation updater bot 021c91811e Localisation updates from https://translatewiki.net. 
Change-Id: If05c18f72c4fb8276676c13e145ade05ec309739
 2017-05-05 22:54:40 +02:00
Translation updater bot 6f96b1e9d1 Localisation updates from https://translatewiki.net. 
Change-Id: Id74033215796baa8238a3635d8cba3fc1b08e0a2
 2017-05-04 23:11:44 +02:00
jenkins-bot 75b762d5c4 Merge "Specify suggested parent node types for tables" 2017-05-04 18:50:48 +00:00
jenkins-bot 20465377db Merge "Allow headings in divs" 2017-05-04 18:49:09 +00:00
Ed Sanders 9d83efc747 Specify suggested parent node types for tables 
This won't do anything useful until T164017 is resolved.

Bug: T164016
Change-Id: I39bffe2dc59a97888b81bdbe990e55ba95b0dd94
 2017-05-04 14:50:49 +00:00
Ed Sanders 485a159037 Allow welcome dialog to be variable height 
Bug: T164056
Change-Id: I277a709545151dbd51f92c21d6317a45b1088db2
 2017-05-04 13:08:33 +01:00
Ed Sanders 8e6105fec8 Allow headings in divs 
Bug: T164453
Change-Id: I986b1b376a592095c94d29a102278d4fde0a621f
 2017-05-04 12:43:36 +01:00
jenkins-bot 9b86ebae7f Merge "Follow-up 57a06a6: Use the same attribute name on read and on write" 2017-05-02 22:00:40 +00:00
James D. Forrester 486bbd7609 Follow-up 57a06a6: Use the same attribute name on read and on write 
Bug: T164054
Change-Id: I6770f6c91248fcd9ab39322413874e20a1b65552
 2017-05-02 14:42:22 -07:00
Translation updater bot eafe281fa3 Localisation updates from https://translatewiki.net. 
Change-Id: Ic48e5776fde9b30c47656b01718bbbf764e6b2da
 2017-05-02 23:22:42 +02:00
Ed Sanders 54fc920622 Captcha improvements 
* Fix focus and resize/scroll into view after the
  captcha has loaded (so after the image has loaded
  for FancyCaptch).
* Add margin between input and captcha
* Enable enter-to-submit on captch input field.
* Unify code for simple/math/questy and correctly
  render math as HTML (by looking at the mime type)

Change-Id: I10433cefbfea8569674c120dde5b489570e20966
 2017-05-02 17:49:12 +01:00
Ed Sanders 998ae22b2d Follow-up I488fd7e74: Adjust saveFail calls for new function signature 
Bug: T164157
Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
 2017-05-02 16:39:04 +01:00
jenkins-bot 68d00a6a42 Merge "init: Fix checks for required skin elements to avoid false positives" 2017-05-01 22:37:16 +00:00
jenkins-bot 089d765c0e Merge "Avoid global variables in tests and build" 2017-05-01 15:56:58 +00:00
jenkins-bot dc8935ae41 Merge "MWSignatureNode/Tool: Avoid global variables" 2017-05-01 15:49:37 +00:00
jenkins-bot 13307dd556 Merge "Fix minor lint errors and typos" 2017-05-01 15:49:35 +00:00
Bartosz Dziewoński a02e68374e init: Fix checks for required skin elements to avoid false positives 
* Do not try to load the editor on protected pages, or if the user
  doesn't have permission to edit pages.
* Move the check for required DOM elements after the check for
  pages without the editor (T162411) and after DOM ready (T163307).

Bug: T162411
Bug: T163307
Change-Id: I8149694ba8155682701f2cda6ca212d60f446caa
 2017-05-01 11:24:01 +00:00
Translation updater bot 99656bae30 Localisation updates from https://translatewiki.net. 
Change-Id: I3e87b5b23666918a904d77111c76160fbe3d0a74
 2017-04-29 23:31:44 +02:00
Ed Sanders 59b3f2e0dc Avoid global variables in tests and build 
Change-Id: I44dd3c3980f88e660798962c4aa0229b62760796
 2017-04-29 12:37:53 +01:00
Ed Sanders ede81b493e MWSignatureNode/Tool: Avoid global variables 
Change-Id: I0596b33e797830f3718f4edbe34075fdaced0831
 2017-04-29 12:37:28 +01:00
Ed Sanders 7c0fc8d3b9 Fix minor lint errors and typos 
* Commas that should be semicolons
* Unnecessary 'call's

Change-Id: I11a80702b5396a36e3deecc6e706a397cc354bd8
 2017-04-29 12:36:17 +01:00
Translation updater bot 26e155035e Localisation updates from https://translatewiki.net. 
Change-Id: Iccbb936fb34cf928fa72cf5d56c1654fe8ce86f4
 2017-04-29 00:09:45 +02:00
jenkins-bot bcb62d7907 Merge "Synchronise VE availability checks in frontend and backend" 2017-04-28 17:02:54 +00:00
Ed Sanders cd8b059e7d Synchronise VE availability checks in frontend and backend 
Adds better support for NWE loading on action=edit.

Change-Id: I35208cce0696607377378a1b58d426e914a3ba7d
 2017-04-28 17:45:27 +01:00
Ed Sanders 381f143a27 QUnit: Remove all code for counting tests 
Change-Id: Ifc20282a4da1aed9be2a9215c13f9a4e3e30168f
 2017-04-28 17:03:20 +01:00
jenkins-bot 323f2479ea Merge "Add basic support for Parsoid HTML5 video/audio" 2017-04-28 15:26:44 +00:00
Ed Sanders 0c2bb3da9c Add basic support for Parsoid HTML5 video/audio 
Change-Id: I30b787261c57e912e571170d8aa2d04726b6aa3a
 2017-04-28 14:08:18 +01:00
Translation updater bot c198ea287d Localisation updates from https://translatewiki.net. 
Change-Id: If183c1f7a7ddffa4dd2c61a6921ca5ad6f4b6bbe
 2017-04-27 22:59:54 +02:00
jenkins-bot 604dc2d86a Merge "MWMediaTransferHandler: Allow uploading of dropped Blobs" 2017-04-27 19:32:42 +00:00
jenkins-bot 2d34afeb27 Merge "VisualDiff: Check save dialog is still visible when re-rendering diff" 2017-04-27 18:53:12 +00:00
Ed Sanders 3999fb1eb6 VisualDiff: Check save dialog is still visible when re-rendering diff 
Change-Id: I1d740b767d150699863f18ee6dd9eca8a35b2bf1
 2017-04-27 18:36:07 +01:00
David Lynch 88f3191926 tests: MWInternalLinkAnnotation getFragment 
Also, fix docs for it. It could also return null for a missing fragment.

Change-Id: Ib6df379c5c3686a59026b6b66f26b3050ede231a
 2017-04-27 11:21:58 -05:00
Ed Sanders 3a9dcf7ec5 MWMediaTransferHandler: Allow uploading of dropped Blobs 
Previous the media upload panel didn't support this. This makes Chrome
behave in the same way as Firefox when pasting images into a document.

Bug: T39932
Change-Id: I12f190a48ae9b62d4ad2f33b2a4ee546fdf7b354
 2017-04-26 22:33:18 +00:00
Ed Sanders fefb76eebc Rewrite logic for choosing initial editor 
Expanding from a single if-expression lets us make the
code much more readable, and reveals some minor bugs.

Change-Id: I49e57bfc093e019c837a73eab5c25fdbd14de0af
 2017-04-26 12:07:51 -07:00
jenkins-bot a93888afd5 Merge "EditModeTool: Use state-describing, not action-describing labels" 2017-04-26 18:42:42 +00:00
Ed Sanders d1017bfd48 EditModeTool: Use state-describing, not action-describing labels 
Follows-up 914eb1cde3; reverts the logic to have the label change, but
sticks with new "-current" i18n messages, so the "X editing" instead of
"Switch to X editing"; the old i18n messages are now dropped entirely.

Bug: T162864
Change-Id: Icdad6c5bb06ff86e9b8976840bb1a94b939609a8
 2017-04-26 11:33:14 -07:00
David Lynch e1e89e8b14 DesktopArticleTarget: only destroy notices tool if it exists 
Bug: T163813
Change-Id: Ib957eac2d3d407f8e683082938ec51d882c2d041
 2017-04-26 18:03:39 +00:00
Translation updater bot 06a6abae2b Localisation updates from https://translatewiki.net. 
Change-Id: I3da20c65994635e306a799b81a9814c9071a6c65
 2017-04-25 23:02:08 +02:00
jenkins-bot c8f919a880 Merge "MWCategoryWidget: batch requests for category data" 2017-04-25 18:32:52 +00:00
L10n-bot e5706fcd9f Merge "Localisation updates from https://translatewiki.net." 2017-04-24 21:01:40 +00:00
Translation updater bot a7b4bfe522 Localisation updates from https://translatewiki.net. 
Change-Id: I06af2815f231bc169dba8bb82a009170a39bb176
 2017-04-24 23:01:33 +02:00
jenkins-bot 83b331e04e Merge "MWTemplatePage: Show a different message if the template doesn't exist" 2017-04-24 20:43:54 +00:00
jenkins-bot 233415cf50 Merge "MWTransclusionModel: Update for change in TemplateData" 2017-04-24 20:43:52 +00:00
James D. Forrester c787df90c5 MWTemplatePage: Show a different message if the template doesn't exist 
Bug: T162694
Change-Id: Icad5abb240efd10fadbfdb287acb98afe2361719
 2017-04-24 20:30:35 +00:00
jenkins-bot b268b4f80f Merge "ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error" 2017-04-24 19:48:35 +00:00
James D. Forrester 8fd621ad74 MWTransclusionModel: Update for change in TemplateData 
Depends-On: I7905502d0c419a04e4487095214634f1513b461c
Change-Id: I97a1bfc9f9ead082a673a91b9d2053630a90309c
 2017-04-24 19:13:59 +00:00
jenkins-bot 7df78e1ec1 Merge "MWSaveDialog: Check diffElement still exists after setTimeout" 2017-04-24 18:12:10 +00:00
Ed Sanders df3a4fb171 MWSaveDialog: Check diffElement still exists after setTimeout 
Bug: T162642
Change-Id: Iec01a8ebbda39d83fd1c2f4dbbef17793d9af1e4
 2017-04-24 18:03:35 +00:00
Translation updater bot 82792c5249 Localisation updates from https://translatewiki.net. 
Change-Id: I1f6839c2c0486ebc30a4d4cbc873f45314c84a16
 2017-04-23 22:53:34 +02:00
Translation updater bot e2309aa3ce Localisation updates from https://translatewiki.net. 
Change-Id: Icfc5631209c09ff5ca286de2ec583264b32d7c43
 2017-04-21 23:07:58 +02:00
Bartosz Dziewoński 70dd0c0d16 Remove unused message 'visualeditor-differror' 
Unused since a6b4258f47.

Change-Id: Ia4d8ca252dfe04416f1b45ae72f771bc53607ec3
 2017-04-21 18:43:36 +02:00
jenkins-bot 67d6ac38e6 Merge "Show a different label for the current mode in the editor mode selector" 2017-04-21 15:56:04 +00:00
jenkins-bot 1862f74f11 Merge "ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only" 2017-04-20 22:34:33 +00:00
Bartosz Dziewoński 371ac353cf ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only 
Sites like to customize 'readonlywarning' with things that we can't parse.
Instead, use 'apierror-readonly'. The old message is still shown in edit
notices.

Bug: T163455
Change-Id: I592accde17b256ecee27820df12d9d312499f8f7
 2017-04-21 00:08:57 +02:00
David Lynch f7d0df2449 MWCategoryWidget: batch requests for category data 
API query cuts off after 50 results.

Bug: T163406
Change-Id: I6e83843dd1a22334d9ddec7103ddf318fb181112
 2017-04-20 16:47:16 -05:00
L10n-bot 08a02f0b29 Merge "Localisation updates from https://translatewiki.net." 2017-04-20 21:16:54 +00:00
Translation updater bot 0e5f238f6b Localisation updates from https://translatewiki.net. 
Change-Id: I2636ef1e36cfce806d637e906f421cf1cd48548c
 2017-04-20 23:16:48 +02:00
jenkins-bot dd6113bb76 Merge "Load notices when switching, just don't show them" 2017-04-20 21:05:40 +00:00
Bartosz Dziewoński 91a75e3fef ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error 
If we retry and get another 'badtoken' error, something is very wrong,
and trying again and again is probably pointless. This behavior also
matches how mw.Api#postWithToken handles bad tokens.

Bug: T163493
Change-Id: I488fd7e74e37922044491695d6c9025a45531281
 2017-04-20 22:42:10 +02:00
Ed Sanders c02c529537 Load notices when switching, just don't show them 
Previously we completely disabled the loading of notices
when switching, instead of just not showing them (so they
don't clash with the "switched" popup).

Bug: T162812
Change-Id: I3f8e787630e196cee1dbb1aa449b3558b74fcd04
 2017-04-20 21:20:10 +01:00
James D. Forrester 914eb1cde3 Show a different label for the current mode in the editor mode selector 
Bug: T162864
Change-Id: I2242f85f8c4607411e65b64c8e43181bb139945f
 2017-04-20 13:00:34 -07:00
James D. Forrester bef15b7a1e Update VE core submodule to master (bfb35aaef) 
New changes:
57f8064b6 tests: Enforce dm unit test coverage at 20% per file and 80% globally
6f757c670 LinkAnnotation: add a getFragment method for consistency with MWInternalLinkAnnotation
c40a3f152 Drop the classList polyfill for IE9
d1af6c6bb Update OOjs UI to v0.21.1
bfb35aaef Localisation updates from https://translatewiki.net.

Bug: T162277
Change-Id: I5146bc421bb88e56bafadccefc7bbdee106504ea
 2017-04-20 09:48:46 -07:00
jenkins-bot 6c4b3d68f7 Merge "Move out Cite-specific unit tests in WT transfer handler" 2017-04-20 16:32:55 +00:00
Ed Sanders a7477a869f Move out Cite-specific unit tests in WT transfer handler 
Change-Id: Ibea6994a208e4b0b1022896eb31dd2f36f0fd6c6
 2017-04-20 17:07:46 +01:00
jenkins-bot 06777e20a3 Merge "MWCategoryItemWidget: remove DraggableElement's padding" 2017-04-20 15:23:29 +00:00
jenkins-bot 0c31c3c243 Merge "ve.ui.MWCategoryPopupWidget: Fix popup positioning" 2017-04-20 07:52:24 +00:00
David Lynch 1c47d71e7d MWCategoryItemWidget: remove DraggableElement's padding 
OOjs UI v0.21.0 changed DraggableElement's padding. Override it here, so it doesn't look broken any more.

Bug: T163404
Change-Id: Ic0bc4f9e3e060cf89e6bc7cb22068d1fe1441d75
 2017-04-20 02:05:42 -05:00
Translation updater bot 0a18ebcfe5 Localisation updates from https://translatewiki.net. 
Change-Id: I15974fc59db78fad152b63361d0aae8942888f8a
 2017-04-19 23:19:02 +02:00
Bartosz Dziewoński 4b7d188735 ve.ui.MWCategoryPopupWidget: Fix popup positioning 
Figuring out why it broke doesn't seem like a very interesting task,
so let's just throw the whole logic out and use OOjs UI PopupWidget's
new built-in ability to position itself relative to anything.

Bug: T163269
Change-Id: Ie464e4668001f4bc6151b40cef469937aa8c6e48
 2017-04-19 22:48:16 +02:00
Translation updater bot 6654de8f0b Localisation updates from https://translatewiki.net. 
Change-Id: Ic69f81d75182144f16a90375bc26c55d48a76998
 2017-04-17 23:21:48 +02:00
James D. Forrester 3a382e6398 Update VE core submodule to master (fc46ed86f) 
New changes:
719f8c667 ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one
35cadd7db Introduce single-line mode for surfaces
41fe321b2 Restore pointer-events comments for IE10 support
42f556820 Upgrade to jQuery v3
c1b8f142c Pass toolbarConfig position to actions toolbar by default
0d4c6a5fc Fix styling of table context in MW theme
db6eb4ebf Localisation updates from https://translatewiki.net.

Bug: T161944
Bug: T162808
Bug: T162830
Change-Id: I9b11673b4a77b7aebcdc282953d83ade08a8d8bd
 2017-04-17 11:25:00 -07:00
Esanders eeab63d2c7 Revert "Dropping IE9: Remove disableUneditableContent from DesktopArticleTarget" 
IE10 also lacks pointer events support.

This reverts commit 5266776953.

Change-Id: I42c9530c45ad98657b403bdb266188368085716b
 2017-04-14 13:53:56 +00:00
James D. Forrester 0ca821b321 Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but not from null 
Whoops.

Bug: T162939
Change-Id: I5a9315e3cfc8a9e8edfb2ef597daeae09bbf5c5e
 2017-04-13 14:38:20 -07:00
Ed Sanders f20b9b0aa0 doc: Tag mixin inheritance hacks with bug 
Also mixin dm.MWResiazble to dm.MWImage (already done
in CE).

Bug: T92540
Change-Id: I32215873993a7e9a7f775ce3f39e2d378e0f31cd
 2017-04-13 11:00:17 -07:00
James D. Forrester d989de5c09 DesktopArticleTarget.init: Don't call setEditorPreference twice 
This is run after the targetPromise completes (via the platform-agnostic
setDefaultMode proxy), which is the correct time to do so. We should not
do this twice, and we definitely shouldn't do this before the target has
successfully loaded, lest a user ends up with us setting their option to
"prefer" an editor that they actually can't load. Whoops.

Bug: T156316
Change-Id: Icf4b5ddd9c8265ade55f43328f807344b41db350
 2017-04-13 04:38:07 +00:00
James D. Forrester ca6cf4e914 ve.test.utils: Don't try to write user options in test suites 
Bug: T162810
Change-Id: I8c2588fe4f7577b962200b583efd68f9cb80367e
 2017-04-13 00:42:51 +00:00
David Lynch efc469f2f4 TemplatePlaceholderPage: abort pending template search after adding template 
With precise timing, the lookup menu could appear after the add template
button had been pressed and the user had moved on to the next page.

Bug: T162707
Change-Id: I36941dc7288c6031a0fb189c0946aa6d8f8697e8
 2017-04-12 11:34:42 -05:00
jenkins-bot b278907870 Merge "dm.metaitems: Turn grouped metas into variadic ones" 2017-04-11 23:13:57 +00:00
Translation updater bot d609f2554d Localisation updates from https://translatewiki.net. 
Change-Id: Id0ae8c83283669d6fe27fdca7b5a475289c74eee
 2017-04-11 23:12:25 +02:00
James D. Forrester 57a06a6e75 dm.metaitems: Turn grouped metas into variadic ones 
We're getting rid of meta item grouping, so we need to prepare.

Merged:
* ve.dm.MWIndexMetaItem
  from ve.dm.MWIndexDisableMetaItem and ve.dm.MWIndexForceMetaItem
* ve.dm.MWNewSectionEditMetaItem
  from ve.dm.MWNewSectionEditDisableMetaItem and ve.dm.MWNewSectionEditForceMetaItem
* ve.dm.MWTOCMetaItem
  from ve.dm.MWTOCDisableMetaItem and ve.dm.MWTOCForceMetaItem

These three now inherit from ve.dm.MWFlaggedMetaItem to avoid code duplication.

Change-Id: Ic8a9cdb1226dccac2c27e7f4b965c1590a7387c0
 2017-04-11 11:13:18 -07:00
David Lynch cdefd36d1e Internal link context popup: selflinks still get link styling 
Bug: T162671
Change-Id: I0ba584b90db73ebade81050f0d782945b8934080
 2017-04-11 10:51:05 -07:00
David Lynch d5ac18a466 LinkCache: don't treat a link with a fragment as a selflink 
This matches the rendered output for the page.

Bug: T162669
Change-Id: I1ea0ab37a2751c0b4669da8a23adf0ce271facea
 2017-04-11 12:19:01 -05:00
Translation updater bot bcf13d5a32 Localisation updates from https://translatewiki.net. 
Change-Id: Ie290cf3caeecc964b6e9639da7a637311d84ab01
 2017-04-10 23:09:29 +02:00
Ed Sanders 55368c1170 VisualDiff: Ignore changes to originalMw 
Can happen when switching edit modes.

Also fix typo in describeChanges.

Change-Id: I2c02adc34aef975b9f6f902a74907d24b7edc54a
 2017-04-10 21:22:16 +01:00
Ed Sanders a6b4258f47 ArticleTarget: Refactor savedialog/target interaction 
* Pass a wikitext promise, instead of wikitext
* Handle writing of content to the dialog from within
  the dialog.
* Handle diff errors within the dialog.
* Never disable the 'Return to save form' (approve) button
* Remove redundant messages

Change-Id: Ibd76e8951998f751abfb4f407682202c2f73ac7e
 2017-04-10 10:29:41 -07:00
Ed Sanders 7a66d4f08a Update VE core submodule to master (1338c50f5) 
New changes:
ae0204885 stylelint: Remove no-unsupported-browser-features overrides
d744cd576 Localisation updates from https://translatewiki.net.
1338c50f5 [BREAKING CHANGE] Remove resize handlers from within DiffElement

Local changes:
Trigger diff element resize on dialog resize

Depends-On: I82a67a4309bf76db5407ea38c26c47d14c01e921
Change-Id: I912a99edca25ff576e2872723f91afe54e36a170
 2017-04-10 10:29:18 -07:00
jenkins-bot 4110bdfd26 Merge "VisualDiff: Fetch original doc from Parsoid if fromEditedState" 2017-04-10 17:09:46 +00:00
jenkins-bot 77987b976d Merge "Remove #wpTextbox1 fallback from ArticleTargetLoader#requestPageData" 2017-04-10 17:05:03 +00:00
jenkins-bot edb911ef71 Merge "Dropping IE9: Remove disableUneditableContent from DesktopArticleTarget" 2017-04-10 16:50:59 +00:00
jenkins-bot 40265bd807 Merge "stylelint: Drop no-unsupported-browser-features references" 2017-04-10 16:49:15 +00:00
jenkins-bot c0361ab40e Merge "Update VE core submodule to master (da9c49395)" 2017-04-10 16:49:13 +00:00
jenkins-bot 17e1a3e3f2 Merge "Make Target#getVisualDiff async" 2017-04-10 16:02:05 +00:00
Ed Sanders 5266776953 Dropping IE9: Remove disableUneditableContent from DesktopArticleTarget 
Bug: T162277
Change-Id: Ibb38284573078098c2173232239e9836a8161f56
 2017-04-10 08:37:03 -07:00
James D. Forrester f51a6d5020 stylelint: Drop no-unsupported-browser-features references 
The rule hasn't been applied for a while, as it was deprecated upstream.

Change-Id: I7877d0e3bdcd05a609d61add2dc62d7598e348cb
 2017-04-10 08:36:37 -07:00
James D. Forrester d1c24ce226 Update VE core submodule to master (da9c49395) 
New changes:
dc0cad28c tests: Factor out ve.dm.TestRebaseClient/Server into their own files
98061108b Convert RebaseServer tests to data provider
3e746a51b Update OOjs to v2.0.0
16231a812 [BREAKING CHANGE] Drop support for Internet Explorer 9
64daeb4b5 Localisation updates from https://translatewiki.net.
3310e876c Update DOMPurify to 0.8.5
579033a83 Follow-up 16231a81: Drop IE9 support in createDocumentFromHtmlUsingIframe

Bug: T162277
Change-Id: If17c6a3fac0920db29f80069f344ffd6be46c3c9
 2017-04-10 08:32:51 -07:00
Ed Sanders 939a1f4005 VisualDiff: Fetch original doc from Parsoid if fromEditedState 
Bug: T160741
Change-Id: Ied0641cc868a8dd4cf540eba75e1b248277a96b0
 2017-04-09 22:28:53 +01:00
Ed Sanders ddf6a89c72 Remove #wpTextbox1 fallback from ArticleTargetLoader#requestPageData 
Makes the API clearer and the method re-usable.

Change-Id: If79afb262e0c8c8e2193c07fef6bb0712496a4d9
 2017-04-09 22:28:03 +01:00
Translation updater bot 603c520c28 Localisation updates from https://translatewiki.net. 
Change-Id: I4824487a4f9a1addb6863561b90d07ff22d50bfd
 2017-04-09 23:06:56 +02:00
Ed Sanders 97f6bdd79a Make Target#getVisualDiff async 
This will be required later when we have to fetch the original
document from the server before running a visual diff.

Change-Id: I351688f4d1fec892bc297f40c209939cbb2ccf95
 2017-04-09 13:26:22 +01:00
Translation updater bot 6f113eedfd Localisation updates from https://translatewiki.net. 
Change-Id: I354180d1b17eacfe0ba1ab883b240bbc6a2ffc14
 2017-04-07 22:54:56 +02:00
Ed Sanders 981dd6c250 Don't set oldid if it is equal to curId 
Change-Id: I0fff55ab1e8d9c5c24b39526aa5d8a893cd99a2a
 2017-04-07 11:49:30 +01:00
Roan Kattouw 1e7e9044c9 MWVESwitchPopup: Follow-up 445f8b76a0: apply adjustment to anchor instead 
Otherwise the anchor isn't correctly aligned below the icon.

Change-Id: I73a9db9be63354f1fa459e844eb40be1d3130189
 2017-04-06 16:33:53 -07:00
Roan Kattouw 445f8b76a0 MWVESwitchPopupWidget: Fix alignment by removing margin 
Since the PopupWidget rewrite, margins for aligning popup anchors
should be set on the anchor itself, not on the popup.

Change-Id: If8237ae5edbc2e8c5cb99147f392aae52e642765
 2017-04-06 11:50:43 -07:00
jenkins-bot d4438549e5 Merge "ArticleTarget: building summary in source mode, strip links from section titles" 2017-04-05 23:57:18 +00:00
Bartosz Dziewoński c45ad46433 Allow loading progress bar to appear on skins other than Vector and MonoBook 
The styles are not specific to the Vector and MonoBook skins, but rather
to the MediaWiki and Apex themes of OOjs UI. Rename them to reflect that.

Change-Id: I757e8d96625feb8290cbf7837b5d801961cda344
 2017-04-05 20:13:28 +02:00
David Lynch 758b2fd689 ArticleTarget: building summary in source mode, strip links from section titles 
Bug: T162017
Change-Id: I76e96d1e36f7bad0b3e17d8bb842c6ad1172f8cc
 2017-04-05 11:16:11 -05:00
Translation updater bot 6d453076a4 Localisation updates from https://translatewiki.net. 
Change-Id: Idf887a77ec667314758aa550b43c0e7c1c95bcb1
 2017-04-04 23:01:49 +02:00
Ed Sanders d50f49de82 MWExtension describeChanges: Actually return value of parent 
Bug: T161357
Change-Id: I7a81ab68dc2f632bd6f380caafef2cba326ad0ef
 2017-04-03 22:57:49 +02:00
jenkins-bot ae59abc35e Merge "Use tabs to indent in json" 2017-04-03 17:23:29 +00:00
Translation updater bot f3a898aeab Localisation updates from https://translatewiki.net. 
Change-Id: Ib35521981875291c847bff7b8704c301b2d399db
 2017-04-02 22:58:12 +02:00
Translation updater bot 1f8550a7d1 Localisation updates from https://translatewiki.net. 
Change-Id: If4fc7506912c647e02214140cd46c4eebd3210e4
 2017-04-01 23:09:54 +02:00
jenkins-bot c599a82fe8 Merge "MWSaveDialog: Run links through a render function for preview & visual diff" 2017-04-01 15:22:09 +00:00
Umherirrender a16812428e Use tabs to indent in json 
Change-Id: Ib0372c86bcaac368f4dd68a512273b504ca9b6b2
 2017-03-31 23:50:07 +02:00
James D. Forrester 8463524e18 MWSaveDialog: Run links through a render function for preview & visual diff 
Provide a utility funcition in ve.init.mw.LinkCache to do this.

Also use this in ve.ce.MWTransclusionNode/ve.ui.MWPreviewElement, and
introduce to ve.ce.MWExtenionNode

Bug: T73900
Bug: T153535
Change-Id: Ieb9a0274b8c5ae1932c431546f09d18000fa6dd9
 2017-03-31 10:51:35 +01:00
Bartosz Dziewoński 285a078b21 Check magic link autolink sequences also after paste 
Bug: T161152
Change-Id: Ie308cdb287f805da888325d4c9ba6d3c35bd017c
 2017-03-30 23:13:00 -04:00
jenkins-bot 9e69bd360f Merge "WikEditor switch widget: Fix styling regression since OOui 0.20.1" 2017-03-30 21:31:37 +00:00
Translation updater bot 9c0b32277e Localisation updates from https://translatewiki.net. 
Change-Id: Ieafdeebf002dc7a8c7c01928a19185d25c351a56
 2017-03-30 23:20:20 +02:00
Ed Sanders 1b1b95acd4 WikEditor switch widget: Fix styling regression since OOui 0.20.1 
Change-Id: I489e45a587e2c10cfb60ade2b5f180f872495324
 2017-03-30 22:18:54 +01:00
jenkins-bot 90c16eb1d4 Merge "MWTransclusionDialog: Move box-shadows to Apex-only" 2017-03-30 16:57:12 +00:00
Ed Sanders 2bc3bd75dd MWTransclusionDialog: Move box-shadows to Apex-only 
Use solid borders for MW theme.

Change-Id: I4a5418d006adf0c7d47dc58624868cf6bb4b7de6
 2017-03-30 17:03:35 +01:00
Ed Sanders 003800f75a Follow-up I88d45aad2: Fix selflink detection 
data.title is not set in the cache, use the query title
instead.

Bug: T52497
Change-Id: I6a3047d3c18110052c70277781bc7be6ead2e7b4
 2017-03-30 11:56:13 +01:00
jenkins-bot 1dc16af006 Merge "Render self-links as if they were <strong>s" 2017-03-30 09:17:00 +00:00
James D. Forrester cb875a6ccc Render self-links as if they were <strong>s 
This is a little inelegant, but it works in both CE and transclusion
content.

Bug: T52497
Depends-On: If058843924c3b30c116df2520aef93a004d98a5d
Change-Id: I88d45aad2aaa45e71b433350986b19764603a1f2
 2017-03-29 23:47:01 +00:00
jenkins-bot da05545faf Merge "Replace $wgVisualEditorSupportedSkins with a check for required elements" 2017-03-29 23:14:53 +00:00
Ed Sanders 6d891dc049 Pass section when resolving conflicts in NWE 
Bug: T154217
Change-Id: I61f69df228fcbe25840b166a2081cacdb0417431
 2017-03-29 22:21:17 +01:00
Translation updater bot 9e893b715b Localisation updates from https://translatewiki.net. 
Change-Id: I4adc48e289d109cbde9c890551bdcb8314afa88f
 2017-03-29 22:50:25 +02:00
Bartosz Dziewoński ae8b0a1f36 Replace $wgVisualEditorSupportedSkins with a check for required elements 
The bare minimum of elements that must be present on the page for
VisualEditor to start and mostly work is:

* '#content' to attach our interface (toolbar etc.)
* '#mw-content-text' to replace with the editing surface
* '#ca-edit' to start up the editor

When those elements are missing (and we expect them to be present,
e.g. we're not on a special page), we print a console warning.

For example, VisualEditor now launches on Timeless and CologneBlue.
It does not launch and prints a warning on Modern and Erudite.
(It is actually possible to edit and save pages on CologneBlue,
although various pieces of the interface look funny.)

This does not change which skins we claim to support: these are still
currently only Vector, MonoBook and Apex. But it allows third-party
skin developers to more easily test the editor and fiddle with their
CSS to make it look right.

Bug: T161373
Change-Id: I97c786f3c8c795c238b10bef332a129ea26f86c2
 2017-03-29 18:13:05 +00:00
jenkins-bot 11f562c4e2 Merge "Don't use '#content #firstHeading', unnecessarily specific" 2017-03-29 18:02:22 +00:00
Bartosz Dziewoński 645eb8e543 Don't use '#content #firstHeading', unnecessarily specific 
Simply '#firstHeading' does fine.

Change-Id: I7c72496f0d58b86582bd33c018b618e1b75f2c7a
 2017-03-29 17:37:29 +00:00
Bartosz Dziewoński 38db8bbe0e Consistently use #catlinks to refer to category links container 
The element has both the class and the id set to 'catlinks'. This is
just for consistency, I have no preference on which to use.

Change-Id: Ic96b0f21fe790d0aa03bfd6366ba246e8493a038
 2017-03-29 17:36:58 +00:00
David Lynch 1f1be831c0 Add template: don't try to add invalid templates when enter is pressed 
Bug: T161715
Change-Id: I12eabe3588fbcbed0fa18b94de7de7239ba490c2
 2017-03-29 10:53:17 -05:00
Translation updater bot f5d6ab9aa7 Localisation updates from https://translatewiki.net. 
Change-Id: Iade5455bc90d8ba51dc481b7a4e9ac82ed2cc1e3
 2017-03-28 23:03:46 +02:00
jenkins-bot 16918a08cf Merge "ve.init.mw.ArticleTarget: Don't construct element IDs dynamically" 2017-03-28 17:23:11 +00:00
Bartosz Dziewoński 6a9f8a1417 ve.init.mw.ArticleTarget: Don't construct element IDs dynamically 
Easier to find the usages this way.

Change-Id: I38ce1389af1d30ff1f5e0214b68d094a67da046f
 2017-03-28 19:01:46 +02:00
jenkins-bot efc0cad89e Merge "MediaDialog: flag caption widget as being in a dialog" 2017-03-28 16:57:22 +00:00
David Lynch 9e86d17260 MediaDialog: flag caption widget as being in a dialog 
This means that cmd+enter won't add a newline when it closes the dialog.

Bug: T161555
Change-Id: I738c9acf8cce437ce6bc4c8db29f28d1fff3d2c9
 2017-03-28 11:43:59 -05:00
jenkins-bot d3df69ee99 Merge "ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling" 2017-03-28 16:41:40 +00:00
jenkins-bot 3d9b2fbd8a Merge "DesktopArticleTarget: Make the waiting module list extensible" 2017-03-28 15:59:02 +00:00
jenkins-bot 0dfe429a1e Merge "ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing" 2017-03-28 15:43:09 +00:00
Bartosz Dziewoński 0462b6ed8f ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling 
Redirect pages have two extra things not present on normal pages:
* Redirect subtitle: the "Redirect page" shown under the page heading.
* Redirect page content header: the "↳ Foo" at the beginning of content.

Our handling was pretty messy and had some bugs (T161614).

Notable behavior changes:
* Update 'wgIsRedirect' in mw.config after saving the page.
* Use #mw-content-text rather than .mw-jump for inserting the fake .redirectMsg.
  .mw-jump is not guaranteed to exist on the page (it's a skin feature).
* Never replace the real .redirectMsg existing on the page, except by the
  new HTML after a page is saved. Our fake is separate now.

Bug: T161614
Change-Id: I96a5e45a71bf10bf6a2b501dc0cf81e6c37060ec
 2017-03-28 17:40:23 +02:00
Bartosz Dziewoński d905d705ce ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing 
To reproduce: start editing a page, turn it into a redirect,
cancel editing and go back to view mode. The "Redirect page"
subtitle under the page title should disappear.

Note that #redirectsub is correctly spelled all lowercase,
unlike #contentSub.

This reverts commit 0e1bc7309b
and fixes the code instead.

Change-Id: Ibacd73122dfec63268a77794bc77c4b88876d3ee
 2017-03-28 01:31:29 +00:00
jenkins-bot 57d57cdbbf Merge "ve.init.mw.DesktopArticleTarget: Remove unused code" 2017-03-28 00:50:50 +00:00
Bartosz Dziewoński 0e1bc7309b ve.init.mw.DesktopArticleTarget: Remove unused code 
As it happens, #redirectsub is correctly spelled all lowercase,
unlike #contentSub. This line does nothing. We remove #redirectsub
correctly elsewhere; I don't think this was ever meant to be here.

Follows-up 96421b283c.

Change-Id: I3e4c6eb2ff94f363b488477b3ddd248e571e723a
 2017-03-28 00:39:38 +00:00
Translation updater bot 2f5998000e Localisation updates from https://translatewiki.net. 
Change-Id: I922c40abd3ed0ae819f9e59c63c40a0159e09eaa
 2017-03-27 23:48:36 +02:00
Translation updater bot d9a3ab6c1b Localisation updates from https://translatewiki.net. 
Change-Id: Id8ea802cf94dbdb58777adc559758795080a50ee
 2017-03-26 22:48:21 +02:00
Ed Sanders 4ac660ad48 Defer rendering of visual diff until tab is selected 
Bug: T161355
Change-Id: I718a92f4c9f8c3a48e359da898ede7dccebcec5e
 2017-03-25 13:23:28 +00:00
jenkins-bot 34552aba9d Merge "Use ve.targetLinksToNewWindow" 2017-03-24 23:56:51 +00:00
jenkins-bot 34fa4dcda6 Merge "Use original title or normalized title when inserting link text" 2017-03-24 22:27:33 +00:00
Ed Sanders 738d3aff47 Use original title or normalized title when inserting link text 
Original title will preserve the case of what the user entered
into the inspector. Noramlized title will remove any unwanted
leading colons from file/category links.

Bug: T118408
Bug: T124410
Bug: T160977
Change-Id: I92ffc19eab4eead0d124e84afc1e5a0a3e535867
 2017-03-24 22:16:31 +00:00
L10n-bot 3cbf2f8078 Merge "Localisation updates from https://translatewiki.net." 2017-03-24 22:03:31 +00:00
Translation updater bot cb6884136c Localisation updates from https://translatewiki.net. 
Change-Id: Ic4b43e99dddd8e74ee58ba4a00fc34c3cbeb0681
 2017-03-24 23:03:24 +01:00
jenkins-bot 09b0340c90 Merge "Apply the 'external' link class hack to MWPreviewElement" 2017-03-24 21:55:40 +00:00
Ed Sanders b756199dc7 Use ve.targetLinksToNewWindow 
Depends-On: I3088e8b95d9032b8e8fd5bff58a8b97ffaa15f98
Change-Id: I07ec10841b62ed1e8c3b3cf82b42653327618cb0
 2017-03-24 21:34:47 +00:00
Ed Sanders c485bd4fce Apply the 'external' link class hack to MWPreviewElement 
Change-Id: I3ccea9a72f812e73bdc4d8d34635671dfd493be4
 2017-03-24 18:53:08 +00:00
James D. Forrester 79b7d0305a *ArticleTarget: Don't trust oldid in the query string, it lies 
Bug: T156998
Change-Id: Iacb94710c8f2f5fbd8d3de9c8a44424aba0c7d02
 2017-03-24 00:30:00 +00:00
Translation updater bot e8bd893e93 Localisation updates from https://translatewiki.net. 
Change-Id: I6463f2e4c50274718ae3bfa80e557be5dcca4d65
 2017-03-23 23:03:48 +01:00
jenkins-bot 21ec4e87a9 Merge "Section editing: strip links from heading text used for edit summary" 2017-03-23 18:45:07 +00:00
jenkins-bot 0869a70cfa Merge "Fix typo in surfaceReady documentation" 2017-03-23 18:09:40 +00:00
jenkins-bot 0bb9bd5aa3 Merge "ve.dm.MWImageNode#describeChanges: Ignore borderImage noise from the model" 2017-03-23 16:11:07 +00:00
jenkins-bot e573a5f444 Merge "ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value" 2017-03-23 15:55:16 +00:00
James D. Forrester c70526f0a2 ve.dm.MWImageNode#describeChanges: Ignore borderImage noise from the model 
Also follow-up 335b56728a by adding the visualeditor-changedesc-align
i18n which was missed.

Change-Id: I801f66c0028f71cf2cdbcb8f1675ba1f5a3cde31
 2017-03-22 17:28:41 -07:00
L10n-bot c0c2e5d9c1 Merge "Localisation updates from https://translatewiki.net." 2017-03-22 22:10:38 +00:00
Translation updater bot fe5488bd82 Localisation updates from https://translatewiki.net. 
Change-Id: Id53d79ec3c6ace2db8a3a39a039396c80899cafa
 2017-03-22 23:10:31 +01:00
jenkins-bot 628852c3bc Merge "ImageCaptionNode: correct documentation typo" 2017-03-22 21:42:48 +00:00
jenkins-bot 048aaa7fb4 Merge "Connect onModelUpdate to the right view node" 2017-03-22 21:18:16 +00:00
Thalia 1f2655ce1a ImageCaptionNode: correct documentation typo 
Change-Id: Ic6e66e82662ec2fbf673062a0b3bc1087c54c4c7
 2017-03-22 21:10:47 +00:00
Ed Sanders ae780f43ed Fix typo in surfaceReady documentation 
Change-Id: I4ae5552000eb6dc160acc4fd2e2b218bf2c7411f
 2017-03-22 20:35:42 +00:00
Ed Sanders 9526bcf6a1 Connect onModelUpdate to the right view node 
Pretty sure this event does nothing for block images, but
if we are going to bind, bind the the ce caption node, not
the ce image node.

Change-Id: I02b5500f381e932efba87d61ccdf668cda377757
 2017-03-22 20:33:55 +00:00
James D. Forrester 555aba7fe8 ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value 
Bug: T160967
Change-Id: Ic83e204eb5c2d14baadf0e450a27ce836337b983
 2017-03-22 13:49:49 -05:00
David Lynch 1dc18b6703 Section editing: strip links from heading text used for edit summary 
Stops us including "[edit]" in the summary when people have marked whole
headings for translation.

Bug: T160911
Change-Id: I906398e6bf45433d904795847f59b5bf0148092f
 2017-03-22 02:00:24 -05:00
Translation updater bot 43dbe38dae Localisation updates from https://translatewiki.net. 
Change-Id: Ic295ea41987f435be9fd025d274ab87179608194
 2017-03-21 22:54:33 +01:00
Bartosz Dziewoński 86f739c994 Remove "prefix": "oo-ui-icon" from ve.ui.Icons.json 
This gets overridden by "selectorWithoutVariant" and "selectorWithVariant"
in the module definition anyway.

Change-Id: I51b8e76d542058c008d92ce55c7ec6bb66df70b7
 2017-03-21 20:27:04 +01:00
Ed Sanders 1adedfbd8b Disable clickable categories bar in wikitext mode 
Bug: T160733
Change-Id: I79b7c880e63675a322b2ada053819b36a175ccbe
 2017-03-20 11:07:52 +00:00
Translation updater bot b3566dde97 Localisation updates from https://translatewiki.net. 
Change-Id: Ifb2f7e4a3f14de95c4b4400330d1b3207370fdff
 2017-03-18 23:03:38 +01:00
Translation updater bot e227996539 Localisation updates from https://translatewiki.net. 
Change-Id: Ie989ec6b785d9de48465481e4ef3da88f17e7998
 2017-03-17 22:50:58 +01:00
David Lynch 217640624a DesktopArticleTarget: Make the waiting module list extensible 
So that GlobalCssJs and other extensions can hook in.

Bug: T156899
Change-Id: I045c7b045ce28047298b28a05e77ef27749c1ee1
 2017-03-16 17:48:03 -07:00
David Lynch e035c1de08 Follow up ec559041: abort notices display early if no notices 
This avoids attempting to toggle after a destroy call has been made.

Change-Id: Ia756ff6436ec0590639dbbff216c9999daf684ec
 2017-03-16 18:00:22 -05:00
James D. Forrester b6b041961b Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destroyed 
Change-Id: I9f26d252db8069e514dddf00f6f42194fe0a1c15
 2017-03-16 15:49:15 -07:00
Translation updater bot 7a8cc04f0d Localisation updates from https://translatewiki.net. 
Change-Id: I75712f53ef3d2ca69f25d5bb3908ec66e2b4d249
 2017-03-16 23:35:16 +01:00
jenkins-bot 421a432b7a Merge "VisualDiff: Add custom messages for change descriptions" 2017-03-16 21:50:07 +00:00
Ed Sanders 9cd8faea8b VisualDiff: Add custom messages for change descriptions 
Bug: T151403
Change-Id: I469a3c7897f2417c1850364f65da51c0deca2386
 2017-03-16 14:36:09 -07:00
jenkins-bot 0ae808913c Merge "Introduce visual differ in the save dialog" 2017-03-16 21:28:41 +00:00
jenkins-bot 85736d5a7b Merge "Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup" 2017-03-16 20:14:05 +00:00
Ed Sanders 12c73bc01f Update VE core submodule to master (ef5dc965f) 
New changes:
4b94f212e Add tool to change directionality of document view

Bug: T153356
Depends-On: I1e3d89e8250b75d0b6992cf4664e84de66d99bc0
Change-Id: Ic832cc661a0899b1668eb650fb09b66ada54d1ef
 2017-03-16 12:42:42 -07:00
James D. Forrester ec5590418e Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup 
Running setNotices( [] ) makes MWNoticesTool run this.destroy() to avoid taking
up extra space in the toolbar when not needed.

Also, make setNotices() bail earlier.

Change-Id: I492fd59a1e15e8f296bf7f03d9b0035c40dafa59
 2017-03-16 11:29:34 -07:00
jenkins-bot f39c6f5983 Merge "MWNoticesPopupTool: When setting notices, clear existing notices" 2017-03-16 17:46:49 +00:00
David Lynch 318c6718fd MWNoticesPopupTool: When setting notices, clear existing notices 
This would keep on duplicating notices when switching modes.

Change-Id: I04720904eddd95c0d3618d284d1930e41a0ae137
 2017-03-16 12:13:36 -05:00
David Lynch eb8ba26adf DesktopArticleTarget: Only try to show notices if some exist 
This avoids an OOui deprecation warning for trying to toggle a popup which
isn't connected to anything.

Bug: T160161
Change-Id: I9ad97785f0de4ecf81d189985459689644e25923
 2017-03-16 11:35:10 -05:00
Ed Sanders 335b56728a Introduce visual differ in the save dialog 
Bug: T143350
Change-Id: I1297d0f4bb87e69be3b50220c1830a22dac1bbae
 2017-03-16 15:33:54 +00:00
jenkins-bot a3a4ff3d20 Merge "Don't load VE or NWE on lint-targetted pages (until that works)" 2017-03-16 04:59:33 +00:00
Bartosz Dziewoński 3d5cedb0ff ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking 
These changes allow us to be more aggressive in autolinking ISBNs (no
need anymore to wait for the user to type a space or move their
selection) and more correct in autolinking RFCs and PMIDs (stray
spaces and dashes no longer mess them up).

* ISBN numbers can only be 10 or 13 digits long. We don't need to
  handle arbitrary lengths.
  * If a number does not begin with 978 or 979, it's the ISBN-10 variant
    and we can autolink it as soon as the user types 10 digits.
  * If a number begins with 978 or 979, it can be either.
    * But if we already have 13 digits typed, autolink immediately.
    * Otherwise, use a delayed sequence to see if it ends at 10 digits.
* RFC and PMID numbers can consist only of digits, no optional spaces
  or dashes are allowed. Typing a space or dash will immediately
  autolink the number.

Bug: T117165
Change-Id: I6a085cd78d910661245a351f3ceb3fabe2f093cf
 2017-03-15 21:58:26 +00:00
Bartosz Dziewoński 5afd15b2cc ve.ui.MWLinkAction: Use delayed sequence 
The trailing space at the end of the regexp is no longer required to
prevent matching (and executing) too soon. We also don't need to know
about trailing punctuation.

However, to prevent the match from ending in the middle of typing, we
have to allow for ' ' and '-' at the end of the match.

Tweaked tests to better match the intent now that a trailing space is
not included, but they pass without changes too, the command is quite
permissive.

Bug: T117165
Depends-On: Ie36046fa43ce49f8a25c99f2de577eb296d68a51
Depends-On: I2af0a738afa43295bf6d7d612cac4349bc6cd20d
Change-Id: I7c28d5c93b1a441387ad05a75846af83d2b21b6a
 2017-03-15 21:58:13 +00:00
James D. Forrester c07a6df74c Don't load VE or NWE on lint-targetted pages (until that works) 
Bug: T160102
Change-Id: Ibb364ff2d89975d5907fa887cca666eee6e78d37
 2017-03-15 14:23:17 -07:00
jenkins-bot 2a9562aca5 Merge "MWAceEditorWidget: Fix position of ace tooltip" 2017-03-15 19:23:38 +00:00
Ed Sanders 6fc47dce64 MWAceEditorWidget: Fix position of ace tooltip 
The floating tooltip breaks inside OOUI dialogs. In the absence
of an upstream fix, just anchor it to the bottom of the textbox.

Bug: T160245
Change-Id: I9055c4e4947f5581605bd490f076415c1edaf8ec
 2017-03-15 12:02:27 -07:00
jenkins-bot 6e14a1eb8e Merge "MWExtensionWindow: Remove pointless zero argument from ve.debounce call" 2017-03-15 18:24:09 +00:00
jenkins-bot ea8606360d Merge "MWMediaInfoFieldWidget: Add extra rules for word-break: break-word" 2017-03-15 18:14:35 +00:00
Ed Sanders 5086b45f15 MWExtensionWindow: Remove pointless zero argument from ve.debounce call 
Change-Id: I58a048af0e6397592e84554024aed3a17c5e5977
 2017-03-15 17:57:54 +00:00
Ed Sanders 97a8041bf2 MWMediaInfoFieldWidget: Add extra rules for word-break: break-word 
We use three rules elsewhere for better browser support

Change-Id: Ic2ecd12c3f78bc3a2d45a10b5305449e7de82b75
 2017-03-15 17:56:53 +00:00
Ed Sanders d85e8da9e2 Remove MSIE from blacklist, already blacklisted upstream 
We support all versions of IE that MW supports, so no need
for additional blacklisting.

Bug: T160494
Change-Id: I771459b4d6a0e2d5781a69a905a51323369b3b66
 2017-03-15 17:42:34 +00:00
L10n-bot 85a163e629 Merge "Localisation updates from https://translatewiki.net." 2017-03-14 21:55:57 +00:00
Translation updater bot 74f67c71a8 Localisation updates from https://translatewiki.net. 
Change-Id: Id47d1613684ff81148023a286264c5625f07fb51
 2017-03-14 22:55:51 +01:00
Bartosz Dziewoński 49f603c703 Update <pre> support for Parsoid changes 
After 79ccfb9372cb57afa569036ef39ead13abfba673, MediaWiki's `<pre>`
tags get rendered as `<pre typeof="mw:Extension/pre">` in Parsoid HTML.
MediaWiki's indent-pre syntax (block indented by a single space) is
still rendered as `<pre>` in Parsoid HTML, however.

Indent-pre is still handled by MWPreformattedNode (no changes).
Introducing MWPreNode, which will handle `<pre>` extension tags,
and MWPreDialog to change its contents (and allow converting
to MWPreformattedNode).

Pieces copied from MWGalleryNode, MWLinkNodeInspector, CommentInspector.

Possible future improvements:
* Add a specific icon for MWPreContextItem
* Avoid API roundtrips for rendering (but rendering wikitext <pre>
  is not as simple as it looks)
* Consider a way to insert these other than '<pre' sequence

Bug: T159900
Change-Id: I5bc4ea6e5d893736f65ef0dd43b08c18cb1a1e85
 2017-03-14 14:08:50 -07:00
James D. Forrester 6ab24fe9f0 Update VE core submodule to master (41134af2b) 
New changes:
1e12d0174 Generalize DiffElement logic (improves lists and tables)
24e0c7a94 Localisation updates from https://translatewiki.net.
32759ae86 Allow variable-length sequences without a fake space terminator, use for autolinking
82c204ba0 QUnit.assert.equalHash: Correctly compare JSON representation
2e5462610 DiffElement: Allow a node change to be an attribute change *and* a linear diff
41134af2b ve.ui.LinkAction: Allow autolinking ranges including trailing spaces again

Local changes:
Updated tests for 32759ae86: the autolinkUrl command no longer expects
trailing whitespace to be included in the range.

Bug: T117165
Bug: T149537
Bug: T158518
Change-Id: I5c2d5b97894fc93f49ce6270a198f3dfdcd09986
 2017-03-14 12:47:32 -07:00
jenkins-bot 399d03df5f Merge "Update gallery actions in response to changes" 2017-03-14 19:43:22 +00:00
Thalia 586cb06821 Update gallery actions in response to changes 
Bug: T62311
Change-Id: Icf51b92cb9a88471c5f11843473523787c177742
 2017-03-14 19:10:34 +00:00
jenkins-bot 797aac9d88 Merge "ArticleTarget#switchToVisualEditor: Bail if the server won't let you switch" 2017-03-14 16:19:06 +00:00
jenkins-bot 0867f469f6 Merge "DesktopArticleTarget: Discard edit summary when canceling an edit" 2017-03-14 16:10:25 +00:00
jenkins-bot 369ad5ca26 Merge "ve.ui.MWWikitextStringTransferHandler: Avoid API call for magic links" 2017-03-14 16:08:00 +00:00
David Lynch 4864189781 DesktopArticleTarget: Discard edit summary when canceling an edit 
Bug: T160130
Change-Id: I2a631b63c3f90bcd60a81312ee031f90dcbf6586
 2017-03-14 10:53:21 -05:00
Translation updater bot 9404888490 Localisation updates from https://translatewiki.net. 
Change-Id: Ibde46a54819705abb0b3e6e34d3465bd6d16eebd
 2017-03-13 23:02:37 +01:00
Bartosz Dziewoński b109c3405f ve.ui.MWWikitextStringTransferHandler: Avoid API call for magic links 
Updated tests to stop assuming that MWWikitextStringTransferHandler
always goes through an API request and Parsoid.

Bug: T117165
Change-Id: I24dffaaf3b4051b1b807ec29ac456d24da2f1fe9
 2017-03-13 19:54:19 +01:00
Translation updater bot 35ec87a601 Localisation updates from https://translatewiki.net. 
Change-Id: I5c8bc3f7edb775dc1c0a851540e75a386b79ab2f
 2017-03-12 23:00:40 +01:00
jenkins-bot b53e4a5d37 Merge "DesktopArticleTarget: Clear stored summary value after save completes" 2017-03-10 20:32:30 +00:00
Thalia c3650a9c07 Remove line breaks from gallery dialog captions 
A gallery tag is parsed line by line, so captions
(and other image data) should not contain line breaks

Bug: T153373
Change-Id: Ib1d1c18216d07c83b2d4358d2dda71c9d17e3e44
 2017-03-10 17:27:22 +00:00
David Lynch a9f54aacd4 DesktopArticleTarget: Clear stored summary value after save completes 
Bug: T160130
Change-Id: Id906da69c743f3a966d4182862cd173b26017059
 2017-03-10 10:19:12 -06:00
James D. Forrester d1f2bf1ecf ArticleTarget#switchToVisualEditor: Bail if the server won't let you switch 
Because otherwise you're just throwing all the user's input on the floor.

Bug: T158692
Change-Id: I5df00842697be11ecde9ea8ba2ab16b0dc90205e
 2017-03-09 17:09:16 -08:00
Translation updater bot 0d113dd032 Localisation updates from https://translatewiki.net. 
Change-Id: I57d7ebfb1bec4f31bda91eb12d0127fb5715f354
 2017-03-09 23:35:43 +01:00
David Lynch 05e2a3119e ArticleTarget: Improve edit summary behavior when switching 
Distinguish between the initial summary state, and a value stored from the
summary when switching modes. This lets us avoid overwriting a stored value
when section-editing, or assuming a stored value after a switch was never
edited.

Bug: T159686
Change-Id: Ie7640538140a14bbafd539b3a45928f5c55cf804
 2017-03-09 14:23:36 -06:00
jenkins-bot 71fe1a8cea Merge "ArticleTarget: use existing initialEditSummary if present" 2017-03-09 19:12:52 +00:00
David Lynch 261d4e8974 ArticleTarget: use existing initialEditSummary if present 
Switching modes recreates the toolbar, so if someone has already edited the
save summary it shouldn't update the initialEditSummary to that.

Bug: T159686
Change-Id: I4109442853916bebae2bce804fcd6777e3eb6d34
 2017-03-09 12:05:12 -06:00
David Lynch c5bb912e80 ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL 
The non-FullRestbaseURL branch didn't handle converting the provided wikitext,
causing data loss when switching from source to visual modes.

Bug: T158692
Change-Id: I283afc4be1e322228d6ec572bfa8542ba8fd9ce7
 2017-03-09 11:30:16 -06:00
jenkins-bot 832674fa85 Merge "Switching modes created an infinite loop onBeforeUnload" 2017-03-09 17:14:47 +00:00
jenkins-bot 10857b2d9f Merge "ve.ui.MWMagicLinkNodeContextItem: Do not display 'Clear styling' button in context" 2017-03-09 16:59:28 +00:00
Bartosz Dziewoński 7b618c55aa ve.ui.MWGalleryDialog: Fix 'Display mode' dropdown options' styling 
It's actually a bit surprising that the only thing broken by using
OptionWidget instead of MenuOptionWidget is some missing styles.

Change-Id: I3961fedbfc61f2f17d91dc7375d47a3cdff2a257
 2017-03-09 16:16:21 +01:00
David Lynch d6c71632ef Switching modes created an infinite loop onBeforeUnload 
Switching from visual to source reruns setupUnloadHandlers, which caused an
infinite loop where it thought it was its own fallback pre-existing handler.

Bug: T153346
Change-Id: I8df55a5395ede02fc34ec47a94f2c780dc08595f
 2017-03-08 11:32:03 -06:00
Translation updater bot b27fe68833 Localisation updates from https://translatewiki.net. 
Change-Id: I71344493334c65b08754134fe3bd3202fb72f04c
 2017-03-07 23:00:20 +01:00
jenkins-bot f9af257b7e Merge "ve.init.mw.DesktopTarget: Use mw-body-content instead of mw-body to match Vector changes" 2017-03-07 18:32:22 +00:00
Ed Sanders 387f9a5514 ve.init.mw.DesktopTarget: Use mw-body-content instead of mw-body to match Vector changes 
This ensures the styles are still applied to surfaces in dialogs.

Change-Id: I30e0cc7dc87dc8c8b6b3be84f821aa22baab457f
 2017-03-07 18:17:35 +00:00
jenkins-bot 9a90148d05 Merge "Add external classes to mw:ExtLinks in NWE preview" 2017-03-07 18:17:11 +00:00
Bartosz Dziewoński 48f227b263 ve.ui.MWMagicLinkNodeContextItem: Do not display 'Clear styling' button in context 
It doesn't work, you can't turn a MWMagicLinkNode into text by
clearing its styling. (You can still do that by clicking 'Edit',
'Convert to simple link', 'Clear styling'.)

`clearable = true` was being inherited from ve.ui.LinkContextItem.

Change-Id: Ib40e952554966fb74b3e72662a6e1e44ad748a57
 2017-03-07 16:34:18 +01:00
Translation updater bot 53cff258cf Localisation updates from https://translatewiki.net. 
Change-Id: Id6df97f02c3d04ff546d52afaa98efaa67d5906f
 2017-03-06 22:54:27 +01:00
jenkins-bot 81c9b5b032 Merge "Apex: Fix target margins" 2017-03-06 19:22:00 +00:00
Translation updater bot 9062ab75ab Localisation updates from https://translatewiki.net. 
Change-Id: Ia42483cea0eaf12517b602850dc2ae362c46b005
 2017-03-05 22:54:46 +01:00
Ed Sanders aa8f477dab Apex: Fix target margins 
Apex is basically abandonware, so we should consider deleting
this code.

Change-Id: Ie0c21fc21d4c37ab0344978bbd0d071415866397
 2017-03-05 18:07:04 +00:00
Translation updater bot a2ef681fd9 Localisation updates from https://translatewiki.net. 
Change-Id: I9a379fbf4bf30911eb8f7d796a4f8a94c1622c2b
 2017-03-04 23:06:24 +01:00
jenkins-bot 82355461fe Merge "Comment Parsoid hacks as such" 2017-03-03 22:58:25 +00:00
Ed Sanders 8802aa331b Add external classes to mw:ExtLinks in NWE preview 
Bug: T153413
Change-Id: I118d3b1794b99ed2d120dd5c5201c1fd18b6245b
 2017-03-03 22:46:21 +00:00
Ed Sanders 91822ddbd5 Comment Parsoid hacks as such 
Change-Id: I23fcc49031e3b34e5b83d7acea56845b325f3026
 2017-03-03 22:41:36 +00:00
Translation updater bot 8a76e9fe81 Localisation updates from https://translatewiki.net. 
Change-Id: I538b21eb94aacba63d2ff173e67c18146923ba04
 2017-03-03 22:50:06 +01:00
jenkins-bot 5aba0ee22b Merge "Improve NWE new section styles" 2017-03-03 18:06:04 +00:00
jenkins-bot 8d29d962c5 Merge "Cleanup DesktopTarget styles" 2017-03-03 17:54:43 +00:00
Ed Sanders 06fa5166c7 Improve NWE new section styles 
* Use <h2> for TextInputWidget to avoid duplicating skin styles
* Fix placeholder colour and font

Change-Id: I36c0b79ec9cbf3fa2ead0541ef5bac4a14a8781b
 2017-03-03 11:59:06 +00:00
Translation updater bot d53d15ec41 Localisation updates from https://translatewiki.net. 
Change-Id: I3865ee179a56f5eddf123afa31e98ee6d13c4ed8
 2017-03-02 23:26:47 +01:00
David Lynch 6cb6933e67 DesktopArticleTarget: Correctly bind section link handler 
Since December, the handler now expects to be passed the mode we're switching
to. Since we're filtering for just the edit link and not edit source, we can
hardcode 'visual' here.

Bug: T159374
Change-Id: I160045dd59ff1b4c2d180dbbe37280a1839886df
 2017-03-02 11:43:11 -06:00
jenkins-bot 59d52158a9 Merge "MWWikitextStringTransferHandler.test: Don't pass around an invalid doc" 2017-03-02 05:56:23 +00:00
jenkins-bot e55e6d7c99 Merge "MWWikitextSurfaceFragment#convertFromSource: Don't make an invalid doc" 2017-03-02 05:56:22 +00:00
jenkins-bot c537a8f0a2 Merge "ArticleTarget#getWikitextFragment: Optimise no-op" 2017-03-02 05:45:58 +00:00
James D. Forrester 9b4e27a91c MWWikitextStringTransferHandler.test: Don't pass around an invalid doc 
Even if it sounds cool, it isn't.

Change-Id: Ib6612bc0ea8d66fc1964b3a782ad56356da65952
 2017-03-02 05:43:10 +00:00
James D. Forrester 6fd475e8ec MWWikitextSurfaceFragment#convertFromSource: Don't make an invalid doc 
Though neat, this hack to get the internal list doesn't seem to be used
and creates an invalid document (just an internal list with no content,
so the internal list is at the start and the default selection position
is inside it). Instead, use the ve.dm.Document.static.newBlankDocument()
utility function that was made for this use case.

Bug: T153509
Change-Id: Iba5931cb5e3f939a803c1d59fa0d8f30a0513f84
 2017-03-02 05:43:03 +00:00
James D. Forrester e0814210e9 ArticleTarget#getWikitextFragment: Optimise no-op 
Change-Id: I6b54ae26e26c5ca697848d2534c128fc9c4bc4aa
 2017-03-01 19:17:26 -08:00
Bartosz Dziewoński 461f99e9da Document usages of ve.dm.Node.static.suggestedParentNodeTypes 
Ed told me this.

Change-Id: I5e3160d3e5c38f9babc133db8977a6e6b8bbd610
 2017-03-02 00:11:54 +01:00
Translation updater bot 603a5a6bd9 Localisation updates from https://translatewiki.net. 
Change-Id: I99dbcc74f0ff9a76c6463de302ea9fc90045f83e
 2017-03-01 22:47:27 +01:00
Ed Sanders 3c0ddc9c69 Cleanup DesktopTarget styles 
* Ensure DAT styles are fully scoped to DAT instances
* Ensure that generic desktop target rules are in the correct file
* Remove old unused rules

Change-Id: I466a0547ff9a0fa1102aac0b1e501a6ba6863ca3
 2017-03-01 12:38:51 +00:00
jenkins-bot ec897c120b Merge "Pass $overlay to FieldsetLayout and FieldLayout in various places" 2017-03-01 00:35:06 +00:00
Ed Sanders e163a09105 Use more specific event name for switching editor from the toolbar 
As we are in the global toolbar event namespace, 'switch' could
mean anything.

Change-Id: I66751faa249710af634ed0fd0c2f2a0bcd872db3
 2017-02-28 23:07:54 +00:00
Ed Sanders 109a136bd6 Use pencil icon for editor switcher dropdown 
Pencil is the icon we use for 'edit' elsewhere in the UI.
Use the eye icon for the VE tool to specify 'visual'.

Bug: T116417
Change-Id: I12b6bab2a52758685abde04579b274a32d651174
 2017-02-28 22:59:51 +00:00
jenkins-bot a61bbb18e3 Merge "Transclusion dialog: Add VE specific rules from OOjs UI" 2017-02-28 21:49:15 +00:00
Volker E 4e4d1da7a3 Transclusion dialog: Add VE specific rules from OOjs UI 
Adding VE specific rules from OOjs UI in preparation of removing them
from the library.

Change-Id: I798717b60badb521d28f8f7a7036a99e5a26d61a
 2017-02-28 12:24:22 -08:00
Ed Sanders b3989e4f07 Move switching methods to ArticleTarget and fix in mobile 
Change-Id: I7796dab5d2a24f9719870abf383925442b787612
 2017-02-28 11:47:35 -08:00
Ed Sanders b3cfca5401 MobileArticleTarget: Don't explicitly set menu indicator 
It is now inferred from toolbar position.

Change-Id: I9e3ac28aee74599b4b35ac2f870dca2556efb027
 2017-02-28 10:37:30 -08:00
jenkins-bot 2e2a5e452c Merge "Use list tool group for editor switching" 2017-02-28 18:33:44 +00:00
jenkins-bot 0070838981 Merge "Use ems for mobile surface font sizes, and add top/bottom spacing" 2017-02-28 18:30:23 +00:00
jenkins-bot 8a12dfd2ee Merge "Update tests to Selenium 3" 2017-02-28 16:04:27 +00:00
Ed Sanders 5ca02bae09 Use ems for mobile surface font sizes, and add top/bottom spacing 
Change-Id: Ida827b54a49c427f2fad2de1f634d8c4e4d28154
 2017-02-28 15:07:39 +00:00
Ed Sanders cb60db4c7f Use list tool group for editor switching 
Bug: T116417
Change-Id: Iadf5a81e2733ab81fe25c686dcd6dad8eac3885c
 2017-02-28 15:06:48 +00:00
Željko Filipin f776983204 Update tests to Selenium 3 
Bug: T158074
Change-Id: I784fc7bb85f32d5e50b5abb500c51493839ccebe
 2017-02-28 14:39:00 +01:00
Translation updater bot df7307c1b8 Localisation updates from https://translatewiki.net. 
Change-Id: Iaead1637d6460165edf1282450ba148e48d468a9
 2017-02-27 22:40:16 +01:00
Ed Sanders a3433e67fd Move modules loaded from DAT.init/TargetLoader to ResourceLoader 
This will make it easier for third parties to load the required
modules for an article-like target.

Also cleanup mobileArticleTarget to better match desktopArticleTarget.

Change-Id: Idb75e2bd99d8cf2c298e101cf92e8af4f85f5ad5
 2017-02-27 16:48:56 +00:00
Translation updater bot 4c9bc6ce53 Localisation updates from https://translatewiki.net. 
Change-Id: Ia9c63305453091afe7ebd5b5c5361dd2474ab11c
 2017-02-26 22:55:11 +01:00
Translation updater bot 49d2dade48 Localisation updates from https://translatewiki.net. 
Change-Id: Ie31ed3d14e14a362b890588db76946c2f6567755
 2017-02-25 22:44:27 +01:00
Translation updater bot 0f769f9a4c Localisation updates from https://translatewiki.net. 
Change-Id: Iea0b0881d660a604f83716425c1d2d38bb474dd1
 2017-02-24 22:49:39 +01:00
jenkins-bot a629b62b43 Merge "For the mode switch tool, show a different tooltip when disabled" 2017-02-24 19:23:53 +00:00
James D. Forrester 440a73206d For the mode switch tool, show a different tooltip when disabled 
Bug: T158723
Change-Id: I8c397e9b10c51d78c0b0f18c494ca9f36400d23e
 2017-02-24 08:49:47 -08:00
Translation updater bot a520037a38 Localisation updates from https://translatewiki.net. 
Change-Id: I7f5ea4a13665e807fe98c1f8d68d88536217d439
 2017-02-23 23:11:42 +01:00
L10n-bot ce86129067 Merge "Localisation updates from https://translatewiki.net." 2017-02-22 21:53:36 +00:00
Translation updater bot 18e340ef5f Localisation updates from https://translatewiki.net. 
Change-Id: I388c3a778615dc9d561e3ba15016fbed6bd825da
 2017-02-22 22:54:16 +01:00
Ed Sanders 501d0c94d2 Cache generated content request when inserting templates 
We request the generated content of a template to determine
if it will be block or inline. This is the same request as
the view makes later to show the rendering, so we should cache
this repsonse.

Bug: T156698
Change-Id: I0ffd36ccd0aa821aa44d99328f2e3a2abc23dc0f
 2017-02-22 04:00:38 +00:00
jenkins-bot 703e784d1a Merge "build: Bump grunt-jsonlint to latest and make pass" 2017-02-21 16:14:38 +00:00
Translation updater bot a3d001d7a5 Localisation updates from https://translatewiki.net. 
Change-Id: I716d04e411b2381f38381d80e9b70661007a3738
 2017-02-21 00:02:00 +01:00
Translation updater bot 50a0c7125a Localisation updates from https://translatewiki.net. 
Change-Id: Ie015f94ba4db43ac49f9a16e3fbe18ee715c27df
 2017-02-19 22:52:36 +01:00
Translation updater bot 63efc6c9af Localisation updates from https://translatewiki.net. 
Change-Id: Ibc99be0de6a97d39ccf7b13c40283410b8ac08a5
 2017-02-18 22:51:16 +01:00
James D. Forrester dddd2c0180 build: Bump grunt-jsonlint to latest and make pass 
grunt-jsonlint       1.0.8  →   1.1.0

Change-Id: I4a5cdd39f6215cc61a1ef530386a87fdcb0c0088
 2017-02-17 16:12:12 -08:00
James D. Forrester cc239a08da build: Bump stylelint and make pass 
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
 2017-02-17 15:23:12 -08:00
Translation updater bot 2dd0e06e87 Localisation updates from https://translatewiki.net. 
Change-Id: Ia236c6849f1c3194ebb59c666006f1edf03687cf
 2017-02-17 22:55:18 +01:00
Translation updater bot 8f5380cc12 Localisation updates from https://translatewiki.net. 
Change-Id: I46eaee06ac9f40e39685ebfccc76bd342439803e
 2017-02-16 23:09:58 +01:00
jenkins-bot 9164b6e400 Merge "DesktopArticleTarget.init: Don't hardcode single-tab accesskey" 2017-02-16 19:19:42 +00:00
jenkins-bot 97d689c824 Merge "MWSaveDialog: Switch to save panel when showing message" 2017-02-16 17:14:12 +00:00
jenkins-bot 6b6df0759e Merge "Tables: Add support for editing mw-collapsible/mw-collapsed" 2017-02-16 16:39:36 +00:00
David Lynch 288422cb9e MWSaveDialog: Switch to save panel when showing message 
Fixing T107251 made it so that clicking "save" always switched back to the
save panel momentarily, causing a flicker of "maybe I can edit this"
experience. With this change, we can only switch back to the save panel when
saving from other panels if a message is being shown.

Bug: T156891
Change-Id: I8f67693283e61c39cfce40ee12d5c6788dd97932
 2017-02-16 10:32:21 -06:00
Ed Sanders 9337e6ecbd Tables: Add support for editing mw-collapsible/mw-collapsed 
We don't support editing <div>s right now (as they're BranchNodes) nor
<span>s (as they're annotations), but most of those are inside templates
and so not editable in VE anyway.

Bug: T157989
Change-Id: I647b2a544fd16952696d0de8d07cb72189b27ecb
 2017-02-16 17:21:44 +01:00
Bartosz Dziewoński 22df25c108 Pass $overlay to FieldsetLayout and FieldLayout in various places 
We now use dialog's overlay in every case where we have a FieldsetLayout
or a FieldLayout with a help popup inside a dialog.

Bug: T100571
Change-Id: I8bd0ed430637feca63ec0f13cb7e1e1c659391a5
 2017-02-16 02:56:03 +01:00
Bartosz Dziewoński c3be577216 ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language variants 
Follow-up to 712ea472d3.

Change-Id: I2f3617fb4e9a80272e559b35c947052c0d8e534b
 2017-02-16 02:19:09 +01:00
Bartosz Dziewoński 2c78411113 ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM 
Bug: T158141
Change-Id: I999bcdc7095a3b9e2a86a7d5eca0e1f3ceb175ef
 2017-02-16 01:17:17 +01:00
Translation updater bot a21a89ac77 Localisation updates from https://translatewiki.net. 
Change-Id: I8a6a7bf01f41eed3d8d7c1cf5ccfb515c16586ce
 2017-02-15 22:47:52 +01:00
Translation updater bot 7d95edacde Localisation updates from https://translatewiki.net. 
Change-Id: I16205f62bba23e5d0d157d433a635feac710aba5
 2017-02-14 22:57:45 +01:00
David Lynch b1d68872b0 DesktopArticleTarget.init: Don't hardcode single-tab accesskey 
Bug: T156141
Change-Id: I1312283437714bf338a8ee3cf63e93ac67db1c45
 2017-02-14 11:24:50 -06:00
L10n-bot 6909c24d5d Merge "Localisation updates from https://translatewiki.net." 2017-02-13 22:19:02 +00:00
Translation updater bot ae92640bf3 Localisation updates from https://translatewiki.net. 
Change-Id: I79bc57730f31d46f3319d1108313d35547d7f2fc
 2017-02-13 23:19:33 +01:00
Bartosz Dziewoński 7beaf0ab9c ve.ce.MWTableNode: Provide preview of sortable table styling 
Algorithm for deciding which cells handle sorting is exactly
the same as in the real jQuery Tablesorter.

Depends on changes in VE core:
* I50426e173c68af7df49e47fe3bec0465a9a55c26
* Iabb372dfe7bf5feef314315ac74a788c6c58dc20

Bug: T139072
Change-Id: I4446be2ad459b05590754da9bb6c3dd8f796be42
 2017-02-13 21:36:43 +00:00
Ed Sanders 08b3f73f16 MWTableDialog: Extend initial values so 'done' button behaves correctly 
Depends-On: I608431365f2a482536affe1dae3fe21bc20e16b4
Change-Id: Idd468caa9417ffd8e0475083c884ef6c554ee152
 2017-02-13 08:30:51 -08:00
Ed Sanders 444ed0b7d8 MWTableDialog: Inherit actions from core 
Change-Id: Ice7f18ac2e1b7728a52a48482728d1b1278ca66f
 2017-02-13 08:30:51 -08:00
Translation updater bot 0b620cf417 Localisation updates from https://translatewiki.net. 
Change-Id: Id1187371077f15d98540f91be55ee2f074254ce5
 2017-02-12 22:44:26 +01:00
jenkins-bot 3c56d19e66 Merge "vw.ui.MWTableDialog: Add "Cancel" button" 2017-02-12 15:07:37 +00:00
Translation updater bot 30cb88940e Localisation updates from https://translatewiki.net. 
Change-Id: If95955b60c6c2b371bda27b1db2272939c3da982
 2017-02-10 22:55:28 +01:00
Bartosz Dziewoński aa22a8c482 vw.ui.MWTableDialog: Add "Cancel" button 
The dialog already supports cancelling by pressing Escape,
but the usual dedicated button was missing.

Change-Id: Ic63b5b59940a43474051466bdbbba0dbeb4342a9
 2017-02-10 15:26:33 +01:00
jenkins-bot a234120771 Merge "Check for 'veaction' when clicking section edit links" 2017-02-09 18:33:55 +00:00
Bartosz Dziewoński 5200f2ef34 ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter 
Or Cmd+Enter for Mac.

Depends on VisualEditor core changes:
* I93f50e325f993d82a821bf02f5e7f56fe1b9de62
* Id0a357b038fc5730f61bcf3ba730838dcda9b00e

Bug: T153241
Change-Id: I6b0a5e2c4e4ec72016463c8ba6576d33d59be8e5
 2017-02-09 16:47:41 +00:00
Translation updater bot c201ae6172 Localisation updates from https://translatewiki.net. 
Change-Id: Ia95042d9cd6c81e99c49848e0d17e33347bbc9c8
 2017-02-08 22:47:18 +01:00
Ed Sanders 6bd650d50a Check for 'veaction' when clicking section edit links 
Such as in the 'add topic' link.

Bug: T157104
Change-Id: Ide2d4cf8c23a5d0db24456d15b4312f7c0a5f922
 2017-02-08 17:48:04 +00:00
Translation updater bot 02aa33cfbd Localisation updates from https://translatewiki.net. 
Change-Id: I74eab9790e644bb90f354ae5d6a9f3cbb7ca2d6b
 2017-02-07 23:07:39 +01:00
jenkins-bot 6e585c457c Merge "Move wikitext signature command to correct file" 2017-02-07 20:47:57 +00:00
Ed Sanders 8ab21d2ef5 Move wikitext signature command to correct file 
So that signature availability is checked.

Bug: T157286
Change-Id: If1e585ce02e0bc9f5aa93129d315f83f183f5952
 2017-02-07 20:21:32 +00:00
Ed Sanders f2cf73eaaf Define default HTML types for extension nodes 
Use span/div for inline/block nodes respectively.

Bug: T157389
Change-Id: I4c501a6af88a490eec83af26adaa515a2b1d18d1
 2017-02-07 20:12:39 +00:00
David Lynch 8a7d44224c ArticleTarget: try to refresh editToken if getWikitextFragment fails 
Refactor saveFail's badtoken handling out so it can be reused by
getWikitextFragment.

Bug: T156991
Change-Id: I686cddb5be4484211fa69640044db1bc34eacefc
 2017-02-07 11:20:59 -06:00
jenkins-bot 158807f86c Merge "Remove explicit toolbar indicator definitions" 2017-02-06 17:11:59 +00:00
Translation updater bot 19569f4b02 Localisation updates from https://translatewiki.net. 
Change-Id: If656029a98191aad2523fe743ac42b1a26920190
 2017-02-05 22:57:31 +01:00
Ed Sanders 7a058a4de8 Remove explicit toolbar indicator definitions 
These are now computed upstream based on position of toolbar.

The menu tool now needs its indicator explicitly hidden.

Change-Id: Id2280f70553e1e45f3a42af45684c5808797925c
 2017-02-04 10:25:37 +00:00
Translation updater bot bb029d2ebc Localisation updates from https://translatewiki.net. 
Change-Id: Ibe93c0e21b2c4adb1796c0d07f9f0843e834be4e
 2017-02-03 23:06:06 +01:00
jenkins-bot 61d449c9d2 Merge "ve.ui.MWSaveDialog: Prettify the 'messages' shown" 2017-02-01 23:50:58 +00:00
jenkins-bot 5015af4a32 Merge "ve.init.mw.ArticleTarget: Don't try to clear non-existent message" 2017-02-01 23:48:30 +00:00
jenkins-bot fbe31de0d3 Merge "ve.ui.MWSaveDialog: Remove unused $saveActions div" 2017-02-01 23:48:10 +00:00
Translation updater bot 8390b1f3fb Localisation updates from https://translatewiki.net. 
Change-Id: I1d46d45a3dda6243a24cddbdb0dd679f8628fee9
 2017-01-31 22:58:54 +01:00
Bartosz Dziewoński e8d99c5536 ve.ui.MWSaveDialog: Prettify the 'messages' shown 
This is currently used to display a warning about missing edit summary
and to display a CAPTCHA field. They now appear in a separated area at
the bottom of the dialog, which slides into view when a message is
added.

Change-Id: I7541284a92d5fd2fa8f469d479e059098c59c0ac
 2017-01-31 17:37:00 +00:00
Bartosz Dziewoński 6f367ea0ec ve.init.mw.ArticleTarget: Don't try to clear non-existent message 
This is just dead code. We never call `.showMessage( 'captcha', ... )`
(the CAPTCHA is shown in the 'api-save-error' message).

Change-Id: I48f51e89d5b366384d184e2ed505be9e7b8f3401
 2017-01-31 14:40:32 +01:00
Bartosz Dziewoński a0cb3029cb ve.ui.MWSaveDialog: Remove unused $saveActions div 
Change-Id: I47da48b29d3bddd598946de655cf1e8b086daf45
 2017-01-31 13:43:47 +01:00
Translation updater bot 2e690797c0 Localisation updates from https://translatewiki.net. 
Change-Id: Idc95868d10a1fd04899fcbec7a280b55743a874d
 2017-01-30 22:52:00 +01:00
jenkins-bot 7b46d105b1 Merge "Advanced Settings: improve displaytitle field" 2017-01-30 19:40:13 +00:00
David Lynch 00fb8c8e58 Advanced Settings: improve displaytitle field 
* Remove the checkbox; an empty field, or a value exactly equal to the page
  title means no displaytitle.
* Automatically fill the field with the current page title
* The field was mispositioned

Bug: T155818
Bug: T156665
Change-Id: I46db6b14616c9a021e757284972537cac00546a1
 2017-01-30 19:29:25 +00:00
WMDE-Fisch a0af0b0529 Disable VisualEditor in the TwoColConflict extension 
As for the Translate extension this will read a global set by the
TwoColConflict extension to disable the VisualEditor and its hooks
on the modified edit conflict page there.

Bug: T156251
Change-Id: I164d1546c9d98d8715650e13c63a01d06c76315d
 2017-01-30 14:06:59 +01:00
Ed Sanders 1d7f929a91 Update VE core submodule to master (139bdf7) 
New changes:
d79138b Overwrite selected content when pasting via DataTransferItem
3c4737f Ensure clipboard is never empty text
3b1339e Create dummy platform and target for tests
4d63c8e Pass text as string to insertDocument when detected as plain text

Local change:
Remove VE standalone module

Flow used to use it, but not anymore. Going forward no one should
be using it in MW.

Bug: T154020
Bug: T156302
Bug: T156498
Depends-On: I078c244ef524669da477a43f9b37c847252e5ad7
Change-Id: Ifc4be16269f819890f2dcdddbbdebf9694ad2868
 2017-01-29 18:50:47 +00:00
Translation updater bot 662789bb13 Localisation updates from https://translatewiki.net. 
Change-Id: Ib90e3f4f0482f1642fe8dde53dd0f601d3e942cc
 2017-01-28 22:56:32 +01:00
Translation updater bot 0383c3c61b Localisation updates from https://translatewiki.net. 
Change-Id: I19e481d7151511014ac3fabd241cdf01932a937e
 2017-01-27 15:00:35 +01:00
jenkins-bot 19c0dd3aa4 Merge "MWSaveDialog: only focus summary if we're on the save panel" 2017-01-27 07:25:31 +00:00
David Lynch 60866eade2 Override ui.CommentInspector so that copying from it sets text/x-wiki 
Bug: T154837
Change-Id: I3413c955aa23d34683e1a028a581b1ea34d55d49
 2017-01-27 01:13:41 -06:00
David Lynch b976f2cf38 MWSaveDialog: only focus summary if we're on the save panel 
Firefox throws exceptions when trying to focus hidden inputs. Using the
"preview" keyboard shortcut entirely bypasses the save panel, but the ready
process assumes it'll always be opened first.

Bug: T153958
Change-Id: Ifb3861116565e77c30b3874fe47889298c3ace6d
 2017-01-27 00:51:33 -06:00
jenkins-bot fb48db7227 Merge "Ignore section edit links when no action present" 2017-01-26 14:13:24 +00:00
Ed Sanders 1df022a6d6 Ignore section edit links when no action present 
BUg: T156282
Change-Id: If3d039da36db946dcbba123d3cdc4e99c45f6a4e
 2017-01-25 18:13:56 +00:00
Translation updater bot dc7ce167b3 Localisation updates from https://translatewiki.net. 
Change-Id: Ie1b9552f69f104a50f0b317d1c6db4d046526ffc
 2017-01-25 14:49:37 +01:00
jenkins-bot fb1d1cdfaf Merge "Use target=_blank for link in template 'extra description'" 2017-01-25 12:53:03 +00:00
jenkins-bot 7d9d6b35d2 Merge "Update actions on live inspectors and preview dialogs" 2017-01-23 23:33:44 +00:00
Translation updater bot 23bce58071 Localisation updates from https://translatewiki.net. 
Change-Id: Ib31aa19ef33f7b5017bf3ed49684cae670fd50c7
 2017-01-23 22:50:30 +01:00
Ed Sanders 133da969ce Use target=_blank for link in template 'extra description' 
We already do this for 'missing description'.

Bug: T155879
Change-Id: Iccf48070ab2b5890d6891856be4ee5cce5308d0d
 2017-01-23 13:07:53 +00:00
Translation updater bot 07f877d476 Localisation updates from https://translatewiki.net. 
Change-Id: I6a51ed82a750a1fd6c3bb5697bb9b69067b2e96d
 2017-01-22 22:45:16 +01:00
Translation updater bot e821a8e24b Localisation updates from https://translatewiki.net. 
Change-Id: Ib7a453738fc26748d5b202c7598db1009d72b145
 2017-01-21 22:46:51 +01:00
Thalia 43c2865f90 Update actions on live inspectors and preview dialogs 
Make inspectors inheriting from MWLiveExtensionInspector
and dialogs inheriting from MWExtensionPreviewDialog
update their 'done' action every time updatePreview is
called. Since both mix in ExtensionWindow, two new methods,
updateActions and isModified are added there.

This should make it more difficult to insert an empty node
accidentally or create a transaction just by opening and
closing an inspector or dialog.

For more complicated dialogs, or inspectors or dialogs
that don't live-update, this behaviour will have to be
implemented separately.

Bug: T155330
Change-Id: Iacafa01fcd419faaec9b112c96be86693a57d561
 2017-01-21 18:29:18 +00:00
Ed Sanders 171286c120 Fix typo in target config 
Change-Id: I5815ce5b0e05ce166e02bfcced520e3770f5453d
 2017-01-20 23:15:23 +00:00
Ed Sanders f58d00b110 Move #getWikitextFragment up to ArticleTarget 
Change-Id: Ice4b04db4a45c07ccffc3892e6db5d814c2ec37b
 2017-01-20 23:15:17 +00:00
Ed Sanders e5555d6d85 Remove MWMobileSurface & Context 
The hacks contained within context were ancient and no
longer used, and thanks to a typo in mw.MobileArticleTarget
neither of these classes was being used anyway.

Change-Id: I52f2b6d5aa5ddbcc45ac6107eaf9407570b73672
 2017-01-20 23:15:11 +00:00
Ed Sanders 1ae5c13cb9 Update VE core submodule to master (f0dcedb) 
New changes:
5b448fa [BREAKING CHANGE] Merge Mobile/DesktopSurface into Surface
2d8959b Localisation updates from https://translatewiki.net.
7eee772 Follow-up 2d8959b: Fix build for added language 'io'
f0dcedb ve.dm.TableMatrix: Really indent ASCII-art comments

Change-Id: I62708f7caeb03b16cd318aab0b0ee3c674e75a26
 2017-01-20 14:35:39 -08:00
Translation updater bot 015017376e Localisation updates from https://translatewiki.net. 
Change-Id: Id8ab05872453edaf2c54c841dcc6abf7b7e68f32
 2017-01-20 09:46:04 +01:00
Translation updater bot c549b370fa Localisation updates from https://translatewiki.net. 
Change-Id: I1e6889a7d649cc1fcceab4ee748c8eafece4b40b
 2017-01-18 22:20:13 +01:00
Translation updater bot b0944d5ad3 Localisation updates from https://translatewiki.net. 
Change-Id: I08914c4a309c016d8ceff90da41328d3c3b12110
 2017-01-17 22:17:40 +01:00
jenkins-bot 1e32b1d31d Merge "Re-order all meta code to put categories first" 2017-01-17 02:39:55 +00:00
jenkins-bot faaf7d2b4f Merge "Fix correct default page for meta dialog in NWE" 2017-01-17 02:38:44 +00:00
Ed Sanders 96a3d38cf9 Re-order all meta code to put categories first 
For consistency.

Change-Id: Ia5e9728ca4f727f4ce30d5f0c88ac9df8c4d21d0
 2017-01-17 00:19:38 +00:00
Ed Sanders 1aeec314d5 Fix correct default page for meta dialog in NWE 
Bug: T154639
Change-Id: I49d0f2295b071ae667e111562e30d04b0174c251
 2017-01-17 00:17:51 +00:00
jenkins-bot 9c3f3646c8 Merge "Correct comment in MWBlockImageNode" 2017-01-16 20:24:45 +00:00
Translation updater bot 6a449d29ba Localisation updates from https://translatewiki.net. 
Change-Id: I12814771ed6d7d2005c5c09543e30f1e635a3289
 2017-01-16 14:32:09 +01:00
Thalia 8c4b8e55e5 Correct comment in MWBlockImageNode 
Change-Id: I99058f97ac74b57c648be51cdb267d24a197b16a
 2017-01-14 18:38:20 -08:00
Ed Sanders 337614d142 Open preview links in new tab 
Bug: T155159
Change-Id: Idddc6b25303c17382ba1bc763b9001b727e1040e
 2017-01-12 16:07:00 -08:00
jenkins-bot a4543a7336 Merge "Allow AceEditorWidget to accept autocomplete word list" 2017-01-12 02:00:14 +00:00
Thalia fc61fb9be0 Allow AceEditorWidget to accept autocomplete word list 
Bug: T155107
Change-Id: I2dd752fb55a4d5596dbc8b8dc69eb55083d7ec66
 2017-01-11 17:26:16 -08:00
L10n-bot 220b2ef042 Merge "Localisation updates from https://translatewiki.net." 2017-01-11 22:27:03 +00:00
Translation updater bot 1f90679b43 Localisation updates from https://translatewiki.net. 
Change-Id: I92917d08fd03456856c1983ab1bd07cd8d46943a
 2017-01-11 23:21:18 +01:00
jenkins-bot 7c49a23a33 Merge "ArticleTarget: Give users a specific message when HookAborted errors happen" 2017-01-11 22:21:13 +00:00
jenkins-bot 18ba046361 Merge "ArticleTarget#saveErrorUnknown: Handle the xhr being complete" 2017-01-11 20:37:08 +00:00
James D. Forrester 002b0adef0 ArticleTarget: Give users a specific message when HookAborted errors happen 
Change-Id: I7017412dc56200f5bb0adbd901aed15507447846
 2017-01-11 10:46:30 -08:00
James D. Forrester 2b502572ec ArticleTarget#saveErrorUnknown: Handle the xhr being complete 
Change-Id: I638b5b80c5a404a438ebd357b6e16bbab7871d6e
 2017-01-11 10:45:43 -08:00
jenkins-bot 0405f8c80a Merge "DesktopArticleTarget: Prevent infinite while loop if $content is empty" 2017-01-11 18:39:35 +00:00
Ed Sanders 889ffc0efc DesktopArticleTarget: Prevent infinite while loop if $content is empty 
Change-Id: I629b2c3f1a4af3441764db7d1d0a7cec96181396
 2017-01-11 18:29:16 +00:00
Translation updater bot 3c943c5817 Localisation updates from https://translatewiki.net. 
Change-Id: Ib66f2dc2241016540afa2df19cc4ac36523ae98b
 2017-01-09 15:56:06 +01:00
jenkins-bot 70a66d4070 Merge "More error handling fixes" 2017-01-09 02:24:17 +00:00
jenkins-bot 09829ae7b4 Merge "MWMetaDialog: Move categories to the top as they're used most" 2017-01-07 14:56:56 +00:00
Translation updater bot 9d29ec3d9c Localisation updates from https://translatewiki.net. 
Change-Id: I37e2fb1213d1db27e24219fba349638f75fc122f
 2017-01-06 23:14:55 +01:00
Translation updater bot a0bda5eb51 Localisation updates from https://translatewiki.net. 
Change-Id: Ied8c757544363b36e27cfccb4df80a0c22d78ce2
 2017-01-05 23:50:18 +01:00
Alex Monk 8fe5bbe39b More error handling fixes 
See T154565

Change-Id: I073aae149497342157503ad3f465b7d57aaad4fa
 2017-01-05 15:13:02 +00:00
jenkins-bot 50e7fd0653 Merge "Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts" 2017-01-05 15:08:33 +00:00
jenkins-bot 4d64196fcb Merge "Fix loadFail parameter handling" 2017-01-04 22:46:27 +00:00
jenkins-bot e91f8f913e Merge "Allow 'T-' prefixed sections, and redirect if section link title isn't current page" 2017-01-04 22:38:34 +00:00
Alex Monk 1bcaa9056c Fix loadFail parameter handling 
Rename them while we're at it.

Bug: T151278
Bug: T152429
Change-Id: I435ac148007db87da69e8cf48568fafa646abb71
 2017-01-04 22:31:08 +00:00
Translation updater bot f2947ed40d Localisation updates from https://translatewiki.net. 
Change-Id: I842b0b968551a988d1a848d8b08aa4ace0c10466
 2017-01-04 22:39:54 +01:00
James D. Forrester 6795430831 MWMetaDialog: Move categories to the top as they're used most 
Bug: T74399
Change-Id: I696d8484ed00c92340f178d5c9dcfe978998dce0
 2017-01-04 11:18:00 -08:00
Ed Sanders 808de2acea Add "templates used" page to meta dialog 
Bug: T149009
Depends-On: Id617f9afbddf094140133f9659efc4b4e746148c
Change-Id: I63e663d05aefb47274f1f28bdcafc5317c2fc4f6
 2017-01-04 18:30:11 +01:00
Ed Sanders b7dd6077b8 Allow 'T-' prefixed sections, and redirect if section link title isn't current page 
Bug: T153176
Change-Id: Ic6fda78d00715777df4a273e7d3e150f20185185
 2017-01-04 16:53:03 +00:00
jenkins-bot cbd88e10ed Merge "Use the monospace hack consistently" 2017-01-03 20:41:03 +00:00
jenkins-bot d816492ca1 Merge "rm stray fileRepoPromise property from media dialog" 2017-01-03 20:24:34 +00:00
jenkins-bot 1ac5ede187 Merge "Don't try to JSON stringify load error messages that are already strings" 2017-01-03 20:22:50 +00:00
jenkins-bot 4abdf21413 Merge "Also allow opening in source mode if VE is unavailable on action=edit" 2017-01-03 20:19:09 +00:00
jenkins-bot 2b913fb10c Merge "Add editintro to notices" 2017-01-03 20:19:06 +00:00
jenkins-bot a973528d67 Merge "Don't block VE/NWE from loading if 'editintro' is specified" 2017-01-03 20:13:29 +00:00
Alex Monk 17ced451f4 MWSaveDialogAction: Don't break on strange accesskey messages 
Quietly return instead.

Bug: T153472
Change-Id: I7c325624734f122c9fd939aee1192187c63d9247
 2017-01-03 11:37:09 -08:00
jenkins-bot f182d5d223 Merge "When switching check wikitext is a non string, not just empty" 2017-01-03 18:57:48 +00:00
jenkins-bot 78a38ae6ea Merge "Register shortcuts for minoredit/watchlist" 2017-01-03 18:54:26 +00:00
jenkins-bot 945d3d4cbc Merge "After saving a specific section, scroll to it" 2017-01-03 18:49:19 +00:00
jenkins-bot 9cc4736708 Merge "ve.ui.MWParameterPage: Restructure constructor to reduce needless work" 2017-01-03 18:44:56 +00:00
jenkins-bot ec6509e86b Merge "ve.ui.MWParameterPage: Hide the "Fall back to plain wikitext" button when in wikitext" 2017-01-03 18:44:54 +00:00
Alex Monk 5c2773539e After saving a specific section, scroll to it 
Bug: T153297
Change-Id: I233e5226abc44d5d0bf8e56957a133d595e7be6f
 2017-01-03 18:38:55 +00:00
jenkins-bot 6599aaf3f4 Merge "Give focus to preview panel for keyboard scrolling" 2017-01-03 17:58:32 +00:00
jenkins-bot f439843964 Merge "Factor out preferred editor check" 2017-01-03 17:50:42 +00:00
jenkins-bot f89a6a3880 Merge "build: Bump file copyright notices for 2017" 2017-01-03 17:11:04 +00:00
jenkins-bot 24d26f5e19 Merge "Move translate extension hack up to 'isAvailable'" 2017-01-03 17:04:11 +00:00
jenkins-bot 7c790f8d12 Merge "Use preferred number casting method" 2017-01-03 17:04:10 +00:00
jenkins-bot 7a81159941 Merge "Fix NWE-only edit tab" 2017-01-03 17:04:09 +00:00
jenkins-bot 80e0edd275 Merge "Allow switching between 'edit source' and 'add topic'" 2017-01-03 17:04:08 +00:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017 
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
 2017-01-03 08:58:33 -08:00
Ed Sanders 4628e9e68c When switching check wikitext is a non string, not just empty 
Also add documentation.

Bug: T154437
Change-Id: Icacc0ad522d3e7fa28ecea9876c2c0465c4eb8e6
 2017-01-02 18:40:07 +00:00
Translation updater bot daa5085917 Localisation updates from https://translatewiki.net. 
Change-Id: I1dbde448e5f2d60675d35d070969b3890ea2aa49
 2017-01-01 10:17:23 +01:00
Ed Sanders 58071f59f1 Add editintro to notices 
Bug: T56029
Bug: T51622
Change-Id: Ib43cc66b817ff394b4f1c82fcba4503df825819c
 2016-12-31 23:23:17 +00:00
Ed Sanders c853475a1a Give focus to preview panel for keyboard scrolling 
Bug: T154334
Change-Id: Ibc093e3111411b6183bf24528a2e0419ba8d40b6
 2016-12-31 22:04:19 +00:00
Ed Sanders fe85ee1ba6 Don't block VE/NWE from loading if 'editintro' is specified 
Later we should actually show the edit intro, but that is a
separate issue (T56029).

Bug: T153481
Change-Id: I97622a3d86b975866305aaa745bac51f6b55f217
 2016-12-31 15:22:11 +00:00
Ed Sanders 9eebfbcac5 Fix NWE-only edit tab 
Change-Id: I5d08e30f43fbe08eb8809692728a8ab37f3a1491
 2016-12-30 16:42:54 +00:00
Ed Sanders 3f47aec20b Use preferred number casting method 
Change-Id: I77215f2bdb6eb055375e5b803d23b6f26df2d8d1
 2016-12-29 20:33:15 +00:00
Alex Monk 4af862e6d3 Also allow opening in source mode if VE is unavailable on action=edit 
Bug: T153508
Change-Id: I5678d3b417c93707edc90bbb76ce4dafcd2098c6
 2016-12-29 20:32:58 +00:00
Ed Sanders c963b73e71 Factor out preferred editor check 
Change-Id: Ic2e2e2e1d24dba8854315dff068ea9ce5d409c5a
 2016-12-29 20:17:55 +00:00
Ed Sanders 7de023caee Allow switching between 'edit source' and 'add topic' 
Also between section editing and full page editing
by clicking on 'edit source'.

Change-Id: I9165a7ad4ac2a588a09532c7181ba72b6fd2f811
 2016-12-29 15:48:38 +00:00
Translation updater bot 2217913182 Localisation updates from https://translatewiki.net. 
Change-Id: If99a57be3026afdfd71533ff227649069c092674
 2016-12-29 10:25:31 +01:00
jenkins-bot 927856aff3 Merge "Use mw.Message#parseDom where appropriate" 2016-12-28 21:40:18 +00:00
Ed Sanders c625398b78 Use the monospace hack consistently 
Change-Id: I6b223e5f0760902c1f34fa5a284703055c763234
 2016-12-28 13:36:14 +00:00
Translation updater bot 786f354ec5 Localisation updates from https://translatewiki.net. 
Change-Id: I6a6785f8b9a0f0448a0f0e0af11dcebf2ab9ec3b
 2016-12-28 10:57:13 +01:00
Bartosz Dziewoński a811168c2a ve.ui.MWParameterPage: Restructure constructor to reduce needless work 
We were constructing a lot of widgets, and never using them all
(they were forever hidden or not even appended to DOM). For large
transclusions this was causing a noticeable performance hit.

I don't think this quite resolves T134814, but it should improve the
situation.

* this.rawFallbackButton is now constructed and appended only when needed.
* this.removeButton is now constructed and appended only when needed.
* this.infoButton can now be a PopupButtonWidget or a disabled ButtonWidget.

Bug: T134814
Change-Id: I2ea00a88a1ea22b73b0c6d10334a94f45734ec3b
 2016-12-27 23:54:49 +00:00
Bartosz Dziewoński e0c97ab2f0 ve.ui.MWParameterPage: Hide the "Fall back to plain wikitext" button when in wikitext 
We were trying to hide it by detaching, which did not work because it
was getting attached again in later code. Clicking the button just did
nothing.

Change-Id: I027550eb723c43dc85453959159b93e6e802e099
 2016-12-27 23:54:42 +00:00
Bartosz Dziewoński 90ff82a035 Use mw.Message#parseDom where appropriate 
Avoid turning DOM into HTML markup and parsing it back into DOM.

Change-Id: I34f56ee60b836a7e0556130a153fc95adb4f3467
 2016-12-27 23:54:12 +00:00
Ed Sanders 827d4185c4 Move translate extension hack up to 'isAvailable' 
All modes of VE should be disabled on these pages.

Bug: T153445
Change-Id: I5adfae940ee35c5ee6712e620a0ddda967a542ad
 2016-12-27 13:56:10 +00:00
Translation updater bot f5b1a5bb18 Localisation updates from https://translatewiki.net. 
Change-Id: I1c8e16e199bbef502b296802acbb3cc15ee417be
 2016-12-26 22:42:30 +01:00
Translation updater bot 2ea87fcaf3 Localisation updates from https://translatewiki.net. 
Change-Id: Ia3b0f68931e0894aa10d2992f90dc8703f8712cb
 2016-12-25 22:20:41 +01:00
Translation updater bot d87a54a31b Localisation updates from https://translatewiki.net. 
Change-Id: I21a43826c79cf6d234fb003f3f20c254758380fd
 2016-12-24 22:41:04 +01:00
Alex Monk 4c061de2e0 Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts 
ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref(
	'http://mediawiki.krenair.dev/mediawiki_dev/wiki/Main_Page?veaction=editsource',
	ve.init.target.surface.model.documentModel.htmlDocument
)

Wrong, current result:
Object {
	title: "Main Page?veaction=editsource",
	rawTitle: "Main_Page?veaction=editsource",
	hrefPrefix: "",
	isInternal: true
}

New result:
Object {
	title: "http://mediawiki.krenair.dev/mediawiki dev/wiki/Main Page?veaction=editsource",
	rawTitle: "http://mediawiki.krenair.dev/mediawiki_dev/wiki/Main_Page?veaction=editsource",
	hrefPrefix: "",
	isInternal: false
}

Change-Id: I3d6d7fcfeb0d8354623026c831605c7633c3e11a
 2016-12-24 20:12:44 +01:00
Alex Monk d7cf29f1c0 rm stray fileRepoPromise property from media dialog 
seems to have gone upstream to core's mw.widgets.APIResultsQueue

Change-Id: I3c2a6dbdca60ceadc9e7175e5f8ad83b7fc4b7a0
 2016-12-24 18:59:48 +01:00
Translation updater bot 55a9cf5208 Localisation updates from https://translatewiki.net. 
Change-Id: I39a587eeb157951e8f848cda002f9a46b77d162a
 2016-12-23 22:34:34 +01:00
Ed Sanders 7611ee5a2c Register shortcuts for minoredit/watchlist 
Bug: T153925
Change-Id: I3f569a75a66e816d0a5c4ad966344100510a4f2b
 2016-12-23 13:36:48 +00:00
Translation updater bot 2dc86af85a Localisation updates from https://translatewiki.net. 
Change-Id: Ic57783cd0222ba31b3c343881a4a4732ad7d0404
 2016-12-22 23:00:45 +01:00
jenkins-bot d5f66e4fe9 Merge "Preserve checkbox data when switching from VE to NWE" 2016-12-22 12:37:37 +00:00
jenkins-bot 50da8d8ab9 Merge "Add comments in some places where we really want to treat messages as HTML" 2016-12-22 00:32:23 +00:00
Ed Sanders aee5e665f1 Preserve checkbox data when switching from VE to NWE 
Bug: T153889
Change-Id: Ifc41ea9320c9f2627efff6f33d4ad87c59fad496
 2016-12-21 22:35:52 +00:00
Alex Monk 101b0ff45c Don't try to JSON stringify load error messages that are already strings 
Change-Id: Ib180c3ac7eb62d351e05153defd6330c3397c478
 2016-12-21 04:00:05 +01:00
jenkins-bot 8497b06287 Merge "ve.init.MWWelcomeDialog: Don't treat text messages as HTML" 2016-12-21 02:49:09 +00:00
jenkins-bot d1b243e660 Merge "Ensure document base is always correct, even in source mode" 2016-12-20 18:51:23 +00:00
jenkins-bot 477f892423 Merge "Change wikitext link inspector name to avoid conflict" 2016-12-20 13:44:36 +00:00
jenkins-bot ced46300cb Merge "MWTemplatePage: Show a link to the template even when there's a description" 2016-12-20 11:04:24 +00:00
Bartosz Dziewoński 72569159b8 Add comments in some places where we really want to treat messages as HTML 
Change-Id: I439338dabd4b031ed1c4cfc9d89af5a6f2971676
 2016-12-20 10:50:15 +00:00
Bartosz Dziewoński dc3bae7d36 ve.init.MWWelcomeDialog: Don't treat text messages as HTML 
This appears to be unintentional. The messages don't have any markup.

Change-Id: I6f6570c5ef90e4a06ead1a23f6f851021a77c234
 2016-12-20 10:50:10 +00:00
Translation updater bot f6ba11dec9 Localisation updates from https://translatewiki.net. 
Change-Id: I7601c2c303782796f9ca3090f0798b9e354baffa
 2016-12-19 22:50:11 +01:00
Ed Sanders 46385a557e Ensure document base is always correct, even in source mode 
Bug: T153624
Change-Id: I3f74f67ce975f5b371ab42adf5213256ae816f7f
 2016-12-19 21:08:58 +00:00
Ed Sanders 323050467f Change wikitext link inspector name to avoid conflict 
This was causing the VE link inspector to fail badly if
NWE was enabled.

Bug: T153668
Change-Id: Ie665715a5f5401e59fc6468b81a4122ca5ebd5a3
 2016-12-19 12:03:58 +00:00
James D. Forrester d576fac49f MWTemplatePage: Show a link to the template even when there's a description 
Bug: T51772
Change-Id: Ia7084dc7dd4e4c092c0d24b123da19721dca54a9
 2016-12-18 21:56:12 +00:00
Translation updater bot 4a1cd55503 Localisation updates from https://translatewiki.net. 
Change-Id: I19262ad5964b36fc84551c68ede397705980d44a
 2016-12-18 22:18:37 +01:00
Translation updater bot 56ba9a9839 Localisation updates from https://translatewiki.net. 
Change-Id: I8f757626dd2ed47aa772ee5c19e4bec5fe72a8c5
 2016-12-17 22:25:49 +01:00
Translation updater bot 7a8b171d01 Localisation updates from https://translatewiki.net. 
Change-Id: I04e37ca08cc134ce68b667deda2fd101d62f6eb6
 2016-12-16 22:18:10 +01:00
jenkins-bot 2f790bb7a8 Merge "Show HTTP status alongside 'Unknown error' when it's not 200" 2016-12-16 18:51:57 +00:00
jenkins-bot 57d49550a0 Merge "Add shortcut for show preview and resolve access key conflicts" 2016-12-16 18:14:17 +00:00
Ed Sanders 4d134cfefc Add shortcut for show preview and resolve access key conflicts 
Refactor save dialog setup so logic for canPreview/canReview
is external and passed in.

'Show preview' will show in the VE command help dialog until
I56c1036e6 is merged in core.

Bug: T149914
Change-Id: Id718ad622be43c03df61d12b8688d53462c59f36
 2016-12-16 13:33:57 +00:00
Alex Monk a9feb8869c Show HTTP status alongside 'Unknown error' when it's not 200 
Change-Id: If14dc14f2cc43a1f12c1314342d5028ec524c31e
 2016-12-16 11:28:38 +00:00
Alex Monk 96b8d35bff Wrap localStorage.getItem calls in try { ... } catch () {} 
Bug: T153291
Change-Id: Ic4f8c390bfe6936bd182b28b1f2c6d19bf459eba
 2016-12-15 23:08:30 +00:00
Translation updater bot c8995a6a88 Localisation updates from https://translatewiki.net. 
Change-Id: Ifc8297cbb54b183ee024b085006f0f7e69fb473a
 2016-12-15 23:20:22 +01:00
jenkins-bot ee2cb3048d Merge "DesktopArticleTarget: Generate the original page title if needed" 2016-12-15 16:50:47 +00:00
jenkins-bot 552e21b74b Merge "Properly clear this.section when switching from VE" 2016-12-15 04:18:37 +00:00
Ed Sanders 9728d78126 Resolve URLs in show preview against correct base 
Bug: T153277
Change-Id: Icaa6de4618de008fb2024d1dd428114688cb1043
 2016-12-15 03:19:16 +00:00
Ed Sanders 17a164363b Properly clear this.section when switching from VE 
Bug: T153276
Change-Id: Idc251c73c03bf87b6e6ca716be98b38d4fb68c5e
 2016-12-15 01:34:30 +00:00
Ed Sanders c92418e4da Fix wikitext handling of DataTransferHandlers when IVStore is used 
Bug: T153269
Change-Id: Ida6ffffac6e6a65784dc84a388d3702680a79db9
 2016-12-14 22:56:18 +00:00
Ed Sanders 1b726dc9bc Fix DataTransferHandlers when loading source editor directly (no etag) 
Bug: T153268
Change-Id: I0b43fd651e26c3d74a5f29e8ed80e5dee28ac399
 2016-12-14 22:56:00 +00:00
jenkins-bot 9c448dd827 Merge "Use deep clone for empty convertFromSource" 2016-12-14 22:27:19 +00:00
Ed Sanders 854256bb8e Use deep clone for empty convertFromSource 
Bug: T153254
Change-Id: I0dc6be0d20020e3fb385c9d065f9395dbda5a6b6
 2016-12-14 22:09:25 +00:00
jenkins-bot 5042fe3360 Merge "Extra section title for edit summary in source mode" 2016-12-14 21:51:02 +00:00
Translation updater bot 01d75a2e86 Localisation updates from https://translatewiki.net. 
Change-Id: Ifdb762bec4c05e58c37ad9fc28b39ceee00d535d
 2016-12-14 22:27:17 +01:00
Ed Sanders 61c7cc4a95 Extra section title for edit summary in source mode 
Bug: T153245
Change-Id: I3b3465f269831152fd7a820027f44bfaada067a8
 2016-12-14 21:22:10 +00:00
James D. Forrester ccbf20496b i18n: Point to a better page for NWE feedback 
Change-Id: I43db0b4dcab051aa17f4ad033628aad770738c60
 2016-12-14 19:38:58 +00:00
Ed Sanders 856d480f7d Follow-up Ic1f1de26: Fix typo in edit tab selector 
Change-Id: I0ac685f1d942a7d40c6926b8ae8d751db04e1474
 2016-12-14 17:35:09 +00:00
jenkins-bot 593474912f Merge "Fix logic for create accesskey=v, and bind to onEditTabClick" 2016-12-14 01:30:17 +00:00
David Lynch b1aed096cb DesktopArticleTarget: Generate the original page title if needed 
When switching from the old wikitext editor to VE, we stored "editing..." as
the original page title. Then restored that when saving / switching to "read".
Instead, detect if we're on top of the classic editor, and use the pagename
message to make a plausibly-correct title.

Bug: T126077
Change-Id: Ib0289de71c3ae947ca0a3e45fe1e620378689c35
 2016-12-13 19:28:15 -06:00
Translation updater bot 176329e9d8 Localisation updates from https://translatewiki.net. 
Change-Id: Ie7ab044b53ba3a2f3a40dd89b50da13c4eba1a13
 2016-12-13 22:46:43 +01:00
jenkins-bot 56927ad512 Merge "SaveDialog: Align colour palette and ensure sufficient contrast" 2016-12-13 19:38:51 +00:00
Volker E 48db1c16f8 SaveDialog: Align colour palette and ensure sufficient contrast 
Align the colors used in the save dialog to OOjs UI's MediaWiki theme,
increasing the contrast of edit summary counter slightly to ensure WCAG
AA accessiblity levels. Also remove unnecessary duplicated CSS
properties, which are already inherited from OOjs UI styles.

Bug: T153086
Change-Id: Iee6b38e0b11f777dd0ffb0f6802d0b3d7349ddee
 2016-12-13 19:26:39 +00:00
Ed Sanders 22f4614eee Show save button on show preview page 
Bug: T151261
Change-Id: If80bb8e4e9e412572ab88d13d07a3f92dd353b31
 2016-12-13 18:10:09 +00:00
jenkins-bot dc897662bf Merge "Resize save dialog after showing captcha" 2016-12-13 17:19:20 +00:00
jenkins-bot 16c5d489fc Merge "Don't restore scroll position when doing real section editing (NWE)" 2016-12-13 16:33:16 +00:00
Ed Sanders db447733b0 Fix logic for create accesskey=v, and bind to onEditTabClick 
Change-Id: I69020652f2946626c443ef5b724cf92e7905f247
 2016-12-13 16:06:57 +00:00
Ed Sanders d2ea716902 Don't restore scroll position when doing real section editing (NWE) 
Bug: T152946
Change-Id: I969a8edd4f23bbe6c73855aac059df732102c560
 2016-12-13 15:44:54 +00:00
Ed Sanders 69c0fb189a Fix action=editsource URL rewriting 
Always look for links unless the only tab is VE.

Bug: T153054
Change-Id: Ic1f1de26fb77098fe62f6263a25c8a40de0e09a7
 2016-12-13 15:36:34 +00:00
Ed Sanders 1f3bb5c9e5 Add section= param to URL after loading target 
This wasn't such a big deal in VE because we load the full
page anyway, but in NWE it is more annoying if you reload the
page and are dumped in a different edit area.

Change-Id: If49569cbe1a2759d8cbbd7ee42dd1b88da39a946
 2016-12-13 15:31:57 +00:00
jenkins-bot c4dacd9d24 Merge "Don't focus save dialog during setup to avoid scroll jumping" 2016-12-13 15:31:23 +00:00
Ed Sanders 56c34fbf79 Follow-up I6eda4a7c: Fix typos in #updateTabs 
Change-Id: Ib80dec3fb199ea03609d5d0f242ac606052f24cc
 2016-12-13 15:19:05 +00:00
jenkins-bot a962e7de3b Merge "Support section=new in NWE" 2016-12-13 13:55:33 +00:00
Ed Sanders 4064c91b8e Don't focus save dialog during setup to avoid scroll jumping 
Bug: T153010
Change-Id: Ia535cd5d4ebfc01994f4e440bb5cb7efa5c40802
 2016-12-13 12:57:34 +00:00
Ed Sanders 5a8106773c Support section=new in NWE 
Bug: T150709
Change-Id: I1002b97060d642df0988da15860a36c13712bade
 2016-12-13 12:20:55 +00:00
Ed Sanders 37190c3e8d Resize save dialog after showing captcha 
Change-Id: I219a1eae442bd580760235f22eee15a836d5ebae
 2016-12-13 12:05:42 +00:00
L10n-bot 34fbe31e93 Merge "Localisation updates from https://translatewiki.net." 2016-12-12 21:54:27 +00:00
Translation updater bot ae76bac942 Localisation updates from https://translatewiki.net. 
Change-Id: I469815663e16164751f4c202228ff48249993f63
 2016-12-12 22:44:06 +01:00
jenkins-bot 669995c8c2 Merge "Follow-up ae8a2750: Stop passing long-dead second parameter" 2016-12-12 21:20:08 +00:00
Ed Sanders a504aba7c5 MWWikitextLinkAnnotationInspector: Select links after creation 
Change-Id: If23d90dc695546e7dddb3c04637e54df47c6f528
 2016-12-12 20:09:52 +00:00
Ed Sanders 2d645d1631 Use Surface#setDisabled instead of deprecated #disable 
Change-Id: Idf998ddc0b95efbf6befbcfa493c42b4c3ba1bfc
 2016-12-10 20:03:07 +00:00
Ed Sanders d555b5ba33 Cleanup handling of 'section' param 
Provide a common function to parsing, and always pass
section to the target, instead of having the target
re-compute it itself.

Change-Id: If9fc24ffa51507cd969fa1b4dfc1519a0b50a572
 2016-12-08 20:24:19 +00:00
jenkins-bot 397eb403cc Merge "Simplify #updateTabs" 2016-12-08 19:59:29 +00:00
Ed Sanders cd87e7483b Expand dummy surface to be at least valid 
Change-Id: I3888dd2f72858bbe79c61fa4a6f7967f21c5cb7c
 2016-12-08 19:36:57 +00:00
Ed Sanders 66e4a5cbe8 Simplify #updateTabs 
Change-Id: I6eda4a7c27f0b7590aae5505b0459ced07d2cc48
 2016-12-08 19:22:11 +00:00
jenkins-bot bdfff4a3b1 Merge "DesktopArticleTarget: clear out originalCategories when they're updated" 2016-12-07 16:46:06 +00:00
David Lynch d720041fd7 DesktopArticleTarget: clear out originalCategories when they're updated 
Bug: T152571
Change-Id: I41b5d5aeea0a01cf922924fa1320369d54fef8cf
 2016-12-07 09:48:26 -06:00
Alex Monk c843824c97 Batch gallery imageinfo requests via ImageInfoCache subclass 
Also get rid of .join( '|' ) for API request parameters per Bartosz

Bug: T147067
Change-Id: If4444cca300d65e28d6fb9003fcac5e076a5129a
 2016-12-06 22:10:19 +00:00
jenkins-bot a04cef294e Merge "Update for API error i18n" 2016-12-06 20:04:24 +00:00
jenkins-bot 446a4e40c4 Merge "SaveDialog inherits from plain dialog, not FragmentDialog" 2016-12-06 19:37:41 +00:00
jenkins-bot 9382e0630a Merge "DesktopArticleTarget: Rebuild the category links when they're edited" 2016-12-06 18:31:43 +00:00
jenkins-bot bdd1a1b78c Merge "Scroll highlighted item into view in gallery dialog" 2016-12-06 18:30:22 +00:00
jenkins-bot 9b4bc7a3f2 Merge "Disable heights option in gallery dialog when mode is slideshow" 2016-12-06 18:28:51 +00:00
jenkins-bot a2e4d9fa82 Merge "Decrease height of gallery search results for better fit" 2016-12-06 18:23:38 +00:00
David Lynch af8aad0483 DesktopArticleTarget: Rebuild the category links when they're edited 
This has to go to the API, because it's skinnable. Also, separates out a few
of the initial page setup functions so they can be re-applied to the new
content inserted.

Bug: T151651
Change-Id: I8d5a6504edc2e0486a0b4f016d8ee6d9a6228de9
 2016-12-06 11:28:08 -06:00
Translation updater bot 2ab755aca9 Localisation updates from https://translatewiki.net. 
Change-Id: Iab69a8d0ae63daccd64d3c40545e87897b6e6661
 2016-12-05 22:52:43 +01:00
Translation updater bot 19f580a9af Localisation updates from https://translatewiki.net. 
Change-Id: I9c43a7a5a9449bf555985696cf57340a4931e11a
 2016-12-04 22:41:24 +01:00
Ed Sanders aa7dba9bdb Follow-up Ifaf6a2607: Display correct message when switching 
Use new mode, not old mode for choosing switch message.

Change-Id: I1ad0913b4a23fd6fbf5cdeb07d1a58ec72398d57
 2016-12-04 15:51:57 +00:00
Ed Sanders 4f7bba4de9 SaveDialog inherits from plain dialog, not FragmentDialog 
Change-Id: I934ab41567ea68e58cfa27451faf499febd68bd1
 2016-12-04 11:09:56 +00:00
Ed Sanders f01d617c53 Bypass API call when wikitext is empty string 
Change-Id: Ie0cedfaae286f73e73bcde7bfca3cb2ae6197924
 2016-12-03 17:44:04 +00:00
Ed Sanders c97e0b58d4 NWE: Disable progress bar when pre-parsing for WindowAction's 
The progress bar dialogs interfere with the life cycle
of the window you are trying to open. Just disable these
progress bars for now to avoid catastrophic behaviour.

Change-Id: I77c8ae67a2d502bbd189836deb320cd55c3cb11a
 2016-12-03 17:20:24 +00:00
Thalia 2fd30fb7c5 Decrease height of gallery search results for better fit 
Bug: T151509
Change-Id: I92c812952457df99251fc0b8f1a17d4e55fe52f7
 2016-12-03 16:31:23 +00:00
Thalia 1b4d70324b Disable heights option in gallery dialog when mode is slideshow 
Also disable relevant fields the first time the dialog is
opened, not just when the dropdown is changed.

Bug: T151482
Bug: T151512
Change-Id: Ic511e1832a9fcaaeaed71c1d495aecc65fdd1d3b
 2016-12-03 16:00:32 +00:00
Thalia 0b9228a926 Scroll highlighted item into view in gallery dialog 
Bug: T152053
Change-Id: I6b77f6c27d5629dc18e421f984cf31badfb2ff04
 2016-12-03 15:46:58 +00:00
jenkins-bot e1e55aa730 Merge "Correct class/classes typo in gallery dialog" 2016-12-03 15:20:53 +00:00
Thalia 295dd380de Correct class/classes typo in gallery dialog 
Bug: T152226
Change-Id: I569df87cf82359c13ad61a3ddffacd83f5f03bae
 2016-12-03 13:03:02 +00:00
Ed Sanders 9ceb13ce60 Update VE core submodule to master (5be61ce) 
New changes:
860954b [BREAKING CHANGE] Parse selection before applying source tools

Local changes:
Implement convertFromSource/convertToSource in WikitextSurfaceFragment

Depends-On: Iaa41c49e2f8e28af28a8a64cb6915f705fa35e8c
Change-Id: I746619d442fb565cd582cb09de3126526c73c333
 2016-12-03 03:43:59 +00:00
James D. Forrester f494067dea Follow-up ae8a2750: Stop passing long-dead second parameter 
Change-Id: Ifc43d9009c2057b5a189d3cc161b62dc4ca83a2c
 2016-12-02 14:31:26 -08:00
L10n-bot 95af1ba8c1 Merge "Localisation updates from https://translatewiki.net." 2016-12-02 21:24:28 +00:00
Translation updater bot a131668e46 Localisation updates from https://translatewiki.net. 
Change-Id: Ie5e6281811ea14485f919a9efcea2f24b009838b
 2016-12-02 22:21:13 +01:00
Ed Sanders 9b5adb8688 Remove WikitextWindowAction, inherits from core 
Depends-On: I2b14cc93bf3c855e157f0b26567337f74992fb96
Change-Id: I3e479c1441f548f62ff8a2f6e7b2ad450262921f
 2016-12-02 11:50:43 -08:00
jenkins-bot 3064890a91 Merge "Clear preview when document is modified" 2016-12-02 02:45:29 +00:00
jenkins-bot 36d976c4c0 Merge "Save Dialog: add shortcut for opening to the review panel" 2016-12-02 00:36:40 +00:00
David Lynch 2bd34cebd4 Save Dialog: add shortcut for opening to the review panel 
Create a new MWSaveDialogAction, which can be hooked up to triggers. Switch
the existing save dialog accesskey to just use the trigger system.
(Maintaining all the accesskey logic, so we don't change the shortcut on
people.)

Bug: T149914
Change-Id: I9b4ef8504148703556f802b266a517dd5098c06b
 2016-12-01 18:16:18 -06:00
Ed Sanders 915bbec307 Clear preview when document is modified 
Use same logic for 'Show preview' as for 'Show changes'

Change-Id: I69510b426548fca46dc9b0d113b77ad206502b21
 2016-12-01 23:59:07 +00:00
jenkins-bot 4e05b86cf3 Merge "Use widget.getApi, not this.getApi" 2016-12-01 23:43:16 +00:00
jenkins-bot e3c0a05b84 Merge "Prevent endless error loop if falling back to wikitext (after a load failure) fails." 2016-12-01 23:17:42 +00:00
Alex Monk 5bd95db994 Use widget.getApi, not this.getApi 
Bug: T152154
Change-Id: Id7e77323ffabf4eeee3e73481cf6bcb9a1e649dc
 2016-12-01 22:48:45 +00:00
jenkins-bot d254436f57 Merge "Use canonical ve.dm.TransactionBuilder.static.newFrom* methods" 2016-12-01 19:44:05 +00:00
jenkins-bot 2b453295ec Merge "ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links" 2016-12-01 19:35:45 +00:00
Ed Sanders 8bca6cc777 Inherit more functionality from core source mode 
Change-Id: Id027681ab5f0c9f4b9ed127b583e45f0fe57ce69
Depends-On: I02f3849027a6652701c2d354d1b77ece9d1a56c1
 2016-12-01 18:44:54 +00:00
James D. Forrester a835f4f9d5 Use canonical ve.dm.TransactionBuilder.static.newFrom* methods 
Change-Id: I082048a677baa2699d94e21548373952d52db61b
 2016-12-01 10:43:10 -08:00
Ed Sanders 218742d806 Update VE core submodule to master (ae30d71) 
New changes:
f58ddea DiffElement: Use document slices with full internal lists
83800c0 DebugBar: Remove hard-coded i18n
b4f89e1 Update OOjs UI to v0.18.1
40c7bf6 Factor out active node functionality from SectionNode for captions
2d967be Move 'mode' property to surface, rename target property to 'defaultMode'
5d8c214 wrapAllNodes in sourcefragment
dd3d9e5 Refactor ve.dm.Transaction
9d61aca Use canonical ve.dm.TransactionBuilder.static.newFrom* methods
df4f72a Make table caption node an active node
b79f72d Core source mode
7533ac4 Localisation updates from https://translatewiki.net.
ae30d71 SourceSurfaceFragment: Check range is not collapsed

Local changes:
Get edit mode from surface where possible

Depends-On: Iec758c1892d518ad4bc2c0d1aaf6ca00fa354323
Change-Id: Ifaf6a26078b2731b374aaad2cb40c08928de9c84
 2016-12-01 10:40:01 -08:00
jenkins-bot 551b6db912 Merge "Fix "Add new image" button in the gallery dialog" 2016-12-01 00:25:49 +00:00
jenkins-bot be4c0df032 Merge "i18n: Kill last two uses of 'parameter' in lieu of 'field'" 2016-12-01 00:19:30 +00:00
Thalia 4b9d1bed4f Fix "Add new image" button in the gallery dialog 
Make sure the button is always visible in the
gallery dialog menu by fixing it to the bottom.

Bug: T151506
Change-Id: I560b0dffbaad9e18c6f7f703cb155356470580ee
 2016-11-30 22:38:11 +00:00
jenkins-bot b6a468d0ff Merge "Clearer English for visualeditor-preference-newwikitexteditor-description" 2016-11-30 22:30:13 +00:00
Amire80 d561894db6 Clearer English for visualeditor-preference-newwikitexteditor-description 
Change-Id: I698822637a212e4462c563cdf43e9b192459671b
 2016-11-30 23:59:08 +02:00
Translation updater bot 2edf528f0f Localisation updates from https://translatewiki.net. 
Change-Id: Ia83483409e59132a73cfce630a9f3ad6c00fb2a4
 2016-11-30 22:22:29 +01:00
Ed Sanders 37910b78ec MWTemplateTitleInputWidget: Use new #getApi method from upstream 
Depends-On: I81811cdd1a0750a8335432eee8f971ab9e0b8ee7
Change-Id: Ic73213df5ede6f82de85df8b69c60dd31f033792
 2016-11-30 19:51:45 +00:00
Bartosz Dziewoński 491ecfe1d6 ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links 
Bug: T151646
Change-Id: I693b190f762d93ffae0aa939ffc9550e567e8e24
 2016-11-30 19:07:50 +01:00
Translation updater bot fd3e5f8398 Localisation updates from https://translatewiki.net. 
Change-Id: Ib42d0dd37389381817efaefda3780bef0867db16
 2016-11-29 22:25:32 +01:00
jenkins-bot 745e919f97 Merge "Update VE core submodule to master (9625e8f)" 2016-11-29 20:46:54 +00:00
James D. Forrester 32c966db97 i18n: Kill last two uses of 'parameter' in lieu of 'field' 
Change-Id: I94fa70b17a210391b0444aca22c577b2e5e549e3
 2016-11-29 12:08:35 -08:00
jenkins-bot 33db54ef28 Merge "Use upstream media search widget from core" 2016-11-29 20:04:46 +00:00
Ed Sanders aeafa6afca Update VE core submodule to master (9625e8f) 
New changes:
f1297b8 [BREAKING CHANGE] Allow target widgets to be re-used

Local changes:
Re-use target widgets

Change-Id: I5decb918f398704d4b6c108a16fbc1cc073ef077
 2016-11-29 11:48:15 -08:00
jenkins-bot 28a4b9f362 Merge "Handle missing pipes in Gallery syntax, and remove them when caption is empty" 2016-11-29 19:27:52 +00:00
Ed Sanders 44fee9b61d Wait until search panel is shown before setting a search query 
Bug: T151659
Change-Id: I3eb3b903a8df1c7732da2a08e4b46b13b162617e
 2016-11-29 11:13:54 -08:00
Ed Sanders 2ee9e62a4d Use upstream media search widget from core 
Bug: T140166
Depends-On: If53ef7f4b62c7a5d4da565c14dd2a353778694e5
Change-Id: I28845e9c143e78d3a377f067606c62da212e3bf1
 2016-11-29 17:19:14 +00:00
James D. Forrester ba232c9f75 2017 Wikitext Editor: Tweak Beta Feature i18n to be less expansive 
Change-Id: Id9afdf27707f246a6c2f0fd69b92d239df88924b
 2016-11-28 16:55:14 -08:00
Translation updater bot 986abb0d0f Localisation updates from https://translatewiki.net. 
Change-Id: I54d71688837784c502dcb6d1615312986694a093
 2016-11-28 22:33:50 +01:00
Ed Sanders 240ec23113 Handle missing pipes in Gallery syntax, and remove them when caption is empty 
Bug: T146190
Change-Id: I703bcdf68b9631a47d839baf3abb42ff98b36bf2
 2016-11-28 17:36:29 +00:00
Translation updater bot f2c444c1bd Localisation updates from https://translatewiki.net. 
Change-Id: Ife8e7e01743c51b22ffacd8ac234434652bf3b10
 2016-11-27 22:34:20 +01:00
jenkins-bot 6bcfed97a5 Merge "Separate out ArticleTarget as a module" 2016-11-26 23:22:32 +00:00
Translation updater bot 6e0ce959d6 Localisation updates from https://translatewiki.net. 
Change-Id: I1ae8c3ead28026b79997175563d0a57175d39900
 2016-11-25 22:55:55 +01:00
Translation updater bot 3991a12bfe Localisation updates from https://translatewiki.net. 
Change-Id: Ica8875aafaf70d8ea6ae94a7eff98edf66de4108
 2016-11-24 22:23:28 +01:00
Ed Sanders 4fe6be1f34 Separate out ArticleTarget as a module 
Also move save button command help registration to ArticleTarget.

Bug: T151096
Change-Id: I941d17254a2e20a82aa46fd538abf887d757c0c3
 2016-11-24 12:35:41 +00:00
jenkins-bot 1909c445bb Merge "Allow the gallery dialog to insert duplicate images initially" 2016-11-24 04:13:03 +00:00
Ed Sanders 0334263718 Missing i18n in gallery dialog 
Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
 2016-11-24 00:09:49 +00:00
Translation updater bot 10d348af8b Localisation updates from https://translatewiki.net. 
Change-Id: Ie8f35a953ffb6e24acd7aa555b2cad555ee6e9f6
 2016-11-23 22:41:42 +01:00
jenkins-bot fde5c3c2ff Merge "Follow-up I63ab27cb: Get rid of notices tool when there are no notices" 2016-11-23 01:17:42 +00:00
Thalia 003ec7b653 Allow the gallery dialog to insert duplicate images initially 
Change I94f4fadd84cd3e prevents the gallery dialog from inserting
duplicate images into the gallery dialog after one request (e.g.
so double-clicking on an image in the search widget doesn't cause
the image to be inserted twice). However, galleries can
intentionally contain duplicates of the same image, so it is
possible to make a spearate request to insert a duplicate image.

When the dialog is first opened, it requests all the images in
the gallery at once, so the above change was causing the
duplicates in an existing gallery to be dropped. Duplicates
should be allowed to be inserted following this initial request.

Bug: T150894
Change-Id: I34353bc9b8db947488474c4be52292e0a1447705
 2016-11-23 01:02:35 +00:00
jenkins-bot 508b4164bd Merge "Let gallery dialog handle unprefixed filenames" 2016-11-23 00:33:39 +00:00
Alex Monk b89a6ee463 Follow-up I63ab27cb: Get rid of notices tool when there are no notices 
Bug: T151423
Change-Id: I3dd9d2cbfb1fa536490eb8b4b7d630e9c6cfdd48
 2016-11-23 00:30:06 +00:00
Thalia 2364f530a3 Let gallery dialog handle unprefixed filenames 
The namespace prefix before image filenames is optional
in galleries, but the API requires it. If the prefix is
omitted, add the file namespace prefix.

Change-Id: I3d126550c2ad2e84454122f92307ba4bc943780b
 2016-11-23 00:20:32 +00:00
jenkins-bot 3d8a749cf2 Merge "init: Initialise 'active' property in mw.Target instead of subclass" 2016-11-22 23:35:10 +00:00
jenkins-bot 8370b98e3f Merge "Move around code that sets up edit notices to ensure it runs after we receive the notices to display" 2016-11-22 23:27:26 +00:00
Alex Monk 16e294fba7 Move around code that sets up edit notices to ensure it runs after we receive the notices to display 
Bug: T151236
Change-Id: I63ab27cb236169f300295b2ed4c88e01048092e7
 2016-11-22 19:16:09 +00:00
Timo Tijhof cde3d2a7f8 init: Initialise 'active' property in mw.Target instead of subclass 
This is set to 'true' in mw.Target#setupSurface(), but not initialised or
used there in that class.

It was previous initialised in an indirect subclass (DesktopArticleTarget).
Move this to the parent class instead for clarity.

Change-Id: Ie3e12d254aa4b689fdce64620e110164311bc60a
 2016-11-21 18:06:52 -08:00
Ed Sanders 7f2d5b5bee Don't re-bind edit tab in DAT when using SET 
In SET the tab's events are already bound in DAT.init.

Bug: T151258
Change-Id: I04529dbdea2d2ff5e52b0f11035a4ac11946617b
 2016-11-21 22:09:26 +00:00
Translation updater bot 0757c5e242 Localisation updates from https://translatewiki.net. 
Change-Id: I70248fdc2480098dd966d59db36306e2e923cb77
 2016-11-21 22:42:09 +01:00
Ed Sanders 6e64fba2f8 Unbreak education popup 
Tools only setup once now, and that is during the dummy surface
phase, so we have to setup the education popups then.

Change-Id: Idf46fe42c893c0692dc442226297253074ef9bd7
 2016-11-21 15:19:58 +00:00
Translation updater bot 01cefc47db Localisation updates from https://translatewiki.net. 
Change-Id: I21e87c04625b6c87ac50ebcf8c014e6d2e29ed92
 2016-11-20 22:21:47 +01:00
jenkins-bot 8fd396151c Merge "Migrate DesktopWikitextArticleTarget code upstream" 2016-11-20 03:06:55 +00:00
Ed Sanders e1a887ccf8 Migrate DesktopWikitextArticleTarget code upstream 
Change-Id: Icca4715411737a561302b44b127d91d117e7e29b
 2016-11-20 02:52:14 +00:00
Translation updater bot 0b257c12db Localisation updates from https://translatewiki.net. 
Change-Id: Ie9a1877be552d5492c483cc7cb2468eba901212f
 2016-11-19 22:08:59 +01:00
Translation updater bot f64099f7cb Localisation updates from https://translatewiki.net. 
Change-Id: I314c1b19bc52e114055039301bf97ee7b4e0c36e
 2016-11-18 22:17:43 +01:00
Translation updater bot dc0b0ea97a Localisation updates from https://translatewiki.net. 
Change-Id: Idf5ec60855a5539b916f7a14aa44aea1e145600a
 2016-11-17 22:56:27 +01:00
jenkins-bot c790944eb0 Merge "Setup htmlBlacklist and add rule for read-mode MW references" 2016-11-17 17:30:45 +00:00
Translation updater bot 59b4c5910c Localisation updates from https://translatewiki.net. 
Change-Id: I856a87673d7e11bc10d2e240d506a816729e2bad
 2016-11-16 22:54:25 +01:00
Alex Monk 86719eb90f Prevent endless error loop if falling back to wikitext (after a load failure) fails. 
Change-Id: Id48fa13a33aee9fabf857d20a75d26463c329f44
 2016-11-16 18:52:26 +00:00
jenkins-bot 51adc1b37f Merge "Fix handling of failure to load visual mode" 2016-11-16 18:48:16 +00:00
jenkins-bot 3483055c29 Merge "Remove max-width from save summary" 2016-11-16 17:55:35 +00:00
James D. Forrester f24e34de3c build: Bump eslint-config-wikimedia to v0.3.0 and make pass 
Change-Id: I7449c11aa63c50fda667265c32021439cc53471f
 2016-11-15 15:05:05 -08:00
jenkins-bot 65604802ac Merge "Fix attribute.style typo in gallery dialog" 2016-11-15 22:09:57 +00:00
Translation updater bot dccb137e0e Localisation updates from https://translatewiki.net. 
Change-Id: Ia94028500a1e833f991162fb716b1bb7cbd9c6ef
 2016-11-15 23:02:26 +01:00
Ed Sanders 134477a840 Setup htmlBlacklist and add rule for read-mode MW references 
Logically depends on If1b20fefe4b.

Bug: T150418
Change-Id: I0e2249b64f3b452c0322e7a20515ee7b2b6c6f60
 2016-11-15 17:20:17 +00:00
jenkins-bot 019aee30d4 Merge "Always set mode when activating the target" 2016-11-15 16:07:50 +00:00
jenkins-bot 961f59d8ce Merge "Normalise filename after image is chosen in gallery dialog" 2016-11-15 12:55:21 +00:00
Ed Sanders ff4761bbd9 Fix handling of failure to load visual mode 
Reject the activating deferred making handleLoadFailure
redundant.

Fix logic for switching back to OWE aware of NWE.

Change-Id: I328fc944bb6b9152752742fe35c56b95e3255b88
 2016-11-15 12:44:38 +00:00
Ed Sanders b4ff55a38c Always set mode when activating the target 
Otherwise if the target was already loaded the mode will
not be changed, which can cause the wrong editor to load
in multi edit tab mode.

Change-Id: I64071dfdfc8511cce51bda20b9c62d7fc126c528
 2016-11-15 12:44:38 +00:00
Ed Sanders 521c3c8436 Pass isModified when switching from VE to NWE 
Bug: T150707
Change-Id: I9ae525aa7a5883bb45f91262db8abc082983ee1b
 2016-11-14 23:05:21 +00:00
Thalia 97af378bb5 Fix attribute.style typo in gallery dialog 
Change-Id: I71162652df5e09c4d974e0f863ea661c4bd7902e
 2016-11-14 22:26:39 +00:00
Thalia 810202395e Normalise filename after image is chosen in gallery dialog 
Bug: T150638
Change-Id: Iead7d0d3f8aa6c864dc6fba7089bab0767035812
 2016-11-14 22:04:25 +00:00
Translation updater bot cd681d4bf4 Localisation updates from https://translatewiki.net. 
Change-Id: I26e9cc640152465d37f834bf9c83d30497c6e2b4
 2016-11-14 23:02:39 +01:00
Brad Jorsch 26e24c2d09 Update for API error i18n 
See Iae0e2ce3. Since VisualEditor master requires core master, this just
depends on the master patch instead of trying to maintain BC.

Depends-On: Iae0e2ce3bd42dd4776a9779664086119ac188412
Change-Id: I0e802a47302725f062334a437bff84e3b2b8b9a6
 2016-11-14 12:47:01 -05:00
jenkins-bot 0c1eff31ef Merge "Teardown the toolbar properly" 2016-11-14 17:26:54 +00:00
Translation updater bot 82b8afafc7 Localisation updates from https://translatewiki.net. 
Change-Id: I4471a9107521394ae38e4b0fdd06cac730c7656b
 2016-11-13 22:57:35 +01:00
jenkins-bot 6215f9a1bb Merge "eslint: Re-enable wrap-iife and partially enable dot-notation" 2016-11-12 23:43:32 +00:00
Translation updater bot 3dfe9de109 Localisation updates from https://translatewiki.net. 
Change-Id: I1c9a170ee3c6e466731c4725a7ee81b064f2f9a1
 2016-11-12 22:59:42 +01:00
Ed Sanders 37ccaca2ec eslint: Re-enable wrap-iife and partially enable dot-notation 
Change-Id: I4420d66f528dcb18ebe2b9f63996661b2969f833
 2016-11-12 14:43:43 +00:00
Ed Sanders f2e0b408b4 Teardown the toolbar properly 
Depends-On: I53a86bf5e0322dc9766ae4ddf31ff0ae5568df7e
Change-Id: If9cc876a57272679584ebc653cf2ee8e17ddb821
 2016-11-12 14:28:11 +00:00
jenkins-bot cf3c972a3a Merge "Move NWE URL changes into JS" 2016-11-12 00:02:50 +00:00
L10n-bot 62fc7e1b9b Merge "Localisation updates from https://translatewiki.net." 2016-11-11 22:03:58 +00:00
Translation updater bot 71b1c8af06 Localisation updates from https://translatewiki.net. 
Change-Id: I55094810442134b6e688fe972c06ce42dfb15cb8
 2016-11-11 23:01:14 +01:00
Ed Sanders b1b6f9836e Remove redundant narrow-threshold calculation 
This is done upstream in OOUI.

Change-Id: Icc0e535f9d1113a14d2c1cc275efebbc98e3a38c
 2016-11-11 18:54:30 +00:00
Alex Monk 807cb6b54e Move NWE URL changes into JS 
Bug: T148077
Change-Id: Ic9b94184a48026254cf4a0a812fe6fc8455841b5
 2016-11-11 18:31:22 +00:00
Ed Sanders 6f8e0d9699 Replace confirm with OO.ui.confirm 
Also enable no-alert eslint rule to prevent alert/confirm/prompt
being used in the future.

Change-Id: I2851e1f58c1861f75dbb20192e5cf6c343da75db
 2016-11-11 13:13:58 +00:00
jenkins-bot 95a8b8a30e Merge "Use a blank temp document when selection is empty" 2016-11-11 00:29:22 +00:00
Ed Sanders 003c5ac410 Use a blank temp document when selection is empty 
shallowCloneFromRange can a broken document if you pass
a collapsed range. That should be fixed upstream but for
now this fixes a major bug (and is faster).

Bug: T150492
Change-Id: I9b539c588d91ef7f22e662c7cae0b3f89b21d33a
 2016-11-11 00:08:11 +00:00
Translation updater bot 0b7f19e941 Localisation updates from https://translatewiki.net. 
Change-Id: I18ad56399a23642d42db319d9c274c6b687a0513
 2016-11-10 23:36:34 +01:00
James D. Forrester 26e7267f02 ArticleTarget: Use an OOUI MessageDialog, not window.alert() 
We should avoid using alert()s as much as possible due to their unhealthy
interaction patterns with any other open tabs or user tasks.

Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
 2016-11-10 12:55:49 -08:00
jenkins-bot 5ac488ba53 Merge "Revert "Temporarily override broken toolbar border colour"" 2016-11-09 21:49:54 +00:00
Translation updater bot aa1cb54a20 Localisation updates from https://translatewiki.net. 
Change-Id: I8bb4d91acd719bc94ac20fa0e02220162e880c48
 2016-11-09 22:45:52 +01:00
Jforrester dc8171d100 Revert "Temporarily override broken toolbar border colour" 
This reverts commit 4c8a97f9e8.

[Pending next OOUI release.]

Change-Id: I890a7081ffa7c015bd32466fa88d61e3f38af4e6
 2016-11-09 20:48:58 +00:00
jenkins-bot de72f77b1b Merge "Collapse to end after inserting WT signature" 2016-11-09 20:00:05 +00:00
James D. Forrester 79befe3d67 MWExtensionWindow: Use #setDir, not the removed #setRTL 
Change-Id: I4090fa0375a93e095a644538b52853fd849b8749
 2016-11-09 11:13:09 -08:00
Ed Sanders 1cb4c27378 Collapse to end after inserting WT signature 
Bug: T150320
Change-Id: I06a8304499d92d0155c112449678fef34dc98424
 2016-11-09 15:26:44 +00:00
jenkins-bot 28787b0f3c Merge "Rename methods used for setting up multiple edit tabs" 2016-11-09 00:45:01 +00:00
Translation updater bot 98fdfb3174 Localisation updates from https://translatewiki.net. 
Change-Id: I0d1b052032dda69430e083751ee83934bae616e8
 2016-11-08 22:50:21 +01:00
jenkins-bot 45a75047fa Merge "Move save dialog checkbox code up from DAT into ArticleTarget" 2016-11-08 17:14:45 +00:00
jenkins-bot d972d3f4f2 Merge "Hacks to get VE loading on mobile while user has NWE enabled" 2016-11-08 17:14:44 +00:00
jenkins-bot efb4133119 Merge "Use onEditTabClick handler in SingleEditTab" 2016-11-08 17:10:06 +00:00
Ed Sanders 55fcded32e Replace non-standard whitespace in comments 
This is required to pass eslint:recommended.

Change-Id: If8c4876a366e5c021c414e54328ed1913b679969
 2016-11-08 14:15:12 +00:00
Ed Sanders 2fa4cfef16 Rename methods used for setting up multiple edit tabs 
Change-Id: I71d6dd0848e9cc3ee8531b0b914c29219b4697bd
 2016-11-08 12:47:30 +00:00
Ed Sanders f6a205d77f Use onEditTabClick handler in SingleEditTab 
Gives us extra functionality like  checking for
isUnmodifiedLeftClick which makes CTRL+click on SET
not change the current page, as expected.

Change-Id: Icb37d7383374ee63798443659a2bcb2f1545c8c5
 2016-11-08 12:39:15 +00:00
Ed Sanders 526b2c0656 Remove max-width from save summary 
Prevents mis-alignment of textbox and checkbox bar
on mobile.

Change-Id: I33d8a2bd4e30d2ed4d61942a7646299f9935bc32
 2016-11-08 10:29:03 +00:00
jenkins-bot 8336720a5f Merge "Remove 'vesection' parameter" 2016-11-08 10:26:53 +00:00
Translation updater bot b2a60edf8a Localisation updates from https://translatewiki.net. 
Change-Id: If90be9fb65286254cd6b386e931eb5093134e043
 2016-11-07 22:40:27 +01:00
jenkins-bot 6f4ff421fc Merge "Clarify wording of __NOINDEX__ option in VisualEditor" 2016-11-07 18:54:10 +00:00
Deskana e4b1b9e4f1 Clarify wording of __NOINDEX__ option in VisualEditor 
VisualEditor contains an option in "Advanced options" to add __NOINDEX__ to
the page, stopping external search engines from indexing the page. This does
not affect the in-site search. The current wording is correct, but a little
ambiguous since it just mentions "search engines". This patch clarifies the
wording.

Change-Id: Ide528f3c028fb79d187eee1c64187c2886635d66
 2016-11-07 10:39:09 -08:00
jenkins-bot c22739cff0 Merge "Cleanup elements passed to MWImageNode mixin" 2016-11-07 16:51:20 +00:00
Translation updater bot 3efe7cc78f Localisation updates from https://translatewiki.net. 
Change-Id: Icb5ee56b1dcb001ad013939335baa72b6c54f128
 2016-11-06 22:42:07 +01:00