wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible

Browse source 
This lets us avoid a fraction of a second lag when someone pastes a plain URL
into source mode.

Bug: T163237
Change-Id: I0e673856dec5f273fb92731b27494762299d2d6c
This commit is contained in:
David Lynch 2017-05-09 09:03:10 -05:00
parent d4c9638508
commit 41ca528705
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js
View file

@ -47,6 +47,7 @@ ve.ui.MWWikitextDataTransferHandlerFactory.prototype.create = function () {
}
handler.resolve = function ( dataOrDoc ) {
var annotations, text;
if ( typeof dataOrDoc === 'string' || ( Array.isArray( dataOrDoc ) && dataOrDoc.every( isPlain ) ) ) {
resolve( dataOrDoc );
} else {
@ -55,6 +56,18 @@ ve.ui.MWWikitextDataTransferHandlerFactory.prototype.create = function () {
// The handler may have also written items to the store
new ve.dm.Document( new ve.dm.ElementLinearData( handler.surface.getModel().getDocument().getStore(), dataOrDoc ) );
// Optimization: we can skip a server hit if this is a plain link,
// with no title, whose href is equal to the contained text. This
// avoids a stutter in the common case of pasting a link into the
// document.
annotations = doc.data.getAnnotationsFromRange( new ve.Range( 0, doc.data.getLength() ) );
if ( annotations.getLength() === 1 ) {
text = doc.getData().reduce( function ( acc, val ) { return ( Array.isArray( acc ) ? acc[ 0 ] : acc ) + val[ 0 ]; } );
if ( annotations.get( 0 ).getAttribute( 'href' ) === text ) {
return resolve( text );
}
}
ve.init.target.getWikitextFragment( doc, false )
.done( resolve )
.fail( function () {