wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 03:08:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ve.init.mw.ArticleTarget: Don't construct element IDs dynamically"

Browse source
This commit is contained in:
jenkins-bot 2017-03-28 17:23:11 +00:00 committed by Gerrit Code Review
parent efc0cad89e 6a9f8a1417
commit 16918a08cf
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
modules/ve-mw/init/ve.init.mw.ArticleTarget.js
View file

@ -224,7 +224,7 @@ ve.init.mw.ArticleTarget.prototype.setDefaultMode = function () {
* @param {boolean} editing Whether the editor is loaded.
*/
ve.init.mw.ArticleTarget.prototype.updateTabs = function ( editing ) {
var tab;
var $tab;
// Deselect current mode (e.g. "view" or "history"). In skins like monobook that don't have
// separate tab sections for content actions and namespaces the below is a no-op.
@ -232,21 +232,21 @@ ve.init.mw.ArticleTarget.prototype.updateTabs = function ( editing ) {
if ( editing ) {
if ( this.section === 'new' ) {
tab = 'addsection';
$tab = $( '#ca-addsection' );
} else if ( $( '#ca-ve-edit' ).length ) {
if ( this.getDefaultMode() === 'visual' ) {
tab = 've-edit';
$tab = $( '#ca-ve-edit' );
} else {
tab = 'edit';
$tab = $( '#ca-edit' );
}
} else {
// Single edit tab
tab = 'edit';
$tab = $( '#ca-edit' );
}
} else {
tab = 'view';
$tab = $( '#ca-view' );
}
$( '#ca-' + tab ).addClass( 'selected' );
$tab.addClass( 'selected' );
};
/**