wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 03:08:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a blank temp document when selection is empty

Browse source 
shallowCloneFromRange can a broken document if you pass
a collapsed range. That should be fixed upstream but for
now this fixes a major bug (and is faster).

Bug: T150492
Change-Id: I9b539c588d91ef7f22e662c7cae0b3f89b21d33a
This commit is contained in:
Ed Sanders 2016-11-11 00:08:11 +00:00
parent 20b802cc85
commit 003c5ac410
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-mw/ui/actions/ve.ui.MWWikitextWindowAction.js
View file

@ -51,7 +51,7 @@ ve.ui.MWWikitextWindowAction.prototype.open = function ( name, data, action ) {
originalFragment = fragment;
originalDocument = originalFragment.getDocument();
coveringRange = originalFragment.getSelection().getCoveringRange();
if ( coveringRange ) {
if ( coveringRange && !coveringRange.isCollapsed() ) {
tempDocument = surface.getModel().getDocument().shallowCloneFromRange( coveringRange );
rangeInDocument = tempDocument.originalRange;
} else {