wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-12-20 09:30:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
7769 commits 13 branches 20 tags 107 MiB
Commit graph

2523 commits

Author SHA1 Message Date
Translation updater bot 8fd76d2332
Localisation updates from https://translatewiki.net. 
Change-Id: I4bd616bc4c83f337c211d21911bd6090003ae1f9
 2024-09-16 09:24:30 +02:00
jenkins-bot 2ef2257922 Merge "Log changes to protected variables access" 2024-09-13 12:49:19 +00:00
jenkins-bot 4f272aeb02 Merge "Add preference for viewing protected variables in AbuseFilter" 2024-09-13 12:27:36 +00:00
STran cbfaaa591d Log changes to protected variables access 
Similar to how CheckUser logs access to IP information about temporary
accounts, AbuseFilter needs to log whenever protected variables are
accessed.

- Implement ProtectedVarsAccessLogger which handles access logging
- Log whenever a user changes their ability to access protected
  variables via Special:Preferences

Bug: T371798
Change-Id: Ic7024d9c5f369eb33c4198a59638de9a1d58b04b
 2024-09-13 01:39:09 -07:00
STran bd819b98a2 Add preference for viewing protected variables in AbuseFilter 
Users need to enable a preference before gaining access to the IPs
from `user_unnamed_ip`, a protected variable.

- Add a preference that the user can check to toggle their access
- Check for the preference and the view right for logs that reveal
  protected variables on:
  + AbuseFilterViewExamine
  + SpecialAbuseLog
  + QueryAbuseLog

Bug: T371798
Change-Id: I5363380d999118982b216585ea73ee4274a6eac1
 2024-09-12 07:59:24 -07:00
Translation updater bot db83369b76
Localisation updates from https://translatewiki.net. 
Change-Id: Ia93dfb0609ba11b8e104f5ddeb84e756cb175555
 2024-09-10 09:27:58 +02:00
Translation updater bot 1109691adc
Localisation updates from https://translatewiki.net. 
Change-Id: I65c16f2cb739a4bd69467cf11421db5d32780008
 2024-09-09 09:21:48 +02:00
Translation updater bot 6c4364688d
Localisation updates from https://translatewiki.net. 
Change-Id: I10e3efd76ea3b882d7409bf676400631763e49f2
 2024-09-05 09:21:38 +02:00
Translation updater bot 98e0d56cb2
Localisation updates from https://translatewiki.net. 
Change-Id: I3a1ea7085072f21f331dc908b121b1e3455c0305
 2024-09-04 09:15:49 +02:00
Translation updater bot b4c32f4757
Localisation updates from https://translatewiki.net. 
Change-Id: I7da53722156626ac32f2da20890d210e3737a3cd
 2024-09-02 09:19:57 +02:00
Translation updater bot ccb5faf096
Localisation updates from https://translatewiki.net. 
Change-Id: I6c95dadb2bfb316b078acc694d44d0ee9a52fd7e
 2024-08-30 09:19:27 +02:00
Translation updater bot 35a479117f
Localisation updates from https://translatewiki.net. 
Change-Id: I461ca3136848f5f2d0489c4eb361e610eaa02fcc
 2024-08-29 09:17:08 +02:00
Translation updater bot 8a8da638d3
Localisation updates from https://translatewiki.net. 
Change-Id: Ief9e8cee08eb09bb9d3aea036dd382dc9a79d322
 2024-08-28 09:36:23 +02:00
Translation updater bot 07ed4eab2d
Localisation updates from https://translatewiki.net. 
Change-Id: I13109ddba997422622635432d41e431e5bb1bc23
 2024-08-27 09:46:40 +02:00
Translation updater bot f4511f7c2e
Localisation updates from https://translatewiki.net. 
Change-Id: I03005ac6897457ef5939d0f80c00b6e53dfbf6c5
 2024-08-26 09:21:12 +02:00
Translation updater bot 86d4fed611
Localisation updates from https://translatewiki.net. 
Change-Id: I48c176b418b68f03165d418e71788e9484c08931
 2024-08-22 09:21:19 +02:00
Translation updater bot f65ed2b7a1
Localisation updates from https://translatewiki.net. 
Change-Id: I85791770e79b28a51a1ab7fb443843ec191c30f5
 2024-08-21 09:22:25 +02:00
Translation updater bot 59cba70091
Localisation updates from https://translatewiki.net. 
Change-Id: I3caa780c4d8fd0b3bde155f9cac96015cfcf4cb9
 2024-08-20 09:40:52 +02:00
Translation updater bot f84ae293a7
Localisation updates from https://translatewiki.net. 
Change-Id: I0bd93af961c8a19ab595c47419baebe859ebfb10
 2024-08-19 09:21:21 +02:00
Translation updater bot b895b6e260
Localisation updates from https://translatewiki.net. 
Change-Id: Icbb7f095f8e900bd543da07fd96a07781c33f260
 2024-08-16 09:27:04 +02:00
Translation updater bot a2eda6ffe9
Localisation updates from https://translatewiki.net. 
Change-Id: Ic73effef7a989c9f1decc1e969e763479e7fd37f
 2024-08-15 09:19:43 +02:00
Translation updater bot a42907f294
Localisation updates from https://translatewiki.net. 
Change-Id: I97bbd0e84bb14a5ed834dd9efe28aa9b01a2e793
 2024-08-14 09:21:50 +02:00
Translation updater bot ad732457f0
Localisation updates from https://translatewiki.net. 
Change-Id: Ib70cb44a14bea490f350ec8e26af5d5985523544
 2024-08-13 09:49:45 +02:00
Translation updater bot 7d3642691b
Localisation updates from https://translatewiki.net. 
Change-Id: I4c1b8c0c0afe3002a611973d5215d826e299724b
 2024-08-12 09:21:28 +02:00
Translation updater bot d1968e3265
Localisation updates from https://translatewiki.net. 
Change-Id: I9ba0596c00fd3308d4098af7959f5cecdcc2fdeb
 2024-08-09 09:33:51 +02:00
Translation updater bot bcab3a7b03
Localisation updates from https://translatewiki.net. 
Change-Id: Ibe6cf64b03cb5765fc5e6b7966d16a576e698e39
 2024-08-08 09:18:53 +02:00
Translation updater bot 20d8e1f7e5
Localisation updates from https://translatewiki.net. 
Change-Id: I11719f554ac0d43b6a495d899be6142263acb538
 2024-08-07 09:23:30 +02:00
Translation updater bot 86370ce996
Localisation updates from https://translatewiki.net. 
Change-Id: I8ae8cad2792bd17aec12bbce4948a2ef482f5898
 2024-08-06 09:45:24 +02:00
Translation updater bot 425772c917
Localisation updates from https://translatewiki.net. 
Change-Id: I0ca9695ef472463c0d330ab67dbde90f7299dca0
 2024-08-05 09:24:19 +02:00
Translation updater bot d60fbef793
Localisation updates from https://translatewiki.net. 
Change-Id: Ia37a015890cc9ad9bd4161a9aed98b0af2e48ff3
 2024-08-02 09:38:28 +02:00
Translation updater bot 82bd56a0aa
Localisation updates from https://translatewiki.net. 
Change-Id: I38ce7ea690d6179ace75687bffdb3f1a2a4fc1ff
 2024-08-01 09:17:49 +02:00
Translation updater bot c0115f3b37
Localisation updates from https://translatewiki.net. 
Change-Id: I03e947472be5927135567cdc1af44092224b7417
 2024-07-31 09:22:13 +02:00
Translation updater bot 02a8dfd882
Localisation updates from https://translatewiki.net. 
Change-Id: I8cbdcb55fc109c1656b3b088291f5f831e6b11a4
 2024-07-29 09:25:38 +02:00
Translation updater bot e7faf0160a
Localisation updates from https://translatewiki.net. 
Change-Id: Ib7a5615f3975209e0e0606d1c338cfd6b0ccf935
 2024-07-26 09:42:10 +02:00
Translation updater bot 9b629596ad
Localisation updates from https://translatewiki.net. 
Change-Id: I3186f4450439bda638aeb79ec92c28f4cc246d08
 2024-07-25 09:18:02 +02:00
Translation updater bot b51459ba3f
Localisation updates from https://translatewiki.net. 
Change-Id: I6a32d083d92c6662deb31315deb0d95f31ccdfff
 2024-07-24 09:22:18 +02:00
Translation updater bot 975e343eb7
Localisation updates from https://translatewiki.net. 
Change-Id: Idd0ae1de72d24475bf51178cb0ff4a7ec51c70f2
 2024-07-23 09:44:13 +02:00
Translation updater bot 062f0039f1
Localisation updates from https://translatewiki.net. 
Change-Id: Ibba5126d0bce50662ec9f3159f6c34c91fbe9052
 2024-07-22 09:23:20 +02:00
Translation updater bot 750410c687
Localisation updates from https://translatewiki.net. 
Change-Id: I5c02cf68177fe5232bd15d76610ebc913e93dfd4
 2024-07-19 09:39:06 +02:00
Translation updater bot 19ca2cad10
Localisation updates from https://translatewiki.net. 
Change-Id: I9ace4121ba7dd3fde9d5bcfcb3de2bb5770d7398
 2024-07-18 09:21:47 +02:00
Translation updater bot 1e780b50b2
Localisation updates from https://translatewiki.net. 
Change-Id: I04c98eb129c828b33855e460482966a217993243
 2024-07-17 09:32:57 +02:00
Translation updater bot 6b326ff2e0
Localisation updates from https://translatewiki.net. 
Change-Id: I7c947cf27ac5872d0eaa9562c02d6c0699bf5c74
 2024-07-16 09:38:35 +02:00
Translation updater bot 29747424be
Localisation updates from https://translatewiki.net. 
Change-Id: Ibb7f11474f369163ca753af519cbb5aabf4d2e01
 2024-07-15 09:23:04 +02:00
Translation updater bot df9e545f7a
Localisation updates from https://translatewiki.net. 
Change-Id: Id341fc862b25c9debb23651ef7e7a62018210b62
 2024-07-12 09:39:20 +02:00
Translation updater bot e045f60dbc
Localisation updates from https://translatewiki.net. 
Change-Id: I611ea9d3dfa96b0429e036c67a48e7093b9ec86e
 2024-07-11 09:28:44 +02:00
STran 30227231f6 Disallow protected variable access on AbuseFilterViewTestBatch 
A filter using a protected variable can be loaded via filter id
using testing tools even though the user might not have the right
to view protected variables. This can potentially leak PII and as
such, testing tools should check for the right before allowing
protected filters to be seen.

- Unload a filter asap if it uses protected variables and the
  requestor doesn't have viewing rights. This:
    + disallows loading of existing protected filters on page load
    + disallows testing against rules that use protected variables
    + disallows subsequent requests for protected filters (via API)

There is a known bug (see T369620) where no user feedback is
provided if an API request for a filter returns no result (typically
when no filter matches the requested id). This commit adds another
pathway to that bug (the filter exists but is protected and not
returned by the API) but does not update this UI/UX.

Bug: T364834
Change-Id: I6a572790edd743596d70c9c4a2ee52b4561e25f3
 2024-07-10 05:31:03 -07:00
Translation updater bot 18ed47a687
Localisation updates from https://translatewiki.net. 
Change-Id: I737a1012f865c2d664b7eac9920b1d295c930092
 2024-07-09 09:41:37 +02:00
Translation updater bot 993fa76c25
Localisation updates from https://translatewiki.net. 
Change-Id: I3f4a8deafc80c7f23627b88f76303a37e01fbdf1
 2024-07-08 09:31:57 +02:00
Translation updater bot bdf0937a27
Localisation updates from https://translatewiki.net. 
Change-Id: I3695bef66d72e4039db55ea1d0a74e86709893b9
 2024-07-03 09:25:22 +02:00
Translation updater bot 71b1c0d0e6
Localisation updates from https://translatewiki.net. 
Change-Id: I635f2c56c409540927635aceba53aa615fe45267
 2024-07-01 09:24:18 +02:00
anterdc99 d1b7bf8e06
Update messages to be more language-friendly 
Change-Id: Id18278496381b1abd69120712ca23ede6336ee11
 2024-06-30 14:42:23 +08:00
Translation updater bot bc5ff46176
Localisation updates from https://translatewiki.net. 
Change-Id: I8cd502dac3414f6ca4f8ca93b7a3330a1c447402
 2024-06-28 09:40:09 +02:00
Translation updater bot 3164bdd105
Localisation updates from https://translatewiki.net. 
Change-Id: I77225b94e5a4741be4cb7e6844d351510617d14f
 2024-06-27 09:19:53 +02:00
Translation updater bot 0ce2096ac8
Localisation updates from https://translatewiki.net. 
Change-Id: Ia3b760fbbc691143ad084cddfbf92e8602f0617e
 2024-06-26 09:20:32 +02:00
Translation updater bot 4dc11add8e
Localisation updates from https://translatewiki.net. 
Change-Id: I32243a432bee13c317daae57e8b4e6d3ffeabeb9
 2024-06-24 09:24:32 +02:00
Translation updater bot d83e1316dc
Localisation updates from https://translatewiki.net. 
Change-Id: I0485bd7561b1d6468f35186743c8374ad6ad11a4
 2024-06-21 09:40:51 +02:00
Translation updater bot 67aea2aa7e
Localisation updates from https://translatewiki.net. 
Change-Id: Ia610542c2f8482bb176dbf6a00bfcfd722a0ffb7
 2024-06-18 09:26:37 +02:00
Translation updater bot d4d04d1138
Localisation updates from https://translatewiki.net. 
Change-Id: If946cd2ec431718b2812f2dabe2584bf751bf28d
 2024-06-17 09:29:07 +02:00
Translation updater bot 16aa6eaaff
Localisation updates from https://translatewiki.net. 
Change-Id: I440eacb6bf5151efa48ae2c8c641aca52ca5f634
 2024-06-14 09:47:57 +02:00
jenkins-bot 4e919e4338 Merge "Add protected variable view permission checks" 2024-06-13 13:18:14 +00:00
STran abe6f1f4ee Add protected variable view permission checks 
Some features restrict access when filters are private. These features
should treat protected filters similarly.

If the user doesn't have view rights for protected filters:
  - Disallow viewing of logs generated by protected filters
  - Disallow querying of matches against protected filters

Bug: T363906
Change-Id: Id84bd4ca7c8e0419fccc3ad83afff35067c9bf70
 2024-06-13 03:15:04 -07:00
Translation updater bot 6e72123efe
Localisation updates from https://translatewiki.net. 
Change-Id: Idabdd0812e9f5ddc9335c6aeac4397163674a6d0
 2024-06-13 09:27:20 +02:00
Translation updater bot f68337c29d
Localisation updates from https://translatewiki.net. 
Change-Id: Ie76af12f2a5405ba1b4f17fa66e17004e44aff69
 2024-06-12 09:21:12 +02:00
Translation updater bot 25e1b8f8eb Localisation updates from https://translatewiki.net. 
Change-Id: I935f1853cb383a5cb4d88687a4e81b73fea2b403
 2024-06-11 09:53:08 +02:00
Translation updater bot d4d679a62e Localisation updates from https://translatewiki.net. 
Change-Id: I3890ae83c9ee56fede22ac334628f125759f74e8
 2024-06-10 09:54:05 +02:00
Translation updater bot 124bf78d4c Localisation updates from https://translatewiki.net. 
Change-Id: Ic978fa445c0d8248347ecdbc7e24314caf89b05b
 2024-06-07 09:43:02 +02:00
jenkins-bot 4b9c2e612c Merge "Clarify protected status in filter checkboxes" 2024-06-06 18:00:27 +00:00
STran 1c96981117 Clarify protected status in filter checkboxes 
The UI/UX for acknowledging a filter will be protected/is protected
could be clearer. The checkbox implemented currently doesn't make
it clear that the acknowledgement is mandatory and filters that are
already protected allow for the checkbox to be unchecked even though
that doesn't reflect that the filter cannot be unprotected.

- Update copy for the protected filter acknowledgement to make it clear
  that it's a mandatory acknowledgement, not an optional one
- Update copy for the error that shows when a filter that should be
  protected doesn't have the acknowledgement checked
- When a filter is already protected, disable the acknowledgement
  checkbox to indicate this is not mutable

Bug: T364485
Change-Id: I667fcca4511dff1ac3ca69930c5b5e5eb5001787
 2024-06-06 00:23:39 -07:00
jenkins-bot 64443f9905 Merge "Add error message for unprivileged access of filter history" 2024-06-05 15:19:31 +00:00
jenkins-bot 3897096fd7 Merge "Implement 'protected' filter acknowledgement checkbox" 2024-06-05 13:42:33 +00:00
STran 5da20292ea Add error message for unprivileged access of filter history 
Attempting to access a diff in the history of a protected filter when
the user doesn't have the right to view protected variables results
in the 'abusefilter-history-error-protected' error and requires copy.

- Add copy for the user-facing 'abusefilter-history-error-protected'
  error

Bug: T364465
Change-Id: I0e9afae90c43bd3f792f1330ea865c0d56a023d1
 2024-06-05 06:22:10 -07:00
STran 69a28f7f03 Implement 'protected' filter acknowledgement checkbox 
- Add a basic checkbox on the filter edit page that must be checked if a
  filter uses a protected variable to ensure that the user is aware that
  their filter will also become protected

Bug: T364485
Change-Id: I7c7652f7d1a81223229b839ff7eee5da4af74c8a
 2024-06-05 05:43:25 -07:00
Translation updater bot e126601788 Localisation updates from https://translatewiki.net. 
Change-Id: I2ea878200aef92946e81300e76a071d5054c2a97
 2024-06-05 09:21:47 +02:00
jenkins-bot 4e14afa6fb Merge "Allow variables to be restricted by user right" 2024-06-04 17:20:17 +00:00
STran bf28dbce0e Allow variables to be restricted by user right 
Some exposed variables (eg. `user_ip`) used in filters are sensitive
and need to only be available to restricted groups of users.

Back-end changes:
- Add `AbuseFilterProtectedVariables` which defines what variables are
  protected by the new right `abusefilter-access-protected-vars`
- Add the concept of a `protected` variable, the use of which will
  denote the entire filter as protected via a flag on `af_hidden`

New UX features:
- Display changes to the protected status of filters on history and diff
  pages
- Check for protected variables and the right to see them in filter
  validation and don't allow a filter to be saved if it uses a variable
  that the user doesn't have access to
- Check for the right to view protected variables before allowing access
  and edits to existing filters that use them

Bug: T364465
Bug: T363906
Change-Id: I828bbb4015e87040f69a8e10c7888273c4f24dd3
 2024-06-04 06:54:53 -07:00
Translation updater bot 77354e4ee4 Localisation updates from https://translatewiki.net. 
Change-Id: I9141fb84ee0c61d2240e6cebab5715c2fb3875f5
 2024-06-04 09:29:27 +02:00
Translation updater bot 06b556f6c6 Localisation updates from https://translatewiki.net. 
Change-Id: Ia2154f54ebe9df5fe38319d98002c0f64856ebf0
 2024-06-03 09:30:04 +02:00
Translation updater bot e34a64cdcb Localisation updates from https://translatewiki.net. 
Change-Id: I33d2bcedbb18b60545510c55c11a90e7963fe139
 2024-05-31 09:55:08 +02:00
Translation updater bot a47a3e3823 Localisation updates from https://translatewiki.net. 
Change-Id: Ie4a8c05d6d105ea90ae22c955b165bfc3a85d429
 2024-05-30 09:35:40 +02:00
Translation updater bot b1e361166b Localisation updates from https://translatewiki.net. 
Change-Id: I80fa4ab93543b206d6d8e3b11c3fb753149b7ffa
 2024-05-29 09:29:45 +02:00
Translation updater bot 90cbdd834f Localisation updates from https://translatewiki.net. 
Change-Id: Ic8d7e785ee4013197837da45901a2e8536413389
 2024-05-28 09:29:15 +02:00
Translation updater bot c34e51153f Localisation updates from https://translatewiki.net. 
Change-Id: Id1daa755bd8214d7e92df16eb5dbe010d77b60e9
 2024-05-27 09:27:32 +02:00
Translation updater bot a21cbfffec Localisation updates from https://translatewiki.net. 
Change-Id: Ib993f524c0b53f3fddaa49cad6523e0a91e76953
 2024-05-24 09:42:31 +02:00
jenkins-bot 58c5edce98 Merge "Add user_unnamed_ip variable" 2024-05-23 18:10:52 +00:00
STran fe0b1cb9e9 Add user_unnamed_ip variable 
After temporary accounts are enabled, filters that rely on an ip
in the `user_name` will fail (eg. `ip_in_range` and `ip_in_ranges`).
To keep these filters working:

- Expose the IP through another variable, `user_unnamed_ip`, that can be
  used instead of `user_name`.
- The variable is scoped to only reveal the IPs of temporary accounts
  and un-logged in users.
- Wikis that don't have temporary accounts enabled will be able to see
  this variable but it won't provide information that `user_name`
  wasn't already providing
- Introduce the concept of transforming variable values before writing
  to the blob store and after retrieval, as IPs need to be deleted from
  the logs eventually and can't be stored as-is in the amend-only blob
  store

Bug: T357772
Change-Id: I8c11e06ccb9e78b9a991e033fe43f5dded8f7bb2
 2024-05-23 07:19:48 -07:00
Translation updater bot c58696b7b0 Localisation updates from https://translatewiki.net. 
Change-Id: Ib1529b519dcaf1d749f3246aac5592c9e1e37e3e
 2024-05-23 09:24:59 +02:00
jenkins-bot 35e3319fe3 Merge "i18n: Replace mw: interwiki with url to mediawiki.org" 2024-05-22 14:28:51 +00:00
Translation updater bot f28ce866a1 Localisation updates from https://translatewiki.net. 
Change-Id: I7d16b514dcd73a52910afb0fcb48791a154f0222
 2024-05-22 09:19:32 +02:00
Translation updater bot 5f720af28f Localisation updates from https://translatewiki.net. 
Change-Id: Ib9d1af167acfcc885cf72a13989aab541c382760
 2024-05-21 09:27:06 +02:00
Translation updater bot ad868d42a4 Localisation updates from https://translatewiki.net. 
Change-Id: Id98c30c4cf378ff812dab86d9bdba03549c7171c
 2024-05-20 09:23:39 +02:00
Translation updater bot c47e3a385f Localisation updates from https://translatewiki.net. 
Change-Id: Ibf503a4b68283c4a4a673ccf8b70881adc1fe5b5
 2024-05-17 09:47:20 +02:00
Translation updater bot f6b914bb23 Localisation updates from https://translatewiki.net. 
Change-Id: I6a2aed4dd60bedfad6f7a1a8d6a35d99457aa0bf
 2024-05-16 09:24:29 +02:00
Umherirrender bd074450ad i18n: Replace mw: interwiki with url to mediawiki.org 
The interwiki table must not contains an interwiki link with prefix mw:

Change-Id: I96e7e3b13fa91ed8d3450a8dec0af2c46aacce21
 2024-05-15 23:30:48 +02:00
Translation updater bot df93b427ac Localisation updates from https://translatewiki.net. 
Change-Id: I821617f52b460269cb499a4ce352d95660e020bb
 2024-05-15 09:20:55 +02:00
Translation updater bot a77994b439 Localisation updates from https://translatewiki.net. 
Change-Id: Ide93b3b72ff550afba74ed28b785b9c7b1df8885
 2024-05-14 09:24:19 +02:00
Amir E. Aharoni 2b29a61f66 Consistent spelling for "comma-separated" 
It's hyphenated in most other extensions.

Change-Id: Ibefa8dec5ba079392ca80f6d8e26d47766dd33a1
 2024-05-13 04:40:46 -04:00
Translation updater bot 39228edbd3 Localisation updates from https://translatewiki.net. 
Change-Id: I4ad76defcad3ae05eae28bd90e13baa64a22e78a
 2024-05-13 09:25:56 +02:00
Translation updater bot 50766781ac Localisation updates from https://translatewiki.net. 
Change-Id: I2a977cb0775e89271c0a44c213d8603459ae305f
 2024-05-10 09:27:16 +02:00
Translation updater bot 1d20a59f84 Localisation updates from https://translatewiki.net. 
Change-Id: Iae605ac3436a08d4e1e6a2abd94d4a3c8eea59e2
 2024-05-09 09:36:37 +02:00
Translation updater bot 25c48d1384 Localisation updates from https://translatewiki.net. 
Change-Id: Ica9c34d7a3e3165fe3704a0554497a790187f3e0
 2024-05-08 09:23:04 +02:00