wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-19 04:05:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
16358 commits 162 branches 1 tag 190 MiB
Commit graph

7619 commits

Author SHA1 Message Date
jenkins-bot e0e8f84322 Merge "Use CE rendering for invisible templates" 2018-05-18 18:27:29 +00:00
David Lynch 909aecbd26 dm.MWInternalLinkAnnotation: account for ? in fragment 
It was failing to properly ignore the fragment if it contained a ?. This
resulted in such fragment-selflinks being considered a link to a wikipage with
a title of their full URL. As such, only consider the pre-# section for ?s.

Bug: T194463
Change-Id: I205f86d2b4abcf91dd6a84e3013e899e953a6842
 2018-05-18 19:58:21 +02:00
jenkins-bot a47b78e18c Merge "Update VE core submodule to master (1d341ca7d)" 2018-05-18 15:37:04 +00:00
James D. Forrester 9e52ece21f Update VE core submodule to master (1d341ca7d) 
New changes:
3a6d868bf Separate (Comment/Link)InspectorTools into separate files
cb5d36e32 Localisation updates from https://translatewiki.net.
c75491b16 build: Extend 'svgmin' options and amend
ddef270d9 Genericise activeLink behaviour to any annotation
d13d44e12 Create simple comment annotation type for rebaser.
7e49a1f33 Add getters for author properties
1d341ca7d Follow-up I16942623d: Only filter inactive models if they are 'canBeActive'

Local changes:
Change .ve-ce-linkAnnotation-active > .ve-ce-linkAnnotation.ve-ce-annotation-active

Bug: T185596
Change-Id: I2a49315d01aa075373f9b5f0d8802a7e7dd4dca3
 2018-05-18 17:07:28 +02:00
jenkins-bot 60ef3af0b1 Merge "Fix position of inspectors/context inside dialogs" 2018-05-18 14:55:01 +00:00
jenkins-bot b899759edc Merge "MobileArticleTarget: fix deprecated toolbar calls" 2018-05-18 14:54:59 +00:00
Bartosz Dziewoński dfe65db5bb Fix position of inspectors/context inside dialogs 
Override #addSurface instead of #getSurfaceConfig, so that the
$overlayContainer option only applies to the "main" surface of the
Target rather than all of the surfaces (including those in
TargetWidgets).

Bug: T194433
Change-Id: I61c609e2d52814b4547fb5292a0bfb237c4c218f
 2018-05-18 14:26:00 +00:00
David Lynch 150fb16008 MobileArticleTarget: fix deprecated toolbar calls 
Change-Id: If7d4b52c29e9648f17eda2d62f8fcdad744f82ae
 2018-05-18 15:59:15 +02:00
jenkins-bot c80c2d1723 Merge "Fix ve.ce.MWTransclusionNode#filterRendering to work with non-element nodes" 2018-05-18 12:05:33 +00:00
Ed Sanders ed604c857d Fix ve.ce.MWTransclusionNode#filterRendering to work with non-element nodes 
Bug: T194839
Change-Id: I90065720725e8b59bfe4a4a9215b3835179cb2d1
 2018-05-17 19:19:40 +01:00
jenkins-bot a975aacbe7 Merge "CategoriesPage: Remove unnecessary input widget width" 2018-05-16 22:06:14 +00:00
Ed Sanders 70cd11e32d CategoriesPage: Remove unnecessary input widget width 
Change-Id: I7fa38b866d0489de612b0ed08cf0b9eb3b9b71af
 2018-05-16 18:04:08 +01:00
Ed Sanders 9b8e501333 MobileArticleTarget: Show both edit modes in edit switcher, for consistency 
Change-Id: I48193db0d8282e31265e95884878eb81cbaeeedd
 2018-05-16 15:20:25 +00:00
jenkins-bot c5a6e54dde Merge "Simplify valign code with a loop" 2018-05-16 09:49:06 +00:00
jenkins-bot d70ddfb85a Merge "Use better align change descriptions" 2018-05-16 09:49:05 +00:00
jenkins-bot cf0fd3e673 Merge "Fix typo in API call for version number help" 2018-05-16 09:37:26 +00:00
Ed Sanders 63c698823c Fix typo in API call for version number help 
Change-Id: Idcea9d74e27e33930d98d2b896ee08012e46e8f3
 2018-05-16 10:23:39 +01:00
jenkins-bot 4ca3f1661d Merge "ArticleTarget: Change rendering of category preview" 2018-05-15 13:28:57 +00:00
Ed Sanders 3c1ef8cff8 Simplify valign code with a loop 
Change-Id: I90cc74d19b46ea2f5a603b1fd39393debefc8e7c
 2018-05-15 11:57:41 +00:00
Ed Sanders 7254fbe2cf Use better align change descriptions 
Adds support for align=none.

Also don't show changes from class names.

Change-Id: Ia00a51dd52af73183e98c8a87f4c60ee5380d81f
Depends-On: Ic668454c4b4b069dab46a608530c85a5bb7e7ad8
 2018-05-15 11:57:33 +00:00
David Lynch 5d19272aa1 ArticleTarget: Change rendering of category preview 
Just generate the standard wiki skin markup for categories. Adjust linkcache to always know
whether links are hidden categories. (It previously knew *sometimes*,
depending on whether a MWCategoryWidget had interacted with that category.)

Make the save dialog preview use the same method as the bottom-of-editor preview.

Bug: T194092
Change-Id: I37fea15eaef0a5847f27ce41dd92370a4bf353b6
 2018-05-13 16:40:59 -05:00
Ed Sanders 900b74e9a9 Update VE core submodule to master (14bcc9256) 
New changes:
14bcc9256 Give toolbars groups names

Local changes:
Give toolbars groups names

Also create an empty placeholder group for reference tools.
This allows targets to specify if they should show them.

Depends-On: Iccaf35cf941cb47ad55e8d98373461f5eaff5fed
Change-Id: I0bace5e5fe05f9c214d57a74c478b48a7dcaec3b
 2018-05-13 18:09:33 +01:00
Ed Sanders d7d4eb3126 Use ve.ce.nodeFactory.createFromModel 
Change-Id: I1a826c3c0985ef0d8ad0b669886e29aa021c90c1
Depends-On: I259face33154b795143c8820abdfb6b4a495f141
 2018-05-11 17:05:09 +00:00
Ed Sanders c2e16186a0 Use CE rendering for invisible templates 
Bug: T170107
Change-Id: I7bce9e7b77ce22953bb0141d81871b53a4f005db
 2018-05-11 17:05:03 +00:00
Ed Sanders 60e129062a Add missing mw-content-(dir) class to MWPreviewElement 
Also allow preview elements to existing with an mw-body-content
area withouth the font size being applied twice.

Depends-On: Ibbf989dcebf2d21fd2ac481f17062f366ff29e41
Change-Id: I284bcd5dd25cdbb883427ebacb41af1bbf50b60f
 2018-05-11 16:59:12 +00:00
jenkins-bot e8c4bf2cd3 Merge "ve.ce.MWTableNode: Compatibility with new jQuery.makeCollapsible toggle styles" 2018-05-10 21:48:24 +00:00
Bartosz Dziewoński deabd6bd51 ve.ce.MWTableNode: Compatibility with new jQuery.makeCollapsible toggle styles 
jQuery.makeCollapsible styles now display "fake" expand/collapse
toggles. This is nice, but some bits and pieces clashed with our
styles, this fixes it.

Also ensure that the styles are loaded if the page previously had no
collapsible elements on it.

Bug: T194323
Change-Id: If8f0869e6677811147f272337da7d96286792fe0
 2018-05-10 21:41:31 +02:00
jenkins-bot d3f3015a60 Merge "Restore CSS for diffslider lines" 2018-05-10 16:09:06 +00:00
Ed Sanders ae9560aacd Restore CSS for diffslider lines 
Bug: T193839
Change-Id: If32a6be33f6c8c9f4413a81f561009214fa39df6
 2018-05-10 16:38:50 +01:00
Bartosz Dziewoński 73a77b60ed ve.init.mw.DiffPage.init: Detect extra diff header rows 
Bug: T193925
Change-Id: I117871bef0f1ecf1ce0ba9762047c926a1e723eb
 2018-05-08 22:05:46 +02:00
jenkins-bot 6ad3c408b2 Merge "Add comment to htmlBlacklist item" 2018-05-08 16:10:27 +00:00
jenkins-bot 821e7ec828 Merge "Remove some no longer required CSS from switch popup" 2018-05-08 16:10:26 +00:00
Ed Sanders b5371c791f Add comment to htmlBlacklist item 
Bug: T150418
Change-Id: I0c48ff6f187cde4c378e5aa193e62d107bc7919c
 2018-05-07 21:49:34 +01:00
Ed Sanders 86fdda21c6 Remove some no longer required CSS from switch popup 
Change-Id: Ic965c147b195b4546f8f1e7d36395c96597a159e
 2018-05-07 21:35:24 +01:00
Ed Sanders 5974c59b97 Follow-up Ifdc951fdc: Don't use target when it doesn't exist 
Change-Id: Idf546f7b1d2c12f59b5024f3365665214e4e5f49
 2018-05-07 21:22:09 +01:00
jenkins-bot 7bca14c182 Merge "Add an 'api' parameter to ApiResponseCache" 2018-05-07 15:53:18 +00:00
jenkins-bot 5722a3c59f Merge "Remove references to global singleton inside LinkCache" 2018-05-07 15:53:01 +00:00
jenkins-bot 93c1f0d9b4 Merge "Create an MWSurface and move langChange handling there" 2018-05-07 15:52:08 +00:00
jenkins-bot 95d831c2de Merge "Create getters for localised APIs (getContentApi/getLocalApi)" 2018-05-07 15:51:45 +00:00
jenkins-bot 9a79c10fc2 Merge "Remove unused overrides in internal link annotation inspector" 2018-05-07 15:41:33 +00:00
jenkins-bot 25d2eb2848 Merge "Use ve.resolveUrl in MediaContext/Dialog" 2018-05-07 15:28:52 +00:00
Ed Sanders b980150df4 Update link cache to use new descriptions API 
Bug: T191333
Change-Id: If1e7f50208a44bda6c30ff1d6c60a085f9da74e7
 2018-05-07 15:59:02 +01:00
Ed Sanders 4b00c765ff Add an 'api' parameter to ApiResponseCache 
Change-Id: Ie68b70472447a4bb2c9be8ed505a91f24858059d
 2018-05-07 11:53:23 +01:00
Ed Sanders 5eb89cdc51 Remove references to global singleton inside LinkCache 
Use 'this' instead.

Change-Id: Ie3138f2c62ff4e4938e8ed21e79b3433d98e2737
 2018-05-07 11:53:23 +01:00
Ed Sanders 8bddec44e3 Create an MWSurface and move langChange handling there 
Change-Id: I8a75b5f431f454b66441fc301b90e5f28636612e
 2018-05-07 11:53:23 +01:00
Ed Sanders 478b0bcbb9 Create getters for localised APIs (getContentApi/getLocalApi) 
Pass through the current document when available, otherwise
assume the current surface's document.

Also add a getter for getPageName, so that can vary based
on the target document.

Bug: T193856
Change-Id: Ifdc951fdc6a43b924d102e3fcd7e59e52023757b
 2018-05-05 14:32:55 +01:00
Ed Sanders b54f427078 Remove unused overrides in internal link annotation inspector 
Removes an unused call to mw.util.getUrl.

Change-Id: I3988311b7160af628ea4ceeafcfdc3cc0a7a3774
 2018-05-05 14:32:55 +01:00
Ed Sanders 3b4923fa74 Use ve.resolveUrl in MediaContext/Dialog 
Change-Id: I53e28d6cec13ac77718ba3cae425c4c43c96e174
 2018-05-05 14:04:15 +01:00
jenkins-bot 1f6cf4883d Merge "ve.init.mw.DesktopArticleTarget.init: Edit the latest revision when viewing a FlaggedRevs-stable one" 2018-05-05 01:03:04 +00:00
Bartosz Dziewoński 192a232410 ve.init.mw.DesktopArticleTarget.init: Edit the latest revision when viewing a FlaggedRevs-stable one 
When the user is viewing the last stable revision of a page which has
newer unreviewed revisions, FlaggedRevs wants us to open the latest
(unreviewed) revision of the page for editing.

Use the JS config variable 'wgFlaggedRevsEditLatestRevision', provided
by FlaggedRevs since change I4c9804fe2c4924e28770807881379ddca4fd8b76.

Also add an extra comment about loading latest revisions in general.

Bug: T165283
Depends-On: I4c9804fe2c4924e28770807881379ddca4fd8b76
Change-Id: Ic47491e690153d0ad87ce64bfc9e7a28a06fc6e2
 2018-05-04 22:04:02 +00:00
jenkins-bot 829089008f Merge "DesktopArticleTarget: track mwedit.ready even if skipping temp editor for new sections" 2018-05-04 21:59:27 +00:00
Ed Sanders ebcf1e1151 Check imageModel exists in #checkChanged 
Bug: T193879
Change-Id: Ic6eda7a056e5207042b575609b9da1869e3a759e
 2018-05-04 14:52:03 +01:00
David Lynch 3f91a27809 DesktopArticleTarget: track mwedit.ready even if skipping temp editor for new sections 
Bug: T193206
Change-Id: I78555b84bde3d5bd14b032862e5a020121fc5c2e
 2018-05-02 11:35:42 -05:00
Ed Sanders e49b5628d8 MWBlockImage: Make zoom link unclickable 
As it sticks out beyond the focus shield we
need to disable it manually.

Change-Id: I92baf24e6bb9294e46821311805ca0bb77f892a6
 2018-05-02 11:57:33 +01:00
jenkins-bot f9cac9f0ce Merge "ve.init.mw.DiffPage.init: Do not duplicate diff table header" 2018-04-30 21:26:55 +00:00
Ed Sanders 3dd3073bd2 Update VE core submodule to master (a8e0eef6d) 
New changes:
a8e0eef6d Simplify usage of dummy target

Local changes:
Simplify usage of dummy target, ceating an MWDummyTarget, extending
DummyTarget instead of mw.ArticleTarget.

Depends-On: I01a6860387087db8149c73793e9bd4294d33aea8
Change-Id: I227486159fe416c219e2c37a1d054201084fe285
 2018-04-30 13:05:02 -07:00
Bartosz Dziewoński 6d4a7f932e ve.init.mw.DiffPage.init: Do not duplicate diff table header 
The duplicate header, especially the duplicate elements with identical
IDs, were difficult to handle for other scripts.

Now instead of hiding the entire wikitext diff, we only hide the
"content" rows but keep the header, and adjust our attributes on the
header back-and-forth when switching diff modes.

Bug: T192755
Change-Id: I3a6bb4730fefd81f533b786ec3b20241c4cb8d13
 2018-04-30 19:23:16 +02:00
Ed Sanders 1bd430c9d1 Convert most uses of isForClipboard to doesModeNeedRendering 
Depends-On: I0f1b90056e9d1a4fa0e188700604709297593924
Change-Id: I6fa1cde51ffc859b57ab557e3ddf8a76d92bf94f
 2018-04-30 16:10:27 +00:00
jenkins-bot ffac6b14dd Merge "Check link 'host' in onEditSectionLinkClick" 2018-04-30 15:17:45 +00:00
jenkins-bot f4f78d3384 Merge "Follow-up Iea7ad832: Fix context in MWPopupTool" 2018-04-30 15:06:06 +00:00
Ed Sanders f8cebb8f51 Follow-up Ib7e769e: Fix typos in static method calls 
Also move desktop-only methods to DesktopArticleTarget.

Bug: T193217
Change-Id: Icc2bb6602a62057da9f841793d8fe06d9814230e
 2018-04-30 11:05:43 +01:00
Ed Sanders ad170023e6 Check link 'host' in onEditSectionLinkClick 
Bug: T193323
Change-Id: Id67798e5689af9d528bf29bb1b42047adaedaabd
 2018-04-30 10:57:45 +01:00
Ed Sanders 8fdc1f7085 Follow-up Iea7ad832: Fix context in MWPopupTool 
Bug: T193043
Change-Id: I2b035a50543093988a291ea8c8958a3a7cc9e7ba
 2018-04-29 21:45:10 +01:00
Ed Sanders cddf206f5b Set surface's $overlayContainer in DesktopArticleTarget 
Logically depends on Ia96b1a89dd9582303b80be85b3971cf3341cad24.

Bug: T166217
Change-Id: Icc54f87bac46d39e8c49010ed052e1db66827f06
 2018-04-27 21:55:12 +00:00
Ed Sanders 95258a9969 Visual diff: Describe redirect changes 
Change-Id: Id31e8399556dab9b47bc1d21c62cb82af3a0e7bb
 2018-04-27 21:07:41 +01:00
Bartosz Dziewoński e1635fdc52 Update custom styles for format menu after OOUI changes 
Bug: T193098
Change-Id: I00d28f16b03a31ecda1dc57050945e98e8eb37e8
 2018-04-26 01:48:28 +02:00
jenkins-bot fd082e577b Merge "ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input" 2018-04-24 16:24:42 +00:00
Bartosz Dziewoński e3378e6d77 ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input 
When we set up the new section title input and possibly set its value
(preloading from URL query, or from autosave), the "Save" button on
the toolbar must already exist, because we try to enable it.

Bug: T192901
Change-Id: I3bba86a8c8a9b81014d425db256ff49f06bdaea6
 2018-04-24 18:11:42 +02:00
David Lynch 44469f0f06 MWWikitextSurface onCopy: set text/x-wiki content if available 
Equivalent to some existing copy-code in inspectors which handle raw wikitext.
Lets us shortcut content-sniffing with html/text content onPaste.

Change-Id: I27ded82a9675abdb3ee98ee29390e7079d11cf05
 2018-04-23 16:04:49 -05:00
jenkins-bot c0364bc6a6 Merge "Teardown target before reloading article" 2018-04-23 21:00:43 +00:00
jenkins-bot ec8be1bfa1 Merge "Add a plain text paste transfer handler for source mode" 2018-04-23 21:00:41 +00:00
Ed Sanders 1f4baa7b58 Teardown target before reloading article 
Ensures that auto-save data is cleared after
creating a new article, or restoring a revision.

Bug: T192770
Change-Id: I348b8522c1a935d7db1243ba8fcbd5b24e3383a2
 2018-04-23 21:30:37 +01:00
gopavasanth 3e541774e8 Change http://www.mediawiki.org/ to https://www.mediawiki.org/ 
In other files, links to mediawiki site are https://www.mediawiki.org/

Bug: T189687
Change-Id: I0279a7ffdb9544a87a11ffdab7ff5d5d38ea6035
 2018-04-23 15:08:43 +00:00
David Lynch 6f8e58fa8a Add a plain text paste transfer handler for source mode 
This allows plain text pasting into source mode without interfering with the
possible-conversion that should happen when it's pasted into visual mode.

Bug: T190590
Bug: T192320
Depends-On: I47a5bf321fb64d4a631ec6fd728bee269d4cdae0
Change-Id: I71db368c683a6a846569d7627f4cc73e907a61d2
 2018-04-22 12:52:56 -05:00
jenkins-bot 6e44244af5 Merge "Sortable table header: Account for null entries in table matrix" 2018-04-19 16:08:01 +00:00
jenkins-bot 9ecd73f771 Merge "NWE: Fix selection when applying async links" 2018-04-19 16:01:22 +00:00
Ed Sanders 24ae471fd1 Sortable table header: Account for null entries in table matrix 
Bug: T192545
Change-Id: I05bb80a0afce72a8202209499947781efe684584
 2018-04-19 14:27:22 +01:00
jenkins-bot 5ae421d715 Merge "Refactor ve.dm.MWTransclusionNode.static.describeChanges" 2018-04-18 07:26:10 +00:00
jenkins-bot bc12e25b35 Merge "MWExtensionNode: Diff mw.attrs" 2018-04-18 07:26:08 +00:00
jenkins-bot 69f0ff1016 Merge "Blacklist images with data URLs" 2018-04-17 19:48:20 +00:00
Ed Sanders 6625fc5c85 Blacklist images with data URLs 
These aren't supported by VE-MW, so must just be
garbage from a browser plugin.

Bug: T192392
Change-Id: I24646244daf2847e4dee88273058658300880dfc
 2018-04-17 20:10:51 +01:00
jenkins-bot 6902e81768 Merge "Use ellipsis on toolbar save/publish button" 2018-04-17 18:34:17 +00:00
jenkins-bot a8e6d1ddd5 Merge "Add label to Options dialog > Categories input fields" 2018-04-17 18:18:55 +00:00
jenkins-bot d325f793a9 Merge "Show revision info on historical diffs" 2018-04-17 17:36:21 +00:00
Ed Sanders 53e758a427 NWE: Fix selection when applying async links 
Change-Id: I31dc6f2d9fcd563bdbd8245bda6336d317aa512a
 2018-04-17 16:33:23 +00:00
Ed Sanders b38500f102 Only resolve wikitext promise when progress dialog has closed 
Logically depends on I0cdb004011 to fix the bug.

Bug: T182402
Change-Id: I8ecd695c052a6c759b8261e81fb25c771bdf3d56
 2018-04-17 16:33:14 +00:00
James D. Forrester 58c5643f1e Update VE core submodule to master (a64ba1cc6) 
New changes:
aee32648a Allow access to a fragment's async state
a64ba1cc6 Add extra copy/paste tests for <span> clipboard keys

Local changes:
* Fix signature of runSurfacePasteTest

Change-Id: Idbc2f2c25eaf0606c51d9dff8ec23562f5244c08
 2018-04-17 16:02:04 +00:00
hunter be5289689f Add label to Options dialog > Categories input fields 
Add label to indicate the function of the input field underneath the
categories label in the options dialog. The <label> element is
preferred for screen readers and users with visual disabilities.

Bug: T146966
Change-Id: Ib300ca7a1fd55d320c1a1a8c8c7fd01ab8b0b9c5
 2018-04-17 06:28:32 +00:00
jenkins-bot 3a9ec6bcce Merge "Fix layout of welcome dialog on smaller screens" 2018-04-12 22:55:39 +00:00
Ed Sanders 62d2211aed Mobile: Hide top-level toolbar labels on narrow screens 
Change-Id: I8049b935204834201d2a185d04070bbf81520d1e
 2018-04-12 23:32:33 +01:00
Ed Sanders 4f448a8c96 Hide stray checkmarks on mobile toolbar 
Change-Id: Iae5ad6f736197f9d88d973a51b3b04bddc101826
 2018-04-12 23:22:26 +01:00
Ed Sanders 2496fcefb0 Fix layout of welcome dialog on smaller screens 
Bug: T191095
Change-Id: Ic329fe22a6758fe58ec56dc3b5a293b83d9b38fb
 2018-04-12 23:15:15 +01:00
Ed Sanders bcf3783c1c Refactor ve.dm.MWTransclusionNode.static.describeChanges 
Removes some duplication.

Change-Id: If68401617cde60cf151bf132f33e5d9dc42bbf72
 2018-04-12 17:46:47 +01:00
Ed Sanders 4fdf5b08b4 MWExtensionNode: Diff mw.attrs 
Bug: T191450
Change-Id: Ia6bfc4d2f04243970d6f65fd0ccfd650aee5da06
 2018-04-12 17:46:47 +01:00
Ed Sanders 3682ab070d mw.Target: Remove .protectedClasses, only used in ArticleTarget 
Also fix documentation

Change-Id: I3fa93dd95c3ef47f649d3f92a38e14750a411333
 2018-04-12 15:38:23 +00:00
Ed Sanders 50a2ab7418 Show revision info on historical diffs 
Bug: T187614
Change-Id: Ie28d4af6443a17e2e25b2520f0e0dbf5ba4076cc
 2018-04-10 20:42:06 +02:00
Ed Sanders 637d869d99 Convert href-less links to spans 
Bug: T191598
Change-Id: I0993869ed53842f9de60ff7e68f79a69da1d23c7
 2018-04-09 18:04:08 +00:00
jenkins-bot b7abb924c2 Merge "Abstract API calls to 'parsefragment'" 2018-04-09 16:13:27 +00:00
jenkins-bot 2306717eb1 Merge "Use 'imageBroken' icon for missing images' contextItem" 2018-04-08 19:13:16 +00:00
James D. Forrester ac2b5e1ef8 Update VE core submodule to master (3ea11b8b1) 
New changes:
f97bdb039 PlainTextStringTransferHandler: Allow as paste
5a0007e49 Expand ce.Surface tests for plain text pasting
bab28c8d3 Localisation updates from https://translatewiki.net.
82bc2c014 Fix language input design now that indicator-next is gone
c14c6ac56 Fix z-index of context elements in diff

Bug: T190590
Bug: T190916
Change-Id: Ibe8b1b62a8300f380b753f978bed6a6f8d520044
 2018-04-06 10:52:54 -05:00
Ed Sanders 924f9ec730 Use 'imageBroken' icon for missing images' contextItem 
Change-Id: I3ba8f34a8ff03c949c18df102e7334449abb6e27
 2018-04-06 15:32:55 +01:00
Ed Sanders 16211cdc09 Abstract API calls to 'parsefragment' 
Change-Id: Id0be3207219a6d93cebff2b6b5061cd24898d5cb
 2018-04-06 13:49:16 +01:00
jenkins-bot f5c483af52 Merge "Gallery: Use 'poster' attribute for video thumnails" 2018-04-05 21:33:29 +00:00
Ed Sanders 43a8004abb Gallery: Use 'poster' attribute for video thumnails 
Bug: T191098
Change-Id: I0f4e456ec7a52ee71dcfca581c73415fc8ee6178
 2018-04-05 22:14:16 +01:00
David Lynch c4c5582121 MWTransclusionDialog: remove extra padding from framesets 
Bug: T191234
Change-Id: I6cfec45607f2dd428347879c134dbe286397f8b6
 2018-04-05 11:30:05 -05:00
Ed Sanders 8b42a5917c Add img.src's to gallery DM output 
Bug: T191377
Bug: T191436
Change-Id: Ie6b3593876c92f8e6f08fb005d876304223491ed
 2018-04-05 12:57:18 +01:00
jenkins-bot 7b1d248ec1 Merge "ve.ui.MWMediaDialog: Use dropdown for image type selector" 2018-04-05 11:02:22 +00:00
jenkins-bot f3ba1a780f Merge "ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget" 2018-04-04 21:36:39 +00:00
jenkins-bot f5b0d655cf Merge "FeedbackTool: Add the ability to vary feedback page for source mode" 2018-04-04 21:24:09 +00:00
jenkins-bot a903f5c1cc Merge "ve.ce.MWInlineImageNode: Fix rendering of non-linked images" 2018-04-04 21:20:59 +00:00
Bartosz Dziewoński 0cf02e0155 ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget 
Also, pass $overlay to all PageLayout subclasses used in ve.ui.MWMetaDialog
and ve.ui.MWTemplateDialog/ve.ui.MWTransclusionDialog, for consistency.

Bug: T191395
Change-Id: Ib7ed2e2c04ff7930be1161bd2b981180ee59557a
 2018-04-04 22:45:13 +02:00
Bartosz Dziewoński 24e828c627 ve.ce.MWInlineImageNode: Fix rendering of non-linked images 
The bug is easiest to reproduce with `[[File:Example.jpg|link=]]`,
but it also affected video embeds.

jQuery appendTo() method returns the set of inserted elements.
Because `this.$element` is undefined at this point, the `<img>`
was not actually being inserted anywhere, and an empty set was
returned, causing MWInlineImageNode to have no CE rendering.

This was not an issue prior to c4f93b14, because `this.$element`
was being defined by the parent constructor (OO.ui.Element)

We don't actually want to insert it anywhere, this appendTo()
call was a remnant of wrapping code removed in a22aeafc.

Bug: T191406
Change-Id: If1dbf9fef0e0ac9debfdb3049ebcccac70948515
 2018-04-04 21:22:58 +02:00
jenkins-bot 884d0137a0 Merge "Remove <section> unwrapping code from ve.ce.MWTransclusionNode" 2018-04-04 19:05:54 +00:00
James D. Forrester 31730cc5b3 FeedbackTool: Add the ability to vary feedback page for source mode 
Wikis with a local link over-ride configured will need to do so here
for the new message `visualeditor-sourcefeedback-link`; wikis with a
remote link configured will need to update their configuration ahead
of this being deployed, setting $wgVisualEditorSourceFeedbackTitle.

Bug: T157953
Change-Id: Iea7ad8328b03f69e01d7c67ca1ddbb7ae7906288
 2018-04-04 18:11:10 +00:00
jenkins-bot 737a0446be Merge "GalleryNode: Pass through all arguments in describeChanges override" 2018-04-04 17:41:08 +00:00
Ed Sanders 63f94f929f GalleryNode: Pass through all arguments in describeChanges override 
Change-Id: I66bb6bc2a5e95607beee103e925b3fa641f432d5
 2018-04-04 18:00:41 +01:00
jenkins-bot 242eb68b96 Merge "Improve diff description on gallery nodes" 2018-04-04 16:50:03 +00:00
Ed Sanders 1159471730 Improve diff description on gallery nodes 
* Deep compare mw.attrs on gallery nodes, ignoring 'caption'
* Ignore computed attributes on gallery image node

Bug: T191441
Change-Id: If1d9ec15a45001f3c420d20481be43ae38ae201a
 2018-04-04 17:38:48 +01:00
jenkins-bot 459f35924c Merge "DiffPage: Remember chosen diff mode" 2018-04-04 16:34:54 +00:00
jenkins-bot 9c82472546 Merge "MWExternalLinkAnnotation: add CSS to override plainlinks styling" 2018-04-04 15:53:51 +00:00
Ed Sanders b5be51db7e Use cog icon for options 
Bug: T191099
Change-Id: I68638dcfa2531ce01843ae3517d9245deb716769
 2018-04-04 13:22:00 +01:00
jenkins-bot cb0ae22be4 Merge "Define childNodeTypes for gallery image node" 2018-04-03 20:26:00 +00:00
jenkins-bot f04563faba Merge "Show redirect link in preview" 2018-04-03 19:01:02 +00:00
jenkins-bot 6ce963665f Merge "Move redirect building methods from DesktopArticleTarget to ArticleTarget" 2018-04-03 19:01:01 +00:00
Thalia 367509287f Define childNodeTypes for gallery image node 
Change-Id: I9ad78d26dfa16a7bc6da8bc94d7ef4e38fdec409
 2018-04-03 19:40:12 +01:00
Ed Sanders 36e0f8988d Show redirect link in preview 
Bug: T191128
Change-Id: I08fc03dd869e6b074a24698f9037380b26e3dd2c
 2018-04-02 17:34:51 +01:00
Ed Sanders 11eaab48c8 Move redirect building methods from DesktopArticleTarget to ArticleTarget 
These are not specific to desktop.

Also make the static builders static, and move VE target specific
code to caller, such as the click handler.

Change-Id: Ib7e769e3d6d339b9e66e1bc924480b0b0d5db17d
 2018-04-02 17:32:24 +01:00
jenkins-bot 45afe665c1 Merge "Visual diffs in source mode section edits" 2018-04-02 16:05:34 +00:00
jenkins-bot b29de616c9 Merge "Fix source copy when clipboardData not available" 2018-03-29 23:39:19 +00:00
Ed Sanders ec3c6b65c0 Remove <section> unwrapping code from ve.ce.MWTransclusionNode 
Has been fixed upstream in Parsoid.

Bug: T181226
Change-Id: I7dfe228e6d1008c4e66377d501f2e4af72c1813d
 2018-03-29 14:05:32 +01:00
Ed Sanders 58054d49da Fix source copy when clipboardData not available 
Bug: T190881
Change-Id: I8569dec0c03caa30cb7fcbbbfeed126dc9db57e4
 2018-03-29 13:58:00 +01:00
jenkins-bot ea9a0d56df Merge "Update VE core submodule to master (4922429f7)" 2018-03-28 16:32:26 +00:00
Bartosz Dziewoński f8522b7aac Update VE core submodule to master (4922429f7) 
New changes:
4922429f7 Merge all theme overrides into single files

Local changes:
* Update extension.json module definitions for 4922429f7
* Merge all VE-MW theme overrides into single files

Change-Id: Ie8bb4a78c3c50dd4e930f25f6f72bc2f395bd10c
 2018-03-28 09:17:12 -07:00
David Lynch 7f5b6fafb4 MWExternalLinkAnnotation: add CSS to override plainlinks styling 
Was causing the active link highlight to look broken.

Bug: T190582
Change-Id: Ia59e762689211625027367511ffd922f445a13ae
 2018-03-28 10:57:10 -05:00
jenkins-bot 476a590c3c Merge "Parse title in show preview using hack" 2018-03-27 20:29:35 +00:00
jenkins-bot 5b36d88eae Merge "Make edit notices popup wider (320 -> 380)" 2018-03-27 17:24:58 +00:00
Ed Sanders d3e5385944 Visual diffs in source mode section edits 
Bug: T190845
Change-Id: I938352eec8b49f27784c12ddea72bbe69fdd6cb2
 2018-03-27 17:53:54 +01:00
David Lynch d77ea2bf16 DesktopArticleTarget: use -published message instead of -saved 
Bug: T183901
Change-Id: I09f6e44f9f743f079ca5504ec06706c764ce6e25
 2018-03-27 10:49:03 -05:00
Esanders 3cd35b95e9 Make edit notices popup wider (320 -> 380) 
Bug: T184379
Change-Id: Ic68f5e117bb0057bb5fa8b83834707abfbadb3b3
 2018-03-27 14:16:25 +00:00
Bartosz Dziewoński b8bcba8cbe ve.ui.MWMediaDialog: Use dropdown for image type selector 
The dialog is not wide enough to fit four buttons side-by-side.

Bug: T74187
Change-Id: I6a4e5692b5f1b2ca9bb78d4e6c6103036f371a52
 2018-03-27 14:40:39 +02:00
jenkins-bot fe625aa5ea Merge "ve.ui.MWPopupTool: Allow labels of buttons in help menu to wrap" 2018-03-27 11:55:16 +00:00
jenkins-bot 6deaeffa95 Merge "Revert "Make edit notices popup wider (320 -> 450)"" 2018-03-27 11:30:12 +00:00
Bartosz Dziewoński 4fd4a5259b ve.ui.MWPopupTool: Allow labels of buttons in help menu to wrap 
Bug: T190796
Change-Id: I7889119a60133100825d7db4a02e6d0a7c797eba
 2018-03-27 12:31:24 +02:00
Bartosz Dziewoński a0dacccd83 Revert "Make edit notices popup wider (320 -> 450)" 
This reverts commit d5a61eb95d.

Bug: T184379
Change-Id: I0198c6d1faf1474ea0faab7e05ec95cfb43c9206
 2018-03-27 10:13:45 +00:00
Volker E e837512cc6 Replace deprecated 'comment' with 'speechBubble' icon 
Bug: T183600
Change-Id: Iebebba61a099193051cffc11f41e366bdb1c19e1
 2018-03-26 21:14:35 -07:00
James D. Forrester fe525e3bcc *Dialog: Don't set to small size, which is the default 
Change-Id: I3b7a19acd0ee5112d104257bdc1e9ff0e9b4ff24
 2018-03-26 15:02:11 -07:00
jenkins-bot dc3e192179 Merge "Make edit notices popup wider (320 -> 450)" 2018-03-26 21:31:07 +00:00
jenkins-bot 58f9cf7050 Merge "Autosave section title when adding new section in source mode" 2018-03-26 21:19:26 +00:00
jenkins-bot 5f8d287e12 Merge "Autosave recovery prompt" 2018-03-26 20:55:18 +00:00
jenkins-bot 44720da389 Merge "*Dialog: Drop verbose option, ignored since v0.20.0" 2018-03-26 16:18:49 +00:00
jenkins-bot 5325424988 Merge "Match audio & video elements in gallery DOM" 2018-03-26 16:18:46 +00:00
jenkins-bot ce425c1d56 Merge "[BREAKING CHANGE] Use upstream tryTeardown instead of close in MobileArticleTarget" 2018-03-26 16:12:35 +00:00
jenkins-bot 132d3fbaac Merge "Move some deactivation code from DesktopArticle to ArticleTarget" 2018-03-26 16:10:49 +00:00
James D. Forrester 9e01553f0b *Dialog: Drop verbose option, ignored since v0.20.0 
Change-Id: If0bc7946b67aaae97886e8dbd956e9338b0e0b40
 2018-03-26 08:55:03 -07:00
Ed Sanders 95fc150a4f Remove unused static overrides from dialog 
Change-Id: I31f0310baa5c438b17f16749368102d8cede22db
 2018-03-26 15:49:04 +01:00
Ed Sanders 28d8d2923e [BREAKING CHANGE] Use upstream tryTeardown instead of close in MobileArticleTarget 
Change-Id: I33bcc98bc75ab049568de47faceb3f3390df5901
 2018-03-26 15:32:55 +01:00
Ed Sanders 307e6c2922 Move some deactivation code from DesktopArticle to ArticleTarget 
Also rename tryDeactive to tryTeardown.

Change-Id: Ie89d59a62826bcfe3d30ad04f89d3c4211cc34f4
 2018-03-26 15:32:55 +01:00
Ed Sanders f89856f0ba Match audio & video elements in gallery DOM 
Bug: T190631
Change-Id: Ic09927728b449dda43cf115fa9612ebd7a2bf23f
 2018-03-25 22:04:57 +01:00
jenkins-bot 966e46ac80 Merge "Fix the image sizes in ve.ui.MWInternalLinkContextItem" 2018-03-23 05:36:51 +00:00
Ed Sanders f7b0118de0 Fix layout of media info fields 
Bug: T190468
Change-Id: Ic81781318a9003064e7d8f283901d70a5bae6ebc
 2018-03-22 22:15:52 +00:00
jenkins-bot 511dfc41ca Merge "Make save commands only executable when article is saveable" 2018-03-22 17:03:37 +00:00
Ed Sanders 8a974f25e6 Fix the image sizes in ve.ui.MWInternalLinkContextItem 
Remove the image size styles from the class
.ve-ui-mwInternalLinkContextItem-hasImage too

Bug: T97631
Follow up: I84edeec38ecfb90f5d53
Change-Id: I39937bf4ba12f7047545b187c54a1c5fae157e4a
 2018-03-22 17:03:19 +00:00
Ed Sanders 3a56d42901 Make save commands only executable when article is saveable 
Change-Id: Ia22fbae45201254867bf6e8920aff944ba9276b9
 2018-03-22 10:44:30 -05:00
Ed Sanders bfb59e9c8a Follow-Up I84edeec38: Use font-size: 1em instead of unset for invisible templates 
Leaving it unset falls back to 'inherit' which is too large.

Change-Id: I0dd90b247b51070bbe10aad4941a9dc4a7ac60c1
 2018-03-22 13:29:49 +00:00
David Lynch 75af29b57d DiffPage: Remember chosen diff mode 
Use a new preference: visualeditor-diffmode-historical.

Bug: T189896
Change-Id: I0575cc0a86dc0683758d24c0f597834e38cf1095
 2018-03-22 01:41:14 -05:00
jenkins-bot bfd4a5870f Merge "Use single-line editor for image captions" 2018-03-22 01:32:09 +00:00
Ed Sanders a58b529104 Autosave recovery prompt 
Prompts the user before recovering if the document
has been edited since last load.

Bug: T190077
Change-Id: Ibc0e1d1342510fbca57ad599c1816918c84e5487
 2018-03-21 16:23:35 -07:00
jenkins-bot 663b9f9a35 Merge "Remove special font-size treatment following-up UI unified in 14px base" 2018-03-21 21:07:16 +00:00
jenkins-bot e03f3e2c73 Merge "Update icons for new 20px grid" 2018-03-21 20:59:23 +00:00
jenkins-bot 5aa1bb8537 Merge "MWTransclusionNode: describe parameter changes for Visual Diffs" 2018-03-21 20:03:21 +00:00
James D. Forrester ece430258b Update VE core submodule to master (dc98cb7ec) 
New changes:
617708fe1 Update rel attribute checks to be aware of multiple rel values
c22428f81 ve.ce.LinearSelection: Don't throw exceptions only to catch on the next line
406db2ce3 Localisation updates from https://translatewiki.net.
33f94faf7 tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior
d85bf0d68 Use documentFragments when DOM splicing
110519f1c Update documentation now describeChange can return jQuery
ff7fa5fa0 Change http://www.mediawiki.org to https://www.mediawiki.org
09faa4a3d Fix error with tabs per this:
a329edf67 Localisation updates from https://translatewiki.net.
da864cc5e demos: Separate out and fix mobile-dist
380cc90c5 VisualDiffs: Unit test for timeout behaviour
601173c02 Clarify the "Log" button label on the debug bar
c52a2e07e demos: Fix auto-save by only storing doc state if not recovered
1b8d2c457 Auto-save: Save and restore last known selection
9e279e77e Fix deprecated icon name 'alignCentre' > 'alignCenter'

Local changes:
tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior

Bug: T189687
Bug: T189939
Depends-On: I2059d8ce9140b733ee92436de395d735ab06b9df
Change-Id: I3c210112c84e2d2bd8226de3dad195bf17afb4c2
 2018-03-20 16:38:54 -07:00
jenkins-bot cf9ddabe23 Merge "Disable visual diffs on source mode section edits" 2018-03-20 23:02:33 +00:00
Ed Sanders 8bfb270168 Use single-line editor for image captions 
Depends-On: I2be081c766fab41b152d03b43e7e936e3f636166
Change-Id: Ifcdc34826ad81e96c22fd68ceb637107cde24d4a
 2018-03-20 22:51:27 +00:00
jenkins-bot 2c96d24c76 Merge "Avoid jQuery.parseHTML" 2018-03-20 21:44:37 +00:00
jenkins-bot 0ed47a025e Merge "Only use pre-computed measurements for position loading bar" 2018-03-20 21:44:36 +00:00
Volker E d44bb0bc1b Remove special font-size treatment following-up UI unified in 14px base 
Removing `0.8em` VE special base `font-size` for UI as we're unifying
OOUI interfaces to `14px` equals to `0.875em` at user agent default size.

Bug: T97631
Depends-on: I693d168d2ccf2babbcfe8952af3e1c262aa97773
Change-Id: I84edeec38ecfb90f5d53199f3b26fc3f83ab0611
 2018-03-20 20:03:19 +00:00
Bartosz Dziewoński d80099dad1 Update icons for new 20px grid 
Set viewBox to "2 2 20 20" to trim 2px off each side of our
existing 24px icons, therefore aligning them to the new 20px
grid. All of them had been drawn with large margins, so none
of the graphic is lost.

Bug: T177432
Bug: T190151
Change-Id: I23a6daa5dc2d4a9afc50f275da5df370d2319277
 2018-03-20 20:03:11 +00:00
jenkins-bot 9d004c4d35 Merge "Use OOUI 'markup' icon instead of local 'alienextension'" 2018-03-20 19:50:55 +00:00
Ed Sanders 0f56af016d Use ellipsis on toolbar save/publish button 
Bug: T189803
Depends-On: Ic29717a660de5e80ee2a37f583b2a61c11fa87c4
Change-Id: Idaf80ea7e6ae9ffa165a8638af886bf6ab21a7f0
 2018-03-20 19:46:36 +00:00
jenkins-bot cea546b502 Merge "MediaContext: Link filename to file page" 2018-03-20 18:41:09 +00:00
jenkins-bot bb34d650c0 Merge "Improve media context item to show Image/Video/Audio instead of 'Media'" 2018-03-20 18:38:53 +00:00
Ed Sanders 10792e179f MediaContext: Link filename to file page 
Change-Id: Ice3fdd40cd1f7b8ba2841ac326babc7f24a2635e
 2018-03-20 17:45:50 +00:00
Ed Sanders c245dd9ca0 Improve media context item to show Image/Video/Audio instead of 'Media' 
Change-Id: Ie3b7ec62483e725d3ce073095a2a958c1db930d5
 2018-03-20 17:45:48 +00:00
Ed Sanders 78ba8bbe3c Use OOUI 'markup' icon instead of local 'alienextension' 
Change-Id: Id15596ab0013cb2078480bdb4dde25ef8e7ae50b
 2018-03-20 17:27:54 +00:00
jenkins-bot c20a610750 Merge "Factor out isSaveable method from updateToolbarSaveButtonState" 2018-03-20 17:26:39 +00:00
jenkins-bot ff21c17c37 Merge "Remove unnecessary attachToolbarSaveButton override" 2018-03-20 17:25:11 +00:00
Bartosz Dziewoński c99b4a0ad5 ve.ui.Icons: Add missing global "invert" variant 
Bug: T190166
Change-Id: I28cc22d49881a25973b31e5e112130fb21cf4a37
 2018-03-20 16:36:18 +01:00
David Lynch a228991181 MWTransclusionNode: describe parameter changes for Visual Diffs 
Currently limited to single-template transclusions.

Bug: T188389
Depends-On: Id03d6a9866b56c00e11a030ed60b3c6fb7ead3d1
Change-Id: I332b5f5aa789fdc00510e9f03ea96e4058a28961
 2018-03-20 10:35:03 -05:00
jenkins-bot 39a8c9e14b Merge "Restrict width of diff feedback button mobile" 2018-03-20 02:09:11 +00:00
jenkins-bot e23dd5fb6d Merge "Make gallery dialog work with native gallery implementation" 2018-03-19 23:39:00 +00:00
jenkins-bot 5b82bb180d Merge "Fix title preview when not overridden" 2018-03-19 23:24:21 +00:00
Thalia 12cc56400b Make gallery dialog work with native gallery implementation 
Updates the model and re-renders the gallery.

Bug: T150621
Bug: T149602
Bug: T149596
Change-Id: I1e93c3af02eeeff1fcdaa5549cccc61ea755ee04
 2018-03-19 23:55:17 +01:00
Ed Sanders 5e1c024d33 Parse title in show preview using hack 
Really Parsoid should do this for us.

Bug: T189540
Change-Id: Ie3b5d458e7e6611565e5852f351d715a48be521a
 2018-03-19 21:58:33 +00:00
Ed Sanders 81f3c2df38 Fix title preview when not overridden 
Change-Id: I555b057d8f20704c0676646afd03c78ad3353f23
 2018-03-19 21:56:54 +00:00
jenkins-bot 48028e84b9 Merge "Allow ve.ui.MWCategoryInputWidget to use different API" 2018-03-19 21:29:58 +00:00
jenkins-bot 98c9a395ac Merge "Show page title in preview" 2018-03-19 17:09:53 +00:00
petarpetkovic fe8b510232 Allow ve.ui.MWCategoryInputWidget to use different API 
* Provide config option to specify which API
ve.ui.MWCategoryInputWidget will use.
* To be used in Iec79e687eff8c63434054282650c97cc882f348d

Change-Id: Ib8869d4facf8b3210b309200d944fad4508d7eee
 2018-03-19 16:50:27 +01:00
Ed Sanders b80075a5e4 Avoid jQuery.parseHTML 
Change-Id: Iaf5cbe27b8883d6e4c468a3b4dae11438d264894
 2018-03-16 15:43:03 +00:00
Ed Sanders a1dffa2dd7 Only use pre-computed measurements for position loading bar 
Change-Id: I5fc17a432de8030a6154c4e961ac10c73f391a79
 2018-03-16 15:39:21 +00:00
Bartosz Dziewoński 13d77ba557 Remember 'checkboxesMessages' when storing document state 
Bug: T188796
Change-Id: I4785fe2fb7df774735c1bd48c222540a0286dd44
 2018-03-16 01:14:29 +01:00
jenkins-bot 1d227935d9 Merge "Autosave: only try to remove autosave on teardown if the surface exists" 2018-03-14 19:17:30 +00:00
jenkins-bot 79f27a5447 Merge "Clear VE autosave whenever WikiEditor is loaded" 2018-03-14 18:25:48 +00:00
jenkins-bot 3c861d7ed1 Merge "Clear auto-save when switching to fallback wikitext editor" 2018-03-14 17:55:44 +00:00
David Lynch 9762b096c8 Autosave: only try to remove autosave on teardown if the surface exists 
It's possible for some load failure states to cause this teardown at a point
without a surface. I observed it in MobileFrontend, when restbase can't be
contacted.

Change-Id: I13489640759c73dad5730d0bbadbfb2a38cb8e53
 2018-03-14 11:53:10 -05:00
Ed Sanders d0eafd6b8d Restrict width of diff feedback button mobile 
Change-Id: Ia4ceb73efb76d7714102619fce9cd87cf34216f9
 2018-03-14 14:32:37 +00:00
jenkins-bot e4a8c0b61b Merge "Attach deactivate code to namespace tab ('Main'/'Article')" 2018-03-14 09:19:16 +00:00
Ed Sanders c6653b6a2d Show page title in preview 
Bug: T189540
Change-Id: Idc203f7fcafcf944108938168b492e90091e3255
 2018-03-13 10:15:16 +00:00
jenkins-bot 540cb864ca Merge "ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image" 2018-03-12 12:28:10 +00:00
Ed Sanders e0419f8388 Autosave section title when adding new section in source mode 
Change-Id: Idcbe2f12e3eb0bb85e2c986885bd8084b16dbe5b
 2018-03-12 12:25:12 +00:00
Ed Sanders 4fc2b32b17 Disable visual diffs on source mode section edits 
Bug: T183938
Change-Id: I0d03c47e9b4c30760b7d3bd7bf90d91e79eb8569
 2018-03-10 22:54:54 +00:00
Ed Sanders e78379a395 Attach deactivate code to namespace tab ('Main'/'Article') 
Bug: T189380
Change-Id: I9f05722b9a1c740f9f982d9c5690d48046f19fdd
 2018-03-10 19:07:11 +00:00
Ed Sanders c3c3c60f1f Clear VE autosave whenever WikiEditor is loaded 
Bug: T189381
Change-Id: I21a76dc32327d6c6e72a793d9b579cb7b6a5e32e
 2018-03-10 18:34:17 +00:00
Ed Sanders ec6d9b235a Clear auto-save when switching to fallback wikitext editor 
Bug: T189381
Change-Id: Id89fa2a673ad8aef3826c0ef862770bf522bbdcf
 2018-03-10 18:04:44 +00:00
jenkins-bot 2ae3f5f1c2 Merge "ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption" 2018-03-10 17:28:34 +00:00
Bartosz Dziewoński 3c676013f8 ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image 
Currently this only handles the caption, but there will be more.

Change-Id: Ia8a25de89375d0ba873f4891b053c7aceab15534
 2018-03-10 17:16:16 +00:00
Bartosz Dziewoński 26e7728272 ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption 
Overriding ve.ce.BranchNode#onSplice seems pretty scary, some bug
could cause two captions to be inserted and it wouldn't even be
visible in the editor.

Instead, allow normal splice handling to happen when the caption is
added/removed, and only override the position where it is inserted
(to account for the image node this.$a).

The caption node is already removed from DM/CE if the image type is
changed to one that doesn't have captions, and even if that failed it
is also hidden in CSS, so we don't need to handle this.

Change-Id: I54f52b288118d692708311512dd674cc85d5d9e3
 2018-03-10 17:16:16 +00:00
Ed Sanders 9678cdc7c8 Factor out isSaveable method from updateToolbarSaveButtonState 
Change-Id: Ic1922ed26bae26a76e8149d48f3fb27fa9ba4330
 2018-03-10 16:20:30 +00:00
Ed Sanders 8b208c80d5 Remove unnecessary attachToolbarSaveButton override 
It's identical to the code inherited form ArticleTarget.

Change-Id: I7fe7a48b0614f2ac2665ece042bb95a6f77303ad
 2018-03-10 16:20:30 +00:00
jenkins-bot 00eb598352 Merge "Update rel attribute checks to be aware of multiple rel values" 2018-03-09 21:44:53 +00:00
jenkins-bot 04e5f6f208 Merge "LinkCache: styleParsoidElements find mw:WikiLink with ~=" 2018-03-09 21:44:52 +00:00
David Lynch b6c6d10d1e ce.MWTransclusionNode: increase invisible selector specificity 
5f6664e2 in VE core changed the specificity for some of the rules this
expected to override.

Bug: T189267
Change-Id: I510e151cc431c321d1d45fde9030d56f059d84ab
 2018-03-08 19:27:52 -06:00
David Lynch 4e10d5b975 Update rel attribute checks to be aware of multiple rel values 
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.

Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
 2018-03-08 14:34:56 -06:00
jenkins-bot 8e79d85583 Merge "Blacklist Web of Trust junk from being added to pages" 2018-03-08 00:33:48 +00:00
David Lynch f8c5608caf LinkCache: styleParsoidElements find mw:WikiLink with ~= 
`noopener` being added to the rel caused issues.

Bug: T189175
Change-Id: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
 2018-03-08 00:14:16 +00:00
Bartosz Dziewoński b05ac142c6 Blacklist Web of Trust junk from being added to pages 
Bug: T189148
Change-Id: Icc4b2d0ddf5104e26a3f563816f6f971d71e2531
 2018-03-07 22:12:43 +01:00
Ed Sanders 045f3b7640 Follow-up I5357a909: Fix logic for autosave from edited state 
Bug: T189071
Change-Id: I5439a73ffcf26795f58625720b1f1667ee3965cc
 2018-03-07 18:43:28 +00:00
Jforrester 16437646fe Merge "Update VE core submodule to master (ca771b8bc)" 2018-03-06 13:14:21 +00:00
James D. Forrester d144599cea Update VE core submodule to master (ca771b8bc) 
New changes:
7551f6c66 [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

Local changes:
Follow-through rename of IndexValueStore->HashValueStore

Bug: T188900
Change-Id: If60d0c637fe92f0e7afe916c064fafb17980d063
 2018-03-06 12:55:30 +00:00
jenkins-bot eb125877e2 Merge "Revert "For empty / whitespace-only headings, output <p> instead of <h#>"" 2018-03-06 12:22:31 +00:00
Ed Sanders a274bdb8f7 Revert "For empty / whitespace-only headings, output <p> instead of <h#>" 
Parsoid now handles empty headings for us in
scrub_wikitext mode (which we use).

This reverts commit 884f301aa0.

Bug: T187913
Change-Id: I8690bbced64be76622929f78f9c9e0d8f85d4be8
 2018-03-05 23:27:52 +00:00
David Lynch 09237b71ef mwExample: add test case for cross-document numberedlink paste 
Bug: T188429
Change-Id: I722f30f07abd65dba93e9ba297b6933ef8ca79c2
 2018-03-05 13:35:25 -06:00
David Lynch 795b428477 MWNumberedExternalLinkNode: set an explicit type 
This lets copy-paste between documents retain the numbered status rather than
falling back on pasting "<a>[3]</a>".

Update the part of LinkCache which selects on mw:ExtLink, so it will handle
possible multiple values in the link rel.

Bug: T188429
Change-Id: Ia5e4c9fa45e94da9cbfcd2a42d017d0fda1c511f
 2018-03-05 11:59:41 -06:00
Ed Sanders 4c759e2587 autosave: Handle switched document with no transactions 
Always store immediately if fromEditedState is true. Also
now that we only store if there is state to recover, remove
the check for transactions before deciding to show the notification.

Change-Id: I5357a9098b91e303f5c71881ea03a080d2969fff
 2018-03-04 23:40:24 +00:00
Ed Sanders 007bb6fa09 Refactor diffpage init 
Avoid re-rendering the diff if it hasn't changed.

Change-Id: Icbc8eb58625cf7c5485d0045e26993a170016309
 2018-03-04 14:45:33 +00:00
Ed Sanders 43ea4c2b51 Fix infinite recursion in positionDiffElement 
updateSize eventually calls setDimensions, which calls
positionDiffElement, so protect against infinite recursion.

Change-Id: I07992f337394712000e6e12c637c6e1442869722
 2018-03-03 18:47:08 +00:00
Ed Sanders d5a61eb95d Make edit notices popup wider (320 -> 450) 
Bug: T184379
Change-Id: Id2df8f8d162db3389206666fa07ea4cc0be8cdec
 2018-03-02 13:29:54 +00:00
jenkins-bot ad6ded970f Merge "ve.ce.MWBlockImageNode: Fix handling of borders" 2018-03-02 13:15:50 +00:00
Ed Sanders c8d0f62095 fetchSpecialCharList: Set directionality 
Specifically, set arabic(extended) and hebrew to 'rtl'.

Logically depends on I14abd3e0c0d23f79aa01d96c216eea913024b4c8
to set the dir attribute in UI.

Bug: T56310
Change-Id: I1c7e28d3d2f20ca84115be6d49650cd9a81d78dd
 2018-03-01 23:22:45 +00:00
jenkins-bot e7d7d5bab1 Merge "autosave: Don't store initial document state until first change" 2018-03-01 18:47:39 +00:00
jenkins-bot fbbda2a480 Merge "ve.ce.MWBlockImageNode: Remove unnecessary #setupSlugs override" 2018-03-01 18:39:48 +00:00
Ed Sanders 11ac2736a1 autosave: Don't store initial document state until first change 
1. It wastes valuable time during setup.
2. If a user reloads the page without making changes we
   should give them the latest html from the server to
   minimise the chance of an edit conflict.

Change-Id: I9a1f8cfd65ef2552fe2c3d6d2bbf975851b52003
 2018-03-01 18:25:10 +00:00
Bartosz Dziewoński d239b6ee6a ve.ce.MWBlockImageNode: Fix handling of borders 
After change 89aecd54ba (2014),
there is no 'border' value for the 'type' attribute, instead
there is a 'borderImage' attribute only present when 'type'
is 'none' or 'frameless'.

Change-Id: Id87ba09b647f5f69b1c9350209e66acdea2c9d69
 2018-03-01 01:08:30 +01:00
Bartosz Dziewoński 5b7c93f0d5 ve.ce.MWBlockImageNode: Remove unnecessary #setupSlugs override 
MWBlockImageNode already can't have any slugs:
* It can't have inline slugs, because it can't directly contain
  content (`this.canHaveChildrenNotContent()` is true)
* It can't have block slugs, because it can't contain paragraphs
  (`this.isAllowedChildNodeType( 'paragraph' )` is false).

(The only thing it can contain is a mwImageCaption.)

Change-Id: Ice6505da2356f004ef048ed0b1a9e03d08af02d1
 2018-03-01 01:08:30 +01:00
jenkins-bot 6155cd4434 Merge "Remove autoGenerated hack" 2018-02-28 18:41:29 +00:00
jenkins-bot 9840316ee9 Merge "Centralize Parsoid resource name parsing logic" 2018-02-28 15:09:20 +00:00
Ed Sanders 90b6a1b5cf Clarify autosave comment 
Change-Id: I0bdaf989886be8537ea45237ceea88a5cca11fc1
 2018-02-28 14:36:58 +00:00
Ed Sanders 19d9e9eb98 Tag TODO comments with bug number 
Change-Id: I965e8d4bed4fdfa24738ca5cce0ae3f51e7f2b40
 2018-02-28 14:36:42 +00:00
Bartosz Dziewoński 98a1bb09c0 Centralize Parsoid resource name parsing logic 
Let's keep the ugly regexp and the comments about why we do this in a
single place.

This is mostly without behavior changes, with three exceptions:
* ve.dm.MWImageModel#attachScalable now passes a title with spaces
  instead of underscores to the Scalable (this doesn't matter because
  it's normalized to use spaces later anyway).
* ve.dm.MWImageNode#getFilename now returns a title with spaces
  instead of underscores. This is used in some API queries and when
  rendering thumbnails for missing files, and this format is actually
  more correct for both of these.
* ve.dm.MWTemplateModel now URI-decodes the template title. This
  actually fixes a bug where trying to edit a template transclusion
  whose title contains a '?' would throw an exception about invalid
  title.

Also, clarify that the return value of ve.dm.MWImageModel#getFilename
and ve.dm.MWImageNode#getFilename is different :(

Change-Id: I8e09015cea82308017ed925ec755b7231518126e
 2018-02-28 03:01:05 +01:00
jenkins-bot 8727ecd181 Merge "Do not use deprecated jquery.byteLength" 2018-02-27 22:10:23 +00:00
jenkins-bot b5ceb1b956 Merge "ve.ui.MWSaveDialog: Allow limiting comment length by characters rather than bytes" 2018-02-27 22:06:01 +00:00
Bartosz Dziewoński 974ea82c50 Do not use deprecated jquery.byteLength 
Change-Id: If3f921d60563bd614c269d1d26b745161f8cfc7b
 2018-02-27 22:35:29 +01:00
Bartosz Dziewo??ski dbfe6c0b5a ve.ui.MWSaveDialog: Allow limiting comment length by characters rather than bytes 
Bug: T185948
Change-Id: I882d69beb1cd442868c8d73988f5b3a2bbb084bc
 2018-02-27 22:35:08 +01:00
jenkins-bot 12323a022e Merge "autosave: Use upstream methods in ve.dm.Surface" 2018-02-27 21:03:52 +00:00
jenkins-bot b3adaa5fc1 Merge "Show notification when document is recovered (or fails)" 2018-02-27 21:03:51 +00:00
Ed Sanders c670ce76ee autosave: Use upstream methods in ve.dm.Surface 
Change-Id: I150b21d7767153d8457b5da658bb8b51b5464aa9
Depends-On: I859b57aef9d591597956f3d942dd2cf1b0aecee0
 2018-02-27 20:54:59 +00:00
Ed Sanders a46b30a161 Show notification when document is recovered (or fails) 
Change-Id: Id2f6651ba7743c05043bbbe64cd9cb7bd762d74b
 2018-02-27 20:54:18 +00:00
jenkins-bot c44390e6f8 Merge "Use session storage to auto-save" 2018-02-27 20:20:31 +00:00
jenkins-bot 92470ae024 Merge "Always set sourceMode=true on dm.MWWikitextSurface" 2018-02-27 16:49:09 +00:00
Ed Sanders 76caef6b4b Use session storage to auto-save 
Ensure we start with the same HTML (i.e. if an edit has
been made since the crash-recovery):
* Whenever an article target is activated, stash the initial
  document html, other parsoid response data, and the request
  parameters (pageName, mode, section) in session storage.
* Whenever an article is fetched through the target loader,
  recover from session storage if the request parameters match.

Store transactions:
* On document transaction (debounced) append the latest
  changes to session storage.
* If a document state is recovered from session storage,
  attempt to re-apply the stored transactions.

Clear transactions:
* Whenever the target is torn down (i.e. save, deliberately
  closing the editor to go back to read mode)

Other:
* If writing to session storage fails once, disable future
  attempts for that session (assume storage quota exceeded)
* Disable tempWikitextEditor when recovering. We don't have
  the transaction code loaded yet to perform the recovery.

Bug: T57370
Depends-On: I3832243fc347a99641fcb7e39a887a153c9a3b22
Depends-On: I448fb566fe9f7f5b5a76e88b70ca000e3d35b415
Change-Id: Id9d877f903cf4796a52f90991c030417a9f8786f
 2018-02-27 12:19:06 +00:00
Ed Sanders 366219e953 Always set sourceMode=true on dm.MWWikitextSurface 
Change-Id: Id46d5ef9c8a585784b8fbd55418d012fff96823f
 2018-02-27 12:19:06 +00:00
Ed Sanders 31f7015260 Whitelist style tags from Parsoid, e.g. TemplateStyles 
Bug: T188143
Change-Id: I7a30d8a8c40de8b786d59c8bf0ebcb77f2baeb2a
 2018-02-26 16:52:01 +00:00
jenkins-bot 72756d5a26 Merge "MWImageNode: getHashObject -> getHashObjectForRendering" 2018-02-24 13:42:15 +00:00
Ed Sanders d17121d1f3 MWImageNode: getHashObject -> getHashObjectForRendering 
The latter was introduced for this very purpose: defining
which attributes affect the rendering (in this case the
thumbnail URL). getHashObject should be reserved for making
full semantic comparisons.

Bonus: Don't distinguish between block/inline images
for URL caching purposes.

Change-Id: I6e6d2547a0d110f07c4d18b8179c168d8c251059
 2018-02-24 12:44:53 +00:00
David Lynch abe3d0a4a5 DiffPage.init: Enforce a valid diff mode 
Bug: T173400
Change-Id: I48b97e10fc6c6e2ca84563b58dd0bb8f42fa251f
 2018-02-22 11:48:37 -06:00
jenkins-bot 3d93d195c7 Merge "Drop IE10 support" 2018-02-22 00:55:50 +00:00
Ed Sanders 05a504887d Drop IE10 support 
Change-Id: Ib1cb8fb32c499ba0bdc87ec55e1e2e95d2eb39ec
Depends-On: I68c882e64fba95d5e1bf41f64658fcef7524dcf5
 2018-02-22 00:47:38 +00:00
Jforrester 2e87e03a29 Merge "ve.ce.MWGalleryNode: Ensure we always have a focusable element" 2018-02-22 00:33:23 +00:00
jenkins-bot c5cc11079b Merge "ve.ui.MWGalleryDialog: Handle galleries with 0 items" 2018-02-22 00:31:30 +00:00
Bartosz Dziewoński 180eb91f3f Increase selector specificity for .ve-ce-focusableNode-invisibleIcon 
Otherwise our width/height rules are overridden by OOUI styles.

Change-Id: I2bbf81231615e6fcfd95573f5f590b5101e66bdf
 2018-02-21 22:30:45 +01:00
Bartosz Dziewoński a5e2f60d7e ve.ce.MWGalleryNode: Ensure we always have a focusable element 
For galleries with 0 items, this would previously return an empty
jQuery collection, which caused funny rendering issues later.

Bug: T75230
Change-Id: Ia68e4f1b74b5ec494fa3d86f0b792f69eadb02fb
 2018-02-21 22:22:49 +01:00
Bartosz Dziewoński 3d422bac2a ve.ui.MWGalleryDialog: Handle galleries with 0 items 
We still don't allow inserting such galleries, but we can handle them
in existing content.

Bug: T75230
Change-Id: I5d7350f00871ac295b0ebc00a633b44570347d85
 2018-02-21 22:11:41 +01:00
jenkins-bot dd94837192 Merge "MWTemplateTitleInputWidget: recover gracefully if TemplateData not present" 2018-02-21 18:14:12 +00:00
David Lynch bd64b58071 MWTemplateTitleInputWidget: recover gracefully if TemplateData not present 
Bug: T187917
Change-Id: Ica0c853e1a7bc908651260df115d59d1939a7939
 2018-02-21 11:53:56 -06:00
jenkins-bot 8d3e702976 Merge "Disable tempWikitextEditor for section=new on talk pages" 2018-02-21 01:29:58 +00:00
Derk-Jan Hartman 249c52b6a4 Hide historical diff controls when UA doesn't support JS 
Bug: T187780
Change-Id: If29974323ef21016edbbb66870914a6dc37e7bbb
 2018-02-20 16:54:31 +00:00
jenkins-bot 8f33fc6225 Merge "Add clearfix to diff page's visual diff element" 2018-02-20 16:52:39 +00:00
jenkins-bot d040645244 Merge "Avoid jQuery.parseHTML" 2018-02-20 16:50:06 +00:00
Ed Sanders 7fe496d8ef Avoid hiding generated #toc 
Bug: T187636
Change-Id: I713479616feddb01c48c9bb6dda2f9c4aaf182e0
 2018-02-20 16:18:27 +00:00
Ed Sanders fcf6ea9e67 Add clearfix to diff page's visual diff element 
Bug: T187687
Change-Id: I4de925964fde7b0fffc6540ba821f9a8162cffe7
 2018-02-20 15:04:25 +00:00
Ed Sanders ee5b80aeee Avoid jQuery.parseHTML 
Bug: T187713
Change-Id: Ic156d6fb670fa2f79cf3c1d5fe0c6272b53b6440
 2018-02-19 15:41:20 +00:00
Ed Sanders f2e7361460 Disable tempWikitextEditor for section=new on talk pages 
The temp editor doesn't know about the title input
widget yet, so disable for now.

Bug: T185633
Change-Id: I3e44dcc30ee8372080c7cd8c5fc27eb167e24fc6
 2018-02-16 18:32:41 +00:00
Ed Sanders 33858c6818 MWSaveDialog: Another check to see if visual diff is still visible 
Bug: T187282
Change-Id: Ia29a335bf6b1bad0eeb55b54094475c7fcc18dfe
 2018-02-16 15:21:12 +00:00
James D. Forrester dd3dddb98c Follow-up 0a7a845a4: Missed one 
Change-Id: I252cb6678df9df503e07b635384a713f052a8abe
 2018-02-14 14:25:07 -08:00
jenkins-bot 0c05b46bff Merge "Remove IE9 workaround" 2018-02-13 17:37:29 +00:00
Ed Sanders e0b7fbe6f8 NWE preview: Avoid skin style clash 
Bug: T187075
Change-Id: I6ac6eebca3bd89ce19fb64f6e95809c4d595bc8b
 2018-02-13 16:22:56 +00:00
Ed Sanders 119e9ef0f6 Remove IE9 workaround 
Change-Id: Ifcb1690934ece7d373c764591e00740d6f1238ee
 2018-02-13 10:45:16 +00:00
James D. Forrester b6c18b2d49 Don't try to insertMetas at 0,0, just at 0 now (lest we crash) 
Bug: T187112
Change-Id: I56e39276637ea018c1ec742d833d115ee881a5d5
 2018-02-12 19:32:23 +00:00
Fomafix 8079d081d0 Remove /* global confirm, alert */ 
The browser functions alert() and confirm() are not used.

Change-Id: I1b069937fe1548298d55a3e6616e189b72c3e8fa
 2018-02-12 10:49:11 +01:00
jenkins-bot 3d0d5667bc Merge "ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection'" 2018-02-08 23:58:24 +00:00
jenkins-bot b2400138a5 Merge "ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable" 2018-02-08 19:44:36 +00:00
Bartosz Dziewoński 5ce321bc60 ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection' 
Bug: T185917
Depends-On: I39bbbce20336a1286a07bf8032acdfb8a7e0cdb6
Depends-On: I05086ddce2ddd857ff88eba75cfdb6bf877bd924
Change-Id: I1e7ed33275d0a97f4b0b3c9756bbef2f3f3ad73c
 2018-02-08 19:50:17 +01:00
Bartosz Dziewoński 5f36aac24c ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable 
Change-Id: I1292021a4a8dee70cfa203a040f176996e4a13ff
 2018-02-08 19:48:33 +01:00
Ed Sanders b14480f49b Assume wpTextbox1 has an API registered already 
Bug: T186743
Change-Id: I19b085dfbf6229854c3d70807ffe83685ca811fe
 2018-02-07 20:12:51 +00:00
Ed Sanders cefa0ebf7b Add trailing linebreak to NWE's temporary wikitext editor 
Bug: T185632
Change-Id: I8225b08484e535668e8b0bd33eb3b8b09b80ff35
 2018-02-02 11:10:18 +00:00
jenkins-bot 7dd6aea2d6 Merge "NWE: Use internal paste in compatible browsers" 2018-01-30 17:41:05 +00:00
jenkins-bot e613c8edc4 Merge "Load modules for preview" 2018-01-30 17:40:45 +00:00
jenkins-bot 8e1ec692d8 Merge "textSelection: Implement getCaretPosition" 2018-01-30 16:48:00 +00:00
jenkins-bot 5e2e0013ae Merge "Implement simple methods from $.textSelection API" 2018-01-30 16:47:19 +00:00
Ed Sanders 9e16e1cbd4 textSelection: Implement getCaretPosition 
Bug: T185992
Depends-On: Id60f4b8aa177564f5252508ce6cff2424eb03fc8
Change-Id: I1a1a953dfbb299a15ba9d4d3e624e6779e72d11c
 2018-01-30 10:54:02 +00:00
Ed Sanders aeb4f2f2b7 Implement simple methods from $.textSelection API 
This should make it easier for some gadgets to work
with NWE.

Bug: T185992
Change-Id: Ic60440f345b8226fb5acaeb966e25eb003ad7866
 2018-01-30 10:53:49 +00:00
Volker E e64ede5b49 Remove unnecessary and low-contrast opacity 
Change-Id: I4853a77679687d23059c118914df42a1d3c2785c
 2018-01-29 23:51:08 -08:00
Ed Sanders 9770c80615 Load modules for preview 
Bug: T147702
Change-Id: I94f6bdf122d4e2c9fba3103f36c438980ce8228d
 2018-01-29 22:35:00 +00:00
James D. Forrester 4ce103abb9 Update VE core submodule to master (c5fddd508) 
New changes:
21a5d55b8 [BREAKING CHANGE] Store metadata as block nodes in the main data list
2f9868aae Localisation updates from https://translatewiki.net.
7a224cf4b Remove <style> tags from pasteTarget ASAP
fb4e894b6 Workaround missing child selector in OOUI for menuLayout
fa4f35281 rebaser: Fix sequencing of server operations
931ee29f6 SurfaceSynchronizer: Also translate selections that are not mentioned in the change
d232b8f04 Disable undo/usurp within SurfaceSynchronizer
d1b7fc597 ve.dm.Change: Truncate stores as well as transactions on conflict
7606f684d rebaser: Only apply artificial delay to submitChange events
9473e8b42 Toolbars: Replace $.width with clientWidth/offsetWidth
abb8f2075 ve.ui.DesktopContext: Remove unused CSS
050414205 ve.ui.DesktopContext: Remove old unnecessary CSS
7b8cbb830 Failing test case for losing annotations
5447d33e4 CommentNode: Protect against call after teardown
bf98ca2b6 Rebaser: Use better hack for disabling history commands
90c07f46c Rebaser: uninitialize fully
2a59016e4 Move updatingName recursion guard out of debounce

Bug: T56299
Bug: T185532
Bug: T185544
Bug: T185599
Bug: T185716
Bug: T185747
Change-Id: I45251811e3fbb3323a25ca5cf364e4cb94aa1d01
 2018-01-29 08:43:08 -08:00
jenkins-bot d7d026425c Merge "Make visual diffs the default in visual mode" 2018-01-27 00:21:24 +00:00
Ed Sanders 35311ad66d NWE: Use internal paste in compatible browsers 
Bug: T185730
Change-Id: I9410707e6e491fe1cbe0b367fccb94a29a1b3145
 2018-01-25 17:40:26 -08:00
jenkins-bot 97fbd5619c Merge "Public API for the tempWikitextEditor" 2018-01-24 00:53:11 +00:00
jenkins-bot a77eea97b3 Merge "Sync tempWikitextEditor just before building target, not on every change" 2018-01-24 00:50:41 +00:00
jenkins-bot 14e557e936 Merge "Use jQuery 3 .catch( fn ) instead of .then( null, fn )" 2018-01-24 00:06:11 +00:00
Ed Sanders 8afe6c5c6d Public API for the tempWikitextEditor 
Allows users to know when the widget has been constructed,
and access it (e.g. to set an initial selection)

Bug: T185279
Change-Id: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
 2018-01-23 15:30:51 -08:00
Bartosz Dziewoński a0e2afef8e Use jQuery 3 .catch( fn ) instead of .then( null, fn ) 
Change-Id: I676eec0acf25690c2b2dd0b9a414be5fee887395
 2018-01-23 15:25:15 -08:00
Ed Sanders d294006d7b Sync tempWikitextEditor just before building target, not on every change 
Also ensure tempWikitextEditor is always torn down, even if
target setup fails.

Change-Id: Idc30a9dc00491b8c85353d73cb9ff70afea1d51c
 2018-01-23 15:13:10 -08:00
jenkins-bot f52ee56a02 Merge "Toolbars: Replace $.height with clientHeight/offsetHeight" 2018-01-23 23:01:37 +00:00
Ed Sanders 154f49e964 Toolbars: Replace $.height with clientHeight/offsetHeight 
Bug: T185599
Change-Id: I43fbce8f221553e9ae03f8385f39a19de01e8eb7
 2018-01-23 12:32:16 -08:00
jenkins-bot 53cd2346dc Merge "MWWikitextStringTransferHandler: Perform Parsoid cleanup on result" 2018-01-22 23:43:18 +00:00
David Lynch d97b734352 MWWikitextStringTransferHandler: Perform Parsoid cleanup on result 
Parsoid markup delivered as a result of a paste was being handled differently.

Bug: T183173
Change-Id: Ic563d2c5cd1f663f35860892b369fb7ba34b9c55
 2018-01-22 14:43:19 -08:00
Ed Sanders 3077bbe51c Remove Firefox support comment 
This line isn't solely for supporting FF52, that is the order
in which it is called (move after attach, not before),
but that matches all our other widgets, so not sure
it needs commenting.

Change-Id: I6f3cc5687f1e4b995dff700d0765d14de1927d51
 2018-01-22 11:27:46 -08:00
jenkins-bot 97b04fbea5 Merge "NWE: Don't attempt to set selection on unattached textarea" 2018-01-22 19:22:11 +00:00
Ed Sanders f2568c8d7d NWE: Don't attempt to set selection on unattached textarea 
Prevents an exception being thrown in Firefox <= 52.

Bug: T185304
Change-Id: Ic9a43e3cf12d4cc566cebb328f8e807e464af634
 2018-01-22 18:58:26 +00:00
David Chan c7b76329ad Use ve.dm.MetaList without explicitly requiring metadata index 
For future compatibility with Ib5174b0dcba1c24f44d889e08140bee31a064011 .

Change-Id: I15f252ce5d36bc0c38c5f5035e5176bf5e6d96e5
 2018-01-21 18:33:28 -08:00
David Lynch a52dc16244 Update TitleInput's getTitle to getMWTitle 
cb92c72c63274b332dc81edf473b1b3979ab4bdf in MW core changed this.

Bug: T185231
Change-Id: I9084a11bd40e46bddbcd1922ff549703bc90f60f
 2018-01-18 11:39:23 -06:00
jenkins-bot d5bf4d41de Merge "Remember preferred diff viewer" 2018-01-18 15:37:35 +00:00
jenkins-bot 31e7006610 Merge "getSelectedItem() -> findSelectedItem()" 2018-01-17 17:29:36 +00:00
Ed Sanders a1e2cb237c Resize link context item after getting description 
Descriptions can run to more than two lines.

Bug: T183650
Change-Id: I3d0a5787cab19abc4851340b08fe4a109e7aec31
 2018-01-17 16:06:28 +00:00
Ed Sanders 0169701257 getSelectedItem() -> findSelectedItem() 
Change-Id: Idf90335d06800b690063c7b2a781e822f0ee7ba9
 2018-01-17 13:39:13 +00:00
Ed Sanders e70fe7c1a1 Make visual diffs the default in visual mode 
Bug: T178248
Change-Id: I9fe22862d4415df034a0054f934c9ebd1d731a5d
 2018-01-17 13:31:07 +00:00
Ed Sanders 7661081ab9 Remember preferred diff viewer 
Separate the preference by surface mode, so you can
use a different preference for NWE.

Bug: T178691
Change-Id: Ib8494a4562ce766a7c8ef7ec1447d06f5d0f17c5
 2018-01-17 13:31:07 +00:00
jenkins-bot 140ec5f2ab Merge "NWE: Show temporary wikitext input widget while loading" 2018-01-16 18:13:47 +00:00
Ed Sanders b1ea5d618a Don't pass wikitext to requestPageData if unmodified 
Bug: T184875
Change-Id: I41a72a9c7546fafc834bf837e507d9359872ff11
 2018-01-14 16:16:47 +00:00
Arlo Breault 25e3662c00 Remove autoGenerated hack 
Reverts some of 471e40e

Depends-On: I2b5c7ff552b3322be74f79a81936c41d58fecabc
Change-Id: Ibfcd4ced6c58c1cd0d362af3bdb43ce4e6879941
 2018-01-12 11:52:42 -05:00
jenkins-bot 2091b8634a Merge "Use section fragment after-save even if the query is empty" 2018-01-10 21:41:59 +00:00
jenkins-bot 2ea64bdd27 Merge "Change save dialog accesskey to be entirely off the trigger" 2018-01-10 21:30:51 +00:00
Ed Sanders 886faf2adc NWE: Show temporary wikitext input widget while loading 
Bug: T184614
Change-Id: I2e4964cb6329660957815dcb9a74d2ad24d5256b
 2018-01-10 21:34:53 +01:00
jenkins-bot 9768750cd3 Merge "Use findItemFromData instead getItemFromData" 2018-01-10 19:54:30 +00:00
David Lynch 64944c119a Use mw.storage instead of localStorage 
mw.storage catches errors, so we won't crash horribly when the user has
localStorage disabled / full.

Bug: T181822
Change-Id: I212994eb535b9a8fb5f6c09deaa10b16c3d7f10e
 2018-01-10 11:44:24 -06:00
David Lynch a89c79dc79 Change save dialog accesskey to be entirely off the trigger 
Accesskeys in this situation are unreliable cross-browser. Firefox won't
trigger the accesskey inside the dialog. We can manually simulate it, via the
existing trigger.

Bug: T121183
Change-Id: Ib919d8b9fcd9324a517037bcc6ef93a26d1488b9
 2018-01-08 11:52:06 -06:00
Ed Sanders c41fd90a15 MWImageModel: Check selectedNode exists before asking for property 
Bug: T180521
Change-Id: I1c10929abd6f5c4afa03a65904bc76fc82f8fcbb
 2018-01-08 15:31:13 +00:00
David Lynch 874ba30ce8 Use section fragment after-save even if the query is empty 
Bug: T181075
Change-Id: If2d1107982d3f947330c750c635ee221ab71610f
 2018-01-05 11:55:38 -06:00
Bartosz Dziewoński 23158de319 Fix context menu for mobile TargetWidgets 
Depends on Ica66325a8267d14f25fbc537b956573d1d3cc336 in VE core.

Bug: T157084
Change-Id: I9d9839d7e96eb1ef254e11554acfb955750a2915
 2018-01-04 16:53:40 +00:00
jenkins-bot 683ac88fcc Merge "doc: Bump copyright year" 2018-01-03 19:20:07 +00:00
James D. Forrester 0a7a845a42 doc: Bump copyright year 
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
 2018-01-03 17:45:07 +00:00
jenkins-bot fad1466d84 Merge "Fix editfont size in source mode" 2018-01-03 01:12:25 +00:00
jenkins-bot 75d4300ba6 Merge "ve.ui.MWSettingsPage: Fix doc comment" 2018-01-02 20:11:33 +00:00
Ed Sanders 459ce75cb2 Fix editfont size in source mode 
Bug: T182320
Change-Id: I777a1a80cb9887bc473aecb5d7b25fd6454a3d60
 2018-01-02 19:20:18 +00:00
Bartosz Dziewoński 4987c07793 Move things that are not modules out of modules/ directory 
* Move SpecialCollabPad.php to /.
* Move screenshots for BetaFeatures to images/.
* Move localisation messages to i18n/.

Change-Id: I874ae135a3ac58118c3dea105136c8c8b6fb41bc
 2018-01-02 11:05:23 +01:00
Bartosz Dziewoński 5f7e60e938 Remove unused files loading-ltr.gif, loading-rtl.gif 
No longer in use since 6d8fbd8221.

Change-Id: If0392c49985fdd5b07c336e17eb5360e0a71770a
 2018-01-02 10:47:32 +01:00
Translation updater bot 93b4371954 Localisation updates from https://translatewiki.net. 
Change-Id: I304a6848db09772c9603b19a1dbc386f80f0d109
 2018-01-01 09:21:05 +01:00
Bartosz Dziewoński 578c55b7c1 ve.ui.MWSettingsPage: Fix doc comment 
Change-Id: Iff4e8854124340a30081009221cde5b2831c81f3
 2017-12-30 03:26:13 +00:00
Translation updater bot 327f3c1219 Localisation updates from https://translatewiki.net. 
Change-Id: I809d676bdb78d17f0a6866ca05f021c3e9c64bdf
 2017-12-29 10:07:04 +01:00
Translation updater bot f7c0a70b9e Localisation updates from https://translatewiki.net. 
Change-Id: I39cb150918eaee64b034e88a4726a31c04f29331
 2017-12-28 10:00:15 +01:00
Prateek Saxena ecd663c4a0 Use findItemFromData instead getItemFromData 
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: I379da96a42c440c7d2d5dc2f3de2773c03546c04
 2017-12-28 11:53:29 +05:30
Translation updater bot 6e46084b89 Localisation updates from https://translatewiki.net. 
Change-Id: Ife309d8d0cce6332fee9ff23796a92c3d8c6f53b
 2017-12-27 10:32:31 +01:00
Translation updater bot 035ccf0d7e Localisation updates from https://translatewiki.net. 
Change-Id: Ic3ef5d2e35085be6121a442740ab8c6fd188721d
 2017-12-23 22:27:16 +01:00
Translation updater bot 906956aae7 Localisation updates from https://translatewiki.net. 
Change-Id: I81e6aa591bec1ac4ca53a4ab0b4f0e3a31af20fb
 2017-12-20 23:23:06 +01:00
Translation updater bot 90cdac7b46 Localisation updates from https://translatewiki.net. 
Change-Id: I7c7ae2a3327ad676a4db0461d871dd2d276ac86d
 2017-12-18 23:07:22 +01:00
jenkins-bot 5457615129 Merge "Add section id to URI fragment on save" 2017-12-18 10:55:35 +00:00
Translation updater bot 99ae04623a Localisation updates from https://translatewiki.net. 
Change-Id: I327e05ba73228d31ad373408c93c9b40a6bfe0b0
 2017-12-17 22:26:19 +01:00
David Lynch 6f2c829bd9 Add section id to URI fragment on save 
Bug: T181075
Change-Id: Iea63112301bfa0860c3d68efc35648a5af7e4ae6
 2017-12-15 00:03:52 +00:00
jenkins-bot e99ef1da02 Merge "ArticleTargetEvents: Track editor mode on save events" 2017-12-14 22:51:04 +00:00
David Lynch 5bbda2b8c8 ArticleTargetEvents: Track editor mode on save events 
Bug: T182610
Change-Id: I8b58bea8e4444478cde4c1340d13ddf97aab8f01
 2017-12-14 16:23:08 -06:00
Translation updater bot dbbbdbd86d Localisation updates from https://translatewiki.net. 
Change-Id: Icc0b85cd1433255d8c9be2f098e0bbe861f52444
 2017-12-14 23:12:35 +01:00
James D. Forrester af8428e861 trackSubscriber: Add timing data for 'loaded' state 
Change-Id: I771764e5f40adcfc67d181cda68f60fc283a9cb2
 2017-12-13 11:20:09 -08:00
David Lynch e66d58076f trackSubscriber: data isn't required 
Editor-fixing caused errors on some events which don't pass data in.

Introduced in 8f612fbe64.

Change-Id: I5c9471e6ffe4cdda0bf5455c80ef70251690e20f
 2017-12-13 11:56:35 -06:00
C. Scott Ananian fde0c180aa Interwiki links are a type of external link 
Bug: T97093
Change-Id: I13325075deba127dc620adb0ad1d18ef99352ab2
 2017-12-13 15:56:58 +00:00
C. Scott Ananian d2d6d23522 Bump Parsoid HTML version to 1.6.0 
It's a brave new world.

https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments&oldid=2644817#Tuesday,_Dec._12,_2017_around_11:45_am_PT:_Y_Deployed_741fc5d

Change-Id: Ib22dc5370cd01bf5becdd639cc12d6a5ccc653a3
 2017-12-13 00:10:16 +00:00
Translation updater bot aaabd8d84b Localisation updates from https://translatewiki.net. 
Change-Id: I2606d7b77cec575907fe57d540326bf1069f14a1
 2017-12-12 22:53:01 +01:00
C. Scott Ananian b85caca493 Strip legacy section IDs from inside headings 
We emit <span id="..." typeof="mw:FallbackId"></span> inside headings
when necessary to provide backward compatibility with pre-HTML5
section ids.  These are mostly harmless inside VE --- they become hidden
alienated nodes, which are then safely ignored by Parsoid during html2wt
even if they manage to migrate outside of a heading --- but it's a
little safer to strip them.

Change-Id: I07d0fcf54427ab02d4930cff183d3e5579a99306
 2017-12-12 12:15:05 -05:00
jenkins-bot a5a3b0c97a Merge "Enable spellchecking on media caption inputs" 2017-12-12 17:04:38 +00:00
Ed Sanders 8a356b19d7 Enable spellchecking on media caption inputs 
Bug: T182393
Change-Id: I23d3f1b37225f9e5a9a9651b6e7b590d38dc99b3
 2017-12-12 16:42:55 +00:00
Translation updater bot 28bc31f58a Localisation updates from https://translatewiki.net. 
Change-Id: Ia5bfd03dc41406dc3ea9344c93f73d6a3309dd99
 2017-12-11 23:39:09 +01:00
jenkins-bot 84e3cfaa0f Merge "Pass editor mode (visual/source) to tracking code" 2017-12-11 17:51:15 +00:00
jenkins-bot db142d34f8 Merge "Track action=loaded for consistency with WikiEditor" 2017-12-11 17:49:17 +00:00
Translation updater bot db453a74fb Localisation updates from https://translatewiki.net. 
Change-Id: I428b0455d4f87c5bd451aac088ccbf68592e5069
 2017-12-10 22:33:31 +01:00
Translation updater bot c6476a33fd Localisation updates from https://translatewiki.net. 
Change-Id: Iac2cdc9cd52b46e12b166676bce5f5384a53e1ef
 2017-12-08 22:37:37 +01:00
Translation updater bot 18f8cd0b1d Localisation updates from https://translatewiki.net. 
Change-Id: I1e4452deddf816b6a2a1007d40a64dcb668fb9a0
 2017-12-07 23:08:05 +01:00
Ed Sanders 8f612fbe64 Pass editor mode (visual/source) to tracking code 
Change-Id: Iba5d3c66ecbd2872d76ea12f795ef3bebaae9d81
 2017-12-07 11:14:00 +00:00
David Lynch 7a260ad1b7 Track action=loaded for consistency with WikiEditor 
Change-Id: I1b92996e63dd85416755377dc14a5a997aac6657
 2017-12-06 11:32:01 -06:00
jenkins-bot 59a57b17a9 Merge "Use rel="noopener" on links targeted at new windows" 2017-12-06 11:18:42 +00:00
jenkins-bot 890d47868c Merge "MWTable: Cleanup events and prevent fire after teardown" 2017-12-05 15:34:05 +00:00
Translation updater bot 3d931296df Localisation updates from https://translatewiki.net. 
Change-Id: I456d50609430beaa80ac687259f0807a419b3e91
 2017-12-05 09:42:06 +01:00
Ed Sanders 28ed1a6b97 MWTable: Cleanup events and prevent fire after teardown 
Bug: T181767
Change-Id: I9b86d810269f3e3e15ba4736d264dbf48c9a0fe3
 2017-12-03 14:46:47 +00:00
Translation updater bot 61365625b7 Localisation updates from https://translatewiki.net. 
Change-Id: I343fc3f0ae5fb7852bc75d8278f5d39823eec5d4
 2017-12-02 22:53:00 +01:00
Translation updater bot 7883f423ac Localisation updates from https://translatewiki.net. 
Change-Id: I2037bd6b5a9cae019e13dbf3ceddd62086c5cbce
 2017-12-01 00:01:48 +01:00
David Lynch 7777f69e7b Use rel="noopener" on links targeted at new windows 
Bug: T180932
Change-Id: I93bda6aaebf97727a187774cccbeba4f27fcddd5
 2017-11-30 13:15:38 -06:00
jenkins-bot 5dce34ee1c Merge "ui.MWSaveDialog: consistent handling of preview category links" 2017-11-30 15:45:35 +00:00
Translation updater bot 212200f4be Localisation updates from https://translatewiki.net. 
Change-Id: If104f2835eee1566891974f24f9d213969a38d32
 2017-11-29 22:56:41 +01:00
David Lynch efbfcd8b35 ui.MWSaveDialog: consistent handling of preview category links 
Category links weren't being checked for redlink status, and weren't opening
in a new window.

Bug: T179913
Change-Id: Ic665583128bf51710178c5674cd35c273f5f207e
 2017-11-29 11:24:32 -06:00
jenkins-bot 7dd9cec01e Merge "DesktopArticleTarget: enable spellcheck on sectionTitle" 2017-11-29 00:38:47 +00:00
David Lynch 396ce6eb6b DesktopArticleTarget: enable spellcheck on sectionTitle 
Tell browsers we explicitly want spellchecking on the section title. If
unspecified this is browser-dependent, so it was inconsistent.

This won't actually have an effect until the next OOjs-UI release (v0.24.3),
as this was a new feature added to TextInputWidget.

Bug: T179654
Depends-On: Ifdd44ead7d782288aaef0979322f0943f7304835
Change-Id: I588874efcff91c5be03da2fc03c268f883b718e2
 2017-11-29 00:06:20 +00:00
Translation updater bot 085ec49a66 Localisation updates from https://translatewiki.net. 
Change-Id: I42b3a5b87ece5c12f42489d98a3ee25aa5c5a332
 2017-11-28 22:50:36 +01:00
Ed Sanders 77773df985 Create MW tables with captions by default 
Bug: T181173
Change-Id: Ib17331e0e8478ba67c1ecbbee4a284d9993cb552
Depends-On: Ieb668d282f7afa9332cead94c95f19f652102af1
 2017-11-27 16:37:24 +00:00
jenkins-bot 65a27b48ce Merge "Fix template rendering" 2017-11-27 15:36:02 +00:00
Ed Sanders 471e40e8bb Fix template rendering 
* Look inside first child for autoGenerated (as reflists can be wrapped)
* Unwrap Parsoid sections
* Discard leading and trailing whitespace

Bug: T179618
Change-Id: Ib9ead28173360f0f1d5a4dc66c33a75d70ef34b3
 2017-11-27 15:02:31 +00:00
Translation updater bot 7da82260e7 Localisation updates from https://translatewiki.net. 
Change-Id: I6e77cc8b6a0e7b7378a70632d59705594a21703e
 2017-11-26 22:54:54 +01:00
Translation updater bot 8e1a60e93b Localisation updates from https://translatewiki.net. 
Change-Id: I73e2bf2377229edac438917df4ddc638fd01e2d2
 2017-11-25 22:58:16 +01:00
Translation updater bot 3c388da5e9 Localisation updates from https://translatewiki.net. 
Change-Id: Ie032d167e7d9f30fff049ff3a98af2ca86ba67b0
 2017-11-24 23:27:50 +01:00
Translation updater bot 643466f4c2 Localisation updates from https://translatewiki.net. 
Change-Id: Iea540f004fe2491cf5e7e7f2f85590fe96b4ffe4
 2017-11-23 23:51:47 +01:00
jenkins-bot 861c48db77 Merge "Unwrap Parsoid sections" 2017-11-23 20:02:43 +00:00
Ed Sanders 267d60f61a Unwrap Parsoid sections 
Section wrapping will be introduced in I0f4c19f7.

Change-Id: I43ced131d07a20318af37e830318e30db2eb451f
 2017-11-23 12:19:57 +00:00
Translation updater bot b33d86d1df Localisation updates from https://translatewiki.net. 
Change-Id: I44df9fd1eb29e1a4bf4b160491554e49d28e4774
 2017-11-22 22:47:15 +01:00
Ed Sanders 38dba57e95 Follow-up I80d82ad87: Only add linebreak to non-empty documents 
This is the same behaviour as the old editor, and
unbreaks editors that use placeholders.

Change-Id: I7b5a18f1fb0d41c5dc08d1b893c90db2bf3dbd86
 2017-11-21 17:14:08 +00:00
jenkins-bot 26e78ea946 Merge "Move source mode newline hack down to ArticleTarget" 2017-11-20 22:32:20 +00:00
Translation updater bot f295eb7384 Localisation updates from https://translatewiki.net. 
Change-Id: I5784a828b8aa69c84222b48a4b36f9c594f9ede2
 2017-11-19 22:41:33 +01:00
Translation updater bot c482d9ebaa Localisation updates from https://translatewiki.net. 
Change-Id: Id8ad8acef84dedbc9395ff5643bdef0b518d4756
 2017-11-18 23:03:55 +01:00
Translation updater bot a4bdca88c7 Localisation updates from https://translatewiki.net. 
Change-Id: I8a5785bfd53a429dbe01e3869429fb1578edc4b6
 2017-11-17 23:03:28 +01:00
Roan Kattouw f37caa6a6f Move source mode newline hack down to ArticleTarget 
We need this hack when visually editing articles, but not in e.g. the
Flow integration. Move it down so that mw.Target has a clean
parseDocument method that can be used by Flow without undesirable
newlines being introduced.

Change-Id: I52bba88b3d33c3d6d16c4cf832f23f970a243abf
 2017-11-17 13:15:27 -08:00
Translation updater bot b7c747a5e9 Localisation updates from https://translatewiki.net. 
Change-Id: I141cdcd5db751610fdd3c78e40e8e82ea0905c2a
 2017-11-15 22:43:25 +01:00
Translation updater bot 42de11dd9c Localisation updates from https://translatewiki.net. 
Change-Id: I137712b96f6223945d6f2fb14a865c2779601095
 2017-11-14 22:43:04 +01:00
Translation updater bot 6cdf04d839 Localisation updates from https://translatewiki.net. 
Change-Id: I28709c87c0b19b28913468e67250b278c917af23
 2017-11-13 22:54:26 +01:00
jenkins-bot 3998651aa2 Merge "Add mw-parser-output to preview elements" 2017-11-13 12:55:24 +00:00
Translation updater bot 9b73200150 Localisation updates from https://translatewiki.net. 
Change-Id: I9071a96e4c6bc863a75a1c6b4fa5fc1b24e3b4ba
 2017-11-12 22:50:24 +01:00
Translation updater bot 8580fed7da Localisation updates from https://translatewiki.net. 
Change-Id: If86bb4a8467aec2ec52823fc230ed946e79c48f2
 2017-11-11 22:55:50 +01:00
Translation updater bot 74800a76da Localisation updates from https://translatewiki.net. 
Change-Id: I21a85d3a7546005a9464af5a9c3f9a0486abf089
 2017-11-10 22:57:49 +01:00
Ed Sanders 57bf86b69e Add mw-parser-output to preview elements 
Bug: T180214
Change-Id: I74700061c89ab4004229e3b03353067e92031774
 2017-11-10 15:34:51 +00:00
Translation updater bot 625dea5a4b Localisation updates from https://translatewiki.net. 
Change-Id: Ia9ec632b3d39b8353619fda55ed5e2191f3b8770
 2017-11-08 22:49:19 +01:00
Translation updater bot b9306f6b09 Localisation updates from https://translatewiki.net. 
Change-Id: I8144f548d7e71ae260a1abf22729f6ded8d95f83
 2017-11-07 22:55:00 +01:00
jenkins-bot 908205d4ac Merge "ce.MWWikitextSurface#onCopy: Do nothing if selection is empty" 2017-11-07 16:18:21 +00:00
Ed Sanders 1cf2bf4a67 ce.MWWikitextSurface#onCopy: Do nothing if selection is empty 
Bug: T179920
Change-Id: I3400f8277a4de6bac216ecbc0ba0d46670e03d11
 2017-11-07 16:09:33 +00:00
Translation updater bot 8209c00cbc Localisation updates from https://translatewiki.net. 
Change-Id: If007f038b0472c9ef12fb7e444e9128c890a8564
 2017-11-06 23:13:31 +01:00
jenkins-bot 2f3dba4222 Merge "Unify SVG markup" 2017-11-06 19:01:14 +00:00
Volker E fdf30c1793 Unify SVG markup 
Align SVG markup across Foundation products by:
- unifying XML declaration,
- removing unnecessary `standalone="no"` attribute as it's default,
- removing all SVG editor metadata
- removing all `g` group elements except where necessary for transforms,
- putting attributes on `path`,
- removing unnecessary ids and
- unifying whitespace.

Saving up to 23% file size before gzipping.

Bug: T178867
Change-Id: If0339073a12f24df1a0f8dcc110c35e0ee2d38a7
 2017-11-06 10:43:56 -08:00
jenkins-bot e18eacf222 Merge "Fix context menu placement on galleries" 2017-11-06 16:36:39 +00:00
jenkins-bot a6e0c8854f Merge "Convert empty doc to empty string in convertToSource" 2017-11-06 16:36:36 +00:00
Translation updater bot 5777b2c12c Localisation updates from https://translatewiki.net. 
Change-Id: I177221e0f068ee12d320dfae6ac11e31568d2a0f
 2017-11-05 22:44:09 +01:00
Translation updater bot c7a9996a10 Localisation updates from https://translatewiki.net. 
Change-Id: Id90279b9542e6842b3e6c133a6fde8dcbe1bbc6f
 2017-11-04 23:00:20 +01:00
Ed Sanders 88e8a9f7a7 Convert empty doc to empty string in convertToSource 
Change-Id: I8753169ff206b5ce23cfd4c0dc7f97ac6fd1fff0
 2017-11-04 21:16:35 +00:00
Ed Sanders b85df2fb8e Fix context menu placement on galleries 
Change-Id: I8d64f805ac3f1ef311bcf1e0e745263b4edbc4c7
 2017-11-04 11:25:41 +00:00
Translation updater bot 3145624694 Localisation updates from https://translatewiki.net. 
Change-Id: Ie30d0f106a01ffa12b464075db32347343652a6c
 2017-11-03 22:50:14 +01:00
jenkins-bot 0511a89c2e Merge "Fire wikipage.content hook on edit notices" 2017-11-02 23:18:44 +00:00
Translation updater bot d234435bd0 Localisation updates from https://translatewiki.net. 
Change-Id: I12b82affd432e1bbcafab2f608420da4bbf044d3
 2017-11-02 23:08:40 +01:00
Translation updater bot ec3d569f24 Localisation updates from https://translatewiki.net. 
Change-Id: I0371fe47c4be9654f1818343d1e218d6577261b2
 2017-11-01 23:19:48 +01:00
Ed Sanders 50217d2a19 Rename mediawikitheme -> wikimediatheme 
Change-Id: I48e1fcc0b71dccdb6d8e034d686a4bfe5dbe39e6
 2017-11-01 15:36:34 +00:00
Translation updater bot 2f9470d9ae Localisation updates from https://translatewiki.net. 
Change-Id: Id293c0866c91066c12fa7789fa246f6177793467
 2017-10-31 22:47:15 +01:00
jenkins-bot 2649a2123a Merge "Fix revslider colours in visual diff mode" 2017-10-31 17:50:53 +00:00
Ed Sanders 3fff0a88d7 Fire wikipage.content hook on edit notices 
Bug: T179315
Change-Id: Ib9a19acbb2459c5b94fc72610f86a48feb80a380
 2017-10-30 22:21:50 +00:00
jenkins-bot 93c2da8e78 Merge "ArticleTarget: remember whether we preloaded, so it can affect the save button" 2017-10-30 22:07:19 +00:00
Translation updater bot d5f02b7483 Localisation updates from https://translatewiki.net. 
Change-Id: I0713373523eaffd0f79560c1f1e76f028697758c
 2017-10-30 22:55:09 +01:00
David Lynch 001b945513 ArticleTarget: remember whether we preloaded, so it can affect the save button 
Idea being: preload use case is often "load content, maybe with parameters,
immediately save it", so we can treat it as being already-modified for saving
purposes.

Bug: T179063
Change-Id: I35ff04bc9cb5172edf8174832624145973aa1fdb
 2017-10-30 16:40:57 -05:00
Translation updater bot 37668e080e Localisation updates from https://translatewiki.net. 
Change-Id: If2b0276e73c0f08543636a03a1dd00d9b92cd462
 2017-10-28 23:05:09 +02:00
Translation updater bot e551f8bcf4 Localisation updates from https://translatewiki.net. 
Change-Id: I8daa1a3a143d70db44ab9c3ce6d01a1d0e4c6357
 2017-10-27 22:39:50 +02:00
Ed Sanders 236d437875 Fix revslider colours in visual diff mode 
Change-Id: If8a631812f3947b2260d66f832849eed3a0ad238
 2017-10-27 11:41:02 +01:00
Translation updater bot d95f4175dd Localisation updates from https://translatewiki.net. 
Change-Id: I09f1039ad1fa7689887b867839a43c90d6311510
 2017-10-26 23:38:37 +02:00
Ed Sanders dc3ed6cec0 build: Update stylelint 0.4.1->0.4.2 
Change-Id: I9d67e4224eb6298e20574a201eeee559ab3a7504
 2017-10-26 21:04:07 +01:00
Translation updater bot c6cbfd272e Localisation updates from https://translatewiki.net. 
Change-Id: I360932f3af6ea92eb1163d9118eb4597f73a3854
 2017-10-25 23:06:53 +02:00
David Lynch ab1e5d58d4 MWInternalLinkContextItem: increase specificity to override OOUI changes 
OOUI 8e31b2f273 increased changed various icon CSS rules, and increased their
specificity. Increase ours to match. This restores the correct size/ratio of
the images in the link context item.

Bug: T178933
Change-Id: I4f1a6dde363cf99f7665dc83f4b0fa6b1dd3c29e
 2017-10-24 16:09:38 -05:00
Translation updater bot bc1f41d0f7 Localisation updates from https://translatewiki.net. 
Change-Id: I868bdeaabf47eb5450be9e99d45451f2724f1833
 2017-10-23 23:45:49 +02:00
Translation updater bot 8074aff678 Localisation updates from https://translatewiki.net. 
Change-Id: I34d2195477c2b61b9a38e5b188d81d595fa85c9b
 2017-10-22 22:54:59 +02:00
Translation updater bot 33462623c9 Localisation updates from https://translatewiki.net. 
Change-Id: I1a9bf279eb217f8c7e87bdaf3c43a622b68a6ae9
 2017-10-19 23:28:36 +02:00
jenkins-bot 600208453b Merge "Use more common 250ms transition for toolbar instead of 400ms" 2017-10-19 17:40:37 +00:00
jenkins-bot c32aeeaa36 Merge "Increase selector specificity to fix layout regression" 2017-10-19 14:29:35 +00:00
Ed Sanders b752a0620b Increase selector specificity to fix layout regression 
Removes negative margin from first item in help popup.

Change-Id: I87ecca9f886dd4061a2afa781ca997ef751907ef
 2017-10-19 15:21:12 +01:00
Ed Sanders 4eb8f46234 Remove duplicate position:relative in toolbar css 
Already set upstream.

Change-Id: Icf15dc82b7d57eb3591b0873e49fa9c598b2742d
 2017-10-19 14:23:05 +01:00
Translation updater bot 28349d7b82 Localisation updates from https://translatewiki.net. 
Change-Id: I8e041de2d743ecfcaa7de6770c95a41431d2cc8e
 2017-10-18 22:53:58 +02:00
Ed Sanders 6761a3619a Use more common 250ms transition for toolbar instead of 400ms 
Change-Id: I8ad1a20753b7bd4a17db605d31502e57149b5348
 2017-10-18 19:17:05 +01:00
L10n-bot 371cff8be6 Merge "Localisation updates from https://translatewiki.net." 2017-10-17 21:05:34 +00:00
Translation updater bot 7ffbb72ae1 Localisation updates from https://translatewiki.net. 
Change-Id: I328365204986eb3dddd000782c348b7aabd941b2
 2017-10-17 23:05:28 +02:00
jenkins-bot 1b54d6e75a Merge "Mobile: Rewrite toolbar centring CSS" 2017-10-17 20:37:14 +00:00
Ed Sanders afc9d2156b Mobile: Rewrite toolbar centring CSS 
Change-Id: I43ada52231a0c9a91c98f2a482d2702528d995a2
 2017-10-17 20:23:50 +01:00
jenkins-bot 45a5121853 Merge "requestParsoidData: Support 'wikitext' param in RESTBase-less environment" 2017-10-17 19:22:55 +00:00
Ed Sanders 0306f77fde Simplify mobile overrides using LESS 
Change-Id: I9ffce148fede03dda6e78377a0d20355bb45e5fd
 2017-10-17 19:44:03 +01:00
jenkins-bot 6d6bff49eb Merge "ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons" 2017-10-17 18:23:26 +00:00
Bartosz Dziewoński 99cdc08f53 ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons 
OOjs UI's styles now include 'top: 0' for icons, which messes us up here.

Bug: T178415
Change-Id: Ia3234848f69fd67d0b3e35c817de1d9847d46143
 2017-10-17 17:55:53 +00:00
jenkins-bot 18e2ccdc96 Merge "init.mw.DesktopArticleTarget: properly set up section links" 2017-10-17 16:28:54 +00:00
David Lynch 80c813e08c init.mw.DesktopArticleTarget: properly set up section links 
We were reimplementing (incompletely) the setup from the .init version. Just
call the original, modified slightly so it doesn't over-setup on repeated
calls.

Bug: T151021
Change-Id: I65bd7c5ecf75c478d6babeb13e7fb2a76a9842c8
 2017-10-17 10:14:50 -05:00
Ed Sanders 8f11796c43 Convert mobile overrides to LESS 
Change-Id: I44754f2d6e69ad9a8a6ce941962714a6d2617b5a
 2017-10-17 11:46:17 +01:00
Ed Sanders 59955251fe Fix button alignment in MW mobile 
Change-Id: I4b29dfef672f48bc6d2b6644b1e0da5a7ada521a
 2017-10-17 11:32:58 +01:00
Translation updater bot b67854f026 Localisation updates from https://translatewiki.net. 
Change-Id: I07de4ef9ea4a31585c519716706e9f389c3763d7
 2017-10-14 22:43:30 +02:00
jenkins-bot 82c8e64f8f Merge "Efficiency improvement for MWLanguageVariantNode#hasRendering" 2017-10-13 21:02:55 +00:00
Translation updater bot a0d39d3643 Localisation updates from https://translatewiki.net. 
Change-Id: I9ac1784955db18b4696006f0f0c9b3da06723f8c
 2017-10-13 22:59:21 +02:00
C. Scott Ananian b56e7eec4d Efficiency improvement for MWLanguageVariantNode#hasRendering 
Override ve.ce.FocusableNode#hasRendering with a model-based test to
improve efficiency and avoid some unnecessary DOM measurements.

Change-Id: Ice7aebcc2f30dc73ef049a6ed0d4a0cffe86d8e2
 2017-10-13 15:11:47 -04:00
jenkins-bot 0fbf8971c1 Merge "Remove duplication from browser whitelist" 2017-10-12 17:32:47 +00:00
Ed Sanders 013d26f0b0 MWParameterPage: Use MultilineTextInputWidget instead of config 
Change-Id: Icccd6460452774ae0ff21ce9df36dfe428d935d2
 2017-10-12 18:13:06 +01:00
Ed Sanders 169ce28c44 Remove duplication from browser whitelist 
The whitelist isn't checked for blacklisted browsers,
so if all non-blacklisted browsers are whitelisted,
set the whitelist definition to all (null).

Change-Id: I8ee3569d9d5be2eda9153f1b087c1be385f93d9c
 2017-10-12 16:54:46 +01:00
Translation updater bot 3cba7eadf2 Localisation updates from https://translatewiki.net. 
Change-Id: I7186a8239ecaadc69dc6ca45de8895ccb7846f0a
 2017-10-11 23:16:55 +02:00
Ed Sanders 58a226288b requestParsoidData: Support 'wikitext' param in RESTBase-less environment 
Change-Id: I6154376be090655d3249ad7e74a0e90b39208a82
 2017-10-11 21:26:18 +01:00
Ed Sanders 581847acb3 Show visual diffs in wikitext mode 
Bug: T170371
Change-Id: I8fd9ed4f804444ec486c4df72125cdeb04da0d5f
 2017-10-11 20:31:39 +01:00
Ed Sanders fc9e0d88f6 Fix WikiEditor mode switcher widget 
Broken by upstream CSS changes in OOUI.

Change-Id: I04c51f18624c09fd0030a8b73410a731216dd99c
 2017-10-11 18:16:44 +01:00
jenkins-bot 12e8f5cdbb Merge "init.mw.Target: make getSurfaceConfig aware of modes" 2017-10-10 22:02:36 +00:00
Translation updater bot f6d891b216 Localisation updates from https://translatewiki.net. 
Change-Id: I7b4a7018ede70f025c9d6969b7fba07794604754
 2017-10-10 23:13:47 +02:00
David Lynch 4e938e58c7 init.mw.Target: make getSurfaceConfig aware of modes 
ve.init.Target sets up TriggerListeners based on getSurfaceConfig if there's
no Surface instantiated. As such, loading directly in source mode would have
those listeners present and assuming the document is in visual mode. So, if
there's not a Surface already, we'll assume we're going to get one created
with the defaultMode, and set things up expecting that.

Bug: T153959
Change-Id: Ia0afe32e6b63ea0d3418137ca5c8bc32c009ecfa
 2017-10-10 15:14:25 -05:00
jenkins-bot 762429e99f Merge "DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader" 2017-10-10 05:04:22 +00:00
Translation updater bot bfe3e66c5e Localisation updates from https://translatewiki.net. 
Change-Id: Ib298629b582138e653c5e807c09a76339544fb8f
 2017-10-09 23:11:04 +02:00
Translation updater bot 1d689c9bd2 Localisation updates from https://translatewiki.net. 
Change-Id: Icd5cecac5b2d5c7f21b9f2bd9450f8c5f191cd11
 2017-10-06 22:58:01 +02:00
James D. Forrester bd2deb3ac4 DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader 
Bug: T164148
Change-Id: I537144bfd52ff84499f5d086f5d05efe2ba0493b
 2017-10-05 15:54:20 -07:00
Translation updater bot ccac68067f Localisation updates from https://translatewiki.net. 
Change-Id: I728c4e56f6e5a91ddca133607a01cfb910e4be61
 2017-10-05 22:58:55 +02:00
Ed Sanders 43763f0a75 Target teardown refactor 
* Rename 'deactivate' to 'tryDeactivate' as it may prompts
  the user to deactivate.
* Merge 'cancel' and 'teardownSurface' in to 'teardown',
  extending the parent method.
* Rename elementsThatHadOurAccessKey to $saveAccessKeyElements
  and move teardown to parent class where it is setup.
* Move toolbarSaveButton teardown to parent class where it is setup.
* Cleanup changeDocumentTitle

Depends-On: I9d97614695272dca6936ef6f3461178fcf0368a8
Change-Id: Ie998a04c21f6615b4415edf471310db5edca3b5a
 2017-10-05 10:26:46 -07:00
jenkins-bot 65ede4fc4f Merge "Use destroy event to teardown new section inputs" 2017-10-05 17:24:57 +00:00
jenkins-bot 5d9c66497a Merge "Use parent #clearSurfaces method to clear surfaces" 2017-10-05 17:22:41 +00:00
jenkins-bot e657612068 Merge "Strip RESTBase IDs from historical diffs" 2017-10-05 16:06:43 +00:00
Ed Sanders 1256b19d72 Use destroy event to teardown new section inputs 
Change-Id: I4990a162b62b7195016efba47cc5926b9e3a0f21
 2017-10-05 16:20:48 +01:00
Ed Sanders e0f7f30bbd Use parent #clearSurfaces method to clear surfaces 
Move mwTocWidget teardown to a destroy event listener.

Change-Id: If96be96aa67da55d3b17dd2565f5e954786ff3ff
 2017-10-05 16:03:55 +01:00
Translation updater bot e0d047973a Localisation updates from https://translatewiki.net. 
Change-Id: I5762bd8184d2b88c686f8b1c27787a6c279bbd73
 2017-10-04 22:59:44 +02:00
jenkins-bot 6e2589d1a6 Merge "Abort loading when 'escape' is pressed" 2017-10-04 15:40:57 +00:00
Ed Sanders 58237588ad Abort loading when 'escape' is pressed 
Bug: T117359
Change-Id: I2c60588f14b9f80b18a7ac8da753fee224be35a4
 2017-10-04 14:09:19 +01:00
jenkins-bot 28d4ed974f Merge "Remove reference to editfont-default" 2017-10-03 18:48:21 +00:00
Ed Sanders ff896e0be6 Always use trackingName for tracking 
Change-Id: Ifc7d3275277628b310f5c017c43a76f5a7c25ea7
 2017-10-02 22:20:53 +01:00
James D. Forrester 09cde07c45 DesktopArticleTarget: Retain 'mwTarget' stats tracking object 
Bug: T177250
Change-Id: I1584f452e16272886af459bac3e24c4995af2231
 2017-10-02 21:03:09 +00:00
jenkins-bot fb4bb65a74 Merge "Allow MediaWiki extensions to use self closing tags" 2017-10-02 18:04:08 +00:00
Ed Sanders cd097bed3d Allow MediaWiki extensions to use self closing tags 
Parsoid now supports this by setting body to null.

Change-Id: I24d856f0cffeacb00cb2b757e34315bc02b595d0
 2017-10-02 10:52:48 -07:00
jenkins-bot 21bd98df61 Merge "ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission" 2017-10-02 17:44:46 +00:00
jenkins-bot e7ac894a94 Merge "MWExtensionWindow: Always send a string to setValueAndWhitespace" 2017-10-02 17:25:02 +00:00
jenkins-bot 2d2ed0094f Merge "MWAlienExtensionNode: Listen to attribute changes" 2017-10-02 17:22:51 +00:00
Ed Sanders ddc056a40a MWExtensionWindow: Always send a string to setValueAndWhitespace 
Bug: T177180
Change-Id: I3a32e1b22e82bc0c182d26a952e7592aafd4b5e4
 2017-10-02 16:26:16 +01:00
Ed Sanders 852e1ababe MWAlienExtensionNode: Listen to attribute changes 
Also:
* Disconnect change event on this.input, which doesn't
  get destroyed on teardown
* Add padding between attributes and this.input
* Assume the alien extensions can have a rendering when
  their body is empty.

Bug: T177181
Bug: T177183
Change-Id: I2e59f8195b255f33f91901213c92ea14793635b4
 2017-10-02 16:22:41 +01:00
Bartosz Dziewoński 2b3998df4b ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission 
Bug: T177041
Change-Id: I28a7ec0710595977e5ec889016dd280d60e93034
 2017-10-02 17:09:04 +02:00
Translation updater bot e667ebe5cb Localisation updates from https://translatewiki.net. 
Change-Id: Ifd08290884dbeed1cc97dd04159d2b6161b31ce5
 2017-10-01 22:48:18 +02:00
Translation updater bot 4ca4ddd991 Localisation updates from https://translatewiki.net. 
Change-Id: I2ad37bcad504d1c0a6fb94e20fa9dc16f5003f59
 2017-09-30 23:02:54 +02:00
jenkins-bot ff7c57489a Merge "Set padded=false for link inspector" 2017-09-29 16:42:29 +00:00
jenkins-bot 8032b97fa9 Merge "Remove upstreamed link inspector page icons" 2017-09-29 16:37:12 +00:00
Ed Sanders 582a3e62fb Remove upstreamed link inspector page icons 
Change-Id: I997b299d9a61ec9307025a7f4d106f185283eb40
Depends-On: I297648d14b4a2540a40f3a0b7d22a7905ef7c035
 2017-09-29 16:27:50 +00:00
Ed Sanders ef46e45b43 Set padded=false for link inspector 
Logically depends on I615b485a272.

Bug: T177080
Change-Id: Ica54238d891fa41eefb0b9216eb4f2190818a502
 2017-09-29 16:14:29 +01:00
Željko Filipin fe09c22e33 Delete Ruby Selenium tests 
Tests are broken most of the time. Ruby framework will be deprecated next month. Selenium tests
that are needed should be implemented in Node.js.

Bug: T164479
Change-Id: I8ec1d9b19b9538936c508daf2b50249a705b3170
 2017-09-29 16:55:12 +02:00
Ed Sanders dc500697e1 Follow-up Ia08dbb44: $attachable -> $bounding 
Change-Id: I88101426998c7f11a7dfd3b971a1274e5aad638a
 2017-09-28 17:36:37 +01:00
Bartosz Dziewoński 81d567bfdc ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs 
This code is meant to fix up the tabs if wgVisualEditorTabPosition
was changed and we're seeing cached HTML with the tabs in wrong order.
But it seems it has never worked. `$caEdit[ 0 ].nextSibling` is a text
node and obviously not equal to `$caVeEdit[ 0 ]`, and vice versa for
the other case. The logic is actually correct, so let's fix it to skip
over text nodes.

Also, remove a stray 'eslint-enable' comment left over in
a0f934ed26.

Bug: T50017
Change-Id: I23663a9bfcfdbf52918452c878a128e6960b1191
 2017-09-28 15:54:55 +02:00
Bartosz Dziewoński a0f934ed26 ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector 
Vector no longer does the silly thing where the tabs are reversed in
the HTML in RTL languages, so we must remove our hack to do the same,
since otherwise it reintroduces the issue it was intended to prevent.

This essentially reverts 2efd4f0061.

Bug: T50017
Change-Id: Ibeaa55bc34899bffab849ea8ad8b127fb5184d43
 2017-09-28 07:35:18 +02:00
Volker E 4067b05832 Unify monospace font family stack 
Bug: T176636
Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
 2017-09-28 00:24:53 +02:00
Translation updater bot db59dc6776 Localisation updates from https://translatewiki.net. 
Change-Id: Icc4ce2792ffbfb8f030c9fa162400c31f72dc8dd
 2017-09-27 22:44:25 +02:00
Ed Sanders 90a9fdb6aa Ensure mw-notification-area doesn't get disabled 
Bug: T176874
Change-Id: I43af13a0fcb5c19fdea53cfaeb941ac100579945
 2017-09-27 14:50:59 +01:00
jenkins-bot 2411e7c04e Merge "Replace constructive with progressive UI flag" 2017-09-26 22:04:46 +00:00
Translation updater bot db5a06afd7 Localisation updates from https://translatewiki.net. 
Change-Id: I55bcbb4134fd269f45b77115c025aea045e3bff8
 2017-09-26 22:54:54 +02:00
James D. Forrester 2c70792c4f Replace constructive with progressive UI flag 
Change-Id: Iae36e978978ed6642f44606a934c540cf5f8537f
 2017-09-26 15:14:32 -04:00
Ed Sanders 38d716f895 Follow-up Iebd1def1: Revert MWSignatureTool case 
The tool checks the page name before the target is initialized.

Change-Id: I02ec528a11cc01b026fb95617388d47323ad96ee
 2017-09-26 19:59:56 +01:00
Ed Sanders 1b8f8d8908 Replace wg(Relevant)PageName with target#pageName 
The default value of target#pageName is wgRelevantPageName
but other targets my override this, or change it dynamically
(e.g. ContentTranslation).

Also remove duplicate setter of pageName in mw.ArticleTarget,
already set in mw.Target.

Change-Id: Iebd1def1d4142978a673afec584a0b663644d176
 2017-09-26 13:22:00 +01:00
Translation updater bot b81a4b0fea Localisation updates from https://translatewiki.net. 
Change-Id: Ia27a53fdc504ca1bb3e2bbb3b0bc6e54542344aa
 2017-09-25 22:54:09 +02:00
jenkins-bot c54a54d3f9 Merge "Api: Missing preloadparams" 2017-09-25 17:30:41 +00:00
Ed Sanders 842d0bb8ed Set bounding element to full frame for MW images 
Logically depends on Iea800132.

Bug: T176646
Change-Id: Ia08dbb4400400990e1e518bc47afd5d60795c736
 2017-09-25 17:17:27 +00:00
David Lynch 02c6e9142b Api: Missing preloadparams 
* Tiny fix to 33dc60838c for PHP variable name
* Bigger fix to properly pass preloadparams in and split them up

Change-Id: I844db115f2563cb9ee1629c30d5f49d1ce58f5bd
 2017-09-25 11:42:09 -05:00
Translation updater bot e13538a8f0 Localisation updates from https://translatewiki.net. 
Change-Id: Ic73bdbb6f814da63a38099728cd960e805be4664
 2017-09-24 23:06:22 +02:00
Translation updater bot d9de7e3235 Localisation updates from https://translatewiki.net. 
Change-Id: I4ce90141a03f0cc736186a8375a21ff22bab349c
 2017-09-23 22:58:22 +02:00
Translation updater bot 996e39613b Localisation updates from https://translatewiki.net. 
Change-Id: I9496eda9f2f17527f36a8dcb356e1246d1f66b98
 2017-09-22 23:29:36 +02:00
Translation updater bot 14ebd22180 Localisation updates from https://translatewiki.net. 
Change-Id: Iee95738a77c34850701cc87b345391a73201145c
 2017-09-21 22:58:48 +02:00
jenkins-bot f17b099984 Merge "Use findFirstSelectableitem instead of getFirstSelectableItem" 2017-09-21 18:13:09 +00:00
Ed Sanders 9572bbe245 Fix font size in local overlays in monobook 
Change-Id: I742c090d64af4e22004e921ab772550474125224
 2017-09-21 15:46:26 +01:00
Translation updater bot fa7cbf0849 Localisation updates from https://translatewiki.net. 
Change-Id: I41c542b61bc744c201ce582267a8a992fde9c201
 2017-09-20 23:09:44 +02:00
jenkins-bot 549290991e Merge "DesktopArticleTarget.init: handle new-section tab when in visual mode" 2017-09-20 17:04:48 +00:00
jenkins-bot e1ae0a91ec Merge "Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label" 2017-09-20 16:20:40 +00:00
David Lynch 325de4b130 DesktopArticleTarget.init: handle new-section tab when in visual mode 
Bug: T157755
Change-Id: Ida657edb57c4d3067f17104ff1b74965c8082131
 2017-09-20 15:49:21 +00:00
jenkins-bot c1721aabe9 Merge "Wait for tree to finish building before updating caption" 2017-09-20 15:41:33 +00:00
Ed Sanders 14f99e3757 Wait for tree to finish building before updating caption 
Bug: T176265
Change-Id: Ib73943beedc6a0166699b33b4d1148d8ba32ad20
 2017-09-20 16:00:41 +01:00
Translation updater bot 7a7e57504b Localisation updates from https://translatewiki.net. 
Change-Id: Iad8f83651883d387edc898646acf6a1042ca38b9
 2017-09-19 23:18:24 +02:00
jenkins-bot 0357252601 Merge "Use figure-inline instead of span for inline media" 2017-09-19 16:11:58 +00:00
jenkins-bot fbdd7c895f Merge "Do not "resolve attributes" in toDomElements() overrides" 2017-09-18 22:27:28 +00:00
jenkins-bot 0246c2a62f Merge "Enable preload in VisualEditor" 2017-09-18 19:59:13 +00:00
David Lynch c440a3576f DesktopArticleTarget: Support preloadtitle in source mode 
Can't support it in visual mode, since there's no new-section handling at all.

Bug: T51622
Change-Id: I763d5fff156e9ef3893bd882fab1dc2d47121728
 2017-09-18 10:18:37 -05:00
Translation updater bot 228af9d25d Localisation updates from https://translatewiki.net. 
Change-Id: I10e3b3c86449102851aec61f7166adfd9432164b
 2017-09-17 22:48:16 +02:00
Translation updater bot 76771b4cd0 Localisation updates from https://translatewiki.net. 
Change-Id: I1cbc38a425ec200a585dfacb825893c20da5b1e2
 2017-09-16 23:06:04 +02:00
David Lynch ea274c94cd Enable preload in VisualEditor 
This allows the use of the preload and preloadparams query parameters. They
should behave as they do in the old editor, loading substituted content in
visual and source modes.

Bug: T51622
Change-Id: I522fb5b480d17912f6d6116be6aa043ead855b52
 2017-09-15 17:17:51 -05:00
C. Scott Ananian 853ec0bc9c Inspectors for editing LanguageConverter markup 
Basic inspectors for editing.  Changing from block to inline, or
adding "hidden" or "describe" flags not supported.

The UI layout for two-way and one-way rules could certainly be improved.

Bug: T49411
Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f5185
 2017-09-15 09:24:33 -07:00
Translation updater bot 253d0b2e09 Localisation updates from https://translatewiki.net. 
Change-Id: Idc7a04710edbde1341c8fd87ab50d74a4ea87dd2
 2017-09-14 23:36:51 +02:00
C. Scott Ananian 26df4dca33 Doc update: use the full class name so JSDuck hyperlinks it correctly 
Change-Id: I2c6f6a6c5b497767d7f7731c86cc145ed60b1deb
 2017-09-14 11:07:07 -04:00
Ed Sanders 405afdce70 Strip RESTBase IDs from historical diffs 
Change-Id: I911d529204a97003ed233464709737b018918634
 2017-09-14 13:45:10 +01:00
Translation updater bot 9dfe4bbdc7 Localisation updates from https://translatewiki.net. 
Change-Id: I2195f7cb1d274f73a32a35237f6e0b9b23e29749
 2017-09-13 22:56:59 +02:00
jenkins-bot 1809344c8a Merge "URL decode file names in gallery, as in PHP parser" 2017-09-13 18:00:56 +00:00
jenkins-bot 714f43c8c2 Merge "Fix typos in gallery attribute names" 2017-09-13 17:34:52 +00:00
jenkins-bot 779dcc2164 Merge "ArticleTarget: Make save commands triggerable from anywhere" 2017-09-13 15:40:19 +00:00
jenkins-bot d6fb66e70c Merge "Use lowerCamelCase for javascript var oldId" 2017-09-13 13:45:20 +00:00
jenkins-bot cd6dfaa42b Merge "Remove pageName/revision from ArticleTarget constructor" 2017-09-13 13:45:19 +00:00
jenkins-bot 15ba6dbc53 Merge "Change ArticleTargetLoader#requestPageData API to use options object" 2017-09-13 13:42:10 +00:00
Ed Sanders a6ac6d0cec Fix typos in gallery attribute names 
The MW attributes are 'style' and 'class'. The plural
forms are used internally only to avoid JS keywords.

Change-Id: I1b7d14872aab4b6b3882d00165924fd1639e1744
 2017-09-13 14:06:44 +01:00
Ed Sanders 280696ad3f URL decode file names in gallery, as in PHP parser 
Bug: T175816
Change-Id: I3ec9c1f6db57798cdc1b5a787dd0bd9b4d3beef1
 2017-09-13 14:03:20 +01:00
Ed Sanders f9562838bf ArticleTarget: Make save commands triggerable from anywhere 
Change-Id: Iea5b2ff1210b0b28a58017f198f55124c9a3348d
 2017-09-13 12:00:19 +00:00
Ed Sanders d515d418c1 Use lowerCamelCase for javascript var oldId 
Change-Id: Idd04578a0035320f85dc911a2f4ddbc6f378887f
 2017-09-13 12:57:37 +01:00
Ed Sanders ebce67b6ab Remove pageName/revision from ArticleTarget constructor 
Other page state is read directly, rather than passed in.
If we come up with a use case for passing this in at a later
date we can reconsider the best way to do this.

Change-Id: Iee7e608c969776b89dbb38b3b56a5177e48344af
 2017-09-13 12:57:37 +01:00
Ed Sanders 682787f312 Change ArticleTargetLoader#requestPageData API to use options object 
Change-Id: I02e6218a8359b1cbc8fed1a34d68206a2a154d46
 2017-09-13 12:57:37 +01:00
Translation updater bot c2b8de09a5 Localisation updates from https://translatewiki.net. 
Change-Id: Ib39c3b33100062858098f2f803e1fad751f837d2
 2017-09-12 22:56:25 +02:00
jenkins-bot 508fdf1543 Merge "Don't require a selection to run any of the save actions" 2017-09-11 15:10:23 +00:00
jenkins-bot 822db7eacf Merge "Add feedback link for visual diff inside save dialog" 2017-09-11 12:01:39 +00:00
Translation updater bot caa7341d49 Localisation updates from https://translatewiki.net. 
Change-Id: If867adb27d970653090e741b90ed503f49a13842
 2017-09-10 22:50:20 +02:00
Ed Sanders 13ef05b489 Don't require a selection to run any of the save actions 
Change-Id: I3a8f7e1e9e3714f226ac240a429a62d011112285
 2017-09-10 14:53:14 +01:00
Translation updater bot bf27796935 Localisation updates from https://translatewiki.net. 
Change-Id: I09865a7a366e768cdb5ac6dcbcbb7ab15ac67420
 2017-09-09 22:53:44 +02:00
Translation updater bot dc2366cbba Localisation updates from https://translatewiki.net. 
Change-Id: I768e3e14ff1b0becdba08daa7694b22625792fab
 2017-09-09 00:22:20 +02:00
Translation updater bot b80952158a Localisation updates from https://translatewiki.net. 
Change-Id: I10f4721b977be987129d271ba1534887bcaabd4d
 2017-09-07 23:42:28 +02:00
David Lynch 569f917edc MWExtensionWindow: clean up originalMwData on teardown 
Not doing this makes adding a new extension node with the exact same content
as a previously-viewed one have the Done button disabled.

Bug: T172586
Change-Id: I39105144e17135044ef644b5464b0fbfdfc019d5
 2017-09-07 10:40:36 -05:00
Bartosz Dziewoński 98351fbcf3 Do not "resolve attributes" in toDomElements() overrides 
Resolving attributes means turning 'href' and 'src' URLs from possibly
relative to absolute, so that they don't depend on the base URI of the
document.

This is necessary when rendering for clipboard (and in some other
cases), but at the point when toDomElements() is called, the document
these elements are in does not necessary have a sane base URI set,
giving us hrefs pointing to nonexistent pages.

Don't do it here; it will happen later when we know what the right
document (and right base URI) is, e.g. in ve.ce.Surface#onCopy or
ve.ui.PreviewElement#replaceWithModelDom.

Bug: T169675
Bug: T175157
Change-Id: Ie0a5d6e1c57b8efdbbfba0c24f31ca91d156e200
 2017-09-07 14:06:24 +02:00
Translation updater bot 67ef60629d Localisation updates from https://translatewiki.net. 
Change-Id: I6176a308b3b526f068da420473e52d342aa0da14
 2017-09-06 23:02:05 +02:00
Bartosz Dziewoński 92cea19890 Use .length instead of .size() for jQuery objects 
.size() is deprecated.

Change-Id: Ib28b7fede117de474efea705adf5dc2cdf8cb101
 2017-09-06 14:52:40 +02:00
Prateek Saxena 1d6b87243e Use findFirstSelectableitem instead of getFirstSelectableItem 
Depends-on: Ic12be404eba490e5ce748f0d754a807e12f6ba76
Bug: T76630
Change-Id: I7daccf8620ec43a56183fd455048a1f2c5f71f26
 2017-09-06 15:42:42 +10:00
jenkins-bot a13620f49a Merge "MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage" 2017-09-06 00:38:33 +00:00
Translation updater bot 8980881dd4 Localisation updates from https://translatewiki.net. 
Change-Id: I745a308a42416baed8debda4b5e2e7491ef5537d
 2017-09-05 23:04:02 +02:00
jenkins-bot 9ef0f71983 Merge "Stop requiring deprecated EditPage::getCheckboxes()" 2017-09-05 18:00:52 +00:00
Arlo Breault 3e96d8ed5a Use figure-inline instead of span for inline media 
Bug: T118520
Depends-On: I0681c39301e52a3368b53d38ed518ac66e18f0d6
Change-Id: Id8ec5b77207f43fc7c379b35859dc09f264e2c04
 2017-09-05 12:17:14 -04:00
Thalia a3902ebff8 Add feedback link for visual diff inside save dialog 
Bug: T170665
Change-Id: I0b09b1089c834a013ad5fee4ecdf75b483b56323
 2017-09-05 13:35:37 +01:00
Prateek Saxena 2b923c0346 MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage 
Bug: T76630
Depends-on: I068dad8c79c4bda6ea37ab6a1eb6ba72ab6f7dc0
Change-Id: Ib4e380aa6cd0cacbadd42bdf447ddee6443f22ef
 2017-09-05 12:13:41 +10:00
Translation updater bot 828ce717f3 Localisation updates from https://translatewiki.net. 
Change-Id: I09c9579992c49851382f4c0d54af59e1552a6532
 2017-09-04 22:52:04 +02:00
Translation updater bot ef753a82ce Localisation updates from https://translatewiki.net. 
Change-Id: Ib1ff25374fcf0df6c0e8ffc3d402adbd3b36dfa1
 2017-09-03 22:41:47 +02:00
jenkins-bot d743fa7c1f Merge "Disable VE on Special:Undelete" 2017-08-31 23:40:41 +00:00
Bartosz Dziewoński df9e564b73 Stop requiring deprecated EditPage::getCheckboxes() 
Instead, use getCheckboxesDefinition(), and build our save form
checkboxes from that rather than extracting them from the HTML.

The ability to have non-checkbox fields there is removed, as that was
never intentional and is now impossible.

To avoid transient problems during deployment (old JS code cached in
the user's browser receiving the new format of API responses), the old
property is kept in the API response. We should remove it next week.

Bug: T174613
Bug: T174686
Change-Id: I5bfca5e116fe790302c3b6ac1357e80237fb1ed2
 2017-08-31 17:47:15 +02:00
jenkins-bot af756c4c20 Merge "EducationPopup: Add cursor:pointer" 2017-08-30 17:59:26 +00:00
Ed Sanders 24747966b6 EducationPopup: Add cursor:pointer 
We still expect the user to click on the tool, and
the actions still works (albeit delayed), so we
should use cursor:pointer.

Change-Id: I6d2b0140f5fd918809f05acc6e405ef430c518fd
 2017-08-30 17:48:27 +00:00
jenkins-bot a24be49c01 Merge "ve.ui.MWEducationPopupTool: Position blue dots with CSS only" 2017-08-30 17:42:38 +00:00
jenkins-bot 1a40fd2b71 Merge "ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table" 2017-08-30 15:48:07 +00:00
jenkins-bot 61ae9df214 Merge "MWParameterPage: Vertically align actions with label" 2017-08-30 15:42:53 +00:00
Egbe Eugene 2fc6423070 Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label 
Since "nbsp" is hard to translate, it is removed from the current
text of visualeditor-mwlanguagevariantcontextitem-rule-code-label,
which was "Language&nbsp;code" - now changed to "Language code".
Instead the table headings (where this message is used) are defined
as non-breaking in CSS.

Bug: T173181
Change-Id: I9794fa010ad908fe772fa6858c25acc6beb973d5
 2017-08-29 21:58:33 +02:00
Bartosz Dziewoński bff16fb352 ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table 
For magical HTML reasons, a `<tbody>` node is automatically inserted
inside the `<table>` node. Therefore the table always had exactly one
direct child, this check always failed and table was never shown.
Instead, count the rows.

Change-Id: Ia8a5387c3f605689ab1053c923952ec955b83253
 2017-08-29 21:57:48 +02:00
jenkins-bot 50c31a0b29 Merge "mw.ArticleTarget: strip HTML tags entirely from source-mode summary" 2017-08-29 19:50:04 +00:00
David Lynch dc101c6169 mw.ArticleTarget: strip HTML tags entirely from source-mode summary 
Bug: T173711
Change-Id: If8b354b2788285ea27472bf9a16544f8e5c091f8
 2017-08-29 12:01:33 -05:00
David Lynch 5d4ff082e6 MWLinkAnnotationInspector: check input validity when switching modes 
Focusing a TextInputWidget normally unsets validity. However, because we're
kind of pretending this is the same input, just in a different mode, it
doesn't make sense to the user that the focus behavior occurs. So, make it
recheck validity after we switch.

Bug: T172159
Change-Id: I1d9d6670d72483c7510fd5ed3c539b43af8432bf
 2017-08-29 11:28:29 -05:00
Bartosz Dziewoński 0a378318bf ve.ui.MWEducationPopupTool: Position blue dots with CSS only 
We can place them in bottom center of the toolbar buttons with
just CSS, no need to manually calculate the position (which
doesn't give the correct results if the toolbar is not visible).

Also add z-index for correct rendering inside TargetWidget,
not overlapped by the toolbar border (e.g. in the media dialog).

Bug: T174120
Change-Id: I556ddfcf252669107cf21810fbed7c9a3751e906
 2017-08-29 18:21:44 +02:00
Ed Sanders c8e856bfb2 MWParameterPage: Vertically align actions with label 
Also make label consistent height, with or without an
indicator using line-height, and move closer to input.

Change-Id: I1b6e6e2f3caa4c949583cafa9448aae6ebc1e0a1
 2017-08-29 14:45:21 +01:00
Ed Sanders 550408f863 Increase width of param actions container 
Bug: T174202
Change-Id: I61a175593b087219b22c5be91d00054b1c15e1dc
 2017-08-29 14:28:26 +01:00
Translation updater bot 498d1dde0c Localisation updates from https://translatewiki.net. 
Change-Id: I85367b5829adcc6402905429b09b00302d1c8585
 2017-08-29 09:27:05 +02:00
Translation updater bot 632a39446f Localisation updates from https://translatewiki.net. 
Change-Id: I86a476a67016ccfec0ece9a6d40576bcc9cc9683
 2017-08-28 13:47:03 +02:00
Ed Sanders 63607c4cff Remove reference to editfont-default 
Bug: T170223
Depends-On: I1ace59c980740fc785ccbd500e19cc8b71d46a5b
Change-Id: I2ac04df04b6652b47490dff5202683c041178a2c
 2017-08-25 18:44:53 +01:00
Ed Sanders 3ba918a6ae Disable VE on Special:Undelete 
Bug: T173154
Change-Id: I2a7d815a67c9e0f80ab3cdfd3a3755370c831867
 2017-08-25 18:09:37 +01:00
Translation updater bot 4677c6837b Localisation updates from https://translatewiki.net. 
Change-Id: I5ea49bc6475bf5c10b900b9ade15455ee939b4a8
 2017-08-25 10:06:55 +02:00
jenkins-bot b73deb1690 Merge "Create wrapper paragraph when converting block image to inline" 2017-08-24 22:16:16 +00:00
jenkins-bot 842b3336bd Merge "Move historical diff loading to DiffLoader util" 2017-08-24 18:33:45 +00:00
jenkins-bot f315c650f6 Merge "Don't focus media dialog until ready process" 2017-08-24 17:18:54 +00:00
Brad Jorsch 2abb9b1b2d Remove execute mode from non-executable 
Change-Id: I46549acd49ca883e9047b8117cb968a9ddbb06cc
 2017-08-24 10:57:25 -04:00
Ed Sanders eb2ee52de0 Create wrapper paragraph when converting block image to inline 
This prevents the image jumping into another paragraph,
e.g. in a different table cell.

Move the logic for removing the old image out of MWMediaDialog
and into MWImageModel#insertImageNode.

Bug: T121449
Change-Id: Ibd7c92f3f90c382ceffd3e0defb12ba36a3786d2
 2017-08-24 15:56:22 +01:00
Ed Sanders b11b144ad6 Don't focus media dialog until ready process 
Bug: T174027
Change-Id: I070b5538e12c8a165a714ac6c3fd172f0ed179d4
 2017-08-24 15:38:11 +01:00
Ed Sanders 51207e7aa5 Allow for mw.body being null in <selfclosing/> extensions 
Bug: T173016
Change-Id: I8daa65e5dc0368b366710f044b621287e83e26f7
 2017-08-23 16:13:16 +00:00
Translation updater bot 21759ac8c9 Localisation updates from https://translatewiki.net. 
Change-Id: I39a7dcd4701e7481dadc37a285159ab283d995e2
 2017-08-23 09:43:48 +02:00
jenkins-bot 8e29c59e44 Merge "Decrease border contrast on selected Vector tabs" 2017-08-22 20:47:22 +00:00
Volker E a2f70cac8b Decrease border contrast on selected Vector tabs 
Decreasing border contrast on selected Vector tabs.

Bug: T173465
Change-Id: I46530c8cdf9161e527f421eeb8186a7695057361
 2017-08-22 13:28:24 -07:00
Translation updater bot 03e17c61bc Localisation updates from https://translatewiki.net. 
Change-Id: Ibd8a3f757e90d99142994dc73b15f178cf98d90b
 2017-08-22 09:24:57 +02:00
Translation updater bot 066cc2ed3e Localisation updates from https://translatewiki.net. 
Change-Id: I0e8878a5878027ffcf58bd02629fe8c54123634a
 2017-08-19 09:26:56 +02:00
jenkins-bot 12ee2041d7 Merge "Align border and border-radius values" 2017-08-17 14:52:10 +00:00
jenkins-bot 9c2bccea48 Merge "Replace remaining greys/reds with WikimediaUI color palette colors" 2017-08-17 14:52:05 +00:00
Translation updater bot 98618638a1 Localisation updates from https://translatewiki.net. 
Change-Id: Ia7afe35d0f465b16d73f065c2373ded6f2dff063
 2017-08-17 09:20:06 +02:00
Volker E 19eb726677 Align border and border-radius values 
Aligning `border` code syntax codebase-wide and
`border-radius` values to WikimediaUI theme.

Change-Id: I1a16dccf17bd112ba5071ebfe02d57237feb39e0
 2017-08-16 14:05:55 -07:00
Volker E aaffa6aa46 Replace remaining greys/reds with WikimediaUI color palette colors 
Replacing remaining greys and reds apart Monobook/Apex specific
stylesheets with WikimediaUI palette colors.

Bug: T173459
Change-Id: I9b5b1c379bf76e8da57eeff28c7dd000f148a8fc
 2017-08-16 13:43:02 -07:00
Translation updater bot 84c6f28b97 Localisation updates from https://translatewiki.net. 
Change-Id: I594ea5f8e9f15fb6739e2ede21e3e365caa77b0a
 2017-08-15 09:02:55 +02:00
Translation updater bot 24e7cd1b26 Localisation updates from https://translatewiki.net. 
Change-Id: Ib536e242d7d941e57e18056b52a304cfdfd73ed6
 2017-08-14 09:43:14 +02:00
Ed Sanders 3cf074c6ea Move historical diff loading to DiffLoader util 
Change-Id: I318752ede2e5c90f9d0ecd26b39e997fff2d60bd
 2017-08-13 15:31:42 -04:00
David Chan c87abccdf9 MWLinkAction: Don't annotate close tags 
Change-Id: I273838eba4cb259cf053ce88378da10b0e241155
 2017-08-13 11:33:43 -04:00
jenkins-bot 2398ae1f3f Merge "Inform users visual diffs are in beta" 2017-08-12 21:04:54 +00:00
Thalia fd75d2687f Inform users visual diffs are in beta 
Bug: T170665
Change-Id: Ia144c4409767567e41693a3fecd245a6b49c27c7
 2017-08-11 15:12:08 -04:00
jenkins-bot 8975449eaf Merge "Context item for LanguageConverter markup" 2017-08-11 14:29:09 +00:00
jenkins-bot 6f12d066d1 Merge "Rename LanguageConverter markup fields" 2017-08-11 14:28:11 +00:00
Translation updater bot 40337be73a Localisation updates from https://translatewiki.net. 
Change-Id: I42edcaf67657f3d0c8425ae1152a47ed3dbc6df9
 2017-08-10 23:17:54 +02:00
jenkins-bot a604c3064a Merge "VisualDiff: Store diffmode in query string on diff pages" 2017-08-10 19:22:40 +00:00
Ed Sanders 1d70266b8b VisualDiff: Store diffmode in query string on diff pages 
Change-Id: I092ac68dd31b29b4418e7afb37bfe94befa16558
 2017-08-10 11:24:54 -04:00
C. Scott Ananian c89a3059f8 Context item for LanguageConverter markup 
Add a context item giving more information on language converter markup.

Bug: T49411
Change-Id: I3c91db84793a9a965dcb760253b24edee5d7bd23
 2017-08-10 11:02:41 -04:00
C. Scott Ananian 4ff740fe21 Rename LanguageConverter markup fields 
Avoid confusion by using `twoway` instead of `bidir`, which could be
confused with the Unicode bidirectional layout algorithm.

Depends-On: Ib59dff22e64f235e30778a5a5b3e525e4fc7fdd3
Change-Id: I7efb35245d48125b167dc0f0ef8f12aa0fff94e5
 2017-08-10 10:59:57 -04:00
Translation updater bot 937f5c0238 Localisation updates from https://translatewiki.net. 
Change-Id: I1b87d53f71cdaa9d9200bb77985e16e26313d174
 2017-08-09 22:46:38 +02:00
jenkins-bot 430fa82774 Merge "Expose ve.ui.MWInternalLinkContextItem generateBody logic" 2017-08-09 18:07:33 +00:00
David Chan c03d69b761 Expose ve.ui.MWInternalLinkContextItem generateBody logic 
Change-Id: I94912ac2c471cc5d227fa8b9cb29c302ca29814d
 2017-08-09 17:58:49 +00:00
jenkins-bot afd3bb5a1d Merge "Remove code for magnify icon from figcaption node" 2017-08-09 16:35:54 +00:00
Translation updater bot 961b2241e9 Localisation updates from https://translatewiki.net. 
Change-Id: I930f11036e7bc1ac1ee700e65b5ddd2bda222b61
 2017-08-08 23:08:11 +02:00
Translation updater bot a2af4cb554 Localisation updates from https://translatewiki.net. 
Change-Id: Iea21c4fac1e837b0f87e7188a46a3aeca0fd87e6
 2017-08-07 23:10:09 +02:00
Translation updater bot 57dfd917f2 Localisation updates from https://translatewiki.net. 
Change-Id: I352afaf45420ca6a3ad59c23573eac8f13202f6e
 2017-08-06 22:51:32 +02:00
jenkins-bot 1e474e038e Merge "Support visual diffs on Special:ComparePages" 2017-08-06 11:46:57 +00:00
Ed Sanders 5104f63cf3 Support visual diffs on Special:ComparePages 
Bug: T171821
Change-Id: I13fe8349ab2d078b172637c931f1b80f7108c927
 2017-08-05 23:38:20 +01:00
Translation updater bot 1e12b53858 Localisation updates from https://translatewiki.net. 
Change-Id: Ifc5d45f9e8b43bf5a17a0e1206cae95645e325eb
 2017-08-04 23:31:05 +02:00
jenkins-bot dc99384c06 Merge "Fill empty apihelp messages" 2017-08-03 21:53:41 +00:00
Umherirrender 33ddad9382 Fill empty apihelp messages 
Change-Id: I5c300e763b58071719710e73fcc0c1666a8e35ec
 2017-08-03 23:42:09 +02:00
Translation updater bot 5e85df4c31 Localisation updates from https://translatewiki.net. 
Change-Id: Id51f14b71889d68489b7e0c34d1b3add3316fc06
 2017-08-03 23:11:46 +02:00
Roan Kattouw 448944de3b Standardize on /^(\.\.?\/)*/ for interpreting Parsoid hrefs 
We used (\.+\/)* instead of (\.\.?\/)* in some places,
but that doesn't make much sense since we won't and shouldn't
ever see stuff like '.../'

Change-Id: I9efcff2d2a34499ca57321dfbae29392ecb422d7
 2017-08-02 21:30:31 +00:00
Translation updater bot 96fd341f1d Localisation updates from https://translatewiki.net. 
Change-Id: I73618d0dc368f56585b7f950ecf20c693d29b8d6
 2017-08-01 23:05:50 +02:00
jenkins-bot 7b17760ad6 Merge "ve.init.mw.ArticleTarget: Fix parsing of preview documents" 2017-08-01 17:40:51 +00:00
Bartosz Dziewoński e31ffa9199 ve.init.mw.ArticleTarget: Fix parsing of preview documents 
ve.init.mw.Target.static.parseDocument requires that its parameter be
a complete HTML document with a single root tag, otherwise some of its
workarounds break horribly in IE 11 (and possibly Firefox).

Bug: T171600
Change-Id: Iaacf24f7bef40a24230fcfa08e15bab31b1587c0
 2017-08-01 17:16:43 +00:00
jenkins-bot c959caffe4 Merge "Copy over missing steps from MWLinkAnnotationInspector to Wikitext version" 2017-08-01 16:25:08 +00:00
Translation updater bot 9a0fda6bba Localisation updates from https://translatewiki.net. 
Change-Id: I3e8539bec5dbd521a0fc1b10d72f78e3d1637d56
 2017-07-31 23:05:34 +02:00
jenkins-bot c44e8e7b19 Merge "Compare template names when diffing, not just type" 2017-07-31 19:28:57 +00:00
Ed Sanders a90f8f5ea1 Copy over missing steps from MWLinkAnnotationInspector to Wikitext version 
Bug: T171892
Bug: T171895
Change-Id: Id14eed79b9a2395b3b722828e62b05d3d8d44327
 2017-07-31 18:44:12 +01:00
jenkins-bot 1bfe56ddb0 Merge "ArticleTarget: set local config to hide welcome dialog" 2017-07-31 16:07:35 +00:00
Translation updater bot 34cd347904 Localisation updates from https://translatewiki.net. 
Change-Id: Ie572f56ba6293663fc4c19e5b70d80035e97e57f
 2017-07-28 22:47:03 +02:00
Ed Sanders 539a1cab43 Compare template names when diffing, not just type 
As type is always 'mwTransclusionInline/Block'.

Bug: T166801
Change-Id: I76cdf0add780d556206c439797cfcca19133d94d
Depends-On: I0f24d9d81b5491a8f09bc59e5f544f99751fd506
 2017-07-28 21:32:32 +01:00
Translation updater bot c0a5b64695 Localisation updates from https://translatewiki.net. 
Change-Id: Id9389d3f271a86db33767e8c9813eaa14b019a17
 2017-07-27 23:23:21 +02:00
Translation updater bot ae47ac45c0 Localisation updates from https://translatewiki.net. 
Change-Id: I47ea114caf376072407ba6c92e60c216aaeb61fd
 2017-07-26 22:58:09 +02:00
Translation updater bot cc0bd4b4cc Localisation updates from https://translatewiki.net. 
Change-Id: I349f1de9b00d36c1e2f1072f7c2cd84629cd3e6e
 2017-07-25 22:47:19 +02:00
C. Scott Ananian 9ee713d480 Display LanguageConverter markup in VisualEditor 
Implement special node types for language variant markup, so that they
display appropriately based on the currently-selected variant.

(Parsoid uses empty elements to represent this markup, so without this
patch anything in -{ ... }- is alienated and disappears.)

A follow-up patch will implement context items and inspectors to
allow editing these nodes.  This patch is basic "read-only" support.

Depends on I4fcdebc2290ec35ba188f4c2e69d578791fbcd67 in Parsoid to
generate the appropriate markup, but this patch is safe to merge
independently.

Bug: T49411
Change-Id: Ie11e9301d2513bfe4a36036481cee9a047f46d37
 2017-07-25 15:26:41 +00:00
Ed Sanders aeca5a8253 Remove code for magnify icon from figcaption node 
This icon is now added by Parsoid content CSS.

Bug: T160960
Depends-On: Id66f09c54103854ccbaa54a03e7c62890b67cba9
Change-Id: I8d76d759641b091c1821ff658b1201ca625fd146
 2017-07-25 14:48:39 +01:00
Translation updater bot ea40fc5f60 Localisation updates from https://translatewiki.net. 
Change-Id: I57efbb78a536b94d16f7bfeabf4ee7002b21aa0f
 2017-07-24 23:21:05 +02:00
David Lynch 0e973e2539 ce.MWTransclusionNode: make sure model exists before getting its document 
Bug: T168932
Change-Id: I8d458888ed0b80205ce17b41f3506410c550630f
 2017-07-24 11:31:19 -05:00
jenkins-bot 6dec360659 Merge "Edit image captions in place" 2017-07-24 16:02:06 +00:00
Translation updater bot 99d18028d9 Localisation updates from https://translatewiki.net. 
Change-Id: I2580854b1270433a4ccda9262d16d7741c9b03e1
 2017-07-22 23:01:52 +02:00
Translation updater bot d15eb23806 Localisation updates from https://translatewiki.net. 
Change-Id: I5fe6d7383256cf027d4550d81ed5bee28df8b1ce
 2017-07-20 23:07:09 +02:00
jenkins-bot 03173b7b2d Merge "ve.ui.MWEducationPopupTool: Don't show if not inside a BarToolGroup" 2017-07-20 17:07:20 +00:00
Timo Tijhof d8a532c87e tests: Remove QUnit.newMwEnvironment from ve.test.utils.mwEnvironment 
Two problems:
* At least one caller already calls QUnit.newMwEnvironment(), which means
  it runs twice which is unsupported and breaks If4141df10eae55 in core.
* It assumes the return will contain 'setup' and 'teardown', which
  is internal and also changes with If4141df10eae55 in core.

Using 'setup' and 'teardown' for this within VE-MW is fine.

First attempt is to simply remove it. Uses that already called
QUnit.newMwEnvironment are effectively unchanged. Uses that didn't
and only pass ve.test.utils.mwEnvironment to QUnit.module directly
will now run without core's QUnit.newMwEnvironment() setup/teardown.

If that breaks anything, we can add it back to those tests that actually
need it.

Change-Id: I9ef0368ba58daf1c7dc92d083ae79c108cc27638
 2017-07-20 00:15:51 +00:00
Translation updater bot d804a1fc10 Localisation updates from https://translatewiki.net. 
Change-Id: Ifbb0c0e37626c04e5085abdda1e8d4a2f60c3c4d
 2017-07-19 23:00:11 +02:00
Bartosz Dziewoński 49d5bae106 ve.ui.MWEducationPopupTool: Don't show if not inside a BarToolGroup 
The popup gets hideously deformed in other cases. Getting it to work
would probably be difficult. Let's just not show it.

Bug: T170919
Change-Id: If9005e9cdea52fefab981f4c7f05f71fce99f3e8
 2017-07-19 22:13:34 +02:00
David Lynch 5f6e186ed4 ArticleTarget: set local config to hide welcome dialog 
This stops the welcome dialog from being displayed repeatedly if the user
edits the article multiple times in the same pageload.

Bug: T170983
Change-Id: I8cc5990e9acb1ac09a2d6dd95eef8042c70088c7
 2017-07-19 14:29:49 -05:00
David Lynch 420037b3ff LinkCache: parsoid element styling, detect selflink fragments 
Selflinks with fragments aren't actually selflinks, and so shouldn't be styled
as such.

Bug: T170943
Change-Id: Icb67c81327769d09af6bcfe593843d9dd2bcc33c
 2017-07-19 11:54:00 -05:00
Ed Sanders 3180445ce9 Edit image captions in place 
Bug: T149753
Depends-On: I6967c9c2b99449e1a4ac003db8213586eda7fbbd
Change-Id: I9baaa8634e9f364e78b3e881113ed8fa917bc76f
 2017-07-19 13:01:02 +01:00
Translation updater bot 623664ec48 Localisation updates from https://translatewiki.net. 
Change-Id: I3e607ca45c0b4f650df79ae26d8c01b26a7e9e88
 2017-07-18 23:10:28 +02:00
jenkins-bot 8baf524006 Merge "Visual diffs: Use new wgDiffOldId/wgDiffNewId" 2017-07-18 15:40:28 +00:00
Bartosz Dziewoński 6123b452da Visual diffs: Use new wgDiffOldId/wgDiffNewId 
This also removes an undeclared dependency on mediawiki.Uri.

Bug: T169574
Depends-On: Ic4abaae6e9c74509f7a114a697cdbb78dd1b89b6
Change-Id: I76803da5f1a52171a1af8de1f3e31ea127a2da78
 2017-07-18 15:16:03 +00:00
Ed Sanders 835a775a49 build: Upgrade grunt-eslint from 19.0.0 to 20.0.0 
Mostly indent and regex fixes.

Change-Id: Iaf9d02363c78cb71deec5c4cab53a05b67f60600
 2017-07-18 12:55:33 +01:00
jenkins-bot 1a2de9c8ad Merge "DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages" 2017-07-17 22:48:21 +00:00
David Lynch c7486ae19b DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages 
Bug: T138715
Change-Id: I1d1efe7fb3286bbf85ea2a17356dcad1d3346517
 2017-07-17 17:17:07 -05:00
L10n-bot 3cd82770e8 Merge "Localisation updates from https://translatewiki.net." 2017-07-17 21:11:56 +00:00
Translation updater bot e91837d952 Localisation updates from https://translatewiki.net. 
Change-Id: I63740a790669e5562776d363c06a31270592f79b
 2017-07-17 23:11:47 +02:00
Ed Sanders 1efd8c5a61 Add mw-parser-output class to CE document 
Bug: T164790
Change-Id: I14ee60dc3e68aad02a740af06f5749e6b5e3329c
 2017-07-17 18:04:52 +01:00
jenkins-bot 1333373c3e Merge "Drop local 'template' icon, use 'puzzle' from upstream" 2017-07-17 15:09:28 +00:00
jenkins-bot 0549c55ca3 Merge "Fix wikitext preview in IE and Edge" 2017-07-17 14:29:43 +00:00
Translation updater bot c820c04ee1 Localisation updates from https://translatewiki.net. 
Change-Id: Ie47d9a6c3f50275338c980822a90edba6853dd8e
 2017-07-14 22:57:02 +02:00
Bartosz Dziewoński 0e00b2c109 Fix wikitext preview in IE and Edge 
In Internet Explorer and Edge, NodeList objects do not have the
'forEach' method. However, Array's 'forEach' can be applied to them,
as we do elsewhere in the code.

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach

Bug: T170466
Change-Id: Icb19995e140607d45c47fb6ae8d60ac80b664d02
 2017-07-14 15:30:27 +02:00
Translation updater bot 815f9e4acc Localisation updates from https://translatewiki.net. 
Change-Id: If9dc517ccbb54150ca209d62bae06df165182429
 2017-07-13 23:01:37 +02:00
jenkins-bot 1b6cc864b3 Merge "DesktopArticleTarget.init: only show welcome dialog if page editable" 2017-07-13 18:11:46 +00:00
David Lynch 0e8ef6c307 ce.MWTransclusionNode: make sure model exists before getting its document 
Bug: T168932
Change-Id: Idf18839b1f1fae6eb29621f1950d2b52c99e3433
 2017-07-13 11:33:38 -05:00
David Lynch a2f8597712 DesktopArticleTarget.init: only show welcome dialog if page editable 
"Welcome to wikipedia, anyone can edit, we welcome all improvements. Start
editing!" is a bit out of place when what you'll see after clicking "start
editing" is "you can't edit this page".

Bug: T138715
Change-Id: I9f655a5f12d4e45644bd01631c2d3131375d8e8f
 2017-07-12 10:29:54 -05:00
Translation updater bot 48a215b9b3 Localisation updates from https://translatewiki.net. 
Change-Id: Ida79312d18b2b56b8d75345fde654c59437dca7b
 2017-07-11 23:09:03 +02:00
Ed Sanders 0917d27e61 Fix wikitext table insertion 
Since Ic8b11d8052 #insertContent puts multiline strings on separate
lines, so to get this to behave correctly, pass in linear data instead.

Bug: T170160
Change-Id: Ie121fce1af46c6834945f4de30bcd9924ee96fd1
 2017-07-10 16:16:11 +01:00
Translation updater bot ec3677e001 Localisation updates from https://translatewiki.net. 
Change-Id: If34229d9423fb41b99ae7e6d578d247a924d669e
 2017-07-08 22:49:24 +02:00
Translation updater bot b67d8d5da9 Localisation updates from https://translatewiki.net. 
Change-Id: Iab72a6b6f3236203dce7ea6bf8ec3c1b7bd96acb
 2017-07-06 23:04:57 +02:00
James D. Forrester 528942c2e1 Drop local 'template' icon, use 'puzzle' from upstream 
Now that our template icon has been upstreamed thereto.

Bug: T111041
Change-Id: If101018de284dcc1be086d92427de0d88adb0e02
 2017-07-06 09:52:56 -07:00
jenkins-bot eb94174561 Merge "ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack"" 2017-07-06 14:53:34 +00:00
Translation updater bot db2921281e Localisation updates from https://translatewiki.net. 
Change-Id: I964c0d70f0ad7e953de2ba7d4a77613d81c55785
 2017-07-05 22:47:29 +02:00
Bartosz Dziewoński 4c3c8b3d1e ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack" 
The promise #getTeardownProcess is trying to resolve/reject no longer
exists, causing exceptions. The code has been unnecessary for a while,
as we do all the work in #getActionProcess. (In the case that we do
switch, the teardown code isn't even called, since we navigate away.)

Cancelling the switch to wikitext works correctly after removing this
code.

Bug: T169588
Change-Id: I1b9b12edf12a0b91f06c13aa53024efb80868387
 2017-07-04 21:49:15 +02:00
jenkins-bot 16f5bc609e Merge "TextInputWidgets: update for deprecated multiline behavior" 2017-07-03 21:21:20 +00:00
David Lynch cfe1d6c0c9 TextInputWidgets: update for deprecated multiline behavior 
Remove config option `multiline` and change to MultilineTextInputWidget as
appropriate.

Bug: T169272
Change-Id: I45565f01de76a88d64d7b0691d1e7279354f375d
 2017-07-03 22:09:58 +01:00
Translation updater bot af7c3a71c9 Localisation updates from https://translatewiki.net. 
Change-Id: I4f1851f6c388dec8ab6be4510607c8f1e8784a33
 2017-07-03 22:52:23 +02:00
Ed Sanders dd54c9c95d Return truthy object when image info not found 
A missing image should return some data to say the
image is missing, not just reject the promise.

Bug: T169337
Change-Id: Ib41a64a783c1baca88f428417c98e7fb913d14a1
 2017-07-03 18:01:33 +00:00
Ed Sanders 915e818356 Clear all gallery state on teardown 
Change-Id: I90662d02bd2d9768bdcf27e532ed8b8792f764c3
 2017-07-03 17:48:06 +00:00
jenkins-bot 73a0574452 Merge "Normalize to template namespace when comparing" 2017-07-03 16:50:44 +00:00
Ed Sanders b3d44c1ccd Normalize to template namespace when comparing 
Bug: T169307
Change-Id: Ic3524819fb026713b27b193e4a03338fffd97229
 2017-07-03 16:41:08 +00:00
jenkins-bot baf1908b99 Merge "DesktopArticleTarget: Regenerate title in all non-view page scenarios" 2017-07-03 16:25:51 +00:00
Translation updater bot 9986166cfb Localisation updates from https://translatewiki.net. 
Change-Id: Ia03ad93b311249dc73b38b69ea085ecfbf75985d
 2017-07-02 22:54:36 +02:00
Ed Sanders af25311201 DesktopArticleTarget: Regenerate title in all non-view page scenarios 
Bug: T168236
Change-Id: I15f2aeb42b98855512970e2f07396fd7a7c97354
 2017-07-01 17:27:07 +00:00
Translation updater bot 90841ca36c Localisation updates from https://translatewiki.net. 
Change-Id: I87974d7d4cbd1f83e913953849d7583d5aa60fc0
 2017-06-30 23:43:26 +02:00
jenkins-bot 59d74932b0 Merge "Update VE core submodule to master (b528a5321)" 2017-06-29 07:39:01 +00:00
Translation updater bot 1055bebefc Localisation updates from https://translatewiki.net. 
Change-Id: I6b7d0c0b29a571c695078b8a00086470751df315
 2017-06-28 23:18:21 +02:00
David Lynch 7e678dc81a Update VE core submodule to master (b528a5321) 
New changes:
44d2d666c Remove custom icon sizing from block slugs
793d131f9 Ignore covering annotations when looking for plain text pastes
b0025f3ab dm.Document fixupInsertion: check suggestedParents as well
73ce638f1 ve.ui.TableLineContext: Fancier popups
9d54d531e Visual Diff: add internal list diff
4f4e121b5 DiffElement: Add hacky support for template-defined references

Local changes:

dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings

Core VE doesn't have any elements with suggestedParents, so make sure this is
properly tested.

Bug: T153315
Bug: T162819
Bug: T164017
Bug: T165865
Change-Id: I01489226d282abe71020e65358ead24fe07692f7
 2017-06-28 20:57:19 +01:00
jenkins-bot 05bc265198 Merge "Keep TOC in correct place in document" 2017-06-28 12:31:33 +00:00
jenkins-bot be808346c9 Merge "Fix TOC meta item detection" 2017-06-28 12:31:32 +00:00
Jforrester 15c6011875 Merge "Ensure MWInlineImages get the ve-ce-leafNode class" 2017-06-27 17:15:44 +00:00
Translation updater bot 42ca5c6d1e Localisation updates from https://translatewiki.net. 
Change-Id: Ibb3f2f38abf77af4872012fb32f73f89d94d0c7b
 2017-06-26 23:08:30 +02:00
jenkins-bot 7f14f854c4 Merge "ve.init.mw.DesktopArticleTarget: Remove some hacks" 2017-06-26 20:27:09 +00:00
Ed Sanders c4f93b1411 Ensure MWInlineImages get the ve-ce-leafNode class 
Without this class, offset calculations fail and model/view
sync can be lost.

Bug: T167009
Change-Id: Ie7b6551ac5a532949c14122b9ee7584a794af0f2
 2017-06-26 12:43:23 +00:00
jenkins-bot 0dee2be8d8 Merge "GalleryDialog: Re-order and make margins even" 2017-06-26 10:33:17 +00:00
jenkins-bot b2ae6ddcb8 Merge "GalleryDialog: Downstream fix for DraggableElement padding" 2017-06-26 10:32:07 +00:00
Translation updater bot 6623018b9d Localisation updates from https://translatewiki.net. 
Change-Id: I97af6bed779e8435746a70ae0eba850ce4be1d2f
 2017-06-25 23:21:18 +02:00
jenkins-bot ba3a5d85bd Merge "Show visual diffs on DiffPage" 2017-06-25 03:30:29 +00:00
jenkins-bot a7fdaffb1b Merge "Clear all diff state when switching editors" 2017-06-24 11:10:32 +00:00
Translation updater bot 2a2b22c829 Localisation updates from https://translatewiki.net. 
Change-Id: I157176fbd3f29a718b7b95974216db819c881cb9
 2017-06-23 22:54:56 +02:00
Ed Sanders 15af26876a GalleryDialog: Re-order and make margins even 
Move image inside filename fieldset, and make
margins between fieldsets and button 1em.

Change-Id: I7f6789043f873f9da4e960c94e22a7ee096a352f
 2017-06-23 12:16:35 -07:00
Ed Sanders 9eb637e933 GalleryDialog: Downstream fix for DraggableElement padding 
Bug: T168745
Change-Id: I95e6f5cd2126878c4f973285fceece1d5a03c4eb
 2017-06-23 11:58:37 -07:00
jenkins-bot 93a44ef399 Merge "MWTransclusionDialog: fix conditions for "show options" button disabling" 2017-06-23 17:21:50 +00:00
Ed Sanders fd1adfb3b5 Keep TOC in correct place in document 
Change-Id: I6ad8cd8cbd7ef902204408673eb096b7405abd24
 2017-06-22 15:16:15 -07:00
Ed Sanders 1a0fd81f64 Fix TOC meta item detection 
Change-Id: Icce35100bbc0bfb5584a676eec0e1774308d0f68
 2017-06-22 15:16:14 -07:00
Translation updater bot 48c6e558ea Localisation updates from https://translatewiki.net. 
Change-Id: I03013c77fdaffbca561a7e3a3462a5469703b25b
 2017-06-22 23:10:14 +02:00
Ed Sanders 11e6e25ac6 Clear all diff state when switching editors 
Bug: T168618
Change-Id: I19ff5054b87568546bfe1202d67c5d863e1549be
 2017-06-22 10:54:04 -07:00
David Lynch 9ded195f7e MWTransclusionDialog: fix conditions for "show options" button disabling 
As I understand it, the button should be enabled whenever there's more than
one option in the sidebar, and disabled otherwise. The previously chosen
conditions weren't perfectly proxying this, and the button would be disabled
whenever editing an already-existing transclusion.

Bug: T167710
Change-Id: Id303b680c072642ae7b66066e28ecc9f1dc90fd7
 2017-06-22 17:58:52 +01:00
jenkins-bot e285c8e4cb Merge "Show simple category list in preview" 2017-06-21 20:07:45 +00:00
jenkins-bot 090d26f9c5 Merge "Use Parsoid data for template names rather than detect from wikitext" 2017-06-21 01:15:38 +00:00
jenkins-bot 7cd5a5d61f Merge "Add newline to end of wikitext documents" 2017-06-21 01:10:57 +00:00
Ed Sanders 09519a24d2 Add newline to end of wikitext documents 
Bug: T156609
Change-Id: I80d82ad87464b1c6e0344b29123bb96fcc4cffad
 2017-06-20 17:51:51 -07:00
jenkins-bot 115f8e7ae5 Merge "Move preview document filtering into MWSaveDialog" 2017-06-21 00:41:26 +00:00
jenkins-bot fc4e836d4b Merge "Fix getWikitextFragment shortcut to return a promise" 2017-06-21 00:40:46 +00:00
Ed Sanders 6f72ef82d9 Show simple category list in preview 
Bug: T153534
Change-Id: Ie86abdad76a38855d5ad1a394c0bfb3c8dd5a8c6
 2017-06-20 23:50:52 +00:00
Ed Sanders 9dd638a5ab Move preview document filtering into MWSaveDialog 
Also:
* Make mw-content-DIR nest inside mw-body-content
* Use ve.filterMetaElements

Change-Id: Ic70c7dff0f74b81f92b8bd48e8092549947990ba
Depends-On: I478fe1f39164b9fd7e71987b818b8f668d1a7020
 2017-06-20 23:50:44 +00:00
jenkins-bot 87e1ede04a Merge "Return nothing from styleParsoidElements" 2017-06-20 23:11:46 +00:00
Translation updater bot 8beac44dab Localisation updates from https://translatewiki.net. 
Change-Id: Ie734ca2986ad6f5a1da5f349b20756ef283246c3
 2017-06-20 23:08:44 +02:00
Ed Sanders e1b4321b5a Return nothing from styleParsoidElements 
The method modifies DOM elements in place, and the return
value is never used.

Change-Id: I6254389dbf8daa67795206cb508038b60e1a4761
 2017-06-20 21:03:22 +00:00
Translation updater bot f7586d5f9d Localisation updates from https://translatewiki.net. 
Change-Id: I59770f4737b52838d1c5cbdb2e9111986b76fc75
 2017-06-19 23:12:02 +02:00
Translation updater bot c5dad8f018 Localisation updates from https://translatewiki.net. 
Change-Id: I961fe87e1974dc12df7fd0df33745c95c926a871
 2017-06-18 22:55:09 +02:00
Ed Sanders 585cf5f990 Fix getWikitextFragment shortcut to return a promise 
Change-Id: Ide5c920332ba9dd0777a7c63e27ebbbc9a391172
 2017-06-17 19:42:24 -07:00
Translation updater bot b9a6dc8394 Localisation updates from https://translatewiki.net. 
Change-Id: I53062bbd73eb478e27284f35320f5bc2bd4809bf
 2017-06-17 22:50:13 +02:00
Translation updater bot d67005cdb8 Localisation updates from https://translatewiki.net. 
Change-Id: Ic29540f87264d7541afa0a3be696cb47ed7e4f50
 2017-06-16 23:02:01 +02:00
jenkins-bot 4b852d899b Merge "Use static parseDocument method" 2017-06-16 18:38:25 +00:00
jenkins-bot 14dd536d32 Merge "ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning" 2017-06-16 18:32:51 +00:00
Ed Sanders 0e6d8d5fff Show visual diffs on DiffPage 
Only shown if VisualEditorEnableDiffPage is set, or query
string param 'visualdiff' is present.

Currently:
* All VE javascript is loaded (could be cut down to just DM code)
* The entire Parsoid HTML of both revisions being compared is loaded
* Both Parsoid HTML docs are parsed into VE DM trees and diffed

Bug: T167508
Change-Id: I151fc9bab3d3032f50c8d11be6b54e45a06fcc34
 2017-06-16 19:29:19 +01:00
Bartosz Dziewoński 624211a60f Use Parsoid data for template names rather than detect from wikitext 
We were incorrectly handling transclusions with trailing
newlines after the template name.

This also improves handling of non-template transclusions,
e.g. parser functions like `{{int:mainpage}}`, which are
no longer mangled as if they were page names.

ve.dm.MWTransclusionNode#isSingleTemplate will now match
a template even if it's name is itself template-generated.

Logic for turning Parsoid's hrefs into page names stolen
from ve.dm.MWImageNode.prototype.getFilename.

Bug: T167613
Change-Id: Ibecf71338eb37bb3da81a7372e4ed41140a9af57
 2017-06-14 23:15:18 +00:00
Bartosz Dziewoński 433e7b5069 ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning 
OOjs UI Popups position themselves automatically relative to their
$floatableContainer these days.

Also added explicit `$floatableContainer: this.$element` in the config
(although not strictly needed, since the parent node is used by
default, this makes the code more robust in case we move the popup
somewhere else in the DOM).

Bug: T167751
Change-Id: Id4267fce6499a4c217f7dc1d18871c02dd078aee
 2017-06-14 23:19:09 +02:00
Bartosz Dziewoński 9dcf6dcddc ve.init.mw.DesktopArticleTarget: Remove some hacks 
No longer needed after I2ede6c88be569224c0b2a4e388a133ad98b86a7b
in VisualEditor core.

* 'transform: none' from 049a32c60a
  (that change does not describe what the issue was, but clearly
  it wasn't a complete fix and I see no problems without it).
* 'z-index: 4' from 6fff13b898 (I can't
  reproduce the issue there after removing it).

Bug: T167616
Change-Id: I7e0d603af2668269e5587eaa5e4761166a1b4097
 2017-06-14 22:25:25 +02:00
Bartosz Dziewoński 39b82f7b00 Revert 032fb292, a97eacd0 
Reverting a new weird hack for an issue and bringing back the
old, tried and true hack that was removed in the mistaken belief
that if a bug is marked as fixed, it is really fixed.

* Revert "MWTransclusionDialog: size footer correctly"
  This reverts commit 032fb2924e.
* Revert "Remove dialog height hack tagged against resolved bug"
  This reverts commit a97eacd05b.

Bug: T93290
Bug: T167483
Change-Id: If1cc07837892bb0248c74025d5403f9698e77705
 2017-06-14 20:38:38 +02:00
jenkins-bot 5fbe84a4e6 Merge "MWTransclusionDialog: size footer correctly" 2017-06-14 11:39:41 +00:00
Translation updater bot 98568e734f Localisation updates from https://translatewiki.net. 
Change-Id: I751ac55b2a10f014c1db8df1d6915d71711ee5c9
 2017-06-13 22:51:12 +02:00
Brad Jorsch 7ec68ed168 API: Split description messages into summary + additional text 
See MediaWiki core patch I778bab2b

Change-Id: I642895c0e77dabfde3a7cdc744c5de4df9489aa5
 2017-06-13 13:27:52 -04:00
David Lynch 032fb2924e MWTransclusionDialog: size footer correctly 
Changing label means a refresh is needed.

Bug: T167483
Change-Id: Ie4b35696bdf21d2a74e786875615d8753a57972d
 2017-06-13 11:48:38 -05:00
Translation updater bot 2dc77148cb Localisation updates from https://translatewiki.net. 
Change-Id: I182b53a98bb4d7c5e471b23a4665c1c3a84c8b46
 2017-06-12 22:52:07 +02:00
jenkins-bot 7e892bbc97 Merge "MWParameterPage: Fix missed remove -> trash icon name rename" 2017-06-12 18:55:05 +00:00
jenkins-bot b170e81d83 Merge "Fix i18n TODOs in CollabPad" 2017-06-12 18:51:31 +00:00
jenkins-bot 27c6f624ae Merge "[DEPRECATING CHANGE] Make Target#createModelFromDom static" 2017-06-12 18:50:38 +00:00
jenkins-bot 076a7feef2 Merge "Add filename to gallery dialog page" 2017-06-12 18:46:48 +00:00
James D. Forrester a7d48228dc MWParameterPage: Fix missed remove -> trash icon name rename 
Bug: T167598
Change-Id: I1701bd426ea66a40937bcc69183c697a8e39710d
 2017-06-12 11:39:50 -07:00
Translation updater bot 678949a23d Localisation updates from https://translatewiki.net. 
Change-Id: Ia2bd46f3bbe52d17c6ea187dbd8a516de564adf8
 2017-06-11 22:48:17 +02:00
Translation updater bot a84164a38b Localisation updates from https://translatewiki.net. 
Change-Id: Ia38f09ce88980b0954a81b72ff32954e286fed23
 2017-06-11 00:39:40 +02:00
Ed Sanders 23c0b6997e Fix i18n TODOs in CollabPad 
Change-Id: Ifa802773881e2f2763578223bc76ca2798a08b17
 2017-06-10 12:48:09 +01:00
Translation updater bot 44d0e3336b Localisation updates from https://translatewiki.net. 
Change-Id: I3d19d4fed087b2f3b2fea902f2a223e765eceddd
 2017-06-09 23:04:23 +02:00
Ed Sanders 75d583a0d9 Use static parseDocument method 
Change-Id: I545a58ffcbf1c7c57c197f4858958de835a40394
Depends-On: I5b36e187a5e8bb68b47b2fccf5b46c08b81b01d9
 2017-06-08 14:43:09 +01:00
Ed Sanders f178061117 [DEPRECATING CHANGE] Make Target#createModelFromDom static 
Change-Id: I019689f87ac0f7f40a8a7600029b5ce1bc92e77f
 2017-06-08 14:35:31 +01:00
jenkins-bot e97393434a Merge "Give extensions a fallback icon when invisible" 2017-06-07 23:34:20 +00:00
Ed Sanders 8fb56b8d75 Give extensions a fallback icon when invisible 
Bug: T166526
Change-Id: I5eafbef3b751a83cef353c8a9f09d90820fa9409
 2017-06-07 22:29:19 +01:00
Translation updater bot 94be609bb4 Localisation updates from https://translatewiki.net. 
Change-Id: I881fdd18a2a6eda2af0f9b48d0e93ba05b845ee0
 2017-06-07 22:56:46 +02:00
L10n-bot 46bcf496fe Merge "Localisation updates from https://translatewiki.net." 2017-06-06 21:03:23 +00:00
Translation updater bot 6c802d059f Localisation updates from https://translatewiki.net. 
Change-Id: I927c7fe0f0c1dae63d337245a6e40723a69fd379
 2017-06-06 22:50:16 +02:00
jenkins-bot 7774f2bee1 Merge "dm.MWTransclusionNode: Move mixin comment, remove duplicated static property" 2017-06-06 15:44:25 +00:00
Ed Sanders 9ccdf15695 dm.MWTransclusionNode: Move mixin comment, remove duplicated static property 
Change-Id: Id8f8205db92a70dde7ba22b39e90e37590efb3d1
 2017-06-06 16:28:01 +01:00
jenkins-bot 010197f1b8 Merge "Don't try to i18n-parse JSON string" 2017-06-06 15:08:16 +00:00
Ed Sanders 4a163020a8 Add filename to gallery dialog page 
Also add fieldset headings consistent with media dialog.

Bug: T167049
Change-Id: I8112b70d8e3ba19079fdab0806ad343b233c9c18
 2017-06-06 15:48:24 +01:00
Ed Sanders 4484f5c316 Don't try to i18n-parse JSON string 
Bug: T167051
Change-Id: Idf07ba51d2681f0f5d275f2a732d77cd85e63d03
 2017-06-06 11:12:41 +01:00
Translation updater bot 3830d2d864 Localisation updates from https://translatewiki.net. 
Change-Id: Ib2dc866df76ca62367f5fbc76d0dd75831bf3968
 2017-06-05 23:20:13 +02:00
Translation updater bot 507fdb73fc Localisation updates from https://translatewiki.net. 
Change-Id: Ief77af837492f4171aebd118d3d07277adcdf8cf
 2017-06-04 23:37:19 +02:00
Translation updater bot b7ef971cbf Localisation updates from https://translatewiki.net. 
Change-Id: I670fd45d44a881de24917d40d4d4eea047cee185
 2017-06-03 22:54:52 +02:00
Translation updater bot 748d301680 Localisation updates from https://translatewiki.net. 
Change-Id: I9fe85ad034bd1784867bf9bbeb5b93d0d568e95d
 2017-06-02 22:51:08 +02:00
jenkins-bot c5bdd39a63 Merge "Update for deprecation of OOjs UI openWindow/closeWindow promise" 2017-06-02 00:32:39 +00:00
Bartosz Dziewoński 4f55d8066e Update for deprecation of OOjs UI openWindow/closeWindow promise 
Bug: T166729
Change-Id: I95b85a8c0d488993c11da74e1d856fef6cf0ebb4
 2017-06-02 00:21:58 +02:00
Translation updater bot 87b90944c8 Localisation updates from https://translatewiki.net. 
Change-Id: I2c7721a9dc5b4abe2151ebe6604bd1b4d7715999
 2017-06-01 23:21:13 +02:00
jenkins-bot f01577ffa8 Merge "ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff" 2017-06-01 18:08:21 +00:00
jenkins-bot a506627f57 Merge "Correct numbers in visualeditor-dialog-meta-settings-toc-help" 2017-06-01 17:49:21 +00:00
David Lynch 7f8f188187 Correct numbers in visualeditor-dialog-meta-settings-toc-help 
Bug: T166029
Change-Id: Ic15834218bed8a78ad2d9de6c0838988ca65cd4b
 2017-06-01 10:46:02 -05:00
jenkins-bot 1a80348e8b Merge "Guard against mwdata.body being null" 2017-06-01 14:52:57 +00:00
Bartosz Dziewoński 834539748c ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff 
This fixes the focussing problems from T166150.

As a separate consequence, when loading a template/transclusion
takes a while (it can take several seconds for e.g. a template with
100 parameters), we will now display nothing while the user waits.
Previously we displayed an empty frozen dialog (note that this only
worked the first time for some reason).

Bug: T166150
Change-Id: I414a72ee248517867eef63a75f2d327aa5d5b908
 2017-06-01 16:31:05 +02:00
Ed Sanders a5e44034fb Guard against mwdata.body being null 
Bug: T166754
Change-Id: I3b887a3a6ee81ca3fd0b242fadc8b833b9031b50
 2017-06-01 14:01:23 +01:00
jenkins-bot c9d9361c5b Merge "Update VE core submodule to master (8be817396)" 2017-06-01 01:16:43 +00:00
Ed Sanders c7221988a1 Update VE core submodule to master (8be817396) 
New changes:
26085a853 Make author list a ListPopupTool
c4ea53eef Update OOjs to v2.1.0
8c94697f3 Update OOjs UI to v0.22.0
cdebc4817 Follow-up 8c94697f: Actually commit the icon changes I had locally
8be817396 Update OOjs UI to v0.22.1

Local changes for author list popup

Change-Id: I36bcaf122528a4a12882aaff3b33ef936082a391
 2017-05-31 17:48:45 -07:00
James D. Forrester 756079d477 Replace uses of the removed 'remove' icon with the 'trash' one 
Bug: T166730
Change-Id: I528dcdb390a4488ffac89fc823ff35bc1eda4f24
 2017-05-31 16:30:17 -07:00
Translation updater bot 8cb43a5f73 Localisation updates from https://translatewiki.net. 
Change-Id: I154f2dd73776ab7c227c5776bdfd97a1228f5dd4
 2017-05-30 22:50:10 +02:00
Translation updater bot f372a9fbc7 Localisation updates from https://translatewiki.net. 
Change-Id: I6c06a3c102a1ac6c009c7c2fc074b6e7a7c55eb7
 2017-05-29 23:33:34 +02:00
Translation updater bot b29b2816b2 Localisation updates from https://translatewiki.net. 
Change-Id: Ia20bdbf2ab8962c4cd73c7296db5f5e1db55d80f
 2017-05-28 22:42:27 +02:00
Translation updater bot ff1279244a Localisation updates from https://translatewiki.net. 
Change-Id: Ic8decb78f5ba98c21d8b526ea91ae88db7bd3605
 2017-05-26 22:53:58 +02:00
Translation updater bot efc4eccc47 Localisation updates from https://translatewiki.net. 
Change-Id: I49161dac6c2583b4820a1d052b0cca8053e68583
 2017-05-25 22:58:36 +02:00
Timo Tijhof a9ce695f75 mw.DesktopArticleTarget: Use require() for mw.page.watch 
Add 'require' to eslint global whitelist for this extension,
since ResourceLoader provides this in all contexts now.

Bug: T166254
Depends-On: I0e6a95bd4fbaba06eae5137ac7af84f62bebf6f0
Change-Id: I6b2fe57317dcff18ec6d9ea0cd9e4eb9c894c169
 2017-05-24 21:17:02 +00:00
Translation updater bot abaa359422 Localisation updates from https://translatewiki.net. 
Change-Id: I2bfd2fa70e5aa870e2001a78d058e6e90a2bb73c
 2017-05-24 23:04:42 +02:00
jenkins-bot 762344b2f1 Merge "Remove dialog height hack tagged against resolved bug" 2017-05-24 06:54:46 +00:00
Translation updater bot 2a84837eb9 Localisation updates from https://translatewiki.net. 
Change-Id: Ifa384f07695740972053594107aa4c3f49d6a054
 2017-05-23 23:09:13 +02:00
Ed Sanders a97eacd05b Remove dialog height hack tagged against resolved bug 
Bug: T93290
Change-Id: Idbb20a0adf854ba68e10043608764891f3d8514d
 2017-05-23 17:48:02 +01:00
Ed Sanders 004ca16a8f Remove mobile browsers from the blacklist 
They are already blacklisted by MW:
https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix_.28mobile.29

Change-Id: I8d6bfc415604a74b6da82d8c4b8f7d9ec7b9d89d
 2017-05-22 14:58:54 +02:00
Translation updater bot 0c26e1804f Localisation updates from https://translatewiki.net. 
Change-Id: I39d9799f42e23262a53e129b1ceea4f76bbef627
 2017-05-21 23:00:27 +02:00
James D. Forrester 8e88db4232 Follow-up 7e72163ea: Fix CBN alien unit test I missed and force-merged 
Whoops.

Change-Id: I21e30efd930458f6c1509e2f3d947f94d5ec5ad2
 2017-05-21 16:32:08 +02:00
Ed Sanders 1a577b668d Move getWikitextFragment up to Target from ArticleTarget 
Any MW target may want to get a wikitext fragment, not just
ArticleTargets. Requires us to move refreshEditToken up as well.

Change-Id: I27d30e20fefd5ba266d3d8e5f99383e9b4d4993a
 2017-05-21 07:57:49 +00:00
Translation updater bot adc947e1f1 Localisation updates from https://translatewiki.net. 
Change-Id: Ibbc8c82e247dc5eb9ca616d9c0ff0ec1eeda7d12
 2017-05-20 22:58:20 +02:00
Ed Sanders 574baf2e8e Provide VE-rebaser in MediaWiki as Special:CollabPad 
Change-Id: I3ffe0e2b6af43d4018dcd79877f4f27ed7d6a7e7
 2017-05-20 19:51:09 +00:00
David Lynch 07e4d5fd17 dm.MWTransclusionNode: remove TableCellableNode mixin 
Change-Id: Ic08c7ba03ad2bee35a96a750377450475d0efeed
 2017-05-19 20:55:14 +02:00
jenkins-bot ed2a6b873e Merge "Allow extension nodes to convert to a specified type of dataElement" 2017-05-19 14:27:16 +00:00
Ed Sanders 153f7b034d Allow extension nodes to convert to a specified type of dataElement 
Sub-classes want to dynamically change type, e.g. inlineFoo/blockFoo,
but doing this after storeGeneratedContents invalidates the cache,
so ensure this is done as soon as the element is generated.

Bug: T151130
Change-Id: I80e2f2587cff8e9d9fe6ded5d8581263268deaa8
 2017-05-19 16:08:01 +02:00
jenkins-bot fbc835be12 Merge "MWCategoryInputWidget: missing 'new' for cached redirected optionwidgets" 2017-05-19 10:13:40 +00:00
David Lynch dfbbe378c3 MWCategoryInputWidget: missing 'new' for cached redirected optionwidgets 
Bug: T164820
Change-Id: I8b2ae9112af74910cb6ba5097dcec8be86cc1376
 2017-05-19 11:57:17 +02:00
Jforrester 352eaea9af Revert "Localisation updates from https://translatewiki.net." 
This reverts commit df892898c5.

hi messages corrupted.

Change-Id: I826f13d24bb43f54700a134b98ecc0fa14a6e3b3
 2017-05-19 08:35:58 +00:00
Translation updater bot df892898c5 Localisation updates from https://translatewiki.net. 
Change-Id: I45389fc125e3fd4823731c1cf561851be734b54c
 2017-05-18 23:02:00 +02:00
jenkins-bot 526d1ba71e Merge "Enable edit tab setup on appropriate Special pages" 2017-05-18 16:18:49 +00:00
Bartosz Dziewoński d687e01208 Do not check for visual editor availability when loading source editor 
Follow-up to fefb76eebc. Prior to that
change, the condition for this looked like this:

  // … if on a ?veaction=edit/editsource page
  (
    isViewPage &&
    uri.query.veaction in editModes &&
    (
      uri.query.veaction === 'editsource' ||
      init.isVisualAvailable
    )
  )

In the refactor, the `uri.query.veaction === 'editsource'` check was
lost.

Since that code is pretty messy (probably predating the source editor
and hastily adjusted), instead change the check for `isVisualAvailable`
to just `isAvailable`. If the requested mode turns out to not be
available later, the editor will not load.

Bug: T165146
Change-Id: Idfaf9115dd20cec8f8e044a704b93b07984cdcee
 2017-05-16 18:57:56 +02:00
jenkins-bot 4249e7898e Merge "Rename deprecated Card to current TabPanel" 2017-05-16 09:50:42 +00:00
jenkins-bot cfa8de994e Merge "MWTransclusionNode: Implement MWTransclusionTableCell" 2017-05-15 18:05:01 +00:00
David Lynch 0eb6b94b4c MWTransclusionNode: Implement MWTransclusionTableCell 
Back in de98382a55, references to MWTransclusionTableCell were introduced,
but weren't followed through on. So, actually add it. Have cellable
Transclusions use it as their type.

Bug: T144122
Depends-On: I054f12f4218102a12d7a9ea843f9c61e8825c52c
Change-Id: I367f878bfd1c58e20b62368cb78120604b48d791
 2017-05-15 12:09:11 -05:00
Ed Sanders 63c36c87da Always prefer wikitext for action=edit on non-SET wikis 
Ideally we could use the preferred editor, but this breaks
tab switching to the old editor.

Bug: T165238
Change-Id: I5f5ee5566cdd2080ba7c89d43cf127b457537768
 2017-05-15 12:48:30 +01:00
jenkins-bot 5e11f1669a Merge "Fix action=edit links for NWE" 2017-05-15 11:06:49 +00:00
Ed Sanders 9342e45f7b Fix action=edit links for NWE 
We added support loading NWE from action=edit in I35208cce069
but missed this check in the front-end.

Bug: T165238
Change-Id: I2732eaa81a3f968b34c4e878b2ad36de981dd567
 2017-05-15 11:52:06 +01:00
James D. Forrester 57aad56a7b Enable edit tab setup on appropriate Special pages 
Using the forthcoming wgRelevantPageIsProbablyEditable.

Bug: T165010
Depends-On: I6c6ca1cfd93e7be917952980f1e1d57aec3a1292
Change-Id: I6c6ca1cfd93e7be917952980f1e1d57aec3a1229
 2017-05-15 11:14:29 +01:00
Translation updater bot dd9a7ad9f9 Localisation updates from https://translatewiki.net. 
Change-Id: I3becfe7c241e510b558e65a54060d3e93cc907b5
 2017-05-14 22:48:41 +02:00
Translation updater bot db24f81138 Localisation updates from https://translatewiki.net. 
Change-Id: Ic7ce8924f898681caafe37761384f0f30919fc8c
 2017-05-12 23:19:04 +02:00
Translation updater bot 898091bfed Localisation updates from https://translatewiki.net. 
Change-Id: Ifa7703be93365df355b7de8db47e878a10b33256
 2017-05-11 23:37:50 +02:00
Volker E f695877de7 Rename deprecated Card to current TabPanel 
Renaming CardLayout to TabPanelLayout and all connected code instances.
Follow-up to Icfe1652cc038dc131b6b855ce9b45040b8ee5178

Bug: T164903
Change-Id: I9ce4e31e390522d469e126fb3a4b05787cef7fef
 2017-05-10 11:46:49 -07:00
David Lynch 2f40972807 MWWikitextDataTransferHandlerFactory: Don't reimplement getText 
I forgot about getText in 41ca528705, apparently.

Bug: T163237
Change-Id: Ibb646fc03a0293845c4449cbbe6c822ba63751f8
 2017-05-10 10:58:42 -05:00
jenkins-bot 862c3ca22e Merge "MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible" 2017-05-10 15:51:16 +00:00
jenkins-bot 24e4cb7d8b Merge "Update VE core submodule to master (fbeb0db2c)" 2017-05-10 15:36:39 +00:00
James D. Forrester 229d6cdf3b Update VE core submodule to master (fbeb0db2c) 
New changes:
d61440346 Add logging to the rebase server and client
d1d2539ae rebaser: Add script to convert a log file to a test case
0896d5f05 lib: Update README files for OOjs and OOjs UI
045ae87fb Localisation updates from https://translatewiki.net.
04b276e16 VisualDiff: Make annotation whitespace trimming configurable
dd04912e5 Localisation updates from https://translatewiki.net.
11fc30709 MobileContext: fix button spacing
7898acd0b Fix typos and minor lint issues
4e3e2deb9 Avoid using the global namespace in test files
1ed81efa1 build: Update eslint to 0.4.0 and make a pass

Bug: T163473
Bug: T164166
Change-Id: I4bab4260d6b05ff0277cacd167186336acc02080
 2017-05-10 10:02:54 -05:00
Translation updater bot 31bea72f3a Localisation updates from https://translatewiki.net. 
Change-Id: I1acf037adbf8456802f4321377b7209cb7268462
 2017-05-09 23:10:18 +02:00
David Lynch 41ca528705 MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible 
This lets us avoid a fraction of a second lag when someone pastes a plain URL
into source mode.

Bug: T163237
Change-Id: I0e673856dec5f273fb92731b27494762299d2d6c
 2017-05-09 10:19:15 -05:00
jenkins-bot 0f903b09d1 Merge "Generate visual diff only after switching to visual diff tab" 2017-05-09 13:31:36 +00:00
Ed Sanders debcd678b5 Generate visual diff only after switching to visual diff tab 
Bug: T164724
Change-Id: I48e49d4b68cc769b3e9d061983de4c78b5ad5c34
 2017-05-09 10:09:39 +00:00
Translation updater bot 4296814235 Localisation updates from https://translatewiki.net. 
Change-Id: I24e0b7ee282f937c0e7b1c44798a78439d723b63
 2017-05-08 23:01:19 +02:00
Translation updater bot 3e31b869e8 Localisation updates from https://translatewiki.net. 
Change-Id: I768ab6f09c49c7d3cdee0f0764a59ac0164bd445
 2017-05-06 23:07:00 +02:00
Translation updater bot 021c91811e Localisation updates from https://translatewiki.net. 
Change-Id: If05c18f72c4fb8276676c13e145ade05ec309739
 2017-05-05 22:54:40 +02:00
Translation updater bot 6f96b1e9d1 Localisation updates from https://translatewiki.net. 
Change-Id: Id74033215796baa8238a3635d8cba3fc1b08e0a2
 2017-05-04 23:11:44 +02:00
jenkins-bot 75b762d5c4 Merge "Specify suggested parent node types for tables" 2017-05-04 18:50:48 +00:00
jenkins-bot 20465377db Merge "Allow headings in divs" 2017-05-04 18:49:09 +00:00
Ed Sanders 9d83efc747 Specify suggested parent node types for tables 
This won't do anything useful until T164017 is resolved.

Bug: T164016
Change-Id: I39bffe2dc59a97888b81bdbe990e55ba95b0dd94
 2017-05-04 14:50:49 +00:00
Ed Sanders 485a159037 Allow welcome dialog to be variable height 
Bug: T164056
Change-Id: I277a709545151dbd51f92c21d6317a45b1088db2
 2017-05-04 13:08:33 +01:00
Ed Sanders 8e6105fec8 Allow headings in divs 
Bug: T164453
Change-Id: I986b1b376a592095c94d29a102278d4fde0a621f
 2017-05-04 12:43:36 +01:00
jenkins-bot 9b86ebae7f Merge "Follow-up 57a06a6: Use the same attribute name on read and on write" 2017-05-02 22:00:40 +00:00
James D. Forrester 486bbd7609 Follow-up 57a06a6: Use the same attribute name on read and on write 
Bug: T164054
Change-Id: I6770f6c91248fcd9ab39322413874e20a1b65552
 2017-05-02 14:42:22 -07:00
Translation updater bot eafe281fa3 Localisation updates from https://translatewiki.net. 
Change-Id: Ic48e5776fde9b30c47656b01718bbbf764e6b2da
 2017-05-02 23:22:42 +02:00
Ed Sanders 54fc920622 Captcha improvements 
* Fix focus and resize/scroll into view after the
  captcha has loaded (so after the image has loaded
  for FancyCaptch).
* Add margin between input and captcha
* Enable enter-to-submit on captch input field.
* Unify code for simple/math/questy and correctly
  render math as HTML (by looking at the mime type)

Change-Id: I10433cefbfea8569674c120dde5b489570e20966
 2017-05-02 17:49:12 +01:00
Ed Sanders 998ae22b2d Follow-up I488fd7e74: Adjust saveFail calls for new function signature 
Bug: T164157
Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
 2017-05-02 16:39:04 +01:00
jenkins-bot 68d00a6a42 Merge "init: Fix checks for required skin elements to avoid false positives" 2017-05-01 22:37:16 +00:00
jenkins-bot 089d765c0e Merge "Avoid global variables in tests and build" 2017-05-01 15:56:58 +00:00
jenkins-bot dc8935ae41 Merge "MWSignatureNode/Tool: Avoid global variables" 2017-05-01 15:49:37 +00:00
jenkins-bot 13307dd556 Merge "Fix minor lint errors and typos" 2017-05-01 15:49:35 +00:00
Bartosz Dziewoński a02e68374e init: Fix checks for required skin elements to avoid false positives 
* Do not try to load the editor on protected pages, or if the user
  doesn't have permission to edit pages.
* Move the check for required DOM elements after the check for
  pages without the editor (T162411) and after DOM ready (T163307).

Bug: T162411
Bug: T163307
Change-Id: I8149694ba8155682701f2cda6ca212d60f446caa
 2017-05-01 11:24:01 +00:00
Translation updater bot 99656bae30 Localisation updates from https://translatewiki.net. 
Change-Id: I3e87b5b23666918a904d77111c76160fbe3d0a74
 2017-04-29 23:31:44 +02:00
Ed Sanders 59b3f2e0dc Avoid global variables in tests and build 
Change-Id: I44dd3c3980f88e660798962c4aa0229b62760796
 2017-04-29 12:37:53 +01:00
Ed Sanders ede81b493e MWSignatureNode/Tool: Avoid global variables 
Change-Id: I0596b33e797830f3718f4edbe34075fdaced0831
 2017-04-29 12:37:28 +01:00
Ed Sanders 7c0fc8d3b9 Fix minor lint errors and typos 
* Commas that should be semicolons
* Unnecessary 'call's

Change-Id: I11a80702b5396a36e3deecc6e706a397cc354bd8
 2017-04-29 12:36:17 +01:00
Translation updater bot 26e155035e Localisation updates from https://translatewiki.net. 
Change-Id: Iccbb936fb34cf928fa72cf5d56c1654fe8ce86f4
 2017-04-29 00:09:45 +02:00
jenkins-bot bcb62d7907 Merge "Synchronise VE availability checks in frontend and backend" 2017-04-28 17:02:54 +00:00
Ed Sanders cd8b059e7d Synchronise VE availability checks in frontend and backend 
Adds better support for NWE loading on action=edit.

Change-Id: I35208cce0696607377378a1b58d426e914a3ba7d
 2017-04-28 17:45:27 +01:00
Ed Sanders 381f143a27 QUnit: Remove all code for counting tests 
Change-Id: Ifc20282a4da1aed9be2a9215c13f9a4e3e30168f
 2017-04-28 17:03:20 +01:00
jenkins-bot 323f2479ea Merge "Add basic support for Parsoid HTML5 video/audio" 2017-04-28 15:26:44 +00:00
Ed Sanders 0c2bb3da9c Add basic support for Parsoid HTML5 video/audio 
Change-Id: I30b787261c57e912e571170d8aa2d04726b6aa3a
 2017-04-28 14:08:18 +01:00
Translation updater bot c198ea287d Localisation updates from https://translatewiki.net. 
Change-Id: If183c1f7a7ddffa4dd2c61a6921ca5ad6f4b6bbe
 2017-04-27 22:59:54 +02:00
jenkins-bot 604dc2d86a Merge "MWMediaTransferHandler: Allow uploading of dropped Blobs" 2017-04-27 19:32:42 +00:00
jenkins-bot 2d34afeb27 Merge "VisualDiff: Check save dialog is still visible when re-rendering diff" 2017-04-27 18:53:12 +00:00
Ed Sanders 3999fb1eb6 VisualDiff: Check save dialog is still visible when re-rendering diff 
Change-Id: I1d740b767d150699863f18ee6dd9eca8a35b2bf1
 2017-04-27 18:36:07 +01:00
David Lynch 88f3191926 tests: MWInternalLinkAnnotation getFragment 
Also, fix docs for it. It could also return null for a missing fragment.

Change-Id: Ib6df379c5c3686a59026b6b66f26b3050ede231a
 2017-04-27 11:21:58 -05:00
Ed Sanders 3a9dcf7ec5 MWMediaTransferHandler: Allow uploading of dropped Blobs 
Previous the media upload panel didn't support this. This makes Chrome
behave in the same way as Firefox when pasting images into a document.

Bug: T39932
Change-Id: I12f190a48ae9b62d4ad2f33b2a4ee546fdf7b354
 2017-04-26 22:33:18 +00:00
Ed Sanders fefb76eebc Rewrite logic for choosing initial editor 
Expanding from a single if-expression lets us make the
code much more readable, and reveals some minor bugs.

Change-Id: I49e57bfc093e019c837a73eab5c25fdbd14de0af
 2017-04-26 12:07:51 -07:00
jenkins-bot a93888afd5 Merge "EditModeTool: Use state-describing, not action-describing labels" 2017-04-26 18:42:42 +00:00
Ed Sanders d1017bfd48 EditModeTool: Use state-describing, not action-describing labels 
Follows-up 914eb1cde3; reverts the logic to have the label change, but
sticks with new "-current" i18n messages, so the "X editing" instead of
"Switch to X editing"; the old i18n messages are now dropped entirely.

Bug: T162864
Change-Id: Icdad6c5bb06ff86e9b8976840bb1a94b939609a8
 2017-04-26 11:33:14 -07:00
David Lynch e1e89e8b14 DesktopArticleTarget: only destroy notices tool if it exists 
Bug: T163813
Change-Id: Ib957eac2d3d407f8e683082938ec51d882c2d041
 2017-04-26 18:03:39 +00:00
Translation updater bot 06a6abae2b Localisation updates from https://translatewiki.net. 
Change-Id: I3da20c65994635e306a799b81a9814c9071a6c65
 2017-04-25 23:02:08 +02:00
jenkins-bot c8f919a880 Merge "MWCategoryWidget: batch requests for category data" 2017-04-25 18:32:52 +00:00
L10n-bot e5706fcd9f Merge "Localisation updates from https://translatewiki.net." 2017-04-24 21:01:40 +00:00
Translation updater bot a7b4bfe522 Localisation updates from https://translatewiki.net. 
Change-Id: I06af2815f231bc169dba8bb82a009170a39bb176
 2017-04-24 23:01:33 +02:00
jenkins-bot 83b331e04e Merge "MWTemplatePage: Show a different message if the template doesn't exist" 2017-04-24 20:43:54 +00:00
jenkins-bot 233415cf50 Merge "MWTransclusionModel: Update for change in TemplateData" 2017-04-24 20:43:52 +00:00
James D. Forrester c787df90c5 MWTemplatePage: Show a different message if the template doesn't exist 
Bug: T162694
Change-Id: Icad5abb240efd10fadbfdb287acb98afe2361719
 2017-04-24 20:30:35 +00:00
jenkins-bot b268b4f80f Merge "ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error" 2017-04-24 19:48:35 +00:00
James D. Forrester 8fd621ad74 MWTransclusionModel: Update for change in TemplateData 
Depends-On: I7905502d0c419a04e4487095214634f1513b461c
Change-Id: I97a1bfc9f9ead082a673a91b9d2053630a90309c
 2017-04-24 19:13:59 +00:00
jenkins-bot 7df78e1ec1 Merge "MWSaveDialog: Check diffElement still exists after setTimeout" 2017-04-24 18:12:10 +00:00
Ed Sanders df3a4fb171 MWSaveDialog: Check diffElement still exists after setTimeout 
Bug: T162642
Change-Id: Iec01a8ebbda39d83fd1c2f4dbbef17793d9af1e4
 2017-04-24 18:03:35 +00:00
Translation updater bot 82792c5249 Localisation updates from https://translatewiki.net. 
Change-Id: I1f6839c2c0486ebc30a4d4cbc873f45314c84a16
 2017-04-23 22:53:34 +02:00
Translation updater bot e2309aa3ce Localisation updates from https://translatewiki.net. 
Change-Id: Icfc5631209c09ff5ca286de2ec583264b32d7c43
 2017-04-21 23:07:58 +02:00
Bartosz Dziewoński 70dd0c0d16 Remove unused message 'visualeditor-differror' 
Unused since a6b4258f47.

Change-Id: Ia4d8ca252dfe04416f1b45ae72f771bc53607ec3
 2017-04-21 18:43:36 +02:00
jenkins-bot 67d6ac38e6 Merge "Show a different label for the current mode in the editor mode selector" 2017-04-21 15:56:04 +00:00
jenkins-bot 1862f74f11 Merge "ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only" 2017-04-20 22:34:33 +00:00
Bartosz Dziewoński 371ac353cf ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only 
Sites like to customize 'readonlywarning' with things that we can't parse.
Instead, use 'apierror-readonly'. The old message is still shown in edit
notices.

Bug: T163455
Change-Id: I592accde17b256ecee27820df12d9d312499f8f7
 2017-04-21 00:08:57 +02:00
David Lynch f7d0df2449 MWCategoryWidget: batch requests for category data 
API query cuts off after 50 results.

Bug: T163406
Change-Id: I6e83843dd1a22334d9ddec7103ddf318fb181112
 2017-04-20 16:47:16 -05:00
L10n-bot 08a02f0b29 Merge "Localisation updates from https://translatewiki.net." 2017-04-20 21:16:54 +00:00
Translation updater bot 0e5f238f6b Localisation updates from https://translatewiki.net. 
Change-Id: I2636ef1e36cfce806d637e906f421cf1cd48548c
 2017-04-20 23:16:48 +02:00
jenkins-bot dd6113bb76 Merge "Load notices when switching, just don't show them" 2017-04-20 21:05:40 +00:00
Bartosz Dziewoński 91a75e3fef ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error 
If we retry and get another 'badtoken' error, something is very wrong,
and trying again and again is probably pointless. This behavior also
matches how mw.Api#postWithToken handles bad tokens.

Bug: T163493
Change-Id: I488fd7e74e37922044491695d6c9025a45531281
 2017-04-20 22:42:10 +02:00
Ed Sanders c02c529537 Load notices when switching, just don't show them 
Previously we completely disabled the loading of notices
when switching, instead of just not showing them (so they
don't clash with the "switched" popup).

Bug: T162812
Change-Id: I3f8e787630e196cee1dbb1aa449b3558b74fcd04
 2017-04-20 21:20:10 +01:00
James D. Forrester 914eb1cde3 Show a different label for the current mode in the editor mode selector 
Bug: T162864
Change-Id: I2242f85f8c4607411e65b64c8e43181bb139945f
 2017-04-20 13:00:34 -07:00
James D. Forrester bef15b7a1e Update VE core submodule to master (bfb35aaef) 
New changes:
57f8064b6 tests: Enforce dm unit test coverage at 20% per file and 80% globally
6f757c670 LinkAnnotation: add a getFragment method for consistency with MWInternalLinkAnnotation
c40a3f152 Drop the classList polyfill for IE9
d1af6c6bb Update OOjs UI to v0.21.1
bfb35aaef Localisation updates from https://translatewiki.net.

Bug: T162277
Change-Id: I5146bc421bb88e56bafadccefc7bbdee106504ea
 2017-04-20 09:48:46 -07:00
jenkins-bot 6c4b3d68f7 Merge "Move out Cite-specific unit tests in WT transfer handler" 2017-04-20 16:32:55 +00:00
Ed Sanders a7477a869f Move out Cite-specific unit tests in WT transfer handler 
Change-Id: Ibea6994a208e4b0b1022896eb31dd2f36f0fd6c6
 2017-04-20 17:07:46 +01:00
jenkins-bot 06777e20a3 Merge "MWCategoryItemWidget: remove DraggableElement's padding" 2017-04-20 15:23:29 +00:00
jenkins-bot 0c31c3c243 Merge "ve.ui.MWCategoryPopupWidget: Fix popup positioning" 2017-04-20 07:52:24 +00:00
David Lynch 1c47d71e7d MWCategoryItemWidget: remove DraggableElement's padding 
OOjs UI v0.21.0 changed DraggableElement's padding. Override it here, so it doesn't look broken any more.

Bug: T163404
Change-Id: Ic0bc4f9e3e060cf89e6bc7cb22068d1fe1441d75
 2017-04-20 02:05:42 -05:00
Translation updater bot 0a18ebcfe5 Localisation updates from https://translatewiki.net. 
Change-Id: I15974fc59db78fad152b63361d0aae8942888f8a
 2017-04-19 23:19:02 +02:00
Bartosz Dziewoński 4b7d188735 ve.ui.MWCategoryPopupWidget: Fix popup positioning 
Figuring out why it broke doesn't seem like a very interesting task,
so let's just throw the whole logic out and use OOjs UI PopupWidget's
new built-in ability to position itself relative to anything.

Bug: T163269
Change-Id: Ie464e4668001f4bc6151b40cef469937aa8c6e48
 2017-04-19 22:48:16 +02:00
Translation updater bot 6654de8f0b Localisation updates from https://translatewiki.net. 
Change-Id: Ic69f81d75182144f16a90375bc26c55d48a76998
 2017-04-17 23:21:48 +02:00
James D. Forrester 3a382e6398 Update VE core submodule to master (fc46ed86f) 
New changes:
719f8c667 ve.ce.DocumentNode: toggle all contentEditable properties, not just the outer one
35cadd7db Introduce single-line mode for surfaces
41fe321b2 Restore pointer-events comments for IE10 support
42f556820 Upgrade to jQuery v3
c1b8f142c Pass toolbarConfig position to actions toolbar by default
0d4c6a5fc Fix styling of table context in MW theme
db6eb4ebf Localisation updates from https://translatewiki.net.

Bug: T161944
Bug: T162808
Bug: T162830
Change-Id: I9b11673b4a77b7aebcdc282953d83ade08a8d8bd
 2017-04-17 11:25:00 -07:00
Esanders eeab63d2c7 Revert "Dropping IE9: Remove disableUneditableContent from DesktopArticleTarget" 
IE10 also lacks pointer events support.

This reverts commit 5266776953.

Change-Id: I42c9530c45ad98657b403bdb266188368085716b
 2017-04-14 13:53:56 +00:00
James D. Forrester 0ca821b321 Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but not from null 
Whoops.

Bug: T162939
Change-Id: I5a9315e3cfc8a9e8edfb2ef597daeae09bbf5c5e
 2017-04-13 14:38:20 -07:00
Ed Sanders f20b9b0aa0 doc: Tag mixin inheritance hacks with bug 
Also mixin dm.MWResiazble to dm.MWImage (already done
in CE).

Bug: T92540
Change-Id: I32215873993a7e9a7f775ce3f39e2d378e0f31cd
 2017-04-13 11:00:17 -07:00
James D. Forrester d989de5c09 DesktopArticleTarget.init: Don't call setEditorPreference twice 
This is run after the targetPromise completes (via the platform-agnostic
setDefaultMode proxy), which is the correct time to do so. We should not
do this twice, and we definitely shouldn't do this before the target has
successfully loaded, lest a user ends up with us setting their option to
"prefer" an editor that they actually can't load. Whoops.

Bug: T156316
Change-Id: Icf4b5ddd9c8265ade55f43328f807344b41db350
 2017-04-13 04:38:07 +00:00
James D. Forrester ca6cf4e914 ve.test.utils: Don't try to write user options in test suites 
Bug: T162810
Change-Id: I8c2588fe4f7577b962200b583efd68f9cb80367e
 2017-04-13 00:42:51 +00:00
David Lynch efc469f2f4 TemplatePlaceholderPage: abort pending template search after adding template 
With precise timing, the lookup menu could appear after the add template
button had been pressed and the user had moved on to the next page.

Bug: T162707
Change-Id: I36941dc7288c6031a0fb189c0946aa6d8f8697e8
 2017-04-12 11:34:42 -05:00
jenkins-bot b278907870 Merge "dm.metaitems: Turn grouped metas into variadic ones" 2017-04-11 23:13:57 +00:00
Translation updater bot d609f2554d Localisation updates from https://translatewiki.net. 
Change-Id: Id0ae8c83283669d6fe27fdca7b5a475289c74eee
 2017-04-11 23:12:25 +02:00
James D. Forrester 57a06a6e75 dm.metaitems: Turn grouped metas into variadic ones 
We're getting rid of meta item grouping, so we need to prepare.

Merged:
* ve.dm.MWIndexMetaItem
  from ve.dm.MWIndexDisableMetaItem and ve.dm.MWIndexForceMetaItem
* ve.dm.MWNewSectionEditMetaItem
  from ve.dm.MWNewSectionEditDisableMetaItem and ve.dm.MWNewSectionEditForceMetaItem
* ve.dm.MWTOCMetaItem
  from ve.dm.MWTOCDisableMetaItem and ve.dm.MWTOCForceMetaItem

These three now inherit from ve.dm.MWFlaggedMetaItem to avoid code duplication.

Change-Id: Ic8a9cdb1226dccac2c27e7f4b965c1590a7387c0
 2017-04-11 11:13:18 -07:00
David Lynch cdefd36d1e Internal link context popup: selflinks still get link styling 
Bug: T162671
Change-Id: I0ba584b90db73ebade81050f0d782945b8934080
 2017-04-11 10:51:05 -07:00
David Lynch d5ac18a466 LinkCache: don't treat a link with a fragment as a selflink 
This matches the rendered output for the page.

Bug: T162669
Change-Id: I1ea0ab37a2751c0b4669da8a23adf0ce271facea
 2017-04-11 12:19:01 -05:00
Translation updater bot bcf13d5a32 Localisation updates from https://translatewiki.net. 
Change-Id: Ie290cf3caeecc964b6e9639da7a637311d84ab01
 2017-04-10 23:09:29 +02:00
Ed Sanders 55368c1170 VisualDiff: Ignore changes to originalMw 
Can happen when switching edit modes.

Also fix typo in describeChanges.

Change-Id: I2c02adc34aef975b9f6f902a74907d24b7edc54a
 2017-04-10 21:22:16 +01:00
Ed Sanders a6b4258f47 ArticleTarget: Refactor savedialog/target interaction 
* Pass a wikitext promise, instead of wikitext
* Handle writing of content to the dialog from within
  the dialog.
* Handle diff errors within the dialog.
* Never disable the 'Return to save form' (approve) button
* Remove redundant messages

Change-Id: Ibd76e8951998f751abfb4f407682202c2f73ac7e
 2017-04-10 10:29:41 -07:00
Ed Sanders 7a66d4f08a Update VE core submodule to master (1338c50f5) 
New changes:
ae0204885 stylelint: Remove no-unsupported-browser-features overrides
d744cd576 Localisation updates from https://translatewiki.net.
1338c50f5 [BREAKING CHANGE] Remove resize handlers from within DiffElement

Local changes:
Trigger diff element resize on dialog resize

Depends-On: I82a67a4309bf76db5407ea38c26c47d14c01e921
Change-Id: I912a99edca25ff576e2872723f91afe54e36a170
 2017-04-10 10:29:18 -07:00
jenkins-bot 4110bdfd26 Merge "VisualDiff: Fetch original doc from Parsoid if fromEditedState" 2017-04-10 17:09:46 +00:00
jenkins-bot 77987b976d Merge "Remove #wpTextbox1 fallback from ArticleTargetLoader#requestPageData" 2017-04-10 17:05:03 +00:00
jenkins-bot edb911ef71 Merge "Dropping IE9: Remove disableUneditableContent from DesktopArticleTarget" 2017-04-10 16:50:59 +00:00
jenkins-bot 40265bd807 Merge "stylelint: Drop no-unsupported-browser-features references" 2017-04-10 16:49:15 +00:00
jenkins-bot c0361ab40e Merge "Update VE core submodule to master (da9c49395)" 2017-04-10 16:49:13 +00:00
jenkins-bot 17e1a3e3f2 Merge "Make Target#getVisualDiff async" 2017-04-10 16:02:05 +00:00
Ed Sanders 5266776953 Dropping IE9: Remove disableUneditableContent from DesktopArticleTarget 
Bug: T162277
Change-Id: Ibb38284573078098c2173232239e9836a8161f56
 2017-04-10 08:37:03 -07:00
James D. Forrester f51a6d5020 stylelint: Drop no-unsupported-browser-features references 
The rule hasn't been applied for a while, as it was deprecated upstream.

Change-Id: I7877d0e3bdcd05a609d61add2dc62d7598e348cb
 2017-04-10 08:36:37 -07:00
James D. Forrester d1c24ce226 Update VE core submodule to master (da9c49395) 
New changes:
dc0cad28c tests: Factor out ve.dm.TestRebaseClient/Server into their own files
98061108b Convert RebaseServer tests to data provider
3e746a51b Update OOjs to v2.0.0
16231a812 [BREAKING CHANGE] Drop support for Internet Explorer 9
64daeb4b5 Localisation updates from https://translatewiki.net.
3310e876c Update DOMPurify to 0.8.5
579033a83 Follow-up 16231a81: Drop IE9 support in createDocumentFromHtmlUsingIframe

Bug: T162277
Change-Id: If17c6a3fac0920db29f80069f344ffd6be46c3c9
 2017-04-10 08:32:51 -07:00
Ed Sanders 939a1f4005 VisualDiff: Fetch original doc from Parsoid if fromEditedState 
Bug: T160741
Change-Id: Ied0641cc868a8dd4cf540eba75e1b248277a96b0
 2017-04-09 22:28:53 +01:00
Ed Sanders ddf6a89c72 Remove #wpTextbox1 fallback from ArticleTargetLoader#requestPageData 
Makes the API clearer and the method re-usable.

Change-Id: If79afb262e0c8c8e2193c07fef6bb0712496a4d9
 2017-04-09 22:28:03 +01:00
Translation updater bot 603c520c28 Localisation updates from https://translatewiki.net. 
Change-Id: I4824487a4f9a1addb6863561b90d07ff22d50bfd
 2017-04-09 23:06:56 +02:00
Ed Sanders 97f6bdd79a Make Target#getVisualDiff async 
This will be required later when we have to fetch the original
document from the server before running a visual diff.

Change-Id: I351688f4d1fec892bc297f40c209939cbb2ccf95
 2017-04-09 13:26:22 +01:00
Translation updater bot 6f113eedfd Localisation updates from https://translatewiki.net. 
Change-Id: I354180d1b17eacfe0ba1ab883b240bbc6a2ffc14
 2017-04-07 22:54:56 +02:00
Ed Sanders 981dd6c250 Don't set oldid if it is equal to curId 
Change-Id: I0fff55ab1e8d9c5c24b39526aa5d8a893cd99a2a
 2017-04-07 11:49:30 +01:00
Roan Kattouw 1e7e9044c9 MWVESwitchPopup: Follow-up 445f8b76a0: apply adjustment to anchor instead 
Otherwise the anchor isn't correctly aligned below the icon.

Change-Id: I73a9db9be63354f1fa459e844eb40be1d3130189
 2017-04-06 16:33:53 -07:00
Roan Kattouw 445f8b76a0 MWVESwitchPopupWidget: Fix alignment by removing margin 
Since the PopupWidget rewrite, margins for aligning popup anchors
should be set on the anchor itself, not on the popup.

Change-Id: If8237ae5edbc2e8c5cb99147f392aae52e642765
 2017-04-06 11:50:43 -07:00
jenkins-bot d4438549e5 Merge "ArticleTarget: building summary in source mode, strip links from section titles" 2017-04-05 23:57:18 +00:00
Bartosz Dziewoński c45ad46433 Allow loading progress bar to appear on skins other than Vector and MonoBook 
The styles are not specific to the Vector and MonoBook skins, but rather
to the MediaWiki and Apex themes of OOjs UI. Rename them to reflect that.

Change-Id: I757e8d96625feb8290cbf7837b5d801961cda344
 2017-04-05 20:13:28 +02:00