wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-26 19:56:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Improve diff description on gallery nodes"

Browse source
This commit is contained in:
jenkins-bot 2018-04-04 16:50:03 +00:00 committed by Gerrit Code Review
parent 459f35924c 1159471730
commit 242eb68b96
2 changed files with 30 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js
View file

@ -120,6 +120,15 @@ ve.dm.MWGalleryImageNode.static.toDomElements = function ( data, doc ) {
return [ li ];
};
ve.dm.MWGalleryImageNode.static.describeChange = function ( key ) {
// These attributes are computed
if ( key === 'src' || key === 'width' || key === 'height' ) {
return null;
}
// Parent method
return ve.dm.MWGalleryImageNode.super.static.describeChange.apply( this, arguments );
};
/* Methods */
/**

21
modules/ve-mw/dm/nodes/ve.dm.MWGalleryNode.js
View file

@ -79,6 +79,27 @@ ve.dm.MWGalleryNode.static.toDomElements = function ( data, doc ) {
return [ ul ];
};
ve.dm.MWGalleryNode.static.describeChanges = function ( attributeChanges, attributes ) {
// Only do a comparison on the 'mw.attrs' attribute
if ( attributeChanges.mw ) {
return ve.dm.MWGalleryNode.super.static.describeChanges.call(
this,
ve.ui.DiffElement.static.compareAttributes( attributeChanges.mw.from.attrs || {}, attributeChanges.mw.to.attrs || {} ),
attributes
);
}
return [];
};
ve.dm.MWGalleryNode.static.describeChange = function ( key ) {
// Caption diff is shown in the DOM
if ( key === 'caption' ) {
return null;
}
// Parent method
return ve.dm.MWGalleryNode.super.static.describeChange.apply( this, arguments );
};
/* Methods */
/**