wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Refactor ve.dm.MWTransclusionNode.static.describeChanges"

Browse source
This commit is contained in:
jenkins-bot 2018-04-18 07:26:10 +00:00 committed by Gerrit Code Review
parent bc12e25b35 bcf3783c1c
commit 5ae421d715
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js
View file

@ -208,7 +208,8 @@ ve.dm.MWTransclusionNode.static.toDomElements = function ( dataElement, doc, con
};
ve.dm.MWTransclusionNode.static.describeChanges = function ( attributeChanges ) {
var change, params, param, $descriptions;
var change, params, param, $paramChanges,
descriptions = [ ve.msg( 'visualeditor-changedesc-mwtransclusion' ) ];
// This method assumes that the behavior of isDiffComparable above remains
// the same, so it doesn't have to consider whether the actual template
@ -247,22 +248,20 @@ ve.dm.MWTransclusionNode.static.describeChanges = function ( attributeChanges )
if ( params[ param ].from !== params[ param ].to ) {
change = this.describeChange( param, params[ param ] );
if ( change ) {
if ( !$descriptions ) {
$descriptions = $( '<ul>' );
if ( !$paramChanges ) {
$paramChanges = $( '<ul>' );
descriptions.push( $paramChanges );
}
if ( change instanceof jQuery ) {
$descriptions.append( $( '<li>' ).append( change ) );
$paramChanges.append( $( '<li>' ).append( change ) );
} else {
$descriptions.append( $( '<li>' ).text( change ) );
$paramChanges.append( $( '<li>' ).text( change ) );
}
}
}
}
if ( $descriptions ) {
return [ ve.msg( 'visualeditor-changedesc-mwtransclusion' ), $descriptions ];
}
}
return [ ve.msg( 'visualeditor-changedesc-mwtransclusion' ) ];
return descriptions;
};
/** */