Commit graph

4059 commits

Author SHA1 Message Date
Bartosz Dziewoński 890cec73b6 Pause polling for new replies while saving
Also fix stopPoll() not really stopping the polling if a request was
in progress while it was called.

Bug: T333576
Change-Id: Ie8f6f006c6fd23971e53586e6219992db23f48fc
2024-08-28 18:55:30 +02:00
Bartosz Dziewoński f76e47a3ef Keep sending CAPTCHA info if an unrelated save error happens
Bug: T371041
Change-Id: I72c73b0e323c794578edb14efcc9cc06e46a194b
2024-08-27 23:55:15 +02:00
Bartosz Dziewoński 4ff5bf253d Reattempt the save when something already created a temporary account
Bug: T368263
Change-Id: I2adcb83017daff578627aa02b04934be21eade44
2024-08-27 23:49:48 +02:00
Bartosz Dziewoński 5bb03b9e7f Fix missing definition of setSaveErrorMessage too
Follow-up to 6a17f6121c
and 4ec197a8cb.

Bug: T373288
Change-Id: I5250354fec0c217faa43a7fb2f51ee68c4116ab8
2024-08-27 23:15:06 +02:00
Translation updater bot f43e1fe58f
Localisation updates from https://translatewiki.net.
Change-Id: I485f8be44f143c904a1e590306e4514118b87114
2024-08-27 09:47:34 +02:00
jenkins-bot a74379a927 Merge "CommentController: fix a call to a missing setSaveErrorMessage" 2024-08-26 17:23:44 +00:00
David Lynch 4ec197a8cb CommentController: fix a call to a missing setSaveErrorMessage
Follow-up to 6a17f6121c, which refactored
this and missed altering this call.

Bug: T373288
Change-Id: Ic9b7b32a2fef209b4e873e2b28881a2792805051
2024-08-26 09:15:21 -05:00
Translation updater bot d144fbede6
Localisation updates from https://translatewiki.net.
Change-Id: I865efa626b6378d35dcf29da003401d2f2f3de77
2024-08-26 09:22:07 +02:00
libraryupgrader ad64e0b08c build: Updating micromatch to 4.0.8
* https://github.com/advisories/GHSA-952p-6rrq-rcjv

Change-Id: I935b2ff65db45ac17c49ab12a1e706d533140ece
2024-08-25 00:32:30 +00:00
Translation updater bot 2d3013134d
Localisation updates from https://translatewiki.net.
Change-Id: I199c25d5b38279a509529b8be9489d8d142951c1
2024-08-23 09:46:00 +02:00
jenkins-bot f57ee98ee8 Merge "Revert "Invert logic on empty talk page"" 2024-08-22 18:29:00 +00:00
DLynch f96eba7e6e Revert "Invert logic on empty talk page"
This reverts commit 7e5f9b59a2.

Reason for revert: Causes empty state to always appear on wikis using Talkpageheader

Bug: T373100
Change-Id: I23a3f937201d93c7c7645a09c4fccfcf1c14008a
2024-08-22 17:48:33 +00:00
Translation updater bot b4e9afe4a5
Localisation updates from https://translatewiki.net.
Change-Id: I562d90bfcffb387dc4200c610fe50df114f4e70f
2024-08-22 09:22:05 +02:00
Translation updater bot b2c8792e6f
Localisation updates from https://translatewiki.net.
Change-Id: Ie0843c91a6951f3b294a57284204cc9ca69e1a4b
2024-08-21 09:23:15 +02:00
Translation updater bot 9d1b2d7d9b
Localisation updates from https://translatewiki.net.
Change-Id: I5c569a4956ed321bbe400d089f817b62797e8eea
2024-08-20 09:42:46 +02:00
Translation updater bot 63937709e4
Localisation updates from https://translatewiki.net.
Change-Id: I4bd208735f8f01a597b2e291c34c3e061e111484
2024-08-19 09:23:04 +02:00
Arlo Breault 8245b94c4c Document shortcoming of CommentFormatter::isEmptyTalkPage
Follows-Up: I5c1877f7f9eb73f88a33e001ca3c2f3d06bb90e4
Change-Id: Idb74807c105062f81954917fe4e8296be2b428f6
2024-08-16 12:28:02 -04:00
Translation updater bot 51b17a6191
Localisation updates from https://translatewiki.net.
Change-Id: I165d762cfcffe32ca22309978a33b9aeb45b91db
2024-08-16 09:27:48 +02:00
jenkins-bot ccb4ad5c7a Merge "Revert "CommentFormatter: Switch from deprecated addJsConfigVars to new setJsConfigVar"" 2024-08-15 21:43:31 +00:00
jenkins-bot 2a6100b294 Merge "Invert logic on empty talk page" 2024-08-15 20:56:39 +00:00
Bartosz Dziewoński 3ec0789d06 Revert "CommentFormatter: Switch from deprecated addJsConfigVars to new setJsConfigVar"
Silence the deprecation warning instead to avoid regressing T372193.
I filed T372592 about the bigger problem we have here.

This reverts commit fe8526caf2.

Bug: T372499
Change-Id: I47884f99e9c18fffd22ffdc27f5c61515b60c8f8
2024-08-15 19:52:29 +00:00
Translation updater bot 87a70fa408
Localisation updates from https://translatewiki.net.
Change-Id: I06180b7ca64abc9432f0918175286b14033321d2
2024-08-15 09:20:16 +02:00
Arlo Breault 7e5f9b59a2 Invert logic on empty talk page
Record if a talk page is not empty, rather than empty.

This helps prevent Parsoid from mislabelling pages as empty when they
contain extension tags it needs to call out to the legacy parser to
process.  Metadata from the legacy parse is merged into the overall
metadata for the page.

For example, a templatestyles extension tag parsed in the context of a
talk page would set the empty state which would then fail to cleared if
the overall parse of the page wasn't empty.

Bartosz (@matmarex) proposed this idea in T371125#10053043

Setting and using these flags all appear to be post-retrieval from
cache.

Alternative to I1deb679ef0e19dc3a36e377c183dd1b4ab0003e9

Bug: T371125
Change-Id: I5c1877f7f9eb73f88a33e001ca3c2f3d06bb90e4
2024-08-14 18:26:25 -04:00
Arlo Breault 69fd71b260 Parsoid's templated content have other attrs as well
Bug: T372019
Change-Id: Ic1d32570f5fed4d48a126d0ef4c8c04a82d7bbb4
2024-08-14 17:30:31 -04:00
Máté Szabó 55665a3f93 Avoid primary DB query for non-talk page edits
While investigating primary database queries as part of T370304,
we found that EventDispatcher currently issues a primary DB query
to fetch the previous revision of the newly created revision on
every edit, but discards the result for non-talk pages. So, as an
optimization, have it fetch the previous revision only after the page
has been established to be a talk page.

Bug: T370304
Change-Id: I301f5c3c002c6953ef0b3919a33667a809342b84
2024-08-14 18:18:02 +02:00
Translation updater bot 5bf38331de
Localisation updates from https://translatewiki.net.
Change-Id: Ifeb1cb9d150b31f6a1ba71141fac04c68c4f6df4
2024-08-14 09:22:34 +02:00
Translation updater bot 51745c1e6b
Localisation updates from https://translatewiki.net.
Change-Id: I277829ef46718aeae45ccd998a68a3070cef5204
2024-08-13 09:50:45 +02:00
jenkins-bot 182c247930 Merge "Show confirmation prompt if trying to submit a new topic without a title" 2024-08-12 17:02:08 +00:00
Translation updater bot 2cff7ee06b
Localisation updates from https://translatewiki.net.
Change-Id: Iad1b29ba7a341eb2e403d30eaf51d804c5227878
2024-08-12 09:22:24 +02:00
libraryupgrader 32fc8c5ea9 build: Updating mediawiki/mediawiki-codesniffer to 44.0.0
The following sniffs are failing and were disabled:
* Generic.CodeAnalysis.AssignmentInCondition.Found
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition

The following sniffs now pass and were enabled:
* Generic.CodeAnalysis.AssignmentInCondition

Change-Id: I8adfdce01ea96f4b62dabd3dea130f9593c7e5ac
2024-08-11 06:40:14 +00:00
James D. Forrester fe8526caf2 CommentFormatter: Switch from deprecated addJsConfigVars to new setJsConfigVar
Bug: T372193
Change-Id: Ib3ec31ac78aee59325b3b1be3bb66f5c4a73715a
2024-08-10 13:51:50 +02:00
Translation updater bot 573172dfaf
Localisation updates from https://translatewiki.net.
Change-Id: I424d7d216d821bac09f4392137d6a203a9d516ab
2024-08-09 09:34:56 +02:00
Jon Robson f065c46e6b Dark mode styles should not apply to printed content
Bug: T371331
Change-Id: I5bd5e530d1262c7e52e1725959e07776ff9f3704
2024-08-08 20:32:16 +00:00
Translation updater bot 2364736d35
Localisation updates from https://translatewiki.net.
Change-Id: I602f6dacb0fa95f610b4f55cd7146621d9b89d55
2024-08-08 09:19:32 +02:00
Translation updater bot d7fa9ce947
Localisation updates from https://translatewiki.net.
Change-Id: I324e23e595dc1f3c1fb3d75654cf93a450cf1891
2024-08-07 09:23:58 +02:00
jenkins-bot 8c9ec66df3 Merge "Fix attachment of toolbar dialogs" 2024-08-06 20:27:30 +00:00
David Lynch da47997ef4 Fix attachment of toolbar dialogs
getToolbarDialogs defaults to the `side` position, but we actually want
the `above` one here.

Bug: T371341
Change-Id: Ib42f6a4877d3b0efb87199f60cce7a7416ce9b8a
2024-08-06 11:39:44 -05:00
Ed Sanders d8f564fe71 Show confirmation prompt if trying to submit a new topic without a title
Bug: T334163
Change-Id: Ib961632636d5b7134219cddde1638c6962209001
2024-08-06 09:44:27 -05:00
Ed Sanders 6a17f6121c Move reply widget controlling logic to CommentController
Some of what happens when you click reply happens in
CommentController (in #save) and some error handling
happens in ReplyWidget (in #onReplyClick).

Move most of the logic to CommenController.

Change-Id: Ib6208c0b8d2ddbbcf08adfcca7875ab8b026f598
2024-08-06 09:44:27 -05:00
jenkins-bot 2578d00536 Merge "Consistent spelling of "subpage"" 2024-08-06 11:26:52 +00:00
Translation updater bot f44e0f1628
Localisation updates from https://translatewiki.net.
Change-Id: I95113ea8a76a9512b3d3eab0864e61de30429f4f
2024-08-06 09:46:49 +02:00
Amir E. Aharoni 15f3f80378 Consistent spelling of "subpage"
"Subpage" is usually written as one word
in core and in other extensions.

Change-Id: Ie10a500790c321e866c02264d55449e42b0110bb
2024-08-06 03:44:51 -04:00
Translation updater bot b27574f0b6
Localisation updates from https://translatewiki.net.
Change-Id: Iac0943773d4374dbe07c4f439e4e1a14f5c6bdd8
2024-08-05 09:24:52 +02:00
Translation updater bot f093eb0605
Localisation updates from https://translatewiki.net.
Change-Id: Ib8b608177df8d5d47c7c79bbbd03fba1eecba2d5
2024-08-02 09:39:16 +02:00
Translation updater bot c72b4504ae
Localisation updates from https://translatewiki.net.
Change-Id: I5c70abb74e82a3336f9a447297b786524d670dc8
2024-08-01 09:18:18 +02:00
Hannah Okwelum 4403887e88 Prepare Less styles for math=parens-division
Bug: T368921
Change-Id: I4c6db2d39883d31cf4216da0e3d79136287bf960
2024-07-31 20:12:15 +01:00
Translation updater bot 1339083307
Localisation updates from https://translatewiki.net.
Change-Id: Ia201497ebce7aea52cb360a87ef36bc979b86d5b
2024-07-31 09:22:43 +02:00
Translation updater bot aa3e9b9645
Localisation updates from https://translatewiki.net.
Change-Id: I9c6c932b85b6678b4f659a5aef2549071480574d
2024-07-30 09:43:07 +02:00
Translation updater bot fc0e2ed1f2
Localisation updates from https://translatewiki.net.
Change-Id: I5c64f96b751f85ae95b7caa4f0f2e762f0bea7bf
2024-07-29 09:26:35 +02:00
Translation updater bot 925e22d345
Localisation updates from https://translatewiki.net.
Change-Id: I587a4e184716b808da346e8ef2896aed0a542da2
2024-07-26 09:44:31 +02:00