Commit graph

7487 commits

Author SHA1 Message Date
Alex Monk f3dd60dbe3 Hide extra space at the top of the single transclusion dialogs
Bug: T78045
Change-Id: I36974f69128a3e2c303076e3bd740f270e178c6b
2015-02-02 16:49:49 -08:00
jenkins-bot 3d6aa68c7c Merge "Use ActionFieldLayout in the template placeholder page" 2015-02-02 23:48:27 +00:00
jenkins-bot 4d53c5d86a Merge "Increase user-input delay in MediaSearchWidget" 2015-02-02 23:47:21 +00:00
jenkins-bot d3bcefffb6 Merge "Do not send search query on whitespace" 2015-02-02 23:46:53 +00:00
jenkins-bot 2388ee443c Merge "build: Bump devDependencies to latest" 2015-02-02 22:43:21 +00:00
jenkins-bot 17ac459ecb Merge "[BrowserTest] Add basic test for table creation" 2015-02-02 22:39:04 +00:00
James D. Forrester bed038b509 build: Bump devDependencies to latest
Updates:
* grunt-contrib-csslint  0.3.1  ->  0.4.0
* grunt-contrib-jslint   0.10.0 -> 0.11.0
* grunt-jscs             0.8.1  ->  1.2.0

For jscs, leaving requireSpacesInsideArrayBrackets to avoid headaches for now.

Change-Id: I62d34444edbba65c8bd22d2fa5e50e16cabb0042
2015-02-02 14:30:39 -08:00
Moriel Schottlender 7734e7e71f Do not send search query on whitespace
If the user inserts a whitespace to the search input we don't want
the API query to be sent out.

Change-Id: I8cd68a6039ca98e3d78c9f1aa88f4098a1a99edc
2015-02-02 14:20:29 -08:00
Elena Tonkovidova 0240a51717 [BrowserTest] Add basic test for table creation
Change-Id: I07022e27da9d7114c18a82cdbd62e4cb82ddc7e2
2015-02-02 15:15:13 -07:00
Moriel Schottlender 5d8108f229 Increase user-input delay in MediaSearchWidget
Increase the timeOut for the typing delay so we send search API
requests less frequently when the user types a search term.

Bug: T88188
Change-Id: Ibaf7184fb0eb9a02b460b0a66eabade791aea620
2015-02-02 14:01:49 -08:00
Translation updater bot 151a683743 Localisation updates from https://translatewiki.net.
Change-Id: I9382244c12e88bde8d58e42e55e40ba1457f1723
2015-02-02 22:32:25 +01:00
Moriel Schottlender 70fb0ea24f Use the new image cache in the media dialog
Prevent another api call for image sizing by caching the chosen
image in the media dialog with the imageInfoCache.

Bug: T88187
Change-Id: If2d905eeb5907f29b6839692509dfc07a06c230e
2015-02-02 19:32:46 +00:00
jenkins-bot d5f7bac940 Merge "Combine imageinfo requests" 2015-02-02 19:32:00 +00:00
Bartosz Dziewoński c0d69dd3db Wait with showing edit notices until after the welcome dialog is closed
Its white overlay is pretty good at obscuring them, and the notices popup
would close when the dialog is closed, making it very easy to miss them.

Also fixed indentation.

Bug: T86987
Change-Id: I9f93c4169de98ef77a1eb33fd31a0ec524b6d2b7
2015-02-02 17:25:02 +00:00
Ed Sanders f4bb7de786 Only re-render if the images is larger than the last rendering
Means we don't make unnecessary requests to the image API
and make the server side image resizer do extra work.

Bug: T88248
Change-Id: I20e1d37c913522eafc45a9a2e263051322b9b083
2015-02-01 13:07:48 -08:00
Alex Monk dc69b15db1 Template dialog: Disable 'Apply changes' until a change is made
Bug: T76926
Bug: T76927
Change-Id: I5a664f865c11690a19b754fc9877baf37e34edad
2015-01-31 03:19:06 +00:00
jenkins-bot 73e05df441 Merge "MWLinkTargetInputWidget: Check title is valid in MediaWiki" 2015-01-31 03:13:36 +00:00
jenkins-bot ed8f711b88 Merge "Don't corrupt href="./" in internal links" 2015-01-31 02:48:11 +00:00
Roan Kattouw 2bdb20b3c1 Don't corrupt href="./" in internal links
href="./" was being corrupted to href=""

Change-Id: Ieedd71a991c6b52225f2ac41ebe1a20e7533c19e
2015-01-30 18:44:57 -08:00
Alex Monk 9841d1012c Update "Watch this page" option when necessary
On load and change the user presses the button

Bug: T78694
Change-Id: I1df2836f8ba4ae647bfb142513e5de9f32ecd0fe
2015-01-31 02:43:59 +00:00
jenkins-bot cc6a629927 Merge "Use padding on save dialog panels so scrollbar is correctly positioned" 2015-01-31 02:31:02 +00:00
Ed Sanders e0d9b062d4 Use padding on save dialog panels so scrollbar is correctly positioned
Previously was using a margin so the scrollbar floated 1.25em from the
edge of the dialog.

Remove Apex-specific hack.

Change-Id: Idc953c492a6527a9216b77256d406fc3435ec0a9
2015-01-30 18:14:07 -08:00
ryasmeen@wikimedia.org eea130381a [BrowserTest] Updating test for Media Settings interface
Fixed the following:
1.The workflow was incomplete and incorporated new changes
2.Wrong css pointer to the first image
3.The Given statement was defined as When in step definition file
4.Removed unnecessary/obsolete steps that was making the test to fail while we can verify the basic functionality with miminum steps.

Change-Id: Ic8a265678900ed52bbed6d90e971d6c016ef610d
2015-01-30 18:11:33 -08:00
jenkins-bot 6230e80904 Merge "MWSaveDialog: Make the diff screen a larger rather than large size" 2015-01-31 02:02:21 +00:00
Moriel Schottlender a25ad02f60 Use ActionFieldLayout in the template placeholder page
Instead of manually attaching a button to the input widget, use the
newly available ActionFieldLayout.

Change-Id: I3a39f476e6115f97f11ea49fac5bfcd93bd8f841
2015-01-31 01:59:26 +00:00
Alex Monk 7876cc957a Combine imageinfo requests
By generalising LinkCache into ApiBatchQueue to request them all centrally

Bug: T75822
Change-Id: I097311ec2487bb1ae9f5d927c2c13c274ba716f9
2015-01-30 17:20:04 -08:00
jenkins-bot 7ff36511e4 Merge "Update VE core submodule to master (f2d7711)" 2015-01-31 00:59:28 +00:00
Ed Sanders e68eba2687 Update VE core submodule to master (f2d7711)
New changes:
4bb50c3 Localisation updates from https://translatewiki.net.
b7a5b87 dm.InternalList: Use DOM methods instead of jQuery .html()
5b09c9b Localisation updates from https://translatewiki.net.
b709d19 Add generic support of alignable nodes
a1f6c3d Localisation updates from https://translatewiki.net.
c29675a Add find next/previous to command help dialog
1e0b1ed Localisation updates from https://translatewiki.net.
7c76542 Don't render rowspan="1" colspan="1" for every table cell
99eb069 Show a message when an invalid regex is inputted in F&R

Local changes:
Bump command help height for new find next/prev commands

Change-Id: I0196775e499132262ba80acdbf1afc26ef4e8c77
2015-01-30 16:12:24 -08:00
Cmcmahon ee79759d5f [BrowserTest] remove old hack and fix "a is undefined" bug
This patch removes an old hack from the early days of VE.

Coincidentally, this hack is the root cause of the bug reported
by me, Erik Berhardson, and Elena Tonkovidova: T87446

Thanks Elena for finding this!

Bug: T87446
Change-Id: I325f60586373427acc2cd8f6e2e7d7accac80695
2015-01-30 22:56:15 +00:00
Cmcmahon fca9110172 [BrowserTest] make rubocop stop complaining
extra lines in the language_screenshot unit test file

Change-Id: I898ad4c1ce5537c02574dd340866260c18d14cee
2015-01-30 14:07:17 -07:00
Translation updater bot 5e0305eb8b Localisation updates from https://translatewiki.net.
Change-Id: I4baafaadd840e84219bfba88c0fb6a8d06cd7cbc
2015-01-30 21:53:17 +01:00
Moriel Schottlender beaa19dc91 Adjust to ooui's show/hide css change
The media dialog used a css hiding hack to make the panels work in
the stack layout. The ooui change in Ibf7c99aa makes this hack not
work and be unnecessary. This fix deletes it.

Depends on ooui change Ibf7c99aa

Change-Id: I57243f9e87c0fde90e069a311e22e96a5b207326
2015-01-29 17:25:50 -08:00
jenkins-bot 071b344353 Merge "Change uses of LookupInputWidget to LookupElement" 2015-01-30 00:44:08 +00:00
Translation updater bot e37cf11a1d Localisation updates from https://translatewiki.net.
Change-Id: I78db777ac7feacef76d179937e73999474f04388
2015-01-29 23:08:45 +01:00
jenkins-bot 4443349a11 Merge "Add a layout queue to media result widget" 2015-01-29 18:34:50 +00:00
jenkins-bot cc4e8e7ebd Merge "When changing image source, use already-available API info" 2015-01-29 18:34:03 +00:00
jenkins-bot e372b93c4c Merge "Lazy load the media search results" 2015-01-29 18:33:47 +00:00
Moriel Schottlender 3d60389ea0 Add a layout queue to media result widget
Use a queue for the method that lays out the result images in
the rows; this queue will only run if the widget is visible,
to make sure that the calculations of the masonry view work
as they should.

In better words: Only cue the queue if the widget is visible.

Bug: T86802
Change-Id: Ia8a30a6a5cccd98a1201443d672e4a6ab4aa946f
2015-01-28 18:01:47 -08:00
Moriel Schottlender e454b81f4d When changing image source, use already-available API info
When the user changes an image to another in the media dialog, we
already have API info that includes the original dimensions, media
type and other information that is required for the Scalable object
to compute the new current dimensions. We can use this info if it
exists instead of asking for another API call. Also make sure to
update the filename when we change an image in the dialog.

Bug: T87267
Change-Id: I9d86959b99b3f3dfed92255a9dba9a8fdd352dcb
2015-01-29 01:58:07 +00:00
Moriel Schottlender a44e0d2e5d Lazy load the media search results
* Set the src attribute only when the image is actually
  visible in the search results.
* Display the thumbnail image we have from the search
  results and then update with a larger one from the API.
* Request for more media results on a higher threshhold,
  when the user views 2 rows above the last available
  result.
* Correct the resizeToBoundingBox and simplify it to work
  properly for a non-square bounding box regardless of
  constraints.

Change-Id: If024b0335ce6a5d2d0eafdbfdfe1030dcaac3a75
2015-01-28 17:56:54 -08:00
jenkins-bot e9d770ed11 Merge "MWMediaDialog: Add contextual help for controls" 2015-01-28 23:42:01 +00:00
jenkins-bot a0a6937450 Merge "Use DOM methods instead of jQuery .html() in references DM code" 2015-01-28 23:38:01 +00:00
jenkins-bot f42d2ce23e Merge "Update permanent link and PDF download link oldids on save" 2015-01-28 23:33:53 +00:00
Translation updater bot 3be58aae9c Localisation updates from https://translatewiki.net.
Change-Id: I43042d50f50d6c610cd12f53e31e8bba95bf5b6f
2015-01-28 22:39:11 +01:00
Alex Monk f6bf40a19a Update permanent link and PDF download link oldids on save
Bug: T74461
Change-Id: Ic66de6e685d23cac1c9870529f42e1aa6348ac7a
2015-01-28 13:16:12 -08:00
Amir E. Aharoni f4d10e3ee6 [BrowserTest] Shorten all capture_screenshot lines
Change-Id: I01c11dfc4f4706d45e7bc62261ed133a7bd72092
2015-01-27 21:37:09 +00:00
Amir E. Aharoni 8da4c9b3cc [BrowserTest] Restore the indentation list screenshot scenario
* Add a class to the indentation toolbar button, similarly to what was done in
  Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
* Fix the definition of the indentation pull-down element acordingly.
* Restore the Indentation menu screenshot scenario, which was disabled in
  I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26

Change-Id: If2d92aab6d04aa487d6f753fa7cac94f8d8215c8
2015-01-27 13:35:39 -08:00
Amir E. Aharoni d20d70cdd6 [BrowserTest] Show the complete insert pull-down in screenshots
The "insert_pull_down" element only included the menu trigger.

Now it includes the complete pull-down with all the items.

This is consistent with other pull-down elements.

Change-Id: I3f6052eab1ee0322ebb7e6f2116e2d5d0e25f5b1
2015-01-27 13:35:39 -08:00
Amir E. Aharoni 3f31715c09 [BrowserTest] Consistent names for variables that refer to down-arrow
Change-Id: Ib7c799af449a9427f6ba25403cbd6b2d220133f0
2015-01-27 13:35:39 -08:00
Amir E. Aharoni 39afc66a91 [BrowserTest] Shorten lines for clarity
The 'I take screenshot of insert pull-down menu' step has many
similar very long lines. Shortening them makes
the code more understandable and conforming to the conventions.

Change-Id: I83b35211a6cbfdc420895469747884f3ae864479
2015-01-27 13:35:39 -08:00
Amir E. Aharoni 024481baae [BrowserTest] Simplify the Selenium selector for the Save button
The selector was very long and incorrect.

This patch simplifies and corrects the selector.

This also fixes the VisualEditor_save_dialog scenario
in the language_screenshots scenarios.

Change-Id: If822f1b2b8bda4d233dff5a88f6317ee1b0d57f1
2015-01-27 13:35:39 -08:00
Translation updater bot d64aa82c4a Localisation updates from https://translatewiki.net.
Change-Id: I1df981d0ac9a4eadf6bcdb81f3c0b50f10e61e43
2015-01-27 22:17:10 +01:00
Amir E. Aharoni 401c526d8a [BrowserTest] Remove extra empty lines to make Rubocop pass
Change-Id: I30be711ee021af3d33b52a957bddd6e76b23b9ae
2015-01-27 11:09:16 -08:00
Amir E. Aharoni c80e311a02 [BrowserTest] Fix VisualEditor toolbar actions scenario
The save button changed from constructive (green) to progressive (blue).

Change-Id: Ic410d5ed3847da803d6d83df7f77b6e0edc5d81b
2015-01-27 04:15:51 +00:00
Amir E. Aharoni 896c8b5d5f [BrowserTest] Change "Headings interface" to "Headings menu"
Change-Id: I8a50bdf1c49d80ec89c1d87d2a4e353f0aa1a3f9
2015-01-27 04:15:43 +00:00
Amir E. Aharoni 5b0e34fa4a [BrowserTest] Clean up the 'I am editing' scenario in language screenshots
Change-Id: Ieecbad486e4b0d2256452c66493ae3cec1643658
2015-01-27 04:15:20 +00:00
jenkins-bot 7dee4f18d7 Merge "Don't rely on 'user' and 'site' modules working correctly" 2015-01-26 22:31:28 +00:00
Roan Kattouw a10fe01f8b Use DOM methods instead of jQuery .html() in references DM code
Bug: T87417
Change-Id: I40df6258cd076911c68351300a488645db1d65d5
2015-01-26 14:06:56 -08:00
Translation updater bot f89fcadaa4 Localisation updates from https://translatewiki.net.
Change-Id: Iccd7bb8e1b399f4632ebe17c1f108b0864acdab0
2015-01-26 22:43:13 +01:00
Roan Kattouw 6623ff4197 Use DOM rather than jQuery for <base> resolution
Avoiding a Sizzle context switch, see https://github.com/jquery/sizzle/issues/311

Bug: T87416
Change-Id: I40dd2cb17f9c3d14d0ee1aa5b542263775feedb7
2015-01-26 10:00:32 -08:00
Roan Kattouw 711c509f81 dm.MWBlockImageNode: Use DOM methods rather than jQuery
To avoid triggering state thrashing in Sizzle
( https://github.com/jquery/sizzle/issues/311 )

Also account for the fact that missing attributes are returned
as undefined by jQuery but null by .getAttribute().

Bug: T87416
Change-Id: Ib3bc7971920c084568abb6ea0bd822d763b276f2
2015-01-26 09:46:55 -08:00
jenkins-bot fd6a2c0f74 Merge "ce.MWReferencesListNode: Remove unnecessary .show() call" 2015-01-26 06:30:55 +00:00
Translation updater bot 2eaf4bc7f1 Localisation updates from https://translatewiki.net.
Change-Id: I7d4da590bc19bc83e64b99a31ee5762c28bb1180
2015-01-25 21:52:03 +01:00
jenkins-bot e49a75a6cf Merge "Focus the add template input in the template dialog" 2015-01-24 03:24:43 +00:00
Moriel Schottlender 34f93bef08 Focus the add template input in the template dialog
Focus the page in the booklet layout so the add template
input is also focused at the opening of the template dialog.

Bug: T85484
Change-Id: Id9ae4653dc2a2e1d1dc16c83c540e22e30f4ea55
2015-01-23 17:55:26 -08:00
Roan Kattouw 154d2cb118 ce.MWReferencesListNode: Remove unnecessary .show() call
ce.InternalItem used to .hide() its .$element, but it doesn't
do this any more, so we don't need to counteract this with
.show() any more either.

Bug: T87160
Change-Id: Ic367508d821cc5c65678d4c878edc84911fd8178
2015-01-23 15:08:50 -08:00
Translation updater bot fb6eba3028 Localisation updates from https://translatewiki.net.
Change-Id: Iec49a3b85c54c8bf208e663887504243fe5a4e26
2015-01-23 22:31:26 +01:00
Moriel Schottlender d0f1a02aec Increase the space between the title and text in media dialog
Make the spacing between the image title and the description
the same as the space between the description and the metadata.

Bug: T87451
Change-Id: I0d0051cd66072861019b904980c405fa05145b2b
2015-01-23 12:19:51 -08:00
Alex Monk 34e4c6a51b Check for venotify on page load, not when VPT is created
Not sure what could have broken this or when. Or if it ever worked to be honest...

Bug: T58921
Change-Id: I069b5ccb4a78a6790e5791354402503676faa7fa
2015-01-22 23:50:02 +00:00
Translation updater bot c9f6bfbbfa Localisation updates from https://translatewiki.net.
Change-Id: I7f7750931f23b1b569a6926f863ce18c90f8d81a
2015-01-22 23:24:06 +01:00
James D. Forrester d8f342a640 MWMediaDialog: Add contextual help for controls
Bug: T53798
Bug: T75731
Change-Id: Ideae0052c366a8c4e03285270569e5c5ca608ad8
2015-01-20 15:53:31 -08:00
Translation updater bot c6f3da6d46 Localisation updates from https://translatewiki.net.
Change-Id: I3a7f7e1e0130bffe5ac246cb1e52926a38ee0c51
2015-01-20 22:01:56 +01:00
jenkins-bot d7c80d4cf2 Merge "MWMediaDialog: Make the dialog bigger when searching for media to insert" 2015-01-20 19:52:11 +00:00
jenkins-bot dc7248031d Merge "Don't add __STATICREDIRECT__ whenever the user sets up redirect details" 2015-01-20 01:09:52 +00:00
Alex Monk d94c25a5b1 Don't add __STATICREDIRECT__ whenever the user sets up redirect details
OO.ui.CheckboxInputWidget#getValue was returning strings "true" or "false"
We want to use isSelected (and setSelected to set things instead of setValue,
I guess.)

Bug: T86827
Change-Id: I0b4b8dca00a4aeae4498a30d73e5eaa7c804115f
2015-01-19 23:32:55 +00:00
Alex Monk f0f2912c9d Actually perform interwiki check in MWLinkTargetInputWidget
Fixes my idiocy in I4b08f1c6

Bug: T72504
Change-Id: I1a7f14fc7f7169ac85eacd4e12a56acff1fe32ae
2015-01-19 22:49:38 +00:00
Translation updater bot e2d953449b Localisation updates from https://translatewiki.net.
Change-Id: Ief7e3f530425a52b78da8099bab104bafc86808d
2015-01-19 22:05:44 +01:00
Translation updater bot 037d49c4ac Localisation updates from https://translatewiki.net.
Change-Id: I1d27554446b015c5192ff7295dd82f0fc7d19b40
2015-01-18 22:23:12 +01:00
James D. Forrester 7daf17fadc MWMediaDialog: Make the dialog bigger when searching for media to insert
Bug: T86397
Change-Id: I40e78441dd555dff837516220653b1c54bf5af92
2015-01-16 16:29:26 -08:00
James D. Forrester 9625bd2c99 MWSaveDialog: Make the diff screen a larger rather than large size
Bug: T78823
Change-Id: If14acbeb8449e27e692bc52556c1d31305b4c54a
2015-01-16 16:04:05 -08:00
Translation updater bot e9e44ac3b8 Localisation updates from https://translatewiki.net.
Change-Id: I436fb1af5eeddbeb5212134bb1551731971c8f16
2015-01-16 21:22:10 +01:00
jenkins-bot f82b486e74 Merge "Mark interwiki links as known in LinkTargetInputWidget" 2015-01-16 19:18:47 +00:00
Moriel Schottlender 061925be87 Add filename to the media dialog
Show the currently used filename at the top of the media dialog so
it can be copied and used in other pages if needed.

Bug: T54459
Change-Id: Ib1844c997189f7ead0656c5a811d3cab70030f89
2015-01-16 17:40:40 +00:00
Ed Sanders e3284dd078 Tweak margins on media info page
Change-Id: I5434c3ade332de22f6b6cf058dc2f1e402524959
2015-01-16 13:34:25 +00:00
jenkins-bot 2ebdf34c29 Merge "Transform the search widget to show image details" 2015-01-16 13:26:25 +00:00
Moriel Schottlender 4947420650 Transform the search widget to show image details
Add an info panel to the MediaDialog to show the user information
about the chosen file from the new extmetadata API.

Also, change the way results are viewed:
* Present the search results with their proper ratio.
* Use masonry fit for the search results.
* Change the resizeToBoundingBox method in ve.dm.MWImageNode to accept
  a specific side constraint, either 'width' or 'height'. This is also
  going to be useful for adding and calculating 'scale' considerations
  that affects the image height.
* Add info panel with details from extmetadata including author, license,
  date of upload and creation, etc.
* Get descriptions and data according to wiki language.

Bug: T78161
Bug: T74061
Change-Id: I7b4d019825aa89dd178665bd9492a07af15954ac
2015-01-16 13:22:54 +00:00
Alex Monk 1e8929993d MWLinkTargetInputWidget: Check title is valid in MediaWiki
Bug: T86709
Change-Id: Ia399d3e8847d520b5d57baa302de8197fdea0787
2015-01-16 02:46:22 +00:00
Bartosz Dziewoński 6de4ed2f26 Change uses of LookupInputWidget to LookupElement
Also moved around some code from MWCategoryInputWidget to
MWCategoryWidget to be a bit less evilly interdependent.

Change-Id: I0b8a58fb669e232a990b19c4b7f872a320bfab58
2015-01-15 18:26:30 -08:00
Translation updater bot 1a4c821dad Localisation updates from https://translatewiki.net.
Change-Id: I4464b2cedef4d2700d017a17bdc32cb2fed24629
2015-01-15 22:51:46 +01:00
Translation updater bot 3a5f538e38 Localisation updates from https://translatewiki.net.
Change-Id: I5a7293e28d87145ab7d9f1af6adc3cad11e4c20e
2015-01-14 22:43:04 +01:00
jenkins-bot 049b5798f2 Merge "[BrowserTest] Add test for missing parameter error msg" 2015-01-14 16:14:42 +00:00
Cmcmahon 295f9f81b1 [BrowserTest] Add test for missing parameter error msg
Test checks for 'Required parameter missing' message, 'Go back'
and 'Continue anyway'.

Paired with Rummana writing this

Change-Id: I9c3aab7f7af9ccde8f0dadd2839a7a698f7341ee
2015-01-14 16:04:12 +00:00
Cmcmahon 7b9cf21dec [BrowserTest] update Cite test for new Journal fields
Maintenance

Change-Id: I36d0c8b438e8fa1847c3947ad52e15d2aadbcfb6
2015-01-13 15:14:26 -07:00
Bartosz Dziewoński 4cce592cce Don't rely on 'user' and 'site' modules working correctly
I think somebody somewhere pointed to this as the reason why VE
wouldn't load when user's common.js has syntax errors, but I actually
can't reproduce that. Not sure if this is needed, but looks like a
good idea anyway.

(Once more, with feeling. Reverted broken attempt: aa531488.)

Change-Id: I252c5c20f75b3bbea51200560408dc4cfc7174f6
2015-01-13 19:18:54 +00:00
jenkins-bot c878a3e7e9 Merge "build: Bump copyright notices to 2015" 2015-01-13 16:21:37 +00:00
jenkins-bot 4e5d279b85 Merge "Toolbar: Make save button progressive, not constructive" 2015-01-13 15:35:46 +00:00
Amir E. Aharoni 7c128f9a4a [BrowserTest] Make the Save page element language independent
This element used the English label. It should just use
the class to be language independent.

I tested by running VisualEditor_save_dialog scenario
in language screenshots for the Persian language. It fails
on master because of the English label and passes with this commit.

Change-Id: I77955b3dfabbf6a15885c085e3fbdd447b04b4db
2015-01-13 13:05:35 +02:00
jenkins-bot 19270a31d0 Merge "[BrowserTest] Change the Heading menu item from a to span" 2015-01-13 10:25:31 +00:00
Amir E. Aharoni 7a4ec947fa [BrowserTest] Change the Heading menu item from a to span
Change-Id: I214f8dbc73e38073f6e8dedfb61d75b1e829fa38
2015-01-13 12:21:10 +02:00
Amir E. Aharoni 919d62e66c [BrowserTest] Remove the page settings scenario from language screenshots test
It will be fixed later. It needs better element definition
to run successfully, and until it's properly fixed
it should be disabled to let other jobs pass.

Bug: T86634
Change-Id: Id41d1329d22679b6a61201ceafc81eafa222d909
2015-01-13 12:14:44 +02:00
James D. Forrester 2f8b3e0d96 build: Bump copyright notices to 2015
Change-Id: Ie92dab7411116d3410195c3fb0a3513c664c0c30
2015-01-12 20:34:19 -08:00
James D. Forrester 6ce2210222 Toolbar: Make save button progressive, not constructive
Bug: T86507
Change-Id: I082d1b4ba09abf74e4c6438ef8b93fcc7de7a41b
2015-01-12 17:50:45 -08:00
Translation updater bot dd318fc581 Localisation updates from https://translatewiki.net.
Change-Id: Ic824b48cbadb9038feb580deaab3309b27198c30
2015-01-12 22:40:30 +01:00
Moriel Schottlender cc293dc4c4 SurfaceWidgets should listen to history
The history event reflects actual changes, rather than the transact
event that masks staged changes done to the document.

Bug: T85845
Change-Id: I1faeb97677540f08c512b48b47fafe28b1072579
2015-01-12 11:51:44 -08:00
jenkins-bot 213c0a2367 Merge "Revert "Don't rely on 'user' and 'site' modules working correctly"" 2015-01-12 19:00:28 +00:00
Jforrester c17e3f89c6 Revert "Don't rely on 'user' and 'site' modules working correctly"
This reverts commit aa53148852.

Bug: T86550
Change-Id: Id97dec739939312caaa10d36197f105a595c1365
2015-01-12 18:49:39 +00:00
jenkins-bot 2b9dc1a129 Merge "Don't rely on 'user' and 'site' modules working correctly" 2015-01-12 04:00:15 +00:00
jenkins-bot 474ef13158 Merge "ve.dm.{MWTransclusionModel,MWTemplateModel}: Remove unused parameters" 2015-01-12 01:17:26 +00:00
Translation updater bot c27bd6f881 Localisation updates from https://translatewiki.net.
Change-Id: I9febe4590309b6f4ff6ace943a541f075781ae31
2015-01-11 22:17:51 +01:00
Bartosz Dziewoński 9e5ec5cefb ve.dm.{MWTransclusionModel,MWTemplateModel}: Remove unused parameters
The 'origin' parameter to the constructors has been removed in 51e096d6.

Change-Id: I885f75c381cea013d32d408c7b26de0fa00629c2
2015-01-11 19:25:17 +01:00
Bartosz Dziewoński aa53148852 Don't rely on 'user' and 'site' modules working correctly
I think somebody somewhere pointed to this as the reason why VE
wouldn't load when user's common.js has syntax errors, but I actually
can't reproduce that. Not sure if this is needed, but looks like a
good idea anyway.

Change-Id: I3abecacf083c1c9dfb2ea30207a9911eeea54b50
2015-01-11 19:01:56 +01:00
Translation updater bot a9f3abbead Localisation updates from https://translatewiki.net.
Change-Id: Ie1981123c61c1129c6488118360c89d665a8bb3d
2015-01-10 22:04:08 +01:00
Translation updater bot 971c6f5008 Localisation updates from https://translatewiki.net.
Change-Id: I8157bd61e0de7daafc8115f975ab45d19cbebe8e
2015-01-09 22:11:58 +01:00
jenkins-bot 7e6cfdf21d Merge "Fix styling of MWCategoryWidget to match MW theme" 2015-01-09 16:36:52 +00:00
Translation updater bot 560cd3edf7 Localisation updates from https://translatewiki.net.
Change-Id: Idce084c8d64bef11dcef790d2c545e5f5cb31965
2015-01-08 22:48:32 +01:00
Ed Sanders 144132bd01 Fix styling of MWCategoryWidget to match MW theme
Having MWCategoryInputWidget inherit from ButonWidget makes things a lot easier.

The mousedown behaviour and the positioning of the popup need work but
that is unrelated to this patch.

Bug: T78039
Change-Id: Ic43e64a6a74b8679a15aa8031207ab722e061ab4
2015-01-08 12:40:15 +00:00
jenkins-bot a84aff99f5 Merge "Work around $.parseHTML( '' ) returning null" 2015-01-07 20:06:38 +00:00
Roan Kattouw f71054d67d Work around $.parseHTML( '' ) returning null
$.parseHTML() always returns an array, except in this one case,
so checking .length of the return value almost always works except
when it blows up in your face.

Filed upsteam as https://github.com/jquery/jquery/issues/1997

Bug: T86056
Change-Id: If133a9df4d573b41b0ecb5bde47b3e6ada053921
2015-01-07 21:02:17 +01:00
jenkins-bot 9b11db5f18 Merge "Use ParsoidVirtualRESTService" 2015-01-07 01:51:06 +00:00
Alex Monk f8e09abdc8 Use ParsoidVirtualRESTService
Breaking change: Introduces new dependency on php5-curl package.

Relies on Id658d925 which introduces this class into core.

Bug: T1218
Change-Id: I2342fa5b0a185f3e8d46d1ba8fa08278970cafb0
2015-01-07 01:43:46 +00:00
jenkins-bot d4aa0aef7f Merge "Add classes to toolbar UI elements" 2015-01-06 20:02:45 +00:00
Alex Monk e2fa665333 Mark interwiki links as known in LinkTargetInputWidget
Bit messy at the moment.

Bug: T72504
Change-Id: I4b08f1c6d70f371f7f9a05d0856111721f4edb35
2015-01-06 02:15:02 +00:00
Alex Monk 9966298593 Re-focus edit summary input when save dialog is ready
I thought this was already being done elsewhere and so removed it back in Ifb8fd9be

Bug: T75675
Change-Id: Ia015c96ec8332af75428f156e4ed7a25184db96b
2015-01-06 00:54:02 +00:00
Translation updater bot afb0ba2eb1 Localisation updates from https://translatewiki.net.
Change-Id: I9c079b997f247fdef38631d1246842f50fab3c80
2015-01-05 23:09:03 +01:00
jenkins-bot d3194051e7 Merge "MWSaveDialog: Correct whitespace" 2015-01-05 21:09:08 +00:00
Bartosz Dziewoński 74db35b93c MWSaveDialog: Correct whitespace
Change-Id: I9f2ad375bc04e798aa4d2f2a8097a4af0a2b2e4d
2015-01-05 22:05:42 +01:00
jenkins-bot edad08090d Merge "Fix save dialog styling for MediaWiki theme" 2015-01-05 19:33:18 +00:00
Ed Sanders 85988c67ce Fix save dialog styling for MediaWiki theme
* Remove rounded corners.
* Change which borders are used as they change colour on focus.
* Fix margins.

Change-Id: I44f725dfeec5c26f95ba5368ca3848272d66e5be
2015-01-05 19:20:30 +00:00
jenkins-bot 178fdf284c Merge "Fix teardown order of MWAlienExtensionsInspector" 2015-01-05 18:18:54 +00:00
Ed Sanders 9a3c03b553 Fix teardown order of MWAlienExtensionsInspector
Local teardown process was jumping to the front of the queue
resulting in the attributeInputs being emptied before they
were read in updateMwData.

Bug: T85818
Change-Id: I24cb490996048e514895c359dedf5945acdecb0a
2015-01-05 17:58:31 +00:00
jenkins-bot d68c2daa86 Merge "Don't break "Edit source" link after VE has closed" 2015-01-05 13:28:42 +00:00
jenkins-bot 472e149e4b Merge "Update bugzilla links to phabricator" 2015-01-05 12:07:36 +00:00
Translation updater bot deaa5e5cd3 Localisation updates from https://translatewiki.net.
Change-Id: Ibdecb2cc7d096863ec5540b87e40c4516ff5ddd1
2015-01-04 21:52:03 +01:00
Translation updater bot 1653fcc5eb Localisation updates from https://translatewiki.net.
Change-Id: Ic7c6d5c09ff4ac961ee21ca8ce55a317576e4636
2015-01-03 23:06:07 +01:00
Translation updater bot 3ca91ba1d7 Localisation updates from https://translatewiki.net.
Change-Id: I1a2c3fd79e011161ee7895ef73708f8c1f37294b
2015-01-02 22:39:24 +01:00
Alex Monk b539bcd4af Update bugzilla links to phabricator
Bug: T75733
Change-Id: I4bf870b19feac0ee10677829daeb3d46eba3d9d6
2015-01-02 15:47:28 +00:00
Alex Monk 9600d28ebc Don't break "Edit source" link after VE has closed
Bug: T85552
Change-Id: I6db6fcff24110e749e3a0c1aa7c0528527b53d44
2014-12-30 21:07:04 +00:00
Translation updater bot 80b39cd2d1 Localisation updates from https://translatewiki.net.
Change-Id: I25f7afc115e59f7c84f2db939b6c8867206001d8
2014-12-30 21:15:14 +01:00
Amir E. Aharoni cd4bd7a73c Add classes to toolbar UI elements
This cleans up the selectors for the elements on the toolbar
so that they can be tested.

Class names in the form of ve-test-* are added to elements
that have words for labels: 'Paragraph', 'Cite', 'Insert'.
There is no other way to look up these elements in the DOM
except using the UI text, but it is different in different languages,
so this is unusable for the language_screenshots job,
which is multilingual by its nature.

Bug: T76143
Change-Id: Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
2014-12-30 12:16:44 +00:00
Translation updater bot b803443193 Localisation updates from https://translatewiki.net.
Change-Id: I118b0b297529683205d4e141174e96b6005ff3d8
2014-12-28 21:47:44 +01:00
Amir E. Aharoni 84629d1b6c Clarify a comment and correct its spelling
Change-Id: Idd1334d60822a1bfaae2354bca6cb277016f81f7
2014-12-28 00:51:52 +02:00
Translation updater bot cad2056fc9 Localisation updates from https://translatewiki.net.
Change-Id: I2071d84053b2d3465bc66018fc1cbd9bc603d769
2014-12-27 19:55:21 +01:00
Translation updater bot d8e22ca0a0 Localisation updates from https://translatewiki.net.
Change-Id: I48159d5b2b76b993e7308639a84759111e68284e
2014-12-26 09:48:42 +01:00
Translation updater bot 1d73f6b19f Localisation updates from https://translatewiki.net.
Change-Id: I1b29109b8a6ed00d52b7c46ca062394c9f792e57
2014-12-23 21:43:58 +01:00
Translation updater bot fc5451f68b Localisation updates from https://translatewiki.net.
Change-Id: If171c89cdcb8ae66743560d72833590ba4976034
2014-12-22 22:48:38 +01:00
Translation updater bot 0458bd4be3 Localisation updates from https://translatewiki.net.
Change-Id: I0bf3cc41c2cb942c30c9a2ff58744e3ee8253ae8
2014-12-20 22:29:34 +01:00
Cmcmahon 2ebbd0f038 [BrowserTest] This test is unreliable in any version of Chrome
The issue is that when running automatically, upon loading the
page to be edited a second and third time, the cursor ends up
in a random place within the existing text of the article.

The test expects the cursor to always be at the start of the
article text, and this happens in Firefox.

I did a cursory check and I could not reproduce the issue of random
cursor placement upon multiple edits to the same article. There
may be a bug here, but it is not trivial to reproduce.

So let's take this test out of the Jenkins builds in the service
of more reliable green tests.

Change-Id: Ie3dd76c5b40f3035d43e6f0a06327adb70900f60
2014-12-19 09:34:20 -07:00
Translation updater bot a5d417f43f Localisation updates from https://translatewiki.net.
Change-Id: I2f9bb82c98b8091a4150c2b457a815b0576da4ba
2014-12-18 23:24:17 +01:00
Amir E. Aharoni a74a4b49de Remove unnecessary translated messages
visualeditor-help-link is marked as notranslate.

Change-Id: I22ddbf0d51d2753b43a78f8ef879aec1d30a1473
2014-12-18 18:08:19 +02:00
Ed Sanders f49bbf783a Update setupToolbar signature in mobile target
This method now takes arguments to make sure they are passed.

Bug: T78710
Change-Id: Ifba696c2a1b60690bdccd1b58d347c254dec5432
2014-12-18 11:25:34 +00:00
Alex Monk c5d927552a Fix Ia6bf604c: Update another caller to ve.init.mw.Target
MobileViewTarget.

Due to this being missed, pageName was getting set to a jQuery object,
which eventually got passed as a data value in a $.ajax call, causing
jQuery to emit a TypeError: Illegal invocation.

I guess this needs a MobileFrontend commit as well. Don't think it fixes
all the issues with loading VE mobile though.

Bug: T78710
Change-Id: I431a902563f608a7a33028cd60112f39c57000a4
2014-12-18 00:59:04 +00:00
Translation updater bot 9ee82f6e38 Localisation updates from https://translatewiki.net.
Change-Id: I0fe19c57399f18ac8707791b2dc272d8ffde3976
2014-12-17 21:52:20 +01:00
jenkins-bot f1103d2bf0 Merge "VE-MW fix commit for I4efbae614e" 2014-12-17 20:03:46 +00:00
Cmcmahon a479d04299 [BrowserTest] clear default text before entering search text
Change-Id: Ief375c95ebee65a1add2fdf1b7c45e600df181a3
2014-12-17 10:37:27 -07:00
Cmcmahon 4fbd141b49 [BrowserTest] update test for new selector
Change-Id: Ic3bc3b416bc7ddadef7a05699f6181c0b7b84cdd
2014-12-17 10:22:44 -07:00
Cmcmahon c34fd60a9b [BrowserTest] update general markup test
refactor for new locator

Change-Id: I089aebb64a9d67d01c1bfa4682927c0de2575051
2014-12-17 09:31:24 -07:00
Cmcmahon 30c3aa2242 [BrowserTest] update Links test
another iframe gone it seems

Change-Id: I33767706675bbdcd1cb45f33da109858ec36986e
2014-12-17 08:51:17 -07:00
jenkins-bot 4de775b4d4 Merge "[BrowserTest]Fixing options test Fixed the unique selector for failing cases Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915" 2014-12-17 15:09:22 +00:00
ryasmeen@wikimedia.org 5eff6e8aa1 [BrowserTest]Fixing options test
Fixed the unique selector for failing cases
Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915
2014-12-16 17:36:50 -08:00
jenkins-bot 9b3d3080ce Merge "Remove use of bind() for inline functions" 2014-12-17 00:13:22 +00:00
jenkins-bot b4bf8a11ca Merge "Update VE core submodule to master (fe2d908)" 2014-12-17 00:08:48 +00:00
Roan Kattouw 08bebc9b2b VE-MW fix commit for I4efbae614e
Local changes:
* Call bindHandlers()/unbindHandlers() in activate/deactivate
* Extend onDocumentKeyDown rather than overwriting it

Change-Id: I0739e71781c5140c54512ab421bdcb6d1df5fbbe
2014-12-16 15:42:27 -08:00
Timo Tijhof 2b7ae8c175 Remove use of bind() for inline functions
Follows-up b0e8900, 447e8de, d3f26e65.

Contrary to binding a reference, this-overiddes for inline
functions gets messy and fragile. There's also a minor
performance overhead that can be avoided. No separation of
concerns, eiter, as the object is held by the closure.

Also:
* Remove left-over instances of @method.
* Remove redundant '0' argument to setTimeout.
* Use null instead of $ for apply() on static methods like $.when.
* Use .empty().append() instead of .html(). Does the same but
  without additional overhead and without confusion association
  with "html" which isn't used (it doesn't serialise and re-parse
  or clone, it just appends when given one or more nodes).

Change-Id: I797a3667c67d52568150be9be5d043d149f22077
2014-12-16 23:27:53 +00:00
jenkins-bot 6ca0046599 Merge "[BrowserTest] changing the css paths for Cite options for fixing the tests" 2014-12-16 22:36:50 +00:00
ryasmeen@wikimedia.org aa77e8ab4f [BrowserTest] changing the css paths for Cite options for fixing the tests
Change-Id: Iea90e4bb656b30ec0839e6c843e30ba8ae1fd637
2014-12-16 15:33:37 -07:00
Bartosz Dziewoński 08654b4f60 Update VE core submodule to master (fe2d908)
New changes:
fd433fa Add getter for toolbarDialogs in ve.ui.Surface
00c3eb7 Add 'done' button to find and replace dialog
3642dc8 Localisation updates from https://translatewiki.net.
fe2d908 Update OOjs UI to v0.6.0

Local changes to ve.ui.MWFormatTool.css for OOjs UI breaking change.

Change-Id: I6bf98ea988b3e1deb4824189ef8e6d59387b6ffc
2014-12-16 13:27:43 -08:00
jenkins-bot ae8f07810d Merge "[BrowserTest] Adding tests for checking fields under Page Settings" 2014-12-16 21:14:28 +00:00
Translation updater bot a34a9c84b6 Localisation updates from https://translatewiki.net.
Change-Id: Ia0d711b180f8c463792416953365a6f71188f52c
2014-12-16 21:59:09 +01:00
jenkins-bot d71492731d Merge "Set 's' accesskey on save button inside save dialog" 2014-12-16 18:57:56 +00:00
jenkins-bot 0de05ea219 Merge "Edit/view source tab: Do not hijack middle click to display confirmation, only left click" 2014-12-16 07:57:26 +00:00
ryasmeen@wikimedia.org a8807c6af4 [BrowserTest] Adding tests for checking fields under Page Settings
Change-Id: I31d8d3327bd8abe6a7c5f3c4941174253104bbac
2014-12-15 21:37:42 +00:00
Translation updater bot 8133ef4aa8 Localisation updates from https://translatewiki.net.
Change-Id: Id6a2c0136078d95c537ef63e3d5d02d2b0fe581a
2014-12-15 22:20:53 +01:00
Alex Monk 0d0172d43b Set 's' accesskey on save button inside save dialog
Can be done much nicer than I expected last time I looked at this task

Bug: T76161
Change-Id: I9541cd9dac69330ed8a802f301617619221bc263
2014-12-15 21:07:54 +00:00
Alex Monk f9339d070b Edit/view source tab: Do not hijack middle click to display confirmation, only left click
Middle click is supposed to open the link in a new tab.

Bug: T78546
Change-Id: I594f1dff072d54c0a8d7112a1eaa0c1c84d0ffc1
2014-12-15 20:24:11 +00:00
Translation updater bot 706413c211 Localisation updates from https://translatewiki.net.
Change-Id: Iff486cf59d6adef1cc9ccc4c5ce4c8e4f85e53aa
2014-12-14 22:25:34 +01:00
Translation updater bot 44514b947e Localisation updates from https://translatewiki.net.
Change-Id: I3422f33ebcd78c2a40c93d93684768b84f5dbd5e
2014-12-13 22:39:50 +01:00
jenkins-bot e6997350ba Merge "Check for stopped propagation before showing close dialog" 2014-12-13 00:52:57 +00:00
Ed Sanders 9459e4e240 Check for stopped propagation before showing close dialog
Various VE elements use escape to perform tasks. Particularly
difficult are OOUI dialogs which listen to the document and thus
fire after this target's listener, so defer and check if the
event was previously stopped.

Bug: T78201
Change-Id: Ie335f199766923833588202626c3af8e4cbcb9b5
2014-12-12 22:38:40 +00:00
Bartosz Dziewoński 29ff7b737e Rename some things for my sanity
Change-Id: I101943fa027947e73f7f7559bd706faadad90e95
2014-12-12 20:49:00 +00:00
Bartosz Dziewoński 16e8255f69 Update VE core submodule to master (b5e2b87)
New changes:
96d0936 Mark primary buttons as progressive as well
68f184c Localisation updates from https://translatewiki.net.
b96c9dc [BREAKING CHANGE] Rename method cmpOffsetPaths to compareOffsetPaths
862f31d Convenience compareDocumentOrder method
b5e2b87 Update OOjs UI to v0.5.0

Local fixes to correct for breaking change I32608c7f in OOjs UI.

Change-Id: I64f5e2f6ccc0056bfa9eda5e65e87789b97b8ad5
2014-12-12 12:29:05 -08:00
Translation updater bot a423784963 Merge "Localisation updates from https://translatewiki.net." 2014-12-11 22:59:37 +00:00
jenkins-bot 87143d4c36 Merge "Mark primary buttons as progressive as well" 2014-12-11 22:59:04 +00:00
Translation updater bot a76f1eff93 Localisation updates from https://translatewiki.net.
Change-Id: I5061faa84a867f5ff99a871aab597280d048ab38
2014-12-11 23:57:57 +01:00
James D. Forrester 57a68d082b Mark primary buttons as progressive as well
Also make save button primary.

In anticipation of Iee91d2c6 in OOjs UI

Change-Id: I123044bfaba631866ad32a35643f23686a17a16f
2014-12-11 22:55:16 +00:00
jenkins-bot fcdae1deba Merge "Fix image alignment in media dialog search" 2014-12-11 22:25:46 +00:00
Moriel Schottlender fbb6cd92b4 Fix image alignment in media dialog search
Make the image results align to the full width of the dialog. This
fix uses dynamic values of the width of the container rather than
a hard-coded value so it should work properly on all themes.

Bug: T78050
Change-Id: I05bb0d8a8b13c246840382b12e098d0579180016
2014-12-11 17:15:25 -05:00
Ed Sanders 45518019eb Update VE core submodule to master (9ac8136)
New changes:
9929b6d [BREAKING CHANGE] Make ve.init.target an OO.ui.Element

Local changes:
* Fix target constructors now they generate this.$element

Change-Id: Ia6bf604c67305834a3f73863a10336cfbb83fa77
2014-12-11 14:00:28 -08:00
Ed Sanders d6067d5718 Update VE core submodule to master (cf1e167)
New changes:
776e801 Delimit text nodes in debug observations
72643bc Remove debug bar hiding now it is handled by the surface
cf1e167 [BREAKING CHANGE] Multiple surface support and demo

Local changes:
Account for detachable toolbars in core being setup in a different order.

Change-Id: I29156948711d55ba5f6dd4f6c35ca0e4cca32373
2014-12-11 12:49:29 -08:00
jenkins-bot 5a3c81db4f Merge "Surfaces should have parent document direction" 2014-12-11 19:04:13 +00:00
jenkins-bot eacb364ed1 Merge "Add timing data for the first transaction" 2014-12-11 03:06:14 +00:00
Roan Kattouw 49b26f886e Add timing data for the first transaction
This doesn't quite tell us about the user's first interaction with
VE (if they open a dialog, for instance, it could be minutes before
that results in a transaction), but it's a good start.

Bug: T76524
Change-Id: I6bac987332802d7363ed65a471b2b1ece67086d8
2014-12-11 03:02:11 +00:00
jenkins-bot 1aa30e0864 Merge "Update VE core submodule to master (3feadb2)" 2014-12-11 00:45:48 +00:00
jenkins-bot edf1ed3dbc Merge "Bump command help dialog height again" 2014-12-11 00:45:06 +00:00
Ed Sanders 34a82928c1 Update VE core submodule to master (3feadb2)
New changes:
fc4af20 Fix filibuster expansion bug
3feadb2 [BREAKING CHANGE] Refactor for multiple surfaces

Local changes:
* Use target.getSurface now that targets can have multiple surfaces
* Remove debug bar code now surfaces manage their own
* Remove import rules code now implemented in base target

Change-Id: I18d6f9f2f36431959d31347b4c1952a1aca1350e
2014-12-10 16:39:10 -08:00
Roan Kattouw e68dd9c7c1 Bump command help dialog height again
Change-Id: I348ce317b46f040bc8a2d70e4392ce0dfe24611c
2014-12-10 16:24:14 -08:00
Cmcmahon 122099fda8 [BrowserTest] issues with Chrome at SauceLabs causes test to fail
This is one of several VE tests that do not work well with older
versions of Chrome

Change-Id: Id7afc51689557d9e86e67a07dc840a8e6ca8303e
2014-12-10 15:00:05 -07:00
Moriel Schottlender e0894b807f Surfaces should have parent document direction
Make sure all surface widgets have documents that are initialized
with the direction of the parent document, so the alignment is set up
correctly.

Bug: T71969
Change-Id: I6e5f003e18a9c5808d9a4b148eddf0d0f7e29e67
2014-12-10 16:46:16 -05:00
Translation updater bot 70e8633c05 Localisation updates from https://translatewiki.net.
Change-Id: I3c4f3b3115aa8daa8b7fb3c4c800b4907e6fd564
2014-12-10 22:11:36 +01:00
jenkins-bot f51cc6f2ea Merge "ve.ui.MWParameter*: Use the destructive flag for all four remove buttons" 2014-12-10 02:04:33 +00:00
Roan Kattouw a032ea039e Move from legacy TimingData schema to new statsd API
This API doesn't have the ability to track any other data
in addition to a name and a duration in milliseconds, so
we add the target name ('mwTarget' or 'mobile') to the
event name and discard all other data.

Change-Id: I25ae0243f8983142d7755b65b05c18d5df36a253
2014-12-10 00:25:42 +00:00
jenkins-bot ed22cbffea Merge "Prefer localStorage to store ve-beta-welcome-dialog" 2014-12-09 22:39:09 +00:00
James D. Forrester eac5aabeb3 ve.ui.MWParameter*: Use the destructive flag for all four remove buttons
Previously we were only doing it for one of the four.

Bug: T78033
Change-Id: Ib0091052a5c858dfd37b8755b6e3b84406b7c745
2014-12-09 14:28:40 -08:00
Alex Monk 51b091b9cd Prefer localStorage to store ve-beta-welcome-dialog
Bug: 62884
Change-Id: I3fe45e890c29aaa8d28edfb6986dc8c7541861c7
2014-12-09 21:04:13 +00:00
Translation updater bot 2edf5a7104 Localisation updates from https://translatewiki.net.
Change-Id: Ifc36f5299dfc91692e2357cb4ba2c2909477e658
2014-12-09 21:59:30 +01:00
Roan Kattouw 29995d806b Remove IEHacks.css in favor of .ve-init-target-ie class
Move reference style hack to MWReferenceNode.css, and move
heading style hack to ve.init.mw.Target.css

Change-Id: Icbd53f8df998c9f7bcc701b7c29dc226dfc5c05f
2014-12-08 15:45:23 -08:00
Roan Kattouw 3321261e98 Split up ve.init.mw.ViewPageTarget.css
* Move styles that apply to all targets to ve.init.mw.Target.css
* Move styles for MWPopupTool subclasses to ve.ui.MWPopupTool.css

Change-Id: I34c8a6200ee337debf00c4e432948f1b86f1b60a
2014-12-08 15:42:19 -08:00
jenkins-bot 09bfc0cb9c Merge "Followup 1c04d32d: release saveDialog reference even if closed" 2014-12-08 23:06:37 +00:00
Roan Kattouw dad06ef495 Followup 1c04d32d: release saveDialog reference even if closed
It's good that we're not trying to close the save dialog
if it's not open, but we still need to release our reference
to it in that case, otherwise trying to open the save dialog
in a new incarnation of the editor will fail.

If you opened VE, opened the save dialog, closed it,
went back to read mode, opened VE again, and tried to open the
save dialog again, it would fail because it tried to open
the cached reference to the previous editor's save dialog.

Bonus: prevent JS errors in this case by only attaching an
onClose handler if the dialog actually opened successfully.
If opening the dialog failed, the callback parameter isn't
a promise but an OO.ui.Error, and calling .always() causes
a JS error.

Change-Id: I62d6d3e7cd3df2c29a0c99e2e23bf1aac5187a12
2014-12-08 14:49:39 -08:00
Translation updater bot 4c3a6e55ee Localisation updates from https://translatewiki.net.
Change-Id: I771f43da908ad0d352ff74c622dea4cbcbd2bb42
2014-12-08 23:24:37 +01:00
Cmcmahon 978308ee1f [BrowserTest] update Cite tests
Seems that a set of invisible textareas have appeared

Change-Id: I2ee81c782220c632393d2bbdc66ca66a5c8bf667
2014-12-08 10:43:35 -07:00
Translation updater bot 381c0bd5a0 Localisation updates from https://translatewiki.net.
Change-Id: I1ba254f3d7e22a6264703f65f7fa0f78b0a22ef9
2014-12-07 21:57:36 +01:00
jenkins-bot 9d1b8fdded Merge "Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths" 2014-12-06 21:41:13 +00:00
Timo Tijhof ee954cbdd5 Use String#slice instead of discouraged String#substr
Aside from the confusion and differences between substr() and
substring() and IE8 bugs with substr(), substr() was removed from
the spec as of ECMAScript 5. It's been standardised in the
optional Annex B section of ES5.

Change-Id: I221ef6ae6956ce20dd9bb74510500f747d04c3b1
2014-12-06 21:26:20 +00:00
James D. Forrester baffe9d7e1 Update VE core submodule to master (32397d8)
New changes:
5e60f12 Ensure clipboard key is removed from paste target
32397d8 Update OOjs UI to v0.4.0

Local changes to compensate for new OOUI version, and updated wfUseMW call.

Change-Id: I005f7b23a36e04f1305d4aa037c19a5c7db9a699
2014-12-06 12:28:07 -08:00
Alex Monk fc6eaf6825 Don't re-enable apply changes in reference dialog if the changes have been undone
Per Roan on Ib5229bdc

Bug: T57976
Change-Id: I0450ab59ea8aa2e3130eb9124de74e67ffc0497f
2014-12-05 23:50:57 +00:00
jenkins-bot 7a0e11ed0c Merge "Disable Apply Changes in reference dialog until changes have been made" 2014-12-05 22:46:26 +00:00
Alex Monk a7b9b89479 Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths
Use model HTMLDocument when parsing transclusion nodes and their link hrefs

As well as mobile, this also covers the issue I found in /w/index.php?veaction=edit

See also T76374

Bug: T76379
Change-Id: I07c9ba0adbcee32f7eb2ca280d3a1d46e963d28f
2014-12-05 22:23:09 +00:00
Translation updater bot a9e939649e Localisation updates from https://translatewiki.net.
Change-Id: I7dc624ec5d93b6ee5be968cd5d744e81f2e0dab9
2014-12-05 23:16:32 +01:00
Bartosz Dziewoński d39dfaa837 MWCategoryInputWidget: Don't explode on invalid titles
canonicalQueryValue can be null at this point, so let's not insert it
into an array that contains strings.

Bug: T76868
Change-Id: I8096a9c1017e883d28124bf807d2d375ae98452a
2014-12-05 21:07:57 +01:00
Alex Monk b0b53befdc Fix call to mw.log.warning
Should be mw.log.warn

Added by I111176b8

Change-Id: I58b78e89a7f5a21fe050e2a90bf856c388f7213d
2014-12-03 23:35:51 +00:00
Translation updater bot fd8f9463aa Localisation updates from https://translatewiki.net.
Change-Id: I9bcf93cd047e84c80a50d0ef34b7474bcdb6486f
2014-12-03 22:30:16 +01:00
James D. Forrester e722c1726f Update VE core submodule to master (0229301)
New changes:
5eb7294 Find and replace
123a6ad Find and replace tool
557f70f Go backwards through find and replace results on shift enter
4a4ed81 Allow language widget to filter on available languages

Local changes to adjust.

Change-Id: I15e14d6d3c7ee60e465baf3a4df7572851cbca3e
2014-12-03 10:36:39 -08:00
Roan Kattouw dbf232a7dc Clean up deactivate mess
Both onDocumentKeyDown and onViewTabClick would check
this.activating and invoke deactivate() differently depending
on its value. That's ugly, so incorporate the "don't show a dialog
if deactivating during activation" logic into deactivate() itself.

Rename the override parameter to noDialog, and fix the broken
logic around it (it overrode too much).

Also move setting this.activating = false; out of these event
handlers into cancel(), where it clearly belongs because
activatingDeferred is being rejected there.

Change-Id: I6c040c74d36f829128a175f00d4e712dd19d31a7
2014-12-02 16:50:36 -08:00
jenkins-bot 45e98c7699 Merge "Cancel VE when escape key pressed" 2014-12-03 00:33:19 +00:00
Alex Monk c0fd5e616d Cancel VE when escape key pressed
Or at least open the confirmation dialog about it.

Relies on I0047bd9d to not break stuff on the second try.

Bug: T52868
Change-Id: Id178a2a0aad2f4bf5f589d66efde61aaa6fae498
2014-12-02 16:29:15 -08:00
jenkins-bot 77b507dfc7 Merge "[Browsertest]Tests for options under Advanced Settings panel" 2014-12-02 23:03:37 +00:00
ryasmeen@wikimedia.org 416d62df4f [Browsertest]Tests for options under Advanced Settings panel
Change-Id: I21765e9e3d7a004d24dd620dd0da35978632d02a
2014-12-02 15:00:33 -08:00
jenkins-bot d7f954b1b5 Merge "Make LinkCache fail more gracefully when given undefined" 2014-12-02 22:45:08 +00:00
jenkins-bot 63e09d4659 Merge "Handle encoding of links in transclusion nodes properly when determining existence" 2014-12-02 22:22:15 +00:00
Roan Kattouw 2ed648c4db Make LinkCache fail more gracefully when given undefined
If you tried to do styleElement( undefined, $element ), you'd
get an exception in the mw.Title constructor from a setTimeout.
That's not very nice, and there's no point sending non-strings
through the queue and other data structures in LinkCache, so
instead just make get() return a rejected promise when given
non-string values.

Change-Id: Iab06929d7e232a8ecd8eb1eff9d1190c303421c1
2014-12-02 14:02:45 -08:00
jenkins-bot d71279cdfe Merge "ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve" 2014-12-02 21:50:12 +00:00
jenkins-bot 6c4c3408b8 Merge "Track new pagedeleted save error in TargetEvents" 2014-12-02 02:04:11 +00:00
Roan Kattouw 915278dfea Track new pagedeleted save error in TargetEvents
Change to Schema:Edit takes it to revision 10676603.

Change-Id: I87a3812585ac0dd22a66ceffdf320ad8bc326155
2014-12-01 17:58:31 -08:00
Alex Monk db4d034fd7 Disable Apply Changes in reference dialog until changes have been made
Bug: T57976
Change-Id: Ib5229bdc480ec437436c5d8d351b06417d4ffd9b
2014-12-02 01:34:44 +00:00
Alex Monk c2ed5201e5 Handle encoding of links in transclusion nodes properly when determining existence
Bug: T75823
Change-Id: I9398e4e1657b218043658d83b13c3dc78ffa8ff1
2014-12-02 01:09:12 +00:00
Translation updater bot 5613f53a96 Localisation updates from https://translatewiki.net.
Change-Id: I5c54331b5438652841ad92ed8a90a45623263563
2014-12-01 22:23:50 +01:00
Bartosz Dziewoński e6ea9db351 ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve
Change-Id: I265aba968d861020852ada5034e166189efd3218
2014-12-01 20:59:53 +01:00
jenkins-bot 7734e0083a Merge "i18n: Pass value to <visualeditor-dialog-meta-settings-newsectioneditlink-help>" 2014-12-01 19:35:34 +00:00
jenkins-bot 0445ee640d Merge "Remove duplicate startSanityCheck from ViewPageTarget" 2014-12-01 19:22:56 +00:00
James D. Forrester 7ab402eeb5 i18n: Pass value to <visualeditor-dialog-meta-settings-newsectioneditlink-help>
Bug: T75969
Change-Id: I6bbe2dbec74edae9fb1b09e03f3102b7a2d0be97
2014-12-01 11:22:34 -08:00
Ed Sanders 7dc4dd66a0 Remove duplicate startSanityCheck from ViewPageTarget
Method was moved to parent, but not deleted from child. Also move
sanityCheckPromise to parent where it is used.

Change-Id: Ie2b00330d796cd089fd4bc84d9332c316500633f
2014-12-01 19:19:51 +00:00
jenkins-bot 55eba4c1cc Merge "Change event listener for caption surface in media dialog" 2014-12-01 19:05:09 +00:00
jenkins-bot 0cfaf9f95b Merge "Set panels after everything is initialized in media dialog" 2014-12-01 18:48:24 +00:00
Translation updater bot 64604a475d Localisation updates from https://translatewiki.net.
Change-Id: I6aa9f444c3e6090edcf851a51e094f0fac042b4b
2014-11-30 22:16:32 +01:00
Translation updater bot 59bccb0bd5 Localisation updates from https://translatewiki.net.
Change-Id: I87dde90d5069228d31da11c7dae3583fa8988320
2014-11-29 12:59:08 +01:00
Amir E. Aharoni 9dad03819e Mention the "Continue" label as a parameter in visualeditor-recreate
Bug: T75971
Change-Id: Id075233da4e8a2978b07b5f2735ac6620ff5330d
2014-11-27 22:33:35 +02:00
Željko Filipin 15ed437331 [BrowserTest] Fixed a couple of page elements
Change-Id: Ia4652896243705651c86ff5f83dbd03029757705
Paired-With: Amir Aharoni
Bug: T76133
2014-11-27 11:39:02 +01:00
jenkins-bot a2d7d64fcf Merge "Followup 6d21d83: unbreak switching to edit source" 2014-11-27 00:27:39 +00:00
Moriel Schottlender 78b86cd72d Set panels after everything is initialized in media dialog
Only change the panels (and focus the caption surface) after the
surface is actually appended and initialized.

Bug: T76074
Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
2014-11-26 19:26:44 -05:00
Roan Kattouw 616a9cd1bf Followup 6d21d83: unbreak switching to edit source
Forgot to pass the wikitext parameter through, oops :(

Bug: T76114
Change-Id: Ic852e4b10c17b2417f582f35fabb87823e0202e3
2014-11-26 16:24:50 -08:00