wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Followup 1c04d32d: release saveDialog reference even if closed"

Browse source
This commit is contained in:
jenkins-bot 2014-12-08 23:06:37 +00:00 committed by Gerrit Code Review
parent 4c3a6e55ee dad06ef495
commit 09bfc0cb9c
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
View file

@ -1019,9 +1019,11 @@ ve.init.mw.ViewPageTarget.prototype.tearDownSurface = function () {
this.surface.mwTocWidget.teardown();
}
if ( this.saveDialog && this.saveDialog.isOpened() ) {
// If the save dialog is still open (from saving) close it
promises.push( this.saveDialog.close() );
if ( this.saveDialog ) {
if ( this.saveDialog.isOpened() ) {
// If the save dialog is still open (from saving) close it
promises.push( this.saveDialog.close() );
}
// Release the reference
this.saveDialog = null;
}
@ -1173,7 +1175,7 @@ ve.init.mw.ViewPageTarget.prototype.showSaveDialog = function () {
{ dir: this.surface.getModel().getDocument().getLang() }
)
// Call onSaveDialogClose() when the save dialog starts closing
.always( function ( opened ) {
.done( function ( opened ) {
opened.always( target.onSaveDialogClose.bind( target ) );
} );
}.bind( this ) );