wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-26 19:56:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

MWCategoryInputWidget: Don't explode on invalid titles

Browse source 
canonicalQueryValue can be null at this point, so let's not insert it
into an array that contains strings.

Bug: T76868
Change-Id: I8096a9c1017e883d28124bf807d2d375ae98452a
This commit is contained in:
Bartosz Dziewoński 2014-12-05 21:07:57 +01:00
parent b0b53befdc
commit d39dfaa837
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js
View file

@ -112,9 +112,10 @@ ve.ui.MWCategoryInputWidget.prototype.getLookupMenuItemsFromData = function ( da
prefixedCanonicalQueryValue = prefixedCanonicalQueryValue && prefixedCanonicalQueryValue.getPrefixedText();
// Invalid titles end up with canonicalQueryValue being null.
if ( canonicalQueryValue ) {
canonicalQueryValue = canonicalQueryValue.getMainText();
} // Invalid titles just end up with canonicalQueryValue being null.
}
$.each( data, function ( index, suggestedCategory ) {
var suggestedCategoryTitle = mw.Title.newFromText(
@ -151,7 +152,7 @@ ve.ui.MWCategoryInputWidget.prototype.getLookupMenuItemsFromData = function ( da
} );
// New category
if ( !exactMatch ) {
if ( !exactMatch && canonicalQueryValue ) {
newCategoryItems.push( canonicalQueryValue );
linkCacheUpdate[prefixedCanonicalQueryValue] = { missing: true };
}