mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-25 06:46:26 +00:00
dbf232a7dc
Both onDocumentKeyDown and onViewTabClick would check this.activating and invoke deactivate() differently depending on its value. That's ugly, so incorporate the "don't show a dialog if deactivating during activation" logic into deactivate() itself. Rename the override parameter to noDialog, and fix the broken logic around it (it overrode too much). Also move setting this.activating = false; out of these event handlers into cancel(), where it clearly belongs because activatingDeferred is being rejected there. Change-Id: I6c040c74d36f829128a175f00d4e712dd19d31a7 |
||
---|---|---|
.. | ||
ve-mw | ||
ve-wmf/i18n |