Commit graph

4829 commits

Author SHA1 Message Date
Alex Monk 4210c4bee0 Use veaction=edit in URL instead of action=edit when we're using multiple tabs
TODO: What about prefer-wt users switching from WTE?

Bug: T131064
Change-Id: I9aa701cbda3964decb8b1ee853c0a281567a0ccb
2016-03-30 02:54:01 +01:00
jenkins-bot 4dadaa677c Merge "MWWikitextStringTransferHandler: Add test for autoGenerated=true" 2016-03-29 22:01:39 +00:00
jenkins-bot f5f97adbe4 Merge "MWWikitextStringTransferHandler: Factor out body tag from response" 2016-03-29 21:42:09 +00:00
jenkins-bot b44cee5557 Merge "MWWikitextStringTransferHandler: Remove data-parsoid from tests" 2016-03-29 21:39:07 +00:00
Translation updater bot f753a46fa1 Localisation updates from https://translatewiki.net.
Change-Id: I840ba9e9d5c3eaed4837cabbd5fbf35c1079150e
2016-03-29 22:40:33 +02:00
Ed Sanders 18df6c3d47 MWWikitextStringTransferHandler: Add test for autoGenerated=true
Bug: T131153
Change-Id: I4922abe7978e1f04eb2276214c761622b44149c7
2016-03-29 19:57:45 +00:00
Ed Sanders b51b512555 MWWikitextStringTransferHandler: Factor out body tag from response
Change-Id: Ic694d1099538d2c60900d490667f2175f7f3afb3
2016-03-29 19:57:36 +00:00
Ed Sanders 818931dd9e MWWikitextStringTransferHandler: Remove data-parsoid from tests
It is ignored by VE, and isn't present in restbase responses.

Change-Id: Iaa2a6a66ba76ca0d63b4d6791ab8589191bce0f2
2016-03-29 19:57:26 +00:00
jenkins-bot 0242dedff9 Merge "Filter out auto-generated reference lists" 2016-03-29 19:37:35 +00:00
jenkins-bot 18533b47fa Merge "Toolbar: Add tooltips to structure and insert groups" 2016-03-29 17:15:51 +00:00
jenkins-bot 29af9b54b6 Merge "MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more" 2016-03-29 16:52:31 +00:00
jenkins-bot 190c64ed69 Merge "Select tool when it's been closed by education tool popup button" 2016-03-29 16:42:38 +00:00
jenkins-bot b9643881d9 Merge "Remove icon properties from windows" 2016-03-29 16:37:22 +00:00
Alex Monk 0760cd6974 Select tool when it's been closed by education tool popup button
Bug: T117273
Change-Id: I54b704b6663f7d862557e6524713259dee8765cc
2016-03-29 15:54:22 +01:00
Ed Sanders 9a347220bc Target loading: Only parse oldid if it is non-null
This un-breaks MobileFrontend.

Change-Id: Ib1bce6b80abb004ff4ca26920759ef98f3cd1143
2016-03-29 12:57:00 +01:00
Ed Sanders c516d897d2 Remove icon properties from windows
Windows stopped supporting icons a while ago.

Change-Id: I8a63152282a5968dcd17675330e31bd1ebe4b68b
2016-03-29 12:33:42 +01:00
Ed Sanders 1d8d1c2a64 Toolbar: Add tooltips to structure and insert groups
Bug: T131133
Change-Id: I927bf6f0d1de74b4ac8d16c3b5ce27720db322d4
2016-03-29 12:08:22 +01:00
Translation updater bot d4d1f10b95 Localisation updates from https://translatewiki.net.
Change-Id: Ifdc4b011bcb895ae3fa39a1fbe31b1640d1e56e4
2016-03-28 22:46:52 +02:00
James D. Forrester a6477fb960 MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more
Change-Id: Ib2f63d1626d8286c7dfd74227d09046a7d2af509
2016-03-28 19:53:08 +00:00
jenkins-bot ff61173f90 Merge "MWLinkAnnotationInspector: select entire link when switching tabs" 2016-03-28 19:22:35 +00:00
Ed Sanders 681250dd5e Filter out auto-generated reference lists
Bug: T101553
Bug: T127664
Change-Id: Idc8c6f30ccdd5eaf76a3f7c1b923d8656ca36413
Depends-On: I24250845e97acb4b7de9c495cb46dbd28fc8817e
2016-03-28 17:23:42 +00:00
David Lynch d33f5969ad MWLinkAnnotationInspector: select entire link when switching tabs
Bug: T129650
Change-Id: I4ca445f2c43438c36ece23245660b63f2a48b722
2016-03-28 11:38:45 -05:00
James D. Forrester 0a23ec716d i18n: Drop another two references to the wikitext editor
Change-Id: I89b727e880f40d6e82fb584beb4647aed6134e90
2016-03-28 08:47:20 -07:00
Translation updater bot f239e17a1e Localisation updates from https://translatewiki.net.
Change-Id: Ie585e9b5dd0251d35e90646f0ff79cc76cf66da8
2016-03-27 21:25:48 +02:00
Thalia 003e02efaa MWAceEditorWidget: Update maxRows and minRows if minRows is changed
This was being done correctly in initialize, but not in setMinRows.

Bug: T131009
Change-Id: I57c771720c59ca1d75f0b9bc14e7c834237019d5
2016-03-27 17:42:11 +00:00
jenkins-bot ff65a71773 Merge "Template Dialog: pushPending while the dialog is closing" 2016-03-26 03:13:42 +00:00
jenkins-bot 068bafd9df Merge "ArticleTarget: Don't assume an explicit oldid is old; check against current" 2016-03-26 00:49:58 +00:00
Alex Monk 680e464e94 ArticleTarget: Don't assume an explicit oldid is old; check against current
Bug: T130810
Change-Id: I3d5b748da37a0a059f282f97dd0d68d1846e2553
2016-03-25 17:37:02 -07:00
jenkins-bot 35ea4b3e4e Merge "Don't strip namespace from text that we replace firstHeading with" 2016-03-25 22:43:41 +00:00
Alex Monk b1aebf0b48 Don't strip namespace from text that we replace firstHeading with
wgTitle is basically just $title->getText()
wgPageName is $title->getPrefixedDBkey()

So we need to take wgPageName and run getPrefixedText (difference is underscores
get replaced by spaces)

Change-Id: Ib99f0d20f1ba99338f80bbbf39cffd544887c3fa
2016-03-25 04:45:09 +00:00
Translation updater bot 8bf7d4ba07 Localisation updates from https://translatewiki.net.
Change-Id: Ief4cec942df98bef1b43038fa14e0cb6403ea454
2016-03-24 22:40:13 +01:00
David Lynch 0268e74a7f Template Dialog: pushPending while the dialog is closing
Double-clicking the "insert" button would double-insert the template. Counting
the close as a pending action avoids that.

Bug: T129725
Change-Id: I41af7c051fd54004cecd563d7a6cf8fdb452840f
2016-03-24 11:33:00 -05:00
Translation updater bot 3028f4f2d6 Localisation updates from https://translatewiki.net.
Change-Id: I7715d2d33b21e1a9d142a2be00a032fe83de4f75
2016-03-23 22:25:43 +01:00
jenkins-bot 9b9ace9d03 Merge "Rename startSave -> onSaveDialogSave" 2016-03-23 19:48:06 +00:00
jenkins-bot 52c862b5af Merge "Make data-mw/body.html attribute comparable" 2016-03-23 19:20:40 +00:00
Ed Sanders 5e4ad90845 Rename startSave -> onSaveDialogSave
Factor out actual startSave into new startSave method.

Change-Id: I73edb5021903f04aa197ace2a2afa3aa3a5ddac6
2016-03-23 11:14:06 +00:00
Ed Sanders 6a159001ab Make data-mw/body.html attribute comparable
Change-Id: Ie23c5816a18f4da84c3d40c13a8c048710389f4b
2016-03-23 11:03:53 +00:00
Alex Monk 2063025237 Don't change focus to VE surface if we're opening the SET dialog
Bug: T130552
Change-Id: Idc4639bb3f51690a827bdbdb0419e9303dd39a1b
2016-03-23 01:08:32 +00:00
Translation updater bot 0f6bdb9071 Localisation updates from https://translatewiki.net.
Change-Id: I994551c7973f274b4791d23c89fd808038df14da
2016-03-22 22:34:47 +01:00
Ed Sanders fd3683e414 Update VE core submodule to master (d1ce123)
New changes:
6cf8864 Follow-up eb97c1f: Fix build for added language 'inh'
d1ce123 SpecialCharacterDialog: Use getReadyProcess promise to wait for char list

Local changes:
* SpecialCharacterDialog: Defer loading of character list.
  Saves ~40k for most users who never use it.

Change-Id: I74b30fee96e1ae4463ed28c19bef4b515330220e
Depends-On: I45dc9f788aa5bd702b91ffd9f63b05b1f4760691
2016-03-22 09:15:23 -07:00
James D. Forrester 7df0e7589e Update VE core submodule to master (eb97c1f)
New changes:
e661245 Localisation updates from https://translatewiki.net.
d0bac53 ElementLinearData: Add test for sanitize conversions
53988e4 ElementLinearData: Test blacklist unwrapping
8593098 ve.dm.Model: Remove unused, untested method 'hasAttributes'
6247dd2 ce.Surface: Add tests for table strip delete
bee1851 ce.Surface: Add larger table strip-delete test
42d39e7 ce.Surface: Test table navigation with enter/escape/tab/shift-tab
5d248f9 Remove TableCaptionCommand
a86ad04 PreviewElement: Check node is a GCN, and always return a boolean
b518839 Localisation updates from https://translatewiki.net.
8834e9c ce.Surface: Allow any key code in the key handler tests
6b3ea6a ce.Surface: Linear arrow tests for block node
026999d Localisation updates from https://translatewiki.net.
eb97c1f Localisation updates from https://translatewiki.net.

Change-Id: Ic5853116d97623316d9a6bbacda2ecab9e4b49d5
2016-03-22 15:12:36 +00:00
Translation updater bot b6662a697d Localisation updates from https://translatewiki.net.
Change-Id: I111db7bda332fc853e50d2d5cd029389a01676e8
2016-03-21 23:37:06 +01:00
Translation updater bot eed6125ef2 Localisation updates from https://translatewiki.net.
Change-Id: I197104b10bb7aa062030a6cf22975283dbe42d28
2016-03-20 22:43:49 +01:00
Translation updater bot c450fdd332 Localisation updates from https://translatewiki.net.
Change-Id: I2425ab6952f0890671132342acfa0308cf286882
2016-03-19 22:55:27 +01:00
Translation updater bot c37a2d11f7 Localisation updates from https://translatewiki.net.
Change-Id: Ia9b65fcfe6117d2075483bd130900c51b787eddc
2016-03-18 22:45:18 +01:00
jenkins-bot 4e4684e7d0 Merge "Show redirect target inside target" 2016-03-17 22:54:39 +00:00
Translation updater bot d036f04573 Localisation updates from https://translatewiki.net.
Change-Id: I30e95352b17b75c8eb8dba54a4007238c28b1c63
2016-03-17 23:23:48 +01:00
Ed Sanders b7d25d92bc Detect the type of plain pasted links
Using the same logic we used for converting pasted URLs, detect
internal links by matching their base.

Currently link pasting is still disabled in the VE target, but
has been enabled elsewhere (Flow).

Change-Id: Iebd61abbe1fe82fd18d129e1dbc815ca75f44e87
2016-03-17 19:30:13 +00:00
jenkins-bot d5ef085b3e Merge "Link pasting: Match RDFa-less links as external" 2016-03-17 17:45:52 +00:00
Ed Sanders 5e6cbc187c Link pasting: Match RDFa-less links as external
Now that some targets support link pasting (Flow) we need to
make sure that pasted links match to an allowed type ('link/mwExternal')
instead of plain 'link' annotations which should never exist
in an MW document.

In a later commit we should auto-detect internal links.

Change-Id: I7faae834aa6e730c3cf93a691331a05fd0fe3d5c
2016-03-17 17:18:41 +00:00
jenkins-bot 1c27e5d51a Merge "In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId" 2016-03-17 15:39:12 +00:00
jenkins-bot 33c9055fdc Merge "Reload page after user selects multi-tab option of SET dialog" 2016-03-17 15:39:09 +00:00
Alex Monk 3288d4e3f9 Show redirect target inside target
Bug: T63861
Depends-On: I71d3d415fe918e8b0a090860cad9271092b1bd7e
Change-Id: I5a138b95e04773885ca9ee548026729805eb11f0
2016-03-17 15:21:06 +00:00
Translation updater bot 445a830d52 Localisation updates from https://translatewiki.net.
Change-Id: I2764438c78e674d492157f55fb15ae82ed114b36
2016-03-15 23:06:07 +01:00
Ed Sanders dec9aa09e4 Use keyboard icon for keyboard help tool
Change-Id: Id5e5097dfcdb5e3be2b21c89886857cb379997e6
2016-03-15 17:28:48 +00:00
Alex Monk 02953f5d64 Suppress meta dialog on refresh pages if we want to show SET dialog
Bug: T129819
Change-Id: I1176d06e5a5f56f01528acd7d099c8be9d317e51
2016-03-15 08:10:46 +00:00
Translation updater bot af64cf7b12 Localisation updates from https://translatewiki.net.
Change-Id: I85827c3e9262adf7bb6191ff68de688f744b613a
2016-03-14 22:55:30 +01:00
jenkins-bot 53d3c62d46 Merge "CommandHelpDialog: Inherit non-corruptively" 2016-03-14 20:28:56 +00:00
Ed Sanders f5873ac1db CommandHelpDialog: Inherit non-corruptively
Change-Id: Ieb497eebe930e58a02552eb9d4305280c91c92c2
2016-03-14 20:03:52 +00:00
Ed Sanders 5d5d5419c6 AceEditorWidget: Use namespaced 'require'
The un-namespaced version will soon be removed to fix RL issues.

Bug: T127643
Change-Id: Iaf4ed23d88cb955b8f8f61725f9effa6180de5bf
2016-03-14 16:56:16 +00:00
Željko Filipin 63eb2a2f46 [BrowserTest] Increase the time Selenium waits for VisualEditor to load
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.

Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
2016-03-14 13:00:17 +01:00
jenkins-bot 110c6eb057 Merge "[BrowserTest] Disable failing language screenshot scenario" 2016-03-14 11:33:53 +00:00
jenkins-bot 0cdf4393ed Merge "Prefer error *code* when logging unknown errors" 2016-03-14 01:01:48 +00:00
jenkins-bot 3a1f6a34c8 Merge "Log readonly code for readonly errors" 2016-03-14 01:00:47 +00:00
Alex Monk 612e43dc08 Prefer error *code* when logging unknown errors
See also I4a5bac24

Change-Id: I62fda9dadd24704f5930b30a2f8ad4d4a9e729cb
2016-03-14 00:27:42 +00:00
Translation updater bot 004247822d Localisation updates from https://translatewiki.net.
Change-Id: I18e35f520e9b8dde3c96e6b2c3b740d1fb48c294
2016-03-13 22:57:53 +01:00
jenkins-bot 1a0733c4f2 Merge "MWSaveDialog: Fix vertical alignment" 2016-03-13 11:43:17 +00:00
Translation updater bot 368953b808 Localisation updates from https://translatewiki.net.
Change-Id: I1c34348e0ce6227d6a3e84a969271563b0e8a6d5
2016-03-12 21:14:25 +01:00
Alex Monk 22bf016a84 In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId
There's probably more to this bug but I think we should still correct this

Bug: T125437
Change-Id: Ib32d1e69b2500578b5dc160c0c2d7481f5577ebb
2016-03-12 04:46:54 +00:00
Translation updater bot 7c8a2207d3 Localisation updates from https://translatewiki.net.
Change-Id: Ifefb57f56a762c7fcb5cab0258d018be0e7c10eb
2016-03-11 22:18:35 +01:00
Ed Sanders da9aff2421 MWSaveDialog: Fix vertical alignment
Change-Id: Ifb62375da6c872a3a4ef783e479a5476ca318b32
2016-03-11 17:37:01 +00:00
Alex Monk d1d4839f8f Log readonly code for readonly errors
I thought I did this yesterday

Change-Id: Icd2cf8fdf4263cab335a2ddfa53ab0585153dfb4
2016-03-11 17:33:57 +00:00
Alex Monk 3807a918f9 Reload page after user selects multi-tab option of SET dialog
Bug: T129510
Change-Id: I3fcac175f18d8159e6a5c4084668264d4705970c
2016-03-11 05:39:29 +00:00
Translation updater bot 55a6cd08b2 Merge "Localisation updates from https://translatewiki.net." 2016-03-10 21:33:52 +00:00
Translation updater bot 3aac2043a4 Localisation updates from https://translatewiki.net.
Change-Id: Ia3db1d0b33d4bdbde66452bcf33a7b0b0e4da5bb
2016-03-10 22:31:26 +01:00
jenkins-bot d6ec1ed86f Merge "Fix logging of event_action.saveFailure.message for responseUnknown" 2016-03-10 21:22:37 +00:00
jenkins-bot ad7c364725 Merge "Better handling of read-only mode" 2016-03-10 21:22:34 +00:00
Alex Monk 0a6f6e1bbd Fix logging of event_action.saveFailure.message for responseUnknown
Change-Id: Ic8d3066d8f6ccf8bc4a1001fd4d406b313915e82
2016-03-10 21:03:25 +00:00
Alex Monk d2a9aefba7 Better handling of read-only mode
* Don't just fail to load, action=visualeditor itself should not write to the DB
  (we have action=visualeditoredit for that)
* Send notice to the client in the usual way
* Handle read only errors on save, log as unknown

This won't let you review changes because that uses visualeditoredit

Bug: T129501
Change-Id: Id78c06b031423e47a7ddf94ec615b6d6975309d3
2016-03-10 21:02:52 +00:00
jenkins-bot 3eaaf57847 Merge "Suppress welcome dialog this time if we're showing the SET pref dialog" 2016-03-10 20:38:39 +00:00
Alex Monk 4462f2539a Suppress welcome dialog this time if we're showing the SET pref dialog
Bug: T129200
Change-Id: Iaa6d80df930cfcbd243efd31437cb8707da35c06
2016-03-10 17:54:15 +00:00
Željko Filipin 43e9c8714f [BrowserTest] Disable failing language screenshot scenario
VisualEditor_Insert_Menu scenario fails with `Original image height is
too small! (ChunkyPNG::OutOfBounds)`.

Bug: T119482
Change-Id: I30c3a9757c5754a40921fce5225b73897eed865b
2016-03-10 15:06:56 +01:00
Translation updater bot d36a099939 Localisation updates from https://translatewiki.net.
Change-Id: I32293b4f2532d15e65b71f09e53ac9c2e8817356
2016-03-09 22:48:24 +01:00
jenkins-bot 2e89f4f658 Merge "[BrowserTest] Disable failing language screenshots" 2016-03-09 17:32:57 +00:00
jenkins-bot 67fb8dd07f Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError" 2016-03-09 17:31:27 +00:00
Timo Tijhof cf1d7c0dab mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined"
Regression from 863a2c2974.

Sometimes when clicking "Switch to source mode" in the toolbar this
error is thrown and the interface freezes because setEditorPreference()
only returns a promise if the value is different.

> Uncaught TypeError: Cannot read property 'done' of undefined
> - ve.init.mw.DesktopArticleTarget.switchToWikitextEditor

Change-Id: Ie59f06a8ed9af9c4fb8199b013c06992d0c4f700
2016-03-08 23:13:11 +00:00
Translation updater bot d8a9a11ca7 Localisation updates from https://translatewiki.net.
Change-Id: Ia668efdeff27d984848c2bca823bf41d370706f9
2016-03-08 22:46:51 +01:00
Ed Sanders d5e594b9f6 Link inspector: Remove premature call to onLinkTypeIndexSet
This causes the inspector to take focus early (line 291) on
first load, and is not necessary as this method fires when
needed anyway.

Bug: T129228
Change-Id: Ia69f76b68e89daf5cb01449c40e71de4ec32d400
2016-03-08 16:54:09 +00:00
jenkins-bot 7261cf5364 Merge "Link inspector: make height consistent" 2016-03-08 16:50:02 +00:00
Ed Sanders 7f31507e12 Link inspector: make height consistent
Make the DOM order sensible so we don't have to
use SearchWidget's position:absolute hacks.

Bug: T129173
Change-Id: I3517e0e0cfe2ab0eee4bed7390e41710d3140eb0
2016-03-08 10:26:31 +00:00
James D. Forrester 80139533ab i18n: Don't refer to the name of the tab in the beta notice given it changes
Change-Id: I9beb322aeabece0df483271b33dbaa41f5da732a
2016-03-07 16:58:32 -08:00
James D. Forrester b247ffd7bd i18n: Explain to returning users that their preferences are mutable
Change-Id: I8a47725d7271af54b30f2130e97b08edec0f0b59
2016-03-07 16:56:13 -08:00
James D. Forrester 9a6650ae1f i18n: Relabel the SET preference and dialog to 'mode'
Change-Id: Id876f4ba102800237cbc4a671d4db9a26f7f116d
2016-03-07 15:51:19 -08:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
jenkins-bot 7a5f34fac3 Merge "Education popup: Also handle clicks on dots" 2016-03-07 23:28:55 +00:00
jenkins-bot 39f3cfa4a7 Merge "Keep summary and checkbox selections when swtiching WTE->VE" 2016-03-07 23:17:08 +00:00
jenkins-bot 075f569e51 Merge "Update ArticleTarget for new API token handling" 2016-03-07 23:14:32 +00:00
jenkins-bot 6ed2d23b13 Merge "Don't give the user the option to discard changes when changing editor" 2016-03-07 23:14:29 +00:00
jenkins-bot 15f8efed70 Merge "DesktopArticleTarget.init#getLastEditor: Check values for validity" 2016-03-07 23:14:26 +00:00
James D. Forrester 79d1f92b42 DesktopArticleTarget: Add Edge and MSIE to whitelist
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
2016-03-07 14:58:10 -08:00
jenkins-bot 4d34f9ad75 Merge "Follow-up I65d96627: Remember the user's preference in WikiEditor too" 2016-03-07 22:31:54 +00:00
James D. Forrester d8eb68d7b6 Don't give the user the option to discard changes when changing editor
Bug: T128585
Change-Id: I02f31e46ae7b2dc7505ed55fc56cd00f538a90e3
2016-03-07 13:39:32 -08:00
Translation updater bot 98052e165d Localisation updates from https://translatewiki.net.
Change-Id: I1e160b1149c6f0a5abb31ad51ba0a099de151a1f
2016-03-07 22:27:34 +01:00
James D. Forrester b0407d840d Follow-up I65d96627: Remember the user's preference in WikiEditor too
Oh dear.

Bug: T129130
Change-Id: I12481ded12f99ab1ba59dbd403c1eed038235fd9
2016-03-07 13:03:35 -08:00
jenkins-bot 789979f223 Merge "Try to fix handling of empty document on WTE->VE switch" 2016-03-07 19:48:22 +00:00
James D. Forrester 302aeefd85 DesktopArticleTarget.init#getLastEditor: Check values for validity
Change-Id: I23e0884a97b3689dd42c3df11a6311cd0601c348
2016-03-07 11:27:23 -08:00
jenkins-bot fe19bfb0af Merge "Use iconWhenInvisible for alien extension nodes" 2016-03-07 18:34:38 +00:00
Ed Sanders bbf86a6768 Use iconWhenInvisible for alien extension nodes
Change-Id: I0bc9bfd040685855402f705f46973e36c42dc0db
2016-03-07 18:15:45 +00:00
jenkins-bot c930ac2779 Merge "Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry" 2016-03-07 16:32:13 +00:00
Translation updater bot 4dd9110c18 Localisation updates from https://translatewiki.net.
Change-Id: I894adeef0ad09824fad0d3fff544ced1f7f3b1ae
2016-03-06 22:18:45 +01:00
Ed Sanders 5cc10a810a Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry
This allows extensions to register their own rules for detecting wikitext,
e.g. matching '<ref>'.

Bonus: Strip the autogenerated <references/> tag which
gets inserted when converting a <ref>.

Bug: T128805
Change-Id: I7a38db45d25e86ff3f3f6199aa04425ec98f7cc4
2016-03-05 22:47:00 +00:00
Translation updater bot bcb8aed482 Localisation updates from https://translatewiki.net.
Change-Id: Icffb9dc8b7f78d2debad38046ba42ea678b969ae
2016-03-05 23:01:12 +01:00
Ricordisamoa 993015e03b Update ArticleTarget for new API token handling
action=query&prop=info was being used because it can be combined
with action=query&meta=userinfo, while action=tokens cannot.

However, since MediaWiki 1.24 the 'intoken' parameter of
action=query&prop=info is deprecated, while the preferred way of
retrieving tokens is action=query&meta=tokens which not only can
be combined with action=query&meta=userinfo but also spares the
need of dealing with page ids.

Change-Id: I5ded3c303ede20514eeb2840715fe240b3b2c7e1
2016-03-05 14:44:07 +01:00
jenkins-bot ea11c33e6d Merge "Handle API errors when refetching the edit token" 2016-03-05 02:16:32 +00:00
Roan Kattouw 6322be2e07 Handle API errors when refetching the edit token
This can happen when the user gets logged out on a private wiki.
We get a badtoken error, so we try to refetch the token, which
itself returns an error. Token refetches didn't have error handling
at all and got the save dialog stuck in the pending state.

We can't offer the user to proceed with a different identity here,
because we encountered an error while trying to figure out what their
current identity is. The best we can do is encourage them to
log back in in a different tab.

Bug: T128934
Change-Id: I17d4452f688ec22631dbd12af223731635004d66
2016-03-04 18:06:33 -08:00
jenkins-bot 074885d7cf Merge "Follow-up 2c24efae: fix typo in event name for unknown save errors" 2016-03-05 02:01:57 +00:00
Roan Kattouw 84d534997e Follow-up 2c24efae: fix typo in event name for unknown save errors
This probably means we stopped logging unknown save errors
back in August.

Change-Id: I4a5bac244a469e73643e8a7d978d9212dd838fb0
2016-03-04 17:31:40 -08:00
Translation updater bot 0d94d8312d Localisation updates from https://translatewiki.net.
Change-Id: I92baebf577ce098877cff730f2ff8de4974f79b2
2016-03-04 22:56:47 +01:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
2016-03-04 15:54:13 +01:00
Alex Monk dde45949a3 Try to fix handling of empty document on WTE->VE switch
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
2016-03-04 02:05:41 +00:00
Ed Sanders 67c207a6f5 Use abstract target widget creation
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
2016-03-03 11:49:44 -08:00
Ed Sanders d64436cc0c Use new surface executeCommand method
Change-Id: I84c718d9da4b7dd0627ba37d9c29c3a25cc5d73e
Depends-On: Id975ea9da43654cd9991a302b49a9fb32782078e
2016-03-03 11:49:44 -08:00
Ed Sanders 62d16e5a8a Update VE core submodule to master (ac24b50)
New changes:
0b7e689 FindAndReplaceDialog: don't use tabindex
17b10a5 Localisation updates from https://translatewiki.net.
a4133e4 [BREAKING CHANGE] Make whitespaceHtmlCharacters a real static property

Local changes:
* MWEntityNode: Fix lookup of whitespaceHtmlCharacters

  Property is now in 'static', and use registry to look up
  TextNode by symbolic name.

Change-Id: Ied8c0c6feb69141c7c53fc4cc790774dee2cb63c
Depends-On: I7537b46a9fd58dfb2bd18dc4ed469aa221b96e86
2016-03-03 08:13:33 -08:00
Ed Sanders 115bf4b3d2 CategoryWidget: Remove reorder event fix after upstream fix
Change-Id: I9088c931433b0824f72b4c77d0fd05cb062068f7
Depends-On: I67945db3652b0edb24b490089b8ea5a43f0b29d0
2016-03-03 15:53:49 +00:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
2016-03-03 14:58:14 +00:00
jenkins-bot 659b9c3576 Merge "[BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages" 2016-03-02 23:33:32 +00:00
Translation updater bot 61cda9824f Localisation updates from https://translatewiki.net.
Change-Id: Ife76752d154e4b595a570e8c8fefed114362dc9f
2016-03-02 23:40:57 +01:00
Alex Monk a3f77d9479 Education popup: Also handle clicks on dots
Bug: T128440
Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
2016-03-02 21:48:05 +00:00
Alex Monk 4ed6fd4010 Change Accept header a bit
Per post-merge commit on I77af4b58 by Subbu

Bug: T128233
Change-Id: I30c4c1ad5b68e5b8a006d7a6c7bcbaac7e2eb164
2016-03-02 15:37:37 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
2016-03-02 13:50:44 +01:00
Alex Monk 21334a0fa8 Keep summary and checkbox selections when swtiching WTE->VE
Bug: T128529
Change-Id: I8a7deac1c4d9390c1db7d78c3e0a11d927ef127b
2016-03-02 11:55:50 +00:00
Ed Sanders d94d98ebfe ArticleTarget: Update documentation
'onReady' no longer exists

Change-Id: I6fbcf619ba471f69380a64ba02994bd6ef0ca246
2016-03-01 22:03:07 +00:00
jenkins-bot 7d1ddae652 Merge "MWTemplateSpecModel: Use namespace constant" 2016-03-01 21:56:51 +00:00
jenkins-bot 1619ca17aa Merge "MWTemplatePage: Don't assume template is the template namespace" 2016-03-01 21:51:19 +00:00
Ed Sanders 1e800f2fdf MWTemplateSpecModel: Use namespace constant
Change-Id: I4404ee726550ca9aa9322720736f6f3778278df7
2016-03-01 21:41:10 +00:00
Ed Sanders 5b17cbca67 MWTemplatePage: Don't assume template is the template namespace
Content can be transcluded from any namespace using '{{:'.

Bug: T128333
Change-Id: Ifa076960958d1e72f302c5bfd5d896427a0e721f
2016-03-01 13:40:38 -08:00
Translation updater bot eceb548e6c Localisation updates from https://translatewiki.net.
Change-Id: Id1453f111870ee703f552fa407dab76b19d786f5
2016-03-01 22:04:45 +01:00
jenkins-bot a0caedc6d9 Merge "API: Send Accept: header to RESTbase" 2016-03-01 03:24:45 +00:00
Alex Monk 2f135e9590 API: Send Accept: header to RESTbase
Bug: T128233
Change-Id: I77af4b58e5469a898063a3f838802e4f5769514b
2016-03-01 01:14:02 +00:00
Alex Monk d46c5e9f91 Fix WTE->VE switching in prefer-wt SET mode
Bug: T128402
Change-Id: I56af672f2334214f048a4bbfe2f9fab891832792
2016-02-29 23:46:11 +00:00
David Lynch 7486f74c6f MWMediaDialog: Only cache relevant information
Trim the cached image data from the media dialog down so that it only caches
the same information that would have been fetched for a non-uploaded image.
Consistency!

Bug: T126081
Change-Id: I0f057c111b66f29c6360e27f97256384f5320b75
2016-02-29 10:16:34 -06:00
jenkins-bot e39d8a744b Merge "Show welcome dialog on mobile too" 2016-02-29 03:02:03 +00:00
jenkins-bot 517bb92a79 Merge "Give a useful message in the temporary blank edit screen" 2016-02-29 02:56:12 +00:00
Translation updater bot 7546362fa9 Localisation updates from https://translatewiki.net.
Change-Id: I7bade8021975fc1c3e2426211e6805a913f07891
2016-02-28 22:00:32 +01:00
jenkins-bot 70a9cee5f3 Merge "Update VE core submodule to master (0371bbe)" 2016-02-28 01:12:55 +00:00
jenkins-bot 03448253b3 Merge "Revert "Compress PNGs with zopflipng"" 2016-02-28 00:29:30 +00:00
Legoktm 7ebac23f86 Revert "Compress PNGs with zopflipng"
This reverts commit cbb7831938.

Change-Id: Ide4880a4a980847bb14cc5880662a4d2142581b8
2016-02-28 00:07:50 +00:00
Alex Monk ade0862db1 Give a useful message in the temporary blank edit screen
Bug: T128028
Change-Id: Ife0a9de96965a9848f362696fc403708fd344825
2016-02-27 21:42:10 +00:00
Translation updater bot e7ad07513a Localisation updates from https://translatewiki.net.
Change-Id: I88bf6d9f401bfbeab5e256a3b6169541ce8ac0eb
2016-02-27 21:59:35 +01:00
James D. Forrester ab4d3e956b Update VE core submodule to master (0371bbe)
New changes:
0371bbe [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern

Local changes: Use new VisualEditorSupportCheck pattern

Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
2016-02-26 12:26:56 -08:00
Ed Sanders 34d607d546 EducationPopupTool: Use vendor prefixes for animation
Bug: T128133
Change-Id: Ic061b50e1ed68ea35ac0ccbefbcb5252f917d35f
2016-02-26 15:34:06 +00:00
Ed Sanders 8f028813e5 CategoryWidget: Update to work with new DraggableGroupElement
Change-Id: Iefac99dba0e6b8ed3eaaa1d5f1d92e402e3cf2db
2016-02-25 16:07:50 -08:00
Alex Monk ced27f348f Show welcome dialog on mobile too
Bug: T112599
Change-Id: Ie04aab468c80dabc84e1386e7529138e1101450e
2016-02-25 22:03:00 +00:00
Translation updater bot cef228ec1d Localisation updates from https://translatewiki.net.
Change-Id: I8a8e0b9b879d18d8011821e49dc8c23624652a38
2016-02-25 22:22:09 +01:00
jenkins-bot 7bef4c9a20 Merge "Warn for empty summary when edit section used" 2016-02-25 18:56:57 +00:00
Translation updater bot 48a2404923 Localisation updates from https://translatewiki.net.
Change-Id: I0a5b177af81d7f05a86b18f5089a76545b2b8860
2016-02-24 22:03:55 +01:00
jenkins-bot 222a5361ba Merge "[BrowserTest] Fix ve.init is undefined error messages in Selenium tests" 2016-02-24 17:56:57 +00:00
jenkins-bot 79d8849b49 Merge "Make surface measurable while activating" 2016-02-24 01:33:47 +00:00
Translation updater bot 4fdef459ae Localisation updates from https://translatewiki.net.
Change-Id: I32522ae9e647712d6256174fade8e0314808b739
2016-02-23 22:35:50 +01:00
Ed Sanders 229a088f34 Make surface measurable while activating
If the surface is display:none then $.width always
returns 0, which breaks features like FocusableNode's
invisible icon.

Bug: T127319
Change-Id: Ib157ffaeb56fca2bdc26868d830c4bf8feafa2a8
2016-02-23 17:05:09 +00:00
wctaiwan 5da37932a2 Warn for empty summary when edit section used
Warn the user about an empty edit summary when the "edit section"
link is used to trigger VE.

Re-does Ic7b456ca a different way.

Bug: T114857
Change-Id: I319c9c5bed47140a81eb409d490c9f82b89a49fe
2016-02-23 00:34:12 +00:00
jenkins-bot 74b2489276 Merge "Link to file description pages in media dialog" 2016-02-22 21:07:43 +00:00
Translation updater bot ed26366723 Localisation updates from https://translatewiki.net.
Change-Id: Ib209a100469a77418cc66174d69bc6955101a7a3
2016-02-22 21:42:37 +01:00
jenkins-bot 0b8f6b576d Merge "Transclusion dialog: Simplify example/default value labels" 2016-02-22 15:48:07 +00:00
Ed Sanders 816fca78e8 Transclusion dialog: Simplify example/default value labels
'Value' comes across as a bit technical. 'e.g.' is more common
for 'example value'. Truncate 'Default value:' to just 'Default:'.

Change-Id: Ie03fb64a01846071ccdcb673439fc568b9d0de78
2016-02-22 15:40:19 +00:00
jenkins-bot 705fc76e62 Merge "MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia)" 2016-02-22 06:34:05 +00:00
jenkins-bot 0f9a09be73 Merge "Make platform language functions actually work" 2016-02-22 06:34:02 +00:00
Ed Sanders 083182debd Make platform language functions actually work
Previously arguments were not getting passed through.

Change-Id: I19fbd6f8a7f32163a85dda01fa46ac56a8c78cf8
2016-02-22 00:05:05 +00:00
Translation updater bot 56e29facc9 Localisation updates from https://translatewiki.net.
Change-Id: I8f4817ee86f71cf8233069b48b5dfd842d0fadff
2016-02-21 22:30:14 +01:00
Ed Sanders deb676e73d MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia)
Change-Id: I4fabf5f8d87b9b21623883203b9d6965a0ff33a0
2016-02-21 18:20:30 +00:00
Alex Monk ca5cab52af Link to file description pages in media dialog
Bug: T125227
Change-Id: I243f5479ab27ab098d41db08ff4a53195d382577
2016-02-21 03:45:37 +00:00
Ori Livneh cbb7831938 Compress PNGs with zopflipng
Zopfli is the most efficient DEFLATE compression algorithm, trading run-time
performance for file sizes that are typically 3-8% smaller than those produced
by zlib with the maximum compression setting. Its output is Deflate-compatible,
so no specialized decoder is needed.

This change was created by running zopflipng against all the PNG files in this
repository. The exact invocation was:

  git ls-files --exclude-per-directory=.gitignore -- '*.png' \|
    parallel zopflipng -m -y {} {} \;

Files which zopflipng was not able to compress more efficiently were left unmodified.

Bug: T127608
Change-Id: Id5807b1ec56320b3474878290dd05600c1e389d5
2016-02-21 00:14:58 +00:00
Translation updater bot 3fd583d1d7 Localisation updates from https://translatewiki.net.
Change-Id: I035d1386ec12fdcd6152cf25a029d9c133c7c1f9
2016-02-20 22:25:46 +01:00
Translation updater bot d300f6a1ff Localisation updates from https://translatewiki.net.
Change-Id: I826fa20c2850c5711e81863104d39453daaa40b3
2016-02-19 22:12:30 +01:00
jenkins-bot 30e6acfff2 Merge "MWMetaDialog: Fix setup of pages" 2016-02-19 19:52:55 +00:00
Ed Sanders 15a47665c8 Meta dialog: Use window action to open windows
Because abstraction.

Change-Id: I9811db4380c6cf37a73a76b97c8439f94723c5a6
2016-02-19 17:37:42 +00:00
Translation updater bot acc2347eee Localisation updates from https://translatewiki.net.
Change-Id: I7dae6beab2b97fefffa0bdc72766e553da7a4c75
2016-02-18 22:18:44 +01:00
James D. Forrester 6e6ac1656f MWPopupTool: Update Phabricator URL broken by upgrade
Change-Id: I17fc6178729e246643e999e622b84e34fc7959b3
2016-02-18 11:24:00 -08:00
Ed Sanders b70eb51491 MWMetaDialog: Fix setup of pages
Only call setup in ready process, as setup includes setting
focus. Defer fitInput call to category widget until transition
is finished so measurements are correct.

Change-Id: I49a30402cf58e36f16316e3ab04fa3349d19954e
2016-02-18 17:14:45 +00:00
Ed Sanders 704ec7ad3f MWCategoryWidget: Improve caching
For every title request, store an entry in noramlizedTitle to
avoid ever making an API request for that category again.

This prevents API requests from being fired every time a
category was moved, which in turn prevents the list from
flickering as it waits for the API request to resolve.

Also normalise the spelling of normalize to en-US/en-GB-oxendict

Bug: T127317
Change-Id: Ie26d9d60fb83981c45ff27199e38ae98e5560a28
2016-02-18 17:14:33 +00:00
Željko Filipin 60a08f925c [BrowserTest] Fix ve.init is undefined error messages in Selenium tests
All scenarios that are passing are enabled to run in Jenkins.
(The commit increases the number of passing scenarios from 2 to 18.)

Bug: T126966
Change-Id: I9789ca42717133120197c4625bb8dad4ea496aa8
2016-02-18 15:42:05 +01:00
Ed Sanders 7eeb136d94 MWCategoryWidget: Use namespace constants from config
Change-Id: I63661ce49dbb0fac62cb7dbd65c466cfdd6e57b0
2016-02-18 11:36:31 +00:00
James D. Forrester cebaacb546 Update VE core submodule to master (cdfd84e)
New changes:
c02ea46 Clarify documentation of directionality methods
43c9b6f Move initialisation browser support checking from downstream
c89be66 Localisation updates from https://translatewiki.net.
5fb7907 Follow-up c89be66: Fix build for added language 'nan'
fc74fab dm.ElementLinearData.compareElements: Add a few missed test cases

Local changes:
Use initialisation browser support checking from upstream

Depends-On: I27a8e7b4376647f01cee648de987dc3ca6a060d5
Change-Id: I3fc79422ee5e487cf5fae3929fe492f21cd2840a
2016-02-17 20:04:16 -08:00
Translation updater bot dabeb4218d Localisation updates from https://translatewiki.net.
Change-Id: Iaabe8dd045b2670aeb9fc0164fcb30f682f73b6c
2016-02-17 22:52:14 +01:00
Alex Monk 83d8a7d9bb Don't remove .ve-activated after successfully activating
hideLoading always gets called after activating, not just failing

Follows-up: I13058ae1

Bug: T127184
Change-Id: I47d1892feacbfcf832aa32f689f173601b76c4ba
2016-02-17 15:36:18 +00:00
Translation updater bot 3ec98ab32d Localisation updates from https://translatewiki.net.
Change-Id: I18bd9573f32007ef6a112b035d0bea503d4c581b
2016-02-16 23:13:41 +01:00
jenkins-bot 88c5316f22 Merge "Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit" 2016-02-16 16:56:15 +00:00
Translation updater bot 6c9b6f0fd7 Localisation updates from https://translatewiki.net.
Change-Id: I2ac29726abb9a68893926d5ab1e06985b5a81cf9
2016-02-15 21:42:28 +01:00
Željko Filipin 966f2f7bbb [BrowserTest] Jenkins runs only passing Cucumber scenarios
To get at least some Cucumber scenarios running in Jenkins, disable all
of them that are failing and run only ones that are passing.

The next step will be to fix failing scenarios.

Bug: T94162
Change-Id: Id0338c1d6b86d6b45220c5c0802074be397fb607
2016-02-15 13:18:19 +00:00
Translation updater bot db852aff65 Localisation updates from https://translatewiki.net.
Change-Id: I3e66b91d4c39d676e167e5d0cfdc914e44c51fa4
2016-02-14 21:31:45 +01:00
Translation updater bot 747a90ada2 Localisation updates from https://translatewiki.net.
Change-Id: If10088f3fc527750ea96bd73d55e8c412d5c1c66
2016-02-13 23:02:29 +01:00
Alex Monk 9a1c0762cb Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit
Bug: T125998
Change-Id: I2982f6e5f26086a1175b9fc8c3039a2143a44659
2016-02-13 02:56:01 +00:00
Alex Monk 1c1d018bc7 Unbreak VE
Follow-up to I13058ae1

Change-Id: Icb30f87746bea3911379fca9766877a36e8b5975
2016-02-13 00:58:42 +00:00
Translation updater bot 685bacc990 Localisation updates from https://translatewiki.net.
Change-Id: Ibd9a19ca100c3c0d392ec40095601db780d29103
2016-02-12 22:12:14 +01:00
jenkins-bot bcae181cec Merge "Try to make MW->VE switching failures break less things" 2016-02-12 17:29:29 +00:00
Translation updater bot 40bbaa9c71 Localisation updates from https://translatewiki.net.
Change-Id: Ia32d187a8afac039d4d2fb71a233fc25e0f87039
2016-02-11 21:41:11 +01:00
Alex Monk 4a288a5866 Try to make MW->VE switching failures break less things
* Try to hide loading bar on failure
* Don't set wgAction back to 'view' if we're dropping the user back to the
  wikitext editor

Bug: T125580
Change-Id: I13058ae131a1dda3b172e78d9b143d70831c47f1
2016-02-11 02:39:06 +00:00
Ed Sanders af8e23ec6e Remove code for varying MWLinkInspectorTool title
The title is visibly varied in the context menu separately, and
we don't usually change the link tool's title - so this is just
a performance drain (updateState happens a lot).

Change-Id: I9cf2aa509a6aac3a2914fa52167cb4463843cd72
2016-02-11 02:22:16 +00:00
Translation updater bot 35cf5524b3 Localisation updates from https://translatewiki.net.
Change-Id: Ide3b91bb90a8fd3c566bd657a13997211d8a345c
2016-02-10 21:11:44 +01:00
jenkins-bot 0611527d77 Merge "Remove translations of messages since moved to Cite/Citoid" 2016-02-10 08:08:51 +00:00
jenkins-bot 4a751524c4 Merge "Edit mode switch: Show popup next to VE switch button" 2016-02-10 01:51:57 +00:00
Ed Sanders 80124c88a6 Edit mode switch: Show popup next to VE switch button
Only show if the user came from VE.

Change-Id: Ic362ba534d135fca5516c8ba401f6b2a22886ff1
2016-02-10 01:36:32 +00:00
Alex Monk 863a2c2974 Don't try to tell the server to set preferences to their current values
It's rather pointless.

Change-Id: I8065af1d61108ce843c0afd2eaa0f1f9b85b6998
2016-02-10 01:04:47 +00:00
Ed Sanders e073a431fc Remove translations of messages since moved to Cite/Citoid
Change-Id: I692f03b374ec28ec6d81aab2d2d6fcd7705cedc5
2016-02-10 00:39:18 +00:00
Translation updater bot 829b2cd430 Localisation updates from https://translatewiki.net.
Change-Id: I28e88ed6e5da7567693ee2833e501696251deecd
2016-02-09 21:42:50 +01:00
jenkins-bot d5f6c220d3 Merge "Follow-up I7e1edcf05c: Remove MonoBook z-index hack" 2016-02-09 14:28:16 +00:00
jenkins-bot 1844af1588 Merge "ve.init.mw.trackSubscriber: Sample at 6.25%" 2016-02-09 01:06:23 +00:00
James D. Forrester a1db489d95 ve.init.mw.trackSubscriber: Sample at 6.25%
Bug: T125598
Change-Id: I1915a6456ba5dfc10e4a52df24cee2e68b27e526
2016-02-08 13:22:33 -08:00
Translation updater bot 047517fa22 Localisation updates from https://translatewiki.net.
Change-Id: I475a76215ab50328eb2c65d68b2c4be2a5afd6e2
2016-02-08 22:17:32 +01:00
jenkins-bot e5eb83ff8b Merge "build: Bump various devDeps to latest and make pass" 2016-02-08 18:18:03 +00:00
Ed Sanders 25be46a57d Fix transclusion node cloneElement method
* Override the static cloneElement. getClonedElement shouldn't
  be overridden as doing so misses static invocations.
* Apply the same fix to extension nodes
* Fix DOM loop to reference clone.originalDomElements[ i ]

Logically depends on Id8024c171c to work.

Bug: T126169
Bug: T126114
Change-Id: Icf4d3115db5b12b97a6c805ff3d0b71d9e88b804
2016-02-08 15:29:19 +00:00
jenkins-bot a996356e12 Merge "MWImageModel: Use clearDefaultDimensions" 2016-02-08 12:52:10 +00:00
Ed Sanders cfe21d317d MWImageModel: Use clearDefaultDimensions
setDefaultDimensions( {} ) is a no-op.

Bug: T126078
Change-Id: I1ef7cae04574e2561d21d4071d19a0067d81b263
2016-02-08 12:37:26 +00:00
James D. Forrester e6e492efc6 build: Bump various devDeps to latest and make pass
* grunt-contrib-jshint: 0.11.3 -> 0.12.0
  This version of the linter cleans up a number of options. 'es5' is now assumed to be
  true by default, and replaced as 'esversion'; 'latedef' is extended to also cover
  functions' defintions, disabled for us for now; 'futurehostile' is introduced to aid
  future-incompatible names for ES6+ support.

  I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this file is
  meant to be loaded by all JS-capable clients to determine if it is (amongst other
  things) capable of ES5, so now we assert ES3 compatibility via jshint.

* grunt-jscs: 2.5.0 -> 2.7.0
  Minor version bump that doesn't affect us.

* grunt-jsonlint: 1.0.6 -> 1.0.7
  Trivial version bump that doesn't affect us.

Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
2016-02-07 19:41:21 -08:00
jenkins-bot 2b01e43777 Merge "DesktopTarget: Move generic VE desktop styles into a separate module" 2016-02-08 01:59:56 +00:00
Ed Sanders 739f924e98 Follow-up I7e1edcf05c: Remove MonoBook z-index hack
The cited reasons were that the the logo and search bar
have a z-index of 3, but that doesn't matter as they are
nested in other elements with z-indexes.

Change-Id: I7ff279efe7c01ba1ffb1fa0d460d59a493ccc47a
2016-02-07 17:40:50 -08:00
Ed Sanders c51cef07b9 DesktopTarget: Move generic VE desktop styles into a separate module
Here they can be re-used by other VE desktop targets,e.g. Flow.

Change-Id: I18431ff73fc1c6ab5639a579e85b0f0cc48cb9ce
2016-02-07 17:39:57 -08:00
Translation updater bot 0138f6a71f Localisation updates from https://translatewiki.net.
Change-Id: Ia7c748204f03aa2be7f403846118753c5f174669
2016-02-07 22:22:53 +01:00
jenkins-bot 16c498fa97 Merge "DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface" 2016-02-07 10:30:06 +00:00
Ed Sanders efd41fbc74 Remove global overlay hack now fixed in Vector
Change-Id: Ic5cfb7ae4d244799be56e12b4b0a44b6ddd00303
Depends-On: I5ebb4e59e3714dfaa3d755ecf6285009efe7b62a
2016-02-07 03:26:02 +00:00
Ed Sanders 9bf010c33c DesktopArticleTarget: Cleanup styles
* Use more specific ve-init-mw-desktopArticleTarget class
* Add comments and reorder in places

Change-Id: Ic9291d3e50304fe3a0efa7ace1ce93c7fba91d98
2016-02-06 19:26:06 -08:00
Alex Monk 138fafbbb9 DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface
So the normal logic is used to close other windows etc.

Bug: T125479
Change-Id: Iee9ef7484de745f3adced28cdbcc87a0c2b597f5
2016-02-06 02:02:39 +00:00
jenkins-bot e0de4c4447 Merge "Remove all Extension:Cite code, now moved there" 2016-02-05 22:17:08 +00:00
jenkins-bot 5a360f4cbb Merge "Remove mwReference tests, moved to Cite extension" 2016-02-05 22:16:24 +00:00
James D. Forrester 1e0486a679 Remove all Extension:Cite code, now moved there
Depends-on: I39936ed83d5a60471a0a75da753f498e80aef234
Depends-on: Ifd853bf9f901065798bd0063aeaa786a3761aa71
Depends-on: I32c93c5118eafe5f071252290c58d3de8dacc81a
Change-Id: Iba0f25b3ebe4e5e63377da57afb760d6980f9907
2016-02-05 21:36:56 +00:00
Ed Sanders 094555cb3c Remove mwReference tests, moved to Cite extension
Change-Id: I07a2bf45117c2d14c7b00875c0a710e20980a23a
2016-02-05 21:36:56 +00:00
Translation updater bot bd848ac4f1 Localisation updates from https://translatewiki.net.
Change-Id: Ic65af97f6c29c1e0c47317997b18ab064f80a2f5
2016-02-05 21:54:43 +01:00
Translation updater bot 7c07b2706b Localisation updates from https://translatewiki.net.
Change-Id: Ibd8991424c15ff9d6700c5103c75aff17aa452d9
2016-02-04 22:18:02 +01:00
Ed Sanders 5864a62134 Default extensions to not use the 'invisible icon'
Bug: T125767
Change-Id: I58c58080382974a887ebc52c1ac80cb5970db8c7
2016-02-04 19:38:16 +00:00
Translation updater bot 622ca082ca Localisation updates from https://translatewiki.net.
Change-Id: I29d93111a508e8af12752b6b93dc13d106f01d5f
2016-02-03 23:09:41 +01:00
Translation updater bot 0acd4160f4 Localisation updates from https://translatewiki.net.
Change-Id: Id1d12847d0c09993453c889af16266b9bac9d9ee
2016-02-02 21:33:11 +01:00
jenkins-bot 804ab26fb2 Merge "Check xhr.responseText is set before trying to send it to $.byteLength" 2016-02-02 19:08:08 +00:00
Alex Monk 9808d04bfe Check xhr.responseText is set before trying to send it to $.byteLength
Bug: T125399
Change-Id: I09881fe8b6db7d95e32732129d043c4a13fa7a9a
2016-02-02 18:52:56 +00:00
Ed Sanders 98bc5daba1 Use new iconWhenInvisible feature in Transclusion/Extenion nodes
Change-Id: Iba55676c06a1cd625187c38c1ae0c9c20b065827
Depends-On: I127bb5d34850cdc545ea3c05d0fc41a8ae1c6dea
2016-02-02 18:07:13 +00:00
Translation updater bot 9ec0705a2b Localisation updates from https://translatewiki.net.
Change-Id: If02911bde5c9cdbaeeaf52a45f4746b1b61b7d16
2016-02-01 21:56:13 +01:00
Ed Sanders db5ed236dd Add controls for wikitable and sortable to table dialog
Bug: T95189
Depends-On: Ife3f3505b845db28dd29a07e9be1533c39726ce1
Change-Id: I1672d8cd2e138df1fad19dcfd948700942e87f2c
2016-02-01 10:58:42 -08:00
Ed Sanders 74358498da Update VE core submodule to master (70ff8cc)
New changes:
242ab45 DesktopContext: Float the context when it goes beyond the viewport
405c44d Rename TableContext to TableLineContext
6c564be Sort messages alphabetically
70ff8cc Introduce table and table cell context

Change-Id: I4357162bc192c90f99ca0aec12eb67bf848e5504
2016-02-01 10:51:26 -08:00
Ed Sanders 5e296a959b Sort messages alphabetically
Change-Id: I45b440b1b020ea79ab4c1eba78effb526c41ddc4
2016-02-01 17:36:43 +00:00
Translation updater bot 122d76bfbe Localisation updates from https://translatewiki.net.
Change-Id: Ib037f762e584c8b6bc153a469057b362e31393fc
2016-01-31 21:42:24 +01:00
Translation updater bot 1b33f7b912 Localisation updates from https://translatewiki.net.
Change-Id: I499a7c36f46bed65f06c881de3df9fdf53e20036
2016-01-30 22:50:35 +01:00
Alex Monk 8cc034b9af Run VE->WTE modification checks regardless of how the user got into VE
I think this fixes a bug similar to the one described in the bug below.

Bug: T124708
Change-Id: I61558227315bec36b71dac281b8da311a3d6bb1a
2016-01-30 03:06:46 +00:00
Translation updater bot de5f372ac5 Localisation updates from https://translatewiki.net.
Change-Id: Idfb5e5fdd92cae124b428c768fd89baa6239541c
2016-01-29 22:43:50 +01:00
Ed Sanders 0ed45dbf61 MWTable: use new sanitization method
This prevents tables from getting sanitized even on
VE to VE copy. Also by calling ClassAttributeNode sanitize
extra CSS classes are removed.

Bug: T97462
Bug: T125220
Depends-On: Ia3ce386b2a03bc227818b10423bca72c736c0656
Change-Id: Ifd91e00b40665b446bbdcdf8859d2bb641bc0e67
2016-01-29 10:29:19 -08:00
jenkins-bot 66b0ff5111 Merge "ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl" 2016-01-29 17:00:38 +00:00
Translation updater bot 77a11811fb Localisation updates from https://translatewiki.net.
Change-Id: If88cee4c9c766aabdccc4d996d48c0151e5611bb
2016-01-28 21:11:06 +01:00
Bartosz Dziewoński fb54d03a59 ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl
Change-Id: Iae61d13a6c776c86bcec6744a2153b14c07722e9
2016-01-28 19:02:38 +01:00
jenkins-bot e4e7fce00e Merge "Create a more neutral warning message" 2016-01-28 07:57:33 +00:00
Justin Du 854f0a3692 Create a more neutral warning message
Change was made because editing mode is not always left to go to view mode,
but for example also because of clicking on "History".

Bug: T121754
Change-Id: Ibc1ba697081e60b8a797f5ea1b814a320ba812c3
2016-01-28 07:29:09 +00:00
Translation updater bot e181ca806b Localisation updates from https://translatewiki.net.
Change-Id: I694abc3d49df4ed6b580a10bdc37ba24fc288ac0
2016-01-27 21:46:32 +01:00
jenkins-bot f78dd8ad72 Merge "MWWelcomeDialog: Let the user switch editors" 2016-01-27 00:20:10 +00:00