Commit graph

2289 commits

Author SHA1 Message Date
Alex Monk 8f7713e796 Apply link styling logic to transclusion nodes
Only template nodes for now. Not sure what we can do about generated content nodes in general...

Bug: 65353
Change-Id: I848f36764b446ed30c74c0e641d0973008f6880b
2014-10-08 15:03:40 +01:00
suchetag 0bb6d3b333 Getting rid of ve.splitClusters in ve-mw
Bug: 57628
Change-Id: I28cb52bd2af564f208b9414154977c351f5c3fcb
2014-10-08 08:09:19 +00:00
Ed Sanders 1af18c3c12 Update VE core submodule to master (984b57a)
New changes:
6bbcd6a Localisation updates from https://translatewiki.net.
b8d8a5b [BREAKING CHANGE] The Great Selection Rewrite of 2014

Local changes:
Update to use new selection/range API

Change-Id: I5480d5c77d599c93c2d374fac88bb2fdb68b0024
2014-10-07 21:39:33 +02:00
Translation updater bot e1806defb5 Localisation updates from https://translatewiki.net.
Change-Id: I121558fe34ccaf09bce2b85c6439bc8a4da0ec5e
2014-10-07 21:03:19 +02:00
jenkins-bot 93e0c3c274 Merge "In first-time dialog, explain how to switch to source without losing work" 2014-10-07 02:29:09 +00:00
Matthew Flaschen 9c3b8f5c4a In first-time dialog, explain how to switch to source without losing work
Change-Id: I462ede0a13f2027fbfb70f94cd87f77ca7c6d6a2
2014-10-06 19:24:16 -07:00
jenkins-bot dcdc5ab0c0 Merge "mw.Platform: Use 'mediawiki.language' for language fallback chain" 2014-10-06 12:13:07 +00:00
Translation updater bot 70fe9aac4d Localisation updates from https://translatewiki.net.
Change-Id: I45bf9ccf9db5540165f1d8cff5e3754b6b46ce7f
2014-10-05 22:17:14 +02:00
Bartosz Dziewoński d751d569db mw.Platform: Use 'mediawiki.language' for language fallback chain
Bonus:
* Remove doubled dependency on mediawiki.Uri
* Add missing dependency on mediawiki.language

Change-Id: Ide716aad7b9f08ae9a24f99812f07273d89da33a
2014-10-05 19:00:32 +00:00
Translation updater bot 4f811920ed Localisation updates from https://translatewiki.net.
Change-Id: Id9b6d44a5e4d80e0d5e8e62cb7f0b5f40fda7af9
2014-10-02 23:28:04 +02:00
jenkins-bot c823b736ec Merge "[BrowserTests] Put automatic language screenshots in more specific category" 2014-10-02 15:34:13 +00:00
Željko Filipin 4d036f6fe1 [BrowserTest] Fixed language screenshot scenario
VisualEditor no longer has cancel button.

Change-Id: Ia06469c23cc527ae87170d6aa5b9066fbc9933a6
Paired-With: Amir Aharoni
2014-10-02 15:34:04 +02:00
Željko Filipin 4ab4ad64dc [BrowserTest] Fix failing VisualEditor_save_dialog scenario
Looks like VisualEditor does not allow saving the page, if the changes
to the page were made while the browser did not have focus.

Change-Id: I959bcb4cc2f72237d2ea75249a56e140d4f7c867
Paired-With: Amir Aharoni
2014-10-02 14:45:24 +02:00
Roan Kattouw 005c6fef27 Fix syntax error in mittoHidden selector
Bug: 71521
Change-Id: Id34987e992a7c13cdfcfec85a7c33f7538606fe0
2014-10-01 11:04:31 -07:00
jenkins-bot df52c9bd0b Merge "Account for categories being removed twice in MWCategoryWidget" 2014-09-30 22:10:31 +00:00
Alex Monk 0c0b545959 Blacklist div[id = kloutify] as well
Followup to I8af9f7ba

Bug: 67006
Change-Id: I84c8902ae8a81f9b62f6817e2f58809f28ca97f7
2014-09-30 23:01:00 +01:00
Alex Monk 0547d8c8ec Remove certain blacklisted elements when getting HTML from document
Hack to try to kill a class of bugs caused by misbehaving browser plugins.

Unable to test whether this fixes them or not.

Bug: 68900
Bug: 51423
Bug: 51521
Bug: 52791
Bug: 52884
Bug: 53252
Bug: 61776
Bug: 63121
Bug: 63229
Change-Id: I8af9f7ba4be45b42f6e2e382ff1a3e1f452058ba
2014-09-30 22:51:06 +01:00
Translation updater bot a519522b53 Localisation updates from https://translatewiki.net.
Change-Id: Iba41f0bfa5c45e471f7cceb8c44dea3cd81a57ab
2014-09-30 22:54:55 +02:00
Roan Kattouw ff587f4f61 Account for categories being removed twice in MWCategoryWidget
Now that we use staging in the meta dialog, the following
sequence is possible:
* Add Category:Foo in UI (adds to DM and adds a widget)
* Remove Category:Foo in UI (removes from DM, removes widget)
* Click Cancel to leave meta dialog
** popStaging()
*** Undo removal of Foo (adds to DM, does not add a widget)
*** Undo addition of Foo (removes from DM, tries to remove nonexistent widget)

Add a check so trying to remove an already-removed widget
doesn't cause a JS error.

Bug: 71471
Change-Id: I34690364ce302b858e2a4429dbb97b57d39aae5f
2014-09-30 11:11:09 -07:00
jenkins-bot c8a408e8ce Merge "mw.LinkCache: Clean up" 2014-09-29 23:36:03 +00:00
Timo Tijhof 94c2c6c745 mw.LinkCache: Clean up
Pompidom.

Change-Id: Ia4e05d62845a7bce685cc9926101a238fe4bbce9
2014-09-29 16:33:46 -07:00
Translation updater bot 7641160262 Localisation updates from https://translatewiki.net.
Change-Id: I4b8568e0a5b626327722b45d69b5150e315389c8
2014-09-29 23:34:08 +02:00
Bartosz Dziewoński c81ed82fa8 Add rudimentary support for page status indicators
Just hide them when opening the editor and show again afterwards. Will
need Parsoid for proper support.

Corresponding patch in core: I2389ff9a5332a2b1d033eb75f0946e5241cfaaf4.

Bug: 23796
Change-Id: I3ce5e7869be50dcd189ca24e2b3d7ebc62de4fc4
2014-09-29 13:45:10 +02:00
Translation updater bot 8146fe213c Localisation updates from https://translatewiki.net.
Change-Id: Ieb47c49b357469adb62593088d99d48e37333a32
2014-09-28 22:37:03 +02:00
Translation updater bot 00dfc45919 Localisation updates from https://translatewiki.net.
Change-Id: I6900022d921e939a0d8c887f45785ac288deea15
2014-09-27 20:32:43 +02:00
James D. Forrester 5ed0f35e11 Move IE10 to the greylist too
Also add a test for IE11 being on the greylist.

Change-Id: I45f1b9f00320237597fa1974932c04102328f0b6
2014-09-26 12:56:04 -07:00
Vikas S Yaligar 9a5caf8dd2 [BrowserTest] Fixed failing language screenshot scenarios
Bug: 71298
Change-Id: Ifcd52935e782e292f9289a72d5e7c4ad12921b4b
2014-09-26 17:49:24 +00:00
jenkins-bot 7c1c8cfe2e Merge "Remove test for functionality tested in core" 2014-09-26 02:51:33 +00:00
jenkins-bot 64b2568465 Merge "Use mw.Title#getRelativeText to deal with titles relative to specific namespaces" 2014-09-26 02:50:43 +00:00
Alex Monk ef1cebd111 Use mw.Title#getRelativeText to deal with titles relative to specific namespaces
Added in MW core in Ie554adef, was backported to 1.24.

Change-Id: Iedc0319042529d41d29846d1734b5481850e9552
2014-09-26 02:47:18 +00:00
jenkins-bot 3d0aae0dcd Merge "Stop "Edit pages on double click" from affecting VE" 2014-09-25 22:52:19 +00:00
jenkins-bot 5e92ee61e0 Merge "Prevent exception throwing in getFilename of MWImageNode" 2014-09-25 21:50:43 +00:00
Translation updater bot dbc976927b Localisation updates from https://translatewiki.net.
Change-Id: I9f63163e0ad6c10f13d2aa5347aed1ec556c7df3
2014-09-25 23:08:13 +02:00
Alex Monk 77fc7e7d6c Stop "Edit pages on double click" from affecting VE
Relies on I0f6225b2

Bug: 53058
Change-Id: Ibd363dfb9da7d91055c541a83969d23401297603
2014-09-25 21:19:18 +01:00
James D. Forrester 136510b1cc [BrowserTests] Put automatic language screenshots in more specific category
Change-Id: I52f92a3e4da0f173596c8a68a572351deba46ade
2014-09-25 10:45:41 -07:00
Željko Filipin ac804a537a [BrowserTest] Disable screenshots for broken scenarios
Workaround for bug 71298.

Change-Id: I23ed22f8859a09821b6ef5edac8eff4ca0f3b17c
Paired-with: Amir Aharoni
Bug: 71298
2014-09-25 15:18:47 +02:00
jenkins-bot 5dcd099862 Merge "Really fix CategoryWidget checks for redirects to hidden categories this time" 2014-09-24 22:50:32 +00:00
Alex Monk 89f8334d58 Really fix CategoryWidget checks for redirects to hidden categories this time
Previous commit dealt with only part of a related problem.

Change-Id: Iffe319d5b6d1a5ea91acca26a9613e07bea0d8fe
2014-09-24 23:18:44 +01:00
jenkins-bot a6557cb051 Merge "Unbreak category widget check for hidden pages" 2014-09-24 22:08:33 +00:00
Alex Monk ea9ce0f5b0 Unbreak category widget check for hidden pages
Fixes Icb62b9b2. I have no idea how I managed to screw this up.
Was also causing an error in console when one of the categories was a redirect

Change-Id: I0321c8be1386cb010c3babb33e08fae0fcaf75ce
2014-09-24 22:59:53 +01:00
Translation updater bot 421bcc506e Localisation updates from https://translatewiki.net.
Change-Id: I6356e966774626f830769f4e546b4859ce98ae21
2014-09-24 22:21:13 +02:00
Ed Sanders 26751dc4a1 Prevent exception throwing in getFilename of MWImageNode
This doesn't happen in real life (as resource is always set) but
it allows us to contruct these nodes from the factory with no data.

Change-Id: Iea146f5dc128ad9d0f36a79b6fe67d622767d46c
2014-09-24 20:43:57 +01:00
Roan Kattouw 6347274f47 Update VE core submodule to master (6e68242)
New changes:
c06fa64 Account for isValid() becoming async
12e4840 Account for WhitespacePreservingTextInputWidget#getValue being called early

Local changes:
* Make MWLinkTargetInputWidget#isValid asynchronous

Bug: 71237
Bug: 71246
Change-Id: Iab83e743f99973f01a54b23fd5ddf1081f7effd6
2014-09-24 12:18:16 -07:00
Roan Kattouw 8517777b9f Update VE core submodule to master (8d5ec7a)
New changes:
8d5ec7a [BREAKING CHANGE] Rename ve.Document.getNodeFromOffset to getBranchNodeFromOffset

Local changes:
* Update calls for rename of getNodeFromOffset to getBranchNodeFromOffset

Change-Id: Ibc69f5a5deeed5698368bb19b30f14497c579e90
2014-09-24 11:34:14 -07:00
jenkins-bot f67989eaa5 Merge "Replace use of ve.isArray with native Array.isArray" 2014-09-24 03:05:57 +00:00
jenkins-bot 02a85676b9 Merge "Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget)" 2014-09-24 01:06:38 +00:00
Timo Tijhof 66de06b0fa Replace use of ve.isArray with native Array.isArray
Change-Id: Ibc45e0fd80db7da872f6ef934cef915be9366e06
2014-09-23 17:58:09 -07:00
Alex Monk 93e4c59e4f Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget)
Change-Id: Icb62b9b27ea1d61097d059fa268cc4834d46fc9f
2014-09-23 23:56:27 +01:00
jenkins-bot a5d8b636eb Merge "ve.ui.MWLiveExtensionInspector: Fix comment typo" 2014-09-23 21:57:31 +00:00
Bartosz Dziewoński 5849e7b8f8 ve.ui.MWLiveExtensionInspector: Fix comment typo
Change-Id: I6e35a5006364ba44de2804e6cd6cd79d6b73c0c3
2014-09-23 23:54:33 +02:00
Translation updater bot 625669f12b Localisation updates from https://translatewiki.net.
Change-Id: I55f61f07576931a694a9686495d899761f4a32fb
2014-09-23 22:04:58 +02:00
Translation updater bot c1d2851241 Localisation updates from https://translatewiki.net.
Change-Id: I3b09d38f6b8ab3652c0338acbdc34319b848e643
2014-09-22 21:50:45 +02:00
Translation updater bot ab3474f032 Localisation updates from https://translatewiki.net.
Change-Id: I80bb743ce8f0dd0e29ee3518e42841de7ea18cd6
2014-09-21 22:01:15 +02:00
Translation updater bot ba97a1ac6e Localisation updates from https://translatewiki.net.
Change-Id: Ief48d85ab343584bf2b230894a7b5c1f67c83a3a
2014-09-20 21:44:23 +02:00
Moriel Schottlender f4dc6fd240 Add 'autovalue' to TemplateData
Allow for an auto-value for parameters in TemplateData, and make sure
this autovalue is inserted as text when parameter is loaded. This is
mostly useful for referencing date or other dynamic templates inside
parameters.

Bug: 52029
Change-Id: I6203530798ffaa62cb26190c70f7ce391bddf123
2014-09-20 00:52:23 +00:00
Translation updater bot e88150cc05 Localisation updates from https://translatewiki.net.
Change-Id: Icb41461e1f20dc79e5f6fee637c7fadd319a79b0
2014-09-19 22:07:38 +02:00
Roan Kattouw 34ec304ec7 Update VE core submodule to master (d6904b5)
New changes:
925ed5c Move sluggability methods to model
a618491 Calculate slug positions in the model
b8fb05e Make the trigger demo kind of work again
e41d22e Update OOjs UI to v0.1.0-pre (ec785c2c64)
4119470 build: Make headers atop dist files suitable for distribution
fca4fec Follow-up cc657c4: Change strikethrough key command to not clash with Macs
a29a561 Add hasSlugAtOffset to DM document
9f47efb Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model
aa35e96 Remove hard coded types from canHaveSlugBefore and fix logic
49a239b Emit 'position' and 'contextChange' events correctly
3c50321 Refactor out finding of CE focusedNodes
d6904b5 Update OOjs UI to v0.1.0-pre (f2c3f12959)

Local changes:
* Move ce.Document tests to dm.Document

Change-Id: Ifa5abd0341e858b20e73e9071d597a25112cadfb
2014-09-18 17:03:46 -07:00
jenkins-bot 4025d1a723 Merge "Remove 'new' keyword where not used" 2014-09-18 23:24:03 +00:00
Ed Sanders 69ae829737 Remove test for functionality tested in core
Add comment to remaining test explaning its purpose.

Depends on Id7c291b in core.

Change-Id: Ia545edac3b2adbd6d45ed5427a9e5e6f9df0da54
2014-09-18 13:15:24 -07:00
Ed Sanders 480d9c05fc Remove 'new' keyword where not used
Factory methods create the instance internally.

Change-Id: I1daa9751536948edc98bd71305a942418806c459
2014-09-18 12:54:41 -07:00
Translation updater bot ad7529b283 Localisation updates from https://translatewiki.net.
Change-Id: Id007fb0b058d084cbcf5e3c0fcc426f205661e17
2014-09-18 20:55:34 +02:00
Translation updater bot 8e9a35fe37 Localisation updates from https://translatewiki.net.
Change-Id: I675e2fd39fa8084ba3fbc3740c36a7b48d7e1b0f
2014-09-17 22:47:23 +02:00
jenkins-bot 82e62f8ec6 Merge "Get confirmation when trying to insert/edit template/citation with required parameters missing" 2014-09-17 19:33:48 +00:00
Alex Monk b3ba809ccb Get confirmation when trying to insert/edit template/citation with required parameters missing
Relies on I5d894f8a in MW core. We'll need to update our wfUseMW when that gets merged.

Bug: 50747
Change-Id: I35e55658a3990121afe4d996ef4ee06547d2aa0c
2014-09-17 12:31:23 -07:00
jenkins-bot d59053575e Merge "Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten" 2014-09-17 02:13:22 +00:00
Roan Kattouw cf1a889ac8 Update VE core submodule to master (5f4b740)
New changes:
a047e72 [BREAKING CHANGE] Create ve.dm.Focusable and store focusable flag there

Local changes:
* Add new ve.dm.FocusableNode mixin where required

Change-Id: Ie9ee2de05acfe3c4c62c4864e65bd20397d6a069
2014-09-16 18:45:22 -07:00
jenkins-bot bdbc75473b Merge "Validate size widget when activating/deactivating apply button" 2014-09-16 23:54:26 +00:00
jenkins-bot 0f4e85ce11 Merge "Template dialog: Show up to the limit of parameters, not up to the limit + 1" 2014-09-16 23:44:55 +00:00
jenkins-bot d2bcc9dc05 Merge "Show pending state on action button and keep dialog open when switching to source mode" 2014-09-16 23:44:22 +00:00
jenkins-bot 370aadd619 Merge "Make <visualeditor-preference-enable> message respect plural rules" 2014-09-16 21:43:10 +00:00
Moriel Schottlender 20c4fbbc1e Validate size widget when activating/deactivating apply button
In the Media Dialog, make sure the size widget is valid before
applying or disabling the apply/save buttons.

Bug: 70861
Change-Id: I6ec9eb69fe6576f1c668270b12157de9910f0214
2014-09-16 14:48:40 -04:00
Translation updater bot 2ac26314b7 Localisation updates from https://translatewiki.net.
Change-Id: I8bc42c851314fe3d70068403b77a709f94be381f
2014-09-16 19:48:38 +02:00
James D. Forrester 92a6fdbb02 Make <visualeditor-preference-enable> message respect plural rules
Change-Id: I4660a530cd50a179c06a82295b6a24cae1b741b6
2014-09-16 10:35:57 -07:00
jenkins-bot 078f30f781 Merge "Use ve.parseXhtml() and ve.serializeXhtml()" 2014-09-16 02:39:39 +00:00
Roan Kattouw c4857a1f82 Use ve.parseXhtml() and ve.serializeXhtml()
Introduced in VE core in I0fb47f7c91f61.

In IE, this fixes corruption of style and bgcolor attributes.
In other browsers, the only change is that we now use
XMLSerializer rather than .outerHTML to serialize, but as
far as I can tell this isn't materially different. XMLSerializer
correctly uses HTML semantics when given an HTML document.

Bug: 70856
Change-Id: If48555fa4763e763484bbabfa0bc4ded0d0a5c58
2014-09-16 01:41:53 +00:00
jenkins-bot 6ec7789be6 Merge "Add contextual help to all remaining meta dialog controls" 2014-09-16 01:31:12 +00:00
James D. Forrester 712ea472d3 Add contextual help to all remaining meta dialog controls
Bug: 51798
Change-Id: I3f8141485c89e585595dbb853d32e69cbcaebac6
2014-09-15 16:26:12 -07:00
Alex Monk ceafcd5937 Check whether there is a range selected when enabling/disabling re-use citation tool
If there is no range selected, disable regardless of whether there are references in the document or not.

Bug: 70870
Change-Id: I2c281fefe7915345fafb735b3788166ab8118049
2014-09-16 00:18:23 +01:00
Cmcmahon b6b93fc860 [BrowserTest] inadvertent clash of identifiers from earlier update
Change-Id: I1a86db0f4fa9ee0f327cf371b76c9ebf25ddc17e
2014-09-15 14:48:49 -07:00
Cmcmahon e71699f06a [BrowserTests] Pick up the latest webdriver to run latest Firefox
Pure maintenance

Change-Id: I709bcae2a609904c5ce75e22c61588d5012dec17
2014-09-15 13:48:12 -07:00
Alex Monk 65b232a35b Show pending state on action button and keep dialog open when switching to source mode
Instead of doing a blocking overlay, we're simply keeping the dialog open,
which is necessary for the pending status of the action buttons anyway.

Requires Ib2c8f336 in OOUI

Bug: 65012
Change-Id: I65b5de4a1666a81b157a71f6fec490007689eb44
2014-09-15 20:44:55 +01:00
James D. Forrester 8cde565899 Template dialog: Show up to the limit of parameters, not up to the limit + 1
Bug: 70609
Change-Id: I26dc9c17fe7572d7b864000781fff6583edf9f9b
2014-09-15 12:13:47 -07:00
Translation updater bot e4a8b251eb Localisation updates from https://translatewiki.net.
Change-Id: Ifb2e827be70c18a7976d36dac4ba2f2c3786ba48
2014-09-15 02:11:59 +02:00
Translation updater bot 7faa561782 Localisation updates from https://translatewiki.net.
Change-Id: I32071f21af9ed6e606aa7aa23982aaef29641ee6
2014-09-13 00:50:00 +02:00
Roan Kattouw 7545868bc8 Don't return undefined in ve.init.mw.Platform#getLanguageName
When the language isn't found, return an empty string
instead of undefined.

Bug: 70731
Change-Id: Ia28e0d24e57e3a24414e04bee58ec76459665ad4
2014-09-12 14:43:31 -07:00
Cmcmahon 954fec83e1 [BrowserTest] UI text changed s/Cancel/Resume editing/.
Change-Id: I774b6a3cf02627ea0399377b9f6d57ca474ead07
2014-09-12 10:53:59 -07:00
Cmcmahon aa67deaeef [BrowserTest] add one test to validate new ie11 build
Change-Id: I9add1caf0083e757d0a7f6da513bd798fd74e97e
2014-09-12 08:55:14 -07:00
lokal-profil dbb94ea221 Correct typo in visualeditor-dialog-meta-settings-redirect-statichelp
Change-Id: Ibd9459903f8ce278e414fd7ba891f653109f913d
2014-09-12 15:26:11 +00:00
Translation updater bot ff803b321f Merge "Localisation updates from https://translatewiki.net." 2014-09-11 22:03:29 +00:00
Translation updater bot c13ee9c93c Localisation updates from https://translatewiki.net.
Change-Id: Ib0454ae6e13ca3e16b92615a743bc6d56b47c18d
2014-09-12 00:01:36 +02:00
jenkins-bot 050205ea85 Merge "Convert all instances of assert.equal to assert.strictEqual" 2014-09-11 21:37:45 +00:00
James D. Forrester b46159eeed Relabel the cancel button in the save dialog to "Resume editing"
Bug: 69116
Change-Id: I35289ff02681c3bf46a7bb491c017c500f30c7a6
2014-09-11 11:52:21 -07:00
Ed Sanders c35d68d52b Convert all instances of assert.equal to assert.strictEqual
We don't tolerate == in our code, so we shouldn't use it in our tests.

Change-Id: I6ed7aebbad8013839af2521819fc6507df014a1a
2014-09-11 10:50:44 -07:00
jenkins-bot c3bd61a3a5 Merge "Disable re-use citation tool if there are no references in the document" 2014-09-11 17:42:25 +00:00
Cmcmahon 3351241659 [BrowserTest] Add @safari and @internet_explorer tags for Jenkins build
Change-Id: Ia39fd2cf40cea7f6c4df364a45b0744ca92bfb7d
2014-09-11 08:11:47 -07:00
Alex Monk 72a118fc82 Disable re-use citation tool if there are no references in the document
Bug: 70640
Change-Id: I727857281644dffd23605d7792a3f71ee7c5b751
2014-09-11 00:13:10 +01:00
Alex Monk e6c4315d93 Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten
Category redirect stuff is currently broken because of I5c536697, but no one seems to have noticed.
Fix bug 69886 while we're here

Bug: 69886
Change-Id: I62cf23d0e86bc43d739bb4c4610a5a852146fa3f
2014-09-10 23:21:12 +01:00
Translation updater bot dc3351e615 Localisation updates from https://translatewiki.net.
Change-Id: I898f5d237545e7a26645be8bc272b4c7df86af8e
2014-09-10 23:44:39 +02:00
jenkins-bot d4f1f6ca7a Merge "Update LinkCache in MWTitleInputWidget" 2014-09-10 19:09:05 +00:00
Alex Monk 674f64dbaf Properly mark reference search index as empty when setting internal list
If it didn't get marked otherwise

Caused by I56909801

Bug: 70611
Change-Id: I81bca8f471c6685e48a7d3768f473a6faf5d8459
2014-09-10 00:13:42 +01:00