wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 06:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Account for categories being removed twice in MWCategoryWidget"

Browse source
This commit is contained in:
jenkins-bot 2014-09-30 22:10:31 +00:00 committed by Gerrit Code Review
parent 0c0b545959 ff587f4f61
commit df52c9bd0b
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
View file

@ -308,9 +308,11 @@ ve.ui.MWCategoryWidget.prototype.removeItems = function ( names ) {
for ( i = 0, len = names.length; i < len; i++ ) {
categoryItem = this.categories[names[i]];
categoryItem.disconnect( this );
items.push( categoryItem );
delete this.categories[names[i]];
if ( categoryItem ) {
categoryItem.disconnect( this );
items.push( categoryItem );
delete this.categories[names[i]];
}
}
OO.ui.GroupElement.prototype.removeItems.call( this, items );