Commit graph

4181 commits

Author SHA1 Message Date
jenkins-bot b26d84bfd6 Merge "CommentController/NewTopicController: Always use replyWidgetPromise" 2024-11-27 03:56:11 +00:00
Ed Sanders a4a335e6a9 CommentController/NewTopicController: Always use replyWidgetPromise
Remove the replyWidget property so users always have to use the
replyWidgetPromise.

Assume that the controller is setup immediately and so the
replyWidgetPromise will always be available.

Change-Id: Ib63952d745033721cac448feda9310e691c60090
2024-11-26 11:58:03 +00:00
Translation updater bot 4f6273e442
Localisation updates from https://translatewiki.net.
Change-Id: Id5394d122121e10549768bbf49f6cd278d03e0de
2024-11-26 08:16:29 +01:00
Ed Sanders 61a79ecb5e Remove unnecessary context variable
Change-Id: Ibfc0fc82f13f8268b8f4d48fd7d5f435c2e402f6
2024-11-25 17:15:58 +00:00
jenkins-bot 3345f49cbd Merge "Separate tag help links from their labels" 2024-11-25 17:11:31 +00:00
Translation updater bot 7f6cf234af
Localisation updates from https://translatewiki.net.
Change-Id: I7a6b843eaa89f9a7417b2f90d684e49dbfd9e447
2024-11-25 08:23:12 +01:00
jenkins-bot ce05e417e9 Merge "Use faster DOMUtils::hasClass()" 2024-11-23 04:03:21 +00:00
Translation updater bot 1e74745ce0
Localisation updates from https://translatewiki.net.
Change-Id: I5d2c91a25025a388b5c0fab2415a2e41bdea6907
2024-11-22 08:41:25 +01:00
Translation updater bot 50e2a7ad38
Localisation updates from https://translatewiki.net.
Change-Id: I66e3a87c8d072c5eb745b3b8968720cb7c4771f8
2024-11-21 08:21:42 +01:00
jenkins-bot c049828dce Merge "Make use of the modern ??= operator in one more place" 2024-11-20 20:19:15 +00:00
jenkins-bot 4be9db5ef3 Merge "ApiDiscussionToolsPageInfo: Show nice error for deleted revisions" 2024-11-20 19:56:42 +00:00
Ammarpad 6e17c85409 ApiDiscussionToolsPageInfo: Show nice error for deleted revisions
This is similar fix as b8a28d6cfc.

Bug: T380351
Change-Id: I1b03a00c5627e1fa9e48aee9e2ed3d8b1ea332f7
2024-11-20 19:40:34 +00:00
jenkins-bot 86d42c6ef9 Merge "Fix mistakes in inline @var comments" 2024-11-20 14:56:03 +00:00
Translation updater bot b6496ab427
Localisation updates from https://translatewiki.net.
Change-Id: I11d824eaf9f88762cfc93414afac9416568fb629
2024-11-20 08:25:44 +01:00
thiemowmde 3cc4e00647 Use faster DOMUtils::hasClass()
I tried to benchmark this. It's not really a big bottleneck in this
codebase, but can still be seen. For example, the relative runtime
of the method CommentUtils::isCommentSeparator (the heaviest user of
this feature) goes down from 1.5% to 0.3%.

Depends-On: If9252a97562542e7a4bec29edcc6e8dee0fb8221
Change-Id: I6b94a2481b5c4f7983df78ee48d45c0d8a50e53b
2024-11-20 08:16:31 +01:00
thiemowmde f59335d85a Make use of the modern ??= operator in one more place
Change-Id: I57c56547893536cd1ca4de567158eccdfff508f9
2024-11-20 08:13:29 +01:00
thiemowmde eb65077dd8 Fix mistakes in inline @var comments
Change-Id: Idca575d4a6dd69b30f3ccb6b4dccadb38721780d
2024-11-20 08:11:59 +01:00
Translation updater bot 7acd730719
Localisation updates from https://translatewiki.net.
Change-Id: I1407179640040ac389ba9afe7ecfe649559de5b3
2024-11-19 08:17:42 +01:00
jenkins-bot 5dec8076e2 Merge "commentparser: Allow signature of user '0' to be detected" 2024-11-18 18:54:48 +00:00
Translation updater bot 2eb8bae39b
Localisation updates from https://translatewiki.net.
Change-Id: I5190230ffb51952cdcacd10d75a061422ad02e2d
2024-11-18 08:23:41 +01:00
Ammarpad 84d0dfc51c commentparser: Allow signature of user '0' to be detected
Bug: T379918
Change-Id: I11a447c11fe64dae88a5035b007fe762a335e6c5
2024-11-15 19:02:43 +01:00
jenkins-bot 8211bc5000 Merge "Fix forwarding promise rejection arguments" 2024-11-15 11:05:07 +00:00
Translation updater bot e9784b8f40
Localisation updates from https://translatewiki.net.
Change-Id: I3f6455e9bc41ef080277812dd2f330ca760fbf8c
2024-11-15 08:44:47 +01:00
Bartosz Dziewoński d516f625c7 Fix forwarding promise rejection arguments
Follow-up to arrow functions refactoring
(a74c00ba8c).

This caused API errors to be handled by showing an error box that
always used the message "Invalid response from server." (generated by
mw.Api#getErrorMessage) instead of the actual error message.

Change-Id: I1c347202f2c2d0a141ba09e6ad136f5d5dc2dc65
2024-11-14 22:32:05 +01:00
Translation updater bot 8821264a5e
Localisation updates from https://translatewiki.net.
Change-Id: Ie0d2019de9eec3d092a8a7f37fe975627d0f03bc
2024-11-14 08:19:16 +01:00
Translation updater bot ce1463fd37
Localisation updates from https://translatewiki.net.
Change-Id: I2b7552fbad7a635da5cc4afaacdfbb83e57e45ae
2024-11-13 08:25:04 +01:00
Translation updater bot c17c50dcf3
Localisation updates from https://translatewiki.net.
Change-Id: Ie7de58ea7e00e8b8355379ff39cd5ad47c900b0f
2024-11-12 08:17:48 +01:00
Translation updater bot f1dcd74978
Localisation updates from https://translatewiki.net.
Change-Id: If45fd35ae7f3c1a7f2c1129106e8e2a58274991d
2024-11-11 08:22:32 +01:00
Umherirrender 126aafa8b8 build: Remove php version from composer.json
The required MediaWiki version in extension.json is 1.43 and does not
support php7.4,
remove the outdated version constraint from composer.json

Change-Id: Ia29e84f0662a07a9f95829be674ec13e97d5a6e5
2024-11-08 21:10:40 +01:00
Translation updater bot 4170b22181
Localisation updates from https://translatewiki.net.
Change-Id: Icedc1c5457f2a91a7dd903c801184926b13dabe4
2024-11-07 08:18:36 +01:00
Translation updater bot 5ea355d172
Localisation updates from https://translatewiki.net.
Change-Id: Ief577f5648bbc89cdd301629d04b9cd9ffb477f0
2024-11-06 08:22:16 +01:00
Translation updater bot 719052e831
Localisation updates from https://translatewiki.net.
Change-Id: Ieb8f89b53569b7def822fc4ed78377bc401a5762
2024-11-05 08:32:25 +01:00
jenkins-bot 98e1b4a34d Merge "Handle hidden revision in more places" 2024-11-04 22:58:30 +00:00
jenkins-bot 197affa825 Merge "Pass message parameters as variadic arguments" 2024-11-04 10:46:13 +00:00
Translation updater bot 16349ccd3c
Localisation updates from https://translatewiki.net.
Change-Id: I50e33fae3d17ed068ede6f63a81f08cf449df991
2024-11-04 08:21:29 +01:00
Ammarpad ad99faef19 Handle hidden revision in more places
Instead of checking section->exists() everywhere we have to call
getTruncatedSectionTitle(), override the method inside
PlaintextEchoPresentationModelSection class to make it always
return string for our case.

Call to getTruncatedSectionTitle() in the following classes now use
the method override:

* RemovedTopicPresentationModel
* SubscribedNewCommentPresentationModel
* AddedTopicPresentationModel

The call to getTruncatedSectionTitle() in CommentThanksPresentationModel
does not need nor use the override.

Bug: T378261
Change-Id: Ibe985da5c1a79c5a1853d9c4896f8769cce6ddfd
2024-11-02 22:15:34 +01:00
libraryupgrader f631ba47ad build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: If3efcd4428b5b5e75a0237ad640d9cf4f8c83c26
2024-11-02 06:55:33 +00:00
Translation updater bot 019c86b0f1
Localisation updates from https://translatewiki.net.
Change-Id: Id1500568c92d673d1b2b136ba8cd38a92c94935e
2024-11-01 08:35:30 +01:00
Bartosz Dziewoński 65951c19d2 Pass message parameters as variadic arguments
Soon to be deprecated in If2ebb6d17ffeacbd95f0ed147ae8f16f90578450

Change-Id: Iaaaa2bf745c2ddcfc6d6d3d15be5ce6f2968cfa8
2024-10-30 21:41:20 +01:00
Translation updater bot 4382b695f3
Localisation updates from https://translatewiki.net.
Change-Id: I1ad029c1b653bf613b17c7b1caa7c52100447147
2024-10-30 08:23:10 +01:00
jenkins-bot 784c28ff70 Merge "Show empty state message if subject doesn't exist but talk page exists" 2024-10-29 15:01:38 +00:00
Ed Sanders a85be7d7b5 Show empty state message if subject doesn't exist but talk page exists
If the subject page/user doesn't exist it usually makes sense
not to show the "Start a discussion about X" message, but when
the talk page itself exists but without any discussions
(e.g. after a Flow archiving), then we _should_ show message to
start a new discussion.

Bug: T378392
Change-Id: I20dab0089691ba7a429c9a50f23b9e3afe61aaaf
2024-10-29 09:54:26 +00:00
Translation updater bot 156fc95696
Localisation updates from https://translatewiki.net.
Change-Id: Ib7c92ddcb4d781381f725cc5e1a55b2dccf5f11e
2024-10-29 08:40:30 +01:00
Translation updater bot 397615186e
Localisation updates from https://translatewiki.net.
Change-Id: Ie989b132a6908028238e69f7f594fcb11c965e3a
2024-10-28 08:22:16 +01:00
jenkins-bot 53b6a17980 Merge "Notifications: Handle suppressed topic titles in notification" 2024-10-26 22:19:13 +00:00
Ammarpad 4a25a985ff Notifications: Handle suppressed topic titles in notification
EchoPresentationModelSection::getTruncatedSectionTitle() has a note that
it should not be called if ::exists() returned false. Among the reason
the section may not exist includes suppressing the revision where the
topic title was added or edited.

Add placeholder message text "(topic removed)", to be used in place of
the unavailable topic title. This is analogous to "(user removed)" which
would be shown along if the username is also suppressed.

Bug: T378261
Change-Id: I6db0872b8724323a5e15eb6a262c2c3d0bdd630d
2024-10-26 15:10:35 +01:00
Andre Klapper 3b67d12a46 Use explicit nullable type on parameter arguments (for PHP 8.4)
Implicitly marking parameter $... as nullable is deprecated in PHP
8.4. The explicit nullable type must be used instead.

Bug: T376276
Change-Id: I40b301271ea0ae5d9123b06841eb8d3e4f9fbf86
2024-10-26 14:59:53 +02:00
Umherirrender fef98c5ebe Use type-declaration on api module constructor
Parent class constructor gets type-declaration in 1145328459

Change-Id: I5ec4767b386317b777846edd88d800f80b3bb360
2024-10-25 19:14:20 +02:00
Translation updater bot e08ba7e8dc
Localisation updates from https://translatewiki.net.
Change-Id: I83d4d5cb49d3be509b6a8692fa86352cad572129
2024-10-25 09:47:45 +02:00
Translation updater bot ed132cc837
Localisation updates from https://translatewiki.net.
Change-Id: I5bd1b0597b852548de9c699b040af5935f32c7be
2024-10-22 09:30:14 +02:00