wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-23 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use explicit nullable type on parameter arguments (for PHP 8.4)

Browse source 
Implicitly marking parameter $... as nullable is deprecated in PHP
8.4. The explicit nullable type must be used instead.

Bug: T376276
Change-Id: I40b301271ea0ae5d9123b06841eb8d3e4f9fbf86
This commit is contained in:
Andre Klapper 2024-10-26 14:59:39 +02:00
parent fef98c5ebe
commit 3b67d12a46
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/CommentModifier.php
View file

@ -652,7 +652,7 @@ class CommentModifier {
* @param string|null $signature
*/
public static function addWikitextReply(
ContentCommentItem $comment, string $wikitext, string $signature = null
ContentCommentItem $comment, string $wikitext, ?string $signature = null
): void {
$doc = $comment->getRange()->endContainer->ownerDocument;
$container = static::prepareWikitextReply( $doc, $wikitext );
@ -670,7 +670,7 @@ class CommentModifier {
* @param string|null $signature
*/
public static function addHtmlReply(
ContentCommentItem $comment, string $html, string $signature = null
ContentCommentItem $comment, string $html, ?string $signature = null
): void {
$doc = $comment->getRange()->endContainer->ownerDocument;
$container = static::prepareHtmlReply( $doc, $html );