wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-29 08:13:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
4178 commits 13 branches 4 tags 132 MiB
Commit graph

4178 commits

This branch
This branch
All branches
Author SHA1 Message Date
Translation updater bot 3bfc0b2a2a Localisation updates from https://translatewiki.net. 
Change-Id: I2927d31711152829f61fa0e164b41fb3b106af5f
 2021-02-04 08:39:18 +01:00
Ed Sanders d05109b24d Truncate user generated part of IDs to 80 characters 
This ensures that IDs fit in a 255 character database field.

Bug: T273658
Change-Id: I3cfe4fce6a865b4343f0f01121cd696aa5f98b22
 2021-02-03 15:04:58 +00:00
Translation updater bot 6124c1acf7 Localisation updates from https://translatewiki.net. 
Change-Id: Ifb50676b19de745a0730915849d422c00a1ea245
 2021-02-03 08:39:04 +01:00
Bartosz Dziewoński 0f4db60e72 More test cases for comment wrappers (multiple siblings) 
For a moment I doubted if we handle this case correctly, but in fact
I didn't botch that code *this* badly.

Change-Id: I5a9d142e4bd97ac40aa388bb43b65ab1286e3f18
 2021-02-03 00:26:52 +01:00
Bartosz Dziewoński 1c3fada1fb Make CommentUtilsTest a proper unit test 
Documentation:
https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Two_types_of_tests

We can do this because the tested methods do not depend on any globals
or on MediaWiki being installed.

In addition to being the new hotness, MediaWikiUnitTestCase allows the
test classes that use it instead of MediaWikiTestCase to start up much
faster. In my testing, running this test case individually now takes
0.35s, compared to 1.1s before.

Try:
* With new code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/unit/CommentUtilsTest.php
* With old code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/CommentUtilsTest.php

Change-Id: I771b1f3d101a394ee869e42547d9ae7839397752
 2021-02-02 15:37:17 +01:00
jenkins-bot 3a33cf81a8 Merge "Update localisation messages and their documentation for new discussion tool" 2021-02-02 12:12:45 +00:00
jenkins-bot 63a5916e53 Merge "Update warning about missing topic title immediately" 2021-02-02 12:11:21 +00:00
Bartosz Dziewoński 75beba2c15 Update localisation messages and their documentation for new discussion tool 
Bug: T264220
Change-Id: I92f346f91cbd9bb7212d4c3389624e18fcb66255
 2021-02-02 12:07:23 +00:00
Translation updater bot 7f202af4dd Localisation updates from https://translatewiki.net. 
Change-Id: Ib615a44d65c0254d1a332f7d9b12f4f7ef60cb88
 2021-02-02 08:38:59 +01:00
Ed Sanders 6c3dd3aaa9 Move Hooks to HookUtils 
Now that all the real hooks have been separated out

Change-Id: Ibdb42f98614fc551068f8f8e5297dcc99251ab46
 2021-02-01 22:35:11 +00:00
Ed Sanders 2908c2808d Move Hooks::addReplyLinks to CommentFormatter 
Change-Id: I9f5483cd801f48efff22cba045ae6851da9719fd
 2021-02-01 22:35:04 +00:00
Ed Sanders bf51f1f65c Use new HookHandler system and group hooks by purpose 
Bug: T273303
Change-Id: I2d940e1944a9d7686bf7bc544a318c88c0b2afad
 2021-02-01 22:34:57 +00:00
jenkins-bot fb415e374d Merge "Update 'save_failure_type' map for EditAttemptStep schema" 2021-02-01 18:28:13 +00:00
Translation updater bot c31fea1bd3 Localisation updates from https://translatewiki.net. 
Change-Id: Ibe13425fbabf7daed46697f1d204a223ebfa6918
 2021-02-01 08:47:31 +01:00
Bartosz Dziewoński 069050ad12 Update warning about missing topic title immediately 
Since it's no longer tied to the "Reply" button, we can move the code
from ReplyWidget to NewTopicController, where it belongs.

Bug: T272543
Change-Id: I8c90ffb772573d22d26c608d45877ee948fd232d
 2021-01-29 23:14:45 +01:00
jenkins-bot 39e45f5b61 Merge "build: Updating dependencies" 2021-01-29 10:04:37 +00:00
libraryupgrader 095622bf4d build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.17.0 → 0.18.1

Additional changes:
* Added the "composer phan" command to conveniently run phan.

Change-Id: I271199abd055233f12f8a1c18ff414b06d1748ec
 2021-01-29 09:54:58 +00:00
Translation updater bot 7ac5d8038a Localisation updates from https://translatewiki.net. 
Change-Id: I909eb5059bffc36ade9ecd9b2aa24ef714545ddf
 2021-01-29 08:37:33 +01:00
Translation updater bot 9e8feded69 Localisation updates from https://translatewiki.net. 
Change-Id: I8fbd2fea9809f2c0dd74ea6946730832bbde1446
 2021-01-28 08:35:41 +01:00
Bartosz Dziewoński f21e6dfc7c New error message when the page doesn't exist 
The previous confusing error was coming from the getLatestRevision() call.

Bug: T273068
Change-Id: I5bb53c875bb08f6fb087875a6e55fb033d182056
 2021-01-27 16:41:03 +01:00
Translation updater bot 20a9836c73 Localisation updates from https://translatewiki.net. 
Change-Id: I51c139bfb963a790fb1a5eea35a5bd1189835285
 2021-01-27 08:34:11 +01:00
Ed Sanders 47aea0b160 Use tabs for indentation in JSON test files 
Change-Id: I1d8f8b33b19bcff249ad08dfe687f87f5e5bf9bf
 2021-01-27 00:25:15 +00:00
jenkins-bot 50f749d676 Merge "Handle category links at ends of comments affecting indentation" 2021-01-26 17:21:34 +00:00
jenkins-bot 373282dfb4 Merge "Don't show error message popups when failing to restore auto-save" 2021-01-26 17:21:32 +00:00
jenkins-bot 1c373b386b Merge "Improve error message used when no changes are saved" 2021-01-26 17:21:31 +00:00
jenkins-bot 2b648dad64 Merge "CommentController: Even better handle clicking links while already commenting" 2021-01-26 17:04:04 +00:00
jenkins-bot 76da6af031 Merge "Move some setup code from CommentController to controller.js" 2021-01-26 17:02:22 +00:00
jenkins-bot 5bbc6d519c Merge "Fix cookie loading hack" 2021-01-26 17:02:20 +00:00
jenkins-bot 1b83e64440 Merge "Fix check for null edits" 2021-01-26 16:58:51 +00:00
Translation updater bot c5e9b3cefb Localisation updates from https://translatewiki.net. 
Change-Id: I86eb898022f05479faadfe4bdb2e8ec123ef6305
 2021-01-26 08:53:04 +01:00
Bartosz Dziewoński c781b127c9 Handle category links at ends of comments affecting indentation 
* Ignore rendering-transparent nodes between discussion comments.
* Improve isRenderingTransparentNode() so that <link> nodes
  representing TemplateStyles are not considered transparent,
  otherwise this would undo ae920b831f.
  Using a regexp from Parsoid.

Bug: T272746
Change-Id: I0b3c3251156ba6c4826abf5ba44ea93f80ebc01d
 2021-01-26 04:55:03 +01:00
Bartosz Dziewoński 344038ae41 Don't show error message popups when failing to restore auto-save 
Several of the messages talk about clicking the reply links, which
seems unhelpful. Also, showing a fullscreen popup on page load seems
very unhelpful too. (Itoldyouso that we shouldn't use popups.)

Bug: T268069
Change-Id: Id1312cf06200fb45a28b39481a99cc2c96603fa4
 2021-01-26 03:03:19 +00:00
Bartosz Dziewoński fdd7994051 Improve error message used when no changes are saved 
Bug: T268069
Change-Id: Iad81755bddebaee09578d6b3ae134af9400931c1
 2021-01-26 02:48:14 +01:00
Bartosz Dziewoński ca9db69b40 Fix check for null edits 
Yet again, the CAPTCHA being neither an error nor a success bites us.

Bug: T272922
Change-Id: I5ef85df452638ad3208e7a1cadad44c83237dbfe
 2021-01-26 01:06:31 +01:00
Bartosz Dziewoński d354b34fa6 CommentController: Even better handle clicking links while already commenting 
If the user is clicking on a new topic link, and a reply widget is
open, attempt to close it instead of doing nothing.

Bug: T272545
Change-Id: I1903f5ae4c9e98c4b3a4703ad0e44d772894592a
 2021-01-25 23:42:15 +01:00
Bartosz Dziewoński 718457130e Move some setup code from CommentController to controller.js 
We'd like the [reply] links to behave differently if other
CommentControllers are already active, but each CommentController
doesn't know anything about others; only the main controller.js does.

Change-Id: Ic21b2d40d213a325509822f703709f52aa8dc8d7
 2021-01-25 23:33:58 +01:00
Bartosz Dziewoński 460283baa5 Add a link to the project page to the "New topic" change tag 
Bug: T272768
Change-Id: Ie363b9cb7137c6e8fe2ce8fc7d162e12e21b0a62
 2021-01-25 17:09:46 +01:00
Bartosz Dziewoński 60272fc348 Fix cookie loading hack 
If the module is loaded on a page where DiscussionTools is
not supposed to be enabled, wgDiscussionToolsFeaturesEnabled
will be undefined, and the code will crash before it can set
the cookie that enables it for future page views.

Bug: T272850
Change-Id: Ia1c40cfc3cbee62823f1806bd20229883905677a
 2021-01-25 15:17:20 +01:00
Translation updater bot 1455b08327 Localisation updates from https://translatewiki.net. 
Change-Id: I6ed7cc007e927e5cdd66412722ef14e2aca4e584
 2021-01-25 08:53:22 +01:00
Translation updater bot 9d8485da36 Localisation updates from https://translatewiki.net. 
Change-Id: Ib15dd632d4279bcc3a0c22cba98df2611760179b
 2021-01-22 08:30:28 +01:00
David Lynch 15c4052168 A/B test output when a specific feature is being tested 
Bug: T268191
Change-Id: Ib4fb59e4dc28aebc45854c293cb25bb3006267c3
 2021-01-21 15:46:05 -06:00
Translation updater bot bdece044c4 Localisation updates from https://translatewiki.net. 
Change-Id: Icbb20382c9269a94863d82f1268abcc1c241f703
 2021-01-21 08:31:40 +01:00
Translation updater bot 57a49e132f Localisation updates from https://translatewiki.net. 
Change-Id: I7acaab528d09b6773016d7ae82d5534d9d0137b9
 2021-01-20 08:26:40 +01:00
jenkins-bot 7bf858066f Merge "NewTopicController: Clear section title on teardown" 2021-01-20 00:31:07 +00:00
jenkins-bot e0fafcee3d Merge "CommentController: Better handle clicking links while already commenting" 2021-01-20 00:28:11 +00:00
Bartosz Dziewoński 2337600f38 NewTopicController: Clear section title on teardown 
Bug: T272393
Change-Id: I633adc17c18e50b921400ec2fcab57649da147dc
 2021-01-20 00:23:10 +00:00
jenkins-bot 1c9f038aac Merge "Padding and border around new topic tool" 2021-01-20 00:04:31 +00:00
jenkins-bot 8d999c5ebf Merge "Separate dialog for abandoning a new topic" 2021-01-20 00:04:29 +00:00
jenkins-bot 994abdac39 Merge "Store reply links in the parser cache" 2021-01-19 21:35:36 +00:00
Bartosz Dziewoński 37b574f165 Separate dialog for abandoning a new topic 
Bug: T269190
Change-Id: Ie4f486b0641edea369702631556d8ea31f991370
 2021-01-19 21:40:21 +01:00