wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-24 10:58:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix check for null edits

Browse source 
Yet again, the CAPTCHA being neither an error nor a success bites us.

Bug: T272922
Change-Id: I5ef85df452638ad3208e7a1cadad44c83237dbfe
This commit is contained in:
Bartosz Dziewoński 2021-01-26 00:02:15 +01:00
parent 460283baa5
commit ca9db69b40
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/ApiDiscussionToolsEdit.php
View file

@ -197,7 +197,7 @@ class ApiDiscussionToolsEdit extends ApiBase {
break;
}
if ( !isset( $result['newrevid'] ) ) {
if ( !isset( $result['newrevid'] ) && isset( $result['result'] ) && $result['result'] === 'success' ) {
// No new revision, so no changes were made to the page (null edit).
// Comment was not actually saved, so for this API, that's an error.
// This is probably because changes were inside a transclusion's HTML?