Commit graph

3522 commits

Author SHA1 Message Date
Translation updater bot 04101abb53 Localisation updates from https://translatewiki.net.
Change-Id: I4a3751dce58487f4a57f462d3cb4587508c96cb7
2022-10-04 08:29:36 +02:00
Ed Sanders 0e5f4460a7 Fix styling of heading input in new topic tool
We accidentally set some proposed mobile styles for desktop.

Change-Id: I3d7092137708196599ccf44fed948757b9aef276
2022-10-03 17:20:10 +02:00
Sam Smith 50853a3db6 EventDispatcher: Remove reference to $wgWMESchemaEditAttemptStepOversample
At the time of writing, $wgWMESchemaEditAttemptStepOversample is not a
global variable in PHP [0].

[0] https://codesearch.wmcloud.org/search/?q=WMESchemaEditAttemptStepOversample

Bug: T312016
Change-Id: I6a8abceddc9fce2f28f7a154fa2fc566538ed5e8
2022-10-03 12:05:23 +01:00
Sam Smith 2f6305b7b5 logger: Also log VisualEditorFeatureUsage events via Metrics Platform
The VisualEditorFeatureUsage instrument is a candidate for migration to
the Metrics Platform [0]. The first step of the migration is to log
events both using the Event Platform directly (i.e. via
mw.eventLog.submit()) and using the Metrics Platform client (i.e. via
mw.eventLog.dispatch()).

The Metrics Platform Client can mix in additional information -
so-called context attributes [1] - based on the stream configuration.
The majority of the default values mixed into each event via the
mw.eventLog.Schema defaults mechanism are already known to the Metrics
Platform Client.

Note well that the Metrics Platform client will not log an event without
one or more streams being configured to receive that event. Therefore,
this change is a NOP.

An example stream configuration is given in [2].

[0] https://wikitech.wikimedia.org/wiki/Metrics_Platform
[1] https://gerrit.wikimedia.org/g/mediawiki/libs/metrics-platform/+/aed6738b845/js/src/StreamConfig.d.ts#31
[2] https://phabricator.wikimedia.org/T309602#7973206

Bug: T309602
Change-Id: Ib919ae0e3f404c85cef17637ea91bb95d5030cf1
2022-10-03 12:02:23 +01:00
Sam Smith b90a2675b0 logger: Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable
... for the sampling rate for the VisualEditorFeatureUse schema.

Bug: T312016
Depends-On: I259757db0c4441a3fcfce505d5bc82dcf2acf58c
Change-Id: I1c7f9c06384549deac2787f5df93c0078b6402af
2022-10-03 11:46:43 +01:00
Translation updater bot e57016414e Localisation updates from https://translatewiki.net.
Change-Id: I8e2bb9b646431fb5db67cea2414711390c96f3ad
2022-10-03 09:45:36 +02:00
Bartosz Dziewoński 8ad26730f2 CommentFormatter: Always add the overflow menu
Bug: T318110
Change-Id: I49900e32dc6b5dbca3286a840ce122639e25e9bd
2022-10-02 15:36:45 +02:00
Bartosz Dziewoński 5f32c90225 Fire wikipage.content hook on edit notices
Bug: T319133
Change-Id: I36efb9326a9bf0efc5ef646d49361b314fdd0b5a
2022-10-02 11:38:33 +02:00
Bartosz Dziewoński 8d727dc26d Fix reply link/button margins on RTL wikis
Follow-up to c232df01a4.

Change-Id: Ie8c463108d2e0cb172d270d6205677459adbb86a
2022-10-01 21:52:32 +02:00
jenkins-bot b4ff3c9f83 Merge "maintenance: Use standard doMaintenance boilerplate" 2022-09-30 17:29:06 +00:00
Bartosz Dziewoński 3fa61ab6cd Rewrite persistRevisionThreadItems
* Fix estimate when using --current
* Add waitForReplication() after batches
* Add an option to restart from a specific point
* Remove TableCleanup, which doesn't work well for these use cases
* Use index on page_id when processing current revisions only

Bug: T315510
Change-Id: Idf9759743e67b3e116d6e20234b603bd76d4a41f
2022-09-30 18:07:39 +02:00
Timo Tijhof 86d47438d3 maintenance: Use standard doMaintenance boilerplate
Consistent with core, most WMF extensions, and boilerplate as
documented in extensions/README and elsewhere; as per T316722.

Change-Id: I02cfcb2bd3debf877d1cbf8654dff4a98dd354ad
2022-09-30 18:01:57 +02:00
Ed Sanders c2594914f9 Don't re-color :visited links that act as buttons
Bug: T319019
Change-Id: I26820229820768390827e79ec09c86eeed424531
2022-09-30 13:40:26 +01:00
Translation updater bot 68b6a3db3d Localisation updates from https://translatewiki.net.
Change-Id: I89ffd6b0f7d820744f794c285d1ec0f36aa2e524
2022-09-30 08:53:35 +02:00
Bartosz Dziewoński 482a2c6dd0 ThreadItemStore: Move some work in insertThreadItems() outside transactions
As suggested in the discussion on T315353.

Bug: T317236
Bug: T317237
Change-Id: I8d9f2e3d4779a2e2f433a8fffea2767ae986bc48
2022-09-29 21:34:15 +02:00
Ed Sanders f9d8b7afd5 Reduce padding around reply button slightly to improve vertical alignment
Change-Id: Ia420f1d6bf1038bfe803c62aba636f046d74bb29
2022-09-29 14:42:11 +01:00
jenkins-bot 0bf1b9e6a1 Merge "Add config to separate out visualenhancements on mobile" 2022-09-29 10:57:27 +00:00
jenkins-bot 0510c84175 Merge "Fix double <div class="mw-parser-output"> after saving" 2022-09-29 07:40:55 +00:00
Translation updater bot 34cab2db62 Localisation updates from https://translatewiki.net.
Change-Id: I3eda1b2bc04a8e4a45c088993739884bdd62647b
2022-09-29 08:27:14 +02:00
Bartosz Dziewoński 4d1722d1e6 Fix double <div class="mw-parser-output"> after saving
Follow-up to d00fa80ff4. .html()
replaces the inner HTML, .replaceWith() replaces the outer HTML.

Change-Id: I8da2d24d439acc5e83ef1f42959fefef27bbea71
2022-09-29 01:26:33 +02:00
David Lynch d5161bf086 Add config to separate out visualenhancements on mobile
Follow-up to d0126ce6de which made them
default-on for all mobile. These two taken together mean that the
mobile visual enhancement features now *only* depend on this config,
rather than on whether the individual features are enabled on desktop.

Bug: T318871
Change-Id: If767753e6d33f19bbc540d4e74273e478198388c
2022-09-28 17:12:48 -05:00
jenkins-bot f910e54802 Merge "Empty state banner: Improve selector for hiding top border" 2022-09-28 16:30:45 +00:00
Ed Sanders 79d4879b3a Empty state banner: Improve selector for hiding top border
Pages can be empty (blanked) without outputting the noarticletext
class, so just suppress the top border if the banner is the first
child of the document.

Change-Id: I808160a7f73a9a976d25e77f4bd47727a57b70c0
2022-09-28 17:04:42 +01:00
jenkins-bot f4f83bfb2f Merge "Show mf-section-0 in preview" 2022-09-28 15:45:29 +00:00
jenkins-bot 8a2e02e8e1 Merge "Suppress top border when section follows <h1>" 2022-09-28 15:40:07 +00:00
jenkins-bot 3436684b2c Merge "Only hold on to a Config instead of ConfigFactory when injecting" 2022-09-28 14:22:46 +00:00
jenkins-bot d0126ce6de Merge "Visual enhancement features are now part of the mobile set" 2022-09-28 14:16:02 +00:00
Ed Sanders df96154538 Show mf-section-0 in preview
Bug: T318758
Change-Id: I12039696bfe0f06e21b28ed32fdfc23442033805
2022-09-28 14:38:20 +01:00
Translation updater bot 56725cb098 Localisation updates from https://translatewiki.net.
Change-Id: Iee45ac860d96e71d0382196c47cb15bc1a1a90ca
2022-09-28 08:21:13 +02:00
jenkins-bot 99c772d4ee Merge "Add mw.track call when comment setup fails" 2022-09-27 22:32:08 +00:00
David Lynch 3a42623fef Visual enhancement features are now part of the mobile set
Bug: T318302
Change-Id: I494e4dd6d2133d110499420ffc57f45a29999748
2022-09-27 16:09:05 -05:00
jenkins-bot 5a5ad9f8df Merge "Always scroll "Loading..." text into view" 2022-09-27 19:16:23 +00:00
jenkins-bot 5d92f638f3 Merge "Move "Return to comment" below sticky header when present" 2022-09-27 19:16:20 +00:00
jenkins-bot adc3344f5f Merge "Fix TODO about ParsoidClient::getPageHtml() params" 2022-09-27 10:43:00 +00:00
Translation updater bot 7654f86129 Localisation updates from https://translatewiki.net.
Change-Id: I248cc9f89609664219874c56728a6b4a4a4631ba
2022-09-27 08:32:04 +02:00
Bartosz Dziewoński 0a5cded42c Fix TODO about ParsoidClient::getPageHtml() params
Depends-On: Id9a450dc8b8eb3e82cf87718b96975e5a3c6180c
Change-Id: I35ce516187fb8dcde24bc35278378496f471e211
2022-09-26 22:50:07 +02:00
Translation updater bot 9ca9bd1355 Localisation updates from https://translatewiki.net.
Change-Id: I75fff58586f1dbb28faa22b57d2c0454a458def7
2022-09-26 08:15:04 +02:00
Ed Sanders f6df39c11a Always scroll "Loading..." text into view
If the widget has just been opened, it should already be in view,
but when we are recovering from auto-save it might not be.

Scrolling it into view lets the user know sooner that a draft is
about to be recovered.

Change-Id: I2b8232edc20e71b04a3f106107c0c7bc6333f66a
2022-09-25 13:28:14 +01:00
Ed Sanders 688cdc24ae Move "Return to comment" below sticky header when present
Also ensure that when we click the button, we scroll the widget fully
into view below the sticky header.

Bug: T318474
Change-Id: I394f02912cd6ab2773552a7364691ef89a17369c
2022-09-25 13:28:12 +01:00
jenkins-bot fb7a25ce91 Merge "PreferenceHooks: Avoid referring to the field of disabled feature" 2022-09-24 23:30:44 +00:00
jenkins-bot 63acbf4dfc Merge "Add Korean special page aliases" 2022-09-24 23:26:00 +00:00
Translation updater bot 5f94a9bf00 Localisation updates from https://translatewiki.net.
Change-Id: I1667584f86a919a1f7a25e8c9e6a95983cd12466
2022-09-23 08:29:00 +02:00
jenkins-bot 43f95c18c3 Merge "Tweak topic container margins on desktop" 2022-09-22 15:32:34 +00:00
Translation updater bot 74305d71ed Localisation updates from https://translatewiki.net.
Change-Id: Iacfcb8b6929589488f40d6c136f86f648314375b
2022-09-22 08:45:57 +02:00
Ed Sanders a9488a9ead Suppress top border when section follows <h1>
Bug: T318198
Change-Id: I550dd240fe629d0159448ea49d49195de0166a25
2022-09-21 21:39:40 +01:00
Translation updater bot f22e68ff86 Localisation updates from https://translatewiki.net.
Change-Id: If151368b3b904ffde201c2545bb2919dd10f346b
2022-09-21 08:28:42 +02:00
jenkins-bot 169b4c74ad Merge "ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names" 2022-09-20 16:46:51 +00:00
na1307 1c1d7b3c5d
Add Korean special page aliases
Change-Id: I87c827d6f113b7d8d46eb60a6cd65ad6c679587c
2022-09-20 17:01:54 +09:00
Translation updater bot 855eef1c2a Localisation updates from https://translatewiki.net.
Change-Id: I23ddaa79e5f7982a6008bea4d234730841a7504f
2022-09-20 08:33:56 +02:00
David Lynch 9ee2301f1e ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names
Computing the name, for headings, requires determining the oldest
comment. This must not be done before all the replies are added to the
thread.

Follow-up to e24550fae9. It was
already *technically* incorrect before then because it was generating
the name based on the first comment in the thread, but that was only
not the oldest in very unusual cases so it was fine. That commit caused
the thread summary to be cached when first requested, however, which
made future requests for oldest/newest comment and authors to be
incorrect.

Bug: T318057
Change-Id: If0bd6caf88e72cd3f91e7f0633c40b445f5e2246
2022-09-19 14:13:51 -05:00