wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-28 16:00:28 +00:00
Code Issues Packages Projects Releases Wiki Activity
4712 commits 11 branches 20 tags 106 MiB
Commit graph

4712 commits

This branch
This branch
All branches
Author SHA1 Message Date
Daimona Eaytoy 9144f20245 Restore check for dividebyzero 
Follow-up of I1721a3ba532d481e3ecf35f51099c1438b6b73b2. This is the only
wrong replacement: strict checking will let 5 / 0.0 pass, with
unexpected results. Adding a regression test for it, too.

Change-Id: I25dbe9fafa92fd9a11bd8bc6ab8e66f305b8d48e
 2019-03-23 11:38:39 +01:00
jenkins-bot 77a0fd6c0d Merge "Replace double-equals with triple-equals" 2019-03-23 07:56:37 +00:00
jenkins-bot 6a8f45300e Merge "Rely on parent::getTableClass in TablePager" 2019-03-23 07:56:34 +00:00
Holger Knust 324d0e6aa3 AbuseFilter: Swapped getNative for getText 
Use getText method in AbuseFilter.php instead of deprecated getNativeData method.

Bug:  T155582
Change-Id: Ia1af3abea8331e2292d608215946834b282ed753
 2019-03-22 17:48:19 -04:00
Daimona Eaytoy f2c1beec44 Replace double-equals with triple-equals 
Since double-equals are evil. I left some of them in place where I
wasn't sure, but I may be changed some which were intended to be
doubles. It could be a good idea to delay merging this patch until we'll
have more code coverage.

Change-Id: I1721a3ba532d481e3ecf35f51099c1438b6b73b2
 2019-03-22 16:12:13 +01:00
Daimona Eaytoy 037b0c375d Rely on parent::getTableClass in TablePager 
Or it will fail if the parent class changes (like it did).

Bug: T218996
Change-Id: I601bac181790e6466fe0b9d8c5d8572dab5a3177
 2019-03-22 15:52:21 +01:00
jenkins-bot 44d602b9a9 Merge "Use lowercase for built-in variables" 2019-03-22 10:44:24 +00:00
jenkins-bot c8021a520a Merge "Move the throttle help tooltip to a message" 2019-03-22 10:35:02 +00:00
jenkins-bot 85b16f1ecd Merge "Change method used for file_bits_per_channel in /test" 2019-03-22 10:34:11 +00:00
Daimona Eaytoy 45e84bad0e Change method used for file_bits_per_channel in /test 
Using MWProps will not raise an 'undefined index' notice and, if the
bitsdepth cannot be established, will return 0. This is way better than
returning the empty string or null, which cannot be treated as integers.

Bug: T218874
Change-Id: I2b585f3a2f257783c15f0fcdd2851f1e1ce4256b
 2019-03-21 14:05:54 +01:00
Daimona Eaytoy 4103ff56af Use 'page' prefix for upload vars 
Rationale on phabricator.

Bug: T218873
Change-Id: I33128098c186ab716951c72e0d917663721b4740
 2019-03-21 13:29:43 +01:00
Translation updater bot edc35ede96 Localisation updates from https://translatewiki.net. 
Change-Id: Ife27683216c2675979f5af60005f7866f2e813a6
 2019-03-20 22:26:35 +01:00
Translation updater bot 4f2b1b00fc Localisation updates from https://translatewiki.net. 
Change-Id: I4fe3d1a41be910bd7be65a58428e17bf8e2c7023
 2019-03-19 22:16:45 +01:00
Translation updater bot 48ed625aa3 Localisation updates from https://translatewiki.net. 
Change-Id: Ice4ced756ff653f2061a0c88a357dbd390da349c
 2019-03-18 23:06:56 +01:00
Daimona Eaytoy 553facee1e Move the throttle help tooltip to a message 
Follow-up of I982d67aa62a899916a26452aceb9646df8c31232. The help text
was meant to be localized, and I probably forgot to do so in the
mentioned patch.

Change-Id: If394b02819911f9c97519b5c972977c38e6d83fa
 2019-03-18 17:38:45 +01:00
Translation updater bot 0837f8ec28 Localisation updates from https://translatewiki.net. 
Change-Id: I22f2865c9f6357d2c4fc30e58385daac5c15f092
 2019-03-17 22:13:44 +01:00
Daimona Eaytoy c79ec2f65e Don't fill the "Filter ID" field with 0 
Follow-up of If4fd015dff64237375a0c4d3b9fbcefbd54dba3e.

Change-Id: I4a68d413dd4897fb12ab92ed0407773a5df23c7d
 2019-03-17 15:49:45 +01:00
Daimona Eaytoy bae9c5bb8f Use lowercase for built-in variables 
The uppercase is just a leftover from a long time ago. Currently,
variables are case-insensitive, and we already perform a strtolower when
saving them. Since most parts of the code already use lowercase, the
uppercase leftovers only make it harder to grep the code to find
variables. As a bonus, make Ace recognize variables in a
case-insensitive fashion.

Change-Id: I72933fcc9952fc1aabf6464b2fc0b04ec39c024b
 2019-03-17 14:23:11 +01:00
jenkins-bot ef8c8e6006 Merge "Make the filter field on ViewHistory of "int" type" 2019-03-17 12:00:47 +00:00
jenkins-bot dc0c5cc5ac Merge "Make uploads testable" 2019-03-17 11:06:43 +00:00
jenkins-bot 8588c35142 Merge "Simplify AbuseFilterVariableHolder::dumpAllVars" 2019-03-17 11:04:53 +00:00
jenkins-bot f63b7e8039 Merge "Remove the hacky 'context' variable" 2019-03-17 10:35:31 +00:00
Daimona Eaytoy 3211c71739 Make uploads testable 
This patch adds missing methods for testing a filter against uploads in
RC. Please note that (as discussed below) using wfFindFile could be
relatively expensive (as it will be executed for 0-100 RC rows).
If this is true, then we should either use another method (but I
couldn't find a suitable one), or simply reduce the amount of testable
uploads to a reasonable limit.

Bug: T170249
Change-Id: Id406d4e1571873f49bb11e69029311b24ececf49
 2019-03-17 11:32:56 +01:00
jenkins-bot de4e971c72 Merge "Remove usage of MakeGlobalVariablesScript hook" 2019-03-17 10:32:30 +00:00
jenkins-bot 4c63c9190c Merge "Remove deprecated DB method" 2019-03-17 10:08:50 +00:00
jenkins-bot 3f3e98fbc5 Merge "Fix shortcircuit for consecutive operations" 2019-03-17 10:04:14 +00:00
jenkins-bot 001a83272d Merge "Add help links for throttle groups" 2019-03-17 09:59:25 +00:00
jenkins-bot e2f1880922 Merge "Don't use wgLang and wgContLang" 2019-03-17 09:53:16 +00:00
jenkins-bot b4780723e4 Merge "Fix faulty query in normalizeThrottleParameters" 2019-03-17 09:50:39 +00:00
jenkins-bot d11f30f7ec Merge "Make text fields use readonly instead of disabled" 2019-03-17 09:49:40 +00:00
jenkins-bot 65a4c26804 Merge "Remove exclusions for Generic.Files.LineLength" 2019-03-17 09:49:38 +00:00
jenkins-bot 92fdb2ce90 Merge "Make Special:AbuseFilter sortable by filter name" 2019-03-17 09:48:29 +00:00
Daimona Eaytoy 7449b43c2f Remove deprecated DB method 
Database::nextSequenceValue is deprecated and just returns null.

Change-Id: I8109e90ab836b5915873da26da87ea9225e2ff03
 2019-03-17 09:38:46 +00:00
Kunal Mehta 577f4dab93 Migrate to new phan 
Bug: T216904
Change-Id: I30864bd3d7f9b9ab674bf6589cd9e5e3aed5bb8d
 2019-03-16 09:41:23 +00:00
Daimona Eaytoy 53ab2b5067 Fix documentation errors reported by Phan 
Change-Id: I5788147ba1998235ded9eedbf64ebad37fce236f
 2019-03-16 09:27:05 +00:00
Translation updater bot 768af21c10 Localisation updates from https://translatewiki.net. 
Change-Id: Ia2d9b679777db7846e12a13aa0864b8a8290abc8
 2019-03-15 22:35:44 +01:00
Translation updater bot 68bf88f062 Localisation updates from https://translatewiki.net. 
Change-Id: I4e3f8c8a5d67939032895963e083bba331801d2b
 2019-03-14 22:51:39 +01:00
Translation updater bot 217ad90792 Localisation updates from https://translatewiki.net. 
Change-Id: I727caf44e961b6d2bcff47e41be5dca40e0603be
 2019-03-13 22:16:05 +01:00
Translation updater bot c280cdc8c4 Localisation updates from https://translatewiki.net. 
Change-Id: I5488d3cc8de49b03048706177d890ea5722a4d67
 2019-03-12 22:29:12 +01:00
jenkins-bot fc00915d7d Merge "Don't escape externalLink text" 2019-03-12 06:00:47 +00:00
Translation updater bot 53920f3b0c Localisation updates from https://translatewiki.net. 
Change-Id: I0c49e687e580da20ba47eb55ccdcdf27b78cd066
 2019-03-11 22:16:23 +01:00
Daimona Eaytoy 6158d96c41 Don't escape externalLink text 
As escaping is handled by makeExternalLink itself. This currently makes
seccheck fail for any patch and is a merge blocker.

Change-Id: I2d21632bbc59abd4ea48aebdb6572d53f8fc89cd
 2019-03-11 13:23:49 +01:00
Translation updater bot 8f3fb5b7e1 Localisation updates from https://translatewiki.net. 
Change-Id: I5db09a0e9580ec883f02beb4cb89b8a2fdb93587
 2019-03-10 22:27:15 +01:00
Translation updater bot 04b5e91c27 Localisation updates from https://translatewiki.net. 
Change-Id: I3f973d70f5c0b252b4efba1745fe8c73845c3a5f
 2019-03-08 22:28:51 +01:00
Translation updater bot 9cb4c7f4e8 Localisation updates from https://translatewiki.net. 
Change-Id: I4d8d19e842cc0602688eb95e3541fb6ad6f2c9c7
 2019-03-05 22:42:32 +01:00
Translation updater bot 1858638897 Localisation updates from https://translatewiki.net. 
Change-Id: Ia4e0e347b2abec9e72cd5e7d3c7a431f015e4426
 2019-03-04 22:15:54 +01:00
Translation updater bot a0d5a63167 Localisation updates from https://translatewiki.net. 
Change-Id: Id301b3c91c412b45f03eaa2ddb92e521f905acbe
 2019-03-03 22:17:08 +01:00
Daimona Eaytoy ef025c0ce2 Make Special:AbuseFilter sortable by filter name 
Only if the user is privileged, though, otherwise ID and name may be
associated.

Bug: T217520
Change-Id: Ida8886308be97de70078664f5f4641b93deab95f
 2019-03-03 19:07:38 +01:00
Umherirrender da682f78ac Use ::class for class name resolution 
Available since php5.5

Change-Id: Ie60465484858867d507081dfe5a305c6ab0599de
 2019-03-03 01:41:40 +01:00
Translation updater bot c8236499e8 Localisation updates from https://translatewiki.net. 
Change-Id: I9991a6b1b1e1a4e1dd5eb32ac5201c7a3197c18f
 2019-03-02 22:42:12 +01:00