wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-24 06:03:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Restore check for dividebyzero

Browse source 
Follow-up of I1721a3ba532d481e3ecf35f51099c1438b6b73b2. This is the only
wrong replacement: strict checking will let 5 / 0.0 pass, with
unexpected results. Adding a regression test for it, too.

Change-Id: I25dbe9fafa92fd9a11bd8bc6ab8e66f305b8d48e
This commit is contained in:
Daimona Eaytoy 2019-03-23 11:36:34 +01:00
parent 77a0fd6c0d
commit 9144f20245
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/parser/AFPData.php
View file

@ -346,7 +346,7 @@ class AFPData {
$a = $a->toNumber();
$b = $b->toNumber();
if ( $op !== '*' && $b === 0 ) {
if ( $op !== '*' && (float)$b === 0.0 ) {
throw new AFPUserVisibleException( 'dividebyzero', $pos, [ $a ] );
}

1
tests/phpunit/AFPDataTest.php
View file

@ -117,6 +117,7 @@ class AFPDataTest extends MediaWikiTestCase {
public function divideByZero() {
return [
[ '1/0', 'mulRel' ],
[ '1/0.0', 'mulRel' ],
];
}
}