Commit graph

9069 commits

Author SHA1 Message Date
Roan Kattouw e68dd9c7c1 Bump command help dialog height again
Change-Id: I348ce317b46f040bc8a2d70e4392ce0dfe24611c
2014-12-10 16:24:14 -08:00
Cmcmahon 122099fda8 [BrowserTest] issues with Chrome at SauceLabs causes test to fail
This is one of several VE tests that do not work well with older
versions of Chrome

Change-Id: Id7afc51689557d9e86e67a07dc840a8e6ca8303e
2014-12-10 15:00:05 -07:00
Moriel Schottlender e0894b807f Surfaces should have parent document direction
Make sure all surface widgets have documents that are initialized
with the direction of the parent document, so the alignment is set up
correctly.

Bug: T71969
Change-Id: I6e5f003e18a9c5808d9a4b148eddf0d0f7e29e67
2014-12-10 16:46:16 -05:00
Translation updater bot 70e8633c05 Localisation updates from https://translatewiki.net.
Change-Id: I3c4f3b3115aa8daa8b7fb3c4c800b4907e6fd564
2014-12-10 22:11:36 +01:00
James D. Forrester 8f30eddee2 Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression>
Bug: T78180
Change-Id: I50d65d2c4f9458788c3fd5a09fd65d4c2f5780fc
2014-12-10 10:51:18 -08:00
jenkins-bot f51cc6f2ea Merge "ve.ui.MWParameter*: Use the destructive flag for all four remove buttons" 2014-12-10 02:04:33 +00:00
Roan Kattouw a032ea039e Move from legacy TimingData schema to new statsd API
This API doesn't have the ability to track any other data
in addition to a name and a duration in milliseconds, so
we add the target name ('mwTarget' or 'mobile') to the
event name and discard all other data.

Change-Id: I25ae0243f8983142d7755b65b05c18d5df36a253
2014-12-10 00:25:42 +00:00
James D. Forrester 8078f61657 Update VE core submodule to master (b6423de)
New changes:
3672954 Follow-up Ifa89a85e: Use '0' not '0px'
0cc0830 Normalize split text nodes correctly
c921dab Localisation updates from https://translatewiki.net.
3d1029b Trim whitespace when annotating

Change-Id: Ia5837dfb93b4eef76c32415462222bcfcfa6df3a
2014-12-09 16:22:23 -08:00
jenkins-bot 54b938e629 Merge "Fix duplicate wikitext parse for displaytitle" 2014-12-09 22:54:37 +00:00
Tim Starling 4c50307cd5 Fix duplicate wikitext parse for displaytitle
Instead of doing a whole new parse for displaytitle, just get it from
the same API action=parse internal request that is used for returning
the content HTML.

Also escape entities as in OutputPage::setPageTitle(). The format of
OutputPage::setPageTitle()/getPageTitle() is a bit confused -- it's
mostly treated as HTML, but Article::view() sets it to the unescaped
title text -- a historical error which was unfortunately wallpapered
over.

Change-Id: I387c1ccd9a75f9c6c6a006d83235c6c1c3d1ecb5
2014-12-10 09:50:59 +11:00
jenkins-bot ed22cbffea Merge "Prefer localStorage to store ve-beta-welcome-dialog" 2014-12-09 22:39:09 +00:00
James D. Forrester eac5aabeb3 ve.ui.MWParameter*: Use the destructive flag for all four remove buttons
Previously we were only doing it for one of the four.

Bug: T78033
Change-Id: Ib0091052a5c858dfd37b8755b6e3b84406b7c745
2014-12-09 14:28:40 -08:00
Alex Monk 51b091b9cd Prefer localStorage to store ve-beta-welcome-dialog
Bug: 62884
Change-Id: I3fe45e890c29aaa8d28edfb6986dc8c7541861c7
2014-12-09 21:04:13 +00:00
Translation updater bot 2edf5a7104 Localisation updates from https://translatewiki.net.
Change-Id: Ifc36f5299dfc91692e2357cb4ba2c2909477e658
2014-12-09 21:59:30 +01:00
jenkins-bot d318c5cded Merge "Restore papaparse" 2014-12-09 19:02:06 +00:00
Roan Kattouw 29995d806b Remove IEHacks.css in favor of .ve-init-target-ie class
Move reference style hack to MWReferenceNode.css, and move
heading style hack to ve.init.mw.Target.css

Change-Id: Icbd53f8df998c9f7bcc701b7c29dc226dfc5c05f
2014-12-08 15:45:23 -08:00
Roan Kattouw 3321261e98 Split up ve.init.mw.ViewPageTarget.css
* Move styles that apply to all targets to ve.init.mw.Target.css
* Move styles for MWPopupTool subclasses to ve.ui.MWPopupTool.css

Change-Id: I34c8a6200ee337debf00c4e432948f1b86f1b60a
2014-12-08 15:42:19 -08:00
jenkins-bot d250252732 Merge "Update VE core submodule to master (805e9aa)" 2014-12-08 23:11:16 +00:00
jenkins-bot 09bfc0cb9c Merge "Followup 1c04d32d: release saveDialog reference even if closed" 2014-12-08 23:06:37 +00:00
Roan Kattouw dad06ef495 Followup 1c04d32d: release saveDialog reference even if closed
It's good that we're not trying to close the save dialog
if it's not open, but we still need to release our reference
to it in that case, otherwise trying to open the save dialog
in a new incarnation of the editor will fail.

If you opened VE, opened the save dialog, closed it,
went back to read mode, opened VE again, and tried to open the
save dialog again, it would fail because it tried to open
the cached reference to the previous editor's save dialog.

Bonus: prevent JS errors in this case by only attaching an
onClose handler if the dialog actually opened successfully.
If opening the dialog failed, the callback parameter isn't
a promise but an OO.ui.Error, and calling .always() causes
a JS error.

Change-Id: I62d6d3e7cd3df2c29a0c99e2e23bf1aac5187a12
2014-12-08 14:49:39 -08:00
James D. Forrester 889d3fb042 Update VE core submodule to master (805e9aa)
New changes:
c027917 Regular expression find and replace
50ca51f Fix the src attribute for non-debug chimeras
0f0ae08 ve.ce.TestRunner: Fix copypasta in JS documentation
c3a26f8 Localisation updates from https://translatewiki.net.
c477adf Track state properly at the end of an event loop

Change-Id: I4e38607d82b57063d05c0a275b0a15b0147bca6c
2014-12-08 14:44:36 -08:00
Translation updater bot 4c3a6e55ee Localisation updates from https://translatewiki.net.
Change-Id: I771f43da908ad0d352ff74c622dea4cbcbd2bb42
2014-12-08 23:24:37 +01:00
jenkins-bot ba6a55f121 Merge "Update VE core submodule to master (af4b395)" 2014-12-08 18:25:47 +00:00
Cmcmahon 978308ee1f [BrowserTest] update Cite tests
Seems that a set of invisible textareas have appeared

Change-Id: I2ee81c782220c632393d2bbdc66ca66a5c8bf667
2014-12-08 10:43:35 -07:00
James D. Forrester a8af5fd470 Update VE core submodule to master (af4b395)
New changes:
9145f1a Use String#slice instead of discouraged String#substr
a3b7fe4 bin: Update update-unicodejs.sh to parity with update-oojs.sh
d475ba6 Localisation updates from https://translatewiki.net.
af4b395 Localisation updates from https://translatewiki.net.

Change-Id: Ie2615f54c4aa48aaab39229e6169953f721620dc
2014-12-08 08:34:49 -08:00
Translation updater bot 381c0bd5a0 Localisation updates from https://translatewiki.net.
Change-Id: I1ba254f3d7e22a6264703f65f7fa0f78b0a22ef9
2014-12-07 21:57:36 +01:00
Ed Sanders faffa85859 Restore papaparse
This was already fixed in core and just needed a pull through.

Change-Id: Icfe21ad97fedbb62e694c58ad7b0df02363e14c2
2014-12-06 21:54:29 +00:00
jenkins-bot 9d1b8fdded Merge "Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths" 2014-12-06 21:41:13 +00:00
Timo Tijhof ee954cbdd5 Use String#slice instead of discouraged String#substr
Aside from the confusion and differences between substr() and
substring() and IE8 bugs with substr(), substr() was removed from
the spec as of ECMAScript 5. It's been standardised in the
optional Annex B section of ES5.

Change-Id: I221ef6ae6956ce20dd9bb74510500f747d04c3b1
2014-12-06 21:26:20 +00:00
James D. Forrester baffe9d7e1 Update VE core submodule to master (32397d8)
New changes:
5e60f12 Ensure clipboard key is removed from paste target
32397d8 Update OOjs UI to v0.4.0

Local changes to compensate for new OOUI version, and updated wfUseMW call.

Change-Id: I005f7b23a36e04f1305d4aa037c19a5c7db9a699
2014-12-06 12:28:07 -08:00
Alex Monk fc6eaf6825 Don't re-enable apply changes in reference dialog if the changes have been undone
Per Roan on Ib5229bdc

Bug: T57976
Change-Id: I0450ab59ea8aa2e3130eb9124de74e67ffc0497f
2014-12-05 23:50:57 +00:00
jenkins-bot 7a0e11ed0c Merge "Disable Apply Changes in reference dialog until changes have been made" 2014-12-05 22:46:26 +00:00
Alex Monk a7b9b89479 Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths
Use model HTMLDocument when parsing transclusion nodes and their link hrefs

As well as mobile, this also covers the issue I found in /w/index.php?veaction=edit

See also T76374

Bug: T76379
Change-Id: I07c9ba0adbcee32f7eb2ca280d3a1d46e963d28f
2014-12-05 22:23:09 +00:00
James D. Forrester 3619e4c0a4 Update VE core submodule to master (d52749b)
New changes:
c6e298f Localisation updates from https://translatewiki.net.
c5f083a Update IE detection to include Edge
aa026f0 Localisation updates from https://translatewiki.net.
543c929 Ignore enter key when no results.
8be322b Fix find and replace highlights in RTL
144c9ac ve.ce.Surface: Remove use of deprecated OO.ui.Element#onDOMEvent and #offDOMEvent
3ae9ba9 Update UnicodeJS to v0.1.2
b173384 navigator.appVersion -> navigator.userAgent
e9991c9 Papaparse update per https://github.com/edg2s/PapaParse/pull/2
461176e Localisation updates from https://translatewiki.net.

Change-Id: I7a3fed99a2559efe071ed515cb0b0d4ae627d05e
2014-12-05 14:18:59 -08:00
Translation updater bot a9e939649e Localisation updates from https://translatewiki.net.
Change-Id: I7dc624ec5d93b6ee5be968cd5d744e81f2e0dab9
2014-12-05 23:16:32 +01:00
Bartosz Dziewoński d39dfaa837 MWCategoryInputWidget: Don't explode on invalid titles
canonicalQueryValue can be null at this point, so let's not insert it
into an array that contains strings.

Bug: T76868
Change-Id: I8096a9c1017e883d28124bf807d2d375ae98452a
2014-12-05 21:07:57 +01:00
Alex Monk b0b53befdc Fix call to mw.log.warning
Should be mw.log.warn

Added by I111176b8

Change-Id: I58b78e89a7f5a21fe050e2a90bf856c388f7213d
2014-12-03 23:35:51 +00:00
Translation updater bot fd8f9463aa Localisation updates from https://translatewiki.net.
Change-Id: I9bcf93cd047e84c80a50d0ef34b7474bcdb6486f
2014-12-03 22:30:16 +01:00
Roan Kattouw bbb9712b7e Followup e722c172: it's MobileWindowManager.js, not MobileInspectorWindowManager.js
Bug: T76660
Change-Id: Ic71bf45dfc1932dea6d9194fa5b2ec265cc7335d
2014-12-03 20:53:39 +00:00
Roan Kattouw fdcc46939a Update VE core submodule to master (e76e259)
New changes:
f033911 Only run showSelection if one of the command successfully executed
381aee1 Remove ve.instances
df0f7e5 Rerender ContentBranchNodes when the selection anchor leaves
27d7517 Check the selection is in the correct surface
40101e4 Use a chimera instead of &#xFEFF; in inline slugs

Change-Id: I6af416ccc99c42e0595f0a52dbb348c710ea7e73
2014-12-03 12:25:52 -08:00
James D. Forrester e722c1726f Update VE core submodule to master (0229301)
New changes:
5eb7294 Find and replace
123a6ad Find and replace tool
557f70f Go backwards through find and replace results on shift enter
4a4ed81 Allow language widget to filter on available languages

Local changes to adjust.

Change-Id: I15e14d6d3c7ee60e465baf3a4df7572851cbca3e
2014-12-03 10:36:39 -08:00
jenkins-bot f0913180ac Merge "Clean up deactivate mess" 2014-12-03 03:08:42 +00:00
James D. Forrester 74b83c627f Update VE core submodule to master (4743d59)
New changes:
82b7ecf Localisation updates from https://translatewiki.net.
a142762 Use unicorn client rect for adjacent collapsed selection
3ee5955 Add getDescription method to selections
d4be8ea Show entire expandable call tree in ve.ui.Filibuster
4743d59 Update OOjs UI to v0.2.4

Change-Id: Ic4ce5d8aff5a8b90cd541069cf22546940dd4b53
2014-12-02 18:27:17 -08:00
Roan Kattouw dbf232a7dc Clean up deactivate mess
Both onDocumentKeyDown and onViewTabClick would check
this.activating and invoke deactivate() differently depending
on its value. That's ugly, so incorporate the "don't show a dialog
if deactivating during activation" logic into deactivate() itself.

Rename the override parameter to noDialog, and fix the broken
logic around it (it overrode too much).

Also move setting this.activating = false; out of these event
handlers into cancel(), where it clearly belongs because
activatingDeferred is being rejected there.

Change-Id: I6c040c74d36f829128a175f00d4e712dd19d31a7
2014-12-02 16:50:36 -08:00
jenkins-bot 45e98c7699 Merge "Cancel VE when escape key pressed" 2014-12-03 00:33:19 +00:00
Alex Monk c0fd5e616d Cancel VE when escape key pressed
Or at least open the confirmation dialog about it.

Relies on I0047bd9d to not break stuff on the second try.

Bug: T52868
Change-Id: Id178a2a0aad2f4bf5f589d66efde61aaa6fae498
2014-12-02 16:29:15 -08:00
jenkins-bot 77b507dfc7 Merge "[Browsertest]Tests for options under Advanced Settings panel" 2014-12-02 23:03:37 +00:00
ryasmeen@wikimedia.org 416d62df4f [Browsertest]Tests for options under Advanced Settings panel
Change-Id: I21765e9e3d7a004d24dd620dd0da35978632d02a
2014-12-02 15:00:33 -08:00
jenkins-bot d7f954b1b5 Merge "Make LinkCache fail more gracefully when given undefined" 2014-12-02 22:45:08 +00:00
jenkins-bot 63e09d4659 Merge "Handle encoding of links in transclusion nodes properly when determining existence" 2014-12-02 22:22:15 +00:00