Commit graph

9069 commits

Author SHA1 Message Date
Cmcmahon c34fd60a9b [BrowserTest] update general markup test
refactor for new locator

Change-Id: I089aebb64a9d67d01c1bfa4682927c0de2575051
2014-12-17 09:31:24 -07:00
Cmcmahon 30c3aa2242 [BrowserTest] update Links test
another iframe gone it seems

Change-Id: I33767706675bbdcd1cb45f33da109858ec36986e
2014-12-17 08:51:17 -07:00
jenkins-bot 4de775b4d4 Merge "[BrowserTest]Fixing options test Fixed the unique selector for failing cases Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915" 2014-12-17 15:09:22 +00:00
ryasmeen@wikimedia.org 5eff6e8aa1 [BrowserTest]Fixing options test
Fixed the unique selector for failing cases
Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915
2014-12-16 17:36:50 -08:00
Alex Monk 3007270645 Pre-populate LinkCache for page we're editing
Bug: T78642
Change-Id: I2293903f9e131f3ea8c31302f86a138208ae57e3
2014-12-17 01:07:57 +00:00
jenkins-bot 9b3d3080ce Merge "Remove use of bind() for inline functions" 2014-12-17 00:13:22 +00:00
jenkins-bot 226ef54602 Merge "Update VE core submodule to master (fc3c1b4)" 2014-12-17 00:10:30 +00:00
jenkins-bot b4bf8a11ca Merge "Update VE core submodule to master (fe2d908)" 2014-12-17 00:08:48 +00:00
James D. Forrester 818526f313 Update VE core submodule to master (fc3c1b4)
New changes:
4166f91 Refactor debug bar dump methods and add hide button
1568e52 Record whitespace on generated empty paragraphs correctly
2253934 Fix whitespace consistency checking when child has no whitespace property
29b249f Improve support for multiple surfaces in demo

Change-Id: Ic496da654130a356530d6028a5fe4230d6c0c735
2014-12-16 15:49:15 -08:00
Roan Kattouw 08bebc9b2b VE-MW fix commit for I4efbae614e
Local changes:
* Call bindHandlers()/unbindHandlers() in activate/deactivate
* Extend onDocumentKeyDown rather than overwriting it

Change-Id: I0739e71781c5140c54512ab421bdcb6d1df5fbbe
2014-12-16 15:42:27 -08:00
Timo Tijhof 2b7ae8c175 Remove use of bind() for inline functions
Follows-up b0e8900, 447e8de, d3f26e65.

Contrary to binding a reference, this-overiddes for inline
functions gets messy and fragile. There's also a minor
performance overhead that can be avoided. No separation of
concerns, eiter, as the object is held by the closure.

Also:
* Remove left-over instances of @method.
* Remove redundant '0' argument to setTimeout.
* Use null instead of $ for apply() on static methods like $.when.
* Use .empty().append() instead of .html(). Does the same but
  without additional overhead and without confusion association
  with "html" which isn't used (it doesn't serialise and re-parse
  or clone, it just appends when given one or more nodes).

Change-Id: I797a3667c67d52568150be9be5d043d149f22077
2014-12-16 23:27:53 +00:00
jenkins-bot 6ca0046599 Merge "[BrowserTest] changing the css paths for Cite options for fixing the tests" 2014-12-16 22:36:50 +00:00
ryasmeen@wikimedia.org aa77e8ab4f [BrowserTest] changing the css paths for Cite options for fixing the tests
Change-Id: Iea90e4bb656b30ec0839e6c843e30ba8ae1fd637
2014-12-16 15:33:37 -07:00
Bartosz Dziewoński 08654b4f60 Update VE core submodule to master (fe2d908)
New changes:
fd433fa Add getter for toolbarDialogs in ve.ui.Surface
00c3eb7 Add 'done' button to find and replace dialog
3642dc8 Localisation updates from https://translatewiki.net.
fe2d908 Update OOjs UI to v0.6.0

Local changes to ve.ui.MWFormatTool.css for OOjs UI breaking change.

Change-Id: I6bf98ea988b3e1deb4824189ef8e6d59387b6ffc
2014-12-16 13:27:43 -08:00
jenkins-bot 6532213ca4 Merge "Update VE core submodule to master (cb46d98)" 2014-12-16 21:24:36 +00:00
jenkins-bot ae8f07810d Merge "[BrowserTest] Adding tests for checking fields under Page Settings" 2014-12-16 21:14:28 +00:00
Translation updater bot a34a9c84b6 Localisation updates from https://translatewiki.net.
Change-Id: Ia0d711b180f8c463792416953365a6f71188f52c
2014-12-16 21:59:09 +01:00
jenkins-bot d71492731d Merge "Set 's' accesskey on save button inside save dialog" 2014-12-16 18:57:56 +00:00
James D. Forrester 6dbde76275 Update VE core submodule to master (cb46d98)
New changes:
2c86408 Localisation updates from https://translatewiki.net.
fb5a8ab Localisation updates from https://translatewiki.net.
ad2265f SpecialCharacterInspector: Don't auto-capitalise the headings
dde5faf Localisation updates from https://translatewiki.net.
2b4bfa2 Calculate unicorn offsets correctly

Change-Id: I75bb759e621ae42aeb0d81dabb7eab18594fedc0
2014-12-16 10:21:16 -08:00
jenkins-bot 0de05ea219 Merge "Edit/view source tab: Do not hijack middle click to display confirmation, only left click" 2014-12-16 07:57:26 +00:00
ryasmeen@wikimedia.org a8807c6af4 [BrowserTest] Adding tests for checking fields under Page Settings
Change-Id: I31d8d3327bd8abe6a7c5f3c4941174253104bbac
2014-12-15 21:37:42 +00:00
Translation updater bot 8133ef4aa8 Localisation updates from https://translatewiki.net.
Change-Id: Id6a2c0136078d95c537ef63e3d5d02d2b0fe581a
2014-12-15 22:20:53 +01:00
Alex Monk 0d0172d43b Set 's' accesskey on save button inside save dialog
Can be done much nicer than I expected last time I looked at this task

Bug: T76161
Change-Id: I9541cd9dac69330ed8a802f301617619221bc263
2014-12-15 21:07:54 +00:00
Alex Monk f9339d070b Edit/view source tab: Do not hijack middle click to display confirmation, only left click
Middle click is supposed to open the link in a new tab.

Bug: T78546
Change-Id: I594f1dff072d54c0a8d7112a1eaa0c1c84d0ffc1
2014-12-15 20:24:11 +00:00
Translation updater bot 706413c211 Localisation updates from https://translatewiki.net.
Change-Id: Iff486cf59d6adef1cc9ccc4c5ce4c8e4f85e53aa
2014-12-14 22:25:34 +01:00
Translation updater bot 44514b947e Localisation updates from https://translatewiki.net.
Change-Id: I3422f33ebcd78c2a40c93d93684768b84f5dbd5e
2014-12-13 22:39:50 +01:00
jenkins-bot ad2f16c81e Merge "Update VE core submodule to master (6103755)" 2014-12-13 00:53:01 +00:00
jenkins-bot e6997350ba Merge "Check for stopped propagation before showing close dialog" 2014-12-13 00:52:57 +00:00
James D. Forrester a5b2399008 Update VE core submodule to master (6103755)
New changes:
cd56662 Move ve.init.Target#destroy to a place where it actually ends up existing
91347cb Factor out event handler binding in ve.init.Target
489cd55 Death to isolation
4597c9a Stop propagation of events after handling trigger keys
ea35d23 Non-DOM-modifying selection
6103755 Fix demo CSS hack broken by OOUI change

Change-Id: I087f2fa6a46742f39e7f25ffe5432465ab328182
2014-12-12 16:34:36 -08:00
Ed Sanders 9459e4e240 Check for stopped propagation before showing close dialog
Various VE elements use escape to perform tasks. Particularly
difficult are OOUI dialogs which listen to the document and thus
fire after this target's listener, so defer and check if the
event was previously stopped.

Bug: T78201
Change-Id: Ie335f199766923833588202626c3af8e4cbcb9b5
2014-12-12 22:38:40 +00:00
James D. Forrester 20c53d53bf Follow-up I64f5e2f6c: Bump wfUseMW version given breaking OOjs UI dependency
Change-Id: I2fddaab73d0c10286276de994c791af2cbb27595
2014-12-12 14:12:48 -08:00
Bartosz Dziewoński 29ff7b737e Rename some things for my sanity
Change-Id: I101943fa027947e73f7f7559bd706faadad90e95
2014-12-12 20:49:00 +00:00
Bartosz Dziewoński 16e8255f69 Update VE core submodule to master (b5e2b87)
New changes:
96d0936 Mark primary buttons as progressive as well
68f184c Localisation updates from https://translatewiki.net.
b96c9dc [BREAKING CHANGE] Rename method cmpOffsetPaths to compareOffsetPaths
862f31d Convenience compareDocumentOrder method
b5e2b87 Update OOjs UI to v0.5.0

Local fixes to correct for breaking change I32608c7f in OOjs UI.

Change-Id: I64f5e2f6ccc0056bfa9eda5e65e87789b97b8ad5
2014-12-12 12:29:05 -08:00
Translation updater bot a423784963 Merge "Localisation updates from https://translatewiki.net." 2014-12-11 22:59:37 +00:00
jenkins-bot 87143d4c36 Merge "Mark primary buttons as progressive as well" 2014-12-11 22:59:04 +00:00
Translation updater bot a76f1eff93 Localisation updates from https://translatewiki.net.
Change-Id: I5061faa84a867f5ff99a871aab597280d048ab38
2014-12-11 23:57:57 +01:00
James D. Forrester 57a68d082b Mark primary buttons as progressive as well
Also make save button primary.

In anticipation of Iee91d2c6 in OOjs UI

Change-Id: I123044bfaba631866ad32a35643f23686a17a16f
2014-12-11 22:55:16 +00:00
jenkins-bot fcdae1deba Merge "Fix image alignment in media dialog search" 2014-12-11 22:25:46 +00:00
Moriel Schottlender fbb6cd92b4 Fix image alignment in media dialog search
Make the image results align to the full width of the dialog. This
fix uses dynamic values of the width of the container rather than
a hard-coded value so it should work properly on all themes.

Bug: T78050
Change-Id: I05bb0d8a8b13c246840382b12e098d0579180016
2014-12-11 17:15:25 -05:00
Ed Sanders 45518019eb Update VE core submodule to master (9ac8136)
New changes:
9929b6d [BREAKING CHANGE] Make ve.init.target an OO.ui.Element

Local changes:
* Fix target constructors now they generate this.$element

Change-Id: Ia6bf604c67305834a3f73863a10336cfbb83fa77
2014-12-11 14:00:28 -08:00
James D. Forrester 0a86323d48 build: Suppress the 'unique-headings' warning from CSSLint
Change-Id: I3421cb7438f6187ae62a5bdcea3e4a5cdf251126
2014-12-11 13:35:14 -08:00
James D. Forrester 722ecddf0b Update VE core submodule to master (17c36e7)
New changes:
17c36e7 Followup cf1e167: unbreak SurfaceWidget

Change-Id: I59ae42b2053106e2a49b67501536a74c6b4bd698
2014-12-11 13:32:56 -08:00
Ed Sanders d6067d5718 Update VE core submodule to master (cf1e167)
New changes:
776e801 Delimit text nodes in debug observations
72643bc Remove debug bar hiding now it is handled by the surface
cf1e167 [BREAKING CHANGE] Multiple surface support and demo

Local changes:
Account for detachable toolbars in core being setup in a different order.

Change-Id: I29156948711d55ba5f6dd4f6c35ca0e4cca32373
2014-12-11 12:49:29 -08:00
jenkins-bot 5a3c81db4f Merge "Surfaces should have parent document direction" 2014-12-11 19:04:13 +00:00
jenkins-bot eacb364ed1 Merge "Add timing data for the first transaction" 2014-12-11 03:06:14 +00:00
Roan Kattouw 49b26f886e Add timing data for the first transaction
This doesn't quite tell us about the user's first interaction with
VE (if they open a dialog, for instance, it could be minutes before
that results in a transaction), but it's a good start.

Bug: T76524
Change-Id: I6bac987332802d7363ed65a471b2b1ece67086d8
2014-12-11 03:02:11 +00:00
James D. Forrester 603248a9c5 Update VE core submodule to master (26f44bc)
New changes:
26f44bc Refactor out trigger listening to allow target and document triggers

Local change to register the file for TriggerListener from VE core,

Change-Id: I16316b71d67b872358a8d7b685a33ce3dc066614
2014-12-10 18:16:29 -08:00
jenkins-bot 1aa30e0864 Merge "Update VE core submodule to master (3feadb2)" 2014-12-11 00:45:48 +00:00
jenkins-bot edf1ed3dbc Merge "Bump command help dialog height again" 2014-12-11 00:45:06 +00:00
Ed Sanders 34a82928c1 Update VE core submodule to master (3feadb2)
New changes:
fc4af20 Fix filibuster expansion bug
3feadb2 [BREAKING CHANGE] Refactor for multiple surfaces

Local changes:
* Use target.getSurface now that targets can have multiple surfaces
* Remove debug bar code now surfaces manage their own
* Remove import rules code now implemented in base target

Change-Id: I18d6f9f2f36431959d31347b4c1952a1aca1350e
2014-12-10 16:39:10 -08:00