Commit graph

9069 commits

Author SHA1 Message Date
Alex Monk 378ab667e9 Follow normalisation response from category status query
To do things like strip off invalid invisible characters from the end of names.
(see bug)

Also rename that function because it covers more than just hidden status now

Bug: T74080
Change-Id: I8374695a991c4d3e397992ad9277b99d9288eec4
2014-11-25 23:35:43 +00:00
James D. Forrester caa47cb4d5 Point wikitext markup link in warning to MW.org
Bug: T69273
Change-Id: Ie9e7307909c18eabaa0e294ac7a1e9c3a3f3f4d1
2014-11-25 15:05:27 -08:00
Ed Sanders 9ce13e70ac Register '<p># ' sequence for creating numbered lists
Replaces wikitext warning sequence.

Change-Id: I438654212284d4a022b11bd59ea2f8bc52f0d737
2014-11-25 22:40:05 +00:00
Ed Sanders 5ce4885529 Replace hacky wikitext warning listener with sequences
Uses the generic sequence detection now available in core instead
of a custom hack that had to been manually bound and unbound to
every surface and surface widget.

As the sequence detection looks at just-typed characters the behaviour
has reverted to showing a auto-hide message. This resolves an issue
with the previous system whereby typing in the same paragraph as existing
wikitext patterns triggered the warning.

Depends on I6a4d71d in core.

Bug: T53751
Change-Id: I7d914b1b60a1cf8c79a724e5f634e1e666c9562d
2014-11-25 22:39:29 +00:00
Roan Kattouw a367d4e074 Update VE core submodule to master (3270e6c)
New changes:
959e54e Always return boolean from an action
2f37cb5 Fix demo width now that OOUI sets max height
1bfe220 Rename variables in surface#execute for clarity
5f15b95 Reduce height hack on command help dialog
15a3a46 Update inexplicably old version of PapaParse library
31cd078 Localisation updates from https://translatewiki.net.
7709239 Create ve.ui.Sequence which matches commands to typed text

Change-Id: I604902f4a9b9aa116492e840ad42c5a4a2b63157
2014-11-25 14:30:21 -08:00
jenkins-bot 941be49f18 Merge "Disable papaparse because it breaks everything" 2014-11-25 22:02:05 +00:00
Roan Kattouw 0b66c2cddb Disable papaparse because it breaks everything
Bug: T75896
Change-Id: I7450734602eb32588f310c8f76d55fdb2f58f4fa
2014-11-25 13:49:48 -08:00
Translation updater bot 2fdf3b5d20 Localisation updates from https://translatewiki.net.
Change-Id: I34f9ba7b451e526c44ee0fdbd52e5f737c0f54b5
2014-11-25 21:52:07 +01:00
jenkins-bot 69fe06a7ae Merge "Check wgRelevantArticleId to determine relevant page existence even on special pages" 2014-11-25 19:44:02 +00:00
jenkins-bot a7dc4af551 Merge "Catch pagedeleted errors and give the ability to re-create the page" 2014-11-25 19:42:58 +00:00
jenkins-bot 0130b6b45c Merge "Create ve.ui.MWCommandHelpDialog.css for height hack" 2014-11-25 19:42:43 +00:00
jenkins-bot 9fd9730549 Merge "Fix rounded corners issue on help button by destroying notices" 2014-11-25 19:42:39 +00:00
Ed Sanders fa34e91da8 Create ve.ui.MWCommandHelpDialog.css for height hack
Height differs to core due to extra commands.

Change-Id: I8162ff4db86ceeac0ca92d165b185a418f9e4fc7
2014-11-25 19:19:16 +00:00
Ed Sanders 0ab28904e6 Fix rounded corners issue on help button by destroying notices
Empty this.$element in notices when there are no elements to display
as just hiding with CSS makes other items in the group no the last
child and therefore breaks any CSS rounded corners rules.

As notices are only ever generated at load, destroying the tool
is not a problem.

Bug: T63575
Change-Id: I63a044ca63f61b976f57e34ce9537034e68a2614
2014-11-25 17:12:40 +00:00
Ed Sanders 80bbc0980d VisualEditor.php: Add missing files for ProgressDialog
Change-Id: Iefa58756c23940e0ed878bb157204115eb889f21
2014-11-25 16:36:03 +00:00
jenkins-bot f3d772a709 Merge "Only try to close save dialog before destroying surface if it's currently open" 2014-11-25 03:12:03 +00:00
James D. Forrester 21fa3f2e8e Update VE core submodule to master (aad2986)
New changes:
66c6516 Filter out comments from external paste
4bde889 build: Fix script paths to be /bin/.. not /bin/../.. which isn't a thing
0bcfdbf Update OOjs UI to v0.2.2

Change-Id: Ia4222ae10b8ff4496faa0327270b24009333f939
2014-11-24 19:00:37 -08:00
Ed Sanders f79aed7572 Update VE core submodule to master (8ca8c41)
Local changes:
* Rename paste rules to import rules (also used by drag and drop)

New changes:
f5d83f8 Remove data-parsoid removal hack
99f938f Create 'preserveGenerated' mode for cloneElements and use in copy
938b44d [BREAKING CHANGE] Rename paste rules to import rules
c51288c ve.ce.Surface: Move insert HTML path to DM
10ce4cf Provide a FileDropHandler for HTML files
701bb9c Provide a FileDropHandler for CSV and TSV files
ca6b444 build: Update update-oojs.sh and update-oojs-ui.sh scripts

Change-Id: I5cfa15ab3efd03e2c64c2f9f725cb3098f53b32a
2014-11-24 18:55:32 -08:00
jenkins-bot eb0a486ec7 Merge "Update VE core submodule to master (2d8aeef)" 2014-11-25 02:19:20 +00:00
Roan Kattouw 28638e6e44 Update VE core submodule to master (2d8aeef)
New changes:
24d7427 Handle empty rowspan/colspan attributes correctly
b8d17ba Delete src/ui/widgets/ve.ui.ContextWidget.js
0b9ad5b Tweak some ContextSelectWidget code after item→option update
c814765 Pass through excludeInsertions in get(Linear)Fragment
ebec520 Make debug bar controls narrower
b918adb Improve logging
4272ad3 Localisation updates from https://translatewiki.net.
166a52b [BREAKING CHANGE] Change command list from whitelist to blacklist
6a77571 Move getText from dm.Document to ElementLinearData
7084ae2 Emit ce.Surface#position after dm.Surface#documentUpdate
cb9eaf0 Localisation updates from https://translatewiki.net.
a014246 Refactor SurfaceObserver pollOnceInternal
d8ba262 Removing padding override from LanguageResultWidget

Change-Id: Iee383f21a1e7f2cd4506202947b6e1198251c48b
2014-11-24 18:14:52 -08:00
jenkins-bot 5861db05b0 Merge "Filter out comments from external paste" 2014-11-25 02:07:24 +00:00
jenkins-bot 17fd82b99a Merge "Fix MW skin hacks" 2014-11-25 00:47:32 +00:00
jenkins-bot 330a1732cb Merge "Change command list from whitelist to blacklist" 2014-11-25 00:42:48 +00:00
jenkins-bot 35cbae3d76 Merge "Fix the "you are now logged in/out" warning" 2014-11-25 00:19:14 +00:00
Translation updater bot 7bdbd77304 Localisation updates from https://translatewiki.net.
Change-Id: Ibcd694dba6997715bdcdc4948b8a52ef9d019dee
2014-11-24 22:05:24 +01:00
Ed Sanders c56a921585 Change command list from whitelist to blacklist
Also remove toolbar definitions as they can now be derived from
command availability.

Depends on If32d514a in core.

Change-Id: I2313f3cc2531686b27f96dc1110b28bb4b295f89
2014-11-24 18:28:37 +00:00
Ed Sanders 325bd0994e Filter out comments from external paste
Bug: T71821
Change-Id: I165efd75adf3d4092860c6d2bc408469dba31388
2014-11-24 11:20:18 +00:00
Alex Monk 1c04d32d75 Only try to close save dialog before destroying surface if it's currently open
Otherwise the closure promise will be rejected as it was already closed with
different data, if you ever opened and closed the save dialog before pressing
the 'Read' button. This means the code in the $.when will never be run, and
the surface never destroyed.

Bug: T75589
Change-Id: I3ffdd1c82506bcd2accc0f3fa113c0950a31918e
2014-11-23 22:30:40 +00:00
Translation updater bot 07a265c3a1 Localisation updates from https://translatewiki.net.
Change-Id: Ib4cb30426f2e42f56da8efa725f9a81259703ea3
2014-11-23 22:43:42 +01:00
jenkins-bot 6b11f8d05e Merge "Always return boolean from an action" 2014-11-23 21:21:58 +00:00
jenkins-bot b69fef2196 Merge "Focus the bookletLayout on ready in the template dialog" 2014-11-23 17:19:11 +00:00
Ed Sanders 2ee4fc0b36 Always return boolean from an action
Command#execute expects this so it knows if the action was
successful.

Change-Id: Iaef1b7d217f0a6cd848b8df4a920c6546a79f503
2014-11-23 17:19:10 +00:00
Translation updater bot a4986e0ee2 Localisation updates from https://translatewiki.net.
Change-Id: If3ccefe94168c271b5bb812a7367e2322cf5bc96
2014-11-22 22:44:08 +01:00
Ed Sanders 2653ce3bb3 Fix MW skin hacks
* Ensure surface widget font size matches main surface,
  move vector-specific hack to vector css file and fix.
* Fix base font size in non-isolated monobook windows.
* Move monobook z-index hack to global overlay only.

Change-Id: I1607dc77f81ac9c522e09a3b502aeb38fee02178
2014-11-22 17:52:46 +00:00
jenkins-bot 268a852455 Merge "Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook" 2014-11-22 02:29:01 +00:00
Roan Kattouw 9b3316a360 Fix the "you are now logged in/out" warning
It would tell you you were logged out when you were actually
logged in, and when I looked into it, I found lots of broken
things, including lots of confusion between the current
anon-ness and username and the new anon-ness and username.

ve.init.mw.Target:
* Check the new isAnon value, not the old one
* Pass the username to the event, rather than just anon-ness

ve.init.mw.ViewPageTarget:
* Use the passed username (new username) rather than the
  username from mw.config (which is updated, but confusing)

Change-Id: Icf406d49100d81e87c677fd6b57ff93cc29f601f
2014-11-21 18:23:11 -08:00
Roan Kattouw 0bc3edfd91 Focus the bookletLayout on ready in the template dialog
Depends on I60377cb5 in oojs-ui

Change-Id: I5d8b73f878bf136efdc97493ef1f6e7bd6f56066
2014-11-21 18:13:27 -08:00
Bartosz Dziewoński e2d4f5b533 [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget
Change-Id: I70f44e71819e9147886bd70baf3460daf9ebbaf2
2014-11-22 01:56:29 +00:00
James D. Forrester a8b4fc4966 Update VE core submodule to master (c8201dd)
New changes:
ff237d4 Fix z-indexes in core
e88d43e Localisation updates from https://translatewiki.net.
cf61803 Consistently use ve.ui.WindowManager everywhere
f9dfdb8 Update OOjs UI to v0.1.0-pre (23565e7519)
f79f7e3 Update OOjs UI to v0.1.0-pre (8f8896196f)
c8201dd Update OOjs UI to v0.1.0-pre (9ed4cf2557)

Local changes for the breaking change to OptionWidget and sub-classes.

Change-Id: Ife6abd312d4dc97be67cb84eea4cb9c6a0a31b1d
2014-11-21 17:41:04 -08:00
jenkins-bot 0ed86dd9da Merge "Add instrumentation for edit schema" 2014-11-22 00:26:31 +00:00
jenkins-bot adb186e454 Merge "OO.ui.WindowManager -> ve.ui.WindowManager" 2014-11-21 22:12:59 +00:00
Roan Kattouw 4cf254a31b OO.ui.WindowManager -> ve.ui.WindowManager
In keeping with Id6660a4b54 in VE core.

Change-Id: I6fa6c0cdc3e514a66889e41c2eb4c710650a3405
2014-11-21 13:58:53 -08:00
Alex Monk 9bb766c5bb Catch pagedeleted errors and give the ability to re-create the page
Bug: 52073
Change-Id: I86a6e1510ccb5e59e94a5262dd3ccd91fdf05a70
2014-11-21 21:44:15 +00:00
James D. Forrester 6f446e0d1a Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook
In I19da270a we bumped the z-index for the overlay from 4 down to 2, to avoid
clashing with the toolbar. However, the site logo, search box and personal
tools all have a z-index of 3, so 4 is required. Instead, bump the toolbar's
z-index up by 1 to 5.

Change-Id: I7e1edcf05cde054c7bcb8c13b5633930fb5ed3b5
2014-11-21 13:29:16 -08:00
Cmcmahon 34f3572372 [BrowserTest] love for test that targets test2wiki
Change-Id: Ie37d88e891b592745e8f430da4481f2f1d2bd530
2014-11-21 21:28:25 +00:00
Cmcmahon f7a7a89d00 [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome
No combination of WebDriver for any version of Chrome on Linux
works 100% correctly.

Remove the failing tests for now.

Change-Id: I46be2c2c857e93234c839d32f1c0d4224733d0f7
2014-11-21 21:26:20 +00:00
Translation updater bot bc031a78ba Localisation updates from https://translatewiki.net.
Change-Id: I2cd1e9f2abf494d61a1a2011e7a271c0dd937f97
2014-11-21 22:12:28 +01:00
jenkins-bot 7416393354 Merge "[BrowserTest] consolidate some duplicate elements" 2014-11-21 20:30:28 +00:00
Cmcmahon 2449ebde99 [BrowserTest] consolidate some duplicate elements
and remove one unused

Change-Id: Ica50cf74edd9a21423800a7d58f4832b77a7e8bc
2014-11-21 13:28:01 -07:00
Roan Kattouw 6d21d83244 Add instrumentation for edit schema
Move ve.track() subscriber to its own file, and have it
route mwtiming.* events (for TimingData) and mwedit.* events
(for Edit schema) differently. Most of the data population
lives in the subscriber, so actual ve.track() calls are
pretty lightweight.

Existing ve.track() calls with timing data were kept with
their names intact for backwards compatibility, but
we may eventually want to throw them out and start from scratch.

ve.init.mw.ViewPageTarget.init.js:
* Remove old track subscriber
* Track init and ready events
* Remove old ve.track( 'Edit', ... ) crap that didn't work

ve.init.mw.ViewPageTarget.js:
* Fire the saveWorkflowBegin event before the save dialog
  loads rather than after
* Remove unnecessary this.events.trackSaveError() calls:
  TargetEvents already listens to these events itself
* Remove badtoken handler because all it was was an
  unnecessary trackSaveError() call
* Add abort tracking
** Pass trackMechanism through deactivate() and cancel()

ve.init.mw.Target.js:
* Add static.integrationType to populate the 'integration'
  field in the schema

ve.init.mw.TargetEvents.js:
* Simplify onSaveError* methods away into connect bindings
* Map track topics to mwtiming.* so they can be routed separately
* Track save-related mwedit.* events

Depends on I978eda96c in WikimediaEvents

Change-Id: Iae677d9b15c71d2b18e795bd5179d11876c06abd
2014-11-21 11:59:15 -08:00