wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 18:39:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
12983 commits 161 branches 1 tag 190 MiB
Commit graph

5806 commits

Author SHA1 Message Date
David Lynch 05e2a3119e ArticleTarget: Improve edit summary behavior when switching 
Distinguish between the initial summary state, and a value stored from the
summary when switching modes. This lets us avoid overwriting a stored value
when section-editing, or assuming a stored value after a switch was never
edited.

Bug: T159686
Change-Id: Ie7640538140a14bbafd539b3a45928f5c55cf804
 2017-03-09 14:23:36 -06:00
jenkins-bot 71fe1a8cea Merge "ArticleTarget: use existing initialEditSummary if present" 2017-03-09 19:12:52 +00:00
David Lynch 261d4e8974 ArticleTarget: use existing initialEditSummary if present 
Switching modes recreates the toolbar, so if someone has already edited the
save summary it shouldn't update the initialEditSummary to that.

Bug: T159686
Change-Id: I4109442853916bebae2bce804fcd6777e3eb6d34
 2017-03-09 12:05:12 -06:00
David Lynch c5bb912e80 ArticleTargetLoader: wikitext switch shouldn't require FullRestbaseURL 
The non-FullRestbaseURL branch didn't handle converting the provided wikitext,
causing data loss when switching from source to visual modes.

Bug: T158692
Change-Id: I283afc4be1e322228d6ec572bfa8542ba8fd9ce7
 2017-03-09 11:30:16 -06:00
jenkins-bot 832674fa85 Merge "Switching modes created an infinite loop onBeforeUnload" 2017-03-09 17:14:47 +00:00
jenkins-bot 10857b2d9f Merge "ve.ui.MWMagicLinkNodeContextItem: Do not display 'Clear styling' button in context" 2017-03-09 16:59:28 +00:00
Bartosz Dziewoński 7b618c55aa ve.ui.MWGalleryDialog: Fix 'Display mode' dropdown options' styling 
It's actually a bit surprising that the only thing broken by using
OptionWidget instead of MenuOptionWidget is some missing styles.

Change-Id: I3961fedbfc61f2f17d91dc7375d47a3cdff2a257
 2017-03-09 16:16:21 +01:00
David Lynch d6c71632ef Switching modes created an infinite loop onBeforeUnload 
Switching from visual to source reruns setupUnloadHandlers, which caused an
infinite loop where it thought it was its own fallback pre-existing handler.

Bug: T153346
Change-Id: I8df55a5395ede02fc34ec47a94f2c780dc08595f
 2017-03-08 11:32:03 -06:00
Translation updater bot b27fe68833 Localisation updates from https://translatewiki.net. 
Change-Id: I71344493334c65b08754134fe3bd3202fb72f04c
 2017-03-07 23:00:20 +01:00
jenkins-bot f9af257b7e Merge "ve.init.mw.DesktopTarget: Use mw-body-content instead of mw-body to match Vector changes" 2017-03-07 18:32:22 +00:00
Ed Sanders 387f9a5514 ve.init.mw.DesktopTarget: Use mw-body-content instead of mw-body to match Vector changes 
This ensures the styles are still applied to surfaces in dialogs.

Change-Id: I30e0cc7dc87dc8c8b6b3be84f821aa22baab457f
 2017-03-07 18:17:35 +00:00
jenkins-bot 9a90148d05 Merge "Add external classes to mw:ExtLinks in NWE preview" 2017-03-07 18:17:11 +00:00
Bartosz Dziewoński 48f227b263 ve.ui.MWMagicLinkNodeContextItem: Do not display 'Clear styling' button in context 
It doesn't work, you can't turn a MWMagicLinkNode into text by
clearing its styling. (You can still do that by clicking 'Edit',
'Convert to simple link', 'Clear styling'.)

`clearable = true` was being inherited from ve.ui.LinkContextItem.

Change-Id: Ib40e952554966fb74b3e72662a6e1e44ad748a57
 2017-03-07 16:34:18 +01:00
Translation updater bot 53cff258cf Localisation updates from https://translatewiki.net. 
Change-Id: Id6df97f02c3d04ff546d52afaa98efaa67d5906f
 2017-03-06 22:54:27 +01:00
jenkins-bot 81c9b5b032 Merge "Apex: Fix target margins" 2017-03-06 19:22:00 +00:00
Translation updater bot 9062ab75ab Localisation updates from https://translatewiki.net. 
Change-Id: Ia42483cea0eaf12517b602850dc2ae362c46b005
 2017-03-05 22:54:46 +01:00
Ed Sanders aa8f477dab Apex: Fix target margins 
Apex is basically abandonware, so we should consider deleting
this code.

Change-Id: Ie0c21fc21d4c37ab0344978bbd0d071415866397
 2017-03-05 18:07:04 +00:00
Translation updater bot a2ef681fd9 Localisation updates from https://translatewiki.net. 
Change-Id: I9a379fbf4bf30911eb8f7d796a4f8a94c1622c2b
 2017-03-04 23:06:24 +01:00
jenkins-bot 82355461fe Merge "Comment Parsoid hacks as such" 2017-03-03 22:58:25 +00:00
Ed Sanders 8802aa331b Add external classes to mw:ExtLinks in NWE preview 
Bug: T153413
Change-Id: I118d3b1794b99ed2d120dd5c5201c1fd18b6245b
 2017-03-03 22:46:21 +00:00
Ed Sanders 91822ddbd5 Comment Parsoid hacks as such 
Change-Id: I23fcc49031e3b34e5b83d7acea56845b325f3026
 2017-03-03 22:41:36 +00:00
Translation updater bot 8a76e9fe81 Localisation updates from https://translatewiki.net. 
Change-Id: I538b21eb94aacba63d2ff173e67c18146923ba04
 2017-03-03 22:50:06 +01:00
jenkins-bot 5aba0ee22b Merge "Improve NWE new section styles" 2017-03-03 18:06:04 +00:00
jenkins-bot 8d29d962c5 Merge "Cleanup DesktopTarget styles" 2017-03-03 17:54:43 +00:00
Ed Sanders 06fa5166c7 Improve NWE new section styles 
* Use <h2> for TextInputWidget to avoid duplicating skin styles
* Fix placeholder colour and font

Change-Id: I36c0b79ec9cbf3fa2ead0541ef5bac4a14a8781b
 2017-03-03 11:59:06 +00:00
Translation updater bot d53d15ec41 Localisation updates from https://translatewiki.net. 
Change-Id: I3865ee179a56f5eddf123afa31e98ee6d13c4ed8
 2017-03-02 23:26:47 +01:00
David Lynch 6cb6933e67 DesktopArticleTarget: Correctly bind section link handler 
Since December, the handler now expects to be passed the mode we're switching
to. Since we're filtering for just the edit link and not edit source, we can
hardcode 'visual' here.

Bug: T159374
Change-Id: I160045dd59ff1b4c2d180dbbe37280a1839886df
 2017-03-02 11:43:11 -06:00
jenkins-bot 59d52158a9 Merge "MWWikitextStringTransferHandler.test: Don't pass around an invalid doc" 2017-03-02 05:56:23 +00:00
jenkins-bot e55e6d7c99 Merge "MWWikitextSurfaceFragment#convertFromSource: Don't make an invalid doc" 2017-03-02 05:56:22 +00:00
jenkins-bot c537a8f0a2 Merge "ArticleTarget#getWikitextFragment: Optimise no-op" 2017-03-02 05:45:58 +00:00
James D. Forrester 9b4e27a91c MWWikitextStringTransferHandler.test: Don't pass around an invalid doc 
Even if it sounds cool, it isn't.

Change-Id: Ib6612bc0ea8d66fc1964b3a782ad56356da65952
 2017-03-02 05:43:10 +00:00
James D. Forrester 6fd475e8ec MWWikitextSurfaceFragment#convertFromSource: Don't make an invalid doc 
Though neat, this hack to get the internal list doesn't seem to be used
and creates an invalid document (just an internal list with no content,
so the internal list is at the start and the default selection position
is inside it). Instead, use the ve.dm.Document.static.newBlankDocument()
utility function that was made for this use case.

Bug: T153509
Change-Id: Iba5931cb5e3f939a803c1d59fa0d8f30a0513f84
 2017-03-02 05:43:03 +00:00
James D. Forrester e0814210e9 ArticleTarget#getWikitextFragment: Optimise no-op 
Change-Id: I6b54ae26e26c5ca697848d2534c128fc9c4bc4aa
 2017-03-01 19:17:26 -08:00
Bartosz Dziewoński 461f99e9da Document usages of ve.dm.Node.static.suggestedParentNodeTypes 
Ed told me this.

Change-Id: I5e3160d3e5c38f9babc133db8977a6e6b8bbd610
 2017-03-02 00:11:54 +01:00
Translation updater bot 603a5a6bd9 Localisation updates from https://translatewiki.net. 
Change-Id: I99dbcc74f0ff9a76c6463de302ea9fc90045f83e
 2017-03-01 22:47:27 +01:00
Ed Sanders 3c0ddc9c69 Cleanup DesktopTarget styles 
* Ensure DAT styles are fully scoped to DAT instances
* Ensure that generic desktop target rules are in the correct file
* Remove old unused rules

Change-Id: I466a0547ff9a0fa1102aac0b1e501a6ba6863ca3
 2017-03-01 12:38:51 +00:00
jenkins-bot ec897c120b Merge "Pass $overlay to FieldsetLayout and FieldLayout in various places" 2017-03-01 00:35:06 +00:00
Ed Sanders e163a09105 Use more specific event name for switching editor from the toolbar 
As we are in the global toolbar event namespace, 'switch' could
mean anything.

Change-Id: I66751faa249710af634ed0fd0c2f2a0bcd872db3
 2017-02-28 23:07:54 +00:00
Ed Sanders 109a136bd6 Use pencil icon for editor switcher dropdown 
Pencil is the icon we use for 'edit' elsewhere in the UI.
Use the eye icon for the VE tool to specify 'visual'.

Bug: T116417
Change-Id: I12b6bab2a52758685abde04579b274a32d651174
 2017-02-28 22:59:51 +00:00
jenkins-bot a61bbb18e3 Merge "Transclusion dialog: Add VE specific rules from OOjs UI" 2017-02-28 21:49:15 +00:00
Volker E 4e4d1da7a3 Transclusion dialog: Add VE specific rules from OOjs UI 
Adding VE specific rules from OOjs UI in preparation of removing them
from the library.

Change-Id: I798717b60badb521d28f8f7a7036a99e5a26d61a
 2017-02-28 12:24:22 -08:00
Ed Sanders b3989e4f07 Move switching methods to ArticleTarget and fix in mobile 
Change-Id: I7796dab5d2a24f9719870abf383925442b787612
 2017-02-28 11:47:35 -08:00
Ed Sanders b3cfca5401 MobileArticleTarget: Don't explicitly set menu indicator 
It is now inferred from toolbar position.

Change-Id: I9e3ac28aee74599b4b35ac2f870dca2556efb027
 2017-02-28 10:37:30 -08:00
jenkins-bot 2e2a5e452c Merge "Use list tool group for editor switching" 2017-02-28 18:33:44 +00:00
jenkins-bot 0070838981 Merge "Use ems for mobile surface font sizes, and add top/bottom spacing" 2017-02-28 18:30:23 +00:00
jenkins-bot 8a12dfd2ee Merge "Update tests to Selenium 3" 2017-02-28 16:04:27 +00:00
Ed Sanders 5ca02bae09 Use ems for mobile surface font sizes, and add top/bottom spacing 
Change-Id: Ida827b54a49c427f2fad2de1f634d8c4e4d28154
 2017-02-28 15:07:39 +00:00
Ed Sanders cb60db4c7f Use list tool group for editor switching 
Bug: T116417
Change-Id: Iadf5a81e2733ab81fe25c686dcd6dad8eac3885c
 2017-02-28 15:06:48 +00:00
Željko Filipin f776983204 Update tests to Selenium 3 
Bug: T158074
Change-Id: I784fc7bb85f32d5e50b5abb500c51493839ccebe
 2017-02-28 14:39:00 +01:00
Translation updater bot df7307c1b8 Localisation updates from https://translatewiki.net. 
Change-Id: Iaead1637d6460165edf1282450ba148e48d468a9
 2017-02-27 22:40:16 +01:00
Ed Sanders a3433e67fd Move modules loaded from DAT.init/TargetLoader to ResourceLoader 
This will make it easier for third parties to load the required
modules for an article-like target.

Also cleanup mobileArticleTarget to better match desktopArticleTarget.

Change-Id: Idb75e2bd99d8cf2c298e101cf92e8af4f85f5ad5
 2017-02-27 16:48:56 +00:00
Translation updater bot 4c9bc6ce53 Localisation updates from https://translatewiki.net. 
Change-Id: Ia9c63305453091afe7ebd5b5c5361dd2474ab11c
 2017-02-26 22:55:11 +01:00
Translation updater bot 49d2dade48 Localisation updates from https://translatewiki.net. 
Change-Id: Ie31ed3d14e14a362b890588db76946c2f6567755
 2017-02-25 22:44:27 +01:00
Translation updater bot 0f769f9a4c Localisation updates from https://translatewiki.net. 
Change-Id: Iea0b0881d660a604f83716425c1d2d38bb474dd1
 2017-02-24 22:49:39 +01:00
jenkins-bot a629b62b43 Merge "For the mode switch tool, show a different tooltip when disabled" 2017-02-24 19:23:53 +00:00
James D. Forrester 440a73206d For the mode switch tool, show a different tooltip when disabled 
Bug: T158723
Change-Id: I8c397e9b10c51d78c0b0f18c494ca9f36400d23e
 2017-02-24 08:49:47 -08:00
Translation updater bot a520037a38 Localisation updates from https://translatewiki.net. 
Change-Id: I7f5ea4a13665e807fe98c1f8d68d88536217d439
 2017-02-23 23:11:42 +01:00
L10n-bot ce86129067 Merge "Localisation updates from https://translatewiki.net." 2017-02-22 21:53:36 +00:00
Translation updater bot 18e340ef5f Localisation updates from https://translatewiki.net. 
Change-Id: I388c3a778615dc9d561e3ba15016fbed6bd825da
 2017-02-22 22:54:16 +01:00
Ed Sanders 501d0c94d2 Cache generated content request when inserting templates 
We request the generated content of a template to determine
if it will be block or inline. This is the same request as
the view makes later to show the rendering, so we should cache
this repsonse.

Bug: T156698
Change-Id: I0ffd36ccd0aa821aa44d99328f2e3a2abc23dc0f
 2017-02-22 04:00:38 +00:00
jenkins-bot 703e784d1a Merge "build: Bump grunt-jsonlint to latest and make pass" 2017-02-21 16:14:38 +00:00
Translation updater bot a3d001d7a5 Localisation updates from https://translatewiki.net. 
Change-Id: I716d04e411b2381f38381d80e9b70661007a3738
 2017-02-21 00:02:00 +01:00
Translation updater bot 50a0c7125a Localisation updates from https://translatewiki.net. 
Change-Id: Ie015f94ba4db43ac49f9a16e3fbe18ee715c27df
 2017-02-19 22:52:36 +01:00
Translation updater bot 63efc6c9af Localisation updates from https://translatewiki.net. 
Change-Id: Ibc99be0de6a97d39ccf7b13c40283410b8ac08a5
 2017-02-18 22:51:16 +01:00
James D. Forrester dddd2c0180 build: Bump grunt-jsonlint to latest and make pass 
grunt-jsonlint       1.0.8  →   1.1.0

Change-Id: I4a5cdd39f6215cc61a1ef530386a87fdcb0c0088
 2017-02-17 16:12:12 -08:00
James D. Forrester cc239a08da build: Bump stylelint and make pass 
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
 2017-02-17 15:23:12 -08:00
Translation updater bot 2dd0e06e87 Localisation updates from https://translatewiki.net. 
Change-Id: Ia236c6849f1c3194ebb59c666006f1edf03687cf
 2017-02-17 22:55:18 +01:00
Translation updater bot 8f5380cc12 Localisation updates from https://translatewiki.net. 
Change-Id: I46eaee06ac9f40e39685ebfccc76bd342439803e
 2017-02-16 23:09:58 +01:00
jenkins-bot 9164b6e400 Merge "DesktopArticleTarget.init: Don't hardcode single-tab accesskey" 2017-02-16 19:19:42 +00:00
jenkins-bot 97d689c824 Merge "MWSaveDialog: Switch to save panel when showing message" 2017-02-16 17:14:12 +00:00
jenkins-bot 6b6df0759e Merge "Tables: Add support for editing mw-collapsible/mw-collapsed" 2017-02-16 16:39:36 +00:00
David Lynch 288422cb9e MWSaveDialog: Switch to save panel when showing message 
Fixing T107251 made it so that clicking "save" always switched back to the
save panel momentarily, causing a flicker of "maybe I can edit this"
experience. With this change, we can only switch back to the save panel when
saving from other panels if a message is being shown.

Bug: T156891
Change-Id: I8f67693283e61c39cfce40ee12d5c6788dd97932
 2017-02-16 10:32:21 -06:00
Ed Sanders 9337e6ecbd Tables: Add support for editing mw-collapsible/mw-collapsed 
We don't support editing <div>s right now (as they're BranchNodes) nor
<span>s (as they're annotations), but most of those are inside templates
and so not editable in VE anyway.

Bug: T157989
Change-Id: I647b2a544fd16952696d0de8d07cb72189b27ecb
 2017-02-16 17:21:44 +01:00
Bartosz Dziewoński 22df25c108 Pass $overlay to FieldsetLayout and FieldLayout in various places 
We now use dialog's overlay in every case where we have a FieldsetLayout
or a FieldLayout with a help popup inside a dialog.

Bug: T100571
Change-Id: I8bd0ed430637feca63ec0f13cb7e1e1c659391a5
 2017-02-16 02:56:03 +01:00
Bartosz Dziewoński c3be577216 ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language variants 
Follow-up to 712ea472d3.

Change-Id: I2f3617fb4e9a80272e559b35c947052c0d8e534b
 2017-02-16 02:19:09 +01:00
Bartosz Dziewoński 2c78411113 ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM 
Bug: T158141
Change-Id: I999bcdc7095a3b9e2a86a7d5eca0e1f3ceb175ef
 2017-02-16 01:17:17 +01:00
Translation updater bot a21a89ac77 Localisation updates from https://translatewiki.net. 
Change-Id: I8a6a7bf01f41eed3d8d7c1cf5ccfb515c16586ce
 2017-02-15 22:47:52 +01:00
Translation updater bot 7d95edacde Localisation updates from https://translatewiki.net. 
Change-Id: I16205f62bba23e5d0d157d433a635feac710aba5
 2017-02-14 22:57:45 +01:00
David Lynch b1d68872b0 DesktopArticleTarget.init: Don't hardcode single-tab accesskey 
Bug: T156141
Change-Id: I1312283437714bf338a8ee3cf63e93ac67db1c45
 2017-02-14 11:24:50 -06:00
L10n-bot 6909c24d5d Merge "Localisation updates from https://translatewiki.net." 2017-02-13 22:19:02 +00:00
Translation updater bot ae92640bf3 Localisation updates from https://translatewiki.net. 
Change-Id: I79bc57730f31d46f3319d1108313d35547d7f2fc
 2017-02-13 23:19:33 +01:00
Bartosz Dziewoński 7beaf0ab9c ve.ce.MWTableNode: Provide preview of sortable table styling 
Algorithm for deciding which cells handle sorting is exactly
the same as in the real jQuery Tablesorter.

Depends on changes in VE core:
* I50426e173c68af7df49e47fe3bec0465a9a55c26
* Iabb372dfe7bf5feef314315ac74a788c6c58dc20

Bug: T139072
Change-Id: I4446be2ad459b05590754da9bb6c3dd8f796be42
 2017-02-13 21:36:43 +00:00
Ed Sanders 08b3f73f16 MWTableDialog: Extend initial values so 'done' button behaves correctly 
Depends-On: I608431365f2a482536affe1dae3fe21bc20e16b4
Change-Id: Idd468caa9417ffd8e0475083c884ef6c554ee152
 2017-02-13 08:30:51 -08:00
Ed Sanders 444ed0b7d8 MWTableDialog: Inherit actions from core 
Change-Id: Ice7f18ac2e1b7728a52a48482728d1b1278ca66f
 2017-02-13 08:30:51 -08:00
Translation updater bot 0b620cf417 Localisation updates from https://translatewiki.net. 
Change-Id: Id1187371077f15d98540f91be55ee2f074254ce5
 2017-02-12 22:44:26 +01:00
jenkins-bot 3c56d19e66 Merge "vw.ui.MWTableDialog: Add "Cancel" button" 2017-02-12 15:07:37 +00:00
Translation updater bot 30cb88940e Localisation updates from https://translatewiki.net. 
Change-Id: If95955b60c6c2b371bda27b1db2272939c3da982
 2017-02-10 22:55:28 +01:00
Bartosz Dziewoński aa22a8c482 vw.ui.MWTableDialog: Add "Cancel" button 
The dialog already supports cancelling by pressing Escape,
but the usual dedicated button was missing.

Change-Id: Ic63b5b59940a43474051466bdbbba0dbeb4342a9
 2017-02-10 15:26:33 +01:00
jenkins-bot a234120771 Merge "Check for 'veaction' when clicking section edit links" 2017-02-09 18:33:55 +00:00
Bartosz Dziewoński 5200f2ef34 ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter 
Or Cmd+Enter for Mac.

Depends on VisualEditor core changes:
* I93f50e325f993d82a821bf02f5e7f56fe1b9de62
* Id0a357b038fc5730f61bcf3ba730838dcda9b00e

Bug: T153241
Change-Id: I6b0a5e2c4e4ec72016463c8ba6576d33d59be8e5
 2017-02-09 16:47:41 +00:00
Ed Sanders 6bd650d50a Check for 'veaction' when clicking section edit links 
Such as in the 'add topic' link.

Bug: T157104
Change-Id: Ide2d4cf8c23a5d0db24456d15b4312f7c0a5f922
 2017-02-08 17:48:04 +00:00
Translation updater bot 02aa33cfbd Localisation updates from https://translatewiki.net. 
Change-Id: I74eab9790e644bb90f354ae5d6a9f3cbb7ca2d6b
 2017-02-07 23:07:39 +01:00
jenkins-bot 6e585c457c Merge "Move wikitext signature command to correct file" 2017-02-07 20:47:57 +00:00
Ed Sanders 8ab21d2ef5 Move wikitext signature command to correct file 
So that signature availability is checked.

Bug: T157286
Change-Id: If1e585ce02e0bc9f5aa93129d315f83f183f5952
 2017-02-07 20:21:32 +00:00
Ed Sanders f2cf73eaaf Define default HTML types for extension nodes 
Use span/div for inline/block nodes respectively.

Bug: T157389
Change-Id: I4c501a6af88a490eec83af26adaa515a2b1d18d1
 2017-02-07 20:12:39 +00:00
David Lynch 8a7d44224c ArticleTarget: try to refresh editToken if getWikitextFragment fails 
Refactor saveFail's badtoken handling out so it can be reused by
getWikitextFragment.

Bug: T156991
Change-Id: I686cddb5be4484211fa69640044db1bc34eacefc
 2017-02-07 11:20:59 -06:00
jenkins-bot 158807f86c Merge "Remove explicit toolbar indicator definitions" 2017-02-06 17:11:59 +00:00
Translation updater bot 19569f4b02 Localisation updates from https://translatewiki.net. 
Change-Id: If656029a98191aad2523fe743ac42b1a26920190
 2017-02-05 22:57:31 +01:00
Ed Sanders 7a058a4de8 Remove explicit toolbar indicator definitions 
These are now computed upstream based on position of toolbar.

The menu tool now needs its indicator explicitly hidden.

Change-Id: Id2280f70553e1e45f3a42af45684c5808797925c
 2017-02-04 10:25:37 +00:00
Translation updater bot bb029d2ebc Localisation updates from https://translatewiki.net. 
Change-Id: Ibe93c0e21b2c4adb1796c0d07f9f0843e834be4e
 2017-02-03 23:06:06 +01:00
jenkins-bot 61d449c9d2 Merge "ve.ui.MWSaveDialog: Prettify the 'messages' shown" 2017-02-01 23:50:58 +00:00
jenkins-bot 5015af4a32 Merge "ve.init.mw.ArticleTarget: Don't try to clear non-existent message" 2017-02-01 23:48:30 +00:00
jenkins-bot fbe31de0d3 Merge "ve.ui.MWSaveDialog: Remove unused $saveActions div" 2017-02-01 23:48:10 +00:00
Translation updater bot 8390b1f3fb Localisation updates from https://translatewiki.net. 
Change-Id: I1d46d45a3dda6243a24cddbdb0dd679f8628fee9
 2017-01-31 22:58:54 +01:00
Bartosz Dziewoński e8d99c5536 ve.ui.MWSaveDialog: Prettify the 'messages' shown 
This is currently used to display a warning about missing edit summary
and to display a CAPTCHA field. They now appear in a separated area at
the bottom of the dialog, which slides into view when a message is
added.

Change-Id: I7541284a92d5fd2fa8f469d479e059098c59c0ac
 2017-01-31 17:37:00 +00:00
Bartosz Dziewoński 6f367ea0ec ve.init.mw.ArticleTarget: Don't try to clear non-existent message 
This is just dead code. We never call `.showMessage( 'captcha', ... )`
(the CAPTCHA is shown in the 'api-save-error' message).

Change-Id: I48f51e89d5b366384d184e2ed505be9e7b8f3401
 2017-01-31 14:40:32 +01:00
Bartosz Dziewoński a0cb3029cb ve.ui.MWSaveDialog: Remove unused $saveActions div 
Change-Id: I47da48b29d3bddd598946de655cf1e8b086daf45
 2017-01-31 13:43:47 +01:00
Translation updater bot 2e690797c0 Localisation updates from https://translatewiki.net. 
Change-Id: Idc95868d10a1fd04899fcbec7a280b55743a874d
 2017-01-30 22:52:00 +01:00
jenkins-bot 7b46d105b1 Merge "Advanced Settings: improve displaytitle field" 2017-01-30 19:40:13 +00:00
David Lynch 00fb8c8e58 Advanced Settings: improve displaytitle field 
* Remove the checkbox; an empty field, or a value exactly equal to the page
  title means no displaytitle.
* Automatically fill the field with the current page title
* The field was mispositioned

Bug: T155818
Bug: T156665
Change-Id: I46db6b14616c9a021e757284972537cac00546a1
 2017-01-30 19:29:25 +00:00
WMDE-Fisch a0af0b0529 Disable VisualEditor in the TwoColConflict extension 
As for the Translate extension this will read a global set by the
TwoColConflict extension to disable the VisualEditor and its hooks
on the modified edit conflict page there.

Bug: T156251
Change-Id: I164d1546c9d98d8715650e13c63a01d06c76315d
 2017-01-30 14:06:59 +01:00
Ed Sanders 1d7f929a91 Update VE core submodule to master (139bdf7) 
New changes:
d79138b Overwrite selected content when pasting via DataTransferItem
3c4737f Ensure clipboard is never empty text
3b1339e Create dummy platform and target for tests
4d63c8e Pass text as string to insertDocument when detected as plain text

Local change:
Remove VE standalone module

Flow used to use it, but not anymore. Going forward no one should
be using it in MW.

Bug: T154020
Bug: T156302
Bug: T156498
Depends-On: I078c244ef524669da477a43f9b37c847252e5ad7
Change-Id: Ifc4be16269f819890f2dcdddbbdebf9694ad2868
 2017-01-29 18:50:47 +00:00
Translation updater bot 662789bb13 Localisation updates from https://translatewiki.net. 
Change-Id: Ib90e3f4f0482f1642fe8dde53dd0f601d3e942cc
 2017-01-28 22:56:32 +01:00
Translation updater bot 0383c3c61b Localisation updates from https://translatewiki.net. 
Change-Id: I19e481d7151511014ac3fabd241cdf01932a937e
 2017-01-27 15:00:35 +01:00
jenkins-bot 19c0dd3aa4 Merge "MWSaveDialog: only focus summary if we're on the save panel" 2017-01-27 07:25:31 +00:00
David Lynch 60866eade2 Override ui.CommentInspector so that copying from it sets text/x-wiki 
Bug: T154837
Change-Id: I3413c955aa23d34683e1a028a581b1ea34d55d49
 2017-01-27 01:13:41 -06:00
David Lynch b976f2cf38 MWSaveDialog: only focus summary if we're on the save panel 
Firefox throws exceptions when trying to focus hidden inputs. Using the
"preview" keyboard shortcut entirely bypasses the save panel, but the ready
process assumes it'll always be opened first.

Bug: T153958
Change-Id: Ifb3861116565e77c30b3874fe47889298c3ace6d
 2017-01-27 00:51:33 -06:00
jenkins-bot fb48db7227 Merge "Ignore section edit links when no action present" 2017-01-26 14:13:24 +00:00
Ed Sanders 1df022a6d6 Ignore section edit links when no action present 
BUg: T156282
Change-Id: If3d039da36db946dcbba123d3cdc4e99c45f6a4e
 2017-01-25 18:13:56 +00:00
Translation updater bot dc7ce167b3 Localisation updates from https://translatewiki.net. 
Change-Id: Ie1b9552f69f104a50f0b317d1c6db4d046526ffc
 2017-01-25 14:49:37 +01:00
jenkins-bot fb1d1cdfaf Merge "Use target=_blank for link in template 'extra description'" 2017-01-25 12:53:03 +00:00
jenkins-bot 7d9d6b35d2 Merge "Update actions on live inspectors and preview dialogs" 2017-01-23 23:33:44 +00:00
Translation updater bot 23bce58071 Localisation updates from https://translatewiki.net. 
Change-Id: Ib31aa19ef33f7b5017bf3ed49684cae670fd50c7
 2017-01-23 22:50:30 +01:00
Ed Sanders 133da969ce Use target=_blank for link in template 'extra description' 
We already do this for 'missing description'.

Bug: T155879
Change-Id: Iccf48070ab2b5890d6891856be4ee5cce5308d0d
 2017-01-23 13:07:53 +00:00
Translation updater bot 07f877d476 Localisation updates from https://translatewiki.net. 
Change-Id: I6a51ed82a750a1fd6c3bb5697bb9b69067b2e96d
 2017-01-22 22:45:16 +01:00
Translation updater bot e821a8e24b Localisation updates from https://translatewiki.net. 
Change-Id: Ib7a453738fc26748d5b202c7598db1009d72b145
 2017-01-21 22:46:51 +01:00
Thalia 43c2865f90 Update actions on live inspectors and preview dialogs 
Make inspectors inheriting from MWLiveExtensionInspector
and dialogs inheriting from MWExtensionPreviewDialog
update their 'done' action every time updatePreview is
called. Since both mix in ExtensionWindow, two new methods,
updateActions and isModified are added there.

This should make it more difficult to insert an empty node
accidentally or create a transaction just by opening and
closing an inspector or dialog.

For more complicated dialogs, or inspectors or dialogs
that don't live-update, this behaviour will have to be
implemented separately.

Bug: T155330
Change-Id: Iacafa01fcd419faaec9b112c96be86693a57d561
 2017-01-21 18:29:18 +00:00
Ed Sanders 171286c120 Fix typo in target config 
Change-Id: I5815ce5b0e05ce166e02bfcced520e3770f5453d
 2017-01-20 23:15:23 +00:00
Ed Sanders f58d00b110 Move #getWikitextFragment up to ArticleTarget 
Change-Id: Ice4b04db4a45c07ccffc3892e6db5d814c2ec37b
 2017-01-20 23:15:17 +00:00
Ed Sanders e5555d6d85 Remove MWMobileSurface & Context 
The hacks contained within context were ancient and no
longer used, and thanks to a typo in mw.MobileArticleTarget
neither of these classes was being used anyway.

Change-Id: I52f2b6d5aa5ddbcc45ac6107eaf9407570b73672
 2017-01-20 23:15:11 +00:00
Ed Sanders 1ae5c13cb9 Update VE core submodule to master (f0dcedb) 
New changes:
5b448fa [BREAKING CHANGE] Merge Mobile/DesktopSurface into Surface
2d8959b Localisation updates from https://translatewiki.net.
7eee772 Follow-up 2d8959b: Fix build for added language 'io'
f0dcedb ve.dm.TableMatrix: Really indent ASCII-art comments

Change-Id: I62708f7caeb03b16cd318aab0b0ee3c674e75a26
 2017-01-20 14:35:39 -08:00
Translation updater bot 015017376e Localisation updates from https://translatewiki.net. 
Change-Id: Id8ab05872453edaf2c54c841dcc6abf7b7e68f32
 2017-01-20 09:46:04 +01:00
Translation updater bot b0944d5ad3 Localisation updates from https://translatewiki.net. 
Change-Id: I08914c4a309c016d8ceff90da41328d3c3b12110
 2017-01-17 22:17:40 +01:00
jenkins-bot 1e32b1d31d Merge "Re-order all meta code to put categories first" 2017-01-17 02:39:55 +00:00
jenkins-bot faaf7d2b4f Merge "Fix correct default page for meta dialog in NWE" 2017-01-17 02:38:44 +00:00
Ed Sanders 96a3d38cf9 Re-order all meta code to put categories first 
For consistency.

Change-Id: Ia5e9728ca4f727f4ce30d5f0c88ac9df8c4d21d0
 2017-01-17 00:19:38 +00:00
Ed Sanders 1aeec314d5 Fix correct default page for meta dialog in NWE 
Bug: T154639
Change-Id: I49d0f2295b071ae667e111562e30d04b0174c251
 2017-01-17 00:17:51 +00:00
jenkins-bot 9c3f3646c8 Merge "Correct comment in MWBlockImageNode" 2017-01-16 20:24:45 +00:00
Translation updater bot 6a449d29ba Localisation updates from https://translatewiki.net. 
Change-Id: I12814771ed6d7d2005c5c09543e30f1e635a3289
 2017-01-16 14:32:09 +01:00
Thalia 8c4b8e55e5 Correct comment in MWBlockImageNode 
Change-Id: I99058f97ac74b57c648be51cdb267d24a197b16a
 2017-01-14 18:38:20 -08:00
Ed Sanders 337614d142 Open preview links in new tab 
Bug: T155159
Change-Id: Idddc6b25303c17382ba1bc763b9001b727e1040e
 2017-01-12 16:07:00 -08:00
jenkins-bot a4543a7336 Merge "Allow AceEditorWidget to accept autocomplete word list" 2017-01-12 02:00:14 +00:00
Thalia fc61fb9be0 Allow AceEditorWidget to accept autocomplete word list 
Bug: T155107
Change-Id: I2dd752fb55a4d5596dbc8b8dc69eb55083d7ec66
 2017-01-11 17:26:16 -08:00
L10n-bot 220b2ef042 Merge "Localisation updates from https://translatewiki.net." 2017-01-11 22:27:03 +00:00
Translation updater bot 1f90679b43 Localisation updates from https://translatewiki.net. 
Change-Id: I92917d08fd03456856c1983ab1bd07cd8d46943a
 2017-01-11 23:21:18 +01:00
jenkins-bot 7c49a23a33 Merge "ArticleTarget: Give users a specific message when HookAborted errors happen" 2017-01-11 22:21:13 +00:00
jenkins-bot 18ba046361 Merge "ArticleTarget#saveErrorUnknown: Handle the xhr being complete" 2017-01-11 20:37:08 +00:00
James D. Forrester 002b0adef0 ArticleTarget: Give users a specific message when HookAborted errors happen 
Change-Id: I7017412dc56200f5bb0adbd901aed15507447846
 2017-01-11 10:46:30 -08:00
James D. Forrester 2b502572ec ArticleTarget#saveErrorUnknown: Handle the xhr being complete 
Change-Id: I638b5b80c5a404a438ebd357b6e16bbab7871d6e
 2017-01-11 10:45:43 -08:00
jenkins-bot 0405f8c80a Merge "DesktopArticleTarget: Prevent infinite while loop if $content is empty" 2017-01-11 18:39:35 +00:00
Ed Sanders 889ffc0efc DesktopArticleTarget: Prevent infinite while loop if $content is empty 
Change-Id: I629b2c3f1a4af3441764db7d1d0a7cec96181396
 2017-01-11 18:29:16 +00:00
Translation updater bot 3c943c5817 Localisation updates from https://translatewiki.net. 
Change-Id: Ib66f2dc2241016540afa2df19cc4ac36523ae98b
 2017-01-09 15:56:06 +01:00
jenkins-bot 70a66d4070 Merge "More error handling fixes" 2017-01-09 02:24:17 +00:00
jenkins-bot 09829ae7b4 Merge "MWMetaDialog: Move categories to the top as they're used most" 2017-01-07 14:56:56 +00:00
Translation updater bot 9d29ec3d9c Localisation updates from https://translatewiki.net. 
Change-Id: I37e2fb1213d1db27e24219fba349638f75fc122f
 2017-01-06 23:14:55 +01:00
Translation updater bot a0bda5eb51 Localisation updates from https://translatewiki.net. 
Change-Id: Ied8c757544363b36e27cfccb4df80a0c22d78ce2
 2017-01-05 23:50:18 +01:00
Alex Monk 8fe5bbe39b More error handling fixes 
See T154565

Change-Id: I073aae149497342157503ad3f465b7d57aaad4fa
 2017-01-05 15:13:02 +00:00
jenkins-bot 50e7fd0653 Merge "Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts" 2017-01-05 15:08:33 +00:00
jenkins-bot 4d64196fcb Merge "Fix loadFail parameter handling" 2017-01-04 22:46:27 +00:00
jenkins-bot e91f8f913e Merge "Allow 'T-' prefixed sections, and redirect if section link title isn't current page" 2017-01-04 22:38:34 +00:00
Alex Monk 1bcaa9056c Fix loadFail parameter handling 
Rename them while we're at it.

Bug: T151278
Bug: T152429
Change-Id: I435ac148007db87da69e8cf48568fafa646abb71
 2017-01-04 22:31:08 +00:00
Translation updater bot f2947ed40d Localisation updates from https://translatewiki.net. 
Change-Id: I842b0b968551a988d1a848d8b08aa4ace0c10466
 2017-01-04 22:39:54 +01:00
James D. Forrester 6795430831 MWMetaDialog: Move categories to the top as they're used most 
Bug: T74399
Change-Id: I696d8484ed00c92340f178d5c9dcfe978998dce0
 2017-01-04 11:18:00 -08:00
Ed Sanders 808de2acea Add "templates used" page to meta dialog 
Bug: T149009
Depends-On: Id617f9afbddf094140133f9659efc4b4e746148c
Change-Id: I63e663d05aefb47274f1f28bdcafc5317c2fc4f6
 2017-01-04 18:30:11 +01:00
Ed Sanders b7dd6077b8 Allow 'T-' prefixed sections, and redirect if section link title isn't current page 
Bug: T153176
Change-Id: Ic6fda78d00715777df4a273e7d3e150f20185185
 2017-01-04 16:53:03 +00:00
jenkins-bot cbd88e10ed Merge "Use the monospace hack consistently" 2017-01-03 20:41:03 +00:00
jenkins-bot d816492ca1 Merge "rm stray fileRepoPromise property from media dialog" 2017-01-03 20:24:34 +00:00
jenkins-bot 1ac5ede187 Merge "Don't try to JSON stringify load error messages that are already strings" 2017-01-03 20:22:50 +00:00
jenkins-bot 4abdf21413 Merge "Also allow opening in source mode if VE is unavailable on action=edit" 2017-01-03 20:19:09 +00:00
jenkins-bot 2b913fb10c Merge "Add editintro to notices" 2017-01-03 20:19:06 +00:00
jenkins-bot a973528d67 Merge "Don't block VE/NWE from loading if 'editintro' is specified" 2017-01-03 20:13:29 +00:00
Alex Monk 17ced451f4 MWSaveDialogAction: Don't break on strange accesskey messages 
Quietly return instead.

Bug: T153472
Change-Id: I7c325624734f122c9fd939aee1192187c63d9247
 2017-01-03 11:37:09 -08:00
jenkins-bot f182d5d223 Merge "When switching check wikitext is a non string, not just empty" 2017-01-03 18:57:48 +00:00
jenkins-bot 78a38ae6ea Merge "Register shortcuts for minoredit/watchlist" 2017-01-03 18:54:26 +00:00
jenkins-bot 945d3d4cbc Merge "After saving a specific section, scroll to it" 2017-01-03 18:49:19 +00:00
jenkins-bot 9cc4736708 Merge "ve.ui.MWParameterPage: Restructure constructor to reduce needless work" 2017-01-03 18:44:56 +00:00
jenkins-bot ec6509e86b Merge "ve.ui.MWParameterPage: Hide the "Fall back to plain wikitext" button when in wikitext" 2017-01-03 18:44:54 +00:00
Alex Monk 5c2773539e After saving a specific section, scroll to it 
Bug: T153297
Change-Id: I233e5226abc44d5d0bf8e56957a133d595e7be6f
 2017-01-03 18:38:55 +00:00
jenkins-bot 6599aaf3f4 Merge "Give focus to preview panel for keyboard scrolling" 2017-01-03 17:58:32 +00:00
jenkins-bot f439843964 Merge "Factor out preferred editor check" 2017-01-03 17:50:42 +00:00
jenkins-bot f89a6a3880 Merge "build: Bump file copyright notices for 2017" 2017-01-03 17:11:04 +00:00
jenkins-bot 24d26f5e19 Merge "Move translate extension hack up to 'isAvailable'" 2017-01-03 17:04:11 +00:00
jenkins-bot 7c790f8d12 Merge "Use preferred number casting method" 2017-01-03 17:04:10 +00:00
jenkins-bot 7a81159941 Merge "Fix NWE-only edit tab" 2017-01-03 17:04:09 +00:00
jenkins-bot 80e0edd275 Merge "Allow switching between 'edit source' and 'add topic'" 2017-01-03 17:04:08 +00:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017 
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
 2017-01-03 08:58:33 -08:00
Ed Sanders 4628e9e68c When switching check wikitext is a non string, not just empty 
Also add documentation.

Bug: T154437
Change-Id: Icacc0ad522d3e7fa28ecea9876c2c0465c4eb8e6
 2017-01-02 18:40:07 +00:00
Translation updater bot daa5085917 Localisation updates from https://translatewiki.net. 
Change-Id: I1dbde448e5f2d60675d35d070969b3890ea2aa49
 2017-01-01 10:17:23 +01:00
Ed Sanders 58071f59f1 Add editintro to notices 
Bug: T56029
Bug: T51622
Change-Id: Ib43cc66b817ff394b4f1c82fcba4503df825819c
 2016-12-31 23:23:17 +00:00
Ed Sanders c853475a1a Give focus to preview panel for keyboard scrolling 
Bug: T154334
Change-Id: Ibc093e3111411b6183bf24528a2e0419ba8d40b6
 2016-12-31 22:04:19 +00:00
Ed Sanders fe85ee1ba6 Don't block VE/NWE from loading if 'editintro' is specified 
Later we should actually show the edit intro, but that is a
separate issue (T56029).

Bug: T153481
Change-Id: I97622a3d86b975866305aaa745bac51f6b55f217
 2016-12-31 15:22:11 +00:00
Ed Sanders 9eebfbcac5 Fix NWE-only edit tab 
Change-Id: I5d08e30f43fbe08eb8809692728a8ab37f3a1491
 2016-12-30 16:42:54 +00:00
Ed Sanders 3f47aec20b Use preferred number casting method 
Change-Id: I77215f2bdb6eb055375e5b803d23b6f26df2d8d1
 2016-12-29 20:33:15 +00:00
Alex Monk 4af862e6d3 Also allow opening in source mode if VE is unavailable on action=edit 
Bug: T153508
Change-Id: I5678d3b417c93707edc90bbb76ce4dafcd2098c6
 2016-12-29 20:32:58 +00:00
Ed Sanders c963b73e71 Factor out preferred editor check 
Change-Id: Ic2e2e2e1d24dba8854315dff068ea9ce5d409c5a
 2016-12-29 20:17:55 +00:00
Ed Sanders 7de023caee Allow switching between 'edit source' and 'add topic' 
Also between section editing and full page editing
by clicking on 'edit source'.

Change-Id: I9165a7ad4ac2a588a09532c7181ba72b6fd2f811
 2016-12-29 15:48:38 +00:00
Translation updater bot 2217913182 Localisation updates from https://translatewiki.net. 
Change-Id: If99a57be3026afdfd71533ff227649069c092674
 2016-12-29 10:25:31 +01:00
jenkins-bot 927856aff3 Merge "Use mw.Message#parseDom where appropriate" 2016-12-28 21:40:18 +00:00
Ed Sanders c625398b78 Use the monospace hack consistently 
Change-Id: I6b223e5f0760902c1f34fa5a284703055c763234
 2016-12-28 13:36:14 +00:00
Translation updater bot 786f354ec5 Localisation updates from https://translatewiki.net. 
Change-Id: I6a6785f8b9a0f0448a0f0e0af11dcebf2ab9ec3b
 2016-12-28 10:57:13 +01:00