Commit graph

7887 commits

Author SHA1 Message Date
James D. Forrester 413f6e82fa Mention at the top of the MW-specific ve.ce.Surface.test file what it is
Change-Id: Icadbf6afbb7d1b9f3bf7bc65ac3d505b4c091275
2014-07-22 23:41:27 +00:00
jenkins-bot 016c93c29b Merge "Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params" 2014-07-22 23:37:41 +00:00
jenkins-bot dec052a4d3 Merge "Deprecate 'live' event in favor of 'setup' and 'teardown' in MW" 2014-07-22 23:36:38 +00:00
Moriel Schottlender b6cc76d49a Deprecate 'live' event in favor of 'setup' and 'teardown' in MW
See also Ieddbf5c684eb0edc3130034de64eb284aeaebbda

Bug: 55505
Change-Id: Ib48ef4f62ac53d41abb69f275f51da3d8b85ce0e
2014-07-22 23:34:32 +00:00
jenkins-bot a602c268d8 Merge "Put "re-use reference" in the toolbar "Cite" menu, and give it an icon" 2014-07-22 21:30:33 +00:00
Translation updater bot 16dccdb527 Localisation updates from https://translatewiki.net.
Change-Id: I1636b3550f51933ad3faf35d69317fd0484b8889
2014-07-22 23:03:10 +02:00
James D. Forrester a9356992d8 Put "re-use reference" in the toolbar "Cite" menu, and give it an icon
Bug: 68201
Change-Id: I9fc61e498748fb086c3e506959bee2438b8cbea6
2014-07-22 13:10:06 -07:00
James D. Forrester 7007f61291 Update VE core submodule to master (244bf0e)
New changes:
32c7edd Localisation updates from https://translatewiki.net.
c7d61bc Round up height of language inspector widget
9473d2f Localisation updates from https://translatewiki.net.
2cffb4d build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1
b3f861e Localisation updates from https://translatewiki.net.
76b7992 Localisation updates from https://translatewiki.net.
76f8e90 Make the re-render flash more prominent
d2506a3 Localisation updates from https://translatewiki.net.
244bf0e CommandHelpDialog: Make closing action 'safe' not 'primary' for consistency

Change-Id: I68db9bdfa6078d4ab3b110e140c413fc6b865c1b
2014-07-22 13:05:31 -07:00
jenkins-bot 107ce12f9d Merge "Fix heights of Reference, ReferenceList and Template dialogs" 2014-07-22 16:11:39 +00:00
Vikas S Yaligar e0e1b38f13 [BrowserTest] Language screenshots are uploaded every 5 seconds
Change-Id: I25b7842b827b9d9366aeafb423b1884271bb39f0
2014-07-22 19:09:06 +05:30
Alex Monk 42db347213 Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params
Bug: 55925
Change-Id: I8475074e25de3969717a6d4dbb88bbb0000ebb4e
2014-07-21 22:38:05 +01:00
Translation updater bot a7e395f0b9 Localisation updates from https://translatewiki.net.
Change-Id: If6a2f2596eecea1d3d8848435277cba23da12da1
2014-07-21 21:42:28 +02:00
Cmcmahon 7b7d8c02a4 [BrowserTest] update Save button locator
Change-Id: I2383a279ab170c382f465d3a7c2f4a3e6b275c48
2014-07-21 09:19:55 -07:00
vikassy 365453f2b3 [BrowserTest] Added @login tag to language screenshot feature
Change-Id: I31f58d4321d8dd251d1a0fcb641ca939a60b1aa0
2014-07-21 17:47:44 +05:30
Translation updater bot aa5c6e9293 Localisation updates from https://translatewiki.net.
Change-Id: Id01027bb596eb6274fee0bbb108f53809b16c18d
2014-07-20 21:11:13 +02:00
Translation updater bot c28a48e7fd Localisation updates from https://translatewiki.net.
Change-Id: I09ff4c6b858071ce4d7488c0ddf781f1ac7ca3eb
2014-07-19 22:08:00 +02:00
James D. Forrester ed82afc14c Fix heights of Reference, ReferenceList and Template dialogs
Bug: 68226
Bug: 68232
Change-Id: I93916875a6b4b1e7b837efce33a9aa20857f227a
2014-07-18 19:14:30 -07:00
James D. Forrester cc089d6bd3 Scrap the cancel button from the toolbar
It's unnecessary, big and ugly, way too close to an actually useful button, and
adds oodles of complexity to the mire that is VPT without significant user benefit
whilst taking up an unjustifiably huge amount of the already-over-burdened space.
This means that the minimum browser width for English on default Vector to show
the toolbar correctly is now 945px, down from 1029px.

Bonuses: fix MWCancelConfirmDialog's cancel button to be destructive (it is) and
remove a now-recently-fixed comment asking for the save button to be styled using
a generic class (provided by the constructive flag).

Change-Id: I30dc7020121f0dd6907b61ef674a7cb14eb00652
2014-07-18 16:38:17 -07:00
James D. Forrester 8cc3451be7 build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1
Change-Id: I097d63cea436ab6ef2a16fccead10b72103d0b6e
2014-07-18 13:21:27 -07:00
Translation updater bot 83b65db414 Localisation updates from https://translatewiki.net.
Change-Id: I944856f8e79dcd05e1f49af9b6d2663d3e138df3
2014-07-18 21:30:58 +02:00
jenkins-bot 23a0fcb249 Merge "[BrowserTest] Updated random page step to language screenshot page" 2014-07-18 12:46:45 +00:00
vikassy 06f15fb7eb [BrowserTest] Updated random page step to language screenshot page
Change-Id: Ica2ae78afcba264d222b02923863b8f23452e259
2014-07-18 18:06:23 +05:30
vikassy 8e1c3de801 [BrowserTest] Fixed failing Media Icon test
Change-Id: I1d07398f1b8f999c76dc278ed8950778ba1e8fd9
2014-07-18 11:01:11 +00:00
Translation updater bot e151d32054 Localisation updates from https://translatewiki.net.
Change-Id: Ie60ce37f1516f55b32631eabf712bb5848b6b562
2014-07-17 23:00:51 +02:00
Cmcmahon cda44f8a9e [BrowserTest] support for Chrome
Chrome is strict about z-index stuff

Change-Id: Icc477891ce1a9ad0fa75a77bcdd387bf6ca13c48
2014-07-17 12:08:16 -07:00
vikassy f58d98fcb9 WIP [BrowserTest] Modified conflicting step: I go to the (.*?) page
Change-Id: Ie0ff326890efddf255320da62a2dd1ec46ffae20
2014-07-17 17:09:47 +00:00
Cmcmahon dc4db46539 [BrowserTest] Chrome needs to wait for the inspector
Change-Id: Iface30b72959b75d04beb54aa76d5798920a881e
2014-07-17 09:28:31 -07:00
jenkins-bot a69ab13cf1 Merge "[BrowserTest] Added lots of new scenarios for language screenshot" 2014-07-17 14:40:59 +00:00
Cmcmahon 406a4c31ae [BrowserTest] update locator for correct page text
Change-Id: Ida8ce2da1061d557520654d2a45369828eefad42
2014-07-17 07:00:28 -07:00
vikassy 27390478b9 [BrowserTest] Added lots of new scenarios for language screenshot
Bug: 62737
Change-Id: If30a9acbe772b76f8a2656ccf3f219dbede9853c
2014-07-17 18:48:53 +05:30
James D. Forrester 72fa906d9f Update VE core submodule to master (63b10db)
New changes:
63b10db Fix-up mobile context and surface

Change-Id: I4b917615a814cbc609a1cf236bd18ce15ef52fbf
2014-07-16 17:17:14 -07:00
jenkins-bot 20205b1e99 Merge "Set title of page to use if discarding changes when changing to the wikitext editor" 2014-07-17 00:08:58 +00:00
Trevor Parscal 49ffef5a0f Close the save dialog on teardown only, not on save
Closing a dialog with specific data means closing it again with
potentially different data, while the dialog is already closing, means
someone wins and someone looses. Silently failing in this case is bad,
because if the first close call was a cancel, producing no side effects,
but the second close call would have produced some side effect, the side
effect would never occur.

The problem here really was that the save dialog needs to be closed
before we can destroy the surface so we can uphold the assumption that
hold and teardown processes are operating on an attached DOM.

The solution is to automatically close the save dialog on teardown,
rather than on save. Since save triggers teardown, this has and identical
user experience.

Bug: 68048
Change-Id: I669448739f168737d4eddd6496189a819ce894b1
2014-07-16 23:51:58 +00:00
James D. Forrester 040ef014bd Update VE core submodule to master (8bb3848)
New changes:
8bb3848 Bring back global/local specific CSS classes

Local changes:
Use global overlay class to target the z-index hack for the Vector skin.

Bug: 68066
Change-Id: If1b6ba0c9035ff32b61d34ee779a95554883a2ec
2014-07-16 23:48:07 +00:00
James D. Forrester eec5946d17 Update VE core submodule to master (48772a2)
New changes:
77dd12e Prevent deletion of focusable nodes by typing
da66427 Update OOjs UI to v0.1.0-pre (97dbb50137)

Change-Id: Ia6d83495a523106e92b184c8b60f815d3739d1fa
2014-07-16 16:00:14 -07:00
Moriel Schottlender 2a114815ab Listen to widget changes in MediaDialog
Attach event listener to the alternate text and the media size widget
in the MediaDialog, so that when either of those are changed the
'Apply Changes' button is enabled.

Related to I88c3f3dcc7667b3ffdd2a8a8433cb47b82ba1531

Bug: 67684
Change-Id: I03efbed2f9b2909b055d96b9ae1e27b6d5e2bdbf
2014-07-16 22:46:47 +00:00
jenkins-bot e5fba68036 Merge "[BrowserTest] update switch-edit-mode test for new UI" 2014-07-16 22:43:56 +00:00
jenkins-bot ccbee28161 Merge "Update VE core submodule to master (ad18102)" 2014-07-16 22:43:51 +00:00
Trevor Parscal 1be1c469de Enable mwreference, mwtransclusion modules on all targets including mobile
Bug: 67701
Change-Id: Icdf2a208c9efa7abd897d48aed02bf923328d53c
2014-07-16 22:40:00 +00:00
Cmcmahon d0b8f62276 [BrowserTest] update switch-edit-mode test for new UI
Also add new checks for switch-modal Discard and
Cancel options

Change-Id: I228b0dee1d110f6a72be4966bbc5918f294ab717
2014-07-16 15:38:52 -07:00
Moriel Schottlender e94a185fda Update VE core submodule to master (ad18102)
New changes:
65042de Fix alien test data
83dccbe Add toolbar menu labels to each group for consistency
2e40ef9 Move 'language' tool from the insert to the styling menu, like in VE-MW
6fb21b2 Add toolbar action section to SA demo with keyboard shortcuts tool
f3eb000 ve.ui.Toolbar: Optimise onSurfaceViewKeyUp performance
eb4e9eb Make sure the document is focused when setting a selection
48584d3 Fixes to getRelativeOffset and getRelativeRange		
fcc427f [BREAKING CHANGE] Remove generatedContents argument from afterRender
825e4be Documentation fixes in test utils		
dbbbe0b Unit tests for showSelection		
1ba9234 Don't handle up/down on focusableNodes even if backwards
a667b87 Remove label from 'insert' menu, and instead use a large plus icon
88885b1 Localisation updates from https://translatewiki.net.		
1f3b79f Initialize data first		
18369b1 Add 'clone' and make 'getDimensionsFromValue' static in ve.dm.Scalable		
92e6b7b Switch to 'custom' when MediaSizeWidget updates		
d0cd87e Localisation updates from https://translatewiki.net.		
1ee21ff Remove lies from documentation		
164f07f Safely ignore requests to open unrecognized windows

Local changes:
Work on a cloned scalable when editing images

Make sure the image model handles a cloned copy of the node's
scalable object, which is then shared with the media size widget.

Bug: 67687
Change-Id: Ie3676b715f5bae3d83da03d667cef3a6a847e212
2014-07-16 22:38:09 +00:00
Alex Monk c1c80f6985 Set title of page to use if discarding changes when changing to the wikitext editor
Turns out it's a bad idea to do most testing on the default page

Bug: 68121
Change-Id: Ie9729dba4e8ca690625a6553703e9ff30cb5106e
2014-07-16 23:15:26 +01:00
jenkins-bot de9491ea0e Merge "Make a message dialog for cancelling VE" 2014-07-16 20:45:28 +00:00
jenkins-bot 1ff53d1b77 Merge "Don't allow document save if we're already tearing down the surface" 2014-07-16 20:45:24 +00:00
Translation updater bot 2c390f41ec Localisation updates from https://translatewiki.net.
Change-Id: Ifdf8cb5fa2726e419277638ae1f0c06978345c6c
2014-07-16 22:02:30 +02:00
Cmcmahon ea96b33c2c [BrowserTest] update template test
Change-Id: I0956bf58e15b1998b995bbcaddbe2514a8d7a058
2014-07-16 12:21:57 -07:00
jenkins-bot bb213db797 Merge "[BrowserTests] update References test for new UI" 2014-07-16 18:27:03 +00:00
Cmcmahon 48044d0ec5 [BrowserTests] update References test for new UI
Change-Id: I9c91a195cb42136422dec59e22d4a3164deaa8d9
2014-07-16 11:24:37 -07:00
Cmcmahon 0791e5c761 [BrowserTests] update Options test for new UI
Change-Id: If435620bc730a3b9d04918fcd4181e08d286e5a1
2014-07-16 11:12:46 -07:00
Alex Monk b9ad2fb406 Don't allow document save if we're already tearing down the surface
Otherwise you get "Uncaught TypeError: Cannot read property 'messages' of null"
if you press the save button late enough in the saving process. The bug refers
to a different error which I have not been able to reproduce.

Bug: 68073
Change-Id: Ia8fa325f1450329b6e0e4ee9af5302aa4857d637
2014-07-16 17:52:00 +01:00