wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-26 19:56:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Deprecate 'live' event in favor of 'setup' and 'teardown' in MW"

Browse source
This commit is contained in:
jenkins-bot 2014-07-22 23:36:38 +00:00 committed by Gerrit Code Review
parent a602c268d8 b6cc76d49a
commit dec052a4d3
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
modules/ve-mw/ce/nodes/ve.ce.MWReferenceNode.js
View file

@ -31,7 +31,8 @@ ve.ce.MWReferenceNode = function VeCeMWReferenceNode( model, config ) {
this.internalList = this.model.getDocument().internalList;
// Events
this.connect( this, { 'live': 'onLive' } );
this.connect( this, { 'setup': 'onSetup' } );
this.connect( this, { 'teardown': 'onTeardown' } );
// Initialization
this.update();
@ -54,17 +55,21 @@ ve.ce.MWReferenceNode.static.primaryCommandName = 'reference';
/* Methods */
/**
* Handle live events.
* Handle setup event.
* @method
*/
ve.ce.MWReferenceNode.prototype.onLive = function () {
ve.ce.MWReferenceNode.prototype.onSetup = function () {
this.internalList.connect( this, { 'update': 'onInternalListUpdate' } );
};
/**
* Handle teardown event.
* @method
*/
ve.ce.MWReferenceNode.prototype.onTeardown = function () {
// As we are listening to the internal list, we need to make sure
// we remove the listeners when this object is removed from the document
if ( this.live ) {
this.internalList.connect( this, { 'update': 'onInternalListUpdate' } );
} else {
this.internalList.disconnect( this );
}
this.internalList.disconnect( this );
};
/**