Go to file
Trevor Parscal 49ffef5a0f Close the save dialog on teardown only, not on save
Closing a dialog with specific data means closing it again with
potentially different data, while the dialog is already closing, means
someone wins and someone looses. Silently failing in this case is bad,
because if the first close call was a cancel, producing no side effects,
but the second close call would have produced some side effect, the side
effect would never occur.

The problem here really was that the save dialog needs to be closed
before we can destroy the surface so we can uphold the assumption that
hold and teardown processes are operating on an attached DOM.

The solution is to automatically close the save dialog on teardown,
rather than on save. Since save triggers teardown, this has and identical
user experience.

Bug: 68048
Change-Id: I669448739f168737d4eddd6496189a819ce894b1
2014-07-16 23:51:58 +00:00
.docs Update VE core submodule to master (f2277ea) 2014-07-14 23:24:45 +00:00
bin Provide a script to automatically list recent commits for pre-deployment review 2014-06-12 12:29:18 -07:00
build/tasks Use submodule for VisualEditor core 2013-12-20 09:18:41 +00:00
lib Update VE core submodule to master (8bb3848) 2014-07-16 23:48:07 +00:00
modules Close the save dialog on teardown only, not on save 2014-07-16 23:51:58 +00:00
.csslintrc
.gitignore
.gitmodules Use submodule for VisualEditor core 2013-12-20 09:18:41 +00:00
.gitreview
.jscsrc build: Update jscs and use new "wikimedia" preset 2014-06-26 17:00:15 +00:00
.jshintignore Move libraries to the lib/ directory 2013-12-19 23:02:52 +01:00
.jshintrc build: Update jscs and jshint 2014-05-15 16:52:34 +00:00
ApiVisualEditor.php Compress HTML data with deflate before POSTing 2014-06-24 17:39:03 +01:00
ApiVisualEditorEdit.php Merge "Update displaytitle on save (try #3)" 2014-07-01 21:18:54 +00:00
AUTHORS.txt Add more authors from git shortlog -s -n 2014-06-12 14:58:28 -07:00
betafeatures-icon-VisualEditor-language-ltr.svg Run node-svgo to crush all SVGs whilst retaining readibility 2014-07-01 16:58:05 -07:00
betafeatures-icon-VisualEditor-language-rtl.svg Run node-svgo to crush all SVGs whilst retaining readibility 2014-07-01 16:58:05 -07:00
betafeatures-icon-VisualEditor-ltr.svg Run node-svgo to crush all SVGs whilst retaining readibility 2014-07-01 16:58:05 -07:00
betafeatures-icon-VisualEditor-rtl.svg Run node-svgo to crush all SVGs whilst retaining readibility 2014-07-01 16:58:05 -07:00
CONTRIBUTING.md Fix dead links in README.md and CONTRIBUTING.md 2014-03-10 18:26:30 +01:00
Gruntfile.js build: Implement "git-status" task and run it in CI environment 2014-06-26 13:27:19 +02:00
LICENSE.txt Fix more copyright headers not updated to 2014 2014-01-13 15:08:24 +00:00
package.json build: Update jscs and use new "wikimedia" preset 2014-06-26 17:00:15 +00:00
README.md Fix dead links in README.md and CONTRIBUTING.md 2014-03-10 18:26:30 +01:00
VisualEditor.hooks.php Rename "test" folder to "tests" 2014-07-15 18:00:32 -07:00
VisualEditor.i18n.php Adding a comment explaining where the i18n messages are 2014-03-12 17:41:42 -07:00
VisualEditor.php Make a message dialog for cancelling VE 2014-07-16 00:07:24 +01:00
VisualEditorDataModule.php Moving citation tool code in API module into its own function 2014-05-09 08:56:40 +00:00

VisualEditor

VisualEditor provides a visual editor for wiki pages. It is written in JavaScript and runs in a web browser.

It uses the Parsoid parser to convert wikitext documents to annotated HTML which the VisualEditor is able to load, modify and emit back to Parsoid at which point it is converted back into wikitext.

For more information about these projects, check out the VisualEditor and Parsoid pages on mediawiki.

Developing and installing

For information on installing VisualEditor on a local wiki, please see https://www.mediawiki.org/wiki/Extension:VisualEditor

For information about running tests and contributing code to VisualEditor, see CONTRIBUTING.md. Patch submissions are reviewed and managed with Gerrit. There is also API documentation available for the VisualEditor.