Alex Monk
47cfc03d72
Close VE SET dialog when we deactivate
...
You can trigger deactivation by browsing back.
Bug: T132494
Change-Id: I8f66e22a745d84a3ca4b144c389c3ae654974789
2016-04-13 22:41:27 +01:00
Translation updater bot
a6974c0c81
Localisation updates from https://translatewiki.net .
...
Change-Id: Ieaf3137f26d599edcc19c42af321fded1e6d135e
2016-04-13 22:22:36 +02:00
Translation updater bot
716a7d64c8
Localisation updates from https://translatewiki.net .
...
Change-Id: I4409a473d8217eaf7c1fa93505422709f1172b6c
2016-04-12 22:59:48 +02:00
jenkins-bot
b779743208
Merge "[BrowserTest] Fix i18n files lookup"
2016-04-12 00:50:13 +00:00
Alex Monk
71990b4c44
Check wpSection before converting textbox contents for use in VE
...
Bug: T132309
Change-Id: I93f7706257f1f8ea59b7447f198a34439b17194d
2016-04-11 23:35:11 +01:00
Translation updater bot
5508609124
Localisation updates from https://translatewiki.net .
...
Change-Id: I29d8e85f5a87b73f8ee011e35f174078dbe60259
2016-04-11 22:40:29 +02:00
jenkins-bot
5dc1257507
Merge "More minor/watch checkbox state computation server-side"
2016-04-11 14:18:56 +00:00
jenkins-bot
9b9390585d
Merge "Adjust DOM and CSS so UI surface runs from top to bottom of page"
2016-04-11 14:03:29 +00:00
jenkins-bot
c2bb40285b
Merge "Add ?redirect=false to VE's RB /page/html/ requests"
2016-04-11 13:44:21 +00:00
Ed Sanders
f342dc01c3
Adjust DOM and CSS so UI surface runs from top to bottom of page
...
Place things like the page title and redirect link inside a new
container $originalContent, which is appended to the surface
when ready. Replace margins with padding in various places.
This will allow us to surface-height-matching sidebar for dialogs.
Change-Id: I60d80fb303bdaf93e9d121f62d534ee3a3056e59
2016-04-11 13:18:36 +01:00
Translation updater bot
b8f387afa7
Localisation updates from https://translatewiki.net .
...
Change-Id: Idece17af3a2cff864e7085f34b1b91b03a1d424e
2016-04-10 20:10:39 +02:00
Alex Monk
149dab8fc5
Add ?redirect=false to VE's RB /page/html/ requests
...
Untested.
Bug: T130757
Change-Id: I27570d3212bd41bf7da93608302dae04c364783f
2016-04-09 03:34:34 +01:00
Roan Kattouw
12eb41acff
More minor/watch checkbox state computation server-side
...
Following through on my threat from 72b0d2a19c
(November 2013).
Change-Id: I0daeef2a0373bbdb06627053e9d726d6fc20a3f6
2016-04-08 18:02:01 -07:00
jenkins-bot
c253bfbd5a
Merge "Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields"
2016-04-08 16:39:50 +00:00
Translation updater bot
a7b2938f0e
Localisation updates from https://translatewiki.net .
...
Change-Id: I67966efc3392f3d2133c0442aad699406bba0c00
2016-04-07 23:05:28 +02:00
Translation updater bot
f9487af27a
Localisation updates from https://translatewiki.net .
...
Change-Id: Iaded10f066d638b38240ff8572e4abb326d42302
2016-04-06 23:16:05 +02:00
Alex Monk
978224f2ec
Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields
...
* Use TitleInputWidget for wiki-page-name and wiki-template-name parameters
* Use UserInputWidget for wiki-user-name parameters
* Use a custom hacky CheckboxInputWidget child class for boolean parameters
* Borrow some ve.ui.MWExternalLinkAnnotationWidget.prototype.createInputWidget code for url parameters
* Use a TextInputWidget with multiline disabled for line parameters
Not dealt with in this commit, so fallback to existing behaviour:
* string
* number
* unknown
* content
* unbalanced-wikitext
* date
* wiki-file-name
Bug: T55613
Bug: T124734
Bug: T124736
Change-Id: If04944d64303d959e8dd605e75a175895932b788
Depends-On: I87699a93ca1b34c6d248456fcc060f584623d158
Depends-On: I5e97604f0fc24176d5e89899bf0505dc442a1a7e
2016-04-06 22:07:19 +01:00
Translation updater bot
5f58ba4bf5
Localisation updates from https://translatewiki.net .
...
Change-Id: I21bc9c165d900adb4223887846c898e702ac40df
2016-04-05 23:01:17 +02:00
jenkins-bot
597a095a64
Merge "Ensure veswitched is not set when we set wteswitched in the URI"
2016-04-05 15:51:33 +00:00
jenkins-bot
f9c95cd820
Merge "Fix up mw.libs.ve.EditingTabDialog.prototype.getActionProcess"
2016-04-05 15:41:28 +00:00
Alex Monk
373a19f1cc
Ensure veswitched is not set when we set wteswitched in the URI
...
veswitched and wteswitched together cannot result in any sane behaviour.
To reproduce:
* Open VE (while having multi-tab pref?), switch into WTE
* Make a change
* Switch into VE
Change-Id: I90e19169e3fab60ab876c8e4d349801309db262f
2016-04-05 01:27:37 +01:00
Alex Monk
f67b578c3f
Fix up mw.libs.ve.EditingTabDialog.prototype.getActionProcess
...
How did this ever work?
Ensure action is passed through and not just undefined, wait for change to go
through before refreshing.
Bug: T131818
Change-Id: I83b5695906044299d338e62e6c980c596d291765
2016-04-04 23:57:46 +01:00
Translation updater bot
2ff6fd5b9b
Localisation updates from https://translatewiki.net .
...
Change-Id: I39ddf914192ccdd0d41708303eb9fb153329c1ba
2016-04-04 22:13:20 +02:00
Antoine Musso
4a97e9585f
[BrowserTest] Fix i18n files lookup
...
The visual_editor_page used relative paths expecting the current
directory to be modules/ve-mw/tests/browser. Use absolute paths instead.
Change-Id: I8b1c4eddc2085ee80380f288bceb14c6feee0a60
2016-04-04 11:52:36 +02:00
Translation updater bot
286f489a6d
Localisation updates from https://translatewiki.net .
...
Change-Id: Iaef135e32858ff9562fba4a1fe56558fc13ba893
2016-04-03 23:25:01 +02:00
jenkins-bot
12aefcc213
Merge "After saving and setting HTML, set single-editor edit section handlers again"
2016-04-02 18:32:46 +00:00
Roan Kattouw
8e69dfa3b8
ArticleTarget: Correct comment explaining where setAssumeExistence( false ); is called
...
Change-Id: Ib883ea1fe57fe6cb3e182965a18eb3fb50246178
2016-04-02 20:28:44 +03:00
jenkins-bot
65ee77da50
Merge "MWExternalLinkAnnotation: Only match plain external <a>s with hrefs"
2016-04-02 16:05:36 +00:00
Ed Sanders
6fad9ecdee
MWExternalLinkAnnotation: Only match plain external <a>s with hrefs
...
We now accept non-Parsoid generated external links from paste,
so make sure they have href attributes otherwise they aren't
really external links and will throw exceptions later on.
Bug: T131430
Change-Id: Ifb565b1ce30cfe80ae72b17f6a9551ea40b36453
2016-04-02 18:51:56 +03:00
jenkins-bot
aa5f992159
Merge "MWExtensionNode#generateContents: Fix renderEmpty logic"
2016-04-02 09:31:07 +00:00
Tpt
8ccbb58ca6
MWExtensionNode#generateContents: Fix renderEmpty logic
...
This static attribute is not used anywhere so it should be safe
Change-Id: I633c521859b59614835344a4644560ac933c6028
2016-04-02 07:58:33 +00:00
Alex Monk
7788aece55
After saving and setting HTML, set single-editor edit section handlers again
...
Change-Id: I6e0962271e7e1460abbe82864b47fddc5bd7f235
2016-04-02 09:53:25 +03:00
Translation updater bot
6b4dcefcf2
Localisation updates from https://translatewiki.net .
...
Change-Id: I520bd24cc795d85ab66e2d623d77b7141d0188ab
2016-04-01 22:30:49 +02:00
Roan Kattouw
f6ba399137
Fix asynchronous loading of MWAlienExtensionNode renderings
...
ve.dm.MWExtensionNode#toDataElement calls storeGeneratedContents()
which prepopulates the cache, but because it was being called with
the wrong context, this.name was null and so the key we were storing
it under was different from the key we'd later be looking for.
Fixed by ensuring ve.dm.MWAlienExtensionNode#toDataElement preserves
context when calling its parent. Our static context hacks are tricky.
Change-Id: If859d861453067d7656a33a1767f6efc7bd9d323
2016-04-01 12:50:13 +03:00
Translation updater bot
1ad77ddf91
Localisation updates from https://translatewiki.net .
...
Change-Id: Ic552bb2a2a87252033cc9f6ab57ff9545f6686b5
2016-03-31 22:47:29 +02:00
jenkins-bot
2449ce203d
Merge "Use veaction=edit in URL instead of action=edit when we're using multiple tabs"
2016-03-31 15:42:40 +00:00
Translation updater bot
db5741d061
Localisation updates from https://translatewiki.net .
...
Change-Id: Ib60a84f5f2dd85ed5b2f9dd89b8eb64402e8a2d6
2016-03-30 22:43:22 +02:00
Alex Monk
4210c4bee0
Use veaction=edit in URL instead of action=edit when we're using multiple tabs
...
TODO: What about prefer-wt users switching from WTE?
Bug: T131064
Change-Id: I9aa701cbda3964decb8b1ee853c0a281567a0ccb
2016-03-30 02:54:01 +01:00
jenkins-bot
4dadaa677c
Merge "MWWikitextStringTransferHandler: Add test for autoGenerated=true"
2016-03-29 22:01:39 +00:00
jenkins-bot
f5f97adbe4
Merge "MWWikitextStringTransferHandler: Factor out body tag from response"
2016-03-29 21:42:09 +00:00
jenkins-bot
b44cee5557
Merge "MWWikitextStringTransferHandler: Remove data-parsoid from tests"
2016-03-29 21:39:07 +00:00
Translation updater bot
f753a46fa1
Localisation updates from https://translatewiki.net .
...
Change-Id: I840ba9e9d5c3eaed4837cabbd5fbf35c1079150e
2016-03-29 22:40:33 +02:00
Ed Sanders
18df6c3d47
MWWikitextStringTransferHandler: Add test for autoGenerated=true
...
Bug: T131153
Change-Id: I4922abe7978e1f04eb2276214c761622b44149c7
2016-03-29 19:57:45 +00:00
Ed Sanders
b51b512555
MWWikitextStringTransferHandler: Factor out body tag from response
...
Change-Id: Ic694d1099538d2c60900d490667f2175f7f3afb3
2016-03-29 19:57:36 +00:00
Ed Sanders
818931dd9e
MWWikitextStringTransferHandler: Remove data-parsoid from tests
...
It is ignored by VE, and isn't present in restbase responses.
Change-Id: Iaa2a6a66ba76ca0d63b4d6791ab8589191bce0f2
2016-03-29 19:57:26 +00:00
jenkins-bot
0242dedff9
Merge "Filter out auto-generated reference lists"
2016-03-29 19:37:35 +00:00
jenkins-bot
18533b47fa
Merge "Toolbar: Add tooltips to structure and insert groups"
2016-03-29 17:15:51 +00:00
jenkins-bot
29af9b54b6
Merge "MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more"
2016-03-29 16:52:31 +00:00
jenkins-bot
190c64ed69
Merge "Select tool when it's been closed by education tool popup button"
2016-03-29 16:42:38 +00:00
jenkins-bot
b9643881d9
Merge "Remove icon properties from windows"
2016-03-29 16:37:22 +00:00
Alex Monk
0760cd6974
Select tool when it's been closed by education tool popup button
...
Bug: T117273
Change-Id: I54b704b6663f7d862557e6524713259dee8765cc
2016-03-29 15:54:22 +01:00
Ed Sanders
9a347220bc
Target loading: Only parse oldid if it is non-null
...
This un-breaks MobileFrontend.
Change-Id: Ib1bce6b80abb004ff4ca26920759ef98f3cd1143
2016-03-29 12:57:00 +01:00
Ed Sanders
c516d897d2
Remove icon properties from windows
...
Windows stopped supporting icons a while ago.
Change-Id: I8a63152282a5968dcd17675330e31bd1ebe4b68b
2016-03-29 12:33:42 +01:00
Ed Sanders
1d8d1c2a64
Toolbar: Add tooltips to structure and insert groups
...
Bug: T131133
Change-Id: I927bf6f0d1de74b4ac8d16c3b5ce27720db322d4
2016-03-29 12:08:22 +01:00
Translation updater bot
d4d1f10b95
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifdc4b011bcb895ae3fa39a1fbe31b1640d1e56e4
2016-03-28 22:46:52 +02:00
James D. Forrester
a6477fb960
MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more
...
Change-Id: Ib2f63d1626d8286c7dfd74227d09046a7d2af509
2016-03-28 19:53:08 +00:00
jenkins-bot
ff61173f90
Merge "MWLinkAnnotationInspector: select entire link when switching tabs"
2016-03-28 19:22:35 +00:00
Ed Sanders
681250dd5e
Filter out auto-generated reference lists
...
Bug: T101553
Bug: T127664
Change-Id: Idc8c6f30ccdd5eaf76a3f7c1b923d8656ca36413
Depends-On: I24250845e97acb4b7de9c495cb46dbd28fc8817e
2016-03-28 17:23:42 +00:00
David Lynch
d33f5969ad
MWLinkAnnotationInspector: select entire link when switching tabs
...
Bug: T129650
Change-Id: I4ca445f2c43438c36ece23245660b63f2a48b722
2016-03-28 11:38:45 -05:00
James D. Forrester
0a23ec716d
i18n: Drop another two references to the wikitext editor
...
Change-Id: I89b727e880f40d6e82fb584beb4647aed6134e90
2016-03-28 08:47:20 -07:00
Translation updater bot
f239e17a1e
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie585e9b5dd0251d35e90646f0ff79cc76cf66da8
2016-03-27 21:25:48 +02:00
Thalia
003e02efaa
MWAceEditorWidget: Update maxRows and minRows if minRows is changed
...
This was being done correctly in initialize, but not in setMinRows.
Bug: T131009
Change-Id: I57c771720c59ca1d75f0b9bc14e7c834237019d5
2016-03-27 17:42:11 +00:00
jenkins-bot
ff65a71773
Merge "Template Dialog: pushPending while the dialog is closing"
2016-03-26 03:13:42 +00:00
jenkins-bot
068bafd9df
Merge "ArticleTarget: Don't assume an explicit oldid is old; check against current"
2016-03-26 00:49:58 +00:00
Alex Monk
680e464e94
ArticleTarget: Don't assume an explicit oldid is old; check against current
...
Bug: T130810
Change-Id: I3d5b748da37a0a059f282f97dd0d68d1846e2553
2016-03-25 17:37:02 -07:00
jenkins-bot
35ea4b3e4e
Merge "Don't strip namespace from text that we replace firstHeading with"
2016-03-25 22:43:41 +00:00
Alex Monk
b1aebf0b48
Don't strip namespace from text that we replace firstHeading with
...
wgTitle is basically just $title->getText()
wgPageName is $title->getPrefixedDBkey()
So we need to take wgPageName and run getPrefixedText (difference is underscores
get replaced by spaces)
Change-Id: Ib99f0d20f1ba99338f80bbbf39cffd544887c3fa
2016-03-25 04:45:09 +00:00
Translation updater bot
8bf7d4ba07
Localisation updates from https://translatewiki.net .
...
Change-Id: Ief4cec942df98bef1b43038fa14e0cb6403ea454
2016-03-24 22:40:13 +01:00
David Lynch
0268e74a7f
Template Dialog: pushPending while the dialog is closing
...
Double-clicking the "insert" button would double-insert the template. Counting
the close as a pending action avoids that.
Bug: T129725
Change-Id: I41af7c051fd54004cecd563d7a6cf8fdb452840f
2016-03-24 11:33:00 -05:00
Translation updater bot
3028f4f2d6
Localisation updates from https://translatewiki.net .
...
Change-Id: I7715d2d33b21e1a9d142a2be00a032fe83de4f75
2016-03-23 22:25:43 +01:00
jenkins-bot
9b9ace9d03
Merge "Rename startSave -> onSaveDialogSave"
2016-03-23 19:48:06 +00:00
jenkins-bot
52c862b5af
Merge "Make data-mw/body.html attribute comparable"
2016-03-23 19:20:40 +00:00
Ed Sanders
5e4ad90845
Rename startSave -> onSaveDialogSave
...
Factor out actual startSave into new startSave method.
Change-Id: I73edb5021903f04aa197ace2a2afa3aa3a5ddac6
2016-03-23 11:14:06 +00:00
Ed Sanders
6a159001ab
Make data-mw/body.html attribute comparable
...
Change-Id: Ie23c5816a18f4da84c3d40c13a8c048710389f4b
2016-03-23 11:03:53 +00:00
Alex Monk
2063025237
Don't change focus to VE surface if we're opening the SET dialog
...
Bug: T130552
Change-Id: Idc4639bb3f51690a827bdbdb0419e9303dd39a1b
2016-03-23 01:08:32 +00:00
Translation updater bot
0f6bdb9071
Localisation updates from https://translatewiki.net .
...
Change-Id: I994551c7973f274b4791d23c89fd808038df14da
2016-03-22 22:34:47 +01:00
Ed Sanders
fd3683e414
Update VE core submodule to master (d1ce123)
...
New changes:
6cf8864 Follow-up eb97c1f: Fix build for added language 'inh'
d1ce123 SpecialCharacterDialog: Use getReadyProcess promise to wait for char list
Local changes:
* SpecialCharacterDialog: Defer loading of character list.
Saves ~40k for most users who never use it.
Change-Id: I74b30fee96e1ae4463ed28c19bef4b515330220e
Depends-On: I45dc9f788aa5bd702b91ffd9f63b05b1f4760691
2016-03-22 09:15:23 -07:00
James D. Forrester
7df0e7589e
Update VE core submodule to master (eb97c1f)
...
New changes:
e661245 Localisation updates from https://translatewiki.net .
d0bac53 ElementLinearData: Add test for sanitize conversions
53988e4 ElementLinearData: Test blacklist unwrapping
8593098 ve.dm.Model: Remove unused, untested method 'hasAttributes'
6247dd2 ce.Surface: Add tests for table strip delete
bee1851 ce.Surface: Add larger table strip-delete test
42d39e7 ce.Surface: Test table navigation with enter/escape/tab/shift-tab
5d248f9 Remove TableCaptionCommand
a86ad04 PreviewElement: Check node is a GCN, and always return a boolean
b518839 Localisation updates from https://translatewiki.net .
8834e9c ce.Surface: Allow any key code in the key handler tests
6b3ea6a ce.Surface: Linear arrow tests for block node
026999d Localisation updates from https://translatewiki.net .
eb97c1f Localisation updates from https://translatewiki.net .
Change-Id: Ic5853116d97623316d9a6bbacda2ecab9e4b49d5
2016-03-22 15:12:36 +00:00
Translation updater bot
b6662a697d
Localisation updates from https://translatewiki.net .
...
Change-Id: I111db7bda332fc853e50d2d5cd029389a01676e8
2016-03-21 23:37:06 +01:00
Translation updater bot
eed6125ef2
Localisation updates from https://translatewiki.net .
...
Change-Id: I197104b10bb7aa062030a6cf22975283dbe42d28
2016-03-20 22:43:49 +01:00
Translation updater bot
c450fdd332
Localisation updates from https://translatewiki.net .
...
Change-Id: I2425ab6952f0890671132342acfa0308cf286882
2016-03-19 22:55:27 +01:00
Translation updater bot
c37a2d11f7
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia9b65fcfe6117d2075483bd130900c51b787eddc
2016-03-18 22:45:18 +01:00
jenkins-bot
4e4684e7d0
Merge "Show redirect target inside target"
2016-03-17 22:54:39 +00:00
Translation updater bot
d036f04573
Localisation updates from https://translatewiki.net .
...
Change-Id: I30e95352b17b75c8eb8dba54a4007238c28b1c63
2016-03-17 23:23:48 +01:00
Ed Sanders
b7d25d92bc
Detect the type of plain pasted links
...
Using the same logic we used for converting pasted URLs, detect
internal links by matching their base.
Currently link pasting is still disabled in the VE target, but
has been enabled elsewhere (Flow).
Change-Id: Iebd61abbe1fe82fd18d129e1dbc815ca75f44e87
2016-03-17 19:30:13 +00:00
jenkins-bot
d5ef085b3e
Merge "Link pasting: Match RDFa-less links as external"
2016-03-17 17:45:52 +00:00
Ed Sanders
5e6cbc187c
Link pasting: Match RDFa-less links as external
...
Now that some targets support link pasting (Flow) we need to
make sure that pasted links match to an allowed type ('link/mwExternal')
instead of plain 'link' annotations which should never exist
in an MW document.
In a later commit we should auto-detect internal links.
Change-Id: I7faae834aa6e730c3cf93a691331a05fd0fe3d5c
2016-03-17 17:18:41 +00:00
jenkins-bot
1c27e5d51a
Merge "In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId"
2016-03-17 15:39:12 +00:00
jenkins-bot
33c9055fdc
Merge "Reload page after user selects multi-tab option of SET dialog"
2016-03-17 15:39:09 +00:00
Alex Monk
3288d4e3f9
Show redirect target inside target
...
Bug: T63861
Depends-On: I71d3d415fe918e8b0a090860cad9271092b1bd7e
Change-Id: I5a138b95e04773885ca9ee548026729805eb11f0
2016-03-17 15:21:06 +00:00
Translation updater bot
445a830d52
Localisation updates from https://translatewiki.net .
...
Change-Id: I2764438c78e674d492157f55fb15ae82ed114b36
2016-03-15 23:06:07 +01:00
Ed Sanders
dec9aa09e4
Use keyboard icon for keyboard help tool
...
Change-Id: Id5e5097dfcdb5e3be2b21c89886857cb379997e6
2016-03-15 17:28:48 +00:00
Alex Monk
02953f5d64
Suppress meta dialog on refresh pages if we want to show SET dialog
...
Bug: T129819
Change-Id: I1176d06e5a5f56f01528acd7d099c8be9d317e51
2016-03-15 08:10:46 +00:00
Translation updater bot
af64cf7b12
Localisation updates from https://translatewiki.net .
...
Change-Id: I85827c3e9262adf7bb6191ff68de688f744b613a
2016-03-14 22:55:30 +01:00
jenkins-bot
53d3c62d46
Merge "CommandHelpDialog: Inherit non-corruptively"
2016-03-14 20:28:56 +00:00
Ed Sanders
f5873ac1db
CommandHelpDialog: Inherit non-corruptively
...
Change-Id: Ieb497eebe930e58a02552eb9d4305280c91c92c2
2016-03-14 20:03:52 +00:00
Ed Sanders
5d5d5419c6
AceEditorWidget: Use namespaced 'require'
...
The un-namespaced version will soon be removed to fix RL issues.
Bug: T127643
Change-Id: Iaf4ed23d88cb955b8f8f61725f9effa6180de5bf
2016-03-14 16:56:16 +00:00
Željko Filipin
63eb2a2f46
[BrowserTest] Increase the time Selenium waits for VisualEditor to load
...
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.
Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
2016-03-14 13:00:17 +01:00
jenkins-bot
110c6eb057
Merge "[BrowserTest] Disable failing language screenshot scenario"
2016-03-14 11:33:53 +00:00
jenkins-bot
0cdf4393ed
Merge "Prefer error *code* when logging unknown errors"
2016-03-14 01:01:48 +00:00
jenkins-bot
3a1f6a34c8
Merge "Log readonly code for readonly errors"
2016-03-14 01:00:47 +00:00
Alex Monk
612e43dc08
Prefer error *code* when logging unknown errors
...
See also I4a5bac24
Change-Id: I62fda9dadd24704f5930b30a2f8ad4d4a9e729cb
2016-03-14 00:27:42 +00:00
Translation updater bot
004247822d
Localisation updates from https://translatewiki.net .
...
Change-Id: I18e35f520e9b8dde3c96e6b2c3b740d1fb48c294
2016-03-13 22:57:53 +01:00
jenkins-bot
1a0733c4f2
Merge "MWSaveDialog: Fix vertical alignment"
2016-03-13 11:43:17 +00:00
Translation updater bot
368953b808
Localisation updates from https://translatewiki.net .
...
Change-Id: I1c34348e0ce6227d6a3e84a969271563b0e8a6d5
2016-03-12 21:14:25 +01:00
Alex Monk
22bf016a84
In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId
...
There's probably more to this bug but I think we should still correct this
Bug: T125437
Change-Id: Ib32d1e69b2500578b5dc160c0c2d7481f5577ebb
2016-03-12 04:46:54 +00:00
Translation updater bot
7c8a2207d3
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifefb57f56a762c7fcb5cab0258d018be0e7c10eb
2016-03-11 22:18:35 +01:00
Ed Sanders
da9aff2421
MWSaveDialog: Fix vertical alignment
...
Change-Id: Ifb62375da6c872a3a4ef783e479a5476ca318b32
2016-03-11 17:37:01 +00:00
Alex Monk
d1d4839f8f
Log readonly code for readonly errors
...
I thought I did this yesterday
Change-Id: Icd2cf8fdf4263cab335a2ddfa53ab0585153dfb4
2016-03-11 17:33:57 +00:00
Alex Monk
3807a918f9
Reload page after user selects multi-tab option of SET dialog
...
Bug: T129510
Change-Id: I3fcac175f18d8159e6a5c4084668264d4705970c
2016-03-11 05:39:29 +00:00
Translation updater bot
55a6cd08b2
Merge "Localisation updates from https://translatewiki.net ."
2016-03-10 21:33:52 +00:00
Translation updater bot
3aac2043a4
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia3db1d0b33d4bdbde66452bcf33a7b0b0e4da5bb
2016-03-10 22:31:26 +01:00
jenkins-bot
d6ec1ed86f
Merge "Fix logging of event_action.saveFailure.message for responseUnknown"
2016-03-10 21:22:37 +00:00
jenkins-bot
ad7c364725
Merge "Better handling of read-only mode"
2016-03-10 21:22:34 +00:00
Alex Monk
0a6f6e1bbd
Fix logging of event_action.saveFailure.message for responseUnknown
...
Change-Id: Ic8d3066d8f6ccf8bc4a1001fd4d406b313915e82
2016-03-10 21:03:25 +00:00
Alex Monk
d2a9aefba7
Better handling of read-only mode
...
* Don't just fail to load, action=visualeditor itself should not write to the DB
(we have action=visualeditoredit for that)
* Send notice to the client in the usual way
* Handle read only errors on save, log as unknown
This won't let you review changes because that uses visualeditoredit
Bug: T129501
Change-Id: Id78c06b031423e47a7ddf94ec615b6d6975309d3
2016-03-10 21:02:52 +00:00
jenkins-bot
3eaaf57847
Merge "Suppress welcome dialog this time if we're showing the SET pref dialog"
2016-03-10 20:38:39 +00:00
Alex Monk
4462f2539a
Suppress welcome dialog this time if we're showing the SET pref dialog
...
Bug: T129200
Change-Id: Iaa6d80df930cfcbd243efd31437cb8707da35c06
2016-03-10 17:54:15 +00:00
Željko Filipin
43e9c8714f
[BrowserTest] Disable failing language screenshot scenario
...
VisualEditor_Insert_Menu scenario fails with `Original image height is
too small! (ChunkyPNG::OutOfBounds)`.
Bug: T119482
Change-Id: I30c3a9757c5754a40921fce5225b73897eed865b
2016-03-10 15:06:56 +01:00
Translation updater bot
d36a099939
Localisation updates from https://translatewiki.net .
...
Change-Id: I32293b4f2532d15e65b71f09e53ac9c2e8817356
2016-03-09 22:48:24 +01:00
jenkins-bot
2e89f4f658
Merge "[BrowserTest] Disable failing language screenshots"
2016-03-09 17:32:57 +00:00
jenkins-bot
67fb8dd07f
Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError"
2016-03-09 17:31:27 +00:00
Timo Tijhof
cf1d7c0dab
mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined"
...
Regression from 863a2c2974
.
Sometimes when clicking "Switch to source mode" in the toolbar this
error is thrown and the interface freezes because setEditorPreference()
only returns a promise if the value is different.
> Uncaught TypeError: Cannot read property 'done' of undefined
> - ve.init.mw.DesktopArticleTarget.switchToWikitextEditor
Change-Id: Ie59f06a8ed9af9c4fb8199b013c06992d0c4f700
2016-03-08 23:13:11 +00:00
Translation updater bot
d8a9a11ca7
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia668efdeff27d984848c2bca823bf41d370706f9
2016-03-08 22:46:51 +01:00
Ed Sanders
d5e594b9f6
Link inspector: Remove premature call to onLinkTypeIndexSet
...
This causes the inspector to take focus early (line 291) on
first load, and is not necessary as this method fires when
needed anyway.
Bug: T129228
Change-Id: Ia69f76b68e89daf5cb01449c40e71de4ec32d400
2016-03-08 16:54:09 +00:00
jenkins-bot
7261cf5364
Merge "Link inspector: make height consistent"
2016-03-08 16:50:02 +00:00
Ed Sanders
7f31507e12
Link inspector: make height consistent
...
Make the DOM order sensible so we don't have to
use SearchWidget's position:absolute hacks.
Bug: T129173
Change-Id: I3517e0e0cfe2ab0eee4bed7390e41710d3140eb0
2016-03-08 10:26:31 +00:00
James D. Forrester
80139533ab
i18n: Don't refer to the name of the tab in the beta notice given it changes
...
Change-Id: I9beb322aeabece0df483271b33dbaa41f5da732a
2016-03-07 16:58:32 -08:00
James D. Forrester
b247ffd7bd
i18n: Explain to returning users that their preferences are mutable
...
Change-Id: I8a47725d7271af54b30f2130e97b08edec0f0b59
2016-03-07 16:56:13 -08:00
James D. Forrester
9a6650ae1f
i18n: Relabel the SET preference and dialog to 'mode'
...
Change-Id: Id876f4ba102800237cbc4a671d4db9a26f7f116d
2016-03-07 15:51:19 -08:00
jenkins-bot
8d7baccd5f
Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist"
2016-03-07 23:28:58 +00:00
jenkins-bot
7a5f34fac3
Merge "Education popup: Also handle clicks on dots"
2016-03-07 23:28:55 +00:00
jenkins-bot
39f3cfa4a7
Merge "Keep summary and checkbox selections when swtiching WTE->VE"
2016-03-07 23:17:08 +00:00
jenkins-bot
075f569e51
Merge "Update ArticleTarget for new API token handling"
2016-03-07 23:14:32 +00:00
jenkins-bot
6ed2d23b13
Merge "Don't give the user the option to discard changes when changing editor"
2016-03-07 23:14:29 +00:00
jenkins-bot
15f8efed70
Merge "DesktopArticleTarget.init#getLastEditor: Check values for validity"
2016-03-07 23:14:26 +00:00
James D. Forrester
79d1f92b42
DesktopArticleTarget: Add Edge and MSIE to whitelist
...
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
2016-03-07 14:58:10 -08:00
jenkins-bot
4d34f9ad75
Merge "Follow-up I65d96627: Remember the user's preference in WikiEditor too"
2016-03-07 22:31:54 +00:00
James D. Forrester
d8eb68d7b6
Don't give the user the option to discard changes when changing editor
...
Bug: T128585
Change-Id: I02f31e46ae7b2dc7505ed55fc56cd00f538a90e3
2016-03-07 13:39:32 -08:00
Translation updater bot
98052e165d
Localisation updates from https://translatewiki.net .
...
Change-Id: I1e160b1149c6f0a5abb31ad51ba0a099de151a1f
2016-03-07 22:27:34 +01:00
James D. Forrester
b0407d840d
Follow-up I65d96627: Remember the user's preference in WikiEditor too
...
Oh dear.
Bug: T129130
Change-Id: I12481ded12f99ab1ba59dbd403c1eed038235fd9
2016-03-07 13:03:35 -08:00
jenkins-bot
789979f223
Merge "Try to fix handling of empty document on WTE->VE switch"
2016-03-07 19:48:22 +00:00
James D. Forrester
302aeefd85
DesktopArticleTarget.init#getLastEditor: Check values for validity
...
Change-Id: I23e0884a97b3689dd42c3df11a6311cd0601c348
2016-03-07 11:27:23 -08:00
jenkins-bot
fe19bfb0af
Merge "Use iconWhenInvisible for alien extension nodes"
2016-03-07 18:34:38 +00:00
Ed Sanders
bbf86a6768
Use iconWhenInvisible for alien extension nodes
...
Change-Id: I0bc9bfd040685855402f705f46973e36c42dc0db
2016-03-07 18:15:45 +00:00
jenkins-bot
c930ac2779
Merge "Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry"
2016-03-07 16:32:13 +00:00
Translation updater bot
4dd9110c18
Localisation updates from https://translatewiki.net .
...
Change-Id: I894adeef0ad09824fad0d3fff544ced1f7f3b1ae
2016-03-06 22:18:45 +01:00
Ed Sanders
5cc10a810a
Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry
...
This allows extensions to register their own rules for detecting wikitext,
e.g. matching '<ref>'.
Bonus: Strip the autogenerated <references/> tag which
gets inserted when converting a <ref>.
Bug: T128805
Change-Id: I7a38db45d25e86ff3f3f6199aa04425ec98f7cc4
2016-03-05 22:47:00 +00:00
Translation updater bot
bcb8aed482
Localisation updates from https://translatewiki.net .
...
Change-Id: Icffb9dc8b7f78d2debad38046ba42ea678b969ae
2016-03-05 23:01:12 +01:00
Ricordisamoa
993015e03b
Update ArticleTarget for new API token handling
...
action=query&prop=info was being used because it can be combined
with action=query&meta=userinfo, while action=tokens cannot.
However, since MediaWiki 1.24 the 'intoken' parameter of
action=query&prop=info is deprecated, while the preferred way of
retrieving tokens is action=query&meta=tokens which not only can
be combined with action=query&meta=userinfo but also spares the
need of dealing with page ids.
Change-Id: I5ded3c303ede20514eeb2840715fe240b3b2c7e1
2016-03-05 14:44:07 +01:00
jenkins-bot
ea11c33e6d
Merge "Handle API errors when refetching the edit token"
2016-03-05 02:16:32 +00:00
Roan Kattouw
6322be2e07
Handle API errors when refetching the edit token
...
This can happen when the user gets logged out on a private wiki.
We get a badtoken error, so we try to refetch the token, which
itself returns an error. Token refetches didn't have error handling
at all and got the save dialog stuck in the pending state.
We can't offer the user to proceed with a different identity here,
because we encountered an error while trying to figure out what their
current identity is. The best we can do is encourage them to
log back in in a different tab.
Bug: T128934
Change-Id: I17d4452f688ec22631dbd12af223731635004d66
2016-03-04 18:06:33 -08:00
jenkins-bot
074885d7cf
Merge "Follow-up 2c24efae
: fix typo in event name for unknown save errors"
2016-03-05 02:01:57 +00:00
Roan Kattouw
84d534997e
Follow-up 2c24efae
: fix typo in event name for unknown save errors
...
This probably means we stopped logging unknown save errors
back in August.
Change-Id: I4a5bac244a469e73643e8a7d978d9212dd838fb0
2016-03-04 17:31:40 -08:00
Translation updater bot
0d94d8312d
Localisation updates from https://translatewiki.net .
...
Change-Id: I92baebf577ce098877cff730f2ff8de4974f79b2
2016-03-04 22:56:47 +01:00
Željko Filipin
dc3944726a
[BrowserTest] Disable failing language screenshots
...
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
2016-03-04 15:54:13 +01:00
Alex Monk
dde45949a3
Try to fix handling of empty document on WTE->VE switch
...
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
2016-03-04 02:05:41 +00:00
Ed Sanders
67c207a6f5
Use abstract target widget creation
...
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
2016-03-03 11:49:44 -08:00
Ed Sanders
d64436cc0c
Use new surface executeCommand method
...
Change-Id: I84c718d9da4b7dd0627ba37d9c29c3a25cc5d73e
Depends-On: Id975ea9da43654cd9991a302b49a9fb32782078e
2016-03-03 11:49:44 -08:00
Ed Sanders
62d16e5a8a
Update VE core submodule to master (ac24b50)
...
New changes:
0b7e689 FindAndReplaceDialog: don't use tabindex
17b10a5 Localisation updates from https://translatewiki.net .
a4133e4 [BREAKING CHANGE] Make whitespaceHtmlCharacters a real static property
Local changes:
* MWEntityNode: Fix lookup of whitespaceHtmlCharacters
Property is now in 'static', and use registry to look up
TextNode by symbolic name.
Change-Id: Ied8c0c6feb69141c7c53fc4cc790774dee2cb63c
Depends-On: I7537b46a9fd58dfb2bd18dc4ed469aa221b96e86
2016-03-03 08:13:33 -08:00
Ed Sanders
115bf4b3d2
CategoryWidget: Remove reorder event fix after upstream fix
...
Change-Id: I9088c931433b0824f72b4c77d0fd05cb062068f7
Depends-On: I67945db3652b0edb24b490089b8ea5a43f0b29d0
2016-03-03 15:53:49 +00:00
Željko Filipin
8e0e40d5cc
[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError
...
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.
Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
2016-03-03 14:58:14 +00:00
jenkins-bot
659b9c3576
Merge "[BrowserTest] Fix ve.init is undefined
and ve.init.target is undefined
error messages"
2016-03-02 23:33:32 +00:00
Translation updater bot
61cda9824f
Localisation updates from https://translatewiki.net .
...
Change-Id: Ife76752d154e4b595a570e8c8fefed114362dc9f
2016-03-02 23:40:57 +01:00
Alex Monk
a3f77d9479
Education popup: Also handle clicks on dots
...
Bug: T128440
Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
2016-03-02 21:48:05 +00:00
Alex Monk
4ed6fd4010
Change Accept header a bit
...
Per post-merge commit on I77af4b58 by Subbu
Bug: T128233
Change-Id: I30c4c1ad5b68e5b8a006d7a6c7bcbaac7e2eb164
2016-03-02 15:37:37 +00:00
Željko Filipin
301b152ec8
[BrowserTest] Fix ve.init is undefined
and ve.init.target is undefined
error messages
...
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.
Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
2016-03-02 13:50:44 +01:00
Alex Monk
21334a0fa8
Keep summary and checkbox selections when swtiching WTE->VE
...
Bug: T128529
Change-Id: I8a7deac1c4d9390c1db7d78c3e0a11d927ef127b
2016-03-02 11:55:50 +00:00
Ed Sanders
d94d98ebfe
ArticleTarget: Update documentation
...
'onReady' no longer exists
Change-Id: I6fbcf619ba471f69380a64ba02994bd6ef0ca246
2016-03-01 22:03:07 +00:00
jenkins-bot
7d1ddae652
Merge "MWTemplateSpecModel: Use namespace constant"
2016-03-01 21:56:51 +00:00
jenkins-bot
1619ca17aa
Merge "MWTemplatePage: Don't assume template is the template namespace"
2016-03-01 21:51:19 +00:00
Ed Sanders
1e800f2fdf
MWTemplateSpecModel: Use namespace constant
...
Change-Id: I4404ee726550ca9aa9322720736f6f3778278df7
2016-03-01 21:41:10 +00:00
Ed Sanders
5b17cbca67
MWTemplatePage: Don't assume template is the template namespace
...
Content can be transcluded from any namespace using '{{:'.
Bug: T128333
Change-Id: Ifa076960958d1e72f302c5bfd5d896427a0e721f
2016-03-01 13:40:38 -08:00
Translation updater bot
eceb548e6c
Localisation updates from https://translatewiki.net .
...
Change-Id: Id1453f111870ee703f552fa407dab76b19d786f5
2016-03-01 22:04:45 +01:00
jenkins-bot
a0caedc6d9
Merge "API: Send Accept: header to RESTbase"
2016-03-01 03:24:45 +00:00
Alex Monk
2f135e9590
API: Send Accept: header to RESTbase
...
Bug: T128233
Change-Id: I77af4b58e5469a898063a3f838802e4f5769514b
2016-03-01 01:14:02 +00:00
Alex Monk
d46c5e9f91
Fix WTE->VE switching in prefer-wt SET mode
...
Bug: T128402
Change-Id: I56af672f2334214f048a4bbfe2f9fab891832792
2016-02-29 23:46:11 +00:00
David Lynch
7486f74c6f
MWMediaDialog: Only cache relevant information
...
Trim the cached image data from the media dialog down so that it only caches
the same information that would have been fetched for a non-uploaded image.
Consistency!
Bug: T126081
Change-Id: I0f057c111b66f29c6360e27f97256384f5320b75
2016-02-29 10:16:34 -06:00
jenkins-bot
e39d8a744b
Merge "Show welcome dialog on mobile too"
2016-02-29 03:02:03 +00:00
jenkins-bot
517bb92a79
Merge "Give a useful message in the temporary blank edit screen"
2016-02-29 02:56:12 +00:00
Translation updater bot
7546362fa9
Localisation updates from https://translatewiki.net .
...
Change-Id: I7bade8021975fc1c3e2426211e6805a913f07891
2016-02-28 22:00:32 +01:00
jenkins-bot
70a9cee5f3
Merge "Update VE core submodule to master (0371bbe)"
2016-02-28 01:12:55 +00:00
jenkins-bot
03448253b3
Merge "Revert "Compress PNGs with zopflipng""
2016-02-28 00:29:30 +00:00
Legoktm
7ebac23f86
Revert "Compress PNGs with zopflipng"
...
This reverts commit cbb7831938
.
Change-Id: Ide4880a4a980847bb14cc5880662a4d2142581b8
2016-02-28 00:07:50 +00:00
Alex Monk
ade0862db1
Give a useful message in the temporary blank edit screen
...
Bug: T128028
Change-Id: Ife0a9de96965a9848f362696fc403708fd344825
2016-02-27 21:42:10 +00:00
Translation updater bot
e7ad07513a
Localisation updates from https://translatewiki.net .
...
Change-Id: I88bf6d9f401bfbeab5e256a3b6169541ce8ac0eb
2016-02-27 21:59:35 +01:00
James D. Forrester
ab4d3e956b
Update VE core submodule to master (0371bbe)
...
New changes:
0371bbe [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern
Local changes: Use new VisualEditorSupportCheck pattern
Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
2016-02-26 12:26:56 -08:00
Ed Sanders
34d607d546
EducationPopupTool: Use vendor prefixes for animation
...
Bug: T128133
Change-Id: Ic061b50e1ed68ea35ac0ccbefbcb5252f917d35f
2016-02-26 15:34:06 +00:00
Ed Sanders
8f028813e5
CategoryWidget: Update to work with new DraggableGroupElement
...
Change-Id: Iefac99dba0e6b8ed3eaaa1d5f1d92e402e3cf2db
2016-02-25 16:07:50 -08:00
Alex Monk
ced27f348f
Show welcome dialog on mobile too
...
Bug: T112599
Change-Id: Ie04aab468c80dabc84e1386e7529138e1101450e
2016-02-25 22:03:00 +00:00
Translation updater bot
cef228ec1d
Localisation updates from https://translatewiki.net .
...
Change-Id: I8a8e0b9b879d18d8011821e49dc8c23624652a38
2016-02-25 22:22:09 +01:00
jenkins-bot
7bef4c9a20
Merge "Warn for empty summary when edit section used"
2016-02-25 18:56:57 +00:00
Translation updater bot
48a2404923
Localisation updates from https://translatewiki.net .
...
Change-Id: I0a5b177af81d7f05a86b18f5089a76545b2b8860
2016-02-24 22:03:55 +01:00
jenkins-bot
222a5361ba
Merge "[BrowserTest] Fix ve.init is undefined
error messages in Selenium tests"
2016-02-24 17:56:57 +00:00
jenkins-bot
79d8849b49
Merge "Make surface measurable while activating"
2016-02-24 01:33:47 +00:00
Translation updater bot
4fdef459ae
Localisation updates from https://translatewiki.net .
...
Change-Id: I32522ae9e647712d6256174fade8e0314808b739
2016-02-23 22:35:50 +01:00
Ed Sanders
229a088f34
Make surface measurable while activating
...
If the surface is display:none then $.width always
returns 0, which breaks features like FocusableNode's
invisible icon.
Bug: T127319
Change-Id: Ib157ffaeb56fca2bdc26868d830c4bf8feafa2a8
2016-02-23 17:05:09 +00:00
wctaiwan
5da37932a2
Warn for empty summary when edit section used
...
Warn the user about an empty edit summary when the "edit section"
link is used to trigger VE.
Re-does Ic7b456ca a different way.
Bug: T114857
Change-Id: I319c9c5bed47140a81eb409d490c9f82b89a49fe
2016-02-23 00:34:12 +00:00
jenkins-bot
74b2489276
Merge "Link to file description pages in media dialog"
2016-02-22 21:07:43 +00:00
Translation updater bot
ed26366723
Localisation updates from https://translatewiki.net .
...
Change-Id: Ib209a100469a77418cc66174d69bc6955101a7a3
2016-02-22 21:42:37 +01:00