Commit graph

7183 commits

Author SHA1 Message Date
bsitu d3d99772b9 Replace EchoBackend with mappers and gateway
* Get rid of EchoBackend by separating responsibilities into smaller objects

* Move main fetchNotification logic from API to a more appropriate place

* Add more unit testing coverage

Change-Id: I42f4d7566543332588431c21c220c0d64d026b70
2014-07-31 10:29:52 -07:00
jenkins-bot eb774144b1 Merge "Revert "New hooks for external integration to notification intiialization"" 2014-07-30 21:58:40 +00:00
Translation updater bot d553edad0f Localisation updates from https://translatewiki.net.
Change-Id: I36d0a4f1830920d635f62c0d0f9795276bd0a51d
2014-07-29 21:54:29 +02:00
Antoine Musso 0dbff3bf16 Clear up cached Main_page title in test
In Echo tests/NotificationFormatterTest.php there is a test that ends up
invoking the Linker to create full URL for Main_page and pass it a
fragment.

Title::newMainPage() is really Title::newFromText('Main_Page') which is
cached.  Whenever the fragment is set, it stuck in the cache entry and
later call to Title::newMainPage() yields a Title object which has the
fragment.

That cause Scribunto tests (at least) to fail when Echo tests are run
before it because Scribunto tests expect a Main_Page title without a
fragment.

The ugly workaround is to have the Echo test to reset the fragment.

We could clear up the Title cache between tests though.

Bug: 68646
Change-Id: I625492fc8bf0dbd6e10275c3a728f5c1f85768c8
2014-07-29 13:56:28 +02:00
Translation updater bot 82b90a6c0e Localisation updates from https://translatewiki.net.
Change-Id: I6291322e36630c0980fdb2a0311cc423b8c80dff
2014-07-28 21:21:50 +02:00
Translation updater bot a31d3f6625 Localisation updates from https://translatewiki.net.
Change-Id: If2754dcfd87d7f4f38ef1ea5a279ee2eb308297d
2014-07-27 22:18:57 +02:00
Translation updater bot fc18ad5575 Localisation updates from https://translatewiki.net.
Change-Id: Ie5178410bfc26ecd14200151a327d79653f3877c
2014-07-26 21:47:34 +02:00
Legoktm a09d4cbaf5 Revert "New hooks for external integration to notification intiialization"
No usecase has been provided, and additionally the hooks
are not documented. Bartosz also points out that
mw.hook calls are asynchronous and memorized.

This reverts commit 9d3561afaf.

Change-Id: If735b46996fab3def835a54223412ef6d3105395
2014-07-26 01:05:35 +00:00
Translation updater bot eb71ab60f9 Localisation updates from https://translatewiki.net.
Change-Id: Ic3f882d74c5bb07128218eea00e836ecd4d3ec99
2014-07-25 23:04:31 +02:00
bsitu c3f02705b0 Fix incorrect variable name
Bug: 68552
Change-Id: Iddf620954c3709e7c03c0b06e0bf8f3d08df366b
2014-07-25 02:21:18 +00:00
Translation updater bot aed46b4f9f Localisation updates from https://translatewiki.net.
Change-Id: Iced35479862681c2bbb429c980acb415491f7715
2014-07-23 22:50:08 +02:00
Translation updater bot 17cc478cb5 Localisation updates from https://translatewiki.net.
Change-Id: Ie06b7ca5d8e2a88daf6121fd8c4a74bb72887ea8
2014-07-22 23:00:51 +02:00
jenkins-bot 65c43ff179 Merge "New hooks for external integration to notification intiialization" 2014-07-22 18:09:03 +00:00
Erik Bernhardson 9d3561afaf New hooks for external integration to notification intiialization
Adds two new hooks to allow extensions to tie into the notification
loading process.  Between these two hooks and the new isInitialized()
method any extension can run code whenever a notification is displayed.

Change-Id: If351835be5f65ca098e2d235ea8c8e4dc40ae2b4
2014-07-21 16:08:56 -07:00
Translation updater bot 88f2b9939b Localisation updates from https://translatewiki.net.
Change-Id: I503ec49cfc52559382b81d0c2a587f0c8100f57c
2014-07-20 21:07:48 +02:00
Translation updater bot 9ca30825ca Localisation updates from https://translatewiki.net.
Change-Id: I193ac4f181b675a3b577e925bccc05f26c4da26c
2014-07-19 22:03:28 +02:00
Translation updater bot fc37fcc9b6 Localisation updates from https://translatewiki.net.
Change-Id: I081d71a7156addd0e2ed193114cdeb059ddcf05e
2014-07-18 21:27:26 +02:00
Translation updater bot 84eee97e5d Localisation updates from https://translatewiki.net.
Change-Id: Ia50b32c03e384e8364e5663b40eb7793be553af3
2014-07-17 22:57:28 +02:00
Translation updater bot 45c8e7dd1a Localisation updates from https://translatewiki.net.
Change-Id: Ida72ac2dafc929d3fe3d5b7c9d3d9dc44aa7c5e7
2014-07-15 22:05:41 +02:00
Translation updater bot 036d6825a0 Localisation updates from https://translatewiki.net.
Change-Id: Iadeda6a0d86a97a746e8e7cc1fb2b3b4623d5932
2014-07-14 22:00:35 +02:00
Kunal Mehta f551656aa2 Remove EchoEvent::updateExtra, MWEchoBackend::updateEventExtra
Unused functions.
There is also no usecase for this, events shouldn't be altered
after creation except for bundling.

Change-Id: Id175c075d24263119f0455d99342263dd98f9410
2014-07-13 22:53:57 +00:00
jenkins-bot c71c80269d Merge "i18n: remove namespace-dependent part from "echo-pref-tooltip-mention"" 2014-07-13 22:51:35 +00:00
Kunal Mehta dd627ab22b Use localized group names for user rights changes
Bug: 55338
Change-Id: I738c2e8a8811d1bbcae03bd873bf5d076c83e8fd
2014-07-13 22:13:09 +00:00
Translation updater bot 0d005e15af Localisation updates from https://translatewiki.net.
Change-Id: I1f64bcaab6006b37b2e5eedfb0aa826d9225fd39
2014-07-13 22:22:02 +02:00
Yuki Shira d4abab3932 i18n: remove namespace-dependent part from "echo-pref-tooltip-mention"
- The mention is independent from the namespace.

Spotted by JurgenNL
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Echo-pref-tooltip-mention/en

Change-Id: I07f828eb1769d52f4a6bf118a34bc5dfbbb313ee
2014-07-13 21:15:44 +09:00
Translation updater bot b52f7dda80 Localisation updates from https://translatewiki.net.
Change-Id: Ia4f02618bb9fee769342389367d792e39f654dc8
2014-07-12 23:21:25 +02:00
Translation updater bot 35d64ad6b7 Localisation updates from https://translatewiki.net.
Change-Id: I9b68656011457f2b527eb5e666bd2611d06cb04f
2014-07-11 21:55:39 +02:00
jenkins-bot 622307a7e3 Merge "Abstract the logic of getting last bundle notif into a method" 2014-07-11 13:08:13 +00:00
Translation updater bot 8db547f389 Localisation updates from https://translatewiki.net.
Change-Id: Ic4c88d7c0b0c970a50159684c52592e13d7152b7
2014-07-09 20:33:01 +00:00
bsitu 1a2d5d7c4e Abstract the logic of getting last bundle notif into a method
We will likely need the very last record when building a bundle
notification in some cases ( talk page diff, flow unread post etc ),
it's better just to have that logic in a method

Change-Id: I8121e0cbed2beb066e27953d79225bb99c550553
2014-07-09 12:24:30 -07:00
Translation updater bot bd27427b88 Localisation updates from https://translatewiki.net.
Change-Id: I9e7579220f77c1e23b21d9ed91ed7e449feba494
2014-07-08 21:01:14 +00:00
Translation updater bot 855632d8af Localisation updates from https://translatewiki.net.
Change-Id: Iae593a3a8867716170e50f35b24913718d0f0e28
2014-07-05 19:55:28 +00:00
Translation updater bot a6d4b724f2 Localisation updates from https://translatewiki.net.
Change-Id: Ia6c60d59b198f6f3fda57a434b9976a440f77ae8
2014-07-04 21:30:39 +00:00
Translation updater bot ea12ba995c Localisation updates from https://translatewiki.net.
Change-Id: If423cea212636d1e6d3aa2b8b66406e221e1f95c
2014-07-03 19:13:51 +00:00
Translation updater bot a0014ebdbe Localisation updates from https://translatewiki.net.
Change-Id: Id947fabfb19b0f9263fbf0338929c0b0c547222e
2014-07-02 19:49:58 +00:00
jenkins-bot 5ae06e0991 Merge "Fix: getUnitTest does not add test files" 2014-07-02 15:56:12 +00:00
physikerwelt 784ae6f5b9 Fix: getUnitTest does not add test files
While running php phpunit.php --tap --testsuite extensions
in vagrant the unit tests for the echo extension were
not added to the file list.

See also
Bug: 67148

Change-Id: Id78580b4c13bbc3428727c23f1fe3e493ec127ec
2014-07-02 15:52:18 +00:00
Translation updater bot 88b7a93fc4 Localisation updates from https://translatewiki.net.
Change-Id: Ie459707d8fbe0424346d56d7beb5f3e94f8d0905
2014-06-30 20:37:12 +00:00
Translation updater bot decd5bd200 Localisation updates from https://translatewiki.net.
Change-Id: I3db0dfbd5f9a8a956fe256f102ee867a643fe91c
2014-06-29 18:37:38 +00:00
Translation updater bot 8d36048096 Localisation updates from https://translatewiki.net.
Change-Id: Ic96ee141354c2078ed2c6485003feb1388c02487
2014-06-27 20:19:58 +00:00
jenkins-bot d7affe1be4 Merge "Switched from begin/commit to *Atomic methods" 2014-06-27 01:07:59 +00:00
Translation updater bot e7b270e49d Localisation updates from https://translatewiki.net.
Change-Id: Ifc6593fa1a918f31ac4d113cd41a7bd27c9eafc4
2014-06-26 19:29:33 +00:00
Max Semenik 1dd635a773 Add ParserTestTables hook handler
Otherwise, it explodes when trying to run tests via PHPUnit:
Error: 1146 Table 'osmiumwiki.parsertest_echo_notification' doesn't exist (localhost)

Change-Id: I8a3e0171ab022e8e2973ea8bed9aacba73a35f34
2014-06-25 18:06:09 -07:00
Translation updater bot f6970d28ac Localisation updates from https://translatewiki.net.
Change-Id: I6e11d02f67b45ef029b673bbf7320497c1122088
2014-06-25 20:36:23 +00:00
Aaron Schulz 16ce5baaf4 Switched from begin/commit to *Atomic methods
* This is just stylistic and cuts down on begin/commit calls in grep

Change-Id: I11011c312c91e158e0cce395eca8022535388b90
2014-06-25 11:08:48 -07:00
Translation updater bot 74d97ec1a3 Localisation updates from https://translatewiki.net.
Change-Id: I44bd50f449bacbfd1e86a928f631c12a76507bd6
2014-06-24 19:59:41 +00:00
Alex Monk d55fbbb49b Don't show files in mention notifications
Bug: 66983
Change-Id: I452fa29f0f70dac4c92c87f4b35d9c886b187afe
2014-06-24 15:27:49 +01:00
Translation updater bot ab69a4a40f Localisation updates from https://translatewiki.net.
Change-Id: Ia73a41a4820aeccb546bd9ee8ff1b4ee8972f6cc
2014-06-22 19:28:24 +00:00
Translation updater bot 3c4994ac78 Localisation updates from https://translatewiki.net.
Change-Id: I2fff12bf71f5145836e9ba7a98e3915aa337fc58
2014-06-20 19:47:17 +00:00
Translation updater bot b9382a3db4 Localisation updates from https://translatewiki.net.
Change-Id: Id1540ff91bb48fec159ecae8018386785756a0e8
2014-06-19 19:27:48 +00:00