wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-22 12:43:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
7183 commits 15 branches 19 tags 79 MiB
Commit graph

7183 commits

This branch
This branch
All branches
Author SHA1 Message Date
jenkins-bot 8912e9c7c9 Merge "Remove qunit tests from mobile" 2014-08-09 00:08:50 +00:00
Florianschmidtwelzow ffd082b738 Remove qunit tests from mobile 
ext.echo.overlay isn't loaded in mobile, so don't load the test in
mobile.

Bug: 69316
Change-Id: Iddd68aca84c69bed10a2afe4aea8463890485e26
 2014-08-09 02:06:46 +02:00
jenkins-bot a765ba09bc Merge "QA: Add browser test for sign up notifications" 2014-08-08 23:45:48 +00:00
jdlrobson 4470d91e54 Hygiene: Break out _buildNotificationList 
Make various properties of the overlay properties of
EchoOverlay to reduce need for function parameters

Change-Id: I70ec0c650d58322aad93d71292a836d7cf7e7474
 2014-08-08 15:45:02 -07:00
jenkins-bot 3e9ae71dcd Merge "Hygiene: Introduce EchoOverlay initialisation class" 2014-08-08 22:24:05 +00:00
jdlrobson ccc0e713a0 Hygiene: Introduce EchoOverlay initialisation class 
Not as scary as it looks. The change to _buildOverlay simply changes
indenting, and cleans up to reflect new parameter. Tests still pass ;-)

Kill noticationLimit concept
Only expose what's necessary on mw.echo.overlay

Change-Id: I2671a41af8188c14ad4c910396afa0d9000b6051
 2014-08-08 14:35:07 -07:00
jenkins-bot 9edea65079 Merge "Fix Echo breaking" 2014-08-08 20:38:49 +00:00
Kunal Mehta 631d0252f7 Fix Echo breaking 
Bug: 66992
Change-Id: I7add48c55e04ef4ea5d0f537c6a1a1ba959f628e
 2014-08-08 21:35:58 +01:00
jdlrobson f4eadb5e0a Ensure override is more specific 
is definitely more specific then
So let's make sure the override always works.

Change-Id: I8e1623357185ad7b55ddc9d60ab98984721075ae
 2014-08-08 11:30:25 -07:00
jdlrobson df66e80648 Regression: Fix styling of new unread notifications 
Change-Id: Icf9f1bc21c084070a21865232cdac5d978be0731
 2014-08-08 10:44:18 -07:00
jdlrobson 02d73ad720 QA: Add browser test for sign up notifications 
Change-Id: I9a8debd8a220516adbcf86d4ccfa0019278171bb
 2014-08-07 14:47:41 -07:00
jdlrobson 71a1ec3f6f Reduce specifity of Echo css 
The #p-personal only is needed to override the ul padding.
Let's make this explict.

Change-Id: Idf538d2a09ffc4d325d4fb3061564d8dd11b1e60
 2014-08-07 21:07:14 +00:00
jdlrobson 1896424e9a Hygiene: use self where possible 
Change-Id: I30e9d6ea8b59e168fc5b151f215c3592f475bedf
 2014-08-06 13:30:42 -07:00
jdlrobson 0ff4295a88 Hygiene: Move the overlay initialisation code into a separate file 
Change-Id: I4dcdf9708b700c57679ff878275c5560a62e3a06
 2014-08-06 20:29:35 +00:00
jdlrobson a815733447 Hygiene: Move code for header into _getTitleElement 
Change-Id: Ic53933189bf51772a88689794a7633ba8ba0ac2c
 2014-08-06 20:29:30 +00:00
jdlrobson f02d3f059d Hygiene: Add _getFooterElement method 
Continue to shrink down the size of buildOverlay

Change-Id: I69b339947bfe4d5e73c6d293f0ae5e9e494ec6ca
 2014-08-06 20:29:25 +00:00
jdlrobson 9b30d33549 Hygiene: Refactor out mark as read button code 
Change-Id: Iad935174925bd1c16e51bbc36c84b48769e9780c
 2014-08-06 20:29:01 +00:00
jdlrobson e064126209 Hygiene: Split buildOverlay into smaller functions 
Start with a getNotificationLimit and markAllAsRead function

Change-Id: Ice53af40a152f6c3b5a92683c574ef7dc2d01047
 2014-08-06 20:28:55 +00:00
jdlrobson 8d12ef9a80 The first ever Echo QUnit tests 
Also change coding conventions of Resources to allows use
array for scripts key.

Change-Id: I0c9f358ce3eb62adb07b68623e97c07993c9c45c
 2014-08-06 13:26:42 -07:00
jdlrobson 0dc45e6c4a Regression: Fix styling on Special:Notifications 
addModuleStyles ignores JavaScript in module.

Change-Id: I6c20a6ff05fbd52d30dea7d7633fb6f4b36b377b
 2014-08-05 17:08:10 -07:00
jenkins-bot cb1375ccdf Merge "Add support for splitting notifications into alert & message" 2014-08-05 22:24:14 +00:00
bsitu 427b7e2c38 Add support for splitting notifications into alert & message 
Change-Id: I8eeeeb9a7a1539a258bc42584274897f9e7dc775
 2014-08-05 14:50:54 -07:00
Translation updater bot 8d15d1a810 Localisation updates from https://translatewiki.net. 
Change-Id: I687dc3b8717b0439c0393feb3e15038e49c4feb6
 2014-08-05 21:56:18 +02:00
jenkins-bot 792b9dfc31 Merge "Add ability to run QUnit tests" 2014-08-05 18:45:29 +00:00
jenkins-bot fd6822fac2 Merge "Hygiene: More LESS cleanup in ext.echo.overlays.less" 2014-08-05 18:40:11 +00:00
jdlrobson 01b0f912f3 Hygiene: More LESS cleanup in ext.echo.overlays.less 
Change-Id: I2d2daad00a11a156dc0ac693ea99322c9470cc6f
 2014-08-05 11:37:43 -07:00
bsitu 4e63ee6164 Hygiene: Update method documentation & split exception to a file 
Change-Id: Id77db0f21ee3fdaad4e040c853fadc605df212ea
 2014-08-04 17:43:57 -07:00
jdlrobson bb6eef198c QA: Add some basic browser tests 
yippee ki yay!
Tests basic functionality
1) presence of Echo button
2) behaviour of clicking Echo button

Change-Id: I6334264e1ee73a59da1e7b0c3f18a1d43b565f3a
 2014-08-04 16:22:01 -07:00
jenkins-bot 091d1c9b52 Merge "Hygiene: Port all Echo css to less." 2014-08-04 20:49:38 +00:00
Translation updater bot 3c22ef1012 Localisation updates from https://translatewiki.net. 
Change-Id: If6bb59767b11f50154dbd7c92232ca4aef47adf4
 2014-08-04 21:53:53 +02:00
jdlrobson 430628ccc1 Hygiene: Port all Echo css to less. 
No changes.
Makes styling code more readable.

Change-Id: Ie45f2cd3671bee5b88ba92ca2946d6e77cd59508
 2014-08-04 11:43:27 -07:00
Erik Bernhardson 74a56e6fc4 Convert existing notifications to use user-locators 
Replace implementation specific code with generalized user-locator
implementations that can be re-used by more notifications in other
extensions.

This patch adjusts the `user-locators` notification parameter to allow
arrays which facilitate passing options to the locator.

Previously(still works):

    'user-locators' => array( 'foo', 'bar' ),

New functionality:

    'user-locators' => array(
	'foo',
	array( 'bar', 42 )
    )

In the second example the callback specified by `bar` will receive
an EchoEvent as the first argument and array( 42 ) as its second
argument.

Change-Id: I7305279bc91d1e40e7054e2fd42a819a35526b82
 2014-08-04 11:16:34 -07:00
Translation updater bot a0b7251741 Localisation updates from https://translatewiki.net. 
Change-Id: I147db21bede9248a01477d371287e9a9005830a9
 2014-08-03 22:09:05 +02:00
jenkins-bot cf418a4ecb Merge "Generalize a couple implementations of EchoGetDefaultNotifiedUsers" 2014-08-02 00:10:42 +00:00
jdlrobson 5b46130173 Add ability to run QUnit tests 
Point out there are no QUnit tests :-)
Add .jshintignore file

Change-Id: I02635b8620dda0110c04549724f50f561c5657fe
Note: See also 69034
 2014-08-01 15:55:22 -07:00
Kunal Mehta e25eb66a3a Support BasicFormatter::getLinkParams returning raw urls 
In some cases like I7e309c04bc2456f4f87554a3d70dd6c77ba22f71 we
only have a raw URL and not a Title object. This supports that
usecase as well.

Change-Id: Ie18698e3ef755ca5a2cecc1f1cfb4254184bb576
 2014-08-01 22:40:59 +00:00
Erik Bernhardson 71c7e02858 Directory reshuffle, add dev tools 
* Port Flow Makefile to Echo
* Move resources to Resources.php

Change-Id: I75e96cc1e51a7768600ffc083550fc94ea9d1e6c
 2014-08-01 22:38:41 +00:00
Translation updater bot 38243e21f5 Localisation updates from https://translatewiki.net. 
Change-Id: I6da903f883787d92e10f87b2e95cd43d53a1f33b
 2014-08-01 21:32:44 +02:00
Erik Bernhardson f995de90c8 Generalize a couple implementations of EchoGetDefaultNotifiedUsers 
There are a variety of generic strategies you could define to choose
which users should be notified about an event, such as 'users watching
the title' or 'talk page owner' (User_talk only).

This adds a new way to generically implement these in Echo and expose them
to other extensions rather than having each extension implement these
generic strategies themselves.

This patch only converts one notification, edit-user-talk. The remaining
notifications will be converted in future patches. The first user of this
will be Flow for notifying all users watching a particular talk page in
I4e46a9c003fbdde274b20ac7aef8455eab4a5222

The users watching title implementation provided here is minimalist, a larger
refactor to accomidate pages with thousands of watchers is being handled
in I3d3fa9328f348bb48682d3658622952ce82d3925

Change-Id: I19bb6a794d22565f3bb5421de92426d390197796
 2014-08-01 12:31:53 -07:00
jenkins-bot 1ba7583985 Merge "Introduce AttributeManager class" 2014-07-31 20:45:31 +00:00
jenkins-bot a2dcf255e5 Merge "Fix a function param in API" 2014-07-31 20:43:13 +00:00
Translation updater bot 97da12ad49 Merge "Localisation updates from https://translatewiki.net." 2014-07-31 20:21:02 +00:00
Translation updater bot cc131e14f1 Localisation updates from https://translatewiki.net. 
Change-Id: I4023cf493c79806156f2666840e327317f0354b9
 2014-07-31 22:15:32 +02:00
bsitu b26cc21794 static method should be declared with static 
Change-Id: I855c09d950a44ae70b7d982e8c3e23b36dde1475
 2014-07-31 13:10:35 -07:00
jenkins-bot c9ed159ea7 Merge "Clear up cached Main_page title in test" 2014-07-31 18:52:32 +00:00
bsitu 267a56398e Introduce AttributeManager class 
This is a precursor to splitting notifications into
alert and message sections.

Change-Id: Ic685f7026ab9b41407b51317780bbfadd05bf9f1
 2014-07-31 11:41:00 -07:00
bsitu 77239e17de Fix a function param in API 
The distributionType is still passed to the function, it will
be arry of event types in next patch

Change-Id: Ieae7cfc383c2a024256f7e6b2f91d3b5c323f79b
 2014-07-31 11:28:57 -07:00
jenkins-bot f94f24dbc0 Merge "Refactor ApiEchoNotifications preparing for alert/messages split" 2014-07-31 18:12:05 +00:00
jenkins-bot dc5f772bac Merge "Replace EchoBackend with mappers and gateway" 2014-07-31 18:11:44 +00:00
Erik Bernhardson 04f04f8db2 Refactor ApiEchoNotifications preparing for alert/messages split 
Change-Id: If4a79a3c775070bcaed62b6330920f7d82c16f69
 2014-07-31 18:11:42 +00:00