wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-23 21:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
6521 commits 15 branches 19 tags 79 MiB
Commit graph

6521 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kosta Harlan 294ed3c2cb ForeignWikiRequest: Guard against bad response 
See also I4dde4e3bb4ff2ea8b7669bb18b2689410e5e7713

Bug: T274408
Change-Id: I3ab7d0a4b58a150fe940bc8441b5fb127142ad9f
 2021-02-17 10:11:10 +01:00
Translation updater bot e147f4fa5c Localisation updates from https://translatewiki.net. 
Change-Id: Ib2f4073cf980367efd1eb019e0de159ffcc1f31a
 2021-02-15 10:05:01 +01:00
Translation updater bot 492842eb31 Localisation updates from https://translatewiki.net. 
Change-Id: Id332ebf3f7ecaf35fc3335f747a085c7865e3ff0
 2021-02-12 08:51:30 +01:00
Translation updater bot e7599387e8 Localisation updates from https://translatewiki.net. 
Change-Id: I4fafbf6162815e081589649002e639c3111ef26d
 2021-02-11 08:38:38 +01:00
Translation updater bot 1d6a2bc5c7 Localisation updates from https://translatewiki.net. 
Change-Id: I1a478f4849c3d75d514040656b2c03cf137aaa86
 2021-02-08 08:40:36 +01:00
Translation updater bot 4c282cad25 Localisation updates from https://translatewiki.net. 
Change-Id: Ib9aec51910b5506f9f653db09a68bed426b194cd
 2021-02-05 08:46:53 +01:00
jenkins-bot ebad6f972a Merge "Remove wrong return null from function documentation" 2021-02-05 02:51:28 +00:00
Translation updater bot 9211924c81 Localisation updates from https://translatewiki.net. 
Change-Id: I5cc73e725e5d6320c739ba1099f1a643771605c1
 2021-02-04 08:39:23 +01:00
jenkins-bot fd61cf3082 Merge "Replace use of newMutableRevisionFromArray within new MutableRevisionRecord" 2021-02-03 22:52:56 +00:00
Umherirrender ddf5b4bd24 Remove wrong return null from function documentation 
Change-Id: I1a702bbdd4378a35216641ec73fbe318f02bde69
 2021-02-03 21:59:07 +01:00
jenkins-bot a517f9ed2a Merge "Use monitored getTestUser() in tests if possible" 2021-02-03 14:37:30 +00:00
jenkins-bot d833955062 Merge "eslint: Fix warnings" 2021-02-03 14:35:45 +00:00
Martin Urbanec 36c65d8fa8 Log ApiEchoUnreadNotificationPages bad responses 
ApiEchoUnreadNotificationPages::getUnreadNotificationPagesFromForeign we
sometime erroneous responses from the foreign wiki. We silently ignore
them since d8a4b6ba9, this add logging of the response payload.

Bug: T273479
Signed-off-by: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Change-Id: I4dde4e3bb4ff2ea8b7669bb18b2689410e5e7713
 2021-02-03 10:47:32 +01:00
jenkins-bot a44277aaf5 Merge "Add missing isset() check to ApiEchoUnreadNotificationPages" 2021-02-03 07:49:15 +00:00
jenkins-bot 4029279de1 Merge "Echo: Remove redundant cast" 2021-02-03 07:46:21 +00:00
Translation updater bot 2967f6cb45 Localisation updates from https://translatewiki.net. 
Change-Id: Id009de7bada31dbdfbf809c8f9fdfa56c81f6262
 2021-02-03 08:39:07 +01:00
Thiemo Kreuz d8a4b6ba91 Add missing isset() check to ApiEchoUnreadNotificationPages 
…::getUnreadNotificationPagesFromForeign().

I'm not 100% sure if this fixes the code in a way it is
supposed to work. However, I see that getFromForeign() is
called 3 times in existing code, and 2 of these places
already do an isset() check. It looks like it was just
forgotten here.

Even if there is another issue to fix here, this patch:
a) silences the error, and
b) gives us more useful debug output.

Bug: T273479
Change-Id: I257620f646196c0554b9d86c849a02f5a8b9519c
 2021-02-03 06:42:26 +00:00
Ammarpad 5b032f5589 Echo: Remove redundant cast 
User::getId() is typehinted to return int and so this cast is causing
Phan failure.

Note the method is deprecated but this patch is not meant to fix that.

Change-Id: I3b7ad419d7c28c3ad7144b8005f2fa387af58b0d
 2021-02-03 07:39:38 +01:00
Peter Ovchyn f352b3406c Replace use of newMutableRevisionFromArray within new MutableRevisionRecord 
Bug: T272560
Change-Id: I171537c3346a7dd4aeb4fc612d7dd9fba5d64679
 2021-02-02 22:42:06 +02:00
Ed Sanders bb1bd02bd6 eslint: Fix warnings 
* Load wikimedia/jsduck rules
* Add inline disables for compat
* Fix shadowed variables

Change-Id: I42234ab74f5007c16ff3960309335e715da76c1c
 2021-02-01 21:02:46 +00:00
Translation updater bot 025cd0f3ac Localisation updates from https://translatewiki.net. 
Change-Id: I755f87c17a936ef7c2e3db84024123abd333cc85
 2021-02-01 08:47:35 +01:00
jenkins-bot 0a93747175 Merge "build: Updating dependencies" 2021-01-29 19:12:49 +00:00
Thiemo Kreuz df6d65a6cf Use monitored getTestUser() in tests if possible 
Change-Id: I584d8883f14b2651927890d353b738a02771abea
 2021-01-29 18:00:57 +00:00
Thiemo Kreuz 0f954929a7 Remove comments that literally repeat the code 
This also fixes a remaining `var` that should be `private`.

Change-Id: Ifa37a097a9d60bd22a16bc626d4b4271b8df2da7
 2021-01-29 13:55:41 +01:00
libraryupgrader b49cebf8cb build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
  The following sniffs are failing and were disabled:
  * MediaWiki.Commenting.FunctionComment.WrongStyle

* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.17.0 → 0.18.1
  The following rules are failing and were disabled:
  * compat/compat

Additional changes:
* Added the "composer phan" command to conveniently run phan.

Change-Id: Icc5ae88b205d4b122efef7aef2826eb334b27820
 2021-01-29 10:19:37 +00:00
Translation updater bot c6f29042bc Localisation updates from https://translatewiki.net. 
Change-Id: I6d2ebba04320b87bba0ee0a606c72dc137d4ac23
 2021-01-29 08:37:36 +01:00
jenkins-bot 8ef19fb332 Merge "Improve function and property documentation in tests" 2021-01-28 09:57:19 +00:00
Translation updater bot 66ae6adafb Localisation updates from https://translatewiki.net. 
Change-Id: If78ecd712f317ab8de73f72ac721749d431fe994
 2021-01-28 08:35:45 +01:00
mainframe98 d426e6fb54 Provide notifications icons through content navigation 
Ia1451e3e802441162eecfc5b7f6a7ba2ae72f377 introduced
the notifications content navigation, which allows skins
to choose where they want notifications to be positioned,
rather than requiring them to manually extract them from
the personal tools.

Bug: T266613
Depends-On: Ia1451e3e802441162eecfc5b7f6a7ba2ae72f377
Change-Id: I7badfd9bf9257b2537596e9f2e93248f52e4bd82
 2021-01-27 17:36:24 +01:00
Translation updater bot f111dd9f60 Localisation updates from https://translatewiki.net. 
Change-Id: I2af220037d6e638819a3fcbbe519982632106248
 2021-01-27 08:34:16 +01:00
Translation updater bot 737a002378 Localisation updates from https://translatewiki.net. 
Change-Id: I621d1ca3dd15512769a217ea39d35fd45e13a35e
 2021-01-25 08:53:26 +01:00
Umherirrender fba5bcec19 Improve function and property documentation in tests 
Change-Id: I90a0c9e7b1ac17edeed5f706a8f968f6d67df56f
 2021-01-23 12:54:27 +01:00
Translation updater bot 7ec57872fe Localisation updates from https://translatewiki.net. 
Change-Id: I7f4b24720e9063ca1ab05934619d3d2ad8881117
 2021-01-22 08:30:33 +01:00
Translation updater bot 7823fb5c41 Localisation updates from https://translatewiki.net. 
Change-Id: I334b05d38c6f69a139b29394dc86f81a5a7446b3
 2021-01-21 08:31:39 +01:00
Translation updater bot 21963b88be Localisation updates from https://translatewiki.net. 
Change-Id: I40957a12484298cda2c098295227e819784ee591
 2021-01-18 08:37:44 +01:00
Translation updater bot da149c856b Localisation updates from https://translatewiki.net. 
Change-Id: I67bc95cbee399bb29fbd6d2a61aa286ba4befb42
 2021-01-15 08:39:07 +01:00
Translation updater bot 945526799a Localisation updates from https://translatewiki.net. 
Change-Id: I4ad8113437ac5274bc74492b5ba095e9af3c333a
 2021-01-14 08:50:10 +01:00
Translation updater bot 4591374302 Localisation updates from https://translatewiki.net. 
Change-Id: I945025bd52e5ae1f19ff2bc3714c0999f039e179
 2021-01-13 08:36:17 +01:00
Translation updater bot 2be4751ba1 Localisation updates from https://translatewiki.net. 
Change-Id: I20ec252abf9e1257c30bd8bbaf3ef983ed5b0950
 2021-01-12 08:37:28 +01:00
Translation updater bot e4b94a847c Localisation updates from https://translatewiki.net. 
Change-Id: I6c2324e25917dafc0efb8e524ea45d15078fbce7
 2021-01-11 08:34:12 +01:00
Translation updater bot 4aa9662221 Localisation updates from https://translatewiki.net. 
Change-Id: I19d9a31d85aef9601c251f462a4d69488e311660
 2021-01-05 08:27:46 +01:00
Translation updater bot c5ab03ed0a Localisation updates from https://translatewiki.net. 
Change-Id: I803e346bafbaf8a79a2e979632b79886ad2d2a73
 2021-01-04 08:43:11 +01:00
jenkins-bot c5ff8a20d1 Merge "Use Maintenance::set/getBatchSize in maintenance scripts" 2020-12-31 23:20:47 +00:00
Translation updater bot 9973c22664 Localisation updates from https://translatewiki.net. 
Change-Id: Iec633689227ceb2922bd36041d2d84ee689e55ad
 2020-12-30 10:13:49 +01:00
Translation updater bot 0a8dda9386 Localisation updates from https://translatewiki.net. 
Change-Id: I4dde3aa8e9bfa9a291dc2823b0771ab6f4ad64b5
 2020-12-28 10:38:11 +01:00
jenkins-bot 6042d6e389 Merge "Prefer UserIdentity::isRegistered over isAnon" 2020-12-23 08:25:04 +00:00
Translation updater bot bb8308b417 Localisation updates from https://translatewiki.net. 
Change-Id: I7a9d7bb1778fbcce7e12f7c81733e4658118c100
 2020-12-23 08:32:12 +01:00
Thiemo Kreuz c9797db768 Prefer UserIdentity::isRegistered over isAnon 
isRegistered is part of the slick UserIdentity interface, i.e.
it's the more "canonical" form. This change makes it a bit
easier to move away from using the huge (4000+ LOC) User class
everywhere, in favor of the UserIdentity interface, where
possible.

This patch is meant as a small step towards this goal. I tried
to replace some usages of User type hints already, but prefer
to go in small, incremental steps.

Change-Id: I039c7a18672dfb6ea9507752bce9ea754babd690
 2020-12-23 07:15:30 +00:00
Translation updater bot 998eccffe0 Localisation updates from https://translatewiki.net. 
Change-Id: I3d70ce079da9fbf125aadd752e9a6c0d99578b35
 2020-12-22 08:30:53 +01:00
Translation updater bot 5bb4551d0a Localisation updates from https://translatewiki.net. 
Change-Id: Icdd77c4bf35e372f10c7c858638735588e2cc383
 2020-12-21 08:38:51 +01:00