Commit graph

6927 commits

Author SHA1 Message Date
Bartosz Dziewoński 24fdeb0170 Fix unnecessary scrollbars on notifications popup
While loading or when there were 0 notifications, the popup displayed
with a scrollbar gutter, in a displeasingly different color.
When there weren't enough notifications to require a scrollbar,
the scrollbar was shown anyway.

These issues were caused by these rules, which don't seem necessary
any more. They were added for T130153 and T159888 (and a mysterious
scrollbar rendering bug), and I can't reproduce any of these bugs.

Bug: T351481
Change-Id: I370166ce31c86ae531080490c455286879999ae5
2023-11-17 13:18:20 +01:00
jenkins-bot eca1091cb5 Merge "Use $this->getServiceContainer() in maintenance and tests" 2023-11-16 21:03:26 +00:00
jenkins-bot 1026158453 Merge "Remove unused CSS classes." 2023-11-16 13:13:10 +00:00
Ed Sanders 37b9ae3ed8 Remove unused CSS classes.
* user-button removed in I55c18cf72.
* mw-notifications-widget removed in I34e27364.

Change-Id: I802be3c15fd3d09f72094fc36e101ad38864ef41
2023-11-16 10:46:23 +00:00
jenkins-bot 66c80eba34 Merge "Unsets icon correctly" 2023-11-13 20:51:55 +00:00
Jon Robson a3d2f9827e Unsets icon correctly
Fixes the rendering of an empty icon in Vector 2022
(empty string is a valid icon - blank icon)

Bug: T350195
Change-Id: I7b19d7e1e85eddd5a4bac29008cd53f14d640a08
2023-11-13 11:18:07 -08:00
Translation updater bot 9ede208a6f Localisation updates from https://translatewiki.net.
Change-Id: I73ba8b2108b383c3c0e4e8b1386174a90782e30b
2023-11-13 08:40:48 +01:00
Fomafix 829003cabf Use $this->getServiceContainer() in maintenance and tests
Use
	$this->getServiceContainer()
instead of
	MediaWikiServices::getInstance()
in maintenance and tests.

Change-Id: I845e8f083b19da093166d6551683f2013eec7bb1
2023-11-09 20:18:48 +00:00
Translation updater bot e4f2c0e4b0 Localisation updates from https://translatewiki.net.
Change-Id: I5a6913da7fe833e45f3dbf898b27b64f10ab3fdd
2023-11-08 13:07:31 +01:00
Translation updater bot 9b0dad2271 Localisation updates from https://translatewiki.net.
Change-Id: I2eb79450f9c2979c8647713ba04ad7f3b1ecdb17
2023-11-06 08:56:10 +01:00
jenkins-bot d712753ad9 Merge "Document some generated messages" 2023-11-03 15:53:58 +00:00
Translation updater bot a2786e54ca Localisation updates from https://translatewiki.net.
Change-Id: I21a7d9f14919c5d13c9d6a039f5176c1629b3b7e
2023-11-03 08:58:50 +01:00
Ed Sanders 2e6c50a963 Document some generated messages
Change-Id: I75571da5943bb94f6d997ebdb8e33fae8b62e812
2023-11-02 19:02:16 +00:00
Translation updater bot 273112545d Localisation updates from https://translatewiki.net.
Change-Id: I6ba6a06a737b8b99de0e079875b709c49bb3db08
2023-10-30 17:59:06 +01:00
Umherirrender e793977f23 Add some newlines to multiline statements in Hooks.php
Change-Id: I6c26dcb2dcdb345f74a14d859faa0b09fed4e0d4
2023-10-29 15:56:29 +01:00
Siddharth VP 0d071e2a7b Avoid use of globals for reading config in hooks
Change-Id: I6d476773397438d7c78e1869e2afe3699ce4c092
2023-10-29 15:41:21 +05:30
Translation updater bot baac31b4a5 Localisation updates from https://translatewiki.net.
Change-Id: I326edfc69a62874711757578a2d21f3f9bde2641
2023-10-27 09:20:09 +02:00
Translation updater bot 831c04703c Localisation updates from https://translatewiki.net.
Change-Id: I87c7a8f3a7ee54441a41c7848591ac1b98057ad3
2023-10-26 11:04:01 +02:00
Volker E ab0f2df92a styles: Use new forward-facing breakpoint tokens
Replacing legacy tablet breakpoint variables with new Codex
design system `@max-width-breakpoint-tablet` tokens.

Bug: T331403
Change-Id: I8342b13c5ec6ad99f39a3d2f4ba1f2b0a1cf6386
2023-10-24 23:37:54 -07:00
Translation updater bot 6bcc56f568 Localisation updates from https://translatewiki.net.
Change-Id: Ifa4f51f0d29c9e4251f76a3619cfe45e961fa211
2023-10-24 09:37:08 +02:00
Translation updater bot 7c29e1bf6c Localisation updates from https://translatewiki.net.
Change-Id: Ie659d6e5959cb6aff0da6b7e81b5afa44e71b762
2023-10-23 09:50:35 +02:00
Umherirrender bdbd65ffae Replace empty() with falsy check
empty() should only be used to suppress errors
Found by a new phan plugin (T234237)

Change-Id: I3a2c86e0f83ec49cbd6af3ad30ecd0a663b761a0
2023-10-22 11:12:41 +02:00
Umherirrender ceb2da0f60 Replace empty() with falsy check
empty() should only be used to suppress errors
When the type of the variable is array,
a falsy check is the same (checks for null, false and empty array)
Found by a new phan plugin (T234237)

Change-Id: Ia4e25651d753b7b4d3bcd780123c66c3d90cdf1b
2023-10-21 20:56:18 +02:00
Translation updater bot 030d0bbbf9 Localisation updates from https://translatewiki.net.
Change-Id: Ic35e7fb8f5975c03361d76fab84e240a1ed53da8
2023-10-19 08:41:48 +02:00
Translation updater bot 08d83dd85a Localisation updates from https://translatewiki.net.
Change-Id: Ib006c7b4feb5b2c9ce207dee3aeb9ec295f6a8cf
2023-10-17 09:34:16 +02:00
Siddharth VP 035f39d76c Use dependency injection in hooks
Removal of globals for reading config to be done in a follow-up patch

Change-Id: I8652ca67375ce2f2d79de93e0a3b75ac998131e0
2023-10-14 23:44:57 +05:30
Translation updater bot 2ceb92f119 Localisation updates from https://translatewiki.net.
Change-Id: I4cfc1593d6805b4d8f622712315885c92860f472
2023-10-10 08:52:02 +02:00
Translation updater bot 1631e312b1 Localisation updates from https://translatewiki.net.
Change-Id: Ice10112e076042a6c87d4a496fc859764f122e6d
2023-10-06 09:19:42 +02:00
Translation updater bot 174737de5b Localisation updates from https://translatewiki.net.
Change-Id: I7ab9c5d583eb7be729cd01fefd30c5e3f78d0b63
2023-10-05 09:11:37 +02:00
Translation updater bot d3950baf9a Localisation updates from https://translatewiki.net.
Change-Id: I71b8165333f06e31fa8420f5e3074160d7d2b4e4
2023-10-04 09:08:07 +02:00
Translation updater bot 9d4833b718 Localisation updates from https://translatewiki.net.
Change-Id: I3e45b1aa0b8ac519f3ce0a664fc949aaba7840f3
2023-10-03 09:32:32 +02:00
Translation updater bot 3e4bc3ed5c Localisation updates from https://translatewiki.net.
Change-Id: Ic64926e0d5357e509d54d034780c0051712f910d
2023-10-02 10:57:13 +02:00
Translation updater bot c834ffe762 Localisation updates from https://translatewiki.net.
Change-Id: I4cea16984a412da142a61f129b0a0601dc8a236b
2023-09-25 08:46:11 +02:00
WMDE-Fisch f72691fc4b [build] Bump wdio-mediawiki to v2.3.0
Change-Id: I9a1a03156bb3c8db4ee2213b6b5f42913f8e4e0d
2023-09-22 16:02:52 +00:00
jenkins-bot a8d425ef5b Merge "Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()" 2023-09-21 21:00:58 +00:00
Translation updater bot d301a28132 Localisation updates from https://translatewiki.net.
Change-Id: I76c819ebbb60a209ca9ec7a367857a8b5d05b19e
2023-09-21 10:15:42 +02:00
jenkins-bot 2a7427630f Merge "ForeignWikiRequest: Ensure fetching CSRF tokens uses unique CentralAuth tokens" 2023-09-20 15:58:11 +00:00
jenkins-bot 8114ac1c6b Merge "ForeignWikiRequest: Specify formatversion, errorformat" 2023-09-20 15:56:26 +00:00
jenkins-bot f325e64256 Merge "Call hook handler for own hooks directly and not via hook system" 2023-09-20 14:32:41 +00:00
Translation updater bot 8cfe70d0a0 Localisation updates from https://translatewiki.net.
Change-Id: I0a43c07c0d7ee5e2fea950b17bb0fe96cc17ae47
2023-09-20 08:55:02 +02:00
Translation updater bot 990dcb205e Localisation updates from https://translatewiki.net.
Change-Id: I0d1914a5fa6542c952ba7842a971ebf2670884d5
2023-09-19 09:25:23 +02:00
Translation updater bot 078a5d1076 Localisation updates from https://translatewiki.net.
Change-Id: Ie8c8cf95cd71b72d4fd2589742d331ddc81948a5
2023-09-18 08:43:00 +02:00
Translation updater bot 7ec07b9574 Localisation updates from https://translatewiki.net.
Change-Id: Ifa61a35908446882e64d58ed30304170e574af46
2023-09-14 09:29:40 +02:00
Translation updater bot 332a3d8b52 Localisation updates from https://translatewiki.net.
Change-Id: I07b764e8d413d2e0223ed7550eef392698d91dff
2023-09-11 09:03:36 +02:00
Umherirrender 5e49d52fba Call hook handler for own hooks directly and not via hook system
Extensions should not a consumer of its own hooks,
just call the code before calling the hook.
In case of EchoGetBundleRules each extension should only handle it's
own event, so this is not a breaking change.
In case if EchoAbortEmailNotification the return false in the hook
handler already aborted further hooks, so this is not a breaking change.

Change-Id: I2715aa6499d01a1c1b3a27ff510b331eae0deca9
2023-09-08 16:47:33 +00:00
Translation updater bot b2cd2bd357 Localisation updates from https://translatewiki.net.
Change-Id: I2589ca9c9949d978ebb27c911cfd15561dc18b3b
2023-09-07 11:11:05 +02:00
Translation updater bot 2cccbdbe2d Localisation updates from https://translatewiki.net.
Change-Id: Ibfbcdd60d0b46b17297aa4ed2a69494dacaa2234
2023-09-06 08:41:53 +02:00
Bartosz Dziewoński 18ed307c39 ForeignWikiRequest: Ensure fetching CSRF tokens uses unique CentralAuth tokens
getCsrfToken() previously did the requests to every wiki with the same
'centralauthtoken'. Luckily this wasn't causing any bugs in practice,
because all users of ForeignWikiRequest that need CSRF tokens always
use it with a single wiki.

Change-Id: Ib1c0b9c13a34e38f85faed519c46cabd3b77e61e
2023-09-04 23:39:40 +02:00
Bartosz Dziewoński c3c3aed4dc ForeignWikiRequest: Specify formatversion, errorformat
Otherwise the parameters are copied from the local API request.
That mostly works fine, but browsing the errors logged for T342201
is a bit confusing when they're in different formats.

Change-Id: I5c361d6c0f7d635d3063290dec25f18bc6417e08
2023-09-04 23:39:30 +02:00
jenkins-bot 68d90d69a7 Merge "Make DB tests more robust" 2023-09-01 13:33:23 +00:00