wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-23 15:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace empty() with falsy check

Browse source 
empty() should only be used to suppress errors
Found by a new phan plugin (T234237)

Change-Id: I3a2c86e0f83ec49cbd6af3ad30ecd0a663b761a0
This commit is contained in:
Umherirrender 2023-10-22 11:12:41 +02:00
parent ceb2da0f60
commit bdbd65ffae
1 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
includes/ResourceLoaderEchoImageModule.php
View file

@ -43,20 +43,9 @@ class ResourceLoaderEchoImageModule extends RL\ImageModule {
foreach ( $this->definition['icons'] as $iconName => $definition ) {
// FIXME: We also have a 'site' icon which is "magical"
// and uses witchcraft and should be handled specifically
if ( isset( $definition[ 'path' ] ) ) {
if ( is_array( $definition[ 'path' ] ) ) {
$paths = [];
foreach ( $definition[ 'path' ] as $dir => $p ) {
// Has both rtl and ltr definitions
$paths[ $dir ] = $p;
}
} else {
$paths = $definition[ 'path' ];
}
if ( !empty( $paths ) ) {
$images[ $iconName ][ 'file' ] = $paths;
}
if ( isset( $definition[ 'path' ] ) && $definition[ 'path' ] ) {
// string or array, if array, has both rtl and ltr definitions
$images[ $iconName ][ 'file' ] = $definition[ 'path' ];
}
}