wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-11 17:00:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace empty() with falsy check

Browse source 
empty() should only be used to suppress errors
When the type of the variable is array,
a falsy check is the same (checks for null, false and empty array)
Found by a new phan plugin (T234237)

Change-Id: Ia4e25651d753b7b4d3bcd780123c66c3d90cdf1b
This commit is contained in:
Umherirrender 2023-10-21 20:56:18 +02:00
parent 030d0bbbf9
commit ceb2da0f60
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/DiscussionParser.php
View file

@ -662,7 +662,7 @@ abstract class DiscussionParser {
$sectionSpan = self::getSectionSpan( $nextSectionStart, $changes['_info']['rhs'] );
$nextSectionStart = $sectionSpan[1] + 1;
$sectionSignedUsers = self::extractSignatures( $section['content'], $title );
if ( !empty( $sectionSignedUsers ) ) {
if ( $sectionSignedUsers ) {
$signedSections[] = $sectionSpan;
if ( !$section['header'] ) {
$fullSection = self::getFullSection(
@ -725,7 +725,7 @@ abstract class DiscussionParser {
}
}
if ( !empty( $signedSections ) ) {
if ( $signedSections ) {
$actions = self::convertToUnknownSignedChanges( $signedSections, $actions );
}