Commit graph

1809 commits

Author SHA1 Message Date
jenkins-bot eb0ca647ef Merge "Ensure highlighted comment is defined before we try to show auto topic sub popup next to it" 2021-11-29 19:24:05 +00:00
jenkins-bot 0e81c8520d Merge "Ensure we won't set 'seenautotopicsubpopup' pref when not showing the popup" 2021-11-29 19:24:03 +00:00
jenkins-bot 1cb8fb6e99 Merge "Don't try to load 'mobile.init' on non-mobile" 2021-11-29 19:24:02 +00:00
Translation updater bot d9c5626470 Localisation updates from https://translatewiki.net.
Change-Id: I5e10a430379ae46258f8a4a40790548732cd2e79
2021-11-29 08:11:36 +01:00
Translation updater bot 4908e15303 Localisation updates from https://translatewiki.net.
Change-Id: I09b385399d32e1603a79438f818df53a99f86037
2021-11-26 08:22:43 +01:00
jenkins-bot e99709e495 Merge "Localisation updates from https://translatewiki.net." 2021-11-25 08:05:42 +00:00
Translation updater bot 6f447aabc3 Localisation updates from https://translatewiki.net.
Change-Id: I4a9a2eafe8877f4a8975658572e5a244e7eaa9c0
2021-11-25 09:02:01 +01:00
Translation updater bot fb7ba6a414 Localisation updates from https://translatewiki.net.
Change-Id: Ib798c4e05ecbbc4d474119eb0083d6d3eacec574
2021-11-25 08:24:10 +01:00
jenkins-bot 38c38b8201 Merge "Cast 'discussiontools-betaenable' preference to bool" 2021-11-24 12:56:05 +00:00
Translation updater bot d344336947 Localisation updates from https://translatewiki.net.
Change-Id: I4584549960cee0e2af02d1fb3c6d8d9cddff19f4
2021-11-24 08:21:43 +01:00
Translation updater bot 3ece3e7f43 Localisation updates from https://translatewiki.net.
Change-Id: I03a0ff0a5c1dc0686c076dcd00c28a94b8502ec0
2021-11-23 08:26:34 +01:00
Bartosz Dziewoński a38e1941e3 Cast 'discussiontools-betaenable' preference to bool
Bug: T296138
Change-Id: Ifff81ec330c3eb447c79f2b176654e7852d671dd
2021-11-22 20:08:55 +01:00
Martin Urbanec 781db3d800 Translate Special:TopicSubscriptions to Czech
Change-Id: I6d2245ee38a529a0f6f10beab205b6ff58ae40a1
2021-11-22 16:23:41 +01:00
Translation updater bot e682c3faba Localisation updates from https://translatewiki.net.
Change-Id: I9f25ee7534d5bf836484f559f1a31a9650a45a6f
2021-11-22 09:02:55 +01:00
jenkins-bot 0e00c6e96d Merge "Fixes for talk_page_edit logging" 2021-11-19 17:26:14 +00:00
David Lynch 17a3ac295e Fixes for talk_page_edit logging
* Add a N/A value for edit counts from anonymous users
* Only oversample with $wgDTSchemaEditAttemptStepOversample if the edit
  is from DiscussionTools
* Consider $wgWMESchemaEditAttemptStepOversample for oversampling

Bug: T286076
Bug: T295995
Depends-On: Ieb3f6c6e1775c1ef53747c37003b17e3634d1c44
Change-Id: I91245a61dfbde8b5ec9b2893b9170cc4d73f7b0a
2021-11-19 17:02:15 +00:00
Translation updater bot 819994c187 Localisation updates from https://translatewiki.net.
Change-Id: If5594ad13f9706be29f35a4ef87497fbaa8bf8da
2021-11-19 08:27:12 +01:00
jenkins-bot dc58a28822 Merge "Ensure form tokens are not longer than allowed" 2021-11-18 21:24:45 +00:00
Bartosz Dziewoński b3b28dd1ab Ensure highlighted comment is defined before we try to show auto topic sub popup next to it
This was a logical merge conflict between 4912a1bf5c and 9ded06a655
that I didn't notice when rebasing the latter. Waiting for the
'mobile.init' module to load changes the order of operations if we're
highlighting the new comment after reloading a page, which we also do
after creating new talk page with the new topic tool.

Bug: T295945
Change-Id: Ief4810cc67c1bda9256585da1e2140b3a222dc5e
2021-11-18 16:01:00 +01:00
Bartosz Dziewoński 0110fe8b8d Ensure we won't set 'seenautotopicsubpopup' pref when not showing the popup
Change-Id: I20f1672bb40b07672474e81e7e59a440bf1f068b
2021-11-18 16:01:00 +01:00
Bartosz Dziewoński 3265b649cd Don't try to load 'mobile.init' on non-mobile
Change-Id: Ib988740e898f4163a1b97ba35a251c4275f44e80
2021-11-18 16:01:00 +01:00
Translation updater bot b3d36a8b62 Localisation updates from https://translatewiki.net.
Change-Id: Icd9929be60568e4c547c84c8eaf88631eeba6b62
2021-11-18 08:41:59 +01:00
jenkins-bot 9742bba6b8 Merge "Replace "Learn more" links with descriptive links in talk page empty states" 2021-11-17 23:36:14 +00:00
Bartosz Dziewoński 72f806829c Ensure form tokens are not longer than allowed
Bug: T295940
Change-Id: I4e3fd5d3ef21274b104c4d22e3bab11043d61334
2021-11-17 23:53:38 +01:00
Translation updater bot c86a3590c4 Localisation updates from https://translatewiki.net.
Change-Id: I45cbb1ec398fb2af21b4be2e34cb0757acf66f4c
2021-11-17 08:30:22 +01:00
Translation updater bot 45ef474109 Localisation updates from https://translatewiki.net.
Change-Id: I35e7d5785ae676db52471d7195d222dafb7c92b9
2021-11-16 08:16:02 +01:00
jenkins-bot e479c28459 Merge "First-run experience popup for automatic topic subscriptions" 2021-11-16 01:39:46 +00:00
Bartosz Dziewoński 9adbbccad8 Auto topic subscriptions disabled by default, enabled only for new users when out of beta
Bug: T294398
Change-Id: I909caaebbb976624a16f15361d4ee232007ff506
2021-11-15 23:36:03 +00:00
Bartosz Dziewoński 9ded06a655 First-run experience popup for automatic topic subscriptions
Bug: T262103
Change-Id: I9f9336718ad060d553146c4e27604565ce5822c6
2021-11-15 22:45:42 +01:00
Bartosz Dziewoński 90283b3a7e Update the [subscribe] buttons when auto-subscriptions are added
When our interface initialized on a page that the current user
recently edited (using the reply tool, the full-page source editor,
or any other way), check if any new automatic topic subscriptions
were added and update the interface to reflect that.

This requires doing some API requests after the page is loaded,
because adding auto-subscriptions happens asynchronously in a
DeferredUpdate (potentially after the user is already viewing
the page with their comment saved), and depends on the contents
of the edit.

(When using the reply tool, we could avoid this API request and
replicate the logic, but that's not implemented in this commit
to keep it simple.)

Bug: T284836
Change-Id: Ic0fabda0de4ebbc5e424f49641e6b03ebb4b7e6a
2021-11-15 22:45:42 +01:00
Bartosz Dziewoński 8d3cf30f60 Automatic topic subscriptions (only for reply tool and new topic tool)
Bug: T284836
Change-Id: I0f98c26c997f66b7a43cd4b971fe72a37d12db5d
2021-11-15 22:45:42 +01:00
Bartosz Dziewoński 0d57aa9762 Automatic topic subscriptions (on any edit)
Bug: T284836
Change-Id: Ia42ad087218fd91a0cdd1664157d1049738e3c01
2021-11-15 22:45:42 +01:00
jenkins-bot 9fbf2b3177 Merge "Avoid splitting about-groups starting with an empty <span>" 2021-11-15 21:38:56 +00:00
jenkins-bot 2b68d4f301 Merge "Test case for splitting about-groups starting with an empty <span>" 2021-11-15 21:37:36 +00:00
jenkins-bot ad7909affc Merge "List methods not covered by unit tests in TODO sections" 2021-11-15 20:53:18 +00:00
jenkins-bot 8082ffbc4f Merge "Messages for Automatic Topic Subscriptions feature" 2021-11-15 18:52:50 +00:00
Ed Sanders adf9f8dc88 Messages for Automatic Topic Subscriptions feature
Extracted from Ia42ad0872 and I9f933671.

Change-Id: I9b3e563071d879c0592bfbaab0d944b546cb5ee9
2021-11-15 18:21:37 +00:00
jenkins-bot f8d71d1263 Merge "Set a user preference to record whether the new topic tool has been used" 2021-11-15 16:57:41 +00:00
David Lynch bd40523843 Set a user preference to record whether the new topic tool has been used
This will be used for an upcoming A/B test.

Bug: T294167
Change-Id: I494b0b3cf3ae568bec2b9cef80aeb22306896769
2021-11-15 10:25:51 -06:00
Bartosz Dziewoński 83ba496919 Avoid splitting about-groups starting with an empty <span>
Usually this isn't a problem, because the comments are marked as
template-generated and we don't allow replying to them. But we had a
special case where we were trying to skip over some invisible
elements, which was causing us to skip into the middle of the
about-group in some cases. When Parsoid sees that, it serializes the
contents twice.

Bug: T290940
Change-Id: I9fe0b8d43ab874ccef371990799f77bfc46bc954
2021-11-15 16:03:38 +00:00
Bartosz Dziewoński e6de1c0462 Test case for splitting about-groups starting with an empty <span>
Bug: T290940
Change-Id: I632d351cf61980a48c0a16c4bdb3656dac83a584
2021-11-15 16:03:28 +00:00
Translation updater bot caa279718c Localisation updates from https://translatewiki.net.
Change-Id: Ibda93aa2194808c63f58238d97c0b72f450dd023
2021-11-15 08:11:36 +01:00
Ed Sanders 3f5756f495 List methods not covered by unit tests in TODO sections
Change-Id: Ia06c3c726b7bc9758454aa8b2f7ea34cbada4c09
2021-11-13 15:27:38 +00:00
Translation updater bot ce33b44e8a Localisation updates from https://translatewiki.net.
Change-Id: I0d0ca822f4587cddb8a4787d6e9f8576191226ed
2021-11-12 08:29:25 +01:00
Translation updater bot b80d960856 Localisation updates from https://translatewiki.net.
Change-Id: If8fd94242b63fa001835ec91f771f0096f8a768f
2021-11-11 10:02:07 +01:00
Bartosz Dziewoński 99b757465a Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'
Bug: T295490
Bug: T295491
Bug: T280051
Change-Id: I1b96b0a22eec9e364c2ecbe8b734cebd0d157b96
2021-11-10 22:24:07 +01:00
jenkins-bot 640f9cac65 Merge "Handle window resize in debug mode" 2021-11-10 19:55:02 +00:00
jenkins-bot e03820ed9d Merge "Suppress events from comments that are more than 10 minutes old" 2021-11-09 23:02:24 +00:00
jenkins-bot aeb7443715 Merge "CommentItem.php: Store timestamp object instead of string" 2021-11-09 23:02:22 +00:00
Ed Sanders 0fba9b0048 Suppress events from comments that are more than 10 minutes old
Bug: T290803
Change-Id: Ic0e23f439eef8a1b785f408d4557bec0abe9104b
2021-11-09 16:37:46 +00:00