wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-28 15:53:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
3561 commits 13 branches 4 tags 132 MiB
Commit graph

3561 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 42ce942c86 Introduce comment "names" to identify comments across revisions/pages 
The existing comment IDs can't be used to find the same comment on
a different revision or page (when it's transcluded), because they
depend on the comment's parent and its position on the page.

Comment names depend only on the author and timestamp. The trade-off
is that they can't distinguish comments posted within the same minute,
or in the same edit, so we will still need the IDs sometimes.

Prefer using comment names when replying, if they're not ambiguous.
This fixes T273413 and T275821.

Heading names depend on the author and timestamp of the oldest comment.
This way we don't have to detect changes to the heading text, but we
can't distinguish headings without any comments.

Bug: T274685
Bug: T273413
Bug: T275821
Change-Id: Id85c50ba38d1e532cec106708c077b908a3fcd49
 2021-03-23 16:08:42 +00:00
Ed Sanders b0a94405dc Remove deprecated dt- classes 
Change-Id: I4fb59f187bf3e31fd9c31841576b3f69aec23634
 2021-03-23 12:39:34 +00:00
Translation updater bot 755640284d Localisation updates from https://translatewiki.net. 
Change-Id: I54c5c6bfe6b1a92dd3f4d388bc3b021dd8c48b19
 2021-03-23 08:24:43 +01:00
Bartosz Dziewoński 9e255d82ca Remove compatibility code for 'data-mw-comment-start' change 
No longer needed.

This reverts commit f727c988a0.

Change-Id: Ib67d30890c6542bd0235dac6e49870c038d5dd86
 2021-03-22 21:17:34 +00:00
Bartosz Dziewoński b28290fa62 Simplify how warnings for IDs equal to legacy IDs are avoided 
I don't like the extra parameter.

Follow-up to d05109b24d.

Change-Id: Ic0f403a816fd3182982002da326bb32d591ebcf7
 2021-03-22 20:15:07 +00:00
Bartosz Dziewoński f727c988a0 Fix "TypeError: Cannot read property 'hasAttribute' of null" when loading on cached pages 
Follow-up to c4de603ef9.

Change-Id: I05dfb142e95e02715b56c2bd7c73bcfbb342fbfe
 2021-03-22 21:06:34 +01:00
jenkins-bot 536f50c293 Merge "Give comments IDs so they can be scrolled to with hash links" 2021-03-22 12:40:06 +00:00
Translation updater bot c8748b218b Localisation updates from https://translatewiki.net. 
Change-Id: Ibcfbe8188a3ae05978f0f791d0829fe602633f6c
 2021-03-22 08:36:25 +01:00
jenkins-bot 63cbd26047 Merge "Add explicit dependency on mediawiki.api" 2021-03-21 23:17:29 +00:00
jenkins-bot abb14d091a Merge "ReplyWidget: Hide external links icons in the anon warning" 2021-03-20 17:41:36 +00:00
Bartosz Dziewoński 86e5410df3 Add explicit dependency on mediawiki.api 
We require it, but it was only loaded by some other dependency.

Change-Id: Ibadc7987f53fe2d07c034e9c8b4da16e2c14b15f
 2021-03-20 17:34:38 +00:00
jenkins-bot c0b221126d Merge "Add accessibility labels to a few controls" 2021-03-20 16:50:33 +00:00
jenkins-bot 9d65658858 Merge "Improve mode selector keyboard interactions" 2021-03-20 16:50:31 +00:00
jenkins-bot 74980b78b5 Merge "Ensure ReplyWidgetVisual#getMode always returns a mode" 2021-03-20 16:39:49 +00:00
Ed Sanders c4de603ef9 Give comments IDs so they can be scrolled to with hash links 
Bug: T265268
Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
 2021-03-20 15:43:23 +00:00
jenkins-bot d05a39ddec Merge "Make IDs (to be used as URL hashes) wikitext safe" 2021-03-20 15:29:32 +00:00
jenkins-bot 37979df1a1 Merge "Ignore warnings about legacy IDs in tests" 2021-03-20 15:28:20 +00:00
Translation updater bot d1f35546b8 Localisation updates from https://translatewiki.net. 
Change-Id: I77d8b52e35287bb8278e005950e66a98fb94c9ba
 2021-03-19 08:25:00 +01:00
Ed Sanders 4a0802065c Make IDs (to be used as URL hashes) wikitext safe 
* Use hyphens instead of pipes a separators
* Use underscores for spaces in usernames

Change-Id: I6efd9739fc73e45002e50e64c43ce0de1c2f1239
 2021-03-18 20:45:21 +01:00
Bartosz Dziewoński a103abb8ae Ignore warnings about legacy IDs in tests 
Change-Id: I3c74b4e65aac9b84494917547cce7eb6a75995b4
 2021-03-18 20:42:03 +01:00
Bartosz Dziewoński 9da3949c47 Add accessibility labels to a few controls 
Topic title field and old wikitext reply field had only placeholders,
but no labels.

Mode selector had labels on individual items, but not on the main
control.

Change-Id: I422e7e5baa8711340a1bb82255e788f2272c45c9
 2021-03-18 15:15:40 +01:00
Bartosz Dziewoński 58c078437d Improve mode selector keyboard interactions 
When there are just two modes, using arrow keys to switch between
them is not intuitive. The focus moving from the selector to the
body widget afterwards is even less intuitive.

Override default TabOptionWidget to allow options to be highlightable
(not just immediately selectable), and mark the current mode's tab as
disabled instead of selected (but make it look selected).

This results in intuitive keyboard interactions (tabbing to the widget
highlights the other tab rather than the current one, pressing enter
switches to it).

Bug: T274423
Change-Id: I9d358d5f301cbf081380ef5d34ccc8c4e146652e
 2021-03-18 15:15:40 +01:00
Bartosz Dziewoński 1dbe907011 Ensure ReplyWidgetVisual#getMode always returns a mode 
In some situations we didn't pass the mode in the config.

Simplify some redundant code that got messed up when we
introduced the NWE source mode.

Change-Id: Ia838fc6752d411f70c8cc6a36d84d2a851fd68bd
 2021-03-18 15:15:40 +01:00
Bartosz Dziewoński 522b7932d7 ReplyWidget: Hide external links icons in the anon warning 
Similar to 282c987efa.

Change-Id: I0f6ca2d4aef114d7c8853df19140bbd27c20325a
 2021-03-17 15:50:34 +01:00
Translation updater bot 59fa9a5927 Localisation updates from https://translatewiki.net. 
Change-Id: I8592d9639c8dfa328d6bd8696838f2fd7d9a326f
 2021-03-17 08:24:51 +01:00
Translation updater bot 6f10f4a820 Localisation updates from https://translatewiki.net. 
Change-Id: Ie7992cd17e2dcd31252dac537210e3b7a8254be8
 2021-03-16 08:33:01 +01:00
jenkins-bot fcff49e15d Merge "Change dt- class prefix to ext-discussiontools-" 2021-03-15 16:51:48 +00:00
Translation updater bot de3c74e478 Localisation updates from https://translatewiki.net. 
Change-Id: Ibff565f3d4980c4e289146fde14a610483705ee6
 2021-03-15 08:40:19 +01:00
Ed Sanders ece8ff69ff Change dt- class prefix to ext-discussiontools- 
Longer, but follows the style guide and less likely to conflict.

We need to account for init classes in the cache being around for
a while.

Change-Id: I738bc93393850db320fdbda2b003ca8ac40556da
 2021-03-13 14:42:39 +00:00
libraryupgrader 1fca3fbd5c build: Updating eslint-config-wikimedia to 0.19.0 
Additional changes:
* eslint: Renamed `wikimedia/client` profile to `client-es5` (T277085).

Change-Id: I67378fec29920bc3208b723c2e118b45abf6558a
 2021-03-13 10:51:31 +00:00
Translation updater bot 2a0611a2b9 Localisation updates from https://translatewiki.net. 
Change-Id: I38a92d74416aca58c145824b58782c496a2e50e3
 2021-03-12 08:45:39 +01:00
Translation updater bot b24ec3be2b Localisation updates from https://translatewiki.net. 
Change-Id: I09646fad4c1a3736a5e3755f058ddda07105b860
 2021-03-11 08:37:03 +01:00
Translation updater bot d5b33021fb Localisation updates from https://translatewiki.net. 
Change-Id: I7f2cda683e51a35243f5722e99eeeed5bcab53df
 2021-03-10 08:31:55 +01:00
jenkins-bot 72f1ff092f Merge "Allow users to continue using reply tool after disabling A/B test" 2021-03-10 06:40:58 +00:00
Bartosz Dziewoński 68ad48f56f Allow users to continue using reply tool after disabling A/B test 
Bug: T276967
Change-Id: I1fa120ded9ac3673fd3e5005618b3312ffd0aaf5
 2021-03-09 22:20:03 +01:00
Bartosz Dziewoński 1a52f06daf Tweak signature formatting in previews for more accurate results 
When posting a new topic, if your comment ends with a template
that has trailing line breaks, the signature will be added as a
preformatted text (which is arguably a bug: T255741).

Preview, however, did not reflect this bug, because of the <span>
markup added to fade out the automatic signature.

Change-Id: I062b01a035e22edfca752a49c5e2433b3f7fb4f6
 2021-03-09 01:08:59 +01:00
Bartosz Dziewoński 44f2209abf Trim signatures when added in an empty existing node, too 
Add unit tests for appendSignature().

Bug: T276612
Change-Id: Ic44c52f4d54492e092f9396c626380e2637b6f0f
 2021-03-08 23:38:46 +00:00
jenkins-bot c33a7c45fe Merge "Add 'href' to reply links for better compatibility with skins" 2021-03-08 23:15:47 +00:00
jenkins-bot aab0c47caf Merge "Tracking changes from VE source mode" 2021-03-08 23:15:44 +00:00
Ed Sanders ccc19d8df2 Add 'href' to reply links for better compatibility with skins 
Change-Id: Id948d576bbe5a6d43c4f8a06cdb2cd8ad19be193
 2021-03-09 00:04:53 +01:00
jenkins-bot 0ca278455e Merge "CommentFormatterTest: Avoid re-serializing the HTML" 2021-03-08 21:47:53 +00:00
Ed Sanders 5324e60e84 Tracking changes from VE source mode 
Change-Id: I5cafa7a21a0ab90fab9d09e44b7525ee07f56709
 2021-03-08 21:13:10 +00:00
Translation updater bot 86c6d459ee Localisation updates from https://translatewiki.net. 
Change-Id: Ie77d419a0bb78404654c94a3c6b0b189a2093ba6
 2021-03-08 08:46:09 +01:00
jenkins-bot 42b70dff1c Merge "Always load init CSS when tools are available for a title" 2021-03-06 18:51:46 +00:00
libraryupgrader c2d4515819 build: Updating eslint-config-wikimedia to 0.18.2 
Change-Id: I4fb61bad6cfb8e06270d9e9da7e373823e70624d
 2021-03-06 13:45:27 +00:00
Ed Sanders 6224c11ff1 Always load init CSS when tools are available for a title 
Also, make init CSS available on mobile.

Bug: T274311
Change-Id: I8f63fdb249cdd8ccdc6d1c4944d2622ac7d668cc
 2021-03-06 12:08:50 +00:00
Translation updater bot 9403fb961c Localisation updates from https://translatewiki.net. 
Change-Id: I5fa2ce3ae26d316d5cf45c7b304575369d82bc9f
 2021-03-05 08:55:34 +01:00
jenkins-bot 17a3657b6a Merge "Follow-up I60e550ef: Don't show relevant user in mention list if it is you" 2021-03-04 22:09:57 +00:00
Ed Sanders 45cda20cf3 Don't attempt to put comment markers in <noscript> tags 
Bug: T276455
Change-Id: Ia427d97528b137111145ac79680972a660f28e37
 2021-03-04 22:24:04 +01:00
Ed Sanders 998bd206ae Follow-up I60e550ef: Don't show relevant user in mention list if it is you 
We have logic above to exclude mentioning yourself, but this
is overridden if you are commenting on your own talk page.

Change-Id: I2858c79bd9f1cb733f105825e17f9df75859e40a
 2021-03-04 20:59:00 +00:00