wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-24 02:48:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tracking changes from VE source mode

Browse source 
Change-Id: I5cafa7a21a0ab90fab9d09e44b7525ee07f56709
This commit is contained in:
Ed Sanders 2021-03-08 13:23:00 +00:00
parent 86c6d459ee
commit 5324e60e84
2 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/dt.ui.ReplyWidget.js
View file

@ -1,7 +1,9 @@
var controller = require( 'ext.discussionTools.init' ).controller,
modifier = require( 'ext.discussionTools.init' ).modifier,
utils = require( 'ext.discussionTools.init' ).utils,
logger = require( 'ext.discussionTools.init' ).logger;
logger = require( 'ext.discussionTools.init' ).logger,
dtConf = require( 'ext.discussionTools.init' ).config,
enable2017Wikitext = dtConf.enable2017Wikitext;
require( './AbandonCommentDialog.js' );
require( './AbandonTopicDialog.js' );
@ -395,8 +397,11 @@ ReplyWidget.prototype.onModeTabSelectChoose = function ( option ) {
// Switch succeeded
mw.track( 'dt.schemaVisualEditorFeatureUse', {
feature: 'editor-switch',
// TODO: Log as `source-nwe-desktop` when enable2017Wikitext is set
action: ( mode === 'visual' ? 'visual' : 'source' ) + '-desktop'
action: (
mode === 'visual' ?
'visual' :
( enable2017Wikitext ? 'source-nwe' : 'source' )
) + '-desktop'
} );
}, function () {
// Switch failed, restore previous tab selection

9
modules/logger.js
View file

@ -1,6 +1,8 @@
'use strict';
var trackdebug = !!mw.util.getParamValue( 'trackdebug' );
var trackdebug = !!mw.util.getParamValue( 'trackdebug' ),
dtConf = require( './config.json' ),
enable2017Wikitext = dtConf.enable2017Wikitext;
/**
* Logs an event to http://meta.wikimedia.org/wiki/Schema:EditAttemptStep
@ -240,9 +242,10 @@ mw.loader.using( 'ext.eventLogging' ).done( function () {
}
if ( data.feature === 'editor-switch' && data.action.indexOf( 'dialog-' ) === -1 ) {
// TODO: Account for `source-nwe-desktop` when enable2017Wikitext is set
// eslint-disable-next-line camelcase
session.editor_interface = session.editor_interface === 'visualeditor' ? 'wikitext' : 'visualeditor';
session.editor_interface = session.editor_interface === 'visualeditor' ?
( enable2017Wikitext ? 'wikitext-2017' : 'wikitext' ) :
'visualeditor';
}
} );
} );