Commit graph

3834 commits

Author SHA1 Message Date
Ed Sanders 4f217f4dab controller: Use replyWidgetPromise when opening new topic tool
This prevents an exception being thrown if you open the
new topic tool when a reply widget is still loading.

Change-Id: I17da48ddf91394d05cc82613ce5517f1e176750b
2024-01-05 16:20:30 +00:00
Ed Sanders b6ebb5db56 CommentController/ReplyWidget: Document events
Also rename CommentController#teardown to onReplyWidgetTeardown,
and NewTopicController#clear(Storage) to onReplyWidgetClear(Storage).

Change-Id: Ib1dd50ca69aac6f1836674d1a6aefa2402844c57
2024-01-05 16:20:30 +00:00
Ed Sanders 811dce7bf7 CommentController#showAndFocus: Use replyWidgetPromise
We shouldn't assume callers of this method have waited
for the replyWidget to be built.

Bug: T354292
Change-Id: Ic66b4f04b8786b07f520e329adda37efcf498dad
2024-01-05 15:26:19 +00:00
Translation updater bot 555cfcc622 Localisation updates from https://translatewiki.net.
Change-Id: Ie8d555bd837f0c58109aee0796a66febdc543b91
2024-01-05 09:12:31 +01:00
Bartosz Dziewoński 91d7cdb704 Remove "Read as wiki page" feature on mobile talk pages
Bug: T280417
Change-Id: I8f24531cbe1b6bb3f434c91a9523b0a11110d8e6
2024-01-04 19:34:48 +01:00
Translation updater bot 650253f046 Localisation updates from https://translatewiki.net.
Change-Id: Id62de6475ff9f281fef80878d191567136ed7d8b
2024-01-04 09:55:33 +01:00
Translation updater bot d00fd7d665 Localisation updates from https://translatewiki.net.
Change-Id: I54d3c943b5bbbcc550c4af4fbc3cfc74c75f6a4a
2024-01-03 08:34:23 +01:00
Translation updater bot fb69ea608b Localisation updates from https://translatewiki.net.
Change-Id: I1b1d1f01e86d479822e9061914315db96d7fc522
2024-01-02 10:15:59 +01:00
jenkins-bot a608bff9f8 Merge "tests: Fix tests when LiquidThreads is also installed" 2023-12-31 07:16:05 +00:00
Translation updater bot db3e7ec069 Localisation updates from https://translatewiki.net.
Change-Id: I6b2bde2b1acaf4dcd0761d06cd5759949d25abf1
2023-12-28 14:49:45 +01:00
Umherirrender 6f487698cc tests: Fix tests when LiquidThreads is also installed
Change-Id: Ica43e90fb3e48ddd20ad2b4130fb3a5efb3a4696
2023-12-27 23:07:24 +01:00
Translation updater bot 719cee1436 Localisation updates from https://translatewiki.net.
Change-Id: If4112b6f17ced30829506df41529778ec677a02e
2023-12-26 14:42:43 +01:00
Novem Linguae 3436e2d9e9 Refactor CommentFormatter->addTopicContainer()
To get ready for the subtopic subscriptions feature, this patch
separates the code that adds the topic container from the code
that adds the subscribe button.

The idea is that in the future, an H3 would need a subscribe
button, but not a topic container. Whereas an H2 would need both.

Bug: T275943
Change-Id: I6a82773ed200dcb4083ac38a4d41838f639c097e
2023-12-24 13:34:30 -08:00
Translation updater bot 631cd8352b Localisation updates from https://translatewiki.net.
Change-Id: I60f5e8277e8bd6651f9254cc9a673a4018b791fb
2023-12-22 17:45:48 +01:00
Translation updater bot e3e4b57f3f Localisation updates from https://translatewiki.net.
Change-Id: Iee2ecc8f25aa3f92395a2abe70a52303bedb60a5
2023-12-21 19:45:13 +01:00
jenkins-bot 6ff126eab5 Merge "CommentFormatter: Do not add wrapper if the heading has attributes" 2023-12-20 17:17:18 +00:00
Bartosz Dziewoński 6f92654137 CommentFormatter: Do not add wrapper if the heading has attributes
Bug: T353489
Change-Id: Idf49b40cd745b804dbad3c09960507790be20ae3
2023-12-20 16:56:12 +01:00
Translation updater bot 7effa10d98 Localisation updates from https://translatewiki.net.
Change-Id: I5ec148ff41875288f4d086576522eeb1689cdc39
2023-12-20 14:04:41 +01:00
jenkins-bot 3a2e10588b Merge "Tweak CSS to deal with Parsoid's <section> tags" 2023-12-19 16:50:41 +00:00
jenkins-bot 35ce6582df Merge "Localisation updates from https://translatewiki.net." 2023-12-18 17:22:28 +00:00
jenkins-bot 2d2bcc05ce Merge "ContentCommentItem.php: Documentation fixes" 2023-12-18 17:21:36 +00:00
jenkins-bot 078f57b427 Merge "ThreadItem.js: Rename getNativeRange to getRange" 2023-12-18 17:21:34 +00:00
Translation updater bot 3d3d42478c Localisation updates from https://translatewiki.net.
Change-Id: I8fb6e9aa6783da82b532839d92cf5336c092ff9e
2023-12-18 18:17:04 +01:00
David Lynch 95121b7364 Stop comment-not-found notification always showing when requestedSince
`TEST && false || true` is always true regardless of `TEST`, we want
`TEST && (false || true)` instead.

Bug: T353568
Change-Id: I72fa6b87f43a9d8439883dfedc35fe82974b35de
2023-12-16 09:20:19 -06:00
Ed Sanders 84bc45adf1 ContentCommentItem.php: Documentation fixes
Change-Id: I5ee1c3e1b79f4e9bdab417c68ff447313ecb752d
2023-12-15 17:05:22 +00:00
Ed Sanders 329a268564 ThreadItem.js: Rename getNativeRange to getRange
Makes the class more similar to PHP. The non-native
ranges exist for efficiency, but users will usually
want native ranges.

Change-Id: Ifd7dd034d2e0f3b9af050ecdab3e063df73dde5e
2023-12-15 16:22:52 +00:00
jenkins-bot 70bd4e8f0e Merge "Avoid global state in tests involving CommentParser" 2023-12-15 16:21:21 +00:00
jenkins-bot 8e2d172960 Merge "CommentParser: Replace new uses of Title with TitleValue" 2023-12-15 16:21:19 +00:00
jenkins-bot bf9fc18120 Merge "Move finding transclusion source from ContentThreadItem to CommentParser" 2023-12-15 16:17:13 +00:00
jenkins-bot a77338fd6d Merge "Revert "Temporarily disable isPreview in Parsoid's rendering"" 2023-12-14 17:24:02 +00:00
Subramanya Sastry 1cf6000d18 Revert "Temporarily disable isPreview in Parsoid's rendering"
This reverts commit d004c001be.

Reason for revert: Visual diff done and results gathered.

Change-Id: Iefb0c74a121346286a353dae6cb795b86aa636ce
2023-12-14 14:16:41 +00:00
jenkins-bot 797bd2ea0b Merge "ThreadItemStore: Omit redundant updates to avoid warnings" 2023-12-14 11:06:45 +00:00
Bartosz Dziewoński ab2a83601a Use SQL expression builder instead of buildLike()
Follow-up to c82783a5b6.

Change-Id: If844b601b3887d5f853fb9f56be2741896114698
2023-12-14 11:55:34 +01:00
Bartosz Dziewoński 1e5dc67c36 ThreadItemStore: Omit redundant updates to avoid warnings
Bug: T353432
Change-Id: Ib095d622e549139efdd050cadc87ac9dd6a1f318
2023-12-14 10:54:16 +00:00
Translation updater bot 92daada02b Localisation updates from https://translatewiki.net.
Change-Id: I6a6685bc1d3405ce19f04984350aa4401ead4be3
2023-12-14 08:27:24 +01:00
Translation updater bot dbcf55494f Localisation updates from https://translatewiki.net.
Change-Id: I65d741bf65a3010ddf039190c8311d98b95f4bee
2023-12-13 08:40:47 +01:00
Subramanya Sastry d004c001be Temporarily disable isPreview in Parsoid's rendering
This will let us render reply links on wikitech and run visual diffs
(which runs in anonymous user mode). This will be reverted after
the visual diff test run.

Change-Id: Ibf175a7f5b1e68f66c257fc26ba9e4b55f752fbd
2023-12-12 14:08:46 -06:00
Subramanya Sastry 8671171b35 Remove checks for missing title info in ParserOutput extensiondata
This data was added to core in I328f533e6cdb11c0c3a873d23bab1a113dfa39be
and it will have been in production for 4 weeks next week which is
enough for all content to have rolled over.

Change-Id: I3d568eed56446f26aa329bfa554d609b8bcb973a
2023-12-12 14:08:46 -06:00
Bartosz Dziewoński 70022c4cee Avoid global state in tests involving CommentParser
Instead of setting global configuration variables, we create a custom
config object and all the other dependencies and pass them to the
CommentParser instead of the defaults.

Depends-On: I8d374b51511a2873dce646aa453c5e0e2c076a14
Change-Id: I9dfccc833d3e2695cf1d1f7bbee4b68eae9a8c25
2023-12-11 22:19:14 +01:00
Bartosz Dziewoński cc9cccbd35 CommentParser: Replace new uses of Title with TitleValue
Follow-up to Ic718a964e309ae3a8e15e299081f46d4db860731.

Change-Id: Ida70ee080de44ec36f11c3c40816f6a198b63798
2023-12-11 22:19:13 +01:00
Bartosz Dziewoński a27e27fc68 Move finding transclusion source from ContentThreadItem to CommentParser
Reasons:
* Various other methods dealing with ranges already live there
* It would be neat if ContentThreadItem was just a value class
  without a lot of logic, similar to DatabaseThreadItem,
  particularly for writing unit tests
* The methods access global state through Title, which can't
  be fixed while they're in ContentThreadItem (see I9dfccc83)

The computation is now always done, instead of only when needed,
but that's a small drawback, since it's fast (fast enough that
I don't see the difference in the time taken when running tests),
and we were already computing it for all comments in many places.

Change-Id: Ic718a964e309ae3a8e15e299081f46d4db860731
2023-12-11 22:18:30 +01:00
jenkins-bot ba7e8417a6 Merge "WikiImporter: Pass Authority for permissions instead of global context" 2023-12-11 19:49:59 +00:00
Umherirrender 64bcb583e9 Use namespaced classes
Done automatically via script
Change to extension.json done manually

Change-Id: Ied7bbddd357290ac6be6bf480be0ee9116e77365
2023-12-11 16:38:02 +01:00
Translation updater bot 64b0b0e259 Localisation updates from https://translatewiki.net.
Change-Id: I3810690deb02b7830618f7975b0c1dfd9ca196c4
2023-12-11 10:43:04 +01:00
jenkins-bot 264869a561 Merge "ReplyWidgetVisual: Replace deprecated selectLastContentOffset call" 2023-12-08 23:33:00 +00:00
Bartosz Dziewoński 855af15fba WikiImporter: Pass Authority for permissions instead of global context
Depends-On: Iea1d03dcdcbda2f9a9adbff1b0d319efd22c4d86
Change-Id: I4ec83fe0a887398a216e2b0392dfa852218fef1e
2023-12-08 22:16:16 +01:00
jenkins-bot b49339f13d Merge "Remove { passive: true } from removeEventListener" 2023-12-08 17:04:32 +00:00
Translation updater bot 4e0e32314b Localisation updates from https://translatewiki.net.
Change-Id: I04e6df5d81f53bb6bd7a729f3ba8c83344fcbbc5
2023-12-08 14:45:21 +01:00
Ed Sanders b60be160ac ReplyWidgetVisual: Replace deprecated selectLastContentOffset call
Change-Id: I80b64ec1d3ecf1985c29a8efc3d072778ffe783f
2023-12-08 11:09:20 +00:00
Ed Sanders a853e6f3d2 Remove { passive: true } from removeEventListener
This option doesn't exist when removing an event.

Change-Id: I2449fec2b2368f829d93eea9a13c13aea1ab75f8
2023-12-08 10:59:40 +00:00