wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-27 17:51:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

ThreadItemStore: Omit redundant updates to avoid warnings

Browse source 
Bug: T353432
Change-Id: Ib095d622e549139efdd050cadc87ac9dd6a1f318
This commit is contained in:
Bartosz Dziewoński 2023-12-14 11:50:40 +01:00
parent 92daada02b
commit 1e5dc67c36
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/ThreadItemStore.php
View file

@ -678,7 +678,11 @@ class ThreadItemStore {
// which are causing conflicts (T339882, T343859#9185559)
->onDuplicateKeyUpdate()
->uniqueIndexFields( [ 'itr_itemid_id', 'itr_revision_id' ] )
->set( $newOrUpdateRevRow )
// Omit redundant updates to avoid warnings (T353432)
->set( array_diff_key(
$newOrUpdateRevRow,
[ 'itr_itemid_id' => true, 'itr_revision_id' => true ]
) )
->caller( $method )
->execute();
return $dbw->affectedRows() ? $dbw->insertId() : null;