Commit graph

2808 commits

Author SHA1 Message Date
Bartosz Dziewoński 482a2c6dd0 ThreadItemStore: Move some work in insertThreadItems() outside transactions
As suggested in the discussion on T315353.

Bug: T317236
Bug: T317237
Change-Id: I8d9f2e3d4779a2e2f433a8fffea2767ae986bc48
2022-09-29 21:34:15 +02:00
Ed Sanders f9d8b7afd5 Reduce padding around reply button slightly to improve vertical alignment
Change-Id: Ia420f1d6bf1038bfe803c62aba636f046d74bb29
2022-09-29 14:42:11 +01:00
jenkins-bot 0bf1b9e6a1 Merge "Add config to separate out visualenhancements on mobile" 2022-09-29 10:57:27 +00:00
jenkins-bot 0510c84175 Merge "Fix double <div class="mw-parser-output"> after saving" 2022-09-29 07:40:55 +00:00
Translation updater bot 34cab2db62 Localisation updates from https://translatewiki.net.
Change-Id: I3eda1b2bc04a8e4a45c088993739884bdd62647b
2022-09-29 08:27:14 +02:00
Bartosz Dziewoński 4d1722d1e6 Fix double <div class="mw-parser-output"> after saving
Follow-up to d00fa80ff4. .html()
replaces the inner HTML, .replaceWith() replaces the outer HTML.

Change-Id: I8da2d24d439acc5e83ef1f42959fefef27bbea71
2022-09-29 01:26:33 +02:00
David Lynch d5161bf086 Add config to separate out visualenhancements on mobile
Follow-up to d0126ce6de which made them
default-on for all mobile. These two taken together mean that the
mobile visual enhancement features now *only* depend on this config,
rather than on whether the individual features are enabled on desktop.

Bug: T318871
Change-Id: If767753e6d33f19bbc540d4e74273e478198388c
2022-09-28 17:12:48 -05:00
jenkins-bot f910e54802 Merge "Empty state banner: Improve selector for hiding top border" 2022-09-28 16:30:45 +00:00
Ed Sanders 79d4879b3a Empty state banner: Improve selector for hiding top border
Pages can be empty (blanked) without outputting the noarticletext
class, so just suppress the top border if the banner is the first
child of the document.

Change-Id: I808160a7f73a9a976d25e77f4bd47727a57b70c0
2022-09-28 17:04:42 +01:00
jenkins-bot f4f83bfb2f Merge "Show mf-section-0 in preview" 2022-09-28 15:45:29 +00:00
jenkins-bot 8a2e02e8e1 Merge "Suppress top border when section follows <h1>" 2022-09-28 15:40:07 +00:00
jenkins-bot 3436684b2c Merge "Only hold on to a Config instead of ConfigFactory when injecting" 2022-09-28 14:22:46 +00:00
jenkins-bot d0126ce6de Merge "Visual enhancement features are now part of the mobile set" 2022-09-28 14:16:02 +00:00
Ed Sanders df96154538 Show mf-section-0 in preview
Bug: T318758
Change-Id: I12039696bfe0f06e21b28ed32fdfc23442033805
2022-09-28 14:38:20 +01:00
Translation updater bot 56725cb098 Localisation updates from https://translatewiki.net.
Change-Id: Iee45ac860d96e71d0382196c47cb15bc1a1a90ca
2022-09-28 08:21:13 +02:00
jenkins-bot 99c772d4ee Merge "Add mw.track call when comment setup fails" 2022-09-27 22:32:08 +00:00
David Lynch 3a42623fef Visual enhancement features are now part of the mobile set
Bug: T318302
Change-Id: I494e4dd6d2133d110499420ffc57f45a29999748
2022-09-27 16:09:05 -05:00
jenkins-bot 5a5ad9f8df Merge "Always scroll "Loading..." text into view" 2022-09-27 19:16:23 +00:00
jenkins-bot 5d92f638f3 Merge "Move "Return to comment" below sticky header when present" 2022-09-27 19:16:20 +00:00
jenkins-bot adc3344f5f Merge "Fix TODO about ParsoidClient::getPageHtml() params" 2022-09-27 10:43:00 +00:00
Translation updater bot 7654f86129 Localisation updates from https://translatewiki.net.
Change-Id: I248cc9f89609664219874c56728a6b4a4a4631ba
2022-09-27 08:32:04 +02:00
Bartosz Dziewoński 0a5cded42c Fix TODO about ParsoidClient::getPageHtml() params
Depends-On: Id9a450dc8b8eb3e82cf87718b96975e5a3c6180c
Change-Id: I35ce516187fb8dcde24bc35278378496f471e211
2022-09-26 22:50:07 +02:00
Translation updater bot 9ca9bd1355 Localisation updates from https://translatewiki.net.
Change-Id: I75fff58586f1dbb28faa22b57d2c0454a458def7
2022-09-26 08:15:04 +02:00
Ed Sanders f6df39c11a Always scroll "Loading..." text into view
If the widget has just been opened, it should already be in view,
but when we are recovering from auto-save it might not be.

Scrolling it into view lets the user know sooner that a draft is
about to be recovered.

Change-Id: I2b8232edc20e71b04a3f106107c0c7bc6333f66a
2022-09-25 13:28:14 +01:00
Ed Sanders 688cdc24ae Move "Return to comment" below sticky header when present
Also ensure that when we click the button, we scroll the widget fully
into view below the sticky header.

Bug: T318474
Change-Id: I394f02912cd6ab2773552a7364691ef89a17369c
2022-09-25 13:28:12 +01:00
jenkins-bot fb7a25ce91 Merge "PreferenceHooks: Avoid referring to the field of disabled feature" 2022-09-24 23:30:44 +00:00
jenkins-bot 63acbf4dfc Merge "Add Korean special page aliases" 2022-09-24 23:26:00 +00:00
Translation updater bot 5f94a9bf00 Localisation updates from https://translatewiki.net.
Change-Id: I1667584f86a919a1f7a25e8c9e6a95983cd12466
2022-09-23 08:29:00 +02:00
jenkins-bot 43f95c18c3 Merge "Tweak topic container margins on desktop" 2022-09-22 15:32:34 +00:00
Translation updater bot 74305d71ed Localisation updates from https://translatewiki.net.
Change-Id: Iacfcb8b6929589488f40d6c136f86f648314375b
2022-09-22 08:45:57 +02:00
Ed Sanders a9488a9ead Suppress top border when section follows <h1>
Bug: T318198
Change-Id: I550dd240fe629d0159448ea49d49195de0166a25
2022-09-21 21:39:40 +01:00
Translation updater bot f22e68ff86 Localisation updates from https://translatewiki.net.
Change-Id: If151368b3b904ffde201c2545bb2919dd10f346b
2022-09-21 08:28:42 +02:00
jenkins-bot 169b4c74ad Merge "ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names" 2022-09-20 16:46:51 +00:00
na1307 1c1d7b3c5d
Add Korean special page aliases
Change-Id: I87c827d6f113b7d8d46eb60a6cd65ad6c679587c
2022-09-20 17:01:54 +09:00
Translation updater bot 855eef1c2a Localisation updates from https://translatewiki.net.
Change-Id: I23ddaa79e5f7982a6008bea4d234730841a7504f
2022-09-20 08:33:56 +02:00
David Lynch 9ee2301f1e ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names
Computing the name, for headings, requires determining the oldest
comment. This must not be done before all the replies are added to the
thread.

Follow-up to e24550fae9. It was
already *technically* incorrect before then because it was generating
the name based on the first comment in the thread, but that was only
not the oldest in very unusual cases so it was fine. That commit caused
the thread summary to be cached when first requested, however, which
made future requests for oldest/newest comment and authors to be
incorrect.

Bug: T318057
Change-Id: If0bd6caf88e72cd3f91e7f0633c40b445f5e2246
2022-09-19 14:13:51 -05:00
jenkins-bot 82f107af7e Merge "Add @covers CommentUtils to tests that use it" 2022-09-19 16:57:18 +00:00
jenkins-bot b594a99a12 Merge "Use margin to position comment marker to avoid Chrome bug" 2022-09-19 16:57:16 +00:00
jenkins-bot 77514eb01f Merge "Replace VisualEditor ParsoidHelper with ParsoidClient" 2022-09-19 16:33:13 +00:00
Bartosz Dziewoński 2679fa3b04 Replace VisualEditor ParsoidHelper with ParsoidClient
Depends-On: I21c4a8cd86f8d085e75a601ed6d2509dedd75d42
Change-Id: I9533d7c05047c2d873c8c6ee5944df965e3b379d
2022-09-19 18:00:14 +02:00
Translation updater bot 3695b13fd7 Localisation updates from https://translatewiki.net.
Change-Id: I37764caac2b80d143fbb93a79c6f96d8603758f1
2022-09-19 08:24:20 +02:00
Ed Sanders 0265d401c2 Add @covers CommentUtils to tests that use it
Change-Id: I35d2d0d75bfdbe17fe186eb5cfb47a850a9d6f6a
2022-09-16 13:22:43 +02:00
Ed Sanders fcdabc5fcc Only filter code coverage at the class level
Many methods are covered indirectly, and using method-level
@covers filters means these are reported as not being covered.

Change-Id: I94eb3e8c48209ff0b6bfc09e18c93555bb167e8f
2022-09-15 14:08:30 +02:00
Translation updater bot 80590f1457 Localisation updates from https://translatewiki.net.
Change-Id: I9e536b12107bbae4940c0b6bcf4498db047fbfe2
2022-09-15 09:54:53 +02:00
Translation updater bot 35fa4a5dd9 Localisation updates from https://translatewiki.net.
Change-Id: I664e5e348cc171c62d3ddcb92abd8cd264fe1e2f
2022-09-14 10:31:29 +02:00
Ed Sanders 39502b4f9a Use margin to position comment marker to avoid Chrome bug
Bug: T317135
Change-Id: I627d92fabaa9d9e477279041d3c40a7c6bfe37c8
2022-09-14 10:01:53 +02:00
Ed Sanders 516ea4a970 Tweak topic container margins on desktop
Bug: T314449
Change-Id: I021dbd33f211fcdc5ef2fea1d99212df772053b4
2022-09-14 09:59:39 +02:00
David Lynch 968250bb02 Add mw.track call when comment setup fails
Bug: T310390
Change-Id: I6df98032469931276ea096a008fdf8f63893dff5
2022-09-14 01:23:07 -05:00
Func 8820940dfd PreferenceHooks: Avoid referring to the field of disabled feature
The GlobalPreferences extension would remove disabled fields from
the form, avoid referring to it in the disable-if param.

Bug: T317526
Change-Id: I6ec177a1f20855c90eb4ea17bb6625c75e5b9617
2022-09-13 09:32:09 +00:00
Translation updater bot 93713ffab4 Localisation updates from https://translatewiki.net.
Change-Id: Ica2690ef08200f5df41df3d900d33029688f4d3a
2022-09-13 09:25:54 +02:00