Commit graph

3812 commits

Author SHA1 Message Date
Ed Sanders b4e4f30234 ThreadItemStore: Remove "ButTryHarder" from method name
This appears to reference the retry that happens due to
REPEATABLE_READ, but that seems like an implementation
detail so not really useful to have in in the function
name, nor does it disambiguate it from another function.

Change-Id: Iacc95b74f25c166545734818efb1b30e18a1754e
2024-02-21 15:56:32 +00:00
Translation updater bot 1bd3a78966 Localisation updates from https://translatewiki.net.
Change-Id: I7f73b9e8a4a1ed44476fc3bb2edd873fa8a229f6
2024-02-20 08:38:22 +01:00
Ed Sanders 5ba0bfa026 Remove temporary newsectionlink_enable config
This was intended as a temporary config to facilitate a
staged rollout (T331635) which has now completed.

Change-Id: I432ec0a24b8e8c12b62556ff6703abff32a2fced
2024-02-19 17:34:23 +00:00
Translation updater bot db5ced1db0 Localisation updates from https://translatewiki.net.
Change-Id: I602cd51c8f07b4dc1287788635d98e7574e873c2
2024-02-19 08:40:06 +01:00
jenkins-bot c12427f150 Merge "tests: Rebuild expected 'timestamplink' output" 2024-02-17 03:20:19 +00:00
Bartosz Dziewoński 08f61b2609 Support for core section heading formatting in post-cache transform
We already supported plain headings without the 'mw-headline'
wrappers, but now we need to parse the 'id' from a different
attribute.

Needed-By: If04d72f427ec3c3730e757cbb3ade8840c09f7d3
Bug: T357723
Change-Id: If85f89c40834618f23dc0ace2e599efb3b6d5ed4
2024-02-16 20:28:53 +00:00
Bartosz Dziewoński 7bee77d5fd Remove unused '*-formattedreply.html' test files
They were renamed in 9c68e058ef, but
b82af45735 accidentally added them back.

Change-Id: Ic0eaa09492d637f4dc54904856621ee1eb930a58
2024-02-16 19:28:05 +01:00
Bartosz Dziewoński 37257d68cf tests: Rebuild expected 'timestamplink' output
When rebuilding expected outputs by running the tests with
'DISCUSSIONTOOLS_OVERWRITE_TESTS=1', our code outputs the
JSON keys in a specific order (not alphabetical).

Change-Id: Ice57948ef1d4b780ae18cfcbb2e7373f518c8abc
2024-02-16 19:27:55 +01:00
jenkins-bot 85f75fb8ed Merge "Parser: Minor code cleanup" 2024-02-16 12:40:19 +00:00
jenkins-bot a386c3a251 Merge "Remove "Read as wiki page" feature on mobile talk pages" 2024-02-15 23:42:09 +00:00
Translation updater bot 6441b78bd7 Localisation updates from https://translatewiki.net.
Change-Id: I299dc07b3801034800a18953327c83bd633fd178
2024-02-15 13:28:04 +01:00
Bartosz Dziewoński ef13c65d55 Use standard gray color for timestamp links
Bug: T275729
Change-Id: I122155f02a7cd771f358b7536909bc5f59abee2c
2024-02-15 03:23:53 +01:00
Subramanya Sastry 3b2de5b10e Properly handle preview scenario for Parsoid rendering
* Removed a wikiech-specific hack and use the now available
  ParserOutput flag.

Change-Id: Ia06025c131485a9dc67afd8258fa4b3753d165b9
2024-02-14 15:32:47 -06:00
Translation updater bot 46a3e15dfb Localisation updates from https://translatewiki.net.
Change-Id: Ic0a87cf2a005c8f81a6490aed480166ddf28d7d6
2024-02-14 08:18:40 +01:00
jenkins-bot 6da23e4d00 Merge "Comment MonoBook fixes which are actually Apex fixes" 2024-02-13 16:45:56 +00:00
Ed Sanders c99e07881d Comment MonoBook fixes which are actually Apex fixes
Change-Id: I44ddc7ad4cef556b71fb3f6710d92500dfd4e9ac
2024-02-13 13:54:38 +00:00
jenkins-bot 0abf8517cc Merge "CommentParser: Add test case for already-linked timestamp" 2024-02-12 20:41:13 +00:00
Ed Sanders 9590a7297d CommentParser: Add test case for already-linked timestamp
Follow-up to 8069585489.

Bug: T356142
Change-Id: Iae9e165f00cc8bfedeb057f113e1c8c5ba7e3bf1
2024-02-12 20:33:06 +00:00
Translation updater bot 533dc4ca27 Localisation updates from https://translatewiki.net.
Change-Id: I000f57da42778ab775b7d224718145c55dea3763
2024-02-12 14:49:24 +01:00
libraryupgrader 6cd913cdc1 build: Updating mediawiki/mediawiki-phan-config to 0.14.0
Change-Id: Ib8324bc6a0a63d5153f278f6b5e6af1b1b4be9fd
2024-02-10 16:48:20 +00:00
jenkins-bot 7c33fe3950 Merge "ThreadItemStore: Add ->caller() in queries" 2024-02-10 05:40:22 +00:00
jenkins-bot 7e5104ced8 Merge "Reduce opacity of overflow menu button" 2024-02-10 00:10:08 +00:00
Ed Sanders bb579ef4c6 Reduce opacity of overflow menu button
This is still an experimental feature and not deployed
anywhere, but as we mute the timestamp to indicate it
is more part of the interface than the content, we should
do the same with this overflow menu button.

Change-Id: I30391912377692fffa9e67e8c4ca63db715878bf
2024-02-09 23:53:20 +00:00
Bartosz Dziewoński fc4d70f9f5 ThreadItemStore: Add ->caller() in queries
It makes it easier to find the queries in debug logs in production.

Change-Id: I80f94d1fc8c49227218b07234e162445cc43ca00
2024-02-09 19:16:55 +01:00
Translation updater bot ddea94a867 Localisation updates from https://translatewiki.net.
Change-Id: Ic755252251bfba62512c68cc86b1f23b488808a0
2024-02-09 08:43:45 +01:00
jenkins-bot 8d97a28ada Merge "Add test cases for the main loop getting stuck on some signatures" 2024-02-08 17:28:31 +00:00
jenkins-bot 26abd2383d Merge "Fix collapsed sections when recovering autosave on mobile, take 2" 2024-02-08 16:38:22 +00:00
Bartosz Dziewoński 6a1f2accee Parser: Minor code cleanup
We had some unused variables and roundabout checks.

Change-Id: I454b60ffa05c1cc12288c5de88c849a25aa35447
2024-02-08 16:59:04 +01:00
Bartosz Dziewoński f4090865d4 Add test cases for the main loop getting stuck on some signatures
Follow-up to 9db35873a4.

Bug: T356884
Change-Id: Ifef490209fdee2b9f52d3ef81a92ea20c5ff2155
2024-02-08 16:59:01 +01:00
Translation updater bot ddba94eb88 Localisation updates from https://translatewiki.net.
Change-Id: I98c45b2a474188dbc1dc088fbf62100b920beb88
2024-02-08 09:15:03 +01:00
jenkins-bot 297f4f01dd Merge "Parser: Fix the main loop getting stuck on some signatures" 2024-02-07 22:01:56 +00:00
jenkins-bot c1049da7d5 Merge "Use Parsoid HTML to drive notifications" 2024-02-07 21:36:56 +00:00
Bartosz Dziewoński 9db35873a4 Parser: Fix the main loop getting stuck on some signatures
In certain cases the parser could go back rather than forward after
finding a signature, causing it to find the same signature forever
until it ran out of memory.

Test cases coming later in a separate patch.

Bug: T356884
Change-Id: I8ac72b05e5e4ed45e6119c012a69708c9d8eda29
2024-02-07 22:33:57 +01:00
Translation updater bot f9fb45a455 Localisation updates from https://translatewiki.net.
Change-Id: Ia1507f94f836a987298444ed9be072a9d5b97927
2024-02-07 08:26:43 +01:00
jenkins-bot 6816c15a03 Merge "Fix exceptions on weirdly encoded URLs" 2024-02-05 22:22:02 +00:00
jenkins-bot 4c2442eeb6 Merge "Ignore transcluded items when finding permalinks" 2024-02-05 21:46:08 +00:00
jenkins-bot e4e8cab1da Merge "Fix unexpected margin on footer links in new topic tool" 2024-02-05 17:20:35 +00:00
Translation updater bot f608a94941 Localisation updates from https://translatewiki.net.
Change-Id: I9cfd8d819d5590e1c85cd6c71efb5be973dc7be9
2024-02-05 08:49:36 +01:00
Bartosz Dziewoński 3957d7ac25 Fix collapsed sections when recovering autosave on mobile, take 2
Follow-up to 8a8c7270cf.

I think this wasn't working becase we were doing it in the wrong
order (reply tool initialization would disable toggling section
state before toggler toggled it open).

Bug: T338920
Change-Id: I7ed3d5c149ddb3d33cb67010f032c63e175687f2
2024-02-04 00:21:45 +01:00
Bartosz Dziewoński f7a8ba08fb Ignore transcluded items when finding permalinks
* Keep the information about this in the API result, which we were
  previously omitting
* Use it instead of duplicating the logic client-side

Bug: T356131
Change-Id: I7e7342e9d94a171b5ef56e646871c18c8c39c44c
2024-02-04 00:07:37 +01:00
Bartosz Dziewoński 1bb3b597ec Fix exceptions on weirdly encoded URLs
`decodeURI( fragment )` can throw if the fragment isn't correctly
encoded – e.g. when it's just '#%'.

Use mw.util.percentDecodeFragment() instead, which uses a more
resilient algorithm.

Change-Id: I8447771ad2ae33da52b71d4127981dd8a2018a7d
2024-02-03 23:48:54 +01:00
Bartosz Dziewoński d0c72f155a Fix unexpected margin on footer links in new topic tool
The new topic tool is not nested in .mw-content-ltr/-rtl,
so the rule did not apply.

Change-Id: If231170f7ab394be075d4d936b8be4c8ae97931c
2024-02-03 23:37:21 +01:00
Bartosz Dziewoński 0f6bdcf9cb Add first basic tests for ThreadItemStore::find*() methods
Just covering the basic scenarios of having comments on the page and
archiving them.

Bug: T356575
Change-Id: I9022b0a7cf3b02bd9f2f2d5605823eec21b92642
2024-02-03 23:14:08 +01:00
jenkins-bot 9f650c92ee Merge "Add more search methods to findNewestRevisionsByHeading" 2024-02-03 21:47:55 +00:00
Ed Sanders df7d101cd2 Use decodeURI for comment ID searches as well as heading searches
Bug: T356199
Change-Id: I8d366c706692caf89a2af9f11c14a9aad9422b7c
2024-02-02 17:34:26 +00:00
Translation updater bot 6feddf4938 Localisation updates from https://translatewiki.net.
Change-Id: I2346f70e62b7c62d4d38ec4afd83631760dd0599
2024-02-02 08:53:19 +01:00
Ed Sanders 8b99c1fbbe Add more search methods to findNewestRevisionsByHeading
In production, indexing the full history of every page will take
too long, so we can't rely on being able to find the target heading
text in the history of the current page.

When this search fails, fall back to the following searches:
* The heading appears in the current revision of a sub-page
* The heading appears anywhere on the wiki, but only once

Bug: T356276
Change-Id: I90e92cb9c85aaf6fb2355f842450981bbe6abf2d
2024-02-01 18:32:36 +00:00
Translation updater bot 4bb3ae7d1f Localisation updates from https://translatewiki.net.
Change-Id: Id0a4cfbe24def17ad1bf866655a1472e47ef3a41
2024-02-01 09:01:39 +01:00
Translation updater bot 6408fe3a41 Localisation updates from https://translatewiki.net.
Change-Id: Ie3796fb8ba5676d97c7e0f82ff0efa0d30c82e63
2024-01-31 08:28:59 +01:00
David Lynch 7b941aae1c Add an exception for ConvenientDiscussions-style permalinks
Bug: T349653
Change-Id: I775774084bb8abf2bc99475b426d581bed306306
2024-01-30 16:44:30 -06:00