Commit graph

4694 commits

Author SHA1 Message Date
jenkins-bot ef8c8e6006 Merge "Make the filter field on ViewHistory of "int" type" 2019-03-17 12:00:47 +00:00
jenkins-bot dc0c5cc5ac Merge "Make uploads testable" 2019-03-17 11:06:43 +00:00
jenkins-bot 8588c35142 Merge "Simplify AbuseFilterVariableHolder::dumpAllVars" 2019-03-17 11:04:53 +00:00
jenkins-bot f63b7e8039 Merge "Remove the hacky 'context' variable" 2019-03-17 10:35:31 +00:00
Daimona Eaytoy 3211c71739 Make uploads testable
This patch adds missing methods for testing a filter against uploads in
RC. Please note that (as discussed below) using wfFindFile could be
relatively expensive (as it will be executed for 0-100 RC rows).
If this is true, then we should either use another method (but I
couldn't find a suitable one), or simply reduce the amount of testable
uploads to a reasonable limit.

Bug: T170249
Change-Id: Id406d4e1571873f49bb11e69029311b24ececf49
2019-03-17 11:32:56 +01:00
jenkins-bot de4e971c72 Merge "Remove usage of MakeGlobalVariablesScript hook" 2019-03-17 10:32:30 +00:00
jenkins-bot 4c63c9190c Merge "Remove deprecated DB method" 2019-03-17 10:08:50 +00:00
jenkins-bot 3f3e98fbc5 Merge "Fix shortcircuit for consecutive operations" 2019-03-17 10:04:14 +00:00
jenkins-bot 001a83272d Merge "Add help links for throttle groups" 2019-03-17 09:59:25 +00:00
jenkins-bot e2f1880922 Merge "Don't use wgLang and wgContLang" 2019-03-17 09:53:16 +00:00
jenkins-bot b4780723e4 Merge "Fix faulty query in normalizeThrottleParameters" 2019-03-17 09:50:39 +00:00
jenkins-bot d11f30f7ec Merge "Make text fields use readonly instead of disabled" 2019-03-17 09:49:40 +00:00
jenkins-bot 65a4c26804 Merge "Remove exclusions for Generic.Files.LineLength" 2019-03-17 09:49:38 +00:00
jenkins-bot 92fdb2ce90 Merge "Make Special:AbuseFilter sortable by filter name" 2019-03-17 09:48:29 +00:00
Daimona Eaytoy 7449b43c2f Remove deprecated DB method
Database::nextSequenceValue is deprecated and just returns null.

Change-Id: I8109e90ab836b5915873da26da87ea9225e2ff03
2019-03-17 09:38:46 +00:00
Kunal Mehta 577f4dab93 Migrate to new phan
Bug: T216904
Change-Id: I30864bd3d7f9b9ab674bf6589cd9e5e3aed5bb8d
2019-03-16 09:41:23 +00:00
Daimona Eaytoy 53ab2b5067 Fix documentation errors reported by Phan
Change-Id: I5788147ba1998235ded9eedbf64ebad37fce236f
2019-03-16 09:27:05 +00:00
Translation updater bot 768af21c10 Localisation updates from https://translatewiki.net.
Change-Id: Ia2d9b679777db7846e12a13aa0864b8a8290abc8
2019-03-15 22:35:44 +01:00
Translation updater bot 68bf88f062 Localisation updates from https://translatewiki.net.
Change-Id: I4e3f8c8a5d67939032895963e083bba331801d2b
2019-03-14 22:51:39 +01:00
Translation updater bot 217ad90792 Localisation updates from https://translatewiki.net.
Change-Id: I727caf44e961b6d2bcff47e41be5dca40e0603be
2019-03-13 22:16:05 +01:00
Translation updater bot c280cdc8c4 Localisation updates from https://translatewiki.net.
Change-Id: I5488d3cc8de49b03048706177d890ea5722a4d67
2019-03-12 22:29:12 +01:00
jenkins-bot fc00915d7d Merge "Don't escape externalLink text" 2019-03-12 06:00:47 +00:00
Translation updater bot 53920f3b0c Localisation updates from https://translatewiki.net.
Change-Id: I0c49e687e580da20ba47eb55ccdcdf27b78cd066
2019-03-11 22:16:23 +01:00
Daimona Eaytoy 6158d96c41 Don't escape externalLink text
As escaping is handled by makeExternalLink itself. This currently makes
seccheck fail for any patch and is a merge blocker.

Change-Id: I2d21632bbc59abd4ea48aebdb6572d53f8fc89cd
2019-03-11 13:23:49 +01:00
Translation updater bot 8f3fb5b7e1 Localisation updates from https://translatewiki.net.
Change-Id: I5db09a0e9580ec883f02beb4cb89b8a2fdb93587
2019-03-10 22:27:15 +01:00
Translation updater bot 04b5e91c27 Localisation updates from https://translatewiki.net.
Change-Id: I3f973d70f5c0b252b4efba1745fe8c73845c3a5f
2019-03-08 22:28:51 +01:00
Translation updater bot 9cb4c7f4e8 Localisation updates from https://translatewiki.net.
Change-Id: I4d8d19e842cc0602688eb95e3541fb6ad6f2c9c7
2019-03-05 22:42:32 +01:00
Translation updater bot 1858638897 Localisation updates from https://translatewiki.net.
Change-Id: Ia4e0e347b2abec9e72cd5e7d3c7a431f015e4426
2019-03-04 22:15:54 +01:00
Translation updater bot a0d5a63167 Localisation updates from https://translatewiki.net.
Change-Id: Id301b3c91c412b45f03eaa2ddb92e521f905acbe
2019-03-03 22:17:08 +01:00
Daimona Eaytoy ef025c0ce2 Make Special:AbuseFilter sortable by filter name
Only if the user is privileged, though, otherwise ID and name may be
associated.

Bug: T217520
Change-Id: Ida8886308be97de70078664f5f4641b93deab95f
2019-03-03 19:07:38 +01:00
Umherirrender da682f78ac Use ::class for class name resolution
Available since php5.5

Change-Id: Ie60465484858867d507081dfe5a305c6ab0599de
2019-03-03 01:41:40 +01:00
Translation updater bot c8236499e8 Localisation updates from https://translatewiki.net.
Change-Id: I9991a6b1b1e1a4e1dd5eb32ac5201c7a3197c18f
2019-03-02 22:42:12 +01:00
Daimona Eaytoy 1244960435 Fix faulty query in normalizeThrottleParameters
The DESC must be specified in the ORDER BY clause, or it will return the
first row instead of the last. Plus select only needed fields and remove
deprecated Database::nextSequenceValue.

Bug: T209565
Change-Id: I48f83f64d406c553a55ac4bbee700d59002e6a18
2019-03-02 12:57:41 +00:00
Matěj Suchánek 99c2749511 Fix issues with SQLite
Bug: T199507
Change-Id: I273de5ebafeee76458a5b873e893044b683c34ca
2019-03-01 10:44:58 +01:00
Translation updater bot d305a9635e Localisation updates from https://translatewiki.net.
Change-Id: Icdbca8fb2b07007087115c508cbee2ccf1e7f57f
2019-02-28 22:24:16 +01:00
Daimona Eaytoy c49707e463 Make text fields use readonly instead of disabled
So that they're easier to read, and because readonly is semantically
more appropriate.

Bug: T217143
Change-Id: I76be8e7fb1cf46efd0c03cde74344be6cb2a0902
2019-02-27 11:52:59 +01:00
Translation updater bot 3e114498f2 Localisation updates from https://translatewiki.net.
Change-Id: I2b145a22e310291370a5e4906cf532cfd5d81b09
2019-02-25 22:57:13 +01:00
Kunal Mehta 85cb0531f0 Add missing use statement
Spotted by phan 1.2.4.

Change-Id: I1d2c417881a88c41dc382f583e4a0b6cddc0048f
2019-02-23 21:29:43 -08:00
Kunal Mehta cb1458f91e Fix parameter order in doc comment
Spotted by phan 1.2.4.

Change-Id: I63aff03d48f1749e03d3398016ead01bc37fe73d
2019-02-23 21:29:39 -08:00
Kunal Mehta 5d1ab854f9 Fix caching in AFComputedVariable
Spotted by phan 1.2.4.

Change-Id: I6ff924e08cc7d8d837b44228dfb26c8d15c810c4
2019-02-23 21:28:47 -08:00
Daimona Eaytoy dd4b579695 Remove exclusions for Generic.Files.LineLength
Keep it only for filters definitions in ConsequencesTests.

Change-Id: I305c7f496a29b20a3ee1d34479d1e4cb9252060a
2019-02-23 10:12:07 +01:00
Thalia 540a557a59 Replace calls to deprecated Block::prevents
Where prevents is used as a setter, use the new setter methods;
where it is used to determine whether a block blocks the target
from editing their talk page, use appliesToUsertalk.

Block::prevents was deprecated and replaced by several other
methods in I0e131696419211.

Bug: T211578
Change-Id: I166cc6f64c0f895ff8c631d2655c1c3208131371
2019-02-22 19:29:02 +00:00
Translation updater bot de6560fb20 Localisation updates from https://translatewiki.net.
Change-Id: I3ccdfdc829e7c0c979795ce1a6005c1a5359e3ef
2019-02-21 22:20:16 +01:00
Translation updater bot ed4ecd5267 Localisation updates from https://translatewiki.net.
Change-Id: I3ea7e36650c5603813a7401bd44b1596c2e43580
2019-02-19 22:19:38 +01:00
Thiemo Kreuz 3993a7ea15 Replace @expectedException with $this->expectException()
The @expectedException annotation got deprecated in PHPUnit 7.5, and
removed in PHPUnit 8.0. This was done because the annotation does have
two disadvantages:
* The class name is encoded in string, where it is not easy to find for
  all IDEs and tools.
* it did not allow to say exactly *when* the exception is expected.

Change-Id: I85f0b5f44b2f400a121115d402b64827ea534c32
2019-02-19 10:58:16 +01:00
Translation updater bot 7a8b1ae811 Localisation updates from https://translatewiki.net.
Change-Id: Ic637db688e5ce40d3425ccb05e22a308a64fa74f
2019-02-18 22:22:38 +01:00
jenkins-bot 6745b9a994 Merge "Fix a typo in EmergencyDisable globals description" 2019-02-18 20:32:39 +00:00
Daimona Eaytoy 6e2b66f96d build: Update eslint-config-wikimedia to 0.10.1
And exclude no-global-selectors for now...

Change-Id: I0cea497ff8d8c749ea4f365c968428af01e85d18
2019-02-18 19:26:42 +01:00
MarcoAurelio 8f56c681c7 build: Update banana to v. 0.7.0
Change-Id: I3c1d52f3cf0e4a2d7ed5e288ab126b12ba56b938
2019-02-18 11:39:38 +00:00
Translation updater bot a2a8985255 Localisation updates from https://translatewiki.net.
Change-Id: Ib1afc13fa0b86967a4d0d0363140c47b7b1fcdaf
2019-02-17 22:13:34 +01:00