Commit graph

1230 commits

Author SHA1 Message Date
jenkins-bot c4ef80638e Merge "Add the log ID as API param for query abuselog" 2018-07-15 15:08:39 +00:00
Translation updater bot 20dc4301f8 Localisation updates from https://translatewiki.net.
Change-Id: I26e90ad47cb9e691406db27092f65c0153fe2841
2018-07-14 22:20:14 +02:00
Daimona Eaytoy d390144c69 Add the log ID as API param for query abuselog
The patch adds the logid parameter to the queryAbuseLog API, so that
users will be able to retrieve a single result with the given logid.

Bug: T36731
Change-Id: I9160c3690e86ea40560f6fa7721918965234c29e
2018-07-14 15:03:17 +02:00
Daimona Eaytoy 0e87c44c74 Show AF logs for a revdeled revision if the user can see the revision
The function used to determine if a row is hidden has three possible
return values: true, false and "implicit". While the first and the
second one refer to AF own suppressing system, 'implicit' means that the
revision associated with the log entry is deleted. However, we checked
for such return value with a boolean cast, which caused true and
'implicit' to be equally treated, thus hiding revdel'ed revisions to
sysops. Bonus: fixed a comment typo.

Bug: T191699
Change-Id: I87d3a6437bb966198175e4bfd063e30ed79c345f
2018-07-14 00:46:19 +02:00
Daimona Eaytoy b8a2225bb2 Warn the user to re-attempt save if edit token didn't match
I've been noticing this problem for a long time: sometimes, when the
filter editor stays open for a long time and you try to click "save filter",
the page is scrolled and the edit isn't save (while it is indeed saved
when clicking save again). I found out that this is due to edit token
not matching. If that happens and the request was posted, warn user to
re-save the edit.

Change-Id: Id0c5600bf22632f57d237a19b492cc9c297be736
2018-07-13 15:40:29 +02:00
Translation updater bot cb0c43133b Localisation updates from https://translatewiki.net.
Change-Id: If69916aa1aff6a6405c6047052cb8378a63b68d4
2018-07-12 22:38:17 +02:00
Translation updater bot 8adffed8af Localisation updates from https://translatewiki.net.
Change-Id: I623f5644d60c6e9fcd13cd882c439cdba55f8511
2018-07-11 22:39:28 +02:00
Translation updater bot d74e0baaa6 Localisation updates from https://translatewiki.net.
Change-Id: I4f63b1c8cb73f27b6a63a3751687e48b193bcd1c
2018-07-10 22:15:33 +02:00
Translation updater bot b066abef8c Localisation updates from https://translatewiki.net.
Change-Id: Ic1c38eae0bf0a6335a07b10429640017c8b4073a
2018-07-09 22:10:44 +02:00
Translation updater bot 5b7a5672de Localisation updates from https://translatewiki.net.
Change-Id: Ibe117886fec4fee42d64c05cef66f837262d7dbe
2018-07-07 22:52:24 +02:00
Daimona Eaytoy 33b1b12b92 Reserve abusefilter-condition-limit tag
Right now it can manually be added when creating filters. Since the
distinction is interal to AbuseFilter, we can't use hooks to achieve the
goal (the tag isn't already usable from outside AF). Also making
isAllowedTag public to make it testable.

Change-Id: I75ce47d247cf6949117370c8c78ab7c6980538f3
2018-07-06 16:43:12 +02:00
Translation updater bot d7cd1de386 Localisation updates from https://translatewiki.net.
Change-Id: I63148d4fc20b5fc9920acecb15a0d885db961b4c
2018-07-05 22:43:28 +02:00
Translation updater bot 97904a38b7 Localisation updates from https://translatewiki.net.
Change-Id: I47dc7c15e4d2ed525bbd85246a3d2b06f4c0f1ac
2018-07-03 22:16:24 +02:00
Translation updater bot 735e8466b8 Localisation updates from https://translatewiki.net.
Change-Id: I82293aa87794c8a922f5d5a36131df250177800b
2018-07-02 22:10:17 +02:00
jenkins-bot 8d9a564aee Merge "Add colon to "Action type" field on Special:AbuseFilter/test" 2018-07-01 21:43:40 +00:00
Translation updater bot f1a661a132 Localisation updates from https://translatewiki.net.
Change-Id: I97ae16e57c087f7b2474aecbb3b7f0f2ea268b38
2018-07-01 22:06:01 +02:00
Translation updater bot d0a00ce049 Localisation updates from https://translatewiki.net.
Change-Id: I039e2a4f8fa68d7c161ab63c27cfc568f860e19c
2018-06-30 22:30:08 +02:00
Translation updater bot e645ddcdf8 Localisation updates from https://translatewiki.net.
Change-Id: Ib543b2c037fc163a541f1c960bc794ac1cb9f7d0
2018-06-29 22:24:59 +02:00
Guycn2 b40ded69cf Add colon to "Action type" field on Special:AbuseFilter/test
(for consistency with other fields on this page)

Change-Id: I21209cd335e6d6d65378963cbef908f928c84569
2018-06-29 03:41:25 +00:00
Daimona Eaytoy 3a1ec5d229 Add missing i18n for sanitize function
The function was added with Ic916a6f8976e486d62d65156fa2dab56a55cf22a
but doesn't have messages for the dropdown.

Change-Id: Ibd7567a2b5277f6529e796a38871846abbfb4d54
2018-06-29 00:52:19 +02:00
Translation updater bot 877d8ea608 Localisation updates from https://translatewiki.net.
Change-Id: I94ab0a54d237a90ea4a06364f8395b9e2719d234
2018-06-28 22:20:47 +02:00
Translation updater bot 74f5327e3f Localisation updates from https://translatewiki.net.
Change-Id: I99fdcdff35b586fed06e14d379c7dbf23d1beb19
2018-06-27 22:17:48 +02:00
jenkins-bot 8b0f289e10 Merge "Stop computing removed variables and show custom error message" 2018-06-27 00:20:38 +00:00
Translation updater bot cfc1724f13 Localisation updates from https://translatewiki.net.
Change-Id: Iff2ac997739610ec49474d9fd08654729ff07087
2018-06-26 22:13:34 +02:00
Daimona Eaytoy 79ec4ebf8b Stop computing removed variables and show custom error message
Old_text and old_html were disabled a long time ago. With this patch,
the user will get a custom error message if trying to use them (instead
of the unrecognisedvar one), plus they'll stop appearing in /examine and
/details, unless they were computed for the examined edit (and in that case, their description message is now restored). Lastly, added a precisation to their messages.

Bug: T190698
Change-Id: Ife168522e6b1d8eb94ebbb8a16ae8831ec1dc497
2018-06-26 20:02:31 +02:00
Daimona Eaytoy c75bc35f7d Rename lists to arrays
Arrays were introduced with the name "lists". While it **may** look
user-friendlier and so on, it actually uses a wrong name: lists are
different from arrays. I ran a grep and I should've replaced
every occurrence, plus everything seems to work, however a double check
wouldn't be bad.

Change-Id: I6a858f02f5dd9250ba7e1abf9c6422fd98758c9e
2018-06-26 14:42:23 +02:00
jenkins-bot 240e264833 Merge "Make /test filterable by action type" 2018-06-26 01:24:16 +00:00
jenkins-bot 625f1b92cd Merge "Reduce form whitespace on Special:AbuseFilter and compact variables" 2018-06-26 01:18:04 +00:00
Daimona Eaytoy 1394da924f Make /test filterable by action type
Bug: T20288
Depends-On: I2c51b695262b132a5c7cdfab20d56e36f43c7448
Change-Id: I9887c586955c1a1b34dbe641a8f9ad34de7a2e1d
2018-06-26 00:48:09 +00:00
Translation updater bot e5b0846197 Localisation updates from https://translatewiki.net.
Change-Id: I10e13e33936b8fccfe45600a982960e4b35a4d53
2018-06-25 22:22:00 +02:00
Translation updater bot d4db0b49d4 Localisation updates from https://translatewiki.net.
Change-Id: I54f6b256343018d4a04b9ccecdd46cc62526195c
2018-06-24 22:25:18 +02:00
Daimona Eaytoy 3c1dae9e14 Allow users with abusefilter-view-private to use testing interface
Now the required need will be abusefilter-modify OR
abusefilter-view-private for /tools, /test and /examine.

Bug: T193903
Change-Id: I3f1a91a2cc1df2272e5d4099cefd7c649a0683d5
2018-06-24 14:10:38 +00:00
Translation updater bot 4d97779c51 Localisation updates from https://translatewiki.net.
Change-Id: I2489b2da7cd75dfdd082e6a343726b266441a0a7
2018-06-21 22:42:20 +02:00
Daimona Eaytoy fcc07db95c Reduce form whitespace on Special:AbuseFilter and compact variables
The conversion to OOUI brought some extra whitespace that creates some
problems while viewing the page, especially with specific skins. This
patch compacts four different form fields in a single one, having the
side benefit of reducing the amount of used variables.

Bug: T189425
Change-Id: I75aa83e36d12db65d8b54c76b3ea14c8c797215e
2018-06-19 12:13:29 +02:00
Translation updater bot 0e4df34261 Localisation updates from https://translatewiki.net.
Change-Id: I43d59b7b098b2fbdf7b11be0b5562dabd38b3329
2018-06-18 22:09:25 +02:00
Translation updater bot 58ed24048d Localisation updates from https://translatewiki.net.
Change-Id: I5d47cdfd497ade70800e0fa33c8256c916b0d6a7
2018-06-17 22:27:46 +02:00
Translation updater bot 9dfbd0d63b Localisation updates from https://translatewiki.net.
Change-Id: Ibdb83009f28a5649021ed053c7a90de0a720f061
2018-06-16 22:25:54 +02:00
Translation updater bot 03158e1272 Localisation updates from https://translatewiki.net.
Change-Id: I75bc6d1a4fb91ea0a32efc0a37ae10b312a12910
2018-06-15 22:35:34 +02:00
Translation updater bot c31f384f5d Localisation updates from https://translatewiki.net.
Change-Id: I5dae60f0f98a523ad3f851d88326a32e9e0e1f20
2018-06-14 22:44:15 +02:00
Translation updater bot 18b46d71cb Localisation updates from https://translatewiki.net.
Change-Id: I68db4a2ea26ba7fc6a89f79f8cf3badf3791b42e
2018-06-13 22:22:27 +02:00
Translation updater bot e2232714f8 Localisation updates from https://translatewiki.net.
Change-Id: Iaa5e133700405433dae57dfcb9da0c6727ff25b4
2018-06-11 22:33:20 +02:00
jenkins-bot a4a6511972 Merge "Don't allow invalid IP ranges to be entered in ip_in_range()" 2018-06-10 00:33:27 +00:00
Translation updater bot 2dfc0b62d8 Localisation updates from https://translatewiki.net.
Change-Id: I0ab4a872a8d5094ab084bf9e6f8c0795189da6e6
2018-06-09 10:26:30 +02:00
Daimona Eaytoy cf4ac34420 Show throttled filters in Special:AbuseFilter
With this patch, filters which are both enabled and throttled have an
"actions automatically disabled" label together with "enabled" and the
row is displayed in red. Plus, some minor changes like removing unused
fields from sortable ones and added a comment to getQueryInfo about used
columns (the idea is that it'll be easy to understand if a given column
is already there, plus if we'll need the missing one we may just replace
it with '*').

Bug: T154206
Change-Id: Iab157d094cbf2d50e9db537535fd48243e74af0b
2018-06-08 21:54:58 +02:00
jenkins-bot 1981c9f8b8 Merge "Add an option to hide private filters on Special:AbuseFilter" 2018-06-08 19:46:53 +00:00
Translation updater bot 1eb684447e Localisation updates from https://translatewiki.net.
Change-Id: Ic3643bd782a3366e4eca15589e037131e30cc56f
2018-06-06 23:05:43 +02:00
Translation updater bot 5a0efd342f Localisation updates from https://translatewiki.net.
Change-Id: Id76dc8fa759fceaa3e09c498a8e609a60ae9c628
2018-06-05 22:16:33 +02:00
Daimona Eaytoy 43ec6cf830 Add an option to hide private filters on Special:AbuseFilter
While the change itself is simple, the only problem here is the desing,
since we're adding even more vertical space with this.

Bug: T164108
Change-Id: Ic5373dd4f0b85dc1311d90ac165d4520ac956e68
2018-06-04 11:21:18 +00:00
Translation updater bot 384c70ffc8 Localisation updates from https://translatewiki.net.
Change-Id: I67b2295ebf1e824c76a01a9ac252fbae3cd751aa
2018-06-03 22:35:54 +02:00
Translation updater bot 7afce94ecd Localisation updates from https://translatewiki.net.
Change-Id: I4b0f7fbdc24808810c45af23c321fb40bb1c350f
2018-06-02 22:41:09 +02:00
Translation updater bot e23ca56bbb Localisation updates from https://translatewiki.net.
Change-Id: I2983fba32d2a5883085058e872d5ee024f9ff599
2018-06-01 22:27:20 +02:00
Translation updater bot dee7bc6a33 Localisation updates from https://translatewiki.net.
Change-Id: Ic95c2e6a86b7c029b9ef00124bf5e4d47f48c350
2018-05-31 22:28:17 +02:00
Translation updater bot ecb919e5de Localisation updates from https://translatewiki.net.
Change-Id: I29c343434513ac82400698e534cd24b73066b6ae
2018-05-29 22:24:34 +02:00
Translation updater bot 296605472d Localisation updates from https://translatewiki.net.
Change-Id: I9322124272a25293829094b9f6e62880fb686bc7
2018-05-28 22:41:43 +02:00
Translation updater bot 751b27181f Localisation updates from https://translatewiki.net.
Change-Id: I5763f4f16c825492bda7dd2ddd6fdbb19b241d0c
2018-05-25 22:13:56 +02:00
Translation updater bot 2bd7ec820a Localisation updates from https://translatewiki.net.
Change-Id: Ic3c3bbcef9b6338c25ebc142ffb3c788a1a52ae8
2018-05-24 22:24:42 +02:00
Translation updater bot cce90f853a Localisation updates from https://translatewiki.net.
Change-Id: Ibacdb826324e656612208d32ca8b5d50eec80b99
2018-05-23 22:20:05 +02:00
Translation updater bot 55715e1b38 Localisation updates from https://translatewiki.net.
Change-Id: I9119e8d680c27fea459dcc9bb4fb8cb6e9073693
2018-05-21 22:10:12 +02:00
Translation updater bot 0804a7ea12 Localisation updates from https://translatewiki.net.
Change-Id: I1c2421a7f3d47a85be339ac5f37548a8ab73dab4
2018-05-20 22:44:15 +02:00
Translation updater bot b9332d03af Localisation updates from https://translatewiki.net.
Change-Id: I4b4cc31fb002e0b9537c38909f9c529467bcf951
2018-05-18 22:48:07 +02:00
Translation updater bot c5acd6b009 Localisation updates from https://translatewiki.net.
Change-Id: I676e94e2ff64c8941c21b1d6a6df0ef3da5d2030
2018-05-17 22:19:28 +02:00
Translation updater bot 83877949a4 Localisation updates from https://translatewiki.net.
Change-Id: I9a95a4362a932988c83ce168f0cb3b030d8e18be
2018-05-15 22:24:18 +02:00
Translation updater bot cfa6ca65a3 Localisation updates from https://translatewiki.net.
Change-Id: I5915a6defe62816dd8ffcfaff99b3453cbf57420
2018-05-14 22:44:02 +02:00
Huji Lee 959a32258f Use PLURAL in newly added i18n message
Addresses an issue with I0ec6a27ff5f37aae864dfd91161bf44f0a217ef1

Change-Id: Iebbba14ac37cddcd56a8bd0c8fb1b6ff2a68bf72
2018-05-13 16:58:33 -04:00
Translation updater bot 97d460b03f Localisation updates from https://translatewiki.net.
Change-Id: Ia94e7c76b491934474c994541fb0cb8db49c0549
2018-05-13 22:17:41 +02:00
Daimona Eaytoy 91c5f6d5b9 Improve the i18n message for throttling to show in history
With the introduction of custom block durations in Ib072433d19dabae48d8514e08be9893135b5d63c, the method which generates action display was enlarged in order to provide a more readable and complete message. However, for throttling we currently have an unreadable message like "Throttle: xx, yy, zzz". This is wrong for two reasons: first, those numbers need to be deciphered; second, the first number is the filter ID which is totally unuseful here.

Change-Id: I0ec6a27ff5f37aae864dfd91161bf44f0a217ef1
2018-05-13 13:29:45 +02:00
Translation updater bot 25b4482ee8 Localisation updates from https://translatewiki.net.
Change-Id: I1d4f141b64c5c0a8d30783244adf6c3ac25c0405
2018-05-11 22:24:45 +02:00
Translation updater bot 47fa731e54 Localisation updates from https://translatewiki.net.
Change-Id: I4a399490a758cf329080ec8f6cbdf2f87da11a39
2018-05-10 22:20:12 +02:00
Translation updater bot 99aa54c63a Localisation updates from https://translatewiki.net.
Change-Id: Icc710afb4cfd4171c595f536e32ffa1c628bcdb4
2018-05-09 22:40:42 +02:00
Translation updater bot 0513162de4 Localisation updates from https://translatewiki.net.
Change-Id: If9cffacb3f5e6b907422ee6410ae95518aac2ba1
2018-05-08 22:19:34 +02:00
Daimona Eaytoy 69c8929468 Add an option to hide bots in /test
Pretty self-explanatory and straightforward, since recentchanges has a
dedicated column for bot edits.

Bug: T193994
Change-Id: I76d41e082aed262640e9fff856eeb97df49633d5
2018-05-07 17:25:40 +02:00
Translation updater bot 9137a2ec41 Localisation updates from https://translatewiki.net.
Change-Id: I5e4f0a2c8df77c501f508b7ac6c9d8c483d95194
2018-05-06 22:21:46 +02:00
Translation updater bot 92ca600311 Localisation updates from https://translatewiki.net.
Change-Id: If1e3760628d2bc972a5cbf8d1290c48cd0ae0af1
2018-05-05 22:13:56 +02:00
Translation updater bot 0409f815d5 Localisation updates from https://translatewiki.net.
Change-Id: If8d93f97d7a769099e898e3b21c8f8a67deb8f47
2018-05-04 22:14:30 +02:00
jenkins-bot 479cce9f58 Merge "Show "blocktalk" in AbuseFilter diff and improve message generation" 2018-05-03 23:22:44 +00:00
Translation updater bot a70c823eba Localisation updates from https://translatewiki.net.
Change-Id: I5909405f62cdcdca7cb0beddbc682065162f620a
2018-05-03 22:20:43 +02:00
Daimona Eaytoy 80ef9d442a Show "blocktalk" in AbuseFilter diff and improve message generation
Quite self-explanatory. If the talk page is blocked, a sentence is
added, otherwise it remains as it is. Plus, improved the way messages
are generated and reduced their reuse.

Bug: T193692
Change-Id: I01f5113ca586b94c25e1102c73d158ebb01c5a4b
2018-05-03 21:11:13 +02:00
jenkins-bot 5ba7903675 Merge "Don't let enabled filters be marked as deleted" 2018-05-02 22:27:37 +00:00
Daimona Eaytoy 632c8e77e2 Don't let enabled filters be marked as deleted
Adds both client-side and server-side validation.

Bug: T156619
Change-Id: If16975dd394cfdb3c57ff263366c2fc865de362a
2018-05-02 22:20:53 +00:00
Translation updater bot 5a78718773 Localisation updates from https://translatewiki.net.
Change-Id: I0964cbda4d1a3a892839e97428eea70a1e3efaf8
2018-05-02 22:16:10 +02:00
Translation updater bot 6558d07eae Localisation updates from https://translatewiki.net.
Change-Id: Ibdc2cb62880df3b12dc647f4e699e311ff24a7d7
2018-05-01 22:11:36 +02:00
Translation updater bot 1d04847a06 Localisation updates from https://translatewiki.net.
Change-Id: I184f95c793092d0210f90ce0cccf12b6bb5c91a0
2018-04-30 22:21:44 +02:00
Translation updater bot 128fe988b3 Localisation updates from https://translatewiki.net.
Change-Id: I497256570bb9a2bb581c82b097f9d4e15ca62f43
2018-04-29 22:30:48 +02:00
jenkins-bot a267c7be8a Merge "Fix i18n for equals_to_any" 2018-04-29 13:51:25 +00:00
Translation updater bot 4c214289d7 Localisation updates from https://translatewiki.net.
Change-Id: Ia38d4fbd68b458c3afa76c4e66f01c04d3fa0f4d
2018-04-28 22:32:34 +02:00
Translation updater bot 64614ad673 Localisation updates from https://translatewiki.net.
Change-Id: I020959c376623e405115ea67deddae61a46781fb
2018-04-27 22:25:31 +02:00
Daimona Eaytoy fb325948b6 Fix i18n for equals_to_any
I wrongly wrote that it's used for strings, while it actually accepts
any kind of argument. Also, specified the used operator.

Change-Id: I6d3545517a83f56f7393a1d1f99ce61d480e333d
2018-04-26 22:28:23 +02:00
Translation updater bot 8b1fdb8a7c Localisation updates from https://translatewiki.net.
Change-Id: I4628fc7418c0ef11583e9a50051d9521da4f8fee
2018-04-26 22:16:17 +02:00
jenkins-bot 04325d0f99 Merge "Add equals_to_any function" 2018-04-25 23:26:04 +00:00
jenkins-bot 5c8b6cf3a6 Merge "Fix typo in i18n message" 2018-04-25 23:21:19 +00:00
Daimona Eaytoy 71f375f19a Add equals_to_any function
Introduce a new function which can be used to group multiple comparisons
in a single condition. In particular, equals_to_any(S, A, B) is the
equivalent of S === A || S === B. This is especially useful in checking
for multiple namespaces, as proposed in the Community health initiative.

Change-Id: I9dcfe303eb5e51e1882fe4a65fa876aa93db7686
2018-04-25 23:12:19 +00:00
Translation updater bot 1f8b5db73f Localisation updates from https://translatewiki.net.
Change-Id: Iaf87f7dbdfbfa56c49caf0fb9fee2437a55588b0
2018-04-25 22:38:15 +02:00
Daimona Eaytoy 61cd27972d Fix typo in i18n message
As pointed out on phab, there's a space missing here. Fixing as proposed
there.

Bug: T172617
Change-Id: I6b74f511bbae481a93e3a174d40928445096148b
2018-04-25 18:24:16 +02:00
Translation updater bot 220597e214 Localisation updates from https://translatewiki.net.
Change-Id: I3ee8e2d3cbb37a04f0961df3d721b9e6507e4809
2018-04-24 22:22:05 +02:00
Translation updater bot fb9b947a67 Localisation updates from https://translatewiki.net.
Change-Id: Iac620ebd10bc24276b1492de63094e84dd598b5a
2018-04-23 22:29:57 +02:00
Translation updater bot 44f1c0a7a8 Localisation updates from https://translatewiki.net.
Change-Id: I9008645e7150e1ae31e578590f7dc89d91f9be23
2018-04-22 22:21:12 +02:00
Translation updater bot 5e2fa0ab1e Localisation updates from https://translatewiki.net.
Change-Id: I5c77ed3aca76470838c24ab2c30c7173f633e65e
2018-04-21 22:15:20 +02:00
Translation updater bot e58674664c Localisation updates from https://translatewiki.net.
Change-Id: I97a0eea8bf7e9fda8126b1a380189ab2c061171a
2018-04-20 22:12:39 +02:00
Translation updater bot 1658bc176f Localisation updates from https://translatewiki.net.
Change-Id: I74d8bb7eb066ed3b0a4331d721eb3777b9efd90d
2018-04-19 22:13:27 +02:00
Translation updater bot d1070e5956 Localisation updates from https://translatewiki.net.
Change-Id: If84e411c1a785f94a21feffc7ed912ff7825afe3
2018-04-18 22:10:26 +02:00
Translation updater bot e7654c986f Localisation updates from https://translatewiki.net.
Change-Id: Iccddef22e482a702d42c49f67d6e71e473b96c14
2018-04-17 22:24:48 +02:00
Translation updater bot e8f67bc817 Localisation updates from https://translatewiki.net.
Change-Id: I75e00c648752831d320568296aceee673b5ed640
2018-04-16 22:11:50 +02:00
Translation updater bot 70c89fc796 Localisation updates from https://translatewiki.net.
Change-Id: If27c034a93b534a3b81e0d5d796022ef0cd9d5b4
2018-04-15 22:23:10 +02:00
Translation updater bot 2c964f88d8 Localisation updates from https://translatewiki.net.
Change-Id: I5cba0cc6186aa3547b265a2ecb070b6938ebe586
2018-04-14 22:13:32 +02:00
Translation updater bot 937a920b05 Localisation updates from https://translatewiki.net.
Change-Id: Ia0263466946cd70657abdad9869a3cc62b0a9f6e
2018-04-13 22:12:34 +02:00
Glaisher 7fade990d2 Don't allow invalid IP ranges to be entered in ip_in_range()
IP::isInRange() can return true for invalid IPs so this can
cause false positives. Instead of letting this happen, don't
allow it in the first place.

See also Ibfe55c2ebac0fccfa8329436

Bug: T124117
Change-Id: Id10552e117ce2b231504e41627b44f8cfb0d4329
2018-04-13 10:59:08 +02:00
Translation updater bot 62f0a51bdb Localisation updates from https://translatewiki.net.
Change-Id: If10f4ff0f6c802c3cf627b4eee0040ab87a1cfa1
2018-04-11 22:39:47 +02:00
jenkins-bot c10f61f623 Merge "Properly detect unclosed comments" 2018-04-11 00:02:35 +00:00
Translation updater bot 8d43289ced Localisation updates from https://translatewiki.net.
Change-Id: I00e4588f7a345f32c524c4a872999d1db7c627f2
2018-04-10 22:14:59 +02:00
Daimona Eaytoy 73ec0d7896 Properly detect unclosed comments
Right now we don't have a specific exception for that, plus we don't
really check if they're closed. In fact, we use the result of strpos
without checking if it evaluates to false; if so, in some particular
cases like the one reported on phab, the while loop will never end.

Bug: T134124
Change-Id: I3b6000f197502a4832a53465b6617b4217080739
2018-04-10 19:26:02 +02:00
Translation updater bot 4465089c02 Localisation updates from https://translatewiki.net.
Change-Id: I74317b62b4f64c794af8ee94aff4998c00b04f41
2018-04-09 23:16:39 +02:00
Translation updater bot e44d21c73d Localisation updates from https://translatewiki.net.
Change-Id: I85f095ad5902b4a2924f1ceb40f6a226e36cc323
2018-04-08 22:29:35 +02:00
Translation updater bot 4b80ecdb1e Localisation updates from https://translatewiki.net.
Change-Id: Ibebd3033d5f8c7f7c8f86e77092a3840ece0770f
2018-04-07 22:33:56 +02:00
Translation updater bot 0f65f1758e Localisation updates from https://translatewiki.net.
Change-Id: If5d6248933ef360f29635879e3c2e085daa58075
2018-04-06 22:19:56 +02:00
jenkins-bot eb066b4f6f Merge "Add missing messages for existing vars decriptions" 2018-04-06 01:25:27 +00:00
Translation updater bot 5711139849 Localisation updates from https://translatewiki.net.
Change-Id: I36d19857c8ed26c9d1800520f0551556226fe2d6
2018-04-05 22:22:06 +02:00
Matěj Suchánek 60f4777c8c Add missing messages for existing vars decriptions
Change-Id: Ifd418c0efbcf7c21b4013d6b8a7454950d15def6
2018-04-05 11:24:49 +02:00
Daimona Eaytoy bc99694d07 Add reasons dropdown to hidelog form and convert it to OOUI
Bug: T153018
Bug: T132284
Change-Id: Idf74765d9f5c475d2e0d48d546cdf7c1aaa99104
2018-04-05 00:08:49 +00:00
Translation updater bot c2ab53e509 Localisation updates from https://translatewiki.net.
Change-Id: Ief4f5a2f7c24c2b545c723046259dd369add1cd0
2018-04-04 22:49:11 +02:00
jenkins-bot e4fa51e209 Merge "Remove my previous username from list of authors" 2018-04-04 11:30:28 +00:00
Translation updater bot 992f094731 Localisation updates from https://translatewiki.net.
Change-Id: Idbe5aa2c5a9469124a74e649e21fe65d0445ac63
2018-04-03 09:50:04 +02:00
Guycn2 178b9da668 Remove my previous username from list of authors
Change-Id: I5eb6ea9323967ed13e7ec2b876325334e5cf5e8e
2018-04-03 02:39:35 +00:00
jenkins-bot 9cf6a4b407 Merge "Add missing comparisons to builderValues" 2018-04-02 21:34:32 +00:00
Daimona Eaytoy fbde96cac6 Add missing comparisons to builderValues
Currently, strict comparisons aren't listed. This way they don't appear
in the dropdown and users may not be aware of their existence.

Change-Id: I93185781de3b698096130c673156a67823375c6b
2018-04-02 17:12:32 +02:00
Daimona Eaytoy e53811ecb3 Add requirement for title and pattern fields
Currently users can save filters without title or pattern. This
shouldn't be allowed since it leads to lack of clarity. The check is
only performed server-side, since when implementing Ace editor we won't
be able to (easily) add a pure HTML requirement for the pattern field.

Bug: T173947
Change-Id: I1a0418b87cdb1ff423238fcdf1c743930500e605
2018-04-02 16:37:51 +02:00
Translation updater bot 6a518a7d6b Localisation updates from https://translatewiki.net.
Change-Id: Ife6051a2853337900e222381f64f0125cf1ffbef
2018-04-02 09:48:06 +02:00
Translation updater bot ba5e619517 Localisation updates from https://translatewiki.net.
Change-Id: I187543cb3efb18af4dcccf0d0101da06aeda23be
2018-04-01 09:37:42 +02:00
Translation updater bot 8e80401487 Localisation updates from https://translatewiki.net.
Change-Id: Ie7b9e29cbc928194e6b5962eac3877145eff3c89
2018-03-31 09:22:11 +02:00
jenkins-bot c67ab4a061 Merge "Revert "Revert "Switch editor to Ace and provide syntax highlight""" 2018-03-30 15:29:01 +00:00
Daimona Eaytoy 3350183fe3 Revert "Revert "Switch editor to Ace and provide syntax highlight""
Make Ace use a fixed size in em.

This reverts commit 272775ff81.

Change-Id: I9b439b20df91eb367bcef4b6f33ff087aded0b62
2018-03-30 11:10:16 -04:00
jenkins-bot ef65bf62c9 Merge "Convert /revert to use OOUI" 2018-03-30 14:02:12 +00:00
Translation updater bot 77d92a05fa Localisation updates from https://translatewiki.net.
Change-Id: I4e93bb9a0b12893d877ef1c5ce142a7fcf8b6672
2018-03-30 09:33:46 +02:00
Daimona Eaytoy 90436c9e59 Convert /revert to use OOUI
This one was left out, probably because it's not well documented.
Together with the simple conversion, I also added a cap to time
selectors (otherwise users may create huge breaking queries) and wrapped
in a class=success P the success message, like we do when saving
filters.

Bug: T132284
Change-Id: I2ba0a54e27608949cd28b9ac0447d1f2157b0ea2
2018-03-30 09:12:59 +02:00
jenkins-bot 899fd5783b Merge "Revert "Switch editor to Ace and provide syntax highlight"" 2018-03-30 02:14:15 +00:00
Huji 272775ff81 Revert "Switch editor to Ace and provide syntax highlight"
This reverts commit 89e6778793.

Change-Id: I41aee10fdd5633d56692334696fb750f41b15433
2018-03-30 02:07:00 +00:00
jenkins-bot f903aa92d4 Merge "Switch editor to Ace and provide syntax highlight" 2018-03-30 02:02:00 +00:00
jenkins-bot da3342e398 Merge "Add search for filter patterns" 2018-03-30 01:32:03 +00:00
Translation updater bot e712281558 Localisation updates from https://translatewiki.net.
Change-Id: Ic7544f277b91ab5ea4d5d2246dd577e844aed566
2018-03-28 22:22:36 +02:00
Translation updater bot 6193345739 Localisation updates from https://translatewiki.net.
Change-Id: Iad1101b331cd204cb2d20994dbd334b4eaaebcce
2018-03-27 22:09:08 +02:00
Translation updater bot 842990b81c Localisation updates from https://translatewiki.net.
Change-Id: I4c81a2f04b0fed111b4cbfcd3da5e16b6fbb2246
2018-03-26 22:18:44 +02:00
Translation updater bot e18cd9b92d Localisation updates from https://translatewiki.net.
Change-Id: Idfa95d3e9c8d2bcbb17ae927f8d29d531b2cd1a5
2018-03-24 22:29:11 +01:00
Translation updater bot 98fbe59540 Localisation updates from https://translatewiki.net.
Change-Id: Ib15f0ba901d51cc869b8738b3cc8629c9d5f084c
2018-03-23 22:12:53 +01:00
Daimona Eaytoy 89e6778793 Switch editor to Ace and provide syntax highlight
Replace the conditions textarea with Ace editor for editing and testing
filter. This uses a soft dependency on CodeEditor; if the latter isn't
installed, the classic textarea is used. The user is still able to
switch between the editors on the go; the new buttons may look a bit
ugly now, but after switching to OOUI they should get much better.
Finally, added a custom syntax highlight for AbuseFilter rules.

Bug: T39192
Change-Id: If3d6a994142e34686bb7fc9f09093f751b599485
2018-03-23 12:39:22 +01:00
Translation updater bot 587b1d91f0 Localisation updates from https://translatewiki.net.
Change-Id: I52f631043738f18ead7cb20f985456b85ba7d259
2018-03-22 22:08:38 +01:00
Translation updater bot 9d97af45ab Localisation updates from https://translatewiki.net.
Change-Id: I3fb617b075f8b06fa20d7c993281ec4b7740846e
2018-03-21 22:31:52 +01:00
Translation updater bot b3f799408f Localisation updates from https://translatewiki.net.
Change-Id: I884f972ab5b3491917713bf8aaf7d522add0e428
2018-03-20 22:12:32 +01:00
Translation updater bot e09479bb62 Localisation updates from https://translatewiki.net.
Change-Id: I296e4dbeda5468307925af91265e5947e710745b
2018-03-19 22:18:33 +01:00
Amire80 03c1a80f92 Clarify bad-tags message: "must" is more precise than "should"
Change-Id: I8ae4505cbe263bdb413b47ac24e84d9b1f9c5d43
2018-03-18 12:30:23 +00:00
Daimona Eaytoy 3bc4bfc4d5 Add search for filter patterns
Adds an option for searching filters with a
specific pattern in the main page, together with already existing options.
Plain search and regex are available, only for users with the
view-private right. The search is performed directly on the database.
If the user actually searched for something, it is also added a column to
Special:AbuseFilter showing a snippet of the pattern from each filter, with the query match highlighted.

Depends on: I8144062b1f273d0d8932203ffcb7a71aca60bba9

Bug: T87455
Change-Id: Ibcd84ff84edca481328210ee857b0ab723028632
2018-03-17 14:54:48 +00:00
Translation updater bot 0b58de551b Localisation updates from https://translatewiki.net.
Change-Id: Ib29bf3885c791eba63106f8e1d4e30f33957a1f2
2018-03-15 22:51:35 +01:00
Translation updater bot 93209b3d2c Localisation updates from https://translatewiki.net.
Change-Id: I89887dacfdd12f19da7ec9411e0c4e3d0d009820
2018-03-14 22:23:18 +01:00
Translation updater bot 53a370b688 Localisation updates from https://translatewiki.net.
Change-Id: Ic03e10e79101fe7523faa2a773bb2b37ef165b59
2018-03-13 22:23:05 +01:00
Translation updater bot 0a7a7cf3a0 Localisation updates from https://translatewiki.net.
Change-Id: Ib44a5368a46b86ab67a3ff804665aacc3de57f76
2018-03-12 22:24:41 +01:00
Translation updater bot cc5c4ee125 Localisation updates from https://translatewiki.net.
Change-Id: I566728894fa07611c76f8587e74eeb63c098f599
2018-03-11 22:30:24 +01:00
Translation updater bot c17a096989 Localisation updates from https://translatewiki.net.
Change-Id: I97af0059e445a7b3739128f794e2a9ba08fbb101
2018-03-10 22:13:45 +01:00
Translation updater bot a926e420e7 Localisation updates from https://translatewiki.net.
Change-Id: I4ccb673735f5e3c7b733d7e97f51c4c7dae64e85
2018-03-09 22:41:50 +01:00
jenkins-bot e24c025670 Merge "Allow customizing block durations for each filter" 2018-03-09 03:27:15 +00:00
Translation updater bot 30d8b8a30e Localisation updates from https://translatewiki.net.
Change-Id: I5dc2d8cab384bc9d71ce64e2c893d7ac433b52f3
2018-03-08 22:45:23 +01:00
Daimona Eaytoy 2dd8d27c34 Allow customizing block durations for each filter
This is part of a project to enchance blocking in AF. With this patch,
users are allowed to specify two block durations for each filter, one
for anonymous and one for registered users. For backward compatibility,
default values are set to the global variables.

Bug: T32024
Change-Id: Ib072433d19dabae48d8514e08be9893135b5d63c
2018-03-08 14:57:16 +01:00
Translation updater bot d9f0bf1ff0 Localisation updates from https://translatewiki.net.
Change-Id: I1852a73baf15ae2e8ffddd098797a6305c7580d8
2018-03-07 22:47:02 +01:00
Translation updater bot 07f6fce156 Localisation updates from https://translatewiki.net.
Change-Id: I37725780433b0ec6ec6fe0c0f119ffd198adf51f
2018-03-06 22:18:22 +01:00
jenkins-bot 04b1d121c9 Merge "Tag actions which hit the condition limit" 2018-03-06 02:08:08 +00:00
Translation updater bot 6a026f5bd8 Localisation updates from https://translatewiki.net.
Change-Id: I99d6ef73778ddad4337255b88491cc3ad245de20
2018-03-05 22:24:11 +01:00
jenkins-bot 7f4b69df1e Merge "Add userLinks in private details page" 2018-03-05 16:03:25 +00:00
Daimona Eaytoy 6e42340af9 Add userLinks in private details page
The IP is currently displayed as plain text. Add instead userLinks in
the usual way to provide some handy links for CUs.

Bug: T188600
Change-Id: I47ee007f450f06a1a19b4c7598373a952efbe06a
2018-03-05 11:52:41 +01:00
Matěj Suchánek d138b2877c Add form field to filter history by filter
So that users have no longer to modify the URL.
Links like "Special:AbuseFilter/history/1" will still
work but request parameters have higher priority.

Bug: T27897
Change-Id: I2d8c26d3350fdd4052b68c7bced10e3fae859d18
2018-03-04 18:11:21 +00:00
Translation updater bot 5f55b7d068 Localisation updates from https://translatewiki.net.
Change-Id: Ib85a9185601940b0e0fd4186024b794f17d181f6
2018-03-03 22:24:53 +01:00
Translation updater bot 528856cb72 Localisation updates from https://translatewiki.net.
Change-Id: I920122529718b8c244ddd8bfc8864c963a0451d8
2018-03-02 22:30:46 +01:00
Translation updater bot fb8a3b4390 Localisation updates from https://translatewiki.net.
Change-Id: Iefefc863a1db07bba65a4d235c0f186394111200
2018-03-01 22:41:34 +01:00
Translation updater bot 1c46161912 Localisation updates from https://translatewiki.net.
Change-Id: If699bcee819287832c9e09e4b8f1d610eabeb8b7
2018-02-28 22:27:08 +01:00
Translation updater bot 91d5dfec8c Localisation updates from https://translatewiki.net.
Change-Id: Ibe939e91e322e97f2cdde70cce13801a914b1624
2018-02-27 22:25:19 +01:00
Huji Lee a83b10c5ed Add option to block a user from editing their own talk page
Bug: T170014
Change-Id: I74b7fd2e036111583e8b69c355e7fb0c51fe67fc
2018-02-27 17:07:51 +00:00
Translation updater bot 24a2518f02 Localisation updates from https://translatewiki.net.
Change-Id: I53513a4fce6a620fdd76f3f844be0172b088f1df
2018-02-26 22:20:07 +01:00
Translation updater bot 3b04981f72 Localisation updates from https://translatewiki.net.
Change-Id: I514f6cf725c7af64c74145e6b8cf12dfa14edf84
2018-02-25 22:33:35 +01:00
Matěj Suchánek d19ced4cef Filter AbuseLog by the "impact" of the change
Users can choose whether they want to see entries
that changed the wiki or didn't (or they can apply
no filter).

Bug: T159061
Change-Id: I6cee9b001c26c4bbc837131781deef27d5e3ef1a
2018-02-24 15:25:50 -05:00
Matěj Suchánek 6f1e15c5ff Filter Special:AbuseLog by action taken by filters
Bug: T187971
Change-Id: I4c786ac312b9095f3055622677b78c2ce7be6b0c
2018-02-24 14:49:39 +01:00
Translation updater bot bdf81c1467 Localisation updates from https://translatewiki.net.
Change-Id: I49124ebb8595c17a797fe33e1623094e8e71d080
2018-02-23 23:01:07 +01:00
Translation updater bot 9177569d58 Localisation updates from https://translatewiki.net.
Change-Id: Ifb8ffdecd3b1463de9650c5c51a24141a21d1aa8
2018-02-22 23:21:35 +01:00
Translation updater bot c411452ceb Localisation updates from https://translatewiki.net.
Change-Id: Id8803ff622d597752a3e718259a1ae595f25a920
2018-02-20 22:28:35 +01:00
Translation updater bot f5de7846cd Localisation updates from https://translatewiki.net.
Change-Id: If0e5120542b282fcb5997d1e0079835937618148
2018-02-19 22:25:16 +01:00
Translation updater bot 384891be7b Localisation updates from https://translatewiki.net.
Change-Id: I929d6e269b74967cf45817024bb9549909f0f58d
2018-02-18 22:40:05 +01:00
Translation updater bot b0ba7060c7 Localisation updates from https://translatewiki.net.
Change-Id: Iad253b4fc322c5104377cb57d14c8f3fa1894036
2018-02-17 22:27:10 +01:00
Translation updater bot 8dfe2ec16c Localisation updates from https://translatewiki.net.
Change-Id: Iff47324b4af2feb26da3a1bb640bddeb33e4bb91
2018-02-16 22:28:45 +01:00
Translation updater bot 512eaa40b4 Localisation updates from https://translatewiki.net.
Change-Id: I8b0027447b89a1ae50ff6cbe223a72a075df5ead
2018-02-15 22:46:56 +01:00
MarcoAurelio 87aac2397f Add missing 'action-abusefilter-private-log' message
Used by MediaWiki to tell unauthorized users why they are not allowed to
view the AbuseFilter private details access log.

Change-Id: Ic6f8d82d377aa4b98048fd19e662e6ed3828c923
2018-02-15 16:46:06 +01:00
Matěj Suchánek 3f34308f96 Tag actions which hit the condition limit
When an action reaches the limit, the remaining filters are not executed.
But there is no way find out which one it was.

Bug: T71492
Change-Id: I28fac76d4e9ca341bed25cd35e1249b19586b773
2018-02-15 10:06:08 +01:00
Translation updater bot 748e11e904 Localisation updates from https://translatewiki.net.
Change-Id: I6fe0d97b5eaa2cc3abcb4cc8ab1fa2bd1253768f
2018-02-14 22:30:20 +01:00
Translation updater bot 421f4dcae1 Localisation updates from https://translatewiki.net.
Change-Id: I3e90a3983a66fcb79a70ad67905512dcb53a7821
2018-02-13 22:25:07 +01:00
Translation updater bot 3e01f8523d Localisation updates from https://translatewiki.net.
Change-Id: Ie1d89503e2cc0eeec5f598e650ca0d34569e702d
2018-02-12 09:23:27 +01:00
Translation updater bot 8e26712bb1 Localisation updates from https://translatewiki.net.
Change-Id: I1c3f6e9a1985e73f3f9155015d0a6ad025886a1f
2018-02-11 10:41:53 +01:00
Daimona Eaytoy f0cf1f227f Fix wrong name in i18n
In Ib0a8b783db6ce0d5db64771c8e0c70f0f8d13d36 I misspelled the name of a
function in i18n, resulting in a duplicate.

Change-Id: I8547a3d8f1ef29713c5cd957d99c47b3e3daa2e3
2018-02-10 11:35:06 +01:00
Translation updater bot aa21d18c2d Localisation updates from https://translatewiki.net.
Change-Id: I5e4cb3e6f4f9a156608cb853ff3522ca5e219a8d
2018-02-10 09:15:09 +01:00
jenkins-bot ac83ad1d90 Merge "Add contains_all and ccnorm_contains_all functions" 2018-02-09 18:08:35 +00:00
Daimona Eaytoy a0de056299 Add contains_all and ccnorm_contains_all functions
Added the contains_all function, with basically the same role as
contains_any but using logic AND instead of OR. Also added
ccnorm_contains_all, that is the same of ccnorm_contains_any but with
AND mode. Finally, fixed three wrong task IDs.
Co-authored with Valerio Bozzolan.

Bug: T21176
Change-Id: Ib0a8b783db6ce0d5db64771c8e0c70f0f8d13d36
2018-02-09 17:33:24 +01:00
Translation updater bot 68adcaad7c Localisation updates from https://translatewiki.net.
Change-Id: I955f3559442f0125171bbf1ae19c001d884eb2a7
2018-02-09 09:41:00 +01:00
Translation updater bot dcdce750ab Localisation updates from https://translatewiki.net.
Change-Id: I798d2cb55b4dc4343c99bb5c8b9fb39e40740e51
2018-02-07 22:17:14 +01:00
Huji Lee 146820185c Log accessing private information in abuse filter logs
Bug: T152934
Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2018-02-07 18:35:36 +00:00
Translation updater bot ec580f7ff1 Localisation updates from https://translatewiki.net.
Change-Id: Ia10997bce6e7c11810d163d34012f6931639dca6
2018-02-06 22:35:11 +01:00
Translation updater bot ae08366138 Localisation updates from https://translatewiki.net.
Change-Id: I4b58226e01316f6371164c72b6215c4e31067dd4
2018-02-05 22:36:39 +01:00
jenkins-bot c84da3552e Merge "Allow filtering AbuseLog in API by wiki" 2018-02-05 05:06:23 +00:00