Commit graph

4288 commits

Author SHA1 Message Date
Daimona Eaytoy 4f3b020f5d Improve code coverage for AbuseFilterParser
Add some tests and improve others to raise coverage percentage. This
should lead to almost 100% for the AbuseFilterParser class. Aside from
this, a couple of changes:
* Remove an unused function
* Let equals_to_any return a genuine result with empty strings
* Remove an if which will never be true in skipOverBraces, since the
function is called after checking the same conditions.

Bug: T201193
Change-Id: I7020b2ed996236c38c5784d161ad98ec44163406
2018-08-20 14:38:40 +02:00
jenkins-bot 50a295a6e7 Merge "Include CheckUser in phan config" 2018-08-20 01:52:54 +00:00
Translation updater bot 50ff368194 Localisation updates from https://translatewiki.net.
Change-Id: Id215438322326b4954ccd3413b583c3dd472b102
2018-08-19 22:38:41 +02:00
jenkins-bot 55f0cd2580 Merge "Change priority order for messages in hidden abuselog entries" 2018-08-19 19:21:41 +00:00
Daimona Eaytoy b8645753ca Remove deprecated method in AbuseFilterVariableHolder
It was soft-deprecated in 2013 and nothing is using it in MW code.

Change-Id: I1300bb18c518b61a2dbce9ad43beeb69c1b615e5
2018-08-19 19:02:45 +02:00
Daimona Eaytoy 9d21c7d03d Change priority order for messages in hidden abuselog entries
Check if the entry is deleted first, since it's the strongest deletion
here (oversight level). Bonus: don't use implicit conversion when
checking the return value of SpecialAbuseLog::isHidden.

Bug: T200644
Change-Id: Ie5c4575ad29fe3dcb85a26cc74f1c59207df2852
2018-08-19 18:22:07 +02:00
Translation updater bot 01df24418a Localisation updates from https://translatewiki.net.
Change-Id: Ia99e4123423cad2fbb0e8b15e8f20d6879cc89f5
2018-08-17 23:36:22 +02:00
Umherirrender c954b412c6 Include CheckUser in phan config
Depends-On: I51421184485c3117bbab9ce3dd42f2dbb6c6180c
Change-Id: Ida17580b301ff4a6b0d3d0020c48f65eb1e21026
2018-08-17 17:38:01 +02:00
Translation updater bot a79dbf5488 Localisation updates from https://translatewiki.net.
Change-Id: Ifab4d658d65b2abee003fc0e8d31fb61538e77be
2018-08-16 22:28:09 +02:00
Daimona Eaytoy bb476e2c45 Fix wrong error message for PHPUnit
We're currently emitting the same error twice, but in one of those cases
it's completely wrong. Damned copy&pasting!

Bug: T202073
Change-Id: I7687826a85f3ef0abaf15d7cd973afc4e55758b2
2018-08-16 17:11:41 +00:00
Translation updater bot 0c496d0118 Localisation updates from https://translatewiki.net.
Change-Id: Id6f137359ab5718087a95d01d65e22c484d5b511
2018-08-15 22:18:15 +02:00
Translation updater bot 2148d06632 Localisation updates from https://translatewiki.net.
Change-Id: Iafe001dca01005c6ab5337738a8e9463773bd2be
2018-08-14 22:34:47 +02:00
Brian Wolff 429b7c6705 Update phan-taint-check to 1.3.0. Hopefully should pass now
Change-Id: If8f78dd08152b68e534cdb72704ccbd81afbd822
Bug: T197002
2018-08-13 23:57:29 +00:00
Translation updater bot 825e5939b4 Localisation updates from https://translatewiki.net.
Change-Id: Ib987d0e1eb5616ce01e57ac8418fae91f373d6a2
2018-08-13 22:14:00 +02:00
Translation updater bot 20f4fb9a8c Localisation updates from https://translatewiki.net.
Change-Id: If8f78dd08152b68e534cdb72704ccbd81afbd898
2018-08-12 22:17:08 +02:00
Translation updater bot 2716696221 Localisation updates from https://translatewiki.net.
Change-Id: I455d6d615d20dc3428eaeb16e95cee280c1b9207
2018-08-11 22:17:14 +02:00
Translation updater bot a3c9c8f5f1 Localisation updates from https://translatewiki.net.
Change-Id: Icff2ffe9422a34ade18bb55b2be3b24cdcc7eb4d
2018-08-10 22:17:58 +02:00
jenkins-bot e129650125 Merge "Add PHPUnit tests for various generic functions" 2018-08-09 20:44:09 +00:00
Translation updater bot 063ea65758 Localisation updates from https://translatewiki.net.
Change-Id: I9810aaddda0ec958d98ab3d2e0dadf9d693d864b
2018-08-09 22:23:18 +02:00
Daimona Eaytoy 0026a68a8a Add PHPUnit tests for various generic functions
Adding tests for generic functions in AbuseFilter class, ranging from
simple utility function to variable computation.

Bug: T42478
Change-Id: I903fb7ffbc436b27462e3e4611ab65ecb8a543ba
2018-08-09 19:20:46 +00:00
Translation updater bot cd0e28be12 Localisation updates from https://translatewiki.net.
Change-Id: I4f641e18316762a57b36d3b61adc67723bfbff31
2018-08-08 22:13:03 +02:00
Translation updater bot b3555fab56 Localisation updates from https://translatewiki.net.
Change-Id: Iba209b3478c2da06ed9891ad74f416afc3a5d993
2018-08-07 22:31:06 +02:00
Translation updater bot 94c33ddbc3 Localisation updates from https://translatewiki.net.
Change-Id: Ideb82bed16e01eec2af4ee1fcb2e3890fec763e0
2018-08-06 22:20:49 +02:00
Translation updater bot 976a0a2fa5 Localisation updates from https://translatewiki.net.
Change-Id: Id9db4f217b5752e883775ba2a1391423220a13b4
2018-08-02 22:19:08 +02:00
jenkins-bot 4b185b3749 Merge "Add phpunit tests for noparams and notenoughargs exceptions" 2018-08-02 08:41:46 +00:00
jenkins-bot f587230fea Merge "Use noparams exception and correctly count function parameters" 2018-08-02 08:16:12 +00:00
jenkins-bot 75729b6195 Merge "Add other phpunit test for AFPUserVisibleException" 2018-08-02 08:07:56 +00:00
Translation updater bot 7d9e345953 Localisation updates from https://translatewiki.net.
Change-Id: Iaec408a00dd6afa0c54560ab994353f5e6303a25
2018-08-01 22:10:07 +02:00
jenkins-bot c876f98d67 Merge "Remove HitCounters from AbuseFilter and use hooks instead" 2018-07-31 20:57:42 +00:00
Translation updater bot 2c85c70e91 Localisation updates from https://translatewiki.net.
Change-Id: Ia4f4fb6b89244a09bc3037ff67f16a104383e1e1
2018-07-31 22:32:39 +02:00
Huji Lee df21fb2b20 Remove HitCounters from AbuseFilter and use hooks instead
Goes with Ief573fb412d332bd4ad6ad8de3052dd85d534b82

Bug: T159069
Change-Id: I38cd7cbf3e595890b53624a477010bd49c9b8552
2018-07-31 03:56:20 +00:00
Translation updater bot c6e6cc7d56 Localisation updates from https://translatewiki.net.
Change-Id: If552b5a58456e5418eb758ce22b0f6add4373100
2018-07-30 22:27:44 +02:00
Kunal Mehta 404e098c3b Fix MediaWiki.Usage.InArrayUsage.Found issues
Change-Id: I1898d95d92cda279c1b9c8a452fb7d054ff263bf
2018-07-29 15:19:09 -07:00
Translation updater bot 1c124ba77a Localisation updates from https://translatewiki.net.
Change-Id: I89dbd13e0fc5a68fb87d13548f33a1f86a9530a4
2018-07-29 22:20:56 +02:00
Translation updater bot f23810d44a Localisation updates from https://translatewiki.net.
Change-Id: Id8ca108c7d02d883c7dee11aaebac4c3be07b679
2018-07-28 22:29:13 +02:00
jenkins-bot 35a9f7d209 Merge "Fix jQuery selector when editing filters" 2018-07-28 14:01:54 +00:00
Matěj Suchánek 37908c7935 Fix jQuery selector when editing filters
Bug: T200604
Change-Id: Ife88ae0f4b9dca0492c1d9dbfc22a975dd7b6b31
2018-07-28 15:23:14 +02:00
Translation updater bot 2e433238b6 Localisation updates from https://translatewiki.net.
Change-Id: I7639c54d3138505ce9bd9f6643a2c981f6fa72c7
2018-07-27 22:17:21 +02:00
tinajohnson.1234 c9003fe1fa Use HistoryPageToolLinks hook to add a log link to history pages
Add an AbuseFilter log link to the subtitle of history pages.

Bug: T28934
Co-authored-by: Matěj Suchánek
Depends-On: I2e0e9e92d3fc303135b0eb9acf06b5fd120178a5
Depends-On: I58a3039b3755648bb0c8aaf87db48ace96ce9344
Change-Id: Ib89c48f2b8f3121ead184844844acee436e2fdd6
2018-07-27 11:25:12 +00:00
jenkins-bot eee65af0ac Merge "build: Updating mediawiki/mediawiki-codesniffer to 21.0.0" 2018-07-27 01:21:01 +00:00
jenkins-bot 55d825c325 Merge "Use empty arrays instead of empty strings for diffs" 2018-07-27 00:55:40 +00:00
libraryupgrader 76c6d2caeb build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation
* MediaWiki.Usage.InArrayUsage.Found

Change-Id: I46e414246c6597dd78b069f753d686c0d1c1c09d
2018-07-27 00:27:11 +00:00
jenkins-bot 78bd634f58 Merge "Add link to abusefilter-edit-lastmod-text" 2018-07-26 22:56:07 +00:00
jenkins-bot 03ffcb0ff9 Merge "Fix block durations dropdown" 2018-07-25 20:24:30 +00:00
Translation updater bot c785e87f6d Localisation updates from https://translatewiki.net.
Change-Id: Iee2c94ed4667239ddf33e430deda640151995198
2018-07-25 22:17:47 +02:00
Translation updater bot a68b741060 Localisation updates from https://translatewiki.net.
Change-Id: I1d0e2e6fc7c21be3d6b80f1d8041d8fcf57c7d67
2018-07-24 22:09:37 +02:00
jenkins-bot d7a5872838 Merge "Add phpunit tests for creating and editing filters" 2018-07-24 16:04:04 +00:00
Daimona Eaytoy 7992349789 Fix block durations dropdown
A month ago SpecialBlock::getSuggestedDurations has been
modified, and now it also returns an "other" key. Since we don't need it
and it would break thing up, add a parameter to avoid dealing with that.

Depends-On: Ic2dbc961f7eebad11da53724b9cce2f804ffad39
Change-Id: Ica37ba7015a04445c2cbafebcc85726368e23cb0
2018-07-24 15:41:57 +00:00
Translation updater bot 35c4590a34 Localisation updates from https://translatewiki.net.
Change-Id: I2fae6e45e7626e55163f3ad648eb148c7b354da0
2018-07-23 22:30:53 +02:00
Translation updater bot 40eea41ca6 Localisation updates from https://translatewiki.net.
Change-Id: Iabc1ef6c5120fcb7cb26e2783596b5d3b6adad47
2018-07-22 22:08:23 +02:00